August 2005 - Wine-Devel - list.winehq.org

WINEALSA: remove crackling in DirectSound/ALSA combination (try 2)

by Alex Villacís Lasso

Alex Villacís Lasso wrote: > For a long time, I have been annoyed by a faint crackling that can be > heard on the sound output of any DirectSound program when full > hardware acceleration is enabled on the ALSA driver. Even after a > patch I sent earlier (which corrected a bigger artifact), this > crackling remained. Last night, I finally set upon removing this > crackling, based on a comment in IDsDriverBufferImpl_GetPosition() in > dlls/winmm/winealsa/audio.c, line 3302: > > //* /*FIXME*/: snd_pcm_mmap_hw_ptr() should not be accessed by a > user app. *// > //* It will NOT return what why want anyway. *// > hw_ptr = _snd_pcm_mmap_hw_ptr(wwo->pcm); > > I thought, maybe it is not returning the correct information for > GetPosition, so that is why the crackling exists, since new samples > are off-position from what they should be in order to guarantee a > smooth sound. So I deduced, maybe the IDsDriverBufferImpl object can > keep a simulation of a hardware pointer and use that instead of the > (slightly incorrect) hardware pointer. My original intention was to > remove entirely the need to reference _snd_pcm_mmap_hw_ptr(), since > this is obviously an internal alsa-lib function and should not be used > from inside the app (as the comment rightly indicates). However, I > found out that the simulated hardware pointer tends to lag behind the > real hardware pointer, and horrible mixups happen if the difference > approaches or exceeds the length of the mmap buffer. So the simulated > pointer is loosely kept close to the hardware pointer in the supplied > patch. > > The good news: the patch sort of works (in my setup, at least, with > Fedora Core 4). All the games I have (Japanese RPGs) now have smooth > sound, unless the CPU load is too high. > The bad news: the patch does nothing to make the dsound tests pass in > Wine (but they were already failing before the patch :-) > > Alex Villacís Lasso > > Changelog: > * Remove crackling in DirectSound/ALSA playback with full hardware > acceleration > Reading through my own previous explanation, I realized that the original crackling problem lies in the fact that the hardware pointer is ahead of the proper position for mixing. So, if the hardware pointer is set back by a fixed amount before reporting in GetPosition, this crackling could be fixed without resorting to the simulated pointer hack. The attached patch does just this. It is an one-line fix, and solves the problem just as well as the original patch, without being as sensitive to CPU usage as the first patch. So please ignore the previous patch and use this one instead. Alex Villacís Lasso Changelog: * Remove crackling in DirectSound/ALSA playback with full hardware acceleration

Aug. 11, 2005

Re: PATCH: GlobalAddAtomA check for invalid ptr

by Alexandre Julliard

Marcus Meissner <marcus(a)jet.franken.de> writes: > So ... now we can: > > - fix this program by contacting the developers etc... which is difficult. > - fix WINE by adding a check. > > I can only fix WINE. Yes, but please don't use the IsBad* functions, use a proper exception handler. -- Alexandre Julliard julliard(a)winehq.org

Aug. 11, 2005

Re: [DSHOW] Beginning of winestreambase lib (take 2)

by Alexandre Julliard

Christian Costa <titan.costa(a)wanadoo.fr> writes: > This patch has not be applied yet. Is there anything wrong with it? > I was also considering turning it into a dll rather than a static > lib. Do you think it's a good idea? No, I don't think it should be a dll. I think it should be named strmbase and should export the exact same things as Windows, modulo C/C++ differences of course. This means the data structures and global functions should be the same, the C interfaces should use the same name as the equivalent C++ classes, etc. and it shouldn't export extra things like the qzdebugstr functions. -- Alexandre Julliard julliard(a)winehq.org

Aug. 11, 2005

Re: [DSHOW] Beginning of winestreambase lib (take 2)

by Christian Costa

Christian Costa wrote: > > Hi, > > This time, with winestrmbase renamed to winestreambase as suggested by > Dimi. > > Changelog: > Add winestreambase library and make quartz use it. > > Christian Costa titan.costa(a)wanadoo.fr > This patch has not be applied yet. Is there anything wrong with it? I was also considering turning it into a dll rather than a static lib. Do you think it's a good idea? Christian

Aug. 11, 2005

Re: Delete Dll(Un)RegisterServer in d3dxof.dll?

by Christian Costa

Francois Gouget wrote: > Hi, > > I'm relaying a question from Vincent Béron: we both had a look at the > winapi_check output and noticed that the comments of these functions > claim they are exported but in fact they are not: they are not > mentioned anywhere in the spec file. > > Now if I look at the APIs exported by d3dxof.dll on various versions > of Windows I don't see these APIs either. However it's possible that > they are only exported in recent versions of DirectX and I'm not sure > the DirectX dlls I have are that recent. > > So I think the question boils down to this: should the > Dll(Un)RegisterServer functions be removed or should they be exported? > All d3dxof dlls I have seen so far do not export them so I didn't put them in the spec (but forgot to removed the regsvr.c file). I don't know how d3dxof objects are registered in Windows but the wine.inf should be a good place for that.

Aug. 11, 2005

Re: setup of the MinGW environment

by Hans Leidekker

On Thursday 11 August 2005 11:30, Saulius Krasuckas wrote: > Sadly I miss miss one file from the site [1] and seems to be down. The > file is called "mingw-binutils-2.15.94-8hl.i386.rpm". Any chances for the > site to get up and running? It's up and running again. -Hans

Aug. 11, 2005

setup of the MinGW environment

by Saulius Krasuckas

Sadly I miss miss one file from the site [1] and seems to be down. The file is called "mingw-binutils-2.15.94-8hl.i386.rpm". Any chances for the site to get up and running? [1] http://mirzam.it.vu.nl/mingw/

Aug. 11, 2005

Awdbedit crashes, wine debugger fails to run aswell.

by Hans Kristian Rosbach

Using wine compiled from CVS yesterday. Awdbedit is available here: http://awdbedit.sourceforge.net/ $ wine awdbedit.exe err:rebar:REBAR_AdjustBands Phase 1 failed, x=32760, maxx=632, start=0, end=0 err:rebar:REBAR_AdjustBands Phase 1 failed, x=32760, maxx=632, start=0, end=0 wine: Unhandled exception (thread 0009), starting debugger... Killed I let the debugger "run" for 5min before killing it, it never showed anything and neither did the awdbedit window update at all. -HK

Aug. 11, 2005

Re: compile error in current cvs

by Mike McCormack

Stefan Leichter wrote: > current cvs does not compile for me. Im on SuSE 9.0. Hi Stefan, Could you please try running "./configure && make depend && make" again, and if that doesn't work, let me know what the output of the following command is: grep XML2 config.status For me it looks like this: s,@XML2LIBS@,-lxml2 -lpthread -lz -lm ,;t t s,@XML2INCL@,-I/usr/include/libxml2 ,;t t ${ac_dA}HAVE_LIBXML2${ac_dB}HAVE_LIBXML2${ac_dC}1${ac_dD} ${ac_uA}HAVE_LIBXML2${ac_uB}HAVE_LIBXML2${ac_uC}1${ac_uD} thanks, Mike

Aug. 11, 2005

Re: PATCH: GlobalAddAtomA check for invalid ptr

by Marcus Meissner

On Tue, Aug 09, 2005 at 12:13:22PM +0300, Saulius Krasuckas wrote: > * On Tue, 9 Aug 2005, Marcus Meissner wrote: > > > > The Ikea kitchen planner passed 0xcccccccc for some reason and works > > much better after this patch. > > It if uninitialized memory in a case of MSVC and MSVCRTD, I guess. > BUUUUG in the app. :-) (...RegisterClassExA calls GlobalAddAtomA...) I had a look at the disassembly and yes, the program is buggy. It has a function which goes like this: func() { WNDCLASSA wca; WNDCLASSEXA wcexa; /* inserted by compiler most likely */ memset(localstackspace, 0xCC, sizeoflocalstackspace); ... initialize fields of wca ... wcexa.cbSize = sizeof(wcexa); wcexa.hIconSm = LoadIconA(...); RegisterClassA(&wca); RegisterClassExA(&wcexa); ... } So wondering why it does not initialize anything of WNDCLASSEXA except cbSize and hIconSm ... I think something in the function assumes that wca and wcexa overlap (since WNDCLASSEXA has this layout: UINT cbSize; WNDCLASSA wndclassastuff; HICON hIconSm; I really would like to see the sourcecode of this one and how it is broken. ;) (Programmers of IKEA Kitchen Planner ... Please read.) So ... now we can: - fix this program by contacting the developers etc... which is difficult. - fix WINE by adding a check. I can only fix WINE. Ciao, Marcus Index: dlls/kernel/atom.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/atom.c,v retrieving revision 1.8 diff -u -r1.8 atom.c --- dlls/kernel/atom.c 10 May 2005 15:15:50 -0000 1.8 +++ dlls/kernel/atom.c 9 Aug 2005 06:55:47 -0000 @@ -183,6 +183,10 @@ */ ATOM WINAPI GlobalAddAtomA( LPCSTR str /* [in] String to add */ ) { + if (HIWORD(str) && IsBadStringPtrA(str, MAX_ATOM_LEN)) { + SetLastError( ERROR_INVALID_PARAMETER ); + return 0; + } return ATOM_AddAtomA( str, NULL ); }

Aug. 11, 2005