August 2005 - Wine-Devel - list.winehq.org

RE: BUG[1481] : unimplemented function msvcrt.dll._mbsbtype

by Ge van Geldorp

> From: Jesse Allen > > Quick question. Does React OS or DJGPP include a portable > implementation of printf in msvcrt? I tried looking using > your source browser but I could not tell where it is actually located. It's in lib/crt/stdio (http://svn.reactos.com/viewcvs/trunk/reactos/lib/crt/stdio/) Gé van Geldorp.

Aug. 30, 2005

Re: wine/ include/prsht.h include/commctrl.h dlls/ ...

by Frank Richter

On 30.08.2005 12:07, Alexandre Julliard wrote: > Log message: > Frank Richter <frank.richter(a)gmail.com> > Fix warnings in 64bit. No I didn't; something must have been mixed up while making the commit message. -f.r.

Aug. 30, 2005

Re: [resend] atl.DllRegisterServer

by Stefan Leichter

Alexandre Julliard schrieb: > Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > > >>looks like i was confused by LoadLibraryEx. I found now that when buildin and >>native version of a dll are present and nothing for the load order is >>specified LoadLibraryEx loads the buildin version as long as >>LOAD_LIBRARY_AS_DATAFILE is not specified. But when LOAD_LIBRARY_AS_DATAFILE >>is specified it loads the native version. >> >>Can this behavoir be change to load the same dll independend of >>LOAD_LIBRARY_AS_DATAFILE ? > > > It can, but it's not clear that it should, LOAD_LIBRARY_AS_DATAFILE > doesn't make much sense on a builtin. Anyway, the resources should be > compatible, if they aren't that's a bug in the builtin. > Ok, i will send a patch to make the name of builtin resource compatible with the native one. -- Bye Stefan

Aug. 30, 2005

Re: curses problems in wineconsole

by Alexandre Julliard

Robert Lunnon <bobl(a)optushome.com.au> writes: > curses.c in wineconsole seems to be under (re) development at the moment. > Under Solaris I get the following. I presume this is because the changes are > being developed with ncurses in mind. Nothing has changed in that code for months. There have been some changes in the configure script though, so maybe something in the curses detection has been broken. -- Alexandre Julliard julliard(a)winehq.org

Aug. 30, 2005

Re: Possible critical section bug - lock by invalid thread

by Alexandre Julliard

Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: > Could anybody who knows about Wine critical sections comment on this? I > do not really understand the implementation of critical sections at the > wineserver side (other than the fact that a select() is used somewhere), > so I could take a long time to unravel this bug. This problem does not > seem specific to DirectSound as far as I could tell, so this might be > affecting a couple other apps under Wine. Also, comments on how I could > supply more information on this are welcome. The most likely cause is that a thread got killed while trying to release the section. If you see calls to TerminateThread that would be a prime suspect. -- Alexandre Julliard julliard(a)winehq.org

Aug. 30, 2005

Re: [resend] atl.DllRegisterServer

by Alexandre Julliard

Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > looks like i was confused by LoadLibraryEx. I found now that when buildin and > native version of a dll are present and nothing for the load order is > specified LoadLibraryEx loads the buildin version as long as > LOAD_LIBRARY_AS_DATAFILE is not specified. But when LOAD_LIBRARY_AS_DATAFILE > is specified it loads the native version. > > Can this behavoir be change to load the same dll independend of > LOAD_LIBRARY_AS_DATAFILE ? It can, but it's not clear that it should, LOAD_LIBRARY_AS_DATAFILE doesn't make much sense on a builtin. Anyway, the resources should be compatible, if they aren't that's a bug in the builtin. -- Alexandre Julliard julliard(a)winehq.org

Aug. 30, 2005

Possible theming bug?

by James Liggett

Hi, Yesterday I updated CVS and tried the new theme system. While I find it very impressive, I think I may have discovered a glaring problem with it. I copied the WinXP "Luna" theme from my XP partition into the Resources folder as directed by this week's WWN issue. It showed up in the Appearances tab as "Windows XP style." It works quite well, shown here: http://members.cox.net/jrliggett/screenshots/theme.png. After deciding that I preferred the old style, I set the theme back to "(No theme)" But, there was a problem: all the colors that the theme I had before were still there (but no other visual effects)--and not the usual dark gray/blue combination. Here's a shot of what I mean: http://members.cox.net/jrliggett/screenshots/theme-bug.png Is this type of behavior a bug or am I doing something wrong? Thanks, James

Aug. 30, 2005

curses problems in wineconsole

by Robert Lunnon

curses.c in wineconsole seems to be under (re) development at the moment. Under Solaris I get the following. I presume this is because the changes are being developed with ncurses in mind. gmake gcc -c -I. -I. -I../../include -I../../include -DUNICODE -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -I /opt/sfw/cups/include -I /opt/sfw/cups/include -o curses.o curses.c In file included from winecon_private.h:24, from curses.c:50: ../../include/wincon.h:133:1: warning: "MOUSE_MOVED" redefined In file included from curses.c:41: /usr/include/curses.h:1487:1: warning: this is the location of the previous definition curses.c:70: error: parse error before "mmask_t" curses.c:70: warning: no semicolon at end of struct or union curses.c:75: error: parse error before '}' token curses.c:95: error: `mouseinterval' undeclared here (not in a function) curses.c:95: warning: type defaults to `int' in declaration of `p_mouseinterval' curses.c:96: error: `mousemask' undeclared here (not in a function) curses.c:96: warning: type defaults to `int' in declaration of `p_mousemask' curses.c: In function `WCCURSES_ResizeScreenBuffer': curses.c:221: error: dereferencing pointer to incomplete type curses.c:221: error: dereferencing pointer to incomplete type curses.c:222: error: dereferencing pointer to incomplete type curses.c:223: error: dereferencing pointer to incomplete type curses.c:225: error: dereferencing pointer to incomplete type curses.c:226: error: dereferencing pointer to incomplete type curses.c:226: error: dereferencing pointer to incomplete type curses.c:229: error: dereferencing pointer to incomplete type curses.c: In function `WCCURSES_PosCursor': curses.c:250: error: dereferencing pointer to incomplete type curses.c:257: error: dereferencing pointer to incomplete type curses.c: In function `WCCURSES_ComputePositions': curses.c:299: error: dereferencing pointer to incomplete type curses.c: In function `WCCURSES_Refresh': curses.c:354: error: dereferencing pointer to incomplete type curses.c:356: error: dereferencing pointer to incomplete type curses.c:356: error: dereferencing pointer to incomplete type curses.c:356: error: dereferencing pointer to incomplete type curses.c: In function `WCCURSES_FillMouse': curses.c:557: error: `MEVENT' undeclared (first use in this function) curses.c:557: error: (Each undeclared identifier is reported only once curses.c:557: error: for each function it appears in.) curses.c:557: error: parse error before "mevt" curses.c:559: error: `mevt' undeclared (first use in this function) curses.c:559: error: too many arguments to function curses.c:586: error: `BUTTON_SHIFT' undeclared (first use in this function) curses.c:588: error: `BUTTON_CTRL' undeclared (first use in this function) curses.c:590: error: `BUTTON_ALT' undeclared (first use in this function) curses.c: In function `WCCURSES_FillCode': curses.c:657: error: dereferencing pointer to incomplete type curses.c:746: error: `KEY_RESIZE' undeclared (first use in this function) curses.c: In function `WCCURSES_GetEvents': curses.c:830: error: `KEY_CODE_YES' undeclared (first use in this function) curses.c: In function `WCCURSES_DeleteBackend': curses.c:849: error: `mmask_t' undeclared (first use in this function) curses.c:849: error: parse error before "mm" curses.c:853: error: dereferencing pointer to incomplete type curses.c:855: error: dereferencing pointer to incomplete type curses.c:856: error: dereferencing pointer to incomplete type curses.c:856: error: `mm' undeclared (first use in this function) curses.c:856: error: called object is not a function curses.c:859: error: dereferencing pointer to incomplete type curses.c: In function `WCCURSES_MainLoop': curses.c:873: error: dereferencing pointer to incomplete type curses.c: In function `WCCURSES_InitBackend': curses.c:906: error: invalid application of `sizeof' to incomplete type `inner_data_curse' curses.c:921: error: dereferencing pointer to incomplete type curses.c:956: error: `BUTTON_SHIFT' undeclared (first use in this function) curses.c:956: error: `BUTTON_CTRL' undeclared (first use in this function) curses.c:956: error: `BUTTON_ALT' undeclared (first use in this function) curses.c:957: error: dereferencing pointer to incomplete type curses.c:957: error: called object is not a function curses.c:962: error: called object is not a function curses.c:966: error: dereferencing pointer to incomplete type curses.c:966: error: called object is not a function gmake: *** [curses.o] Error 1

Aug. 30, 2005

Re: Re[4]: Wine device drivers proposal

by Damjan Jovanovic

--- Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: > Monday, August 29, 2005, 3:13:43 AM, Damjan > Jovanovic wrote: > >> It looks like there are multiple projects going > on > >> along the same lines here. > >> Ivan Leo and me working on this too (making > safedisc > >> protected games work on > >> wine). > >> > >> So far we have functional DeviceIoCotrol on a > >> device. But no support for read or > >> write nor synchronization of any kind. Right now > it > >> blocks until processing is > >> complete. > > > How exactly did you change DeviceIoControl()? > > Mm that's a bit more complicated then just > DeviceIoControl. Actually believe it > or not but "DeviceIoControl" is unchanged. What did you change? NtDeviceIoControl()? > Vitaliy > > > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

Aug. 30, 2005

Re: KERNEL: check for NULL in LoadModule16

by Andreas Mohr

Hi, On Mon, Aug 29, 2005 at 01:43:04PM -0500, Alex Villacís Lasso wrote: > I could not find any MSDN reference on any documented behavior for > LoadLibrary16 or LoadModule16 when libname == NULL. I've checked it now (Watcom, Win98 SE): (forgot to zero LOADPARAMS, sorry! But it hopefully didn't matter...) a) NULL, &lp 0 "system out of mem/executable corrupt/relocs invalid" b) "kernel", NULL kernel handle c) NULL, NULL 0 d) (char *)0x1, &lp 2 "file not found" e) (char *)0x1256, NULL 2 f) NULL, (void *)0x1257 0 NO CRASHES whatsoever, IOW it fully intercepts any invalid pointers. a), c), f) vs. d) indicates that it does an explicit check against a NULL name, since probably otherwise LoadModule16 will continue due to the non-NULL name (0x1) and notice somewhat later (in some file API) that file name 0x1 is invalid. So yes, you were right after all - but only semi-right, since the return code is wrong. IMHO this incident strongly indicates that we should add a Win16 source to the Wine tree which can be compiled with Watcom and run similar to the Wine test suite. I don't think such a glaring omission could have happened with Win32 API due to our test suite (well, sure, somewhere it can happen, but the chances are much lower). There probably is no good way to do Win16 calls in Win32 programs with thunking, so we should just have a separate Win16 source instead, to be tested as time permits, since it needs a Watcom compile. What about a directory dlls/kernel/tests/win16/ ? (and adding a README mentioning OpenWatcom) Or should it be dlls/kernel/tests16/ instead? I've got lots of Win16 tests in a Watcom file on my system, I should reorganize it into a common format and add them to CVS, I guess... Andreas

Aug. 30, 2005