September 2005 - Wine-Devel

Re: Documentation volunteer(s) needed

by Holly Bostick

Brian Vincent schreef: > Hopefully I can make this easier on someone. Also, I'm cc'ing Scott > Ritchie since he mentioned at one point he was interested in this. > > The docs now live in a separate CVS tree, I don't have the details > for that. After grabbing them from CVS, you'll want to make sure you > have the docbook tools available for compiling. In the docs > directory you can just do a "make html" or some such in order to > generate nicely viewable material to help with editing. > > I started in on this about a year ago and there's a pretty good > outline to work from. Some of the actual content is just plain wrong > now, but it's probably about 90% accurate. There have been changes > the the DLL Overrides and Drive Settings part of Winecfg. I'd also > consider this stuff to be a little light on the configuration side. > For example, to configure just application settings you need to add > an app on the first tab of winecfg and then make the overrides on the > second tab. I don't think this discusses how that per-app stuff is > done (it also affects Graphics.) One other question in this regard; I'm currently running 20050830. Do I need to compile from CVS to get a more accurate picture of the current state of what I'm documenting, or is the current release (naturally I'll update to the September release as soon as I see it) 'close enough'? > > > <snip of very useful current status information> > > Going forward, we have a lot of documentation in the User Guide about > downloading Wine, compiling Wine, CVS, etc; mostly stuff that's > already duplicated in some form or another on the web site. I'd like > to see as much stuff like that removed from the User Guide as > possible, we can simply refer people to WineHQ for more info. (I > think the reason for the duplication is that the website docs simply > didn't exist when the User Guide was written, now the website has > superceded the User Guide.) When it's all said and done we should be > left with the following sections: - Introduction - Configuration - > Running - Troubleshooting > OK, that's at least an outline of what you/we aim to achieve which is (very) good, of course. Nothing more to say until I've looked at the current material, but I can see the benefits of aiming for simplicity and clarity. I hope the release is stable enough to support these goals (I have faith). Oh yeah, another question-- are we making provision for 'special circumstances'? I've got an ATI card, which makes me sensitive to such things, since the ATI drivers fail to do many things that they should, and often additional provisions need to be made specifically to get an app or game to run with the stupid fglrx drivers, where no such config workarounds need to be used with nVidia cards, or so I've heard. Or does that just fall under 'Troubleshooting'? Or does Wine not need such workarounds at all (unlike Cedega)? My Wine install seems to be acting a bit flakey atm, and I'm not sure why, so I haven't gotten as far with my current project of documenting what works where (Wine vs. Cedega) as I would like, and it makes it hard to be sure whether something that works under Cedega but not under Wine is because I can configure Cedega to work around some ATI problems, whereas I can't with Wine, or whether it's because my Wine install is acting flakey, or because Wine is kinda broke atm in some ways. > > -------- > > There's enough material on this topic to practically write a book. > Someone should think about that. Didn't you get a replacement co-author yet?? Amazing, if true. But that's another discussion :) . Thanks for the info; I'll get over to the documentation CVS later tonight or early tomorrow. Holly

Sept. 20, 2005

Re: Documentation volunteer(s) needed

by Tom Wickline

On 9/20/05, Holly Bostick <motub(a)planet.nl> wrote: > > YES!!! Where do I sign up? Hello Holly, To get the docs in a terminal run : cvs -z3 -d:pserver:anonymous(a)cvs.sourceforge.net:/cvsroot/wine co -P docs When prompted for a password press the enter key. A subdirectory named docs will be created. and you can edit to your hearts content. ;) Make sure you read over : http://www.winehq.org/site/sending_patches I put DOCS: at the beginning of the subject when sending this way Dimi can easily pick it out. Tom > Holly > > >

Sept. 20, 2005

Re: Documentation volunteer(s) needed

by Brian Vincent

On 9/20/05, Holly Bostick <motub(a)planet.nl> wrote: > > YES!!! Where do I sign up? Hopefully I can make this easier on someone. Also, I'm cc'ing Scott Ritchie since he mentioned at one point he was interested in this. The docs now live in a separate CVS tree, I don't have the details for that. After grabbing them from CVS, you'll want to make sure you have the docbook tools available for compiling. In the docs directory you can just do a "make html" or some such in order to generate nicely viewable material to help with editing. I started in on this about a year ago and there's a pretty good outline to work from. Some of the actual content is just plain wrong now, but it's probably about 90% accurate. There have been changes the the DLL Overrides and Drive Settings part of Winecfg. I'd also consider this stuff to be a little light on the configuration side. For example, to configure just application settings you need to add an app on the first tab of winecfg and then make the overrides on the second tab. I don't think this discusses how that per-app stuff is done (it also affects Graphics.) Last year I sent this to wine-devel talking about it: ------- For now, the biggest changes can be found in configuring.sgml (which translates into the "Configuring Wine" part of the guide.) A diff is available here: http://www.theshell.com/~vinn/wine-user-guide.diff However, this stuff is best looked at as a side-by-side comparison with the existing docs. You can find that here: http://www.theshell.com/~vinn/wine-user-guide.html (Not having looked at Mike's recent patches, I'm sure this will soon be out of date. Things like drive detection are missing. There's also parts that I left undone: such as the printing config, an appendix listing reg keys would be nice once we know what they all are. Other parts probably need a better explanation, such as font configuration. Anything you notice missing is probably worth telling me about, though it won't be hard to find lots of mistakes.) One of the big goals of all this is to reduce the amount of documentation and outdated stuff. Therefore, registry.sgml, printing.sgml, and fonts.sgml have been somewhat merged into configuring.sgml. fonts.sgml contained a lot of outdated info in it that probably caused more confusion than helped. Going forward, we have a lot of documentation in the User Guide about downloading Wine, compiling Wine, CVS, etc; mostly stuff that's already duplicated in some form or another on the web site. I'd like to see as much stuff like that removed from the User Guide as possible, we can simply refer people to WineHQ for more info. (I think the reason for the duplication is that the website docs simply didn't exist when the User Guide was written, now the website has superceded the User Guide.) When it's all said and done we should be left with the following sections: - Introduction - Configuration - Running - Troubleshooting -------- There's enough material on this topic to practically write a book. Someone should think about that. -Brian

Sept. 20, 2005

Re: Documentation volunteer(s) needed

by Holly Bostick

Alexandre Julliard schreef: > Folks, > > As most of you probably know (at least those of you who managed to get > out of bed in time for my keynote ;-) we are supposed to release 0.9 > real soon now. We do have one remaining issue: the documentation > needs some major work. Not every bit of it is critical for the > release, but we need to fix at least the User's Guide to reflect the > recent configuration changes. Would anybody be interested in helping > with that? > YES!!! Where do I sign up? Holly

Sept. 20, 2005

Re: RE : OLEAUT32: add full multiplication/division support for DECIMAL, with tests

by Michael Stefaniuc

Alex Villacís Lasso wrote: [..] > As for sending the patch over and over in the month, I was sitting on > mine because I tried to send it during three months and wasn't accepted. > I assumed that it was because I failed to provide testcases. Maybe. But it is also too big. Try splitting it up: put VarDecMul, VarDecDiv and VarDecFromBstr into separate patches together with the tests. If i don't forget i will send you some test cases for VarDecMul too as i have started to implement that one too (handling of some corner cases was missing). bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

Sept. 20, 2005

Re: user: make A->W WM_GETTEXTLENGTH use WM_GETTEXT [try 2]

by Frank Richter

On 20.09.2005 17:00, Frank Richter wrote: > Playing around with a Chinese ANSI code page and some non-Latin > codepage, it seems that with SendMessageA(), you get a correct ANSI > length, while with CallWndProcA() you don't - seems Windows just returns > the Unicode length without any further adjustments... Correction. Seems the CallWndProcA() result depends on what proc is called: Proc directly (as specified to RegisterClassW()): no WM_GETTEXT sent Proc returned by GetWindowLongPtrW (..., GWLP_WNDPROC): no WM_GETTEXT sent Proc returned by GetWindowLongPtrA (..., GWLP_WNDPROC): WM_GETTEXT sent -f.r.

Sept. 20, 2005

Re: listview: infoPtr might be invalid after WM_NOTIFY

by Dimi Paun

> Dimi, if you think this is ugly, or if you are working on a better solution, > please do protest. Well, in part it's a matter of style, and IMO this will clutter the code. Moreover, the patch as it is now works by accident. For example: /* send NM_RELEASEDCAPTURE notification */ - notify(infoPtr, NM_RELEASEDCAPTURE); + notify(infoPtr->hwndSelf, NM_RELEASEDCAPTURE); if (!infoPtr->bFocus) SetFocus(infoPtr->hwndSelf); See, after the notify() the infoPtr may be invalid. This means that if we assume the control can be deleted at any point we send out a notification, we have to reget and recheck infoPtr after every function call. There's got to be a better way. I personally think an exception-based solution would be better. This is what exceptions where invented. I know they look alien in C, but I use them every day in Java for good effect. It's true, we have to be careful to release resources along the way, but we have only 6 such allocations that need protecting, and they are localized. And there we already have a try/catch simulated with goto's. Another approach may be to ref count the structure pointed to by infoPtr, and release it at exit from WinProc when the count is 0. Sort of a poor man's garbage collection. I'm cool with this too, and in fact it may be cleaner then the exception-based solution. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

Sept. 20, 2005

Re: RE : OLEAUT32: add full multiplication/division support for DECIMAL, with tests

by Alex Villacís Lasso

Vijay Kiran Kamuju wrote: >Hi Alex, > >I think your VarBstrFromDec fails with my testcases, >and you should not hardcode the decimal format seperator. >And your patch fails my tests. >Check my patch<http://www.winehq.org/pipermail/wine-patches/2005-September/020777.html>for >VarBstrFromDec(for my implementation and tests), my implementation is >partial. >You did a gr8 job implemeting the DECIMAL stuff in oleaut32. >I have been sending and resending my patch since a month. >I hope yours gets commited soon. > >bye >Vijay > > > >------------------------------------------------------------------------ > > > > I guess the failing part is the one where the decimal separator is supposed to change between locales, but doesn't. My patch was based on the (mistaken) assumption that the VARIANT_MakeBstr() function would take care of the decimal separator for each locale. I will add your tests to my patch and resubmit with the necessary changes tomorrow. As for sending the patch over and over in the month, I was sitting on mine because I tried to send it during three months and wasn't accepted. I assumed that it was because I failed to provide testcases. Alex Villacís Lasso

Sept. 20, 2005

Documentation volunteer(s) needed

by Alexandre Julliard

Folks, As most of you probably know (at least those of you who managed to get out of bed in time for my keynote ;-) we are supposed to release 0.9 real soon now. We do have one remaining issue: the documentation needs some major work. Not every bit of it is critical for the release, but we need to fix at least the User's Guide to reflect the recent configuration changes. Would anybody be interested in helping with that? -- Alexandre Julliard julliard(a)winehq.org

Sept. 20, 2005

Windows CE on Wine

by Boaz Harrosh

OK What you guys think. I have an Arm based machine Running Windows CE. Same machine also runs Linux... Do you think it can be the same Wine codebase, implementing Both Win32 API as well as WindowsCE API? What areas must be rewritten (or not) ? 1.Loader 2.HAL (is there an HAL in Wine) 3.Debugging / exceptions any thing else? Other CPU(s)? What if I want to do the same but for WindowsCE x86? Free Life Boaz

Sept. 20, 2005

Re: user: make A->W WM_GETTEXTLENGTH use WM_GETTEXT [try 2]

by Frank Richter

On 19.09.2005 21:44, Frank Richter wrote: > Interestingly, when CallWindowProcA() is used on an W window, no > WM_GETTEXT is sent. (Whether the window proc belongs to the window does > not seem to matter.) Though, in that case, the result is not doubled either. Playing around with a Chinese ANSI code page and some non-Latin codepage, it seems that with SendMessageA(), you get a correct ANSI length, while with CallWndProcA() you don't - seems Windows just returns the Unicode length without any further adjustments... -f.r.

Sept. 20, 2005

Re: question about the status of the wine printing system

by Kuba Ober

> I would say it is already working with most major applications. I think > it works with Photoshop and it certainly works with all of the Office > applications. I bet it won't work if you embed an .eps file in a Word document. Word is known to push those directly to postscript printers. Probably uses the same escape as Acrobat. On non-ps printers it normally only prints the low-resolution preview, and only if one came with the .eps. Cheers, Kuba

Sept. 20, 2005

Re: Suggestions for improvement of the emulator

by Kuba Ober

> "em·u·late: Computer Science, Software: Imitation of the function of > (another system), by dynamic recompilation or interpretive translation as > to allow the imitating system to accept the same data, execute the same > binary programs, and achieve the same results as the imitated system." I like that one. At least it meshes well with what people mean when they use the word. Cheers, Kuba

Sept. 20, 2005

Re: Wine on NetBSD?

by Ivan Leo Puoti

Bryce Robilliard wrote: > I was enquiring as to whether or not Wine is compatible with NetBSD According to the readme file yes, however I think nobody has tried it in a long time. Ivan

Sept. 20, 2005

Re: CopyImage for IMAGE_BITMAP still not right, next Try

by Uwe Bonnes

>>>>> "Dmitry" == Dmitry Timoshkov <dmitry(a)baikal.ru> writes: Dmitry> "Uwe Bonnes" <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: >> if ((res = CreateBitmapIndirect(&bm))) { - char *buf = HeapAlloc( >> GetProcessHeap(), 0, bm.bmWidthBytes * bm.bmHeight ); + LONG size = >> GetBitmapBits( hnd, 0, NULL ); + char *buf = HeapAlloc( >> GetProcessHeap(), 0, size ); GetBitmapBits( hnd, bm.bmWidthBytes * >> bm.bmHeight, buf ); - SetBitmapBits( res, bm.bmWidthBytes * >> bm.bmHeight, buf ); + SetBitmapBits( res, size, buf ); Dmitry> This doesn't look right. You need to call GetBitmapBits the Dmitry> second time with "size" returned from a previous GetBitmapBits Dmitry> call, just like you do in SetBitmapBits. If I do that, I get an X Error: X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 73 (X_GetImage) Serial number of failed request: 34307 Current serial number in output stream: 34307 The bitmap in question in Avrstudio from Atmel is a four bit one. With the code above, serveral errors like: err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=4 err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=4 err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=4 err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=4 are produced. B.t.w. to get Avrstudio to run until that error happens, start it like env WINEDLLOVERRIDES=msvcrt,msxml3,ole32,oleaut32,rpcrt4,urlmon=n /spare/bon/wine/wine/wine AvrStudio4/AVRStudio.exe Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

Sept. 20, 2005

Re: CopyImage for IMAGE_BITMAP still not right, next Try

by Dmitry Timoshkov

"Uwe Bonnes" <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: > if ((res = CreateBitmapIndirect(&bm))) > { > - char *buf = HeapAlloc( GetProcessHeap(), 0, bm.bmWidthBytes * bm.bmHeight ); > + LONG size = GetBitmapBits( hnd, 0, NULL ); > + char *buf = HeapAlloc( GetProcessHeap(), 0, size ); > GetBitmapBits( hnd, bm.bmWidthBytes * bm.bmHeight, buf ); > - SetBitmapBits( res, bm.bmWidthBytes * bm.bmHeight, buf ); > + SetBitmapBits( res, size, buf ); This doesn't look right. You need to call GetBitmapBits the second time with "size" returned from a previous GetBitmapBits call, just like you do in SetBitmapBits. -- Dmitry.

Sept. 20, 2005

Re: fix if's that are followed by semicolons

by Michael Stefaniuc

Mike McCormack wrote: > > Erik de Castro Lopo wrote: > >> Gcc-4.0 catches this: >> >> erikd(a)miles > cat test.c int main (void) >> { >> if (0) ; >> return 0 ; >> } >> erikd(a)miles > gcc-4.0 -W -Wall test.c -o /dev/null >> test.c: In function 'main': >> test.c:3: warning: empty body in an if-statement > > > Yes, but only if you use -W -Wall, which wine unfortunately doesn't :/ Properly documented (in the janitorial part on the wiki) this is good enough. No need to write an extra tool/script to catch those if problems. I once wrote a script for smatch to look for such cases but i'm not sure i finished it or at least it's not part of the standard smatch scripts I run. > bash-3.00$ cat > t.c > int boo(int arg) { > if (arg); > return 0; > } > bash-3.00$ /usr/local/gcc-4.0.1/bin/gcc -c -Wall t.c > bash-3.00$ /usr/local/gcc-4.0.1/bin/gcc -c -W -Wall t.c > t.c: In function 'boo': > t.c:2: warning: empty body in an if-statement bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

Sept. 20, 2005

Re: fix if's that are followed by semicolons

by Mike McCormack

Erik de Castro Lopo wrote: > Gcc-4.0 catches this: > > erikd(a)miles > cat test.c > int main (void) > { > if (0) ; > return 0 ; > } > erikd(a)miles > gcc-4.0 -W -Wall test.c -o /dev/null > test.c: In function 'main': > test.c:3: warning: empty body in an if-statement Yes, but only if you use -W -Wall, which wine unfortunately doesn't :/ bash-3.00$ cat > t.c int boo(int arg) { if (arg); return 0; } bash-3.00$ /usr/local/gcc-4.0.1/bin/gcc -c -Wall t.c bash-3.00$ /usr/local/gcc-4.0.1/bin/gcc -c -W -Wall t.c t.c: In function 'boo': t.c:2: warning: empty body in an if-statement Mike

Sept. 20, 2005

Re: fix if's that are followed by semicolons

by Erik de Castro Lopo

Mike McCormack wrote: > > Andreas Mohr wrote: > > > Could you perhaps create a first version of a shell script tools/find_gotchas ? > > I have other things to do at the moment, so go ahead if you're feeling > motivated. I suspect you'll run into alot of false positives. There > might be a compiler switch to turn on warnings for these things too (ie. > statements with no effect). Gcc-4.0 catches this: erikd(a)miles > cat test.c int main (void) { if (0) ; return 0 ; } erikd(a)miles > gcc-4.0 -W -Wall test.c -o /dev/null test.c: In function 'main': test.c:3: warning: empty body in an if-statement Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo +-----------------------------------------------------------+ "It is capitalist America that produced the modern independent woman. Never in history have women had more freedom of choice in regard to dress, behavior, career, and sexual orientation." -- Camille Paglia

Sept. 20, 2005

Re: [bug 3255] comboboxex fix + tests

by Michael Stefaniuc

Hello Jason, are you sure you sent the patch? Looks to me more like the output of "cvs update" ;) bye michael Ann & Jason Edmeades wrote: > The bug itself was an off by one calculation due to zero based indexes, but > I also saw the same problem existed in other functions and so wrote some > small tests for them. > > Changelog > > Fix some off by one calculations in the comboboxex functions, and handle an > out of range positive index the same as windows + unit test case -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

Sept. 20, 2005

Re: fix if's that are followed by semicolons

by Mike McCormack

Andreas Mohr wrote: > Could you perhaps create a first version of a shell script tools/find_gotchas ? I have other things to do at the moment, so go ahead if you're feeling motivated. I suspect you'll run into alot of false positives. There might be a compiler switch to turn on warnings for these things too (ie. statements with no effect). Mike

Sept. 20, 2005

Re: fix if's that are followed by semicolons

by Andreas Mohr

Hi, On Tue, Sep 20, 2005 at 04:49:49PM +0900, Mike McCormack wrote: > > Found with: > > find . -name \*.c -exec grep "if *([^)]*)\; *" {} \; -ls Could you perhaps create a first version of a shell script tools/find_gotchas ? We really need to make sure all those many things similar to this get fixed on an ongoing basis. Other gotchas could be if (a = b) (not easily identifiable since it might be legitimate, though) HFILE x = 0; (instead of INVALID_HANDLE or so) Andreas Mohr -- No programming skills!? Why not help translate many Linux applications! https://launchpad.ubuntu.com/rosetta

Sept. 20, 2005

Re: question about the status of the wine printing system

by Francois Gouget

On Mon, 19 Sep 2005, Dan Kegel wrote: > In http://www.winehq.org/hypermail/wine-devel/2005/01/0111.html, > Francois Gouget wrote: > >> If you're trying to print stuff from Acrobat Reader (now called Adobe >> Reader), then that's known not to work. > > What are the problems? I don't know much about printing, but as I was explained it, the problem is that Acrobat Reader uses a special EMF escape to directly send Postscript or something like it to the printer and that does not work right in Wine. As far as I know Acrobat Reader is the only application with this problem. > How much work is left before printing in Wine is > more or less working with most major applications > (like, say, Photoshop and Acrobat Reader)? I would say it is already working with most major applications. I think it works with Photoshop and it certainly works with all of the Office applications. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

Sept. 20, 2005

Re: Burning CDs under Wine?

by Dan Kegel

Vitaliy Margolen wrote: > Monday, September 19, 2005, 6:07:58 PM, Dan Kegel wrote: > >>What is the current state of support for burning CDs >>under Wine? I checked the appdb, but can't find >>any recent reports of CD burning programs working. ... > > There were few changes to wine's aspi and related code. Can you do regression > testing to see when your program stopped working? Or did it ever worked at all > with Wine? Good question. The app is Picasa 2. I am going by the comments at http://appdb.winehq.org/appview.php?versionId=2786 which say > Burning CDs ("Create a Gift CD" and "Backup CD") does not work (keeps on saying it needs a blank CD or DVD). I haven't tested it myself yet. I'll try to do that when I get back from vacation in a week. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

Sept. 20, 2005

RE : OLEAUT32: add full multiplication/division support for DECIMAL, with tests

by Vijay Kiran Kamuju

Hi Alex, I think your VarBstrFromDec fails with my testcases, and you should not hardcode the decimal format seperator. And your patch fails my tests. Check my patch<http://www.winehq.org/pipermail/wine-patches/2005-September/020777.html>for VarBstrFromDec(for my implementation and tests), my implementation is partial. You did a gr8 job implemeting the DECIMAL stuff in oleaut32. I have been sending and resending my patch since a month. I hope yours gets commited soon. bye Vijay

Sept. 20, 2005