September 2005 - Wine-Devel

Re: DDRAW: Fix reference counting

by Stefan Dösinger

Hi, > Why do you increase the refcount by 2? Since you add and release them in > the same functions, it is not really necessary and just adds complexity > to the code. Well, Windows does so for some reason, and after what I've seen with Empire Earth, I suspect that there are some apps out there which depend on things like this. It's unlikely, but I would not be surprised if that happens. > if (!FAILED(hr)) -> if (SUCCEEDED(hr)) Could have guesses this one. Thanks. Thanks, for your suggestions, Stefan

Sept. 19, 2005

Re: Fwd: amblksize definition

by Saulius Krasuckas

* On Mon, 19 Sep 2005, Vijay Kiran Kamuju wrote: > > amblksize definition in msvcrt. Wouldn't it be nice to establish a real variable somewhere in the msvcrt code?

Sept. 19, 2005

XEmbed systray patch bugs

by James Liggett

Hi Mike and Rob, I tried your patch for XEmbed systray support, and I'm pretty impressed with it. I think it's about time someone finally dusted this one off and tried to get it committed. But, I've noticed some issues: 1. The "Wine-Systray" window is still showing up. I've been able to fix this by getting rid of the WS_VISIBLE style when creating the window in systray.c, and then manually showing the window after it's been docked. 2. The rightmost edges of systray icons are cut off. The previous fix seemed to work for this problem too. I think it has something to do with painting/updating the embedded window. 3. Sometimes, systray icons don't show up at all. I notice this when exiting a program that uses systray and then starting it again. On the second consecutive run, the icon doesn't show up at all. It must be some kind of window-management problem, because I still see the Wine-systray window after after the program I'm using exits. I can only make it go away after restarting my window manager (Metacity with the GNOME desktop) Looks like some kind of cleanup issue. I'm working on this one. For reference, the two programs I've been using for testing are Palm Hotsync and Steam. When I get some more free time, I'll put together a simpler test case to nail down that third problem. All that aside, good work guys! :) James

Sept. 19, 2005

Re: hhctrl: Correctly draw the navigation pane

by Robert Shearman

James Hawkins wrote: >Hi, > >Changelog >* Correctly draw the navigation pane. > > > Hi James, I'm impressed with the work that has been done to get hhctrl this complete. But... >@@ -149,7 +144,7 @@ static void HH_RegisterChildWndClass(HHI > wcex.hInstance = pHHInfo->hInstance; > wcex.hIcon = LoadIconW(NULL, (LPCWSTR)IDI_APPLICATION); > wcex.hCursor = LoadCursorW(NULL, (LPCWSTR)IDC_ARROW); >- wcex.hbrBackground = (HBRUSH)(COLOR_3DFACE); >+ wcex.hbrBackground = (HBRUSH)(COLOR_MENU); > > This doesn't seem right. You're not registering a menu-like class. > wcex.lpszMenuName = NULL; > wcex.lpszClassName = szChildClass; > wcex.hIconSm = LoadIconW(NULL, (LPCWSTR)IDI_APPLICATION); > > -- Rob Shearman

Sept. 19, 2005

Re: DDRAW: Fix reference counting

by Robert Shearman

Stefan Dösinger wrote: >Hello, >This patch increases the reference count of a DirectDraw object when a Surface >is created, like Windows does. It also adds a test which tests this >functionality. > >Stefan Dösinger > > >------------------------------------------------------------------------ > >Index: dlls/ddraw/ddraw_main.c >=================================================================== >RCS file: /home/wine/wine/dlls/ddraw/ddraw_main.c,v >retrieving revision 1.9 >diff -u -r1.9 ddraw_main.c >--- dlls/ddraw/ddraw_main.c 12 Sep 2005 14:12:47 -0000 1.9 >+++ dlls/ddraw/ddraw_main.c 18 Sep 2005 19:56:12 -0000 >@@ -697,8 +697,10 @@ > } > else if (pDDSD->ddsCaps.dwCaps & DDSCAPS_TEXTURE) > { >- /* create texture */ >+ /* create texture. This increases the DD refcount by 2 */ > > Why do you increase the refcount by 2? Since you add and release them in the same functions, it is not really necessary and just adds complexity to the code. > hr = create_texture(This, pDDSD, ppSurf, pUnkOuter); >+ if(!FAILED(hr)) >+ IDirectDraw7_AddRef(iface); /* Plus the increase at the end of the function */ > > if (!FAILED(hr)) -> if (SUCCEEDED(hr)) -- Rob Shearman

Sept. 19, 2005

Re: comctl32.dll: Running siap and modules under wine, first steps

by Dimi Paun

On Sat, 2005-09-17 at 17:46 -0300, Maximiliano Curia wrote: > Is anybody working in this dll, or has worked on this widget? Nobody currently works on the treeview unfortunately, and it needs love. Lots of it. If you want to take a stab at it, you can find it in dlls/comctl32/treeview.c -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

Sept. 19, 2005

Re: [Now ns7] Dragon ns8 problem

by wino＠piments.com

On Mon, 12 Sep 2005 13:14:44 +0200, Jean Magnan de Bornier <jean(a)bornier.net> wrote: > > OK, I added rpcrt4.dll in c/windows/system, and now dns starts all right, > although slowly and with strange messages, and WORKS! > If you have got this working correctly it would be good if you could add a comment to http://appdb.winehq.org/appview.php?versionId=3227 with your wine version, simulated windows version, the NS version (NS7 french? multilang? std/pref?) and a list of any dlls you needed to run native. It would also be great to have some comment on how well it deals with the french language, I installed NS5 VF for someone and was surprised that it seemed to perform just as well as in English. regards.

Sept. 18, 2005

Rendering problem when scrolling license agreement in Picasa installer

by Dan Kegel

http://bugs.winehq.org/show_bug.cgi?id=3348 describes a scrolling problem that is probably pretty easy to fix. The nullsoft(?) installer used by picasa 2 seems to have a problem with text scrolling in the latest snapshot of wine. Scrolling using the keyboard works, but scrolling by clicking on the arrows of the scrollbar screws up the new text. I have a sneaking suspicion this affects other apps. Is this a known problem already? Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

Sept. 18, 2005

Picasa working pretty well...

by Dan Kegel

I had a free couple of hours this morning, so I amused myself by trying out Picasa on the most recent snapshot of wine on my el-cheapo x86_64 Compaq laptop running 32 bit FC3. I was really impressed with how well things worked in general - much of the interface worked very smoothly. Hats off to the Wine developers! Still, there were some real glitches, so I filed six bug reports. You can see them in the AppDB at http://appdb.winehq.org/appview.php?versionId=2786 I'll post individual messages about a couple of them. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

Sept. 18, 2005

server: reimplement namespace as a directory object.

by Vitaliy Margolen

This a first look at implementing name space inside wineserver as a directory object. Some things are scatchy, like dealing with dices that should have files inside them - ex: named pipes. You could look at how I done this with winstation. Is this is a correct approach to this? Or should I do something else? I also added few extra flags to objects, that will have to be used where appropriate. Also added object type filed to ops. There are few places that needs this especially directory query function, that has to return type name. As always, all suggestions comments are appreciated. Vitaliy Margolen

Sept. 18, 2005

freedce-win32 - winsock joy

by Luke Kenneth Casson Leighton

progress being made. am about 10-15% the way through a compile, having previously got dcethreads to use pthread-win32 by judicious ripping out of large amounts of code. fortunately, elrond has already win32'd tng, so there is stacks of code in tng's lib/util_sock.c to rip off :) -- -- <a href="http://lkcl.net">http://lkcl.net</a> --

Sept. 18, 2005

winehq at the CIA Open Source Notification System

by Detlef Riekenberg

Hi. There are no updates listed for wine at the CIA Open Source Notification System: http://cia.navi.cx/stats/project/winehq Is this our fault? -- By By ... ... Detlef

Sept. 18, 2005

Compile failure on Solaris

by wine＠henkis.net

I get the following error when i try to compile Win on my Solaris x86 machine: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DBINDIR="\"/usr/local/bin\"" -DDLLDIR="\"/usr/local/lib/wine\"" -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wpointer-arith -g -O2 -o debug.o debug.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DBINDIR="\"/usr/local/bin\"" -DDLLDIR="\"/usr/local/lib/wine\"" -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wpointer-arith -g -O2 -o ldt.o ldt.c ldt.c:107: error: conflicting types for 'sysi86' /usr/include/sys/sysi86.h:248: error: previous declaration of 'sysi86' was here ldt.c:107: error: conflicting types for 'sysi86' /usr/include/sys/sysi86.h:248: error: previous declaration of 'sysi86' was here gmake[2]: *** [ldt.o] Error 1 gmake[2]: Leaving directory `/home/henrikj/wine/wine/libs/wine' gmake[1]: *** [wine] Error 2 gmake[1]: Leaving directory `/home/henrikj/wine/wine/libs' gmake: *** [libs] Error 2 Thankful for any assistance... Regards Henrik

Sept. 18, 2005

Re: comctl32.dll: Running siap and modules under wine, first steps

by Andreas Mohr

Hi, On Sat, Sep 17, 2005 at 08:20:29PM -0300, Maximiliano Curia wrote: > So, what should I do next? I'm afraid I cannot give much technical advice how to proceed here, but what you should do soon is to protest loudly against *FORCING* a Windows-only program on the public in this day and age of multi-platform use, despite those cross-platform toolkits such as Qt, wxWidgets, GTK and Java having been available for long times already (not to mention that several of those should actually be superiour to the single-platform toolkit that may have been used here!). This is "§$%"§(%" incredible ignorance and malvolence. But I'm confident that many of you have already been doing this. Good luck with this major annoyance, Andreas Mohr

Sept. 18, 2005

Re: HKCU\Software created as volatile?

by Dmitry Timoshkov

"Kimmo Myllyvirta" <kimmo.myllyvirta(a)gmail.com> wrote: > I've met this kind of errors so many times with fresh installs that I > finally took a look at what was going on; > err:winecfg:set_config_key Unable to set configuration key Audio in > section Drivers, res=1021 > > This error occurs because HKCU\Software is created with > REG_OPTION_VOLATILE, thus making it impossible to create non-volatile keys > under HKCU\Software. This breaks about every app that's trying to create > keys under "Software" - like winecfg. > > This is because SystemParametersInfoW in dlls/user/sysparams.c creates > the "HKCU\Software\Wine\Temporary System Parameters" > key with REG_OPTION_VOLATILE - and if you do not have HKCU\Software\Wine > already available, they are crated as volatile also. Please send a patch which fixes SystemParametersInfoW to wine-patches. -- Dmitry.

Sept. 18, 2005

Re: comctl32.dll: Running siap and modules under wine, first steps

by Robert Shearman

Maximiliano Curia wrote: >... > >There are a couple of important widgets that seem to be incompatible with >wine. But as I'm not an expert neither in Windows nor in wine, the one I could >really track down is a TreeView widget (from comctl32.dll) (from the main >window of the program), that is not fully implemented in wine, and by using a >native comctl32.dll (I tried using the win98, winme, win2k libraries) the >widget would work but some of the other stuff, like switching >to one of the modules wouldn't. > >I made a screenshot to make this clearer, the wine version[3] and the w2k >version[4]. > >So, what should I do next? > > Start the program with WINEDEBUG=+treeview wine program.exe &> treeview.log and send the treeview log to the list (compressed if it is over 50kB). >Is there some documentation of how to implement a certain Windows widget in >wine? > > Not really. My guess is that either some message is failing because it is hitting some border case. >Is anybody working in this dll, or has worked on this widget? > > I have worked on the control, but I don't really have time to look at the specific problem, other than giving a 5 minute look over any log files you send. -- Rob Shearman

Sept. 17, 2005

comctl32.dll: Running siap and modules under wine, first steps

by Maximiliano Curia

Hi, I'm trying to use a program called "siap"[1] under wine. It's the required program to pay taxes that the Argentinian government uses. So, it's quite important for the free software community in Argentina to be able to use it in a free software environment. However, I haven't heard of any real success on it, so far. I've been trying to make it run using winetools[2], and differents versions of wine. The furthest I've gone, has been with version 20050310 and all the "plugins" that winetools provides, installed. Only then, could I install the application, run it, switch between the different modules (although it worked only sometimes), but I can't really use it. There are a couple of important widgets that seem to be incompatible with wine. But as I'm not an expert neither in Windows nor in wine, the one I could really track down is a TreeView widget (from comctl32.dll) (from the main window of the program), that is not fully implemented in wine, and by using a native comctl32.dll (I tried using the win98, winme, win2k libraries) the widget would work but some of the other stuff, like switching to one of the modules wouldn't. I made a screenshot to make this clearer, the wine version[3] and the w2k version[4]. So, what should I do next? Is there some documentation of how to implement a certain Windows widget in wine? Is anybody working in this dll, or has worked on this widget? I'd appreciate any comments. Thanks, [1] http://www.afip.gov.ar/programas/siap_main.asp (spanish only) [2] http://www.von-thadden.de/Joachim/WineTools/ [3] http://gnuservers.com.ar/~maxy/wine/siap-wine.png [4] http://gnuservers.com.ar/~maxy/wine/siap-w2k.png -- Saludos, /\/\ /\ >< `/ -- Saludos, /\/\ /\ >< `/

Sept. 17, 2005

comctl32.dll: Running siap and modules under wine, first steps

by Maximiliano Curia

Hi, I'm trying to use a program called "siap"[1] under wine. It's the required program to pay taxes that the Argentinian government uses. So, it's quite important for the free software community in Argentina to be able to use it in a free software environment. However, I haven't heard of any real success on it, so far. I've been trying to make it run using winetools[2], and differents versions of wine. The furthest I've gone, has been with version 20050310 and all the "plugins" that winetools provides, installed. Only then, could I install the application, run it, switch between the different modules (although it worked only sometimes), but I can't really use it. There are a couple of important widgets that seem to be incompatible with wine. But as I'm not an expert neither in Windows nor in wine, the one I could really track down is a TreeView widget (from comctl32.dll) (from the main window of the program), that is not fully implemented in wine, and by using a native comctl32.dll (I tried using the win98, winme, win2k libraries) the widget would work but some of the other stuff, like switching to one of the modules wouldn't. I made a screenshot to make this clearer, the wine version[3] and the w2k version[4]. So, what should I do next? Is there some documentation of how to implement a certain Windows widget in wine? Is anybody working in this dll, or has worked on this widget? I'd appreciate any comments. Thanks, [1] http://www.afip.gov.ar/programas/siap_main.asp (spanish only) [2] http://www.von-thadden.de/Joachim/WineTools/ [3] http://gnuservers.com.ar/~maxy/wine/siap-wine.png [4] http://gnuservers.com.ar/~maxy/wine/siap-w2k.png -- Saludos, /\/\ /\ >< `/

Sept. 17, 2005

Re: found it! the "dce porting" header file

by Ivan Leo Puoti

Luke Kenneth Casson Leighton wrote: > guys (wine team) i have to say this. you were utterly insane to not use > freedce as your starting point I heard some ros guys want to implement smb from scratch without even looking at samba, it must be some mental disease that all people reimplementing windows get ;-) Ivan.

Sept. 17, 2005

found it! the "dce porting" header file

by Luke Kenneth Casson Leighton

http://examples.oreilly.de/english_examples/dce/dce_nt/dceport.h.aug95 o joy o joy. also, i found _this_!!! http://sourceware.org/pthreads-win32/ which is an implementation of pthreads on win32. _also_ i found - was reminded - by judicious searching on google, that of course entegrity.com have "PC-DCE" which is of course a _commercial_ product that has done exactly the work required: making dce (1.1? 1.2.2?) compile on Win32. including exceptions, dealing with mapping the names, blah blahhh. now. anyone got any brainy ideas on how to reverse dceport.h - in particular the thingy. wotsit. TRY/FINALLY/CATCH stuff? what i'm going to try to do is take a shot at simply compiling dcethreads - on win32. if that _works_ (the tests pass) it'll be great - it will prove two things: 1) that pthreads-win32 works 2) that the dce exception handling will fly, on win32, and _that_ means pretty much zero (urk! let's hope!) work. for now. my main goal: "GetItWorking(tm)". i couldn't care less about binary compatibility for now: i want "services" - i want srvsvcd, i want winregd, i want lsarpcd, i want samrd - all compiled, all working, using TCP/IP. i can then work on rewriting freedce's ntlmsspauth.so to be a DLL (starting off as my favourite - a stub with username and password of "test"). i can then work on writing an "ncalrpc" plugin transport (which is very straightforward: a matter of filling in about 25 functions in a vector table). and also on a ncacn_np plugin transport. "working" means that other people will then be able to focus on issues like binary compatibility. guys (wine team) i have to say this. you were utterly insane to not use freedce as your starting point - and i am still bewildered by you not even looking at its source code (which is topologically identical in almost all areas, to what you've created) or the opengroup's documentation. i say that with the greatest of respect for what you've achieved without freedce. l. -- -- <a href="http://lkcl.net">http://lkcl.net</a> --

Sept. 17, 2005

Re: [Now ns7] Dragon ns8 problem

by wino＠piments.com

On Mon, 12 Sep 2005 13:14:44 +0200, Jean Magnan de Bornier <jean(a)bornier.net> wrote: > > OK, I added rpcrt4.dll in c/windows/system, and now dns starts all right, > although slowly and with strange messages, and WORKS! > Hmm, I found it is very slow to open on more recent wine versions : ie after 20050524 but was getting crashes as soon as I tried to open dragonpad. This is regression, it used to work. Could you post which (all) dlls you have had to run native to get this working? Did you have to install IE6 first or not. (I cheated but it worked) > I have not figured out I could save the output that is written on the > "dragon > editor"; if I try to save in a file dns crashes, if I try to save to > clipboard (C-c) and then open it in e.g. emacs, I have nothing. > Any ideas? > Thanks, To copy text dictated into DragonPad I simply highlight it with the mouse. Standard X behaviour will copy this to the clipboard without any other clicking or hotkeys. Then I paste where I want it . Again, the std 3rd mouse button click will paste most places in X , but in Opera email I find I have to use Cntl-V to paste since the mouse-3-click seems to paste another buffer. I love this - highlight to copy; one click to paste - in X , it is so much more efficient than all the context menu stuff in Win. I seem to recall the Edit menu in dragonpad worked as expected as well. Cant advice on emacs behaviour. HTH

Sept. 17, 2005

documentation out of date.

by wino＠piments.com

I am trying to update from 20050524 to wine-20050830. The newer version tells me to use winecfg not the old config file , so I thought I should read up on it. >> bash-3.00#man winecfg >> No manual entry for winecfg So I tried man wine but no mention of winecfg , it still refers to the config file. It also lists a reference in the last line to a man entry for wineserver. So I decided to get upto date on wineserver... >> bash-3.00#man wineserver >> No manual entry for wineserver Wine is a very complex program, it would be helpful if the man entries were self-consistent and updated with the release they install with, especially when important changes like the introduction of wineconfig are concerned. So where do I look for info on winecfg? In short, does .wine/config still get read or is it dead? Also winecfg About tells me version is "wine CVS" , wine command tells me 20050830. I am trying to maintain an app in the appDB but this is difficult without consistent doc. TIA for any input.

Sept. 17, 2005

HKCU\Software created as volatile?

by Kimmo Myllyvirta

I've met this kind of errors so many times with fresh installs that I finally took a look at what was going on; err:winecfg:set_config_key Unable to set configuration key Audio in section Drivers, res=1021 This error occurs because HKCU\Software is created with REG_OPTION_VOLATILE, thus making it impossible to create non-volatile keys under HKCU\Software. This breaks about every app that's trying to create keys under "Software" - like winecfg. This is because SystemParametersInfoW in dlls/user/sysparams.c creates the "HKCU\Software\Wine\Temporary System Parameters" key with REG_OPTION_VOLATILE - and if you do not have HKCU\Software\Wine already available, they are crated as volatile also. ( see get_volatile_regkey() ) You can test this simply by (if you have a fresh install, you can go directly to 4.); 1. Opening regedit 2. Delete HKCU\Software (or HKCU\Software\Wine only) 3. Close regedit 4. Open regedit 5. Try to create a new key under HKCU\Software (or HKCU\Software\Wine, if you removed only that) 6. You'll get error message "Subkey must be volatile" Any comments? ( This could be fixed in sysparams.c - already got a patch ready for it, but probably it's better to ensure in wineserver that the Software\Wine exists or something, so that this bug does not pop up again later? )

Sept. 17, 2005

Re: XEmbed Systray Support

by Rob Shearman

Robert Shearman wrote: > Hi, > > This patch allows new non-KDE systems to display notification area > icons for Win32 apps in the window manager's system tray, instead of > in a 16x16 top-level window. > > Changelog: > Support XEmbed protocol for system tray windows. Sorry, I forgot to credit Mike Hearn in the changelog. It should be as follows: Robert Shearman <rob(a)codeweavers.com> Mike Hearn <mh(a)codeweavers.com> Support XEmbed protocol for system tray windows. Thanks, Rob

Sept. 17, 2005

Re: OleFont: Fix IDispatch Implementation (was Re: olefont: GetIDsOfNames)

by Robert Shearman

Walt Ogburn wrote: >I'm not sure how to proceed here. My small patch makes the GetIDsOfNames >in olefont work, so that programs that want to use GetIDsOfNames to get a >DISPID code and then use Invoke to set font size, bold, etc. will work. >With your bigger patch, IFontDisp uses the GetIDsOfNames from typelib.c, >which also works, but it also uses the Invoke from typelib.c, which >doesn't know how to set the font size, etc. > It does know how to do that - it uses the typelib to calculate an offset in the vtable of the this pointer passed into CreateStdDispatch and calls the matching method. >Therefore, programs that try >to get the DISPID code with GetIDsOfNames and then set some property with >Invoke are broken at a different point after your patch. > > Have you tested this? How exactly do they break? Do they crash or does Invoke return an error? >The thing is, I don't see how the Invoke in typelib.c can be made to get >and set the font size, font weight, etc. correctly. It shouldn't know >about the internal structure of OLEFontImpl, right? So how can it know >that DISPID_FONT_WEIGHT and DISPID_FONT_BOLD mean doing doing different >things to the same field in the OLEFontImpl, or where to find it? > > Again, it should look up the offset in the vtable to call the appropriate put_... or get_... function depending on whether propget or propput is specified. >If you know how to make Invoke work again after your patch, that would be >great. > It is possible that I overlooked something that we need to do for the invoking through a typelib to work. I'll need more info to find this out. -- Rob Shearman

Sept. 16, 2005