January 2006 - Wine-Devel - list.winehq.org

Re: setupapi: unimplemented function setupapi.dll.SetupPromptReboot

by Steven Edwards

Hi, On 1/27/06, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > Is anyone working on this for Wine? > Any ideas about the ReactOS code? The shutdown code ExitWindowsEx calls is a complex beast. Its something like 40 steps all of which were not implemented so it was disabled until the rest of the plumbing was put in. -- Steven Edwards - ReactOS and Wine developer "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Jan. 27, 2006

<DEL> key is sending an extra char when NumLock is ON

by penna＠bb.com.br

Hi, I was looking at an old problem I have with wine and saw some record at the wine-devel and wine-users lists that I think are related with the same problem. Look at: http://www.winehq.org/hypermail/wine-users/2004.03.txt (look for "get a comma on the place" in your browser) and also at: http://www.winehq.org/hypermail/wine-devel/2000.10.txt (look for "but then it inserts" in your browser) When the NumLock is ON wine is sending an extra key. Wine deletes the corresponding char but also send a period (.) or a comma (,) <- it depends on the type of the keyboard. In my case, which is a brazilian ABNT2, it sends an extra comma _only_ if the NumLock is ON. It does not mater if I press the <del> key at the numeric key pad or at the "island" that contais the <del> <ins> <home> <end> ... stuff. I am going to open a bug at bugzilla and send the WINEDEBUG=+key (just the piece where the stuff happens). wine=0.9.6 for Mandriva 2006 pre-built by Ivan keyboard=brazilian abnt2 Thanks. --------------------------------------------------------- Ulisses de Sousa Penna Analista Consultor - Banco do Brasil Fone: +55-61-3310-6320 Fax: +55-61-3310-6435 ---------------------------------------------------------

Jan. 27, 2006

setupapi: unimplemented function setupapi.dll.SetupPromptReboot

by Saulius Krasuckas

I stuck upon this function right now. And I see ReactOS folks already have some implementation [*], but for some reason it is disabled. Is anyone working on this for Wine? Any ideas about the ReactOS code? [*] http://www.reactos.org/generated/doxygen/d4/d55/lib_2setupapi_2stubs_8c-sou…

Jan. 27, 2006

Re: setupapi: unimplemented function setupapi.dll.SetupPromptReboot

by James Hawkins

On 1/27/06, Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > I stuck upon this function right now. And I see ReactOS folks already > have some implementation [*], but for some reason it is disabled. > > Is anyone working on this for Wine? > Any ideas about the ReactOS code? > Start off by reading through the msdn documentation of the function: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/setupapi/s… Read through it thoroughly and make note of all the details of the function. Then write as many test cases as you can for the function. Test the details you found on msdn and any other cases you can think of. This should give you a better idea of how to implement the function because you'll understand what needs to happen for each particular case. -- James Hawkins

Jan. 27, 2006

Re: Win32HandleToDosFileHandle / DosFileHandleToWin32Handle

by Eric Pouech

Derek Fawcus wrote: > I'm looking to do some changes to the wine vdm - or more accurately > to the winedos dll to make the handling for some DOS applications > more useful. This is mainly driven from a desire to run DOS apps > without a wineconsole, so using the unix stdin/stdout/stderr as > the DOS file handles. i.e. ala the BSD doscmd program; mind it > also has similar issues (plus I'd have to port it :) > > There are a few things I'll have to alter wrt to the existing console > handling (within winedos), but the main part will be using the JFT > within the PSP/PDB and creating SFTs. not sure what you're exactly trying to achieve. why do you need this ? do you really have programs peeking inside the JFT/SFT structures ? A+ -- Eric Pouech

Jan. 27, 2006

Re: user: fix DrawTextExA/W on empty strings.

by Bill Medland

On January 25, 2006 10:49 am, Rein Klazes wrote: > On Wed, 25 Jan 2006 07:49:57 -0800 (PST), you wrote: > >Hi Rein, > > > >- if (!str) return 0; > >+ if (!str || count == 0) return 0; > > if (count == -1) count = strlenW(str); > >- if (count == 0) return 0; > >+ if (count == 0) { > >+ if( flags & DT_CALCRECT) { > >+ rect->right = rect->left; > >+ rect->bottom = rect->top; > >+ } > >+ return 0; > >+ } > > > >This block will never be reached because of the if (!str || > > count == 0) test above. > > Wrong, look again. > > It can be coded a little bit more efficiently though. I will > make a different patch. > > Rein. > > > Rein. (Apart from the other discussion) are you sure that you really mean that? "If the length is explicitly stated to be zero then don't do the calcrect but if the length is to be measured and happens to come out as zero then do do the calcrect" If so then I suggest at least a comment that it is deliberate; it sounds counterintuitive to me. -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

Jan. 27, 2006

Re: opengl: Sync a dibsection to its pixmap before drawing to it via opengl

by Alexandre Julliard

Huw D M Davies <h.davies1(a)physics.ox.ac.uk> writes: > +void enter_gl(void) > +{ > + GLXContext gl_ctx; > + Wine_GLContext *ctx; > + enum x11drv_escape_codes escape = X11DRV_SYNC_PIXMAP; > + > + wine_tsx11_lock_ptr(); /* unlock in LEAVE_GL */ > + gl_ctx = glXGetCurrentContext(); > + if(!gl_ctx) return; > + ctx = get_context_from_GLXContext(gl_ctx); > + if(!ctx || GetObjectType(ctx->hdc) == OBJ_DC) > + return; > + > + ExtEscape(ctx->hdc, X11DRV_ESCAPE, sizeof(escape), (LPCSTR)&escape, 0, NULL); You cannot make GDI calls while holding the X11 lock, this will deadlock. -- Alexandre Julliard julliard(a)winehq.org

Jan. 27, 2006

Re: StretchDIBits function problem.

by Willie Sippel

Am Freitag, 27. Januar 2006 00:57 schrieb Alex Villacís Lasso: > Cyril Margorin wrote: > > Hello, > > > > I've discovered, that using of GetDIBits after StretchDIBits doesn't > > return correct data. > > More then - all pixels that it returns are black. > > In attachment the test function. > > > > Changelog: > > Cyril Margorin <comargo(a)gmail.com> > > add test of StretchDIBits()/GetDIBits() bunch to gdi/test/bitmap.c > > > > -- > > Cyril Margorin > > > > ------------------------------------------------------------------------ > > Do you know whether this test is related to this bug? - > http://bugs.winehq.org/show_bug.cgi?id=201 > > > Alex Villacís Lasso Also reminds me of my pet-bug: http://bugs.winehq.org/show_bug.cgi?id=1973 So my bug might be a duplicate of 201 then, it seems...? Ciao, Willie -- Willie Sippel //////// | Tritium Studios // | ______________________________ //// /// | http://www.tritium-studios.com <willie(a)froq.net>

Jan. 27, 2006

Re: Global hooks problems (WH_MOUSE_LL)

by Vitaliy Margolen

Thursday, January 26, 2006, 12:43:58 PM, Alexandre Julliard wrote: > Vitaliy Margolen <wine-devel(a)kievinfo.com> writes: >> It does work thank you. The only question I have : does that cover >> WINEVENT_OUTOFCONTEXT hooks too? > No, that's a different mechanism. Do you have evidence that they are > currently broken too? No i was just asking. If it's in the different place then this change shouldn't affect them. Vitaliy.

Jan. 27, 2006

Re: StretchDIBits function problem.

by Jesse Allen

On 1/26/06, Alex Villacís Lasso <a_villacis(a)palosanto.com> wrote: > Cyril Margorin wrote: > > Hello, > > > > I've discovered, that using of GetDIBits after StretchDIBits doesn't > > return correct data. > > More then - all pixels that it returns are black. > > In attachment the test function. > > > Do you know whether this test is related to this bug? - > http://bugs.winehq.org/show_bug.cgi?id=201 > This seems like the black screen with starcraft on battle.net problem. From what I have read before, it comes from not having a real DIB Engine. So I think this is the related bug: http://bugs.winehq.org/show_bug.cgi?id=421 Jesse

Jan. 27, 2006