December 2006 - Wine-Devel - list.winehq.org

Re: Concerning the separate OpenAL32.dll thunk patch and OpenALwinmm driver patch

by Alexandre Julliard

"Nick Burns" <adger44(a)hotmail.com> writes: > Again -- for the sound drivers -- Mac OSX has ONE sound driver ONE > I would like to have a choice. Why? What does it do that you cannot do with the CoreAudio driver? > Yes my wineopenal patch is not perfect (based on broken code does not > help) -- I know that -- but thats why i want to get it into wine -- so > other people who know more about audio can add to it and make it > better Judging from past experience, people for whom it doesn't work right will simply go out and implement yet another driver, with yet another set of bugs... -- Alexandre Julliard julliard(a)winehq.org

Dec. 1, 2006

Re: oleaut32: add VarBstrCmp binary comparison for LCID==0

by Dmitry Timoshkov

"Charles Blacklock" <charles(a)diagnos.co.uk> wrote: > Cool, the attached patch does this now. Is this any better? Yes (although I'd personally move local variables under the "if (lcid == 0)" case), please send it to wine-patches. -- Dmitry.

Dec. 1, 2006

Re: oleaut32: add VarBstrCmp binary comparison for LCID==0

by Charles Blacklock

On Fri, 2006-12-01 at 16:36 +0800, Dmitry Timoshkov wrote: > It would be much more effective to call SysStringByteLen only once for each > string instead of calling it again and again after a failing comparison. Cool, the attached patch does this now. Is this any better? Charles

Dec. 1, 2006

Re: [PATCH 1/9] dinput: Move acquired flag to the base device class.

by Peter Oberndorfer

On Friday 01 December 2006 07:23, Vitaliy Margolen wrote: > Sorry ignore my previous patches. I didn't send them in the proper order. > > --- > dlls/dinput/device.c | 28 ++++++++++++++++++++++++++++ > dlls/dinput/device_private.h | 3 +++ > dlls/dinput/joystick_linux.c | 23 ++++++++--------------- > dlls/dinput/keyboard.c | 36 ++++++++++++++++-------------------- > dlls/dinput/mouse.c | 23 ++++++++--------------- > 5 files changed, 63 insertions(+), 50 deletions(-) > Hi, some questions/notices about this patch: Previously when the device was not acquired inside JoystickAImpl_Unacquire DIERR_NOTACQUIRED was returned. now you call IDirectInputDevice2AImpl_Unacquire, which returns DI_NOEFFECT when not acquired. but DI_NOEFFECT does not have high bit set so it won't trigger the FAILED macro. Do you know if the Acquire/Unacquire functions return value the same for all device types? In JoystickAImpl_Acquire you don't use your new IDirectInputDevice2AImpl_Acquire function but set This->base.acquired = 1; Is there a reason for this? In SysKeyboardAImpl_Unacquire you seem to call IDirectInputDevice2AImpl_Acquire? Greetings Peter

Dec. 1, 2006

Re: oleaut32: add VarBstrCmp binary comparison for LCID==0

by Dmitry Timoshkov

"Charles Blacklock" <charles(a)diagnos.co.uk> wrote: > + if (lcid == 0) > + { > + ret = memcmp(pbstrLeft, pbstrRight, min(SysStringByteLen(pbstrLeft), SysStringByteLen(pbstrRight))); > + if (ret < 0) > + return VARCMP_LT; > + if (ret > 0) > + return VARCMP_GT; > + if (SysStringByteLen(pbstrLeft) < SysStringByteLen(pbstrRight)) > + return VARCMP_LT; > + if (SysStringByteLen(pbstrLeft) > SysStringByteLen(pbstrRight)) > + return VARCMP_GT; > + return VARCMP_EQ; > + } It would be much more effective to call SysStringByteLen only once for each string instead of calling it again and again after a failing comparison. -- Dmitry.

Dec. 1, 2006

Re: user32: Factorize graphics driver's WindowCreate and ShowWindowin user32.

by Dmitry Timoshkov

"Pierre d'Herbemont" <pdherbemont(a)free.fr> wrote: > My patch is wrong, but I am not sure we should leave ShowWindow in > the driver: It contains only Win32 calls (appart from > WINPOS_MinMaximize), and is indeed a wrapper for SetWindowPos. And > the exports are needed for CreateWindow, not ShowWindow. > > What makes me move ShowWindow in user is the call to > WINPOS_MinMaximize which is shared with CreateWindow, and this one > needs the SetIconicState. The problem is that for top level windows we need to route ShowWindow actions to a Window Manager/Host Windowing System, so that actions like minimize/maximize/restore would be properly handled. We don't do this at the moment, but we need to. -- Dmitry.

Dec. 1, 2006

Re: How to embed wine into swt?

by Cloudor Pu

Damjan Jovanovic wrote: > On 11/30/06, Robert Shearman <rob(a)codeweavers.com> wrote: >> There aren't that many GTK experts that work on Wine, so most of us >> won't be able to tell you what you need to do. I suggest you find a >> tutorial for how to embed a plain X11 window from another process using >> GTK and use that as a basis for embedding a Wine window. If you find >> that Wine needs to do something to its X11 windows that it currently >> doesn't do, then email the requirements to this list. > >> -- >> Rob Shearman >> > > Look at GtkPlug and GtkSocket, they implement the XEmbed protocol for > cross-process widget embedding (which is on fd.o). > > Damjan > If I get GtkPlug and GtkSocket worked, then how to embed a wine window into GtkPlug? I can embed GVIM into my app easily because it accept a socketId argument, i.e. "gvim --socketid 6291501" Does wine accept such an argument as GVIM? cloudor

Dec. 1, 2006

Re: Concerning the separate OpenAL32.dll thunk patch and OpenAL winmm driver patch

by Chris Robinson

On Thursday 30 November 2006 10:58, Alexandre Julliard wrote: > Detlef Riekenberg <wine.dev(a)web.de> writes: > > I don't know, if wineaudio.drv this is still the way to go, but we have > > sound crackeling and Buffer-underun Bugs, and adding another copy of > > the "not very well working" code might be a "no go" for Alexandre. > > Exactly, we already have 8 sound drivers, and not a single one > actually works properly, so I'm pretty reluctant to add yet another > copy of the same broken code. I'm curious about how Wine will handle Windows DirectSound drivers. Apparently Creative is working on a dsound->openal wrapper driver, and with the openal dll, it could take a huge load off of Wine in the dsound department for most people if it could work.

Dec. 1, 2006