February 2006 - Wine-Devel - list.winehq.org

Wine compilation error (flex related)

by Elvis Pranskevichus

Hello! Both emerge =wine-0.9.8 and the latest git workdir fail to compile on current Gentoo with: gcc -c -I. -I. -I../../include -I../../include -DINCLUDEDIR="\"/usr/local/include/wine\"" -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wpointer-arith -g -O2 -o lex.yy.o lex.yy.c lex.yy.c:2610: error: parse error before numeric constant lex.yy.c: In function `yy_scan_string': lex.yy.c:2611: error: number of arguments doesn't match prototype lex.yy.c:305: error: prototype declaration lex.yy.c:2613: warning: passing arg 1 of `strlen' makes pointer from integer without a cast lex.yy.c:2613: warning: passing arg 1 of `yy_scan_bytes' makes pointer from integer without a cast make[2]: *** [lex.yy.o] Error 1 make[2]: Leaving directory `/home/el/projects/wine/wine-git/tools/wrc' make[1]: *** [wrc] Error 2 make[1]: Leaving directory `/home/el/projects/wine/wine-git/tools' make: *** [tools] Error 2 The flex --version is flex 2.5.33 (the latest one, released on February 21, 2006). gcc --version is gcc (GCC) 3.4.4 (Gentoo 3.4.4-r1, ssp-3.4.4-1.0, pie-8.7.8) widl and wmc lexers compiled fine. Downgrading to flex 2.5.4a makes everything compile again. Is this a flex issue or is a Wine problem? Thanks, -- Elvis Pranskevichus - elprans(a)gmail.com

Feb. 27, 2006

Re: [wininet] More wininet tests InternetQueryOption and InternetSetOption - Corrected

by Detlef Riekenberg

Am Mittwoch, den 22.02.2006, 23:13 +0530 schrieb Vijay Kiran Kamuju: > Any thing wrong with this patch. > Any Comments (expecting a lot) > As you asked me, i took a look on this Patch. For my winspool-Patches, i was told to check the documented behavior and only check undocumented behavior, when an Application relies on this undocumented effect. It's of course a good Idea, to print as much Informations as possible, when a test Failed (err in your case). When i add a new Test, I add a trace after every tested API-Call, compile the Test on linux with the mingw-crosstools as Windows-Binary (make -C dlls/your_dllname_here/tests crosstest) and run that Binary on all Windows-Versions that I have. After an update to the Parameter and the Text for ok(), I do the tests on Windows again. Then I test that Binary on wine. When there are no Failures left, i remove the traces, compile again, test again, and after a final test in wine with (make -C dlls/your_dllname_here/tests test), the diff is created. - Your Test did not apply here, so i merged the patch by cut & paste. (malformed Patch) - I get 5 Failures on wine. (make -C dlls/wininet/tests test) + hinet = InternetOpenA(useragent,INTERNET_OPEN_TYPE_DIRECT,NULL,NULL, 0); + ok((hinet != 0x0),"InternetOpen Failed\n"); - Please use (hinet != NULL) here, or is MSDN wrong (value / pointer)? - Does the other tests work, when InternetOpenA failed, or is it more useful to return from the test here? + SetLastError(0xdeadbeef); + retval=InternetSetOptionA(hinet,INTERNET_OPTION_USER_AGENT, &inagent, sizeof(inagent)); + err=GetLastError(); + ok(retval == 1,"Got wrong return value %d\n",retval); + ok(err == 0xdeadbeef, "Got wrong error code %ld\n",err); For the Example above, my Idea is: ok(retval, "returned %d with %ld (expected '!= 0')\n", retval, err); + len=0; + SetLastError(0xdeadbeef); + buffer=HeapAlloc(GetProcessHeap(),0,len); + retval = InternetQueryOptionW(hinet,INTERNET_OPTION_USER_AGENT,buffer,&len); + err=GetLastError(); + ok(buffer != NULL,"Output Buffer Should Not be Set"); + todo_wine ok(len == 38,"Got wrong user agent length %ld instead of %d \n",len,38); + - You use HeapAlloc with a len of 0 and than the test "buffer != NULL": This is a Test for HeapAlloc - InternetQueryOptionW is not implemented in win95/98/me - Please avoid fixed numbers. When someone changes the Agent-Name, the complete Test must be reworked. For the tests of the W-Functions: I was told, that i should test the Unicode-Functions only, when there are other results as from the ANSI-Version. Since our ANSI - Implementations should call the Unicode-Function, the ANSI-Test validates both Implementations. (Yes, i knew that the Implementation in wine is sometimes wrong: we have Crosscalls W->A and some Unicode-Functions are stubs while the ANSI-Versions are implemented) + WideCharToMultiByte(CP_ACP,0,(WCHAR *)buffer,-1,tmpbuffer,len,0,0); + todo_wine ok(!strcmp(inagent,tmpbuffer),"Got wrong user agent string % s instead of %s\n",tmpbuffer,inagent); - This Test failed on Windows XP + retval = InternetSetOptionW(NULL,INTERNET_OPTION_USER_AGENT, &inpbuffer, sizeof(inpbuffer)); You use ANSI-Parameter for an UNICODE-Function. You can take a look at the Tests for winspool/GetPrinterDriverDirectory - A test with the documented use to get the required size for the Buffer (buffersize=0) - A test with documented use (all Options valid) - Buffer is larger (must succeed) - Buffer is to small (must fail with a specific ERROR_*) (Other Functions may truncate the returned Data) - without a buffer (NULL), but with the correct buffersize. This is for testing the API, when the app was unable to allocate the Buffer, but did not check the Result of the allocation. So there are some Reasons, why the test is not Ready yet. I read the Docs about InternetQueryOption on MSDN and IMHO there are so many Documented values for dwOption, that I suggest to start with a testing-table and fill it with all of our implemented Options for InternetQueryOption / InternetSetOption. We have then a complete Test of our wininet-Implementation with only a small amount of code. The Table can grow very easy, when Applications use Options that we need to implement. -- By By ... ... Detlef

Feb. 27, 2006

libxml2 use in Wine?

by Gerald Pfeifer

A user reported that when he has libxml2 installed when building Wine, "some apps" work fine whereas without libxml2 he get's warning and errors and reduce functionality. And indeed the configure code and some other part of Wine do refer to libxml2. However, there is now documentation (as verified via `grep -ri libxml2`) that mentions libxml2 in any way. Is there any specific reason, or is this just an omission, and a patch to wine/README would be welcome? Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

Feb. 26, 2006

Re: ddraw.dll

by Segin

Alexander N. Sørnes wrote: > Hello, > > I have found that some Westwood installers, such as the ones for Nox, > C&C Tiberian Sun, C&C Yuri's Revenge and C&C Tiberain Sun: Firestorm > require ddraw.dll to be present in the windows/system 32 directory; if > not, they give a message saying they failed to initialize DirectX. > Can someone submit a patch so this file is created by > wineprefixcreate? ddraw.dll is present system directories of both > Windows 98SE and Windows XP. > > > Regards, > > Alexander N. Sørnes > > > I wouldn't know why it does this, but a highly likely explanation is that the installers dlopen() C:\WINDOWS\DDRAW.DLL using an absolute or semi-absolute (flexible Windows directory, in case Windows is installed on D: or even in "D:\WINNT\") path. It probably also tries to stat() thew file before opening it so that the lack of the file causes an error before it is dlopen()d. A good suggestion is if a DLL file is stat()d in the c:\windows\system(32) directory in Wine, Wine should check it against any .so files in $INSTALLPREFIX/lib/wine, and claim the file exist if a compatable .dll.so is found. Wine should also 'remember' this mapping in case of fopen() or compatable calls.

Feb. 26, 2006

Re: [Linux-NTFS-Dev] Windows Device driver for NTFS

by Anton Altaparmakov

On Sat, 25 Feb 2006, Gerold J. Wucherpfennig wrote: > Can anybody help me to code a little driver for a virtual hard disk drive for > examination of undocumented NTFS filesystem stuctures i.e. the $LOGFILE > (journaling of NTFS)? The data should be written to e.g. C:\image.bin, > filesize e.g. 50MB which will correspond to a drive e.g. Z:, drive size 50MB. > After every write the driver should be paused to examine the C:\image.bin > to get the undocumented structure of the file $LOGFILE? > > Can anybody help me? I'm a little confused by the windows DDK documentation > and tutorials found on the internet. I've already downloaded the windows DDK. > > Please CC me and excuse me for crossposting. Regards, Go to: http://www.acc.umu.se/~bosse/ It will answer all your questions and more. In particular you will probably want a copy of the ntifs.h header file there as well as copy of the FileDisk driver source code (source + binary is in the zip file) which is what you want to write... Instead of pausing you may want to just modify the driver to keep a change log of what it is writing where or to even just create a whole copy of the image every time a write occurs or whatever... Have fun! Note three things: 1) You will want to disable write caching on the "disk" from Windows (can't remember where it is exactly but it is something like "optimize for quick removal" or some simillar name). 2) Note that you will not actually see small modifications to $LogFile because they are all done in memory and only when (one or more?) complete log record pages are done do they get given to the nt cache manager which flushes them to disk. So you are likely to only see 4k or large writes at a time so you will never be able to see the actual fine granularity that you really need to see to figure out the $LogFile internals properly. 3) Look at the current ntfs kernel driver (2.6 kernels) or in ntfsprogs/libntfs in the header file fs/ntfs/logfile.h (kernel) or include/ntfs/logfile.h (ntfsprogs/libntfs) for the restart page definitions and fs/ntfs/logfile.c and libntfs/(somewhere).c for logfile parsin functions. They are pretty advanced in that they properly parse and sanity check the restart areas of a logfile $LogFile and analyse if the volume has been shut down cleanly or not. The only case they cannot tell is when the volume looks like it is dirty but if you were able to actually parse all the log record pages, you would find it to be clean after all (e.g. there was no activity on the system when the power failed so system was idle and no disk activity hence no not checkpointed transactions present) but we can't tell that because we do not understand the log record pages. Oh also there is a book with a high level overview of how logging in Windows/ntfs works. It is "Inside Windows 2000, 3rd Ed" (or "Inside Windows NT, 2nd Ed") [ there may now be a more recent edition, don't know ], this is from Microsoft Press and authors are David Solomon (only author on 2nd Ed) and Mark Russinovich. See http://www.amazon.co.uk/exec/obidos/ASIN/0735610215 Best regards, Anton -- Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/

Feb. 25, 2006

Re: DirectX 8 test: Gothic 2 on wine

by Stefan Dösinger

Hi, > > The gamma problem is known from Diablo 2 > > Is this a new problem? It used to work very well for me ;-) It works in ddraw mode, in d3d mode it's dark > After loading (which is (much?) faster on win32) the performance is okay - > well, it doesn't flicker. But I guess it'll be slower with more textures, > won't it? I don't think so. That some textures are there shows that they are rendered. The missing textures are rendered to, but the texture content is wrong.

Feb. 25, 2006

Re: [PATCH] please commit this FCI work

by Gerold J. Wucherpfennig

On Friday 24 February 2006 22:57, Detlef Riekenberg wrote: > Am Freitag, den 24.02.2006, 14:28 +0100 schrieb Gerold J. Wucherpfennig: > > Please commit. > > I have no knowledge about fci, but some code is strange: > > +#define fci_set_error(A,B,C) \ > + p_fci_internal->perf->erfOper = A; \ > + p_fci_internal->perf->erfType = B; \ > + p_fci_internal->perf->fError = C; > + > > You use SetLastError() for B almost everywhere following the Macro. > Why not add this statement to the Macro? OK, but then there would be a SetLastError(0). I don't know if that's ok. > > Exceptions where you did not use SetLastError(): Macro-Parameter B is 0 > - Did you mean NO_ERROR / ERROR_SUCCESS? > - Does Windows use a SetLastError(NO_ERROR) in this case? > (Tests for cabinet.dll are only in one file: "extract.c". > can you add tests for fci/compress?) I have never used such tests I don't know. And I have very big problems in doing the compression there are two libraries for lzx and deflate compression, but I suppose it's too difficult for me. > > When windows does a SetLastError(NO_ERROR): > append "SetLastError(B)" to the Macro > > When windows does not do a SetLastError(NO_ERROR): > append "if (B) SetLastError(B)" to the Macro > > + /* write error */ > + fci_set_error( FCIERR_TEMP_FILE, ERROR_WRITE_FAULT, TRUE ); > + p_fci_internal->perf->erfType = ERROR_WRITE_FAULT; > + p_fci_internal->perf->fError = TRUE; > + SetLastError(ERROR_WRITE_FAULT); > > the two p_pci_* - lines are duplicates (already done in the Macro) > > btw: What should be added to the changelog? > > cabinet/fci: cleanup error-handling with a MACRO It's not only the macro. The patch is half a year old, so let me think about it... I think there was one bug fixed and the verbose info about the progress was completed. Please CC me.

Feb. 25, 2006

Windows Device driver for NTFS

by Gerold J. Wucherpfennig

Can anybody help me to code a little driver for a virtual hard disk drive for examination of undocumented NTFS filesystem stuctures i.e. the $LOGFILE (journaling of NTFS)? The data should be written to e.g. C:\image.bin, filesize e.g. 50MB which will correspond to a drive e.g. Z:, drive size 50MB. After every write the driver should be paused to examine the C:\image.bin to get the undocumented structure of the file $LOGFILE? Can anybody help me? I'm a little confused by the windows DDK documentation and tutorials found on the internet. I've already downloaded the windows DDK. Please CC me and excuse me for crossposting. Regards, Gerold

Feb. 25, 2006

Re: DirectX 8 test: Gothic 2 on wine

by Olaf Leidinger

Hello! > The sound problem might be quite a lot of work to fix. > You can get sound working when you use the following native dll's: > > dmime > dmsynth > dmstyle > dmusic > > The crash seems to happen inside dmstyle/dmime: > > fixme:dmime:IDirectMusicSegment8Impl_IDirectMusicSegment8_GetParam > (0x7fd35148, GUID_IDirectMusicStyle, 0xffffffff, 0, 0, (nil), 0x7a4fa0) > fixme:dmstyle:IDirectMusicChordTrack_IDirectMusicTrack_GetParam > (0x7fd35738, GUID_IDirectMusicStyle, 0, (nil), 0x7a4fa0): stub > > When you look at the status of the dmusic related dlls on winehq they could use a lot more work. But Gothic seems to use some more exotic functions... Okay, I tried it with native DLLs, the ones above plus dmband. Without native dmband it also crashes. But now the game works with sound. Ciao, Olaf

Feb. 25, 2006

Re: DirectX 8 test: Gothic 2 on wine

by Olaf Leidinger

Hello! > Are you sure that's a d3d8 game? The log only shows d3d7/ddraw output. Sorry, this was my mistake... Ciao, Olaf

Feb. 25, 2006