March 2006 - Wine-Devel - list.winehq.org

Re: May be a bad idea to have Winetools in the next SUSE release

by Tony Lambregts

Jason Green wrote: > On 3/11/06, Tony Lambregts <tony.lambregts(a)gmail.com> wrote: >> In simple terms we get WineTools to query the AppDB with an application name (ie >> somename.exe) and we return a list of applications for the user to choose from >> and the after the user selects the program WineTools gets the appropriate >> overrides from the AppDB and sets them for the user. >> >> I think that that this is do-able if we work together. > > First, great idea. > > Second, here's a [very incomplete] list of what would need to be done > to pull this off: > - AppDB would have to be extended to be able to get and report this > data, and it would make sense for each App's maintainer to be able to > manage that information. > - Biggest issue here is that this information could have a tendency > to change very rapidly, so it might overload the app maintainers if > they had to track this for each version of wine. What I think would > make sense is to have regular snapshots (every 3 months?) and release > a new version of "Winetools Plus" or whatever you want to call this > thing a month later to give the maintainers time to update each of > their apps based on the frozen version. Well how often this should be updated depends on the development of the various dll. If all a program requires wine to emulate Windows 3.1 then it might not need updating ever. > - Data needed: AppID, AppVersionID, WineVersionID, Window Version, DLL > Overrides, Window settings (fullscreen/windowed - sometimes and > issue), Sound options, Video acceleration required, General notes or > HOWTO's, etc. You would need separate overrides/settings for > Installing vs. Running the app. You are right that we will probably need entries for both the installer and the program itself. > - AppDB could dump this information to an xml format which "Winetools > Plus" could be distributed with. Maybe have an option to download the > latest xml file directly from winehq.org. I see this as a dynamic thing as the list could get quite large. and downloading the whole thing for just one program seems excessive. > - The 'Winetools Plus' front-end would just be a menu which would > query all of the apps in the xml dump. The user picks they app they > want to install, and it reads the necessary information, verifies the > source installation media, and goes at it. I think that it would be better if the user entered into WineTools the name of the exe they were trying to run but you may be right about this option > - Applying patches to apps might get tricky (e.g., where wine only > successfully runs version 1.5 of the app, but 1.0 is on the CD), but > I'm sure it could be worked out. We cannot solve all the problems at once. > > Anyway, there's a start. That would encourage users to get involved > in the AppDB reporting process as well as better organize how to just > "get things done" using wine. > I would like to here from Joachim as to what WineTools would need. The main thing I would like to get away from in WineTools is the blanket changes that it now does of making wine emulate windows 95 and use native Dlls by default. Thanks for your input -- Tony Lambregts Tony Lambregts

March 11, 2006

Re: [Bugzilla] Add note to not paste logs and back traces.

by Vitaliy Margolen

Saturday, March 11, 2006, 11:19:57 AM, Rein Klazes wrote: > On Sat, 11 Mar 2006 08:14:03 -0700, you wrote: >>Change Log: Add note to attach and not paste logs and back traces. >> >>Files changed: template/en/default/bug/edit.html.tmpl >>template/en/default/bug/create/create.html.tmpl > Not pasting back traces will make following the bug list by email rather Well it might be true, but to a point. Most of the debug traces are too wide and e-mail wraps them (so does maillist archive). That _does_ make it nearly impossible to see anything. > useless. IMO what people are currently posting in bugzilla do not > require such recommendations. What? You mean having all the pastes in this bug: http://bugs.winehq.org/show_bug.cgi?id=4131 adds to it's readability? This is just one bug that I could think of. Also note that the biggest paste by author has nothing to do with the bug itself. Vitaliy

March 11, 2006

Re: x11drv: One more fix for "stuck" ctrl, shift & alt.

by Tomas Carnecky

Vitaliy Margolen wrote: > Anything wrong with this patch? It does fix the "stuck alt" problem for > games I use alt+tab on. > I can confirm that this fixes the bug. This patch is very important for me as I don't have to switch back and forth between desktop and WoW to un-stuck they alt-key. This patch works fine and I don't see any side-effects. tom

March 11, 2006

Re: [Bugzilla] Add note to not paste logs and back traces.

by Tony Lambregts

Rein Klazes wrote: > On Sat, 11 Mar 2006 08:14:03 -0700, you wrote: > >> Change Log: Add note to attach and not paste logs and back traces. >> >> Files changed: template/en/default/bug/edit.html.tmpl >> template/en/default/bug/create/create.html.tmpl > > Not pasting back traces will make following the bug list by email rather > useless. There is always a link in the email to the attachment. >IMO what people are currently posting in bugzilla do not > require such recommendations. > Well if that was the case there would not be so many comments telling people not to paste[1]. I can only see the situation getting worse as more people report bugs. [1] http://bugs.winehq.org/buglist.cgi?query_format=&short_desc_type=allwordssu… http://bugs.winehq.org/buglist.cgi?query_format=&short_desc_type=allwordssu…'t+paste

March 11, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Jason Green

On 3/11/06, Tony Lambregts <tony.lambregts(a)gmail.com> wrote: > In simple terms we get WineTools to query the AppDB with an application name (ie > somename.exe) and we return a list of applications for the user to choose from > and the after the user selects the program WineTools gets the appropriate > overrides from the AppDB and sets them for the user. > > I think that that this is do-able if we work together. First, great idea. Second, here's a [very incomplete] list of what would need to be done to pull this off: - AppDB would have to be extended to be able to get and report this data, and it would make sense for each App's maintainer to be able to manage that information. - Biggest issue here is that this information could have a tendency to change very rapidly, so it might overload the app maintainers if they had to track this for each version of wine. What I think would make sense is to have regular snapshots (every 3 months?) and release a new version of "Winetools Plus" or whatever you want to call this thing a month later to give the maintainers time to update each of their apps based on the frozen version. - Data needed: AppID, AppVersionID, WineVersionID, Window Version, DLL Overrides, Window settings (fullscreen/windowed - sometimes and issue), Sound options, Video acceleration required, General notes or HOWTO's, etc. You would need separate overrides/settings for Installing vs. Running the app. - AppDB could dump this information to an xml format which "Winetools Plus" could be distributed with. Maybe have an option to download the latest xml file directly from winehq.org. - The 'Winetools Plus' front-end would just be a menu which would query all of the apps in the xml dump. The user picks they app they want to install, and it reads the necessary information, verifies the source installation media, and goes at it. - Applying patches to apps might get tricky (e.g., where wine only successfully runs version 1.5 of the app, but 1.0 is on the CD), but I'm sure it could be worked out. Anyway, there's a start. That would encourage users to get involved in the AppDB reporting process as well as better organize how to just "get things done" using wine. My 2 cents. Jason

March 11, 2006

Re: "IE5 or higher required". Grr.

by Vitaliy Margolen

Saturday, March 11, 2006, 8:27:59 AM, Jeremy White wrote: >> BTW is there are some particular reason that you have to cc every >> single bug that you file to wine-devel mailing as well? I'm sorry, but >> quality of those bugs are not that good really to go directly to >> wine-devel list. With this particular bug you could at least try to find >> what is that program looks at to decide if you do have IE installed or >> not. > I certainly don't want wine-devel to turn into wine-users, > but I think you are wrong to lump Dan's emails into that category. > Dan is a very capable developer; he may not be the most > accomplished Wine hacker, but he is not without his chops. > Note that many of the @ucla.edu patches that come to wine-devel > are from his students. > Further, I think that Dan is triaging issues that are > of fairly critical interest to Wine. > For example, IE dependence is a very hard problem for Wine; > a lot of programs have that as an issue. I, for one, am > grateful to Dan for running with the Windows version > of Firefox, as it helps us be better ready to understand > how to use Firefox to solve that problem. > Further, I happen to know that the Munich considered > using Wine for their desktop migration, and they felt that > Wine was 'awful'; so it is very interesting to me, personally, > to explore why that might be. > Cheers, > Jeremy Ah ok. I want to apologize then. I'm trying to get reasonable bug reports with enough information so any developer can go in and look without downloading giga-bytes of stuff to just get something like WINEDEBUG=warn+all. Also most of the bugs end up being a duplicates of already known problems. In this particular case, I won't be surprised if all that software does is checks for one particular file somewhere in system32 directory. It's long know outstanding problem. I think if we search bugzilla we will come up with at least dozen of files that programs check for in this way. Again, sorry for the extra noise. Vitaliy.

March 11, 2006

Re: [Bugzilla] Add note to not paste logs and back traces.

by Rein Klazes

On Sat, 11 Mar 2006 08:14:03 -0700, you wrote: >Change Log: Add note to attach and not paste logs and back traces. > >Files changed: template/en/default/bug/edit.html.tmpl >template/en/default/bug/create/create.html.tmpl Not pasting back traces will make following the bug list by email rather useless. IMO what people are currently posting in bugzilla do not require such recommendations. Rein.

March 11, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Tony Lambregts

Rich Gilson wrote: > On Thursday 09 March 2006 08:27, Joachim von Thadden wrote: >> What does that mean? We are making a tool to make Windows programs run >> with Wine. We do not develop Wine and our main goal is not to achieve as >> much debugging informations as possible. The goal is to make the usage >> of Wine as easy as possible for users coming from Windows and who are >> customized to point and click interfaces. Again: The goal is not to >> develop Wine. The goal is to use it easy. >> >> Regards >> Joachim von Thadden > > Please don't misunderstand me, I have a great deal of respect for what what > the Wine developers have accomplished so far; however, I feel that those that > have put the effort into Winetools have done so because they saw a need and > filled it. In the realm of ease of use and user-friendliness, Wine is > horribly lacking. Yes, it is getting better, but I think that Winetools is > the closest thing I've seen that would make it so that an average user could > us it. > > IMHO, the Wine developers should spend less time b*tching about Winetools and > more time figuring out how they can 1) build a front-end that is better than > Winetools, or 2) help improve Winetools so that it works more to their liking > but still offers an easy, user-friendly interface. > > Personally, I would like to see an application (be it Winetools or something > else, it doesn't really matter to me) that would interface with the appdb. > You could launch this front-end and it would pull up a list of all the > applications in the appdb that have special "config" files. These files > would tell this front-end EXACTLY what dll overrides are necessary, what > files to run, what needs to be installed beforehand, etc. Then, if there is > ever a change (due to Wine improving support for a particular dll so that an > override is no longer needed, for example) all that would have to be done is > to update the "config" file attached to the program in the appdb and *bingo*, > you've just "update" your front-end! > I think this is a "Good Idea" (tm) There are always going to be programs that need tweaks to get them to run. I know of a few that will work fine just by changing the windows version but fail miserably with a "clean wine" [1]. These programs usually fail in XP as well but it would be nice for the users to have an easy way to get them to run "out of the box" in wine There are others that look for a certain file and if it does not exist the program fails[2]. Just creating an empty file with the appropriate name is often enough to get the program working. This is a class of bug that is sure to be around for a while. The last class of bugs are the ones that require native (windows) DLL's [3]. It would be nice to be able to keep track of these somewhere so that developers know which files need to be worked on Most people are not programmers and even fewer are capable of being developers but if we can find a way to make everyones life easier both developers and users then we should do it. In simple terms we get WineTools to query the AppDB with an application name (ie somename.exe) and we return a list of applications for the user to choose from and the after the user selects the program WineTools gets the appropriate overrides from the AppDB and sets them for the user. I think that that this is do-able if we work together. -- Tony Lambregts [1] http://appdb.winehq.org/appview.php?versionId=4349 [2] http://bugs.winehq.org/show_bug.cgi?id=4796 http://bugs.winehq.org/show_bug.cgi?id=3661 [3] http://bugs.winehq.org/show_bug.cgi?id=4631

March 11, 2006

Re: GL_STENCIL-related build failures in dlls/wined3d/device.c

by Gerald Pfeifer

I've seen half a dozen or more changes to dlls/wined3d/device.c since that message of mine, but appare On Sun, 5 Mar 2006, Gerald Pfeifer wrote: > The recent changes to dlls/wined3d/device.c cause the following build > failures for me on FreeBSD 5.4, though I assume this is in fact not > related to FreeBSD but to xorg 6.8.2 or libglut 6.4.1 on this system. > > device.c: In function `IWineD3DDeviceImpl_SetRenderState': > device.c:3776: error: `GL_STENCIL_BACK_FAIL' undeclared (first use in this function) > device.c:3776: error: (Each undeclared identifier is reported only once > device.c:3776: error: for each function it appears in.) > device.c:3777: error: `GL_STENCIL_BACK_PASS_DEPTH_FAIL' undeclared (first use in this function) > device.c:3778: error: `GL_STENCIL_BACK_PASS_DEPTH_PASS' undeclared (first use in this function) > gmake[2]: *** [device.o] Error 1 > gmake[2]: Leaving directory `/.amd_mnt/nashira/files5/test/wine/dlls/wined3d' > gmake[1]: *** [wined3d] Error 2 > > The most straightforward patch would be the one below, but it leaves > three "variable may be used uninitialized" warnings in the first of the > two affected spots. > > Gerald > > Index: device.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/device.c,v > retrieving revision 1.145 > diff -u -3 -p -r1.145 device.c > --- device.c 4 Mar 2006 17:10:57 -0000 1.145 > +++ device.c 5 Mar 2006 08:35:52 -0000 > @@ -3226,9 +3226,15 @@ HRESULT WINAPI IWineD3DDeviceImpl_SetRen > > GLint action = StencilOp(Value); > > +#ifdef GL_STENCIL_FAIL > glGetIntegerv(GL_STENCIL_FAIL, &stencilFail); > +#endif > +#ifdef GL_STENCIL_PASS_DEPTH_FAIL > glGetIntegerv(GL_STENCIL_PASS_DEPTH_FAIL, &depthFail); > +#endif > +#ifdef GL_STENCIL_PASS_DEPTH_PASS > glGetIntegerv(GL_STENCIL_PASS_DEPTH_PASS, &stencilPass); > +#endif > > if(WINED3DRS_STENCILFAIL == State) { > stencilFail = action; > @@ -3773,9 +3779,15 @@ HRESULT WINAPI IWineD3DDeviceImpl_SetRen > > GLint action = StencilOp(Value); > > +#ifdef GL_STENCIL_BACK_FAIL > glGetIntegerv(GL_STENCIL_BACK_FAIL, &stencilFail); > +#endif > +#ifdef GL_STENCIL_BACK_PASS_DEPTH_FAIL > glGetIntegerv(GL_STENCIL_BACK_PASS_DEPTH_FAIL, &depthFail); > +#endif > +#ifdef GL_STENCIL_BACK_PASS_DEPTH_PASS > glGetIntegerv(GL_STENCIL_BACK_PASS_DEPTH_PASS, &stencilPass); > +#endif > > if(WINED3DRS_CCW_STENCILFAIL == State) { > stencilFail = action; > -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

March 11, 2006

Re: "IE5 or higher required". Grr.

by Jeremy White

> BTW is there are some particular reason that you have to cc every > single bug that you file to wine-devel mailing as well? I'm sorry, but > quality of those bugs are not that good really to go directly to > wine-devel list. With this particular bug you could at least try to find > what is that program looks at to decide if you do have IE installed or > not. I certainly don't want wine-devel to turn into wine-users, but I think you are wrong to lump Dan's emails into that category. Dan is a very capable developer; he may not be the most accomplished Wine hacker, but he is not without his chops. Note that many of the @ucla.edu patches that come to wine-devel are from his students. Further, I think that Dan is triaging issues that are of fairly critical interest to Wine. For example, IE dependence is a very hard problem for Wine; a lot of programs have that as an issue. I, for one, am grateful to Dan for running with the Windows version of Firefox, as it helps us be better ready to understand how to use Firefox to solve that problem. Further, I happen to know that the Munich considered using Wine for their desktop migration, and they felt that Wine was 'awful'; so it is very interesting to me, personally, to explore why that might be. Cheers, Jeremy

March 11, 2006

Re: "IE5 or higher required". Grr.

by Dan Kegel

On 3/10/06, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: > BTW is there are some particular reason that you have to cc every > single bug that you file to wine-devel mailing as well? I'm sorry, but > quality of those bugs are not that good really to go directly to > wine-devel list. The two apps I posted about yesterday were ones that a European city needed for its transition to desktop Linux, so they seemed important enough to post about. But if others think I'm spamming the devel list, I can certainly stop. > With this particular bug you could at least try to find > what is that program looks at to decide if you do have IE installed or > not. I did look at WINEDEBUG=+reg, but didn't see anything obvious. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 11, 2006

Re: Francois Gouget : user32: Handle WM_ENDSESSION in DefWinProc().

by Rein Klazes

On Fri, 24 Feb 2006 14:29:45 -0600, you wrote: >Author: Francois Gouget <fgouget(a)codeweavers.com> >Date: Fri Feb 24 15:34:09 2006 +0100 > >user32: Handle WM_ENDSESSION in DefWinProc(). >DefWinProc() should call PostQuitMessage() on WM_ENDSESSION if the >shutdown is proceeding. Hi Francois, This patch is causing a problem in Pegasus Mail. Closing some dialogs cause termination of the complete program. Here is a part of SPY++ log when run under win2000, when I close the edit new mail dialog: |<00202> 00130A82 S ..........................WM_SYSCOMMAND uCmdType:SC_CLOSE xPos:672 yPos:121 [wParam:0000F060 lParam:007902A0] |<00203> 00130A82 S ...........................WM_CLOSE wParam:00000000 lParam:00000000 |<00204> 00130A82 S ............................WM_QUERYENDSESSION nSource:1 (End Task from Task List dialog) [wParam:00000001 lParam:00000000] |<00951> 00130A82 R ............................WM_QUERYENDSESSION fShutdownIsOk:True [lResult:00000001] ... |<00952> 00130A82 S ............................WM_ENDSESSION fEndSession:True [wParam:00000001 lParam:00000000] |<00953> 00130A82 R ............................WM_ENDSESSION lResult:00000000 The WM_QUERYENDSESSION and WM_ENDSESSION are sent by the program: |0009:Call user32.SendMessageA(00030024,00000011,00000001,00000000) ret=0040641d How did you check the behavior of the Windows DefWindowProc? If I put a DefWindowProc(hwnd, WM_ENDSESSION, 1, 0); some where in a windows program nothing happens, while a PostQuitMesage certainly closes the app. Rein.

March 11, 2006

Re: "IE5 or higher required". Grr.

by Vitaliy Margolen

Friday, March 10, 2006, 11:53:24 PM, Dan Kegel wrote: > On 3/10/06, Dan Kegel <dank(a)kegel.com> wrote: >> I heard KeepTool was an app used by some government >> developers, so I tried installing the free trial from http://keeptool.com. >> Sadly, the installer complained I needed IE5 or later. > Filed at http://bugs.winehq.org/show_bug.cgi?id=4796 > - Dan > -- > Wine for Windows ISVs: http://kegel.com/wine/isv Well I guess that's the one that does need the IE installed. There are lots of programmes that relay on some functionality provided by IE. Doesn't matter if they really need it or not. BTW is there are some particular reason that you have to cc every single bug that you file to wine-devel mailing as well? I'm sorry, but quality of those bugs are not that good really to go directly to wine-devel list. With this particular bug you could at least try to find what is that program looks at to decide if you do have IE installed or not. Vitaliy Margolen.

March 11, 2006

Re: "IE5 or higher required". Grr.

by Dan Kegel

On 3/10/06, Dan Kegel <dank(a)kegel.com> wrote: > I heard KeepTool was an app used by some government > developers, so I tried installing the free trial from http://keeptool.com. > Sadly, the installer complained I needed IE5 or later. Filed at http://bugs.winehq.org/show_bug.cgi?id=4796 - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 11, 2006

"IE5 or higher required". Grr.

by Dan Kegel

I heard KeepTool was an app used by some government developers, so I tried installing the free trial from http://keeptool.com. Sadly, the installer complained I needed IE5 or later. The registry key trick I've been using, [Software\\Microsoft\\Internet Explorer] "Version"="6.0.2900.2180" didn't seem to do the trick this time. Any suggestions on how to get past that? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 11, 2006

spss can't even install...

by Dan Kegel

I heard that SPSS was one of the apps governments like (so they crunch statistics -- who knew? :-), so I tried running the free eval. It wouldn't even install. The problems were already described in http://bugs.winehq.org/show_bug.cgi?id=4700 Looks like an msi problem, but there might be something more general wrong; all wine apps hang for about twenty seconds at a certain point during the install, which is pretty strange. - Dan p.s. one downside of using wine to run firefox as your main browser is it's a bit more dangerous to do the rm -rf ~/.wine needed to do a really clean install of a test app :-) so this test was done with a fairly cluttered fake wine directory. But it seems to match the results in the PR. -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 11, 2006

Re: AlphaImageLoader - tranparent pngs 4 IE

by Mike Hearn

If you register and use a native dxtrans.dll it may work. On Wed, 08 Mar 2006 16:48:23 +0100, Axel Huizinga wrote: > Hi! > > Did anybody get DXImageTransform.AlphaImageLoader working > to render transparent png in IE on wine? > > Cordially, > Axel

March 10, 2006

Re: winegdb: Fix crash in empty first command

by Eric Pouech

Eric Pouech wrote: > Vitor T. Sessak wrote: > >> 2006/3/7, Eric Pouech >> >>> >>> 2006/3/6, Vitor T. Sessak <vitor.sessak at m4x.org >>> <http://www.winehq.org/mailman/listinfo/wine-patches>>: >>> >>>> / >> >> >> />>/ Changelog: >> />>/ winegdb: Fix crash in empty first command >> />>/ >> />>/ Winedbg crashes when pressing enter as its first command. >> /> >> >>> >>> this is wrong as the last_line will be HeapFree'd when the next >>> command is >>> keyed in. >> >> >> >> You are right. I've changed it and fixed the FIXME too. > > your new code leaks the lines (you never free them) to be more precise, when you copy the pointers, both last and this refer to the same buffer, which is not what you want you should duplicate the buffer A+ -- Eric Pouech

March 10, 2006

Re: winegdb: Fix crash in empty first command

by Eric Pouech

Vitor T. Sessak wrote: > 2006/3/7, Eric Pouech > >> >> 2006/3/6, Vitor T. Sessak <vitor.sessak at m4x.org >> <http://www.winehq.org/mailman/listinfo/wine-patches>>: >> >>> / > > />>/ Changelog: > />>/ winegdb: Fix crash in empty first command > />>/ > />>/ Winedbg crashes when pressing enter as its first command. > /> > >> >> this is wrong as the last_line will be HeapFree'd when the next >> command is >> keyed in. > > > You are right. I've changed it and fixed the FIXME too. your new code leaks the lines (you never free them) A+ -- Eric Pouech

March 10, 2006

Re: riched20: Implements FR_WHOLEWORD for EM_FINDTEXT

by Lei Zhang

On Monday 06 March 2006 11:06 am, you wrote: > Lei Zhang <leiz(a)ucla.edu> writes: > > --- dlls/riched20/editstr.h 2 Mar 2006 11:18:19 -0000 1.27 > > +++ dlls/riched20/editstr.h 5 Mar 2006 06:36:50 -0000 > > @@ -29,6 +29,7 @@ > > #include <stdarg.h> > > #include <stdio.h> > > #include <stdlib.h> > > +#include <wctype.h> > > You can't use anything from wctype.h in Wine. Use the functions from > wine/unicode.h instead. Hi Alex, I did not know wctype.h is unusable in Wine. Is this documented anywhere? I took a quick glance around the site and did not see much information regarding i18n. Anyway, I posted a revised patch to wine-patches earlier in the week: http://www.winehq.org/pipermail/wine-patches/2006-March/024848.html - Lei

March 10, 2006

Re: WINED3D: Color fixups for vertex shaders

by H. Verbeet

On 10/03/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Because reg is set to 6 in the declaration, this translates to specular > because VertexDecl8_Registers[6] corresponds to specular. Yes, but that shouldn't make it into the arrayUsageMap. ArrayUsageMap defines usage, but in this case we don't know how the data will be used.

March 10, 2006

Re: WINED3D: Color fixups for vertex shaders

by Roderick Colenbrander

> Either way, arrayUsageMap doesn't get initialised correctly. If we > don't know what's in a register, we shouldn't pass it through > arrayUsageMap, but use some other way. > > I won't be around next week, but after that I'll probably try to have > a look at d3d8 shaders. > The declaration is converted to a d3d9 shader in parsedeclaration8. The function parsetoken8 handles the conversion of a token. In this case the following code is entered: case D3DVSD_TOKEN_STREAMDATA: if (token & 0x10000000) { TRACE(" 0x%08lx SKIP(%lu)\n", token, ((token & D3DVSD_SKIPCOUNTMASK) >> D3DVSD_SKIPCOUNTSHIFT)); } else { DWORD type = ((token & D3DVSD_DATATYPEMASK) >> D3DVSD_DATATYPESHIFT); DWORD reg = ((token & D3DVSD_VERTEXREGMASK) >> D3DVSD_VERTEXREGSHIFT); ERR("reg: %d\n", reg); TRACE(" 0x%08lx REG(%s, %s)\n", token, VertexDecl8_Registers[reg], VertexDecl8_DataTypes[type]); } Because reg is set to 6 in the declaration, this translates to specular because VertexDecl8_Registers[6] corresponds to specular. Someone in #winehackers thought that perhaps your code should only be called for FVF shaders. Roderick -- Bis zu 70% Ihrer Onlinekosten sparen: GMX SmartSurfer! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer

March 10, 2006

Re: WINED3D: Color fixups for vertex shaders

by H. Verbeet

On 10/03/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > I have walked through the code. This small demo (dolphinvs from dx8.1 sdk) > uses the following vertex declaration for the seafloor: > D3DVSD_STREAM( 0 ), > D3DVSD_REG( 0, D3DVSDT_FLOAT3 ), // Position of first mesh > D3DVSD_REG( 3, D3DVSDT_FLOAT3 ), // Normal > D3DVSD_REG( 6, D3DVSDT_FLOAT2 ), // Tex coords > D3DVSD_END() > > It stores texture coordinates in register 6 (D3DVSD_SPECULAR). Registers > should be general purpose I think and this should work fine. Your patch > assumes that 'D3DVSD_SPECULAR' is allways used for colors which should be > swizzled. Well, no. It assumes that arrayUsageMap[WINED3DSHADERDECLUSAGE_SPECULAR] contains the register number for the register that is used to store specular colors, or -1 if there are no specular colors. loadNumberedArrays() in drawprim.c uses arrayUsageMap in the same way. > Because we are storing texture coordinates in them they shouldn't > be swizzled but we don't know what is stored in them. I'm not sure how to > fix this bug but I think the code should be moved to a later stage. I don't think that will work. We really need to know if a certain block of data is going to be used for colors or not, or we can't fix the data, in the shader or otherwise. Also, we have to fix the data before it gets passed to the shader or on input, we can't do it on output because other components (with the correct color order) might have been added in the shader. Either way, arrayUsageMap doesn't get initialised correctly. If we don't know what's in a register, we shouldn't pass it through arrayUsageMap, but use some other way. I won't be around next week, but after that I'll probably try to have a look at d3d8 shaders.

March 10, 2006

Re: ddraw design flaw

by Stefan Dösinger

Hi, > I have found a design flaw in ddraw and described it in my 'World of > Warcraft 0.10 Public Test Real (PTR)' thread. Why has nobody adressed > this issue? In my eyes it is a severe design flaw if an application > can't unload ddraw.dll without side effects (especially if this > side-effect is that all opengl/directx applications are unusable after > that). The ddraw implementation has some unloading bugs at the moment. Not restoring the glx context(that's the problem you reported, right) is only one of them. Another is that the screen resolution isn't restored when the app doesn't care for releasing it's object. I have this problem in mind, and I'll check WineD3D for it, as it most likely affects all D3D libs. Once it's fixed in wineD3D and ddraw uses wineD3D for rendering, this should be sorted out. Sorry for not fixing this at once, but time is limited ;). If you want a solution now, you're free to fix ddraw. But I registered that issue and it's on my lenghty todo list.

March 10, 2006

Re: WINED3D: Color fixups for vertex shaders

by Roderick Colenbrander

> In particular, is it the fixup for DIFFUSE, SPECULAR or either that > causes the problem? What are the values for reg, > arrayUsageMap[WINED3DSHADERDECLUSAGE_DIFFUSE] and > arrayUsageMap[WINED3DSHADERDECLUSAGE_SPECULAR]? > > It looks like texture coordinates are wrong, but those shouldn't be > affected by this patch, do you initialise arrayUsageMap correctly? > > I have walked through the code. This small demo (dolphinvs from dx8.1 sdk) uses the following vertex declaration for the seafloor: D3DVSD_STREAM( 0 ), D3DVSD_REG( 0, D3DVSDT_FLOAT3 ), // Position of first mesh D3DVSD_REG( 3, D3DVSDT_FLOAT3 ), // Normal D3DVSD_REG( 6, D3DVSDT_FLOAT2 ), // Tex coords D3DVSD_END() It stores texture coordinates in register 6 (D3DVSD_SPECULAR). Registers should be general purpose I think and this should work fine. Your patch assumes that 'D3DVSD_SPECULAR' is allways used for colors which should be swizzled. Because we are storing texture coordinates in them they shouldn't be swizzled but we don't know what is stored in them. I'm not sure how to fix this bug but I think the code should be moved to a later stage. Swizzling won't be done in the shader then :( Roderick -- Bis zu 70% Ihrer Onlinekosten sparen: GMX SmartSurfer! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer

March 10, 2006

ddraw design flaw

by Tomas Carnecky

I have found a design flaw in ddraw and described it in my 'World of Warcraft 0.10 Public Test Real (PTR)' thread. Why has nobody adressed this issue? In my eyes it is a severe design flaw if an application can't unload ddraw.dll without side effects (especially if this side-effect is that all opengl/directx applications are unusable after that). So please, will someone explain me why nobody wants to fix this? It's nothing bad now, but if WoW still loads Survey.dll (and thus ddraw.dll) in the final public release many people will demand a fix. Very few people play on the PTR, but there are quite a lot who play WoW under wine.. and they will not be happy if they can't play anymore. tom

March 10, 2006

Re: DDraw->WineD3D refcounting hack

by Stefan Dösinger

> You could have a function to explicitly destroy the object, regardless > of reference count. However, I think that one already got mentioned > last time :-) :-) Yes, that was mentioned, and indeed I have one internal function, mainly for code readability. The problem is that I can't destroy the sublevel surfaces when the root surface is destroyed, I have to wait until the WineD3DTexture is destroyed. In most cases, this is equal, and the root surface holds the only reference to the WineD3DTexture, but in some cases WineD3D holds an internal reference. If I just destroy the sublevels with the root, then WineD3D will get angry(aka crash) because I take away the Textures surfaces. The first wineD3D surface survives because it's parent is an IParent object, and destroying the root surface does only Release the WineD3DTexture, not the WineD3DSurface.

March 10, 2006

Re: Trying to fix bug 2400 - delete and comma

by Marin Glibic

agaro wrote: > Only posting here a litle news about this thread subject. > I sent an patch to fix this problem: > http://www.winehq.org/pipermail/wine-patches/2006-March/024891.html > Works for your keyboard layout? Please, let me know! :) works great for croatian. hooray!

March 10, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Tom Wickline

On 3/9/06, Joachim von Thadden <thadden(a)web.de> wrote: > > > This leads to many users asking for help in #winehq on freenode. > > But nobody there wants to support winetools and thus can only > > suggest them to remove their .wine and redo it without winetools > > (which usually makes it work). > > Yes, this is true. As we are a freetime project we have not the time to > sit on an IRC channel. But there is always > > a) this mailinglist where we sit and listen > b) the possibility to mail us directly > Hello, I don't believe you would have to spend all of your free time sitting on a # winetools IRC channel. The channel could maintained by current users.. You know, users helping users kinda thing. And if you guys have some extra time to spend on the channel fine if you don't that would be fine as well. The way it is now WineTools users don't have a mailing list, a IRC channel or forum to ask questions or any real way to seek help other than sending you a direct mail. And experienced users don't have any of these venues to help people. Just my $.02 Tom

March 9, 2006

Re: Use a property for the colour dialog's information.

by Mike McCormack

>> - SetWindowLongPtrW(hDlg, DWLP_USER, 0); /* we >> don't need it anymore */ >> + SetPropW( hDlg, szColourDialogProp, lpp ); > SetPropW( hDlg, szColourDialogProp, lpp ) should be SetPropW( hDlg, > szColourDialogProp, NULL ). That's what I get for writing code at 1am after a couple of beers :/ It probably should be RemovePropW. Mike

March 9, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Mike McCormack

Rich Gilson wrote: > On Thursday 09 March 2006 08:27, Joachim von Thadden wrote: >>customized to point and click interfaces. Again: The goal is not to >>develop Wine. The goal is to use it easy. I think you'd have alot more friends around here if your goal was to help develop Wine. As it stands, WineTools somewhat impedes testing and bug reporting of Wine versions of dlls (eg. ole32, oleaut32, rpcrt4) since you encourage your users to use Windows versions of those dlls, even though the Wine ones work for many applications. > IMHO, the Wine developers should spend less time b*tching about Winetools and > more time figuring out how they can 1) build a front-end that is better than > Winetools, or 2) help improve Winetools so that it works more to their liking > but still offers an easy, user-friendly interface. As Joachim states, his "goal is not to develop Wine". That's kind of incompatible with the goals of "Wine developers", isn't it? Mike

March 9, 2006

Re: dinput: Create single thread for mouse and keyboard hook procs. [try 3]

by Vitaliy Margolen

Any problems with this patch? I have not received any additional comments. And it does fix at least two games in question (see bug reports). And I have not seen any side-affects from it either. Vitaliy Margolen Wednesday, February 22, 2006, 8:10:16 AM, Vitaliy Margolen wrote: > ChangeLog: > dinput: Create single thread for mouse and keyboard hooks. > Put keyboard & mouse hook callbacks into separate thread. > Move few global variables into object. Delete no longer used crit section. > For hooks to work properly hook callback have to be in a thread > with message loop. Some games create separate threads just to handle > mouse and/or keyboard events that do not have message loop. This patch fixes > such games (Bug 4264) - mouse and (Bug 2981) - keyboard. > Try#2 (based on suggestions from Alexandre): > Using a message window in a dedicated thread with normal message loop. > Hooks are installed and removed using SendMessage to this window. > Only one mouse and one keyboard hook is permitted. > Hook handles are managed by dedicated thread and not given back to > caller. > Try#3 (with Robs suggestions) > Use critical section. > dlls/dinput/device.c | 132 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/dinput/device_private.h | 2 + > dlls/dinput/keyboard.c | 130 > ++++++++++++++++------------------------- > dlls/dinput/mouse.c | 33 ++++------- > 4 files changed, 195 insertions(+), 102 deletions(-)

March 9, 2006

Re: x11drv: One more fix for "stuck" ctrl, shift & alt.

by Vitaliy Margolen

Anything wrong with this patch? It does fix the "stuck alt" problem for games I use alt+tab on. Vitaliy Margolen Tuesday, February 21, 2006, 10:30:39 PM, Vitaliy Margolen wrote: > ChangeLog: > x11drv: One more fix for "stuck" ctrl, shift & alt. > DInput needs scan code with each event - make sure we send one. > Also don't loose key state change events in mouse.c > I tested this with Keyboard DInput sample from DXSDK. It clearly showed > that we are loosing these events when focus is being changed. > dlls/x11drv/keyboard.c | 10 +++++----- > dlls/x11drv/mouse.c | 6 ++++-- > dlls/x11drv/x11drv.h | 2 ++ > 3 files changed, 11 insertions(+), 7 deletions(-)

March 9, 2006

Re: x11drv: Fix one case of "glXChooseFBConfig returns NULL" problem.

by Vitaliy Margolen

Anything wrong with this patch? According to MSDN ChoosePixelFormat should pick closest mode, but not fail. Vitaliy Margolen Saturday, March 4, 2006, 10:27:11 PM, Vitaliy Margolen wrote: > ChangeLog: > x11drv: Fix one case of "glXChooseFBConfig returns NULL" problem. Using alpha bits >> 8 makes this function fail, while it should not. > dlls/x11drv/opengl.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-)

March 9, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Rich Gilson

On Thursday 09 March 2006 08:27, Joachim von Thadden wrote: > Am Thu, Mar 09, 2006 at 01:41:06PM +0100 schrieb Jan Zerebecki: > > I think a quote from http://www.winehq.org/site/download somewhat > > sums up the cencus on this list regarding Winetools: "WineTools > > [is] only recommended if installation or operability of Windows > > software failed on pure Wine. Since WineTools radically alters > > your Wine configuration please do not report bugs in programs > > with WineTools installed. Instead contact the author of WineTools > > Joachim von Thadden." > > As there are arguments floating around about WineTools that are > definitely not correct I think I have to make some things here clear. > > > Some other facts: > > > > Winetools is only sporadically updated for new versions of Wine > > (as http://www.von-thadden.de/Joachim/WineTools/ indicates; this > > site also contains some warnings regarding the support status). > > WineTools is not "sporadically" updated as it makes no sense to update > it with every new Wine release. The purpose is not to keep track Wine, > the purpose is to have a stable basis. As such WineTools often stays > with a specific Wine version for a time. This is the same what > Crossover-Office does. So you would also not include that if you were > allowed to? > The reality that I have come up with is this: Even following the instructions provided in the appdb to install IE6 (which is necessary for almost anything else to work properly) I can't seem to get it to install properly. When I run an install through Winetools, it works flawlessly. When I try to install TurboTax under "pure" Wine, it fails miserably without having to do dll overrides and such. When I install it under Winetools, I have no problems getting it to run without having to tweak the hell out of it. > > Winetools radically alters some vital Wine settings and thus > > makes many other apps fail. > > This first part is true, the second definitely not. WineTools is at the > moment the only way to have all major commercial windows programs run > simultaneously with Wine under Linux if you do not want to pay for > Crossover-Office. > > If what you say is true then name the apps that fail with WineTools and > run with *plain* Wine. I am waiting for your list. And I will include > them in the next release (if I can download them legaly). > > > This leads to many users asking for help in #winehq on freenode. > > But nobody there wants to support winetools and thus can only > > suggest them to remove their .wine and redo it without winetools > > (which usually makes it work). > > Yes, this is true. As we are a freetime project we have not the time to > sit on an IRC channel. But there is always > > a) this mailinglist where we sit and listen > b) the possibility to mail us directly > > Again: I am nosy to know which apps work after removing a WineTools > .wine. > > > Currently no Winetools developer works closely with the Wine > > developers to correct problems of interaction between Winetools > > and Wine. > > What does that mean? We are making a tool to make Windows programs run > with Wine. We do not develop Wine and our main goal is not to achieve as > much debugging informations as possible. The goal is to make the usage > of Wine as easy as possible for users coming from Windows and who are > customized to point and click interfaces. Again: The goal is not to > develop Wine. The goal is to use it easy. > > Regards > Joachim von Thadden Please don't misunderstand me, I have a great deal of respect for what what the Wine developers have accomplished so far; however, I feel that those that have put the effort into Winetools have done so because they saw a need and filled it. In the realm of ease of use and user-friendliness, Wine is horribly lacking. Yes, it is getting better, but I think that Winetools is the closest thing I've seen that would make it so that an average user could us it. IMHO, the Wine developers should spend less time b*tching about Winetools and more time figuring out how they can 1) build a front-end that is better than Winetools, or 2) help improve Winetools so that it works more to their liking but still offers an easy, user-friendly interface. Personally, I would like to see an application (be it Winetools or something else, it doesn't really matter to me) that would interface with the appdb. You could launch this front-end and it would pull up a list of all the applications in the appdb that have special "config" files. These files would tell this front-end EXACTLY what dll overrides are necessary, what files to run, what needs to be installed beforehand, etc. Then, if there is ever a change (due to Wine improving support for a particular dll so that an override is no longer needed, for example) all that would have to be done is to update the "config" file attached to the program in the appdb and *bingo*, you've just "update" your front-end! I say I would like to see it because I do not personally have the requisite programming skill to accomplish such a task, but I'm convinced it could be done and that there are programmers out there in the Wine community that would easily be able to accomplish such a task. This whole Wine/Winetools argument has been a thorn in my side for a while because I see both sides of the argument and can understand both stances. However, I'm also watching and not seeing any compromise being made. It's like both sides have formed ranks and dug in. It's not my intention to just whine and cry about things, but I'm not in a position to directly help. What I can do is offer my ideas and opinions. I have I haven't pissed too many people off because that was not my intention. I do look forward to every new release of Wine that comes out, hoping that it's that much closer to allowing me to leave Windows behind for good. -- -- In a world without fences, who needs Gates?

March 9, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Sven.Paschukat＠t-online.de

Marcus Meissner schrieb: > Hmm, I have some kind of recommendation here. > > What about winetools using ".winetools" as WINEPREFIX setting? > > This would make it possible to keep a ".wine" for the purists, and > ".winetools" for the "just get things done" people. > > Up to now winetools does not seem to honor a WINEPREFIX setting > (also a bug I think). > > Ciao, Marcus Hey, you steal Joachim's ideas ;-) That's one point we have discussed in similar form. One directory for the present winetools mode and another for a new builtin mode where winetools just acts as a menu driven loader and installer. Sven

March 9, 2006

Updated DDraw over WineD3D patch

by Stefan Dösinger

Hi, I've uploaded anothe update of my DDraw->WineD3D patch to http://stud4.tuwien.ac.at/~e0526822/. It fixes some refcounting issues and the D3D renderer of the Half-Life 1 Steam version works. It also takes the merged header patches into account ;) I am quite busy the next time, so I won't be able to do a lot ddraw development. I'll continue to send patches, but only header changes, no added functionality. I'll keep myself up to date and anser feedback mails, but I don't think I've the time to do intensive development. I expect I can continue in April. Have fun playing, Stefan

March 9, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Hiji

> Hmm, I have some kind of recommendation here. > > What about winetools using ".winetools" as > WINEPREFIX setting? > > This would make it possible to keep a ".wine" for > the purists, and > ".winetools" for the "just get things done" people. > > Up to now winetools does not seem to honor a > WINEPREFIX setting > (also a bug I think). Seperating .wine and .winetools would be cool. In fact, the only reason I don't use winetools is because it "dilutes" my pure wine install. Just tossing in my 2 cents! Hiji __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

March 9, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Marcus Meissner

> > Currently no Winetools developer works closely with the Wine > > developers to correct problems of interaction between Winetools > > and Wine. > > What does that mean? We are making a tool to make Windows programs run > with Wine. We do not develop Wine and our main goal is not to achieve as > much debugging informations as possible. The goal is to make the usage > of Wine as easy as possible for users coming from Windows and who are > customized to point and click interfaces. Again: The goal is not to > develop Wine. The goal is to use it easy. Hmm, I have some kind of recommendation here. What about winetools using ".winetools" as WINEPREFIX setting? This would make it possible to keep a ".wine" for the purists, and ".winetools" for the "just get things done" people. Up to now winetools does not seem to honor a WINEPREFIX setting (also a bug I think). Ciao, Marcus

March 9, 2006

Re: Trying to fix bug 2400 - delete and comma

by Sven.Paschukat＠t-online.de

agaro schrieb: > Works for your keyboard layout? Please, let me know! :) Fixes the bug in my german layout :-) Sven

March 9, 2006

Re: Trying to fix bug 2400 - delete and comma

by agaro

Only posting here a litle news about this thread subject. I sent an patch to fix this problem: http://www.winehq.org/pipermail/wine-patches/2006-March/024891.html Works for your keyboard layout? Please, let me know! :) []s agaro

March 9, 2006

Re: DDraw->WineD3D refcounting hack

by H. Verbeet

On 09/03/06, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Is such a thing acceptable for Wine? Does anyone have a better solution? If > you need some code to look at, I'll upload an updated patch to my homepage > later. You could have a function to explicitly destroy the object, regardless of reference count. However, I think that one already got mentioned last time :-)

March 9, 2006

DDraw->WineD3D refcounting hack

by Stefan Dösinger

Hello, I have a a question regarding some code that might be rejected by Alexandre when I submit it. The problem is that I have to do an refcount hack in my new ddraw code to destroy textures properly. I CC this mail to AJ because it's him who has the last word ;) WineD3D and Direct3D7 have different ideas about handling mipmap textures. In d3d7 they are complex surfaces - a bunch of surfaces with a root and sublevels. All surfaces in the compound have their own refcount, but they are all destroyed when the root is destroyed. In WineD3D there's the texture as a container, and the surfaces in the container have their refcount linked to the container(See the patch H. Verbeet sent a few days ago). In d3d7 the application destroys the first surface to release the whole texture. My first idea was to Release the WineD3DTexture. It would then call the Release method of all the sublevel ddraw surfaces, which would destroy them. This works for a correctly written application, but applications call GetAttachedSurface for the sublevels, which addrefs, and many do not Release the sublevels after GetAttachedSurface(). This leaves the sublevel surfaces with a refcount of 2 or more when the root is destroyed. To make sure that they are destroyed, I set their refcount to 1 when the root is destroyed. When the last reference to the WineD3D Texture is released, wineD3D will destroy the sublevel surfaces. Is such a thing acceptable for Wine? Does anyone have a better solution? If you need some code to look at, I'll upload an updated patch to my homepage later. Thanks, Stefan

March 9, 2006

ChangeDisplaySettings

by Jan Dvorak

While trying to run Scratches game, the game tries to set fullscreen resolution but fails - heres the log: trace:x11settings:X11DRV_EnumDisplaySettingsEx mode -1 (current) -- getting current mode (desktop) trace:x11settings:X11DRV_EnumDisplaySettingsEx mode 0 -- 800x600x32bpp (desktop) trace:x11settings:X11DRV_ChangeDisplaySettingsEx ((null),0x406bf9cc, (nil),0x00000004,(nil)) trace:x11settings:X11DRV_ChangeDisplaySettingsEx flags=FULLSCREEN trace:x11settings:X11DRV_ChangeDisplaySettingsEx DM_fields=BITSPERPEL,PELSWIDTH,PELSHEIGHT,DISPLAYFREQUENCY trace:x11settings:X11DRV_ChangeDisplaySettingsEx width=0 height=0 bpp=32 freq=0 (desktop) err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found! (desktop) it's the second game i encountered trying to do this (calling changedisplaysettings with PELSWIDTH and PELSHEIGHT masks set but setting the values of width and height itself to 0 ). It is buggy application ? Or some undocumented hack in winapi? Or error in wine ? And if it is, what can we do about it (as the games itself runs perfectly otherwise , just windowed ) ? Thanks. JD

March 9, 2006

Re: Use a property for the colour dialog's information.

by Robert Shearman

Mike McCormack wrote: >@@ -1217,7 +1220,7 @@ static INT_PTR CALLBACK ColorDlgProc( HW > DeleteDC(lpp->hdcMem); > DeleteObject(lpp->hbmMem); > HeapFree(GetProcessHeap(), 0, lpp); >- SetWindowLongPtrW(hDlg, DWLP_USER, 0); /* we don't need it anymore */ >+ SetPropW( hDlg, szColourDialogProp, lpp ); > > SetPropW( hDlg, szColourDialogProp, lpp ) should be SetPropW( hDlg, szColourDialogProp, NULL ). -- Rob Shearman

March 9, 2006

Re: WINED3D: Color fixups for vertex shaders

by H. Verbeet

On 09/03/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > In my local tree I have some simple d3d8 shaders working. (See for instance > http://roderick.student.utwente.nl/dolphin1.png and dolphin2.png on windows; > there's some color issue but apart from that it works). This patch causes in > combination with the other vshader patch you sent some drawing issues. Check > http://roderick.student.utwente.nl/dolphin3.png Any idea why that could be happening? In particular, is it the fixup for DIFFUSE, SPECULAR or either that causes the problem? What are the values for reg, arrayUsageMap[WINED3DSHADERDECLUSAGE_DIFFUSE] and arrayUsageMap[WINED3DSHADERDECLUSAGE_SPECULAR]? It looks like texture coordinates are wrong, but those shouldn't be affected by this patch, do you initialise arrayUsageMap correctly?

March 9, 2006

Re: WINED3D: Color fixups for vertex shaders

by Roderick Colenbrander

> Direct3D stores vertex color data in BGRA order, OpenGL stores it in > RGBA order. This causes red and blue to be swapped in d3d applications > when run under wine. This patch fixes this problem for vertex shaders > by enabling the flag that causes red and blue to be swapped in > vshader_program_add_input_param_swizzle, when appropriate. > > Changelog: > - Enable color fixups for vertex shaders > In my local tree I have some simple d3d8 shaders working. (See for instance http://roderick.student.utwente.nl/dolphin1.png and dolphin2.png on windows; there's some color issue but apart from that it works). This patch causes in combination with the other vshader patch you sent some drawing issues. Check http://roderick.student.utwente.nl/dolphin3.png Regards, Roderick -- "Feel free" mit GMX FreeMail! Monat f�r Monat 10 FreeSMS inklusive! http://www.gmx.net

March 9, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Andreas Jaeger

Jan Zerebecki <jan.wine(a)zerebecki.de> writes: > Hi. > > For Andreas Jaeger: I CCed you, because you said on > http://en.opensuse.org/Wishlist_Packages_that_are_already_there > that Winetools got included for the next SUSE release. I hope you > are the correct person to talk to or at least can forward this to > someone who is. The following might be usefull information for > you: Winetools is not part of our default installation and will not be provided with the CD set, it's just an extra optional package that people that know about it can easily use, Andreas -- Andreas Jaeger, aj(a)suse.de, http://www.suse.de/~aj/ SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126

March 9, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Joachim von Thadden

Am Thu, Mar 09, 2006 at 01:41:06PM +0100 schrieb Jan Zerebecki: > I think a quote from http://www.winehq.org/site/download somewhat > sums up the cencus on this list regarding Winetools: "WineTools > [is] only recommended if installation or operability of Windows > software failed on pure Wine. Since WineTools radically alters > your Wine configuration please do not report bugs in programs > with WineTools installed. Instead contact the author of WineTools > Joachim von Thadden." As there are arguments floating around about WineTools that are definitely not correct I think I have to make some things here clear. > Some other facts: > > Winetools is only sporadically updated for new versions of Wine > (as http://www.von-thadden.de/Joachim/WineTools/ indicates; this > site also contains some warnings regarding the support status). WineTools is not "sporadically" updated as it makes no sense to update it with every new Wine release. The purpose is not to keep track Wine, the purpose is to have a stable basis. As such WineTools often stays with a specific Wine version for a time. This is the same what Crossover-Office does. So you would also not include that if you were allowed to? > Winetools radically alters some vital Wine settings and thus > makes many other apps fail. This first part is true, the second definitely not. WineTools is at the moment the only way to have all major commercial windows programs run simultaneously with Wine under Linux if you do not want to pay for Crossover-Office. If what you say is true then name the apps that fail with WineTools and run with *plain* Wine. I am waiting for your list. And I will include them in the next release (if I can download them legaly). > This leads to many users asking for help in #winehq on freenode. > But nobody there wants to support winetools and thus can only > suggest them to remove their .wine and redo it without winetools > (which usually makes it work). Yes, this is true. As we are a freetime project we have not the time to sit on an IRC channel. But there is always a) this mailinglist where we sit and listen b) the possibility to mail us directly Again: I am nosy to know which apps work after removing a WineTools .wine. > Currently no Winetools developer works closely with the Wine > developers to correct problems of interaction between Winetools > and Wine. What does that mean? We are making a tool to make Windows programs run with Wine. We do not develop Wine and our main goal is not to achieve as much debugging informations as possible. The goal is to make the usage of Wine as easy as possible for users coming from Windows and who are customized to point and click interfaces. Again: The goal is not to develop Wine. The goal is to use it easy. Regards Joachim von Thadden -- "Never touch a running system! Never run a touching system? Never run a touchy system!!!"

March 9, 2006

Re: WINED3D: Implement GetCreationParameters

by Peter Beutner

Alexandre Julliard schrieb: > Your mistake is to assume that the app will handle the error in a sane > way. That's extremely unlikely, especially for things like bad > pointers since the app obviously didn't expect to be passing bad > pointers. If the app really wants to handle that sort of error it can > always add an exception handler around the call; so not trapping the > error in the library doesn't prevent the app from catching the error, > it just avoids forcing a lot of useless checks on well-written apps. > > And it's not clear at all that crashing is more likely to lose data > than not crashing. With the Windows way, the app will merrily continue > working with corrupt data, which gives it a lot more opportunities to > add garbage to your data without noticing, than if it crashed right > away before having done too much damage. > I surrender, you convinced me ;). Sorry for the noise.

March 9, 2006

WINE's way to find out about MS headers?

by Christoph Frick

hiho after reading the SetProperty documentation on MSDN about the direct input interface, i found out about four "defines" that are not yet included in the dinput.h of WINE. #define DIPROP_APPDATA MAKEDIPROP(?) #define DIPROP_CPOINTS MAKEDIPROP(?) #define DIPROP_INSTANCENAME MAKEDIPROP(?) #define DIPROP_PRODUCTNAME MAKEDIPROP(?) i guess the ids they represend are not documented anywhere but the dinput.h from Microsoft. what is the "best practise" for cases like this, to add them to wine's headers? -- cu

March 9, 2006

May be a bad idea to have Winetools in the next SUSE release

by Jan Zerebecki

Hi. For Andreas Jaeger: I CCed you, because you said on http://en.opensuse.org/Wishlist_Packages_that_are_already_there that Winetools got included for the next SUSE release. I hope you are the correct person to talk to or at least can forward this to someone who is. The following might be usefull information for you: I think a quote from http://www.winehq.org/site/download somewhat sums up the cencus on this list regarding Winetools: "WineTools [is] only recommended if installation or operability of Windows software failed on pure Wine. Since WineTools radically alters your Wine configuration please do not report bugs in programs with WineTools installed. Instead contact the author of WineTools Joachim von Thadden." Some other facts: Winetools is only sporadically updated for new versions of Wine (as http://www.von-thadden.de/Joachim/WineTools/ indicates; this site also contains some warnings regarding the support status). Winetools radically alters some vital Wine settings and thus makes many other apps fail. This leads to many users asking for help in #winehq on freenode. But nobody there wants to support winetools and thus can only suggest them to remove their .wine and redo it without winetools (which usually makes it work). Currently no Winetools developer works closely with the Wine developers to correct problems of interaction between Winetools and Wine. IMHO it would be best to either not include Winetools in a distribution or find a more active developer for it who is willing to support Winetools and cooperate with Wine developers. Or at least put up a big warning where it is read by a user that installs Winetools through the distributions package management. Jan

March 9, 2006

RE: WINED3D: Implement GetCreationParameters

by Rolf Kalbermatter

Alexandre Julliard wrote: > Rolf Kalbermatter <rolf.kalbermatter(a)citeng.com> writes: > > > Alexandre Julliard schrieb: > > > >>I fail to see in how far returning an error is hiding a bug. > >>Imho if the library detects an error[*] it should pass the > >>information to the application and let the application handle > >>it. The library doesn't know if the application maybe can cope > >>with it. Just ultimately crash is a bad idea imo. > > Please be careful with how you quote text, I didn't write that, Peter > did. Sorry about that. The first draft contained the entire communication and was syntactially correct but unnecessary long. When trimming it down I messed up the quote line. Will try to not do this again in the future. Rolf Kalbermatter

March 9, 2006

Re: WINED3D: Implement GetCreationParameters

by Alexandre Julliard

Rolf Kalbermatter <rolf.kalbermatter(a)citeng.com> writes: > Alexandre Julliard schrieb: > >>I fail to see in how far returning an error is hiding a bug. >>Imho if the library detects an error[*] it should pass the >>information to the application and let the application handle >>it. The library doesn't know if the application maybe can cope >>with it. Just ultimately crash is a bad idea imo. Please be careful with how you quote text, I didn't write that, Peter did. -- Alexandre Julliard julliard(a)winehq.org

March 9, 2006

GTA/FEAR vs mscoree/.NET

by Ivan Gyurdiev

Marcus Meissner wrote: > On Sun, Oct 16, 2005 at 04:22:10PM -0400, Ivan Gyurdiev wrote: > >> Grand Theft Auto... the never ending struggle to get it working. >> >> First I thought it was broken because of OLE...subsequently found out >> the installer was freezing, because of hidden message boxes. Now I've >> managed to install it in Desktop mode, but it dies when ran, with no >> output of any kind... >> >> Investigating shows: >> >> 000b:Call kernel32.SetUnhandledExceptionFilter(2027f1a8) ret=0115fbe9 >> 000b:Ret kernel32.SetUnhandledExceptionFilter() retval=0115fb7c >> ret=0115fbe9 >> 000b:Call kernel32.GetModuleHandleA(015459f4 "mscoree.dll") ret=0115ae6b >> 000b:Call ntdll.RtlInitAnsiString(7fcaf528,015459f4 "mscoree.dll") >> ret=2018d4fc >> 000b:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=2018d4fc >> 000b:Call ntdll.RtlAnsiStringToUnicodeString(7fffcbf8,7fcaf528,00000000) >> ret=2018d55b >> 000b:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=2018d55b >> 000b:Call ntdll.RtlInitUnicodeString(7fcaf52c,7fffcc00 L"mscoree.dll") >> ret=201a554d >> 000b:Ret ntdll.RtlInitUnicodeString() retval=00000018 ret=201a554d >> 000b:Call ntdll.LdrGetDllHandle(00000000,00000000,7fcaf52c,7fcaf534) >> ret=201a555b >> 000b:Ret ntdll.LdrGetDllHandle() retval=c0000135 ret=201a555b >> 000b:Call ntdll.RtlNtStatusToDosError(c0000135) ret=201a558a >> 000b:Ret ntdll.RtlNtStatusToDosError() retval=0000007e ret=201a558a >> 000b:Ret kernel32.GetModuleHandleA() retval=00000000 ret=0115ae6b >> 000b:Call kernel32.ExitProcess(00000001) ret=0115ae8f >> 000b:Call ntdll.LdrShutdownProcess() ret=201b03bd >> >> Looks like it doesn't like the missing mscoree.dll. >> I thought the .NET framework was not a core windows dll? >> Why would it require it? Also, installing a native dll doesn't seem to >> help... >> > > You are trying to execute a .NET binary. > > Same happens for me when I run "wine f-spot.exe" ;) > > Ciao, Marcus > So, what does that mean for the end user - is there hope that in the future I'll be able to run GTA or, F.E.A.R (which has the exact same problem) under Wine? Will the wine project integrate with mono? Note: if I install a native mscoree, the applications are still not able to find it.

March 9, 2006

Re: WINED3D: Implement GetCreationParameters

by Rolf Kalbermatter

Alexandre Julliard schrieb: >I fail to see in how far returning an error is hiding a bug. >Imho if the library detects an error[*] it should pass the >information to the application and let the application handle >it. The library doesn't know if the application maybe can cope >with it. Just ultimately crash is a bad idea imo. Many applications ignore returned error codes (especially if you have to call GetLastError()) if the programmer was under the assumption that there will be never a possibility to cause an error. While this assumption may be true on Windows (or at least a certain Windows version the programmer has tested on) it is certainly not necessarily true in Wine. There could have been a Wine call just before, that was wrongly implemented, returning an invalid pointer or such. Just returning an error may hide that error for many lines, to crash in some much more unrelated area eventually. Tracking such dependant error causes is already hard enough and hiding an invalid pointer access or other invalid parameter by checking for its validness makes it even harder if an application doesn't ridicully check every possible error condition and believe me I haven't seen many programs that really do that. Crashing may be not what most end users very much like but it is in my opinion just as fine than displaying a dialog box that an unrecoverable error has occurred and that it must shut down and much better than relying on the application to actually do proper error checking, but it makes the life of every Wine programmer just a little bit easier and Wine still being far from a release state can use any help on the programmer side. Wine's policy is to do parameter checking only if Windows is doing it in all versions too and sometimes even then only when there is at least one application that depends on it to work properly. Lets look at the example at hand. There is a function that does not check the pointer in Windows. If an application crashes in that function because of that, this means basically that the application did not do proper pointer checking already and then it is very questionable that it would check the error indication of that function at all, since it wouldn't get such an error indication on Windows anyhow. Also this application will either crash on Windows too, and then it is the programmers problem to make this application behave better or it does not crash on Windows because some previous function does behave differently than the Wine equivalent and then every wine programmer would like to know as soon as possible that this error occurres, not 5000 lines further down the program. If you would talk about a stable and final Wine release (which with Wine chasing the Windows API propably never will be) this might be a little different but we talk about a software project heavily under development. Rolf Kalbermatter

March 9, 2006

Re: BF2 demo

by Ivan Gyurdiev

> Nope. I do have to use OSS instead of ALSA, Doesn't help. > or it will hang right at > the point where the "Join Game" button should get shown, but it never > gives me the "nested exception on signal stack" error. It might be > usefull to add a few traces to the debug log, eg +d3d9,+d3d,+seh and > maybe others depending on what that shows you. > I've attached the trace - I see some texture-related errors before the exception is thrown. http://bugs.winehq.org/show_bug.cgi?id=4745

March 9, 2006

Re: BF2 demo

by H. Verbeet

On 08/03/06, Ivan Gyurdiev <ivg2(a)cornell.edu> wrote: > You were able to get the BF2 demo to show something? Yes. > Is this with native d3dx9_25.dll ? Yes. > Did you run into this bug at all? > http://bugs.winehq.org/show_bug.cgi?id=4745 Nope. I do have to use OSS instead of ALSA, or it will hang right at the point where the "Join Game" button should get shown, but it never gives me the "nested exception on signal stack" error. It might be usefull to add a few traces to the debug log, eg +d3d9,+d3d,+seh and maybe others depending on what that shows you.

March 9, 2006

Re: Wine and OS X

by Jim White

Segin wrote: > Jim White wrote: > >> Segin wrote: >> >>> Obchod id wrote: >>> >>>> There could be at least mention in FAQ about possible OS x version or >>>> whether there is no plan. >>>... >>> OSx86 Wiki entry: >>> http://wiki.osx86project.org/wiki/index.php/Darwine >>> >>> Darwine project page: >>> http://darwine.opendarwin.org/ >> >> ... > If you check that wiki page, there is a .dmg for a i386 build. Cool. Hopefully Wine will soon have a volunteer to be the maintainer, and the Downloads and FAQ pages will be updated. Even without a maintainer, those pages could be updated with this information. For those who may not be clear, Darwine is not a fork of Wine, but a Wine developer forum focused on OS X (and Darwin) specific issues. And yes, while I'm harping on FAQ updating, I'm aware that needs to be done on Darwine's site too. Jim White

March 8, 2006

Re: Wine and OS X

by Segin

Jim White wrote: > Segin wrote: > >> Obchod id wrote: >> >>> Hi, >>> >>> There could be at least mention in FAQ about possible OS x version or >>> whether there is no plan. >>> >>> Best wishes >>> >>> Frantisek >>> >> It already exists, but only for Intel Macs (The name 'Wine' is a >> recursive emulator for Wine Is Not a Emulator, from the fact it >> doesn't emulate a CPU. Therefore you cannot run x86 Windows programs >> on a PowerPC Macintosh.) >> >> OSx86 Wiki entry: >> http://wiki.osx86project.org/wiki/index.php/Darwine >> >> Darwine project page: >> http://darwine.opendarwin.org/ > > > What Obchod said is that the information about Wine on OS X is not > readily apparent in the FAQ. While being obscure during the days of > PowerPC-only OS X, the question now of "What about Wine on OS X?" has > become quite frequent in the Intel-era and will become more so. > > While a download of Wine for Intel OS X is probably still a month or > two away, updating the FAQ and making a link to it from the Downloads > page would be the user-friendly thing to do (particularly since there > is bound to be a flood of inquiries when CodeWeavers makes their > CrossOver Office release). > > Jim White > > > > If you check that wiki page, there is a .dmg for a i386 build.

March 8, 2006

Re: Wine and OS X

by Jim White

Segin wrote: > Obchod id wrote: > >> Hi, >> >> There could be at least mention in FAQ about possible OS x version or >> whether there is no plan. >> >> Best wishes >> >> Frantisek >> > It already exists, but only for Intel Macs (The name 'Wine' is a > recursive emulator for Wine Is Not a Emulator, from the fact it doesn't > emulate a CPU. Therefore you cannot run x86 Windows programs on a > PowerPC Macintosh.) > > OSx86 Wiki entry: > http://wiki.osx86project.org/wiki/index.php/Darwine > > Darwine project page: > http://darwine.opendarwin.org/ What Obchod said is that the information about Wine on OS X is not readily apparent in the FAQ. While being obscure during the days of PowerPC-only OS X, the question now of "What about Wine on OS X?" has become quite frequent in the Intel-era and will become more so. While a download of Wine for Intel OS X is probably still a month or two away, updating the FAQ and making a link to it from the Downloads page would be the user-friendly thing to do (particularly since there is bound to be a flood of inquiries when CodeWeavers makes their CrossOver Office release). Jim White

March 8, 2006

Re: Wine and OS X

by Segin

Obchod id wrote: >Hi, > >There could be at least mention in FAQ about possible OS x version or >whether there is no plan. > >Best wishes > >Frantisek > > > It already exists, but only for Intel Macs (The name 'Wine' is a recursive emulator for Wine Is Not a Emulator, from the fact it doesn't emulate a CPU. Therefore you cannot run x86 Windows programs on a PowerPC Macintosh.) OSx86 Wiki entry: http://wiki.osx86project.org/wiki/index.php/Darwine Darwine project page: http://darwine.opendarwin.org/

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Francois Gouget

On Wed, 8 Mar 2006, Peter Beutner wrote: > Francois Gouget schrieb: >> * or the application does not pass a NULL here because it would cause >> it to crash on Windows. But if we merely return an error the application >> will merrily go on, only to crash or report that DirectX does not work a >> while later. By then the source of the problem will be very hard to find >> due to all that happened since this function call. >> The point is that we need to fix the bug that causes the application >> to pass a NULL to Wine in the first place. And the best way to spot it, >> and thus fix it, is if Wine segfaults in the same way as Windows when >> given a NULL. > The whole point of my email was that a crash here doesn't help you > to find the real problem. And you are wrong there. When an application crashes you have a very clear point where you know things went very wrong. This point is very clearly identified by the SEH traces and the winedbg backtrace. This information makes it *much* easier to find the original bug. And this is from experience. When an application doesn't crash but doesn't do what you want either, it's hard to even know which part of the log is relevant to the problem. > Imo a library is supposed to validate given parameters as much as > possible and rather return an error to the caller than to crash. No. A library can say that a given function must not be caled with a NULL parameter in which case it is perfectly valid to crash if that rule is violated. There's no point for both the callee and the caller to check for NULL parameters. > Let's just hope the kernel devs don't adopt your > "Better-crash-than-return-an-error" strategy :p The design of kernels, servers, and other pieces of code that have to deal with untrusted data (e.g. browsers), is completely different from that of general purpose libraries. Trying to apply the rules of one to the other will only give bad results. And, as was pointed out before, Wine is in yet a different situation since its number one requirement is compatibility with the Win32 API rather than breaking clean with it and 'doing things the right way' (whatever that is). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: the choice of a GNU generation

March 8, 2006

BF2 demo

by Ivan Gyurdiev

H. Verbeet wrote: > Currently pixel shaders get created, but not used. This patch enables > OpenGL fragment programs if pixel shaders are enabled and the harware > supports it. Makes fonts readable in the menu for the BF2 demo. This > patch should be applied after the one that removes the FIXME in > drawPrimitiveDrawStrided. > You were able to get the BF2 demo to show something? Is this with native d3dx9_25.dll ? Did you run into this bug at all? http://bugs.winehq.org/show_bug.cgi?id=4745

March 8, 2006

Re: fixme:commdlg:GetFileName95 Flags 0x00900000 not yet implemented

by Rainer Dorsch

Am Montag, 6. März 2006 09:34 schrieben Sie: > On Sunday 05 March 2006 21:50, you wrote: > > I went to 'Arbeitsplatz' in the Shell and then 'C'. MyDocuments was shown > > as a file, not a folder. I.e. the problem persists. > > I don't quite understand, since MyDocuments is on the Desktop, not on > 'Arbeitsplatz'. Could you please browse to 'Arbeitsplatz\C:\windows'? The hierarchy I see is Desktop->Arbeitsplatz->C:->windows > Just to be sure: In notepad the filedialog works fine, right? Yes, that works fine. Thanks, Rainer -- Rainer Dorsch Alzentalstr. 28 D-71083 Herrenberg 07032-919495 Icq: 32550367

March 8, 2006

Re: AlphaImageLoader - tranparent pngs 4 IE

by Adam Cooper

On Wed, 2006-03-08 at 11:02 -0500, Jason Green wrote: > On 3/8/06, Axel Huizinga <axel(a)3dragons.com> wrote: > > Did anybody get DXImageTransform.AlphaImageLoader working > > to render transparent png in IE on wine? > > If I recall correctly, transparent .PNG's don't even work in IE on > Windows (at least until the upcoming IE7.0). > With a bit of javascript wizardry and the aforementioned DXImageTransform you can get transparent pngs on IE. At least on a windows install of IE. I don't know if it works on wine. Regards Adam

March 8, 2006

Re: Trying to fix bug 2400 - delete and comma

by agaro

I know now what scancode, keycode and vkey are! :) Some references: * ScanCode and KeyCode http://lct.sourceforge.net/lct/x60.html http://www.tldp.org/HOWTO/Keyboard-and-Console-HOWTO-2.html http://www.win.tue.nl/~aeb/linux/kbd/scancodes-1.html * Virtual-Key Codes (vkey) http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winu… I thought the problem was in TranslateMessage (dlls/user/message.c) and X11DRV_ToUnicodeEx (dlls/x11drv/keyboard.c) functions but I found others suspects: EVENT_event_to_vkey and X11DRV_InitKeyBoard (boths in dlls/x11drv/keyboard.c). What is happening? (in brazilian abnt2 keyboard with wine-0.9.9) The EVENT_event_to_vkey function return the wrong value 0x2E to X11DRV_KeyEvent which emits an event through X11DRV_send_keyboard_input. On MSDN and dlls/user/spy.c VK_SEPARATOR virtual key code apears as 0x6C, however in trace below apears as 0x2E while in both cases keycodes are equals. The 0x2E virtual key code value corresponds to VK_DELETE. My guess for now: X11DRV_InitKeyboard function initialize keyc2vkey array with wrong value for this case. Trace ($ WINEDEBUG=+key wine winecfg) of NumPad Delete key with NumLock key activated: trace:key:X11DRV_KeyEvent type 2, window a0000a, state 0x0010, keycode 0x005b trace:key:X11DRV_KeyEvent state = 10 nbyte = 1, status 0x4 trace:key:X11DRV_KeyEvent KeyPress : keysym=FFAC (KP_Separator), # of chars=1 / 0x2c / ',' trace:key:EVENT_event_to_vkey e->keycode = 5b trace:key:X11DRV_KeyEvent keycode 0x5b converted to vkey 0x2e trace:key:X11DRV_KeyEvent bScan = 0x53. trace:key:X11DRV_send_keyboard_input wParam=002e, lParam=00530001, InputKeyState=c1 trace:key:TranslateMessage Translating key VK_DELETE (002e), scancode 53 trace:key:GetKeyboardState (0x7faff024) trace:key:X11DRV_ToUnicodeEx (002E, 0053) : faked state = 0x0010 trace:key:EVENT_event_to_vkey e->keycode = 5b trace:key:X11DRV_ToUnicodeEx type 2, window a0000a, state 0x0010, keycode 0x005b trace:key:X11DRV_ToUnicodeEx Translating char 0x2c to unicode trace:key:X11DRV_ToUnicodeEx ToUnicode about to return 1 with char 2c trace:key:TranslateMessage 1 -> PostMessageW(0x10050,WM_CHAR,002c,00530001) trace:key:GetKeyState key (0x12) -> 0 trace:key:GetKeyState key (0x10) -> 0 trace:key:GetKeyState key (0x11) -> 0 trace:key:GetKeyState key (0x11) -> 0 trace:key:X11DRV_KeyEvent type 3, window a0000a, state 0x0010, keycode 0x005b trace:key:X11DRV_KeyEvent state = 10 nbyte = 0, status 0x1 trace:key:X11DRV_KeyEvent KeyRelease : keysym=0 (No Name), # of chars=0 / 0x00 / '' trace:key:EVENT_event_to_vkey e->keycode = 5b trace:key:X11DRV_KeyEvent keycode 0x5b converted to vkey 0x2e trace:key:X11DRV_KeyEvent bScan = 0x53. trace:key:X11DRV_send_keyboard_input wParam=002e, lParam=c0530001, InputKeyState=41 []s agaro

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Alexandre Julliard

Peter Beutner <p.beutner(a)gmx.net> writes: > Just take the example you have written something in Office and the given behaviour(passing a > NULL pointer) happens when you click on the print button. If it crashes your work is lost, if > it returns an error( and the app handles it in a sane way ) you just won't be able to print > it, but may save it and print it somehow else. > In that case my main concern is certainly not that a crash helps me to find a bug, but > to don't loose my data ;) Your mistake is to assume that the app will handle the error in a sane way. That's extremely unlikely, especially for things like bad pointers since the app obviously didn't expect to be passing bad pointers. If the app really wants to handle that sort of error it can always add an exception handler around the call; so not trapping the error in the library doesn't prevent the app from catching the error, it just avoids forcing a lot of useless checks on well-written apps. And it's not clear at all that crashing is more likely to lose data than not crashing. With the Windows way, the app will merrily continue working with corrupt data, which gives it a lot more opportunities to add garbage to your data without noticing, than if it crashed right away before having done too much damage. -- Alexandre Julliard julliard(a)winehq.org

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Peter Beutner

Hi Andreas Mohr schrieb: > Hi, > Can you mention an example of Windows popping up an error message "function > foo baz called with invalid parameter ..., what do you want me to do?". > See? Me neither... heh, the message will more likely looks like "Failed to initialize {Direct3D/DirectDraw/OpenGL/Foo}" Which still leaves you puzzled what the hell actually went wrong, but at least shows that sometimes the return values are actually checked for errors ;) > Any additional error checking in Wine that's *not done by Windows* to make > (semi-)abnormal code flow keep running is A Very Bad Thing (tm). So if a windows function crashes with a given set of parameters the aim is to exactly replicate that behaviour? hmm seems I have to re-think my argument I usually tell people that bugs in windows are not neccessarily also present in wine. Let's hope there is never a exploitable bug that needs to be implemented in wine :p >>> If there's a problem that we need to be aware of, then we'd better get to know >>> about it NOW, not 5 lines, not 3000 relay lines and not 10 minutes after it >>> occurred and nobody ever remembers what the actual problem was. >> To repeat it, if that crash happens you are *already* "3000 relay lines" after the actually >> problem and you have *no* clue what the actual problem is. > That may well be the case, but I sure as hell don't want to even increase > my trouble by orders of magnitude by waiting a lot longer in this error case... So let's remove the dozens of NULL pointer checks already in place ;) And better also the whole exception handling which gives applications the chance to carry on execution even in case of a segmentation fault, which highly increases the trouble to find the original source of the problem *scnr*.

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Peter Beutner

Alexandre Julliard schrieb: > Peter Beutner <p.beutner(a)gmx.net> writes: > >> Or look at it from the view of a user developing a winelib application. I'm sure >> he will very much appreciate it when wine does a better parameter checking than MS >> and returns an error instead of a crash backtrace ;) >> Imo a library is supposed to validate given parameters as much as possible and >> rather return an error to the caller than to crash. > > It's just the opposite actually. A good library (which the MS ones > certainly aren't...) should crash on bad pointers, so that bugs can be > found and fixed. Hiding bugs and trying to stumble along is the MS > way, this is what leads to idiocy like having an exception handler in > lstrlen(). So if in this case Windows doesn't have a check we > certainly don't want one either. I fail to see in how far returning an error is hiding a bug. Imho if the library detects an error[*] it should pass the information to the application and let the application handle it. The library doesn't know if the application maybe can cope with it. Just ultimately crash is a bad idea imo. Just take the example you have written something in Office and the given behaviour(passing a NULL pointer) happens when you click on the print button. If it crashes your work is lost, if it returns an error( and the app handles it in a sane way ) you just won't be able to print it, but may save it and print it somehow else. In that case my main concern is certainly not that a crash helps me to find a bug, but to don't loose my data ;) [*] Obviously you can't check against every possible failure. And it certainly may be a bit too much to check against bad pointers in general, but a NULL pointer check is cheap, easy and certainly doable.

March 8, 2006

Re: AlphaImageLoader - tranparent pngs 4 IE

by Jason Green

On 3/8/06, Axel Huizinga <axel(a)3dragons.com> wrote: > Did anybody get DXImageTransform.AlphaImageLoader working > to render transparent png in IE on wine? If I recall correctly, transparent .PNG's don't even work in IE on Windows (at least until the upcoming IE7.0).

March 8, 2006

AlphaImageLoader - tranparent pngs 4 IE

by Axel Huizinga

Hi! Did anybody get DXImageTransform.AlphaImageLoader working to render transparent png in IE on wine? Cordially, Axel

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Andreas Mohr

Hi, On Wed, Mar 08, 2006 at 03:49:55PM +0100, Peter Beutner wrote: > Hi > Andreas Mohr schrieb: > > We're not a library.We're a very, very, very, very specific piece of software > Well, I remember I was told that wine is just another gui toolkit like gtk+ or qt *scnr*. Good memory ;) However I didn't state that, and I wouldn't want to ;) > > that is required to absolutely, positively fully emulate Windows to the > > closest extent possible (within practical limits, of course). > > As such debating whether to delay a crash by adding useless checks > > *that do not exist in Windows*(!) to *work around* strange behaviour most > > likely caused by our own non-conformant code is utterly pointless. > And I thought the whole idea behind error-checking was not just to delay the crash > but to entirely prevent it and instead inform the user what and where something failed. > I would prefer it if the application pops up a message "xyz failed" rather than a crash. > (admittingly, in how far the application does this in a proper way is entirely out of > our hands ;) ) Can you mention an example of Windows popping up an error message "function foo baz called with invalid parameter ..., what do you want me to do?". See? Me neither... And how do you want to """prevent""" anything?? Forget it... > Let's just hope the kernel devs don't adopt your "Better-crash-than-return-an-error" strategy :p The kernel developers code according to their very own rules, they're the ones to design stuff properly and thus fully know error conditions and corner cases of the code they're designing from scratch. We *absolutely* don't - especially when considering MSDN "correctness" <expletive deleted>. Any additional error checking in Wine that's *not done by Windows* to make (semi-)abnormal code flow keep running is A Very Bad Thing (tm). > > If there's a problem that we need to be aware of, then we'd better get to know > > about it NOW, not 5 lines, not 3000 relay lines and not 10 minutes after it > > occurred and nobody ever remembers what the actual problem was. > To repeat it, if that crash happens you are *already* "3000 relay lines" after the actually > problem and you have *no* clue what the actual problem is. That may well be the case, but I sure as hell don't want to even increase my trouble by orders of magnitude by waiting a lot longer in this error case... Andreas Mohr

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Peter Beutner

Hi Andreas Mohr schrieb: > On Wed, Mar 08, 2006 at 02:08:52PM +0100, Peter Beutner wrote: >> Imo a library is supposed to validate given parameters as much as possible and >> rather return an error to the caller than to crash. > We're not a library.We're a very, very, very, very specific piece of software Well, I remember I was told that wine is just another gui toolkit like gtk+ or qt *scnr*. > that is required to absolutely, positively fully emulate Windows to the > closest extent possible (within practical limits, of course). > As such debating whether to delay a crash by adding useless checks > *that do not exist in Windows*(!) to *work around* strange behaviour most > likely caused by our own non-conformant code is utterly pointless. And I thought the whole idea behind error-checking was not just to delay the crash but to entirely prevent it and instead inform the user what and where something failed. I would prefer it if the application pops up a message "xyz failed" rather than a crash. (admittingly, in how far the application does this in a proper way is entirely out of our hands ;) ) Let's just hope the kernel devs don't adopt your "Better-crash-than-return-an-error" strategy :p > If there's a problem that we need to be aware of, then we'd better get to know > about it NOW, not 5 lines, not 3000 relay lines and not 10 minutes after it > occurred and nobody ever remembers what the actual problem was. To repeat it, if that crash happens you are *already* "3000 relay lines" after the actually problem and you have *no* clue what the actual problem is.

March 8, 2006

Fwd: Can't run DirectX games on x86_64 biarch Linux

by Jason Green

On 3/8/06, Willie Sippel <willie(a)zeitgeistmedia.net> wrote: > [...] > I also build Wine on an amd64 system (running gentoo/ amd64), no problems. But > there's one thing I noticed a while ago: Wine continues to compile and > install even if some of the DLLs won't compile. I had this a few times in the > past, and ended up with a basically working Wine install that missed a few > DLLs, mostly OpenGL-related stuff. Maybe something like that happens to you? > Just check that all DLLs are built and in place, and make sure there were no > errors during compile (like I said, with some DLLs, Wine just continues to > build even though errors appear)... Correct, wine will compile and run without a lot of features and never warn you that they don't exist. See this wiki page for an example of what your include/config.h file should probably look like: http://wiki.winehq.org/Recommended_Packages I just added the Fedora Core 5 and Ubuntu Dapper sections yesterday, and I believe that they are at least 95% accurate, although I might have missed one somewhere. If someone can add the package names required for a gentoo build (or possibly create and maintain wine-cvs packages with all of the necessary deps???), it would probably help out many users trying to compile from source.

March 8, 2006

Re: ntdll: Fix Directory Searching when VFAT_IOCTL_READDIR_BOTH returns an invalid d_reclen

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > No, the file it is searching for exists, but doesn't seem to be > returned by the ioctl for some reason. It is likely a x86-64 kernel > bug, but we should still fix in our code IMHO. Yes, but falling through to readdir when we reach the end of the directory is not correct behavior, it will cause every directory to be searched twice. This needs more investigation. -- Alexandre Julliard julliard(a)winehq.org

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Alexandre Julliard

Peter Beutner <p.beutner(a)gmx.net> writes: > Or look at it from the view of a user developing a winelib application. I'm sure > he will very much appreciate it when wine does a better parameter checking than MS > and returns an error instead of a crash backtrace ;) > Imo a library is supposed to validate given parameters as much as possible and > rather return an error to the caller than to crash. It's just the opposite actually. A good library (which the MS ones certainly aren't...) should crash on bad pointers, so that bugs can be found and fixed. Hiding bugs and trying to stumble along is the MS way, this is what leads to idiocy like having an exception handler in lstrlen(). So if in this case Windows doesn't have a check we certainly don't want one either. -- Alexandre Julliard julliard(a)winehq.org

March 8, 2006

Re: System wide registry

by Stefan Dösinger

Hi, > In WINE user guide I read int the System Administration Tips > about global registry files (f.i. /usr/local/etc/wine.systemreg) > But I can't find any code in WINE about it. It is obsoleted now? > Is it possible to use system wide registry now? I created an /etc/wine directory with a system.reg, userdef.reg and dosdevices file, owned by a user "wine". In the other users .wine directory, there's a individual user.reg file, and a symlink to the files in /etc/wine/. The virtual c drive is in /opt/windows, owned by wine:users This way, there's a system-wide system.reg file, and wine is more or less the admistrator. The Linux file permissions prevent others from writing to /opt/windows and system.reg. An user can modify HKLM, but the changes won't get written to disk and get lost after his wine process terminates. Theoretically, you can use the root account instead of a special user, but it's highly discoraged to run wine as root, due to security concernes. You have to be aware that many Windows apps require full access to system directories or their install directories, but that's a problem Wine can't solve, and Windows suffers from that too.

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Andreas Mohr

Hi, On Wed, Mar 08, 2006 at 02:08:52PM +0100, Peter Beutner wrote: > Imo a library is supposed to validate given parameters as much as possible and > rather return an error to the caller than to crash. We're not a library. We're a very, very, very, very specific piece of software that is required to absolutely, positively fully emulate Windows to the closest extent possible (within practical limits, of course). As such debating whether to delay a crash by adding useless checks *that do not exist in Windows*(!) to *work around* strange behaviour most likely caused by our own non-conformant code is utterly pointless. If there's a problem that we need to be aware of, then we'd better get to know about it NOW, not 5 lines, not 3000 relay lines and not 10 minutes after it occurred and nobody ever remembers what the actual problem was. Andreas Mohr

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Kuba Ober

> Or look at it from the view of a user developing a winelib application. I'm > sure he will very much appreciate it when wine does a better parameter > checking than MS and returns an error instead of a crash backtrace ;) Ooooh, don't I smell bait-and-switch here? :) Always good to learn from your adversaries, right? Kuba

March 8, 2006

System wide registry

by Vitaly Lipatov

In WINE user guide I read int the System Administration Tips about global registry files (f.i. /usr/local/etc/wine.systemreg) But I can't find any code in WINE about it. It is obsoleted now? Is it possible to use system wide registry now? -- Lav Vitaly Lipatov Saint-Petersburg, Etersoft www.etersoft.ru GNU! ALT Linux Team! WINE! LaTeX! LyX!

March 8, 2006

Re: ntdll: Fix Directory Searching when VFAT_IOCTL_READDIR_BOTH returns an invalid d_reclen

by Robert Shearman

Alexandre Julliard wrote: >Robert Shearman <rob(a)codeweavers.com> writes: > > > >>--- a/dlls/ntdll/directory.c >>+++ b/dlls/ntdll/directory.c >>@@ -1245,7 +1245,11 @@ static NTSTATUS find_file_in_dir( char * >> unix_name[pos - 1] = '/'; >> for (;;) >> { >>- if (!de[0].d_reclen) break; >>+ if (!de[0].d_reclen) >>+ { >>+ unix_name[pos - 1] = 0; >>+ break; >> >> > >We should probably have a 'goto not_found' here instead. > No, the file it is searching for exists, but doesn't seem to be returned by the ioctl for some reason. It is likely a x86-64 kernel bug, but we should still fix in our code IMHO. -- Rob Shearman

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Peter Beutner

Francois Gouget schrieb: > * or the application does not pass a NULL here because it would cause > it to crash on Windows. But if we merely return an error the application > will merrily go on, only to crash or report that DirectX does not work a > while later. By then the source of the problem will be very hard to find > due to all that happened since this function call. > The point is that we need to fix the bug that causes the application > to pass a NULL to Wine in the first place. And the best way to spot it, > and thus fix it, is if Wine segfaults in the same way as Windows when > given a NULL. The whole point of my email was that a crash here doesn't help you to find the real problem. It only says you that the function was called with a NULL pointer as parameter. Well, grepping through the trace log where a DirectX function returned an error most probably will get you the same result. And with the ERR() message that was in the original patch it would have been even easier to spot. Anyway both cases do _not_ tell you where things went wrong in the first place. You have to work through the whole trace log before that call to check where something wrong could have been returned. It might be even a bug in the application itself (e.g. forgotten check after malloc), who knows ... Or look at it from the view of a user developing a winelib application. I'm sure he will very much appreciate it when wine does a better parameter checking than MS and returns an error instead of a crash backtrace ;) Imo a library is supposed to validate given parameters as much as possible and rather return an error to the caller than to crash. But as the patch already was commited, I think any further discussion is pointless.

March 8, 2006

Re: linking errors in Winelib code (version 0.9.9) on Solaris 10

by Robert Shearman

Arun Kumar Khandelwal wrote: >I am compiling Winelib (version 0.9.9) on Solaris 10 machine. I am >getting below linking errors: > >gcc -c -I. -I. -I../../include -I../../include -I/usr/include/libxml2 >-I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT >-fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ >-Wdeclaration-after-statement -Wpointer-arith -g -O2 -o main.o main.c > >Undefined first referenced > symbol in file >GetStartupInfoA ../../dlls/libwinecrt0.a(exe_main.o) >GetModuleHandleA ../../dlls/libwinecrt0.a(exe_main.o) >GetCommandLineA ../../dlls/libwinecrt0.a(exe_main.o) >WinMain ../../dlls/libwinecrt0.a(exe_main.o) >ld: warning: Symbol referencing errors > > >Please suggest how to get rid of these errors. > I think you should be using winegcc. I'm afraid I don't know much more than that about winelib and the documentation is out of date so I can't refer you there. -- Rob Shearman

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by Willie Sippel

[...] > > Second, some programs run fine with wine, e. g. pcAnywhere. And some > games do start up and show the title menu (like StarCraft or AOE2), but > crash when selecting a game. > > Third, as I said before, I've compiled wine from source on a Pentium II > Debian box which doesn't even know what x86_64 is, and copied the > installation directory /opt/wine-CVS... to my x86_64 box. But that > didn't help. I also used the setarch-utility to make the Wine configure > script see an i686-machine, and setting the -m32 flags for GCC by hand, > but the effect was the same. I also build Wine on an amd64 system (running gentoo/ amd64), no problems. But there's one thing I noticed a while ago: Wine continues to compile and install even if some of the DLLs won't compile. I had this a few times in the past, and ended up with a basically working Wine install that missed a few DLLs, mostly OpenGL-related stuff. Maybe something like that happens to you? Just check that all DLLs are built and in place, and make sure there were no errors during compile (like I said, with some DLLs, Wine just continues to build even though errors appear)... Ciao, Willie -- Willie Sippel //////// | Tritium Studios // | ______________________________ //// /// | http://www.tritium-studios.com <willie(a)froq.net>

March 8, 2006

linking errors in Winelib code (version 0.9.9) on Solaris 10

by Arun Kumar Khandelwal

I am compiling Winelib (version 0.9.9) on Solaris 10 machine. I am getting below linking errors: gcc -c -I. -I. -I../../include -I../../include -I/usr/include/libxml2 -I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wpointer-arith -g -O2 -o main.o main.c Undefined first referenced symbol in file GetStartupInfoA ../../dlls/libwinecrt0.a(exe_main.o) GetModuleHandleA ../../dlls/libwinecrt0.a(exe_main.o) GetCommandLineA ../../dlls/libwinecrt0.a(exe_main.o) WinMain ../../dlls/libwinecrt0.a(exe_main.o) ld: warning: Symbol referencing errors Please suggest how to get rid of these errors. Thanks and Regards, Arun Khandelwal

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by H. Verbeet

On 08/03/06, Christoph Frick <frick(a)sc-networks.de> wrote: > the vertex-shader there goes nuts (rainbow cars) and about 2/3 of the > textures looks like only one pixel-row of the texture is scaled over the > whole polygone. > > the game used to work completly before that change - except the shadows > and the overlayed textures for the instruments. I think Roderick mentioned that shaders are currently broken in d3d8 and that he was working on fixing them. @Christian: For what it's worth, I'm on AMD64 as well and it seems to work just fine. As Stefan said, you should probably verify that it link against the correct libraries (although I'm not sure if trying to link against 64-bit libs would even compile).

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by Christian Schneider

Am Mittwoch, den 08.03.2006, 10:20 +0100 schrieb Stefan Dösinger: > Hi, > > > > About half a year ago I replaced my old desktop by an AMD64 box and my > > > > previous x86 Linux from Scratch (LFS) installation by a x86_64 multilib > > > > LFS. And since then I'm not able to run any DirectX title anymore that > > > > used to work before. > > I tried, but it didn't help. I've also tried different audio outputs > > (ALSA and OSS), but the error messages are the same. > > > > Anyways, thanks for your reply. > It looks to me that something went wrong with compilation. Roderic does DX > development on an AMD64 machine without problems. Are you sure that Wine is > compiled for 32 Bit? The question is quite obvious, but yes, I am sure its 32-bit. First, the output of the following command is empty, so there are no 64-bit binaries in the wine directory: $ file /opt/wine/lib/{,wine/}*.so /opt/wine/bin/* | grep "64-bit" Second, some programs run fine with wine, e. g. pcAnywhere. And some games do start up and show the title menu (like StarCraft or AOE2), but crash when selecting a game. Third, as I said before, I've compiled wine from source on a Pentium II Debian box which doesn't even know what x86_64 is, and copied the installation directory /opt/wine-CVS... to my x86_64 box. But that didn't help. I also used the setarch-utility to make the Wine configure script see an i686-machine, and setting the -m32 flags for GCC by hand, but the effect was the same. > Perhaps some problem with the 32 bit libraries? In general 32-bit apps work fine on my machine. I can run Opera, Firefox, VMware 4.5, Quake III Arena, UT2004 and much other binary software without any problems. Are there some libs known to cause trouble with Wine? How can I check this? Cheers, Christian Schneider

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by Christoph Frick

On Wed, Mar 08, 2006 at 11:01:06AM +0100, Christian Schneider wrote: > > > As you can see, the most common errors are err:seh:setup_exception > > > and err:ntdll:RtlpWaitForCriticalSection. I've also done some more > > > tests with other games like Revolt, Anno 1503, Half-Life 2, and > > > the errors all look alike. > > anno 1503 never ever worked for me (there where some discussion > > about apps like this that follow a pattern with ddraw and threads, > > that wine might be able to handle (ever)). > I know that it's not supposed to work, but don't you think it's > strange that I only get two types of error messages with any game, > regardless if it's known to work or not? like Stefan i would also consider this more like a problem with the installation? i also run all the games on a opteron box with 64bit gentoo and manual compiled wine. i had no problems as i switched last year from the 32bit platform other then the problems i had beforehand. although anno1503 is the only game you mentioned, that is also on my list - beside that i know the following games work: black mirror, nibiru (demo) il2 (stormovik, foreign battles, aces, pacific fighters), jagged alliance 2, grand prix legends, baldurs gate2, planescape torement - and i have problems running ankh, raven shield, richard burns rally. -- cu

March 8, 2006

ole:ITypeInfo_fnInvoke, failed to convert param 0

by Tomas Carnecky

I got this when the WoW patcher started: err:ole:CoGetClassObject class {4955dd33-b159-11d0-8fcf-00aa006bcc59} not registered err:ole:CoGetClassObject no class object {4955dd33-b159-11d0-8fcf-00aa006bcc59} could be created for for context 0x1 fixme:ole:CoCreateInstance no classfactory created for CLSID {4955dd33-b159-11d0-8fcf-00aa006bcc59}, hres is 0x80040154 err:ole:ITypeInfo_fnInvoke failed to convert param 0 to VT_VARIANT|VT_BYREF from VT_VARIANT|VT_BYREF and the last line doesn't make sense to me, the patcher runs fine though... tom

March 8, 2006

Re: Problem while compiling wine-0.9.9 source on solaris

by Francois Gouget

On Tue, 7 Mar 2006, Vikas Gera wrote: [...] > I tried to build Wine Library on Solaris 10 platform today. It gave > error while compiling dll/dxerr8 module. > The error message says "Don't know how to make target: install-lib" [...] > But similar error message is getting repeated for other modules as well. > I would like to fix it in one shot, probably a fix in the configure > script is needed. Has anybody faced this problem and fixed it? Please > suggest. Are you using GNU make or the standard make? Switching to GNU make may help. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The last time religion ruled, it was called the dark ages.

March 8, 2006

Re: WINED3D: Implement GetCreationParameters

by Francois Gouget

On Tue, 7 Mar 2006, Peter Beutner wrote: [...] > Unless some app relies on this crashing behaviour(which I doubt), I don't think wine > should implement bugs just because MS does it. > Seems a bit obscure strategy to me to crash in case of an error instead of proper > error checking/reporting. This has been discussed many times before (but maybe not in the recent past). There are two cases to consider: * either some applications do pass NULL thus causing a segfault and then expect to catch that exception. As you said, this is pretty unlikely here but it has happened with other (non-DirectX) APIs. In this case, then Wine must segfault too otherwise the application will fail. * or the application does not pass a NULL here because it would cause it to crash on Windows. But if we merely return an error the application will merrily go on, only to crash or report that DirectX does not work a while later. By then the source of the problem will be very hard to find due to all that happened since this function call. The point is that we need to fix the bug that causes the application to pass a NULL to Wine in the first place. And the best way to spot it, and thus fix it, is if Wine segfaults in the same way as Windows when given a NULL. So segfaulting like Windows does is really the right thing to do. It may warrant a comment in the code though, especially if there is a test with a message right before. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by Christian Schneider

Am Mittwoch, den 08.03.2006, 09:46 +0100 schrieb Christoph Frick: > On Wed, Mar 08, 2006 at 12:09:28AM +0100, Christian Schneider wrote: > > > As you can see, the most common errors are err:seh:setup_exception and > > err:ntdll:RtlpWaitForCriticalSection. I've also done some more tests > > with other games like Revolt, Anno 1503, Half-Life 2, and the errors > > all look alike. > > anno 1503 never ever worked for me (there where some discussion about > apps like this that follow a pattern with ddraw and threads, that wine > might be able to handle (ever)). > I know that it's not supposed to work, but don't you think it's strange that I only get two types of error messages with any game, regardless if it's known to work or not? Regards, Christian Schneider

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by Christoph Frick

On Wed, Mar 08, 2006 at 10:18:32AM +0100, Stefan Dösinger wrote: > > anno 1503 never ever worked for me (there where some discussion > > about apps like this that follow a pattern with ddraw and threads, > > that wine might be able to handle (ever)). > Anno 1503 is not multi threaded, I had the demo running, but it was > VERY slow. But there might be other glx context bugs i guess i have tried running this game over a year now - everytime it crashes at the exact same place (choosing a flag and then switching to "3d-mode"). last week i tar:ed it and gave up - now you tell me it works ;) btw: for all the d3d8 -> wined3d gurus out there another demo, that make trouble: http://www.liveforspeed.net/ the vertex-shader there goes nuts (rainbow cars) and about 2/3 of the textures looks like only one pixel-row of the texture is scaled over the whole polygone. the game used to work completly before that change - except the shadows and the overlayed textures for the instruments. -- cu

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by Stefan Dösinger

Hi, > > > About half a year ago I replaced my old desktop by an AMD64 box and my > > > previous x86 Linux from Scratch (LFS) installation by a x86_64 multilib > > > LFS. And since then I'm not able to run any DirectX title anymore that > > > used to work before. > I tried, but it didn't help. I've also tried different audio outputs > (ALSA and OSS), but the error messages are the same. > > Anyways, thanks for your reply. It looks to me that something went wrong with compilation. Roderic does DX development on an AMD64 machine without problems. Are you sure that Wine is compiled for 32 Bit? Perhaps some problem with the 32 bit libraries?

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by Stefan Dösinger

Hi, > anno 1503 never ever worked for me (there where some discussion about > apps like this that follow a pattern with ddraw and threads, that wine > might be able to handle (ever)). Anno 1503 is not multi threaded, I had the demo running, but it was VERY slow. But there might be other glx context bugs

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by Christian Schneider

Am Dienstag, den 07.03.2006, 16:39 -0700 schrieb Jesse Allen: > On 3/7/06, Christian Schneider <mail(a)chrschn.de> wrote: > > Hi all. > > > > About half a year ago I replaced my old desktop by an AMD64 box and my > > previous x86 Linux from Scratch (LFS) installation by a x86_64 multilib > > LFS. And since then I'm not able to run any DirectX title anymore that > > used to work before. > > > > > Try disabling the sound in winecfg. I tried, but it didn't help. I've also tried different audio outputs (ALSA and OSS), but the error messages are the same. Anyways, thanks for your reply. Cheers, Christian Schneider

March 8, 2006

Re: Can't run DirectX games on x86_64 biarch Linux

by Christoph Frick

On Wed, Mar 08, 2006 at 12:09:28AM +0100, Christian Schneider wrote: > As you can see, the most common errors are err:seh:setup_exception and > err:ntdll:RtlpWaitForCriticalSection. I've also done some more tests > with other games like Revolt, Anno 1503, Half-Life 2, and the errors > all look alike. anno 1503 never ever worked for me (there where some discussion about apps like this that follow a pattern with ddraw and threads, that wine might be able to handle (ever)). -- cu

March 8, 2006

Re: GDI32: [4/5] freetype.c add more font selecting&linking mechanism support.

by Byeong-Sik Jeon

Hi. I found another registry key in my korean MS Windows XP. ----------------------------------------------------- [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FontAssoc] [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FontAssoc \Associated Charset] "ANSI(00)"="YES" "OEM(FF)"="YES" "SYMBOL(02)"="NO" [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FontAssoc \Associated DefaultFonts] "AssocSystemFont"="gulim.ttc" "FontPackage"="GulimChe" "FontPackageDontCare"="굴림" "FontPackageRoman"="바탕" "FontPackageSwiss"="굴림" "FontPackageModern"="바탕" "FontPackageScript"="바탕" "FontPackageDecorative"="굴림" --------------------------------------------------------------- I think that create_child_font_list(), WineEngCreateFontInstance() have to this key. and then I can remove "defSystem" in all my patch(4/5 and 5/5). I working. but, create_child_font_list(), WineEngCreateFontInstance() will not create directly this key. I want your advice. Thanks. 2006-03-08 (수), 01:41 +0900, Byeong-Sik Jeon 쓰시길: > 2006-03-07 (화), 14:34 +0000, Huw D M Davies 쓰시길: > > On Tue, Mar 07, 2006 at 09:29:14PM +0900, Byeong-Sik Jeon wrote: > > > ChangeLog: > > > Improved create_child_font_list(), get_nearest_charset(), more using > > > font-linking mechanism. > > > > > > If lfCharSet == DEFAULT_CHARSET, then ALL font(LOGFONT) can see current > > > locale letter, (have to exist least one font corresponding current > > > locale ). > > > > > > > - If lfCharSet == DEFAULT_CHARSET then use the current locale codepage. > > > > and If selected font is not support current ansi codepage, then it fixup > > > > the problem in "create_child_font_list()" function. > > > > > > > > > > > I'm slightly confused about what you're trying to do here. Could you > > try to explain it again please? > > > Sorry, my poor english... > > assume "Arial.ttf" is exist in the system. > ------------------------------------------ > string = "Hello. 안녕하세요. 安寕"; /* include non-western character */ > > logfont.lfCharSet = DEFAULT_CHARSET; > logfont.lfFaceName = "Arial"; > hfont = CreateFontIndirect(&logfont); > SelectObject(hdc, hfont); > > TextOut(hdc, 10, 10, string, strlen(string)); > -------------------------------------------- > at this case, now Wine print out broken shape, because glyph missing on > Arial.ttf. > > font-linking mechanism help this situation. but need to > ------------------------------- > [HKLM\\...\SystemLink] > "Arial"="......" > -------------------------------- > New get_nearest_charset(), create_child_font_list() solve this situation > without any additional config file change. > > > > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/gdi/fontex… > ---------------------------------- > Windows NT/2000/XP: DEFAULT_CHARSET is set to a value based on the > current system locale. For example, when the system locale is English > (United States), it is set as ANSI_CHARSET. > ---------------------------------- > Korean locale => HANGEUL_CHARSET, > Japanese locale => SHIFTJIS_CHARSET. > .... > but, Arial.ttf is missing these charset, therefore incorrect operation > in the get_nearest_charset(). > > Sorry again. Please see the code.... > > > > Moving this TRACE is clearly not correct. > Yes. I mistake...

March 7, 2006

Re: WINED3D: Implement GetCreationParameters

by Vitaliy Margolen

Tuesday, March 7, 2006, 3:22:28 PM, Peter Beutner wrote: > H. Verbeet schrieb: >> On 07/03/06, Ivan Gyurdiev <ivg2(a)cornell.edu> wrote: >>> This doesn't really make sense to me - the point of unspecified behavior >>> if a parameter is NULL would be to speed up the function under contract >>> with the caller. If you're already doing the check, why not handle it in >>> some way other than crashing? >> Because we *want* to crash and get a nice backtrace. > hm maybe I'm missing something but afaik you will get a backtrace right back into the > application code, which will help you exactly nothing (unless you have the source > code of the game and the binary doesn't have its debugging information stripped > which is very likely not the case). > So you have to figure out where you might have returned something wrong by looking at > the traces from _before_ GetCreationParameters. > The backtrace itself won't give you _any_ clues. > Unless some app relies on this crashing behaviour(which I doubt), I don't think wine > should implement bugs just because MS does it. > Seems a bit obscure strategy to me to crash in case of an error instead of proper > error checking/reporting. If anything Wine does crash in much more cases then native. Look at all the ntdll functions. Native never crash there (because all those are direct kernel calls). Wine on the other hand will crash whenever you have a bad pointer dereference. So I don't see any reasons why we should check for NULL pointer here. It will still crash if pointer is bogus, but not NULL. Also having a crash in a debug trace helps to find the place where did it crash. If Wine just returns from this function, you never know where it will cause the real problem. Vitaliy.

March 7, 2006