March 2006 - Wine-Devel - list.winehq.org

Re: winedbg: Fix stepping over

by Eric Pouech

Petr Tesarik wrote: > Hi, > > this patch fixes a bug in winedbg, which caused it to continue > execution at a wrong address when stepping over a function call. > The trouble was that if there was no breakpoint found, the code at the > end of break_should_continue reversed the PC adjustment and later the > debugger resumed program execution AFTER the INT3 instruction, which > is clearly wrong. > Index: break.c > =================================================================== > RCS file: /home/wine/wine/programs/winedbg/break.c,v > retrieving revision 1.17 > diff -u -r1.17 break.c > --- break.c 27 Jan 2006 15:22:15 -0000 1.17 > +++ break.c 21 Mar 2006 10:36:07 -0000 > @@ -731,9 +731,13 @@ > if (code == EXCEPTION_BREAKPOINT) > addr->Offset += be_cpu->adjust_pc_for_break(&dbg_context, TRUE); > > + dbg_curr_thread->stopped_xpoint = find_xpoint(addr, be_xpoint_break); > dbg_curr_process->bp[0].enabled = FALSE; /* disable the step-over breakpoint */ > > - dbg_curr_thread->stopped_xpoint = find_xpoint(addr, be_xpoint_break); this part looks correct > + /* Unconditionally stop on the step-over breakpoint */ > + if (dbg_curr_thread->stopped_xpoint == 0) > + return FALSE; > + but this doesn't... you don't handle the count here... what you should do is only compute dbg_curr_thread->stopped_xpoint (and do the appropriate handling) when its current value is -1 (not found) A+ -- Eric Pouech

March 22, 2006

IDE with Winemaker

by Ng, Billy H CIV NAVSEA

Hi, I am a Windows Developer who is new to the Linux world. Is there any IDE (like Visio Studio) I can use with Winemaker? I am trying to port a Windows App to Linux Fedora. Thanks, Billy.

March 22, 2006

Re: advpack: Forward the remaining advpack.c ansi functions to their unicode counterparts

by Alexandre Julliard

"James Hawkins" <truiken(a)gmail.com> writes: > +HRESULT WINAPI SetPerUserSecValuesA(PERUSERSECTIONA* pPerUser) > +{ > + PERUSERSECTIONW perUserW; > + > + if (!pPerUser) > + return E_INVALIDARG; > + > + TRACE("(%p)\n", pPerUser); > + > + /* lengths copied from PERUSERSECTION structure definition */ > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szGUID, 59, perUserW.szGUID, 59); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szDispName, 128, perUserW.szDispName, 128); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szLocale, 10, perUserW.szLocale, 10); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szStub, MAX_PATH * 4, perUserW.szStub, MAX_PATH * 4); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szVersion, 32, perUserW.szVersion, 32); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szCompID, 128, perUserW.szCompID, 128); The source lengths are wrong, these are null-terminated strings. Also please use sizeof() instead of hardcoding the constants. -- Alexandre Julliard julliard(a)winehq.org

March 22, 2006

Re: Bugzilla: Duplicates

by Tobias Burnus

Hello, > Just found, that gcc has "Most frequently reported Bugs": > http://gcc.gnu.org/bugzilla/duplicates.cgi > > And since we have also bugzilla, i tested http://bugs.winehq.org/duplicates.cgi > The Page is present, but not configured to be useful for wine. > > The code is in the cvs, but I'm unable to help here (perl). > (Browse the cvs: "http://cvs.winehq.org/cvsweb/bugzilla/") > > Hmm, in principle one only needs to tweek at http://bugs.winehq.org/editparams.cgi the 'mostfreqthreshold' option. Running ./checksetup.pl doesn't harm either The essential task is to fill the duplicates table using the script: http://cvs.winehq.org/cvsweb/bugzilla/collectstats.pl You need to run it using cron. Tobias

March 22, 2006

CVS EU Server

by Sven.Paschukat＠t-online.de

Does anyone know what's wrong with the CVS server rhlx01.fht-esslingen.de in Europe? It's out of sync for a few days now. Sven

March 22, 2006

Bugzilla: Duplicates (was: Known issues area on main wiki page)

by Detlef Riekenberg

Tony Lambregts wrote: > Tom Spear wrote: >> On 3/21/06, *Vitaliy Margolen* <wine-devel(a)kievinfo.com >> <mailto:wine-devel(a)kievinfo.com>> wrote: >> >> I sure hope all users will go look at this page first. But some how I >> don't think they will. When we getting _exact_ duplicates with the > Keeping them around for a while even after they are fixed would be a > good idea since not everyone keeps up with the latest version of wine. > > [1] > http://bugs.winehq.org/show_bug.cgi?id=219 (SafeDisk) > http://bugs.winehq.org/show_bug.cgi?id=1631 (dsound: problem with underrun detection) > http://bugs.winehq.org/show_bug.cgi?id=1410 (mouse always recenterd) Just found, that gcc has "Most frequently reported Bugs": http://gcc.gnu.org/bugzilla/duplicates.cgi And since we have also bugzilla, i tested http://bugs.winehq.org/duplicates.cgi The Page is present, but not configured to be useful for wine. The code is in the cvs, but I'm unable to help here (perl). (Browse the cvs: "http://cvs.winehq.org/cvsweb/bugzilla/") -- By by ... Detlef

March 22, 2006

Re: What happened to the Fedora packages?

by Mike Hearn

On Wed, 22 Mar 2006 12:04:52 +0100, Francois Gouget wrote: > If compiling Wine crashes your computer!!! then something is wrong!!! > with your computer!!! You should really find out what!!! and fix it!!! > Otherwise you are likely to get problems running Wine!!! It's a bug in Wine, which I harassed AJ about a long time ago but it was never fixed I guess because he has a super-awesome machine :) Basically, compiling winetest causes gas to blow gigs of memory, because it's compiling like 50mb+ of assembly. I just hacked it out of the build system myself. There's nothing wrong with my machine except it being old ...

March 22, 2006

Re: Store GL context in the TEB

by Mike Hearn

On Tue, 21 Mar 2006 13:03:13 -0500, Wino Rojo wrote: > Where can I find more information about this, or a path to try? I'm > currently getting the BadMatch error and I would like to try this solution Just wait until it's merged then upgrade, it's the easiest way.

March 22, 2006

Re: Easy applications to write automated tests for?

by Dan Kegel

On 3/22/06, Molle Bestefich <molle.bestefich(a)gmail.com> wrote: > Ok. Cygwin does pretty well if you're using it as a single user / do > not use many processes/threads while pushing it CPU-wise. Right -- and I think we can hew to that limitation when using msys as part of a possible wine regression test. > Eg., Cygwin will be able to run a ./configure script just fine, too. Right, but modern cygwin is hard to support on wine, I think. The old snapshot in msys is probably easier. > > > There are a couple of other Windows-->Unix emulation kits readily > > > available, so shouldn't be hard to find something that both runs > > > reliably and can make ./configure scripts work... > > > > Oh, really? Got URLs? > > MKS Toolkit > http://www.mkssoftware.com/ Commercial, not a free download. There's a way to apply for a trial, but it's not easy, and you can't just download it. > Windows Services for Unix > http://www.microsoft.com/technet/interopmigration/unix/sfu/ I just tried it; it bombs on setup, complaining that the TCP/IP service isn't installed. But even if we fix that, downloading it requires a Microsoft Passport account and you have to fill out an intrusive questionaire. Also, there's no way of knowing when Microsoft will suspend free downloads. So I think that's out. Which kind of leaves us with msys/mingw as the prime contender, I think. For starters, all we have to do is verify, say, that it can build and run a hello, world app on wine. I think that even works right now! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 22, 2006

Re: WIDL: Add missing ignore attribute. Check for inapplicable attributes in typedef.

by Saveliy Tretiakov

I think it is still possible to implement meaningful error messages. A good overview of how this can be done is here: http://www.cs.nmsu.edu/~jeffery/merr.html. Anyway, if you disagree, I will resend patch with explicit error check. Alexandre Julliard wrote: > I think checking values explicitly is preferable to encoding them in > the syntax, since it gives you a chance to provide meaningful > errors. If you rely on the parser all you'll get is a generic "syntax > error" with no clue to what you did wrong. > >

March 22, 2006

Re: What happened to the Fedora packages?

by Segin

Neal Gompa wrote: > What happened to the Fedora packages? They have not been updated since > 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro > supported has the up to date packages!!! And why does the Red Hat > packages site not go to the SourceForge site as it does for SUSE > packages and the others?? I have not really had the guts to ask until > now, because I thought that maybe there was a slump, but now, its > getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! > Please tell me new packages will be ready soon!!! Compiling WINE > always crashes my computer, so I prefer to use the RPMs... > >------------------------------------------------------------------------ > > > > Is your computer also a Pentium 166MHz with 32MB of RAM? ... No, wait, even THAT can compile wine. Wine wasn't rated for 16MB systems, sorry. </sarcasam> Or in English: You need more RAM. When you run out of RAM, almost all UNIXes and clones have a kernel panic. Linux does either that, or it starts randomly killing off proccesses (your window manager, X, init, and so on) depending on it config at compile time. Please make sure you have enough swap, you have plenty of RAM (512MB or more), all of your toolkit conponets (gcc, binutils, etc.) are up to date, and that you don't have faulty hardware.

March 22, 2006

Re: Easy applications to write automated tests for?

by Molle Bestefich

Dan Kegel wrote: > Molle Bestefich wrote: > > Dimi Paun wrote: > > > Being able to run an emulation layer like msys/cygwin > > > > In my experience (couple of years worth of different Cygwin versions, > > all relatively new stuff), the Cygwin kernel emulation stuff is > > extremely unstable itself. > > unstable in the sense that it changes all the time, yes. No. Unstable in the sense that the core code is buggy. > msys, on the other hand, is working off a frozen snapshot > of cygwin from long ago, and never changes. > So it's stable in at least that sense. I have no idea > how buggy it is. It works well enough to run configure > scripts on real windows, though. Ok. Cygwin does pretty well if you're using it as a single user / do not use many processes/threads while pushing it CPU-wise. I'll agree that hobby usage (running a couple of Unix apps) is the most common use case for Cygwin, and it works well in that case. Eg., Cygwin will be able to run a ./configure script just fine, too. > > There are a couple of other Windows-->Unix emulation kits readily > > available, so shouldn't be hard to find something that both runs > > reliably and can make ./configure scripts work... > > Oh, really? Got URLs? MKS Toolkit http://www.mkssoftware.com/ Windows Services for Unix http://www.microsoft.com/technet/interopmigration/unix/sfu/ > Have you tried any of them on wine? Unfortunately, no.

March 22, 2006

Re: WIDL: Add missing ignore attribute. Check for inapplicable attributes in typedef.

by Alexandre Julliard

Saveliy Tretiakov <saveliyt(a)mail.ru> writes: > ChangeLog: > Saveliy Tretiakov <saveliyt(a)mail.ru> > - Add missing ignore attribute. > - Check for inapplicable attributes in typedef. Changed attribute > parsing in a way Mike McCormack suggested. > - Register type alias in typelib, if ATTR_PUBLIC is set. I think checking values explicitly is preferable to encoding them in the syntax, since it gives you a chance to provide meaningful errors. If you rely on the parser all you'll get is a generic "syntax error" with no clue to what you did wrong. -- Alexandre Julliard julliard(a)winehq.org

March 22, 2006

Re: What happened to the Fedora packages?

by Francois Gouget

On Tue, 21 Mar 2006, Neal Gompa wrote: > What happened to the Fedora packages? They have not been updated since > 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro > supported has the up to date packages!!! And why does the Red Hat packages > site not go to the SourceForge site as it does for SUSE packages and the > others?? I have not really had the guts to ask until now, because I thought > that maybe there was a slump, but now, its getting annoying!! And Fedora > just released Fedora Core 5 yesterday!!! Please tell me new packages will be > ready soon!!! Compiling WINE always crashes my computer, so I prefer to use > the RPMs... If compiling Wine crashes your computer!!! then something is wrong!!! with your computer!!! You should really find out what!!! and fix it!!! Otherwise you are likely to get problems running Wine!!! Exclamation marks aside this is a good question. Is help needed to generate the RedHat packages? I'm not voluntering myself since I don't use Fedora<g>. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

March 22, 2006

Re: advpack: Forward AddDelBackupEntryA to its unicode counterpart

by Alexandre Julliard

"James Hawkins" <truiken(a)gmail.com> writes: > + do > + { > + MultiByteToWideChar(CP_ACP, 0, ansi_list, len, ptr, len); > + > + ansi_list += len; > + ptr += len; > + > + len = lstrlenA(ansi_list) + 1; > + size += len * sizeof(WCHAR); > + list = HeapReAlloc(GetProcessHeap(), 0, list, size); > + } while (*ansi_list); You are assuming that A and W have the same length, that's wrong. Also it will be quite expensive to resize the list all the time. You should determine the full length of the list and then convert everything in one go. -- Alexandre Julliard julliard(a)winehq.org

March 22, 2006

Re: What happened to the Fedora packages?

by Michel Ludwig

On Wed 22 Mar 2006 03:55, Neal Gompa wrote: > What happened to the Fedora packages? They have not been updated since > 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro > supported has the up to date packages!!! And why does the Red Hat packages > site not go to the SourceForge site as it does for SUSE packages and the > others?? I have not really had the guts to ask until now, because I thought > that maybe there was a slump, but now, its getting annoying!! And Fedora > just released Fedora Core 5 yesterday!!! Please tell me new packages will > be ready soon!!! Compiling WINE always crashes my computer, so I prefer to > use the RPMs... Nice and decent Fedora Wine packages are in Fedora Extras: http://fedoraproject.org/extras/4/i386/repodata/repoview/W.group.html http://fedoraproject.org/extras/5/i386/repodata/repoview/W.group.html And even a "yum install wine" should do it (as root of course :-)).

March 22, 2006

Re: linux mmap bug ? not filling in allocation gaps

by Marcus Meissner

On Wed, Mar 22, 2006 at 12:11:27AM -0800, Geoff Brimhall wrote: > I've been debugging why an n64 emulator ( Project64 ) > gets "Failed to allocate memory" errors under wine > 9.9.10 on linux kernel 2.6. > > The program allocates a large chunk of size > 0x20100000, which succeeds, and then another large > 0x10100000 chunk, which fails. Do you have ulimits set? > I can't be the first person to notice this. Are there > any TODO solutions for this ? No. Ciao, Marcus

March 22, 2006

Re: linux mmap bug ? not filling in allocation gaps

by Mike McCormack

Geoff Brimhall wrote: > Wrote a test mmap binary to fill a process address > space, it created a similar gap between the executable > load address and the loaded shared libraries, > eventually failing mmap calls when it hit the stack > address space. When I updated the test app to > explicitly mmap in the gap area via specifying the > aligned start address, the mmap call succeeded. > > I can't be the first person to notice this. Are there > any TODO solutions for this ? Wine's holey memory map has been discussed before: http://www.winehq.com/pipermail/wine-devel/2006-February/044979.html The "truely correct" solution is probably to implement Windows compatible memory allocation in the Linux kernel, but there's other hacks that could be done in user space. Just a matter of finding something that Alexandre is willing to live with. A preload-ish type thing that overrode libc's mmap/munmap calls seems pausible to me. Mike

March 22, 2006

linux mmap bug ? not filling in allocation gaps

by Geoff Brimhall

I've been debugging why an n64 emulator ( Project64 ) gets "Failed to allocate memory" errors under wine 9.9.10 on linux kernel 2.6. The program allocates a large chunk of size 0x20100000, which succeeds, and then another large 0x10100000 chunk, which fails. WINEDEBUG=+relay,+virtual eventually brought me to look at the linux /proc/<pid>/maps to see if the address space was really fully allocated. Here's what I noticed: Address start - end: 00400000-0554000 - Project64.exe address 00554000-20000000 ---p large mem allocation *** <gap> *** 55555000-573e0000 - loaded shared libraries 573e0000-774e0000 ---p mem alloc of 0x20100000 7bf00000-7c003000 - wine-pthread 7c003000-7c1ee000 - [heap] 7ffe0000-fffe0000 ---p large mem allocation ffff7000-fffff000 - [stack] Wrote a test mmap binary to fill a process address space, it created a similar gap between the executable load address and the loaded shared libraries, eventually failing mmap calls when it hit the stack address space. When I updated the test app to explicitly mmap in the gap area via specifying the aligned start address, the mmap call succeeded. I can't be the first person to notice this. Are there any TODO solutions for this ? One linux-centric solution would be to look for gaps like this in /proc/<pid>/maps in the libs/wine/mmap.c and take advantage of this. Or maybe another would be to keep a table of address spaces returned in wine_anon_mmap as a guide, then validate with try_mmap_fixed as to where a next-allocation should occur ( would this solution work outside linux ) ? Thanks, geoff Brimhall __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

March 22, 2006

Re: Known issues area on main wiki page

by Tom Spear (Dustin Booker, Dustin Navea)

Tony Lambregts wrote: > Tom Spear wrote: >> On 3/21/06, *Vitaliy Margolen* <wine-devel(a)kievinfo.com >> <mailto:wine-devel(a)kievinfo.com>> wrote: >> >> I sure hope all users will go look at this page first. But some >> how I >> don't think they will. When we getting _exact_ duplicates with >> the same >> summary and almost identical comments. I don't think users will >> bother to >> look anywhere else. >> >> But that will add extra work on our side to keep this list in >> synch. On >> top of the usual stuff that we already do. >> >> Vitaliy. >> >> It wouldnt take much extra time outta my day to do it. 5 mins at max >> and only once I notice something is being reported rather >> frequently. I assume that these people who are reporting identical >> duplicates read some of the dodcumentation though, because otherwise >> they probably wouldn't have even known about winecfg. >> >> Tom >> > Keeping them around for a while even after they are fixed would be a > good idea since not everyone keeps up with the latest version of wine. > > Tony Lambregts > I didn't think about that, but you are right. I'll do something like Bug (x) - (Description) - Status: Resolved - Resolved as of wine v(x) Thanks Tom

March 22, 2006

What happened to the Fedora packages?

by Neal Gompa

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

March 22, 2006

Re: x11drv: (bug 4685) some ALT+key combos processed incorrectly

by Vitaliy Margolen

Tuesday, March 21, 2006, 3:49:53 PM, tkho(a)ucla.edu wrote: > Patch to recognize VK_LMENU and VK_RMENU in alt-key combos (bug 4685) > This patch looks for VK_LMENU and VK_RMENU in addition to VK_MENU when dealing > with ALT-key combo messages. This is the easiest way to add this functionality, > but arguably not the cleanest. > 2006-03-21 Thomas Kho <tkho(a)ucla.edu> > * dlls/x11drv/keyboard.c > x11drv: recognize VK_LMENU and VK_RMENU in ALT-key combos I'm sorry but this is further away from native, not closer. I just made some tests, and native sets/clears VM_MENU whenever right or left ALT is pressed/depressed. So we should be doing the same thing. Btw exactly the same thing happens with CONTROL & SHIFT. I will try to send these tests today-tomorrow. But you could try that yourself using SendInput(). Vitaliy Margolen

March 22, 2006

Re: Known issues area on main wiki page

by Tom Spear (Dustin Booker, Dustin Navea)

Segin wrote: > Tony Lambregts wrote: >> Tom Spear wrote: >>> On 3/21/06, **Vitaliy Margolen** <wine-devel(a)kievinfo.com >>> <mailto:wine-devel(a)kievinfo.com>> wrote: >>> >>> [...] >> [...] >> Keeping them around for a while even after they are fixed would be a >> good idea since not everyone keeps up with the latest version of wine. > I have an idea, let's add a update check program to wine, so that when > a person run it, they get to know what the latest version is, and > their current version, plus make a standard executable of it for use > on older versions. That is a good supplement, but we already have the wine-announce mailing list. I guess you are right though, not everyone subscribes to it that uses wine. Tom

March 22, 2006

Re: opengl32: make the old code before the "sync the dibsection to its pixmap" patch be selectable at runtime

by Stefan Dösinger

Am Dienstag, 21. März 2006 23:31 schrieb Lionel Ulmer: > > What says that a gl context can be used by one thread only? In the > > glxDestroyContext man page it sounds like a context has a sort of > > reference count, and it can be used by multiple threads. > > man glXMakeCurrent > > BadAccess is generated if ctx was current to another > thread at the time glXMakeCurrent was called. > > Seems pretty clear to me, but well, my man pages may be outdated :-) Indeed. I must have overloocked it :-| Thanks for the clarification

March 21, 2006

Re: opengl32: make the old code before the "sync the dibsection to its pixmap" patch be selectable at runtime

by Lionel Ulmer

> What says that a gl context can be used by one thread only? In the > glxDestroyContext man page it sounds like a context has a sort of reference > count, and it can be used by multiple threads. man glXMakeCurrent BadAccess is generated if ctx was current to another thread at the time glXMakeCurrent was called. Seems pretty clear to me, but well, my man pages may be outdated :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

March 21, 2006