March 2006 - Wine-Devel - list.winehq.org

Re: May be a bad idea to have Winetools in the next SUSE release

by Tony Lambregts

Jason Green wrote: > On 3/11/06, Tony Lambregts <tony.lambregts(a)gmail.com> wrote: >> In simple terms we get WineTools to query the AppDB with an application name (ie >> somename.exe) and we return a list of applications for the user to choose from >> and the after the user selects the program WineTools gets the appropriate >> overrides from the AppDB and sets them for the user. >> >> I think that that this is do-able if we work together. > > First, great idea. > > Second, here's a [very incomplete] list of what would need to be done > to pull this off: > - AppDB would have to be extended to be able to get and report this > data, and it would make sense for each App's maintainer to be able to > manage that information. > - Biggest issue here is that this information could have a tendency > to change very rapidly, so it might overload the app maintainers if > they had to track this for each version of wine. What I think would > make sense is to have regular snapshots (every 3 months?) and release > a new version of "Winetools Plus" or whatever you want to call this > thing a month later to give the maintainers time to update each of > their apps based on the frozen version. Well how often this should be updated depends on the development of the various dll. If all a program requires wine to emulate Windows 3.1 then it might not need updating ever. > - Data needed: AppID, AppVersionID, WineVersionID, Window Version, DLL > Overrides, Window settings (fullscreen/windowed - sometimes and > issue), Sound options, Video acceleration required, General notes or > HOWTO's, etc. You would need separate overrides/settings for > Installing vs. Running the app. You are right that we will probably need entries for both the installer and the program itself. > - AppDB could dump this information to an xml format which "Winetools > Plus" could be distributed with. Maybe have an option to download the > latest xml file directly from winehq.org. I see this as a dynamic thing as the list could get quite large. and downloading the whole thing for just one program seems excessive. > - The 'Winetools Plus' front-end would just be a menu which would > query all of the apps in the xml dump. The user picks they app they > want to install, and it reads the necessary information, verifies the > source installation media, and goes at it. I think that it would be better if the user entered into WineTools the name of the exe they were trying to run but you may be right about this option > - Applying patches to apps might get tricky (e.g., where wine only > successfully runs version 1.5 of the app, but 1.0 is on the CD), but > I'm sure it could be worked out. We cannot solve all the problems at once. > > Anyway, there's a start. That would encourage users to get involved > in the AppDB reporting process as well as better organize how to just > "get things done" using wine. > I would like to here from Joachim as to what WineTools would need. The main thing I would like to get away from in WineTools is the blanket changes that it now does of making wine emulate windows 95 and use native Dlls by default. Thanks for your input -- Tony Lambregts Tony Lambregts

March 11, 2006

Re: [Bugzilla] Add note to not paste logs and back traces.

by Vitaliy Margolen

Saturday, March 11, 2006, 11:19:57 AM, Rein Klazes wrote: > On Sat, 11 Mar 2006 08:14:03 -0700, you wrote: >>Change Log: Add note to attach and not paste logs and back traces. >> >>Files changed: template/en/default/bug/edit.html.tmpl >>template/en/default/bug/create/create.html.tmpl > Not pasting back traces will make following the bug list by email rather Well it might be true, but to a point. Most of the debug traces are too wide and e-mail wraps them (so does maillist archive). That _does_ make it nearly impossible to see anything. > useless. IMO what people are currently posting in bugzilla do not > require such recommendations. What? You mean having all the pastes in this bug: http://bugs.winehq.org/show_bug.cgi?id=4131 adds to it's readability? This is just one bug that I could think of. Also note that the biggest paste by author has nothing to do with the bug itself. Vitaliy

March 11, 2006

Re: x11drv: One more fix for "stuck" ctrl, shift & alt.

by Tomas Carnecky

Vitaliy Margolen wrote: > Anything wrong with this patch? It does fix the "stuck alt" problem for > games I use alt+tab on. > I can confirm that this fixes the bug. This patch is very important for me as I don't have to switch back and forth between desktop and WoW to un-stuck they alt-key. This patch works fine and I don't see any side-effects. tom

March 11, 2006

Re: [Bugzilla] Add note to not paste logs and back traces.

by Tony Lambregts

Rein Klazes wrote: > On Sat, 11 Mar 2006 08:14:03 -0700, you wrote: > >> Change Log: Add note to attach and not paste logs and back traces. >> >> Files changed: template/en/default/bug/edit.html.tmpl >> template/en/default/bug/create/create.html.tmpl > > Not pasting back traces will make following the bug list by email rather > useless. There is always a link in the email to the attachment. >IMO what people are currently posting in bugzilla do not > require such recommendations. > Well if that was the case there would not be so many comments telling people not to paste[1]. I can only see the situation getting worse as more people report bugs. [1] http://bugs.winehq.org/buglist.cgi?query_format=&short_desc_type=allwordssu… http://bugs.winehq.org/buglist.cgi?query_format=&short_desc_type=allwordssu…'t+paste

March 11, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Jason Green

On 3/11/06, Tony Lambregts <tony.lambregts(a)gmail.com> wrote: > In simple terms we get WineTools to query the AppDB with an application name (ie > somename.exe) and we return a list of applications for the user to choose from > and the after the user selects the program WineTools gets the appropriate > overrides from the AppDB and sets them for the user. > > I think that that this is do-able if we work together. First, great idea. Second, here's a [very incomplete] list of what would need to be done to pull this off: - AppDB would have to be extended to be able to get and report this data, and it would make sense for each App's maintainer to be able to manage that information. - Biggest issue here is that this information could have a tendency to change very rapidly, so it might overload the app maintainers if they had to track this for each version of wine. What I think would make sense is to have regular snapshots (every 3 months?) and release a new version of "Winetools Plus" or whatever you want to call this thing a month later to give the maintainers time to update each of their apps based on the frozen version. - Data needed: AppID, AppVersionID, WineVersionID, Window Version, DLL Overrides, Window settings (fullscreen/windowed - sometimes and issue), Sound options, Video acceleration required, General notes or HOWTO's, etc. You would need separate overrides/settings for Installing vs. Running the app. - AppDB could dump this information to an xml format which "Winetools Plus" could be distributed with. Maybe have an option to download the latest xml file directly from winehq.org. - The 'Winetools Plus' front-end would just be a menu which would query all of the apps in the xml dump. The user picks they app they want to install, and it reads the necessary information, verifies the source installation media, and goes at it. - Applying patches to apps might get tricky (e.g., where wine only successfully runs version 1.5 of the app, but 1.0 is on the CD), but I'm sure it could be worked out. Anyway, there's a start. That would encourage users to get involved in the AppDB reporting process as well as better organize how to just "get things done" using wine. My 2 cents. Jason

March 11, 2006

Re: "IE5 or higher required". Grr.

by Vitaliy Margolen

Saturday, March 11, 2006, 8:27:59 AM, Jeremy White wrote: >> BTW is there are some particular reason that you have to cc every >> single bug that you file to wine-devel mailing as well? I'm sorry, but >> quality of those bugs are not that good really to go directly to >> wine-devel list. With this particular bug you could at least try to find >> what is that program looks at to decide if you do have IE installed or >> not. > I certainly don't want wine-devel to turn into wine-users, > but I think you are wrong to lump Dan's emails into that category. > Dan is a very capable developer; he may not be the most > accomplished Wine hacker, but he is not without his chops. > Note that many of the @ucla.edu patches that come to wine-devel > are from his students. > Further, I think that Dan is triaging issues that are > of fairly critical interest to Wine. > For example, IE dependence is a very hard problem for Wine; > a lot of programs have that as an issue. I, for one, am > grateful to Dan for running with the Windows version > of Firefox, as it helps us be better ready to understand > how to use Firefox to solve that problem. > Further, I happen to know that the Munich considered > using Wine for their desktop migration, and they felt that > Wine was 'awful'; so it is very interesting to me, personally, > to explore why that might be. > Cheers, > Jeremy Ah ok. I want to apologize then. I'm trying to get reasonable bug reports with enough information so any developer can go in and look without downloading giga-bytes of stuff to just get something like WINEDEBUG=warn+all. Also most of the bugs end up being a duplicates of already known problems. In this particular case, I won't be surprised if all that software does is checks for one particular file somewhere in system32 directory. It's long know outstanding problem. I think if we search bugzilla we will come up with at least dozen of files that programs check for in this way. Again, sorry for the extra noise. Vitaliy.

March 11, 2006

Re: [Bugzilla] Add note to not paste logs and back traces.

by Rein Klazes

On Sat, 11 Mar 2006 08:14:03 -0700, you wrote: >Change Log: Add note to attach and not paste logs and back traces. > >Files changed: template/en/default/bug/edit.html.tmpl >template/en/default/bug/create/create.html.tmpl Not pasting back traces will make following the bug list by email rather useless. IMO what people are currently posting in bugzilla do not require such recommendations. Rein.

March 11, 2006

Re: May be a bad idea to have Winetools in the next SUSE release

by Tony Lambregts

Rich Gilson wrote: > On Thursday 09 March 2006 08:27, Joachim von Thadden wrote: >> What does that mean? We are making a tool to make Windows programs run >> with Wine. We do not develop Wine and our main goal is not to achieve as >> much debugging informations as possible. The goal is to make the usage >> of Wine as easy as possible for users coming from Windows and who are >> customized to point and click interfaces. Again: The goal is not to >> develop Wine. The goal is to use it easy. >> >> Regards >> Joachim von Thadden > > Please don't misunderstand me, I have a great deal of respect for what what > the Wine developers have accomplished so far; however, I feel that those that > have put the effort into Winetools have done so because they saw a need and > filled it. In the realm of ease of use and user-friendliness, Wine is > horribly lacking. Yes, it is getting better, but I think that Winetools is > the closest thing I've seen that would make it so that an average user could > us it. > > IMHO, the Wine developers should spend less time b*tching about Winetools and > more time figuring out how they can 1) build a front-end that is better than > Winetools, or 2) help improve Winetools so that it works more to their liking > but still offers an easy, user-friendly interface. > > Personally, I would like to see an application (be it Winetools or something > else, it doesn't really matter to me) that would interface with the appdb. > You could launch this front-end and it would pull up a list of all the > applications in the appdb that have special "config" files. These files > would tell this front-end EXACTLY what dll overrides are necessary, what > files to run, what needs to be installed beforehand, etc. Then, if there is > ever a change (due to Wine improving support for a particular dll so that an > override is no longer needed, for example) all that would have to be done is > to update the "config" file attached to the program in the appdb and *bingo*, > you've just "update" your front-end! > I think this is a "Good Idea" (tm) There are always going to be programs that need tweaks to get them to run. I know of a few that will work fine just by changing the windows version but fail miserably with a "clean wine" [1]. These programs usually fail in XP as well but it would be nice for the users to have an easy way to get them to run "out of the box" in wine There are others that look for a certain file and if it does not exist the program fails[2]. Just creating an empty file with the appropriate name is often enough to get the program working. This is a class of bug that is sure to be around for a while. The last class of bugs are the ones that require native (windows) DLL's [3]. It would be nice to be able to keep track of these somewhere so that developers know which files need to be worked on Most people are not programmers and even fewer are capable of being developers but if we can find a way to make everyones life easier both developers and users then we should do it. In simple terms we get WineTools to query the AppDB with an application name (ie somename.exe) and we return a list of applications for the user to choose from and the after the user selects the program WineTools gets the appropriate overrides from the AppDB and sets them for the user. I think that that this is do-able if we work together. -- Tony Lambregts [1] http://appdb.winehq.org/appview.php?versionId=4349 [2] http://bugs.winehq.org/show_bug.cgi?id=4796 http://bugs.winehq.org/show_bug.cgi?id=3661 [3] http://bugs.winehq.org/show_bug.cgi?id=4631

March 11, 2006

Re: GL_STENCIL-related build failures in dlls/wined3d/device.c

by Gerald Pfeifer

I've seen half a dozen or more changes to dlls/wined3d/device.c since that message of mine, but appare On Sun, 5 Mar 2006, Gerald Pfeifer wrote: > The recent changes to dlls/wined3d/device.c cause the following build > failures for me on FreeBSD 5.4, though I assume this is in fact not > related to FreeBSD but to xorg 6.8.2 or libglut 6.4.1 on this system. > > device.c: In function `IWineD3DDeviceImpl_SetRenderState': > device.c:3776: error: `GL_STENCIL_BACK_FAIL' undeclared (first use in this function) > device.c:3776: error: (Each undeclared identifier is reported only once > device.c:3776: error: for each function it appears in.) > device.c:3777: error: `GL_STENCIL_BACK_PASS_DEPTH_FAIL' undeclared (first use in this function) > device.c:3778: error: `GL_STENCIL_BACK_PASS_DEPTH_PASS' undeclared (first use in this function) > gmake[2]: *** [device.o] Error 1 > gmake[2]: Leaving directory `/.amd_mnt/nashira/files5/test/wine/dlls/wined3d' > gmake[1]: *** [wined3d] Error 2 > > The most straightforward patch would be the one below, but it leaves > three "variable may be used uninitialized" warnings in the first of the > two affected spots. > > Gerald > > Index: device.c > =================================================================== > RCS file: /home/wine/wine/dlls/wined3d/device.c,v > retrieving revision 1.145 > diff -u -3 -p -r1.145 device.c > --- device.c 4 Mar 2006 17:10:57 -0000 1.145 > +++ device.c 5 Mar 2006 08:35:52 -0000 > @@ -3226,9 +3226,15 @@ HRESULT WINAPI IWineD3DDeviceImpl_SetRen > > GLint action = StencilOp(Value); > > +#ifdef GL_STENCIL_FAIL > glGetIntegerv(GL_STENCIL_FAIL, &stencilFail); > +#endif > +#ifdef GL_STENCIL_PASS_DEPTH_FAIL > glGetIntegerv(GL_STENCIL_PASS_DEPTH_FAIL, &depthFail); > +#endif > +#ifdef GL_STENCIL_PASS_DEPTH_PASS > glGetIntegerv(GL_STENCIL_PASS_DEPTH_PASS, &stencilPass); > +#endif > > if(WINED3DRS_STENCILFAIL == State) { > stencilFail = action; > @@ -3773,9 +3779,15 @@ HRESULT WINAPI IWineD3DDeviceImpl_SetRen > > GLint action = StencilOp(Value); > > +#ifdef GL_STENCIL_BACK_FAIL > glGetIntegerv(GL_STENCIL_BACK_FAIL, &stencilFail); > +#endif > +#ifdef GL_STENCIL_BACK_PASS_DEPTH_FAIL > glGetIntegerv(GL_STENCIL_BACK_PASS_DEPTH_FAIL, &depthFail); > +#endif > +#ifdef GL_STENCIL_BACK_PASS_DEPTH_PASS > glGetIntegerv(GL_STENCIL_BACK_PASS_DEPTH_PASS, &stencilPass); > +#endif > > if(WINED3DRS_CCW_STENCILFAIL == State) { > stencilFail = action; > -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

March 11, 2006

Re: "IE5 or higher required". Grr.

by Jeremy White

> BTW is there are some particular reason that you have to cc every > single bug that you file to wine-devel mailing as well? I'm sorry, but > quality of those bugs are not that good really to go directly to > wine-devel list. With this particular bug you could at least try to find > what is that program looks at to decide if you do have IE installed or > not. I certainly don't want wine-devel to turn into wine-users, but I think you are wrong to lump Dan's emails into that category. Dan is a very capable developer; he may not be the most accomplished Wine hacker, but he is not without his chops. Note that many of the @ucla.edu patches that come to wine-devel are from his students. Further, I think that Dan is triaging issues that are of fairly critical interest to Wine. For example, IE dependence is a very hard problem for Wine; a lot of programs have that as an issue. I, for one, am grateful to Dan for running with the Windows version of Firefox, as it helps us be better ready to understand how to use Firefox to solve that problem. Further, I happen to know that the Munich considered using Wine for their desktop migration, and they felt that Wine was 'awful'; so it is very interesting to me, personally, to explore why that might be. Cheers, Jeremy

March 11, 2006

Re: "IE5 or higher required". Grr.

by Dan Kegel

On 3/10/06, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: > BTW is there are some particular reason that you have to cc every > single bug that you file to wine-devel mailing as well? I'm sorry, but > quality of those bugs are not that good really to go directly to > wine-devel list. The two apps I posted about yesterday were ones that a European city needed for its transition to desktop Linux, so they seemed important enough to post about. But if others think I'm spamming the devel list, I can certainly stop. > With this particular bug you could at least try to find > what is that program looks at to decide if you do have IE installed or > not. I did look at WINEDEBUG=+reg, but didn't see anything obvious. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 11, 2006

Re: Francois Gouget : user32: Handle WM_ENDSESSION in DefWinProc().

by Rein Klazes

On Fri, 24 Feb 2006 14:29:45 -0600, you wrote: >Author: Francois Gouget <fgouget(a)codeweavers.com> >Date: Fri Feb 24 15:34:09 2006 +0100 > >user32: Handle WM_ENDSESSION in DefWinProc(). >DefWinProc() should call PostQuitMessage() on WM_ENDSESSION if the >shutdown is proceeding. Hi Francois, This patch is causing a problem in Pegasus Mail. Closing some dialogs cause termination of the complete program. Here is a part of SPY++ log when run under win2000, when I close the edit new mail dialog: |<00202> 00130A82 S ..........................WM_SYSCOMMAND uCmdType:SC_CLOSE xPos:672 yPos:121 [wParam:0000F060 lParam:007902A0] |<00203> 00130A82 S ...........................WM_CLOSE wParam:00000000 lParam:00000000 |<00204> 00130A82 S ............................WM_QUERYENDSESSION nSource:1 (End Task from Task List dialog) [wParam:00000001 lParam:00000000] |<00951> 00130A82 R ............................WM_QUERYENDSESSION fShutdownIsOk:True [lResult:00000001] ... |<00952> 00130A82 S ............................WM_ENDSESSION fEndSession:True [wParam:00000001 lParam:00000000] |<00953> 00130A82 R ............................WM_ENDSESSION lResult:00000000 The WM_QUERYENDSESSION and WM_ENDSESSION are sent by the program: |0009:Call user32.SendMessageA(00030024,00000011,00000001,00000000) ret=0040641d How did you check the behavior of the Windows DefWindowProc? If I put a DefWindowProc(hwnd, WM_ENDSESSION, 1, 0); some where in a windows program nothing happens, while a PostQuitMesage certainly closes the app. Rein.

March 11, 2006

Re: "IE5 or higher required". Grr.

by Vitaliy Margolen

Friday, March 10, 2006, 11:53:24 PM, Dan Kegel wrote: > On 3/10/06, Dan Kegel <dank(a)kegel.com> wrote: >> I heard KeepTool was an app used by some government >> developers, so I tried installing the free trial from http://keeptool.com. >> Sadly, the installer complained I needed IE5 or later. > Filed at http://bugs.winehq.org/show_bug.cgi?id=4796 > - Dan > -- > Wine for Windows ISVs: http://kegel.com/wine/isv Well I guess that's the one that does need the IE installed. There are lots of programmes that relay on some functionality provided by IE. Doesn't matter if they really need it or not. BTW is there are some particular reason that you have to cc every single bug that you file to wine-devel mailing as well? I'm sorry, but quality of those bugs are not that good really to go directly to wine-devel list. With this particular bug you could at least try to find what is that program looks at to decide if you do have IE installed or not. Vitaliy Margolen.

March 11, 2006

Re: "IE5 or higher required". Grr.

by Dan Kegel

On 3/10/06, Dan Kegel <dank(a)kegel.com> wrote: > I heard KeepTool was an app used by some government > developers, so I tried installing the free trial from http://keeptool.com. > Sadly, the installer complained I needed IE5 or later. Filed at http://bugs.winehq.org/show_bug.cgi?id=4796 - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 11, 2006

"IE5 or higher required". Grr.

by Dan Kegel

I heard KeepTool was an app used by some government developers, so I tried installing the free trial from http://keeptool.com. Sadly, the installer complained I needed IE5 or later. The registry key trick I've been using, [Software\\Microsoft\\Internet Explorer] "Version"="6.0.2900.2180" didn't seem to do the trick this time. Any suggestions on how to get past that? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 11, 2006

spss can't even install...

by Dan Kegel

I heard that SPSS was one of the apps governments like (so they crunch statistics -- who knew? :-), so I tried running the free eval. It wouldn't even install. The problems were already described in http://bugs.winehq.org/show_bug.cgi?id=4700 Looks like an msi problem, but there might be something more general wrong; all wine apps hang for about twenty seconds at a certain point during the install, which is pretty strange. - Dan p.s. one downside of using wine to run firefox as your main browser is it's a bit more dangerous to do the rm -rf ~/.wine needed to do a really clean install of a test app :-) so this test was done with a fairly cluttered fake wine directory. But it seems to match the results in the PR. -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 11, 2006

Re: AlphaImageLoader - tranparent pngs 4 IE

by Mike Hearn

If you register and use a native dxtrans.dll it may work. On Wed, 08 Mar 2006 16:48:23 +0100, Axel Huizinga wrote: > Hi! > > Did anybody get DXImageTransform.AlphaImageLoader working > to render transparent png in IE on wine? > > Cordially, > Axel

March 10, 2006

Re: winegdb: Fix crash in empty first command

by Eric Pouech

Eric Pouech wrote: > Vitor T. Sessak wrote: > >> 2006/3/7, Eric Pouech >> >>> >>> 2006/3/6, Vitor T. Sessak <vitor.sessak at m4x.org >>> <http://www.winehq.org/mailman/listinfo/wine-patches>>: >>> >>>> / >> >> >> />>/ Changelog: >> />>/ winegdb: Fix crash in empty first command >> />>/ >> />>/ Winedbg crashes when pressing enter as its first command. >> /> >> >>> >>> this is wrong as the last_line will be HeapFree'd when the next >>> command is >>> keyed in. >> >> >> >> You are right. I've changed it and fixed the FIXME too. > > your new code leaks the lines (you never free them) to be more precise, when you copy the pointers, both last and this refer to the same buffer, which is not what you want you should duplicate the buffer A+ -- Eric Pouech

March 10, 2006

Re: winegdb: Fix crash in empty first command

by Eric Pouech

Vitor T. Sessak wrote: > 2006/3/7, Eric Pouech > >> >> 2006/3/6, Vitor T. Sessak <vitor.sessak at m4x.org >> <http://www.winehq.org/mailman/listinfo/wine-patches>>: >> >>> / > > />>/ Changelog: > />>/ winegdb: Fix crash in empty first command > />>/ > />>/ Winedbg crashes when pressing enter as its first command. > /> > >> >> this is wrong as the last_line will be HeapFree'd when the next >> command is >> keyed in. > > > You are right. I've changed it and fixed the FIXME too. your new code leaks the lines (you never free them) A+ -- Eric Pouech

March 10, 2006

Re: riched20: Implements FR_WHOLEWORD for EM_FINDTEXT

by Lei Zhang

On Monday 06 March 2006 11:06 am, you wrote: > Lei Zhang <leiz(a)ucla.edu> writes: > > --- dlls/riched20/editstr.h 2 Mar 2006 11:18:19 -0000 1.27 > > +++ dlls/riched20/editstr.h 5 Mar 2006 06:36:50 -0000 > > @@ -29,6 +29,7 @@ > > #include <stdarg.h> > > #include <stdio.h> > > #include <stdlib.h> > > +#include <wctype.h> > > You can't use anything from wctype.h in Wine. Use the functions from > wine/unicode.h instead. Hi Alex, I did not know wctype.h is unusable in Wine. Is this documented anywhere? I took a quick glance around the site and did not see much information regarding i18n. Anyway, I posted a revised patch to wine-patches earlier in the week: http://www.winehq.org/pipermail/wine-patches/2006-March/024848.html - Lei

March 10, 2006

Re: WINED3D: Color fixups for vertex shaders

by H. Verbeet

On 10/03/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Because reg is set to 6 in the declaration, this translates to specular > because VertexDecl8_Registers[6] corresponds to specular. Yes, but that shouldn't make it into the arrayUsageMap. ArrayUsageMap defines usage, but in this case we don't know how the data will be used.

March 10, 2006

Re: WINED3D: Color fixups for vertex shaders

by Roderick Colenbrander

> Either way, arrayUsageMap doesn't get initialised correctly. If we > don't know what's in a register, we shouldn't pass it through > arrayUsageMap, but use some other way. > > I won't be around next week, but after that I'll probably try to have > a look at d3d8 shaders. > The declaration is converted to a d3d9 shader in parsedeclaration8. The function parsetoken8 handles the conversion of a token. In this case the following code is entered: case D3DVSD_TOKEN_STREAMDATA: if (token & 0x10000000) { TRACE(" 0x%08lx SKIP(%lu)\n", token, ((token & D3DVSD_SKIPCOUNTMASK) >> D3DVSD_SKIPCOUNTSHIFT)); } else { DWORD type = ((token & D3DVSD_DATATYPEMASK) >> D3DVSD_DATATYPESHIFT); DWORD reg = ((token & D3DVSD_VERTEXREGMASK) >> D3DVSD_VERTEXREGSHIFT); ERR("reg: %d\n", reg); TRACE(" 0x%08lx REG(%s, %s)\n", token, VertexDecl8_Registers[reg], VertexDecl8_DataTypes[type]); } Because reg is set to 6 in the declaration, this translates to specular because VertexDecl8_Registers[6] corresponds to specular. Someone in #winehackers thought that perhaps your code should only be called for FVF shaders. Roderick -- Bis zu 70% Ihrer Onlinekosten sparen: GMX SmartSurfer! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer

March 10, 2006

Re: WINED3D: Color fixups for vertex shaders

by H. Verbeet

On 10/03/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > I have walked through the code. This small demo (dolphinvs from dx8.1 sdk) > uses the following vertex declaration for the seafloor: > D3DVSD_STREAM( 0 ), > D3DVSD_REG( 0, D3DVSDT_FLOAT3 ), // Position of first mesh > D3DVSD_REG( 3, D3DVSDT_FLOAT3 ), // Normal > D3DVSD_REG( 6, D3DVSDT_FLOAT2 ), // Tex coords > D3DVSD_END() > > It stores texture coordinates in register 6 (D3DVSD_SPECULAR). Registers > should be general purpose I think and this should work fine. Your patch > assumes that 'D3DVSD_SPECULAR' is allways used for colors which should be > swizzled. Well, no. It assumes that arrayUsageMap[WINED3DSHADERDECLUSAGE_SPECULAR] contains the register number for the register that is used to store specular colors, or -1 if there are no specular colors. loadNumberedArrays() in drawprim.c uses arrayUsageMap in the same way. > Because we are storing texture coordinates in them they shouldn't > be swizzled but we don't know what is stored in them. I'm not sure how to > fix this bug but I think the code should be moved to a later stage. I don't think that will work. We really need to know if a certain block of data is going to be used for colors or not, or we can't fix the data, in the shader or otherwise. Also, we have to fix the data before it gets passed to the shader or on input, we can't do it on output because other components (with the correct color order) might have been added in the shader. Either way, arrayUsageMap doesn't get initialised correctly. If we don't know what's in a register, we shouldn't pass it through arrayUsageMap, but use some other way. I won't be around next week, but after that I'll probably try to have a look at d3d8 shaders.

March 10, 2006

Re: ddraw design flaw

by Stefan Dösinger

Hi, > I have found a design flaw in ddraw and described it in my 'World of > Warcraft 0.10 Public Test Real (PTR)' thread. Why has nobody adressed > this issue? In my eyes it is a severe design flaw if an application > can't unload ddraw.dll without side effects (especially if this > side-effect is that all opengl/directx applications are unusable after > that). The ddraw implementation has some unloading bugs at the moment. Not restoring the glx context(that's the problem you reported, right) is only one of them. Another is that the screen resolution isn't restored when the app doesn't care for releasing it's object. I have this problem in mind, and I'll check WineD3D for it, as it most likely affects all D3D libs. Once it's fixed in wineD3D and ddraw uses wineD3D for rendering, this should be sorted out. Sorry for not fixing this at once, but time is limited ;). If you want a solution now, you're free to fix ddraw. But I registered that issue and it's on my lenghty todo list.

March 10, 2006

Re: WINED3D: Color fixups for vertex shaders

by Roderick Colenbrander

> In particular, is it the fixup for DIFFUSE, SPECULAR or either that > causes the problem? What are the values for reg, > arrayUsageMap[WINED3DSHADERDECLUSAGE_DIFFUSE] and > arrayUsageMap[WINED3DSHADERDECLUSAGE_SPECULAR]? > > It looks like texture coordinates are wrong, but those shouldn't be > affected by this patch, do you initialise arrayUsageMap correctly? > > I have walked through the code. This small demo (dolphinvs from dx8.1 sdk) uses the following vertex declaration for the seafloor: D3DVSD_STREAM( 0 ), D3DVSD_REG( 0, D3DVSDT_FLOAT3 ), // Position of first mesh D3DVSD_REG( 3, D3DVSDT_FLOAT3 ), // Normal D3DVSD_REG( 6, D3DVSDT_FLOAT2 ), // Tex coords D3DVSD_END() It stores texture coordinates in register 6 (D3DVSD_SPECULAR). Registers should be general purpose I think and this should work fine. Your patch assumes that 'D3DVSD_SPECULAR' is allways used for colors which should be swizzled. Because we are storing texture coordinates in them they shouldn't be swizzled but we don't know what is stored in them. I'm not sure how to fix this bug but I think the code should be moved to a later stage. Swizzling won't be done in the shader then :( Roderick -- Bis zu 70% Ihrer Onlinekosten sparen: GMX SmartSurfer! Kostenlos downloaden: http://www.gmx.net/de/go/smartsurfer

March 10, 2006