March 2006 - Wine-Devel - list.winehq.org

Re: GDI32: freetype.c add more font selecting&linking mechanism support.

by Byeong-Sik Jeon

2006-03-07 (화), 10:45 +0000, Huw D M Davies 쓰시길: > As Mike has said the patch is too long to review properly, so please > break it down into much smaller pieces. Yes. now working... > > and, I add some basic registry value. "Tahoma", "Gulim", "MS UI Gothic", > > "Simsun", "PMingLiU". > > One thing that caught my eye was that these strings are locale > dependent rather like the bitmap font strings (see update_font_info). Yes. that is just thing like example, I will remove that. but, tahoma is important. "Tahoma" is linked at the "System" and, many resource files use "MS Shell Dlg", and font substitutes "MS Shell Dlg"="Tahoma". therefore, if font(gulim.ttc, msgothic.ttc, ...) is exist, then we(CJK users) can see our latter at first start. just only "tahoma"... HKLM: [Software\\Microsoft\\Windows NT\\CurrentVersion\\FontLink\\SystemLink] "Tahoma"=str(7):"Gulim.ttc,Gulim\0MsGothic.ttc,MS UI Gothic \0SimSun.ttc,SimSun\0Mingliu.ttc,PMingLiU\0"

March 7, 2006

Re: GDI32: freetype.c add more font selecting&linking mechanism support.

by Huw D M Davies

As Mike has said the patch is too long to review properly, so please break it down into much smaller pieces. On Tue, Mar 07, 2006 at 04:29:04PM +0900, Byeong-Sik Jeon wrote: > and, I add some basic registry value. "Tahoma", "Gulim", "MS UI Gothic", > "Simsun", "PMingLiU". One thing that caught my eye was that these strings are locale dependent rather like the bitmap font strings (see update_font_info). Keep up the good work! Huw. -- Huw Davies huw(a)codeweavers.com

March 7, 2006

Re: WINED3D: Implement GetCreationParameters

by H. Verbeet

On 07/03/06, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Native D3D crashes if it's called with a NULL pointer? Are you sure that you > shouldn't return something like D3DERR_INVALIDCALL if pParamters == NULL? Yes. I verified that with DirectX 9.0c on win2k.

March 7, 2006

Re: advpack: Forward OpenINFEngineA and TranslateInfString/ExA to their unicode counterparts

by Alexandre Julliard

"James Hawkins" <truiken(a)gmail.com> writes: > + > + res = TranslateInfStringW(filenameW.Buffer, installW.Buffer, > + translateW.Buffer, keyW.Buffer, NULL, > + dwBufferSize, &len, NULL); > + > + if (res == S_OK) > + { > + bufferW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + > + res = TranslateInfStringW(filenameW.Buffer, installW.Buffer, > + translateW.Buffer, keyW.Buffer, bufferW, > + dwBufferSize, &len, NULL); > + > + *pdwRequiredSize = WideCharToMultiByte(CP_ACP, 0, bufferW, -1, > + pszBuffer, dwBufferSize, > + NULL, NULL); > + The buffer size and overflow handling is not correct here. -- Alexandre Julliard julliard(a)winehq.org

March 7, 2006

Re: WINED3D: Implement GetCreationParameters

by Stefan Dösinger

Am Dienstag, 7. März 2006 08:50 schrieb H. Verbeet: > On 07/03/06, Ivan Gyurdiev <ivg2(a)cornell.edu> wrote: > > > + if (!pParameters) { > > > + ERR("(%p) : Called with a NULL pParameters\n", This); > > > + } > > > + > > > + *pParameters = This->createParms; > > > > This is dereferencing a NULL pointer. > > Yes. Native d3d does that as well. The NULL pointer check there is > purely informational. Native D3D crashes if it's called with a NULL pointer? Are you sure that you shouldn't return something like D3DERR_INVALIDCALL if pParamters == NULL? Might be worth a test case if native really crashes.

March 7, 2006

Re: winegdb: Fix crash in empty first command

by Eric Pouech

2006/3/6, Vitor T. Sessak <vitor.sessak(a)m4x.org>: > > Changelog: > winegdb: Fix crash in empty first command > > Winedbg crashes when pressing enter as its first command. this is wrong as the last_line will be HeapFree'd when the next command is keyed in.

March 7, 2006

Re: GDI32: freetype.c add more font selecting&linking mechanism support.

by Mike McCormack

Byeong-Sik Jeon wrote: > ChangeLog: > - add more font selecting & linking mechanism support. Nice work! Some comments: * Please split each fix into a separate patch. This makes patch reviews and isolating regressions easier. A number of small patches will be accepted into the Wine tree faster than one big patch. * There's also alot of unnecessary formatting changes in your patch, which could be avoided. eg. > - LIST_FOR_EACH_ENTRY(family, &font_list, Family, entry) > - { > + LIST_FOR_EACH_ENTRY(family, &font_list, Family, entry) { * Please stick to coding style in the file you're change, so that we don't end up with a mix of many different coding styles in the same file. (and you don't add unnecessary changes like the above). thanks, Mike

March 7, 2006

Re: WINED3D: Implement GetCreationParameters

by H. Verbeet

On 07/03/06, Ivan Gyurdiev <ivg2(a)cornell.edu> wrote: > > > + if (!pParameters) { > > + ERR("(%p) : Called with a NULL pParameters\n", This); > > + } > > + > > + *pParameters = This->createParms; > > > This is dereferencing a NULL pointer. Yes. Native d3d does that as well. The NULL pointer check there is purely informational.

March 7, 2006

Re: riched20: Implements FR_WHOLEWORD for EM_FINDTEXT

by Lei Zhang

On Monday 06 March 2006 01:28 pm, Phil Krylov wrote: > On Sun, 05 Mar 2006 14:20:47 -0800 > > Lei Zhang <leiz(a)ucla.edu> wrote: > > + if ((flags & FR_WHOLEWORD) && iswalnum(wLastChar)) > > Probably a test checking if native richedit does not use user's word > breaking procedure (set via EM_SETWORDBREAKPROC) for FR_WHOLEWORD > searches would be cool. > > -- Ph. Thanks, I will add this along with some i18n tests at a later time. - Lei

March 7, 2006

Re: WINED3D: Implement GetCreationParameters

by Ivan Gyurdiev

> + if (!pParameters) { > + ERR("(%p) : Called with a NULL pParameters\n", This); > + } > + > + *pParameters = This->createParms; > This is dereferencing a NULL pointer.

March 7, 2006

Re: How to link and run applications using WinLib

by Robert Shearman

Segin wrote: > Arun Kumar Khandelwal wrote: > >> Hi All, >> I am able to compile and link my test program using winemaker. It >> generates a test.exe.so and not test.exe. I do not know how to run this >> *.so? What should I do to link and run program using winlib? Thanks, >> Arun > > you use it like any executable. The '.so' part is to signify that the > file is a ELF shared object. > > Also, can you attach the source code and executable in your reply? I'd > like to take a look at it, if that's not a problem. You use wine to run the program. If that is a problem then you can always provide a wrapper script or hack the source to always load your .exe.so file (if you are shipping wine with your program). -- Rob Shearman

March 7, 2006

Re: PATCH: define __user

by Robert Shearman

dmitry serpokryl wrote: > Hi, > > please beg my pardon for the kind of a possible stupidity, but: > > 1. I'm using SuSE kernel for SuSE 10 x86-64, so all compiliation goes > into x86-64 (not in i386) mode by default Wine automatically adds the -m32 flag to gcc to force it to compile in i386 mode. > 2. gcc - 4.0.2 (release): > Target: x86_64-unknown-linux-gnu > Configured with: ../configure --prefix=/usr/local/gcc-4.0.2 > Thread model: posix > gcc version 4.0.2 That's fine. > 3. $ wine --version > Wine 0.9.7 > (compiled some times ago from CVS. I make CVS updates monthly) As is this. > 4. $ locate unistd.h | egrep usr/include > /usr/include/asm-i386/unistd.h > /usr/include/asm-x86_64/ia32_unistd.h > /usr/include/asm-x86_64/unistd.h > /usr/include/asm.default/ia32_unistd.h > /usr/include/asm.default/unistd.h > /usr/include/kpathsea/c-unistd.h > /usr/include/linux.default/unistd.h > /usr/include/sys/unistd.h > /usr/include/unistd.h > > > 5. /usr/include/asm is a symlink, pointing to -> > /usr/src/linux/include/asm/ I think this is the problem. Is this a default symlink on your distro or was it put there by installing kernel source? > So, I'm not quite understand the reason of compiliation error at this > time. In 32-bit mode the i386 headers should be used instead of x86-64 ones. On your system this isn't happening, although the headers are there. Try looking in /usr/include/asm.default and seeing whether they try to do the right thing and select the right unistd.h for the environment. > > Please beg my pardon for the disturbing. > > Thanks, > > My best regards, > Dmitry > > > > On Tue, 28 Feb 2006 08:08:45 -0300, Robert Shearman > <rob(a)codeweavers.com> wrote: > >> dmitry serpokryl wrote: >> >>> Hi, thanks for your feedback. >>> >>> I just updated wine cvs, no ./configure errors but still "make" >>> unable to complete: >>> >>> gcc -m32 -c -I. -I. -I../../include -I../../include >>> -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe >>> -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement >>> -Wpointer-arith -g -O2 -o signal_i386.o signal_i386.c >>> signal_i386.c: In function ‘wine_sigaction’: >>> signal_i386.c:123: error: ‘__NR_sigaction’ undeclared (first use in >>> this function) >> >> >> >> You're using some buggy headers that define SYS_sigaction, but don't >> define __NR_sigaction. You should have /usr/include/asm/unistd.h >> that includes /usr/include/asm-i386/unistd.h if not compiling in >> x86_64 mode, and the latter should have a define for __NR_sigaction. >> > > > -- Rob Shearman

March 7, 2006

Re: How to link and run applications using WinLib

by Segin

Arun Kumar Khandelwal wrote: >Hi All, > I am able to compile and link my test program using winemaker. It >generates a test.exe.so and not test.exe. I do not know how to run this >*.so? What should I do to link and run program using winlib? >Thanks, >Arun > > > > > you use it like any executable. The '.so' part is to signify that the file is a ELF shared object. Also, can you attach the source code and executable in your reply? I'd like to take a look at it, if that's not a problem.

March 6, 2006

Re: riched20: Implements FR_WHOLEWORD for EM_FINDTEXT

by Phil Krylov

On Sun, 05 Mar 2006 14:20:47 -0800 Lei Zhang <leiz(a)ucla.edu> wrote: > + if ((flags & FR_WHOLEWORD) && iswalnum(wLastChar)) Probably a test checking if native richedit does not use user's word breaking procedure (set via EM_SETWORDBREAKPROC) for FR_WHOLEWORD searches would be cool. -- Ph.

March 6, 2006

Re: Error while compiling code using wineg++ / winegcc on solaris

by Kuba Ober

> I am not able to compile a test program on solaris using winegcc tool. > Can anybody help? . . . > When I try to compile it using winegcc, it gives following error > message: > testuser(a)testbox:~/test >wineg++ test.cpp > winegcc: -fshort-wchar failed. > > On adding a flag '-v' with wineg++, a detailed error message is > displayed: > testuser(a)testbox:~/test >wineg++ -v test.cpp > -fshort-wchar -DWINE_UNICODE_NATIVE -D_REENTRANT -fPIC -DWIN32 -D_WIN32 . . . Pardon me, but this kinda looks like wineg++ is not finding the compiler. Here's how it looks on my FC4 box with wine 0.9.7: $ wineg++ -v q.cpp g++ -fshort-wchar -DWINE_UNICODE_NATIVE . . . ^^^ You should investigate why wineg++ doesn't find what the name of the compiler is. It tried actually invoking an executable by the name of -fshort-wchar, as a session with truss would have shown ;) Cheers, Kuba

March 6, 2006

Re: KERNEL32: Improve descriptions

by Kuba Ober

> > > -UINT WINAPI GetTempFileNameW( LPCWSTR path, LPCWSTR prefix, > > > UINT unique, LPWSTR buffer ) +UINT WINAPI GetTempFileNameW( > > > LPCWSTR lpPathName, LPCWSTR lpPrefixString, UINT uUnique, > > > LPWSTR lpTempFileName ) > > > > *Please* don't change nice readable parameter names into the > > horrible Hungarian line noise format. > > Sorry, I thought we need to fix parameter names according to > MSDN :( Weren't the parameter names an implementation detail that's essentially invisible to the api user (docs nothwithstanding)? I.e. there's no such thing as 'fixing them' according to MSDN, because the api spec itself has no authority over parameter names. Heck, they can be different (or nonexistent) in the header files than in implementation files, and so on, right? Presumably the names should be nice so that wine maintainers can maintain the implementation ;) Cheers, Kuba

March 6, 2006

Re: FONTS: fix Courier font

by Huw D M Davies

On Mon, Mar 06, 2006 at 07:02:47PM +0300, Vitaly Lipatov wrote: > В сообщении от 6 марта 2006 17:27 Вы написали: > > "Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > > > > What are you trying to fix? > > > > > > There is screenshot from notepad with Courier font selected in > > > attachment. > > > > Do you see the same problem with Windows font? > No, only with WINE's courier without my path Looks like this might be a fontforge or FreeType problem. Windows courier at 13 ppem should have an ascent of 11 and a descent of 2, which is what we have in the .sfd. Now, when I run sfnt2fnt on the generated .ttf I get an ascent of 13, ppem of 13 and hence a descent of 0. I'm not going to have time to look into this soon, so please feel free to investigate more. Huw. -- Huw Davies huw(a)codeweavers.com

March 6, 2006

Re: [dsound] DllCanUnloadNow

by Alexandre Julliard

Christian Gmeiner <christian.gmeiner(a)students.fh-vorarlberg.ac.at> writes: > This patch > + implements LockServer > + implements DllCanUnloadNow You need to maintain the lock count when creating/deleting objects too. -- Alexandre Julliard julliard(a)winehq.org

March 6, 2006

Re: riched20: Implements FR_WHOLEWORD for EM_FINDTEXT

by Alexandre Julliard

Lei Zhang <leiz(a)ucla.edu> writes: > --- dlls/riched20/editstr.h 2 Mar 2006 11:18:19 -0000 1.27 > +++ dlls/riched20/editstr.h 5 Mar 2006 06:36:50 -0000 > @@ -29,6 +29,7 @@ > #include <stdarg.h> > #include <stdio.h> > #include <stdlib.h> > +#include <wctype.h> You can't use anything from wctype.h in Wine. Use the functions from wine/unicode.h instead. -- Alexandre Julliard julliard(a)winehq.org

March 6, 2006

Re: ntdll: Fix Directory Searching when VFAT_IOCTL_READDIR_BOTH returns an invalid d_reclen

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > --- a/dlls/ntdll/directory.c > +++ b/dlls/ntdll/directory.c > @@ -1245,7 +1245,11 @@ static NTSTATUS find_file_in_dir( char * > unix_name[pos - 1] = '/'; > for (;;) > { > - if (!de[0].d_reclen) break; > + if (!de[0].d_reclen) > + { > + unix_name[pos - 1] = 0; > + break; We should probably have a 'goto not_found' here instead. -- Alexandre Julliard julliard(a)winehq.org

March 6, 2006

Re: Error while compiling code using wineg++ / winegcc on solaris

by Dimi Paun

> The version is 3.4.2. Here's the console dump. This is odd. Can you check if the -fshort-wchar is at all supported on Solaris? Is it Solaris on Intel or Sparc? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

March 6, 2006

Re: Errors in Win API Stats

by Robert Shearman

Peter Åstrand wrote: > > I've noticied that http://www.winehq.org/site/winapi_stats is not > quite correct. For example, it claims that "amstream" is 100% > implemented, which is not correct: There are 21 stubs or something > like that. > > How is this page generated? It only looks at functions exported in the spec file. It doesn't look at COM interfaces. -- Rob Shearman

March 6, 2006

Re: [user.dll] get rid of DPRINTF

by Alexandre Julliard

Christian Gmeiner <christian.gmeiner(a)students.fh-vorarlberg.ac.at> writes: > This patch eliminates DPRINTF calls and replaces it with TRACE calls, as > suggested here: http://wiki.winehq.org/DebugTracingCleanup This doesn't apply to relay traces I'm afraid, they use a different format. -- Alexandre Julliard julliard(a)winehq.org

March 6, 2006

RE: Error while compiling code using wineg++ / winegcc on solaris

by Vikas Gera

Hi Dimi, Thanks for replying. The version is 3.4.2. Here's the console dump. -bash-3.00$ winegcc --version gcc (GCC) 3.4.2 Copyright (C) 2004 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Thanks & Regards, Vikas Gera HeadStrong Inc. -----Original Message----- From: Dimi Paun [mailto:dimi(a)lattica.com] Sent: Monday, March 06, 2006 6:11 PM To: Vikas Gera Cc: wine-devel(a)winehq.org Subject: Re: Error while compiling code using wineg++ / winegcc on solaris On Mon, 2006-03-06 at 14:47 +0530, Vikas Gera wrote: > testuser(a)testbox:~/test >wineg++ test.cpp > winegcc: -fshort-wchar failed. What version of gcc are you using? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

March 6, 2006

Re: FONTS: fix Courier font

by Vitaly Lipatov

В сообщении от 6 марта 2006 17:27 Вы написали: > "Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > > > What are you trying to fix? > > > > There is screenshot from notepad with Courier font selected in > > attachment. > > Do you see the same problem with Windows font? No, only with WINE's courier without my path -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

March 6, 2006