March 2006 - Wine-Devel - list.winehq.org

Re: DirectDraw -> WineD3D patch

by Peter Beutner

Stefan Dösinger schrieb: > Hi, > I've brought my DirectDraw over WineD3D patch in a form where I want to show > it to the public for review. I've uploaded it to > http://stud4.tuwien.ac.at/~e0526822/, where it is described in detail(below > the game list). nice work :). I just looked a bit into the palette issue( aka lost text color etc): from IWineD3DDeviceImpl_CreatePalette: + memset(&palVersion, 0, sizeof(LOGPALETTE)); + object->hpal = CreatePalette(&palVersion); + memcpy(&object->palVersion, &palVersion, sizeof(LOGPALETTE)); + /* FIXME Using the palVersion member from IWineD3DPaletteImpl for CreatePalette + * directly causes a heap corruption. Why? In original ddraw this was a WORD, + * which failed too. Confused ... + */ + object->palNumEntries = IWineD3DPaletteImpl_Size(Flags); That can't really work. This only creates a palette with zero entries. You need to set palNumEntries before calling CreatePalette. Attached patch( applies on top of yours ) should fix it( i.e. do it the same way it is done in the current implementation). But the text colors in AoE are still lacking :/. Needs some more investigation ... Peter b0a1e06bddc2bbc17bf7b5d991236a4cd76f0d1a diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index f224c2c..9b0e468 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -1660,12 +1660,11 @@ HRESULT WINAPI IWineD3DDeviceImpl_Create HRESULT WINAPI IWineD3DDeviceImpl_CreatePalette(IWineD3DDevice *iface, DWORD Flags, PALETTEENTRY *PalEnt, IWineD3DPalette **Palette, IUnknown *Parent) { IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *) iface; IWineD3DPaletteImpl *object; - LOGPALETTE palVersion; HRESULT hr; FIXME("(%p)->(%lx, %p, %p, %p)\n", This, Flags, PalEnt, Palette, Parent); /* Create the new object */ - object = HeapAlloc(GetProcessHeap(), 0, sizeof(IWineD3DPaletteImpl)); + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IWineD3DPaletteImpl)); if(!object) { ERR("Out of memory when allocating memory for a IWineD3DPalette implementation\n"); return DDERR_OUTOFVIDEOMEMORY; @@ -1676,15 +1675,14 @@ HRESULT WINAPI IWineD3DDeviceImpl_Create object->Flags = Flags; object->parent = Parent; object->wineD3DDevice = This; - - memset(&palVersion, 0, sizeof(LOGPALETTE)); - object->hpal = CreatePalette(&palVersion); - memcpy(&object->palVersion, &palVersion, sizeof(LOGPALETTE)); - /* FIXME Using the palVersion member from IWineD3DPaletteImpl for CreatePalette - * directly causes a heap corruption. Why? In original ddraw this was a WORD, - * which failed too. Confused ... - */ object->palNumEntries = IWineD3DPaletteImpl_Size(Flags); + + object->hpal = CreatePalette((const LOGPALETTE*)&(object->palVersion)); + + if(!object->hpal) { + HeapFree( GetProcessHeap(), 0, object); + return DDERR_OUTOFMEMORY; /* only reason why CreatePalette could have failed */ + } hr = IWineD3DPalette_SetEntries((IWineD3DPalette *) object, 0, 0, IWineD3DPaletteImpl_Size(Flags), PalEnt); if(FAILED(hr)) { diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 86b10bb..626154a 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1309,9 +1309,9 @@ struct IWineD3DPaletteImpl { /* IWineD3DPalette */ HPALETTE hpal; - LOGPALETTE palVersion; - WORD palNumEntries; - PALETTEENTRY palents[256]; + WORD palVersion; /*| */ + WORD palNumEntries; /*| LOGPALETTE */ + PALETTEENTRY palents[256]; /*| */ /* This is to store the palette in 'screen format' */ int screen_palents[256]; DWORD Flags;

March 3, 2006

Re: make crosstest

by Hans Leidekker

On Friday 03 March 2006 16:14, Saulius Krasuckas wrote: > -lkernel32 /usr/local/lib/gcc/i386-mingw32/3.4.4/libgcc.a: could not read > symbols: Archive has no index; run ranlib to add one Run this command: $ i386-mingw32-ranlib /usr/local/lib/gcc/i386-mingw32/3.4.4/libgcc.a There's something wrong with package building on recent Fedora Core releases but I haven't found the cause of it yet. -Hans

March 3, 2006

[mlang.dll] DllCanUnloadNow

by Christian Gmeiner

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This patch + implements LockServer + implements DllCanUnloadNow + add some needed calls to LockModule() & UnlockModule() If it didn't get into cvs i want a mail with the cause. - -- Christian Gmeiner - student of computer science http://dxr3plugin.sf.net http://itb04.ath.cx http://javamill.ath.cx -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFECFi9Dwe2AbwGBA8RApDQAJ4nCMpbbOeWBTi/x1xV36MrBaKoNgCfRTG8 54cyjapBkvdO9DUkNP41k3k= =HK0l -----END PGP SIGNATURE----- Index: dlls/mlang/mlang.c =================================================================== RCS file: /home/wine/wine/dlls/mlang/mlang.c,v retrieving revision 1.25 diff -u -r1.25 mlang.c --- dlls/mlang/mlang.c 6 Dec 2005 10:39:43 -0000 1.25 +++ dlls/mlang/mlang.c 3 Mar 2006 08:47:38 -0000 @@ -453,6 +453,21 @@ static void fill_cp_info(const struct mlang_data *ml_data, UINT index, MIMECPINFO *mime_cp_info); +static LONG dll_count; + +/* + * Dll lifetime tracking declaration + */ +static void LockModule(void) +{ + InterlockedIncrement(&dll_count); +} + +static void UnlockModule(void) +{ + InterlockedDecrement(&dll_count); +} + BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) { switch(fdwReason) { @@ -709,6 +724,7 @@ { TRACE("Destroying %p\n", This); HeapFree(GetProcessHeap(), 0, This); + UnlockModule(); } return ref; @@ -735,8 +751,11 @@ static HRESULT WINAPI MLANGCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { - IClassFactoryImpl *This = (IClassFactoryImpl *)iface; - FIXME("(%p)->(%d),stub!\n",This,dolock); + if (dolock) + LockModule(); + else + UnlockModule(); + return S_OK; } @@ -2281,6 +2300,9 @@ mlang->ref = 1; *ppObj = (LPVOID) mlang; TRACE("returning %p\n", mlang); + + LockModule(); + return S_OK; } @@ -2288,8 +2310,7 @@ HRESULT WINAPI DllCanUnloadNow(void) { - FIXME("\n"); - return S_FALSE; + return dll_count == 0 ? S_OK : S_FALSE; } HRESULT WINAPI GetGlobalFontLinkObject(void)

March 3, 2006

Re: Question about copyright lines

by Marcus Meissner

On Fri, Mar 03, 2006 at 03:20:48PM +0100, Stefan Dösinger wrote: > Hello, > At the top of every fine there's are some "Copyright <year> <name>" lines, > listing the persons who have contributed to a file, and when. Are there any > specifc rules about that? If you make a significant contribution, just add yourself there. (significant in my eyes -> new feature, code rewrite or similar) Ciao, Marcus

March 3, 2006

Re: WINECFG: Eliminate some gcc 4.1 warnings caused by casts in macros.

by Francois Gouget

On Fri, 3 Mar 2006, Mike McCormack wrote: [...] > They would prefer that we use statement expressions, which are gcc specific, > in our macros. Something like: Thanks for the explanation. Sure, having an #ifdef/#else/#endif for each macro is way too painful. But what about the following: +#ifndef WINE_CAST +# if __GNUC__ +# define WINE_CAST(ctype, val) ({ctype r=(ctype)(val);r;}) +# else +# define WINE_CAST(ctype, val) ((ctype)(val)) +# endif +#endif + + #define Header_SetImageList(hwnd,himl) \ - (HIMAGELIST)SNDMSGA((hwnd),HDM_SETIMAGELIST,0,(LPARAM)himl) + WINE_CAST(HIMAGELIST, SNDMSGA((hwnd),HDM_SETIMAGELIST,0,(LPARAM)himl)) + This pre-processes to code that uses the statement expression on gcc compilers and to the regular cast for others. So there should be no warning in either case (I couldn't check with gcc 4.1 but this preprocesses to the expected form). I also checked with gcc 2.95 and it compiles fine and without warning there which should be enough backwards compatibility for everyone (otherwise we can go further and check the GCC version). Of course in a real patch the WINE_CAST macro would be declared somewhere in windef.h, and we'd still have to change all the macros that cast a function result. But that seems quite feasible and not too ugly and I would be willing to submit such a patch. We may also want to find a better name. WINE_MACRO_CAST? WINE_MCAST? __MACRO_CAST? WINE_CAST_RESULT? Should I send such a patch? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

March 3, 2006

Question about copyright lines

by Stefan Dösinger

Hello, At the top of every fine there's are some "Copyright <year> <name>" lines, listing the persons who have contributed to a file, and when. Are there any specifc rules about that? Thanks, Stefan

March 3, 2006

ddraw/specular lighting

by david.adam

Hello, A lot of ddraw games recquires specular lighting to work (Syberia I, Settlers IV, etc...). Unfortunately, specular lighting is not implemented in ddraw. Does the change ddraw/direct 7 WINED3D resolve this problem? Otherwise, does somebody forsee to work on that? The implmentation of specular lighting would improve considerably the numbers of working games under wine.... Best regards, Joaopa

March 3, 2006

Re: WSH, WMI scripts

by Vassilis Virvilis

Sreenivas Tatti wrote: > Hi Mike, > You could have understood my requirement. I am looking at WINE to get > this thing done. If not supported in WINE, then what other possible way, > I can achieve this. I have to do some windows registry modifications and > start/stop/query about windows services from a Linux box. > I have to remotely install my agent on a windows box. That is my goal. > Thanks in anticipation. > With regards, > Sreenivas It is absolutely unrelated to wine and completely off topic but since you asked why don't you install cygwin to the remote machines and do the staff you want to do with ssh and some local scripting. I mean if you can do it from a dos prompt, ok a cmd prompt, then you have to be able to do it with a ssh connection remotely and in a secure manner too. http://pigtail.net/LRP/printsrv/cygwin-sshd.html .bill

March 3, 2006

RE: WSH, WMI scripts

by Sreenivas Tatti

Hi Mike, You could have understood my requirement. I am looking at WINE to get this thing done. If not supported in WINE, then what other possible way, I can achieve this. I have to do some windows registry modifications and start/stop/query about windows services from a Linux box. I have to remotely install my agent on a windows box. That is my goal. Thanks in anticipation. With regards, Sreenivas -----Original Message----- From: Mike McCormack [mailto:mike(a)codeweavers.com] Sent: Friday, March 03, 2006 4:28 PM To: Sreenivas Tatti Cc: wine-devel(a)winehq.org Subject: Re: WSH, WMI scripts Sreenivas Tatti wrote: > I have a requirement that, I should run WSH and WMI scripts in Linux > environment in order to do some registry changes on a remote machine and > start/stop/query windows services on a remote machine. It's unlikely to work, as DCOM (OLE over the network) does not work, and Wine currently has no builtin support for WSH/WMI. Mike

March 3, 2006

Re: WSH, WMI scripts

by Mike McCormack

Sreenivas Tatti wrote: > I have a requirement that, I should run WSH and WMI scripts in Linux > environment in order to do some registry changes on a remote machine and > start/stop/query windows services on a remote machine. It's unlikely to work, as DCOM (OLE over the network) does not work, and Wine currently has no builtin support for WSH/WMI. Mike

March 3, 2006

WSH, WMI scripts

by Sreenivas Tatti

Hi, I have a requirement that, I should run WSH and WMI scripts in Linux environment in order to do some registry changes on a remote machine and start/stop/query windows services on a remote machine. Can I use WINE for this purpose. Thanks in anticipation. With regards, Sreenivas T.

March 3, 2006

Re: COMCTL32: Fix some gcc 4.1 warnings caused by windowsx.h macros.

by Thomas Weidenmueller

Rob Shearman wrote: > IMHO, it would be better to see one patch that turns this warning off > than ten patches that obfuscate the code I absolutely appreciate this warning, IMO it's not code obfuscation. - Thomas

March 3, 2006

Re: COMCTL32: Fix some gcc 4.1 warnings caused by windowsx.h macros.

by Mike McCormack

Rob Shearman wrote: > I see little benefit in this warning being enabled. > > IMHO, it would be better to see one patch that turns this warning off > than ten patches that obfuscate the code Yesterday, Alexandre fixed 4 problems that showed using this warning: http://source.winehq.org/git/?p=wine.git;a=commit;h=c9cc7e33ffaaf9b359d6bcc… They showed up with gcc 4.1, but I didn't notice them because of the warnings from function casts. It's probably possible to turn it off using -Wno-unused-value, but there are real problems that will be caught with it. Consider part of Alexandre's patch yesterday: +++ b/dlls/ole32/ole2.c @@ -801,7 +801,7 @@ static HRESULT WINAPI EnumOLEVERB_Next( rgelt->grfAttribs = atolW(pwszAttribs); if (pceltFetched) - *pceltFetched++; + (*pceltFetched)++; This->index++; } return hr; Getting rid of the relative small number of macro uses that cause the warning doesn't seem to difficult, or to obfuscate the code too much to me. Mike

March 3, 2006

Regression in 0.9.9: Operation Flashpoint

by Riku Hintukainen

There seems to be a regression with Operation Flashpoint in wine-0.9.9, possibly because of the dx8->wine3d move. Should I file a bug, or wait if it gets fixed? Please cc since I' m not subscribed. $ wine ./FLASHPOINTRESISTANCE.EXE wine: Unhandled page fault on read access to 0x00000fd1 at address 0xfd1 (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000fd1 in 32-bit code (0x0 0000fd1). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:00000fd1 ESP:7fbcf1dc EBP:7fbcf298 EFLAGS:00210206( - 00 - RIP1) EAX:69c2c330 EBX:7bf87af8 ECX:7bf87af8 EDX:7fd5b3e0 ESI:7fd66830 EDI:00001e00 Stack dump: 0x7fbcf1dc: 7bf616a3 00000405 00001e00 00001e00 0x7fbcf1ec: 00001e00 00000000 7fd5b408 00000003 0x7fbcf1fc: 3f800000 7bf88620 00000000 00000000 0x7fbcf20c: 00000000 00000000 00000000 00001e00 0x7fbcf21c: 00001e00 00001e00 00000000 00001e00 0x7fbcf22c: 00001e00 00001e00 00001e00 00001e00 Backtrace: =>1 0x00000fd1 (0x00000fd1) 2 0x7bf73840 IWineD3DStateBlockImpl_InitStartupStateBlock+0xd90 in wined3d (0x 7bf73840) 3 0x7bf698f9 IWineD3DImpl_CreateDevice+0x229 in wined3d (0x7bf698f9) 4 0x7c23b958 IDirect3D8Impl_CreateDevice+0x108 in d3d8 (0x7c23b958) 5 0x004f3134 in flashpointresistance (+0xf3134) (0x004f3134) 0x00000fd1: addb %al,0x0(%eax) Modules: Module Address Debug info Name (79 modules) PE 0x00400000-007e1000 Export flashpointresistance PE 0x10000000-10032000 Deferred ifc22 PE 0x65f00000-65fc2000 Deferred ole32 ELF 0x69e59000-69e90000 Deferred dsound<elf> \-PE 0x69e70000-69e90000 \ dsound PE 0x69ea0000-69ef3000 Deferred rpcrt4 ELF 0x7bf00000-7bf03000 Deferred <wine-loader> ELF 0x7bf3c000-7bf89000 Export wined3d<elf> \-PE 0x7bf50000-7bf89000 \ wined3d ELF 0x7bf89000-7c000000 Deferred libglu.so.1 ELF 0x7c220000-7c240000 Export d3d8<elf> \-PE 0x7c230000-7c240000 \ d3d8 ELF 0x7e9fb000-7ea10000 Deferred midimap<elf> \-PE 0x7ea00000-7ea10000 \ midimap ELF 0x7eb2d000-7eb4e000 Deferred msacm32<elf> \-PE 0x7eb30000-7eb4e000 \ msacm32 ELF 0x7eb4e000-7ebe4000 Deferred libasound.so.2 ELF 0x7ebe5000-7ebfc000 Deferred msacm<elf> \-PE 0x7ebf0000-7ebfc000 \ msacm ELF 0x7ebfc000-7ec1d000 Deferred winealsa<elf> \-PE 0x7ec10000-7ec1d000 \ winealsa ELF 0x7ec40000-7ec5a000 Deferred imm32<elf> \-PE 0x7ec50000-7ec5a000 \ imm32 ELF 0x7ec5a000-7ec61000 Deferred libxrender.so.1 ELF 0x7ec62000-7ec79000 Deferred ximcp.so.2 ELF 0x7f3da000-7f562000 Deferred r200_dri.so ELF 0x7f562000-7f5be000 Deferred libgl.so.1 ELF 0x7f5be000-7f66c000 Deferred libx11.so.6 ELF 0x7f66c000-7f677000 Deferred libxext.so.6 ELF 0x7f677000-7f67b000 Deferred libxxf86vm.so.1 ELF 0x7f67b000-7f68f000 Deferred libice.so.6 ELF 0x7f68f000-7f700000 Deferred winex11<elf> \-PE 0x7f6a0000-7f700000 \ winex11 ELF 0x7f700000-7f71c000 Deferred libexpat.so.0 ELF 0x7f71c000-7f73e000 Deferred libfontconfig.so.1 ELF 0x7f73e000-7f7a0000 Deferred libfreetype.so.6 ELF 0x7f7a1000-7f7aa000 Deferred libgcc_s.so.1 ELF 0x7f7ad000-7f7b5000 Deferred libxcursor.so.1.0.2 ELF 0x7f7b5000-7f7b8000 Deferred libxrandr.so.2 ELF 0x7f7b8000-7f7eb000 Deferred dinput<elf> \-PE 0x7f7d0000-7f7eb000 \ dinput ELF 0x7f7eb000-7f7ff000 Deferred dinput8<elf> \-PE 0x7f7f0000-7f7ff000 \ dinput8 ELF 0x7f7ff000-7f81b000 Deferred iphlpapi<elf> \-PE 0x7f810000-7f81b000 \ iphlpapi ELF 0x7f81b000-7f840000 Deferred ws2_32<elf> \-PE 0x7f820000-7f840000 \ ws2_32 ELF 0x7f840000-7f859000 Deferred wsock32<elf> \-PE 0x7f850000-7f859000 \ wsock32 ELF 0x7f859000-7f86d000 Deferred lz32<elf> \-PE 0x7f860000-7f86d000 \ lz32 ELF 0x7f86d000-7f884000 Deferred version<elf> \-PE 0x7f870000-7f884000 \ version ELF 0x7f884000-7f8bb000 Deferred advapi32<elf> \-PE 0x7f890000-7f8bb000 \ advapi32 ELF 0x7f8bb000-7f93a000 Deferred gdi32<elf> \-PE 0x7f8d0000-7f93a000 \ gdi32 ELF 0x7f93a000-7fa47000 Deferred user32<elf> \-PE 0x7f950000-7fa47000 \ user32 ELF 0x7fa47000-7fac0000 Deferred winmm<elf> \-PE 0x7fa50000-7fac0000 \ winmm ELF 0x7fc05000-7fcf0000 Deferred kernel32<elf> \-PE 0x7fc20000-7fcf0000 \ kernel32 ELF 0x7fe00000-7fe02000 Deferred xlcutf8load.so.2 ELF 0x7fe02000-7fe07000 Deferred libxxf86dga.so.1 ELF 0x7fe07000-7fe0f000 Deferred libsm.so.6 ELF 0x7fe0f000-7fe19000 Deferred libnss_files.so.2 ELF 0x7fe19000-7fe23000 Deferred libnss_nis.so.2 ELF 0x7fe23000-7fe38000 Deferred libnsl.so.1 ELF 0x7fe38000-7fe40000 Deferred libnss_compat.so.2 ELF 0x7fe41000-7fe50000 Deferred libz.so.1 ELF 0x7fe5c000-7fe7f000 Deferred libm.so.6 ELF 0x7fe7f000-7ff75000 Deferred libwine_unicode.so.1 ELF 0x7ff75000-7ffe0000 Deferred ntdll<elf> \-PE 0x7ff90000-7ffe0000 \ ntdll ELF 0xb7dd4000-b7dd8000 Deferred libdl.so.2 ELF 0xb7dd8000-b7ef0000 Deferred libc.so.6 ELF 0xb7f5b000-b7f75000 Deferred libwine.so.1 ELF 0xb7f75000-b7f8c000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 00000008 (D) C:\Program Files\Codemasters\Operation Flashpoint\FLASHPOINTRESISTA NCE.EXE 0000000b 15 0000000a 0 00000009 0 <==

March 3, 2006

Re: WINECFG: Eliminate some gcc 4.1 warnings caused by casts in macros.

by Mike McCormack

Francois Gouget wrote: > What are these warnings? What is causing them? Sorry, should have posted an explanation. The warning comes from code like this: char foo(x); #define bar(x) (int) foo(x) So for the example you gave from my patch: #define Header_SetImageList(hwnd,himl) \ (HIMAGELIST)SNDMSGA((hwnd),HDM_SETIMAGELIST,0,(LPARAM)himl) We get a "computed value is not used" warning when we use Header_SetImageList without assigning the returned value to anything. I reported this in the gcc bugzilla some time ago, but the gcc team claim that this is a feature, not a bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25955 They would prefer that we use statement expressions, which are gcc specific, in our macros. Something like: #define Header_SetImageList(hwnd,himl) \ ({ HIMAGELIST r; \ r = (HIMAGELIST)SNDMSGA((hwnd),HDM_SETIMAGELIST,0,(LPARAM)himl); \ r; }) Alexandre suggested that we use inline functions to solve this problem, however this requires including winuser.h when including windowsx.h, and that we choose SendMessageA or SendMessageW for the macros that deal with strings. Conceivably we could use: #ifdef HAVE_BORKED_GCC_COMPUTED_VALUE_NOT_USED_WARNING #define Header_SetImageList(hwnd,himl) \ ({ HIMAGELIST r; \ r = (HIMAGELIST)SNDMSGA((hwnd),HDM_SETIMAGELIST,0,(LPARAM)himl); \ r; }) #else #define Header_SetImageList(hwnd,himl) \ (HIMAGELIST)SNDMSGA((hwnd),HDM_SETIMAGELIST,0,(LPARAM)himl) #endif This requires use -DHAVE_BORKED_GCC_COMPUTED_VALUE_NOT_USED_WARNING when compiling Wine code and Winelib apps. > Do we really have to give up on the macros and use SendMessage directly > to avoid the warnings? If we do, then I would say this means the macros > are broken because it means Winelib users will get the same problem we > do and will have to modify their code or live with gobs of warnings. Yes, and it will be broken for WineLib. I quote Alexandre from IRC: <julliard> mike_m: hmm right, that's a PITA <mike_m> truely <julliard> i'd say get rid of windowsx.h then I agree this is not an ideal solution... let me know if you have any better ideas. Mike

March 3, 2006

Re: WINECFG: Eliminate some gcc 4.1 warnings caused by casts in macros.

by Francois Gouget

On Fri, 3 Mar 2006, Mike McCormack wrote: > ChangeLog: > Eliminate some gcc 4.1 warnings caused by casts in macros. What are these warnings? What is causing them? > - TreeView_SetImageList(tree, hImageList, TVSIL_STATE); > + SendMessageW( tree, LVM_SETIMAGELIST, TVSIL_STATE, (LPARAM)hImageList ); Do we really have to give up on the macros and use SendMessage directly to avoid the warnings? If we do, then I would say this means the macros are broken because it means Winelib users will get the same problem we do and will have to modify their code or live with gobs of warnings. So, is there a way to fix the macros? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Avoid the Gates of Hell - use Linux.

March 3, 2006

Re: Launch native Linux apps?

by Stefan Dösinger

> Is it possible to set Wine up so that it can launch native Linux apps? For > example, set your native copy of Acrobat Reader to be associated to PDF > extensions in Wine, or even use the Linux plugin while using a browser? I have done this with Kmail and others. You have to add a few registry keys in HKCL and HKLM. Basically, you can launch any Linux app from wine by it's full path and pass command line arguments. There's of course the problem of converting Windows paths to Unix paths. At http://www.winehq.com/site/fun_projects my Kmail registry entries are described. For examples how to use Open Office, you have to google. I don't think that executing a Linux Plugin in a Win32 browser is possible, but cossover allows you to do the reverse. Stefan

March 3, 2006

Re: [wininet] More wininet tests InternetQueryOption and InternetSetOption - Corrected

by Vijay Kiran Kamuju

This is a detailed reply to ur mail. On 2/27/06, Detlef Riekenberg <wine.dev(a)web.de> wrote: > Am Mittwoch, den 22.02.2006, 23:13 +0530 schrieb Vijay Kiran Kamuju: > > Any thing wrong with this patch. > > Any Comments (expecting a lot) > > > > As you asked me, i took a look on this Patch. > > For my winspool-Patches, i was told to check the documented behavior and > only check undocumented behavior, when an Application relies on this > undocumented effect. > It's of course a good Idea, to print as much Informations as possible, > when a test Failed (err in your case). > > When i add a new Test, I add a trace after every tested API-Call, > compile the Test on linux with the mingw-crosstools as Windows-Binary > (make -C dlls/your_dllname_here/tests crosstest) and run that Binary on > all Windows-Versions that I have. After an update to the Parameter and > the Text for ok(), I do the tests on Windows again. > Then I test that Binary on wine. When there are no Failures left, i > remove the traces, compile again, test again, and after a final test in > wine with (make -C dlls/your_dllname_here/tests test), the diff is > created. > > > - Your Test did not apply here, so i merged the patch by cut & paste. > (malformed Patch) > > - I get 5 Failures on wine. (make -C dlls/wininet/tests test) > > > + hinet = InternetOpenA(useragent,INTERNET_OPEN_TYPE_DIRECT,NULL,NULL, > 0); > + ok((hinet != 0x0),"InternetOpen Failed\n"); > > - Please use (hinet != NULL) here, or is MSDN wrong (value / pointer)? > > - Does the other tests work, when InternetOpenA failed, or is it more > useful to return from the test here? > Just copied from http tests > > + SetLastError(0xdeadbeef); > + retval=InternetSetOptionA(hinet,INTERNET_OPTION_USER_AGENT, &inagent, > sizeof(inagent)); > + err=GetLastError(); > + ok(retval == 1,"Got wrong return value %d\n",retval); > + ok(err == 0xdeadbeef, "Got wrong error code %ld\n",err); > > For the Example above, my Idea is: > ok(retval, "returned %d with %ld (expected '!= 0')\n", retval, err); > Well due our partial implementation, we have not correctly implemented returning all the error states. Hence it requires seperate tests for error messages. > + len=0; > + SetLastError(0xdeadbeef); > + buffer=HeapAlloc(GetProcessHeap(),0,len); > + retval = > InternetQueryOptionW(hinet,INTERNET_OPTION_USER_AGENT,buffer,&len); > + err=GetLastError(); > + ok(buffer != NULL,"Output Buffer Should Not be Set"); > + todo_wine ok(len == 38,"Got wrong user agent length %ld instead of %d > \n",len,38); > + > > - You use HeapAlloc with a len of 0 and than the test "buffer != NULL": > This is a Test for HeapAlloc How to create a buffer with zero length does simple buffer = NULL suffice, i dont think so > - InternetQueryOptionW is not implemented in win95/98/me Will put a check for that once the base gets thru. > - Please avoid fixed numbers. When someone changes the Agent-Name, > the complete Test must be reworked. In most other tests we use basenumbers as well, i dont prefer using other functions in it. If there is a bug in their implementation, this test get affected. Each test case should be independent and atomic > > > For the tests of the W-Functions: > I was told, that i should test the Unicode-Functions only, when there > are other results as from the ANSI-Version. Since our ANSI - > Implementations should call the Unicode-Function, the ANSI-Test > validates both Implementations. > (Yes, i knew that the Implementation in wine is sometimes wrong: we have > Crosscalls W->A and some Unicode-Functions are stubs while the > ANSI-Versions are implemented) I am testing the both Unicode and Ansi Versions. If u are concerned about SetOptionW, i have made tests for this because our implementation for it is flawed. > > > + WideCharToMultiByte(CP_ACP,0,(WCHAR *)buffer,-1,tmpbuffer,len,0,0); > + todo_wine ok(!strcmp(inagent,tmpbuffer),"Got wrong user agent string % > s instead of %s\n",tmpbuffer,inagent); > > - This Test failed on Windows XP > Have to look into this. How to Compare char string and wchar string. > > + retval = InternetSetOptionW(NULL,INTERNET_OPTION_USER_AGENT, > &inpbuffer, sizeof(inpbuffer)); > You use ANSI-Parameter for an UNICODE-Function. > This is a test for bad programming ;) > > You can take a look at the Tests for winspool/GetPrinterDriverDirectory > - A test with the documented use to get the required size for the Buffer > (buffersize=0) > - A test with documented use (all Options valid) > - Buffer is larger (must succeed) > - Buffer is to small (must fail with a specific ERROR_*) > (Other Functions may truncate the returned Data) > - without a buffer (NULL), but with the correct buffersize. > This is for testing the API, when the app was unable to allocate > the Buffer, but did not check the Result of the allocation. > I will look into them > > > So there are some Reasons, why the test is not Ready yet. > > I read the Docs about InternetQueryOption on MSDN and IMHO there are so > many Documented values for dwOption, that I suggest to start with a > testing-table and fill it with all of our implemented Options for > InternetQueryOption / InternetSetOption. > We have then a complete Test of our wininet-Implementation with only a > small amount of code. The Table can grow very easy, when Applications > use Options that we need to implement. I wrongly chose to implement the INTERNET_OPTION_USER_AGENT, hence i am writing the tests for those. So that my implementation gets thru. I have tests for other options also in my mind. > > > -- > By By ... > ... Detlef > > Cheers, Vijay

March 3, 2006

Re: [wininet] More wininet tests InternetQueryOption and InternetSetOption - Corrected

by Vijay Kiran Kamuju

Thanks a lot on reviewing my patch, I have been busy lately. So i could not reply u soon enough. I will make some changes and send it to u for review. Thanks, Vijay On 2/27/06, Detlef Riekenberg <wine.dev(a)web.de> wrote: > Am Mittwoch, den 22.02.2006, 23:13 +0530 schrieb Vijay Kiran Kamuju: > > Any thing wrong with this patch. > > Any Comments (expecting a lot) > > > > As you asked me, i took a look on this Patch. > > For my winspool-Patches, i was told to check the documented behavior and > only check undocumented behavior, when an Application relies on this > undocumented effect. > It's of course a good Idea, to print as much Informations as possible, > when a test Failed (err in your case). > > When i add a new Test, I add a trace after every tested API-Call, > compile the Test on linux with the mingw-crosstools as Windows-Binary > (make -C dlls/your_dllname_here/tests crosstest) and run that Binary on > all Windows-Versions that I have. After an update to the Parameter and > the Text for ok(), I do the tests on Windows again. > Then I test that Binary on wine. When there are no Failures left, i > remove the traces, compile again, test again, and after a final test in > wine with (make -C dlls/your_dllname_here/tests test), the diff is > created. > > > - Your Test did not apply here, so i merged the patch by cut & paste. > (malformed Patch) > > - I get 5 Failures on wine. (make -C dlls/wininet/tests test) > > > + hinet = InternetOpenA(useragent,INTERNET_OPEN_TYPE_DIRECT,NULL,NULL, > 0); > + ok((hinet != 0x0),"InternetOpen Failed\n"); > > - Please use (hinet != NULL) here, or is MSDN wrong (value / pointer)? > > - Does the other tests work, when InternetOpenA failed, or is it more > useful to return from the test here? > > > + SetLastError(0xdeadbeef); > + retval=InternetSetOptionA(hinet,INTERNET_OPTION_USER_AGENT, &inagent, > sizeof(inagent)); > + err=GetLastError(); > + ok(retval == 1,"Got wrong return value %d\n",retval); > + ok(err == 0xdeadbeef, "Got wrong error code %ld\n",err); > > For the Example above, my Idea is: > ok(retval, "returned %d with %ld (expected '!= 0')\n", retval, err); > > + len=0; > + SetLastError(0xdeadbeef); > + buffer=HeapAlloc(GetProcessHeap(),0,len); > + retval = > InternetQueryOptionW(hinet,INTERNET_OPTION_USER_AGENT,buffer,&len); > + err=GetLastError(); > + ok(buffer != NULL,"Output Buffer Should Not be Set"); > + todo_wine ok(len == 38,"Got wrong user agent length %ld instead of %d > \n",len,38); > + > > - You use HeapAlloc with a len of 0 and than the test "buffer != NULL": > This is a Test for HeapAlloc > - InternetQueryOptionW is not implemented in win95/98/me > - Please avoid fixed numbers. When someone changes the Agent-Name, > the complete Test must be reworked. > > > For the tests of the W-Functions: > I was told, that i should test the Unicode-Functions only, when there > are other results as from the ANSI-Version. Since our ANSI - > Implementations should call the Unicode-Function, the ANSI-Test > validates both Implementations. > (Yes, i knew that the Implementation in wine is sometimes wrong: we have > Crosscalls W->A and some Unicode-Functions are stubs while the > ANSI-Versions are implemented) > > > + WideCharToMultiByte(CP_ACP,0,(WCHAR *)buffer,-1,tmpbuffer,len,0,0); > + todo_wine ok(!strcmp(inagent,tmpbuffer),"Got wrong user agent string % > s instead of %s\n",tmpbuffer,inagent); > > - This Test failed on Windows XP > > > + retval = InternetSetOptionW(NULL,INTERNET_OPTION_USER_AGENT, > &inpbuffer, sizeof(inpbuffer)); > You use ANSI-Parameter for an UNICODE-Function. > > > You can take a look at the Tests for winspool/GetPrinterDriverDirectory > - A test with the documented use to get the required size for the Buffer > (buffersize=0) > - A test with documented use (all Options valid) > - Buffer is larger (must succeed) > - Buffer is to small (must fail with a specific ERROR_*) > (Other Functions may truncate the returned Data) > - without a buffer (NULL), but with the correct buffersize. > This is for testing the API, when the app was unable to allocate > the Buffer, but did not check the Result of the allocation. > > > > So there are some Reasons, why the test is not Ready yet. > > I read the Docs about InternetQueryOption on MSDN and IMHO there are so > many Documented values for dwOption, that I suggest to start with a > testing-table and fill it with all of our implemented Options for > InternetQueryOption / InternetSetOption. > We have then a complete Test of our wininet-Implementation with only a > small amount of code. The Table can grow very easy, when Applications > use Options that we need to implement. > > > -- > By By ... > ... Detlef > >

March 3, 2006

BadMatch in glXCreateGLXPixmap (bug 3102)

by Damjan Jovanovic

"Star wars: knights of the old republic" dies on startup (see bug 3102) with BadMatch when create_glxpixmap() calls glXCreateGLXPixmap(). The man page for glXCreateGLXPixmap: GLXPixmap glXCreateGLXPixmap( Display *dpy, XVisualInfo *vis, Pixmap pixmap ) BadMatch is generated if the depth of pixmap does not match the depth value reported by core X11 for vis, or if pixmap was not created with respect to the same screen as vis. So can any xlib expert here give me some code to check for those 2 cases? Any other ideas what could be wrong? I believe a PBUFFER is involved, not the actual screen. Thanks Damjan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

March 3, 2006

Re: Recently created font problem - anyone see similar?

by Dmitry Timoshkov

"Dr J A Gow" <J.A.Gow(a)furrybubble.co.uk> wrote: > I found that the following patch, committed to CVS on 23/02/06 > at 20:33:06 made all my Wine system fonts squashed up and unreadable, which > in turn made a mess of formatting in some dialog boxes. I backed the > patch out from a current tree and the problem went away. Anyone else see > this behaviour? I am wondering what the purpose of this patch is as > the fonts were quite OK before it was committed, and now they are > completely unreadable on this system. Any thoughts before I submit a > patch to put this back the way it was? This usially means that you have no Wine bitmap fonts installed in windows/fonts. I sent a patch to wineprefixcreate to install them by default, by Alexandre rejected it. -- Dmitry.

March 2, 2006

Launch native Linux apps?

by Rich Gilson

Is it possible to set Wine up so that it can launch native Linux apps? For example, set your native copy of Acrobat Reader to be associated to PDF extensions in Wine, or even use the Linux plugin while using a browser? If so, how do I accomplish this? -- -- In a world without fences, who needs Gates?

March 2, 2006

Re: Recently created font problem - anyone see similar?

by Andrew Z

Dr J A Gow <J.A.Gow <at> furrybubble.co.uk> writes: > I found that the following patch, committed to CVS on 23/02/06 > at 20:33:06 made all my Wine system fonts squashed up and unreadable, which > in turn made a mess of formatting in some dialog boxes. I backed the > patch out from a current tree and the problem went away. Anyone else see > this behaviour? I am wondering what the purpose of this patch is as > the fonts were quite OK before it was committed, and now they are > completely unreadable on this system. Any thoughts before I submit a > patch to put this back the way it was? I had this problem too: http://bugs.winehq.org/show_bug.cgi?id=4682 I like the old behavior, and I don't like the solution of copying the fonts to the /usr/share/fonts because I want to be able to build WINE from source and run it from ~/wine without root permission (to install the fonts). Andrew

March 2, 2006

Re: DirectDraw -> WineD3D patch

by Aric Cyr

Stefan Dösinger <stefandoesinger <at> gmx.at> writes: > > Hi, > I've brought my DirectDraw over WineD3D patch in a form where I want to show > it to the public for review. I've uploaded it to > http://stud4.tuwien.ac.at/~e0526822/ , where it is described in detail(below > the game list). > Sweet! Looking forward to playing with this over the weekend. Seems like you are getting decent performance out of that radeon mobility 9000. I'll take a look at the OpenGL problem you list on the page and see if I can help (I love OpenGL, so any excuse to play with it is a good one) :) Good work! Hope your exams didn't suffer because of this ;) Regards, Aric

March 2, 2006

Recently created font problem - anyone see similar?

by Dr J A Gow

Hi, I found that the following patch, committed to CVS on 23/02/06 at 20:33:06 made all my Wine system fonts squashed up and unreadable, which in turn made a mess of formatting in some dialog boxes. I backed the patch out from a current tree and the problem went away. Anyone else see this behaviour? I am wondering what the purpose of this patch is as the fonts were quite OK before it was committed, and now they are completely unreadable on this system. Any thoughts before I submit a patch to put this back the way it was? John. The offending patch: Module: wine Branch: refs/heads/master Commit: 69a23a608eea59624b2f37ab424e0f42b3da5baf URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=69a23a608eea59624b2f37a… Author: Dmitry Timoshkov <dmitry at codeweavers.com> Date: Thu Feb 23 20:33:06 2006 +0800 gdi: Use "MS Sans Serif" as default sans serif font, not Arial. --- dlls/gdi/freetype.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/gdi/freetype.c b/dlls/gdi/freetype.c index ad0d6eb..51e92b8 100644 --- a/dlls/gdi/freetype.c +++ b/dlls/gdi/freetype.c @@ -284,10 +284,10 @@ static struct list font_list = LIST_INIT static const WCHAR defSerif[] = {'T','i','m','e','s',' ','N','e','w',' ', 'R','o','m','a','n','\0'}; -static const WCHAR defSans[] = {'A','r','i','a','l','\0'}; +static const WCHAR defSans[] = {'M','S',' ','S','a','n','s',' ','S','e','r','i','f','\0'}; static const WCHAR defFixed[] = {'C','o','u','r','i','e','r',' ','N','e','w','\0'}; -static const WCHAR defSystem[] = {'A','r','i','a','l','\0'}; +static const WCHAR defSystem[] = {'S','y','s','t','e','m','\0'}; static const WCHAR SystemW[] = {'S','y','s','t','e','m','\0'}; static const WCHAR MSSansSerifW[] = {'M','S',' ','S','a','n','s',' ', 'S','e','r','i','f','\0'};

March 2, 2006

DirectDraw -> WineD3D patch

by Stefan Dösinger

Hi, I've brought my DirectDraw over WineD3D patch in a form where I want to show it to the public for review. I've uploaded it to http://stud4.tuwien.ac.at/~e0526822/, where it is described in detail(below the game list). If there are no fundamental objections against it, I'll start sending patches for WineD3D. The changes I'll make in small patches :) are: -> Header fixes, that wined3d_interface.h can be included with d3d.h -> Adding methods to WineD3D for DirectDraw rendering -> Adding the 2D only surface implementation to WineD3D When WineD3D is ready, I'll send a patch for dlls/ddraw to wine-devel and wine-user for a broad regression testing, and when the regressions are out, the ddraw can be replaced(From my POV, AJ has the last word of course ;) ) Have fun playing, Stefan

March 2, 2006

getwinegit.sh 0.21 released

by Christian Lachner

Hellooo, punctual to the new wine-0.9.9-release there is a new version of my getwinegit.sh-script. No great changes but some smaller ones. First of all, the logger got more informative if you experience problems with your getwinegit.sh-installation. The second thing is a better checking of the config-vars. Not the supergreat errorhandling i would like it to be but now there is something that checks if the vars are set and so on. The last thing is that the readme got a bit more informatical (dependencies and compatibility of shells). Maybe there were some more minor changes in the script but... i can't remember ;). Current version is now 0.21. PS: the release is now packed in a tar.bz2 as requested :D

March 2, 2006

Re: Dogfood Challenge, week 2

by Dan Kegel

On 2/9/06, Dan Kegel <dank(a)kegel.com> wrote: > > Firefox is quite usable; I read gmail in it routinely. > Here's my current list of firefox dogfood bugs: > > http://bugs.winehq.org/show_bug.cgi?id=4441 - black bars > http://bugs.winehq.org/show_bug.cgi?id=4523 - copy broken > http://bugs.winehq.org/show_bug.cgi?id=4528 - too tall > http://bugs.winehq.org/show_bug.cgi?id=4529 - screwy stars At first glance, Mike's patch for 4529 also fixes bugs 3171, 4441, and 4442! Firefox just got a lot tastier. (The patch isn't in cvs yet, but I think it ought to be, based on my extensive ten minutes of testing :-) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 2, 2006

Re: WineD3D Opengl 2.x compile fix

by H. Verbeet

On 02/03/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: >+ if(WINE_GL_VERSION_MAJOR(gl_info->gl_version) == 2) { Shouldn't that be >= 2? It seems unlikely functionality would get removed in later OpenGL versions.

March 2, 2006

Re: Alexandre Julliard : configure: Use --rpath if supported when building binaries to point to

by Alexandre Julliard

Vitaly Lipatov <lav(a)etersoft.ru> writes: > Now I think there is bug somewhere. I see in ps strange paths after ran any > program: > /usr/lib/../bin/wine-preloader > /usr/lib/../bin/wine-kthread notepad.exe > /usr/lib/../bin/wineserver That's not a bug, it's a feature. Binaries are now located relative to the library path, so if you move your Wine install somewhere else it still works, without having to set environment variables. -- Alexandre Julliard julliard(a)winehq.org

March 2, 2006

Re: Alexandre Julliard : configure: Use --rpath if supported when building binaries to point to

by Jan Zerebecki

On Wed, Mar 01, 2006 at 08:29:38PM -0800, Dan Kegel wrote: > Vitaly wrote: > >Build system in ALT Linux has strict requires to use rpath and last changes in > >wine conflicts with it. > > Can you explain more about ALT Linux's build system and rpath? > > Does it disallow all use of rpath by applications? > - Dan At least for Debian I think rpath may not be used. But as I understand it, it may be used if the referenced lib. path is completely private to the package, even tho that is discouraged. See the following link and especially the linked mailinglist thread for explanation: http://www.netfort.gr.jp/~dancer/column/libpkg-guide/libpkg-guide.html#rpath Jan

March 2, 2006

Re: [PATCH 3/3] [Dnsapi.dll] Tests

by Steven Edwards

On 3/2/06, Steven Edwards <winehacker(a)gmail.com> wrote: > Why don't you break this out in to a function like load_dnsapi() that > way if there are missing symbols from one version to another you can > use GetProcAddress and delay load them and it will all be contained in > one function. Also to make it clear you don't need to do the delay loading of the symbols unless they really differ from one windows to another. Just using the LoadLibrary is fine. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

March 2, 2006

Re: [PATCH 3/3] [Dnsapi.dll] Tests

by Steven Edwards

Hi, Just a matter of style to save moving the code around later if we add more tests. +START_TEST(names) +{ + HMODULE hdnsapi = LoadLibrary("dnsapi.dll"); + char *testname1 = ".bob"; + char *testname2 = ".bOb"; + + trace("Dnsapi.dll is only on Win2k and above.\nChecking...\n"); + if(hdnsapi != NULL) + { + trace("Dnsapi.dll loaded.\nNow unloading...\n"); + FreeLibrary(hdnsapi); + } + else + { + trace("Dnsapi.dll was not loaded or failed to be unloaded.\n"); + return; + } Why don't you break this out in to a function like load_dnsapi() that way if there are missing symbols from one version to another you can use GetProcAddress and delay load them and it will all be contained in one function. + trace("Now testing function: DnsNameCompare_A(LPSTR, LPSTR)\n"); + ok(DnsNameCompare_A(testname1,testname2)==TRUE, + "Comparison failed!\n %s and %s should be equal!\n",testname1,testname2); + trace("%s and %s are equal.\n",testname1,testname2); Also it would be a good idea to break this out in to another function. I tend to do one function per API I am checking so I would stick all of this in to a function called test_DnsNameCompare(); +} Nice work btw. Thanks for being patent with submitting patches and tests. I am not really that great of a programmer and these type of style changes help me follow along and write better tests. Take a look at this test I wrote to get the idea http://cvs.winehq.org/cvsweb/wine/dlls/setupapi/tests/stringtable.c?rev=1.2… It tends to be more lines but I think its much clearer to read. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

March 2, 2006

Re: New d3d8 code and FFXIBench3 - pretty good!

by Stefan Dösinger

Hi, > I own Diablo 2... this would be a good reason to dust it off :) I should get it by today :) I ordered it at Amazon for a cheap price. Usually it takes 3 days until I get things. Snail mail that is :). > I am running fglrx as well, so I could work on getting the performance up > on these cards. I also have contacts at ATI, so if there are specific > problem I could send feedback directly, and hopefully they can fix things > for future releases. Although I'd check glDrawPixels on Windows as well... > I suspect it is just as slow there. Also for glDrawPixels you should turn > off a lot of the GL state (lighting and stuff that you don't need). That > could speed things up a bit. The attached program illustrates the problem: It's a d3d9 app and runs with current Wine CVS. On startup, it shows a black screen. If you press any button(except ESC), it will do a Clear with a solid color based on the key you pressed. If you click anywhere with the left mouse button, it locks the backbuffer, fills it with 0xff, unlocks it and flips. On Mesa radeon this has no effect(image doesn't change), with software rendering it's the same, as well with fglrx. If you change the pixel format to D3DFMT_R8G8B8, then it will work for fglrx. I haven't tested this on Windows, but I was told that it works with Nvidia cards in Wine. I just tested it in some old cvscedega version, and there it works, although I have to click twice. If you change D3DSWAPEFFECT_FLIP to D3DSWAPEFFECT_DISCARD in line 121, the screen will go black on clicks, with a delay of about one secound, so you can see the slowlyness. In some rare cases in games, glDrawPixels writes a dark, solid color, and if it writes to the front buffer, it's possible to see the new color sliding down slowly. I suspect that glDrawPixels isn't really broken, but WineD3D sets up render states which break it. I wanted to do a test with a simple GL app, but I didn't find the time yet. Current DDraw is broken in the same way, but it in the most cases, it draws a textured quad instead of using glDrawPixels, which works fine there.

March 2, 2006

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll

by Rolf Kalbermatter

Mike McCormack [mike(a)codeweavers.com] wrote: >> + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); >> + return ERROR_CALL_NOT_IMPLEMENTED; >> +} > >You SetLastError or return an error code, not both. This is not always correct. Win32 API has several functions returning an int where the only SDK documentation is that the function returns 0 on success and anything else on failure. What those usually seem to do is retuning the (internal) error code. Relying on such a return value being anything than 0 or !0 of course would be bad programming, since there will be potential differences between different platforms but it does happen. Rolf Kalbermatter

March 2, 2006

re: Alexandre Julliard : configure: Use --rpath if supported when building binaries to point to

by Dan Kegel

Vitaly wrote: >Build system in ALT Linux has strict requires to use rpath and last changes in >wine conflicts with it. Can you explain more about ALT Linux's build system and rpath? Does it disallow all use of rpath by applications? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

March 1, 2006

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll

by Mike McCormack

Also, please disable your challenge/response spam "filter". Solving your spam problem by spamming everybody else is not cool. You wrote to us with a patch, you solicited our response, so why are you spamming us back? I'd advise others to not respond to spam from bluebottle.com. Mike

March 1, 2006

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll

by Dmitry Timoshkov

"MattK" <mekjedi(a)bluebottle.com> wrote: > + if(fdwReason == DLL_THREAD_ATTACH) > + { > + DisableThreadLibraryCalls(hinstDLL); > + return TRUE; > + } This is not an appropriate place to call DisableThreadLibraryCalls, how did you come with it when there are a lot of examples in the Wine tree? -- Dmitry.

March 1, 2006

Re: x11drv fix for bug#4506: page fault on read access

by Dmitry Timoshkov

"Rein Klazes" <wijn(a)wanadoo.nl> wrote: > + srcpixel = (const DWORD*)((int)srcpixel & 0xfffffffc); It would be more readable IMO to use ~3 instead of 0xfffffffc. -- Dmitry.

March 1, 2006

[wined3d] glStencilOpSeparate & glStencilFuncSeparate symbol errors

by Aric Cyr

The recent patch: http://winehq.org/pipermail/wine-patches/2006-February/024656.html can cause linker errors for the two symbols glStencilOpSeparate and glStencilFuncSeparate. The reason being that these are only exported in OpenGL 2.0 compatible libraries, and in particular, are not present in ATI's binary driver. This causes wined3d to fail to build (compiles fine but linking fails). I suspect that Vitaly is already working on fixing this, but thought I'd mention it anyways since other might run into the same problem. Cheers, Aric

March 1, 2006

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll

by Mike McCormack

MattK wrote: > +BOOL WINAPI DnsNameCompare_A(LPSTR pName1, LPSTR pName2) > +{ > + TRACE("(%s %s)\n",pName1, pName2); > + > + LPSTR name1 = pName1; > + LPSTR name2 = pName2; > + > + RemovePeriods(name1); > + RemovePeriods(name2); > + > + int equal; > + > + equal = lstrcmpiA(name1,name2); > + > + return !equal; > +} This is still not correct. You can't modify name1, and name2 in place. You shouldn't use inline declarations (ie. the "int equal" should be after the bracket.) There's also no in assigning pName1 to name1, it doesn't make a copy of the string as you suspect, it makes a copy of the pointer to the string. > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} You SetLastError or return an error code, not both. > diff -Nu dlls/dnsapi/utils.c dlls/dnsapi/utils.c There's no need to make a seperate file for this. > +LPSTR RemovePeriods(LPSTR string) > +{ > + if(string == NULL) > + return NULL; > + DWORD d = 0; > + > + while(string[d] == '.') > + { > + string--; > + } > + > + return string; > +} This won't work at all... If you wrote some better test cases you would discover these problems. How about testing: DnsNameCompare_A(NULL, NULL) DnsNameCompare_A("", ".") DnsNameCompare_A("..........", "..........") DnsNameCompare_A(".a.b.c.d.e.", "abcde") DnsNameCompare_A("a.com.","a.com") DnsNameCompare_A("A.com", "a.com") DnsNameCompare_A(".A.com", "a.com") DnsNameCompare_A("Acom", "acom") etc. Mike

March 1, 2006

Re: wined3d: Fix compile for older OpenGL headers.

by Raphael

On Wednesday 01 March 2006 11:48, Vitaly Budovski wrote: > H. Verbeet wrote: > > Although #ifdef GL_VERSION_2_0 will make compilation work with older > > OpenGl headers, it's not the way to fix this. Basically, wined3d > > should check for functionallity during runtime with GL_SUPPORT and > > call extensions with GL_EXTCALL. The issue has come up a few times > > before with patches from the same author, and I think he should be > > aware of the issue by now. > > That takes care of functions as part of an OpenGL extension. > What about core functions of a newer GL version? Would all of > those need to be defined in the wined3d_gl.h file? i forget :) We shouldn't have no more built-time checks as example: #if defined(GL_VERSION_1_3) We always must use runtime checks So WineD3D_GL_Info::gl_version must be correctly filled (isn't initialised for now) and used Regards, Rapahel

March 1, 2006

Re: wined3d: Fix compile for older OpenGL headers.

by Raphael

On Wednesday 01 March 2006 11:48, Vitaly Budovski wrote: > H. Verbeet wrote: > > Although #ifdef GL_VERSION_2_0 will make compilation work with older > > OpenGl headers, it's not the way to fix this. Basically, wined3d > > should check for functionallity during runtime with GL_SUPPORT and > > call extensions with GL_EXTCALL. The issue has come up a few times > > before with patches from the same author, and I think he should be > > aware of the issue by now. > > That takes care of functions as part of an OpenGL extension. > What about core functions of a newer GL version? Would all of > those need to be defined in the wined3d_gl.h file? Yes, else will have problems in wine launch if installed OpenGL library not provide this symbols Regards, Raphael

March 1, 2006

Re: Alexandre Julliard : configure: Use --rpath if supported when building binaries to point to

by Mike Hearn

On Wed, 2006-03-01 at 22:21 +0300, Vitaly Lipatov wrote: > Did you mean fix rpm spec? No, fix RPM the program. If the RPM software can't cope with a simple use of RPATH then it is buggy and should be patched. > You are about workaround explained by Alexandre? The workaround is fine for Wine, but it's the general principle I have a problem with. If you asked me to add a --disable-rpath switch to software I maintained I'd say no, because this is not a bug in my software but rather with RPM itself. > Now I think there is bug somewhere. I see in ps strange paths after ran any > program: > /usr/lib/../bin/wine-preloader > /usr/lib/../bin/wine-kthread notepad.exe > /usr/lib/../bin/wineserver Looks OK to me. A bit ugly maybe ...

March 1, 2006

Re: [PATCH 1/4] [WineDbg]: main_loop

by Eric Pouech

Alexandre Julliard wrote: > Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > > >>- split dbg_main_loop in two parts (one for finishing the debuggee >> attachment, the second one really for handling the main loop) >>- removed now longer needed dbg_main_loop > > > Auto mode is still broken with this patch... did you really test it? > yes, at some point, then did some last minute change, which broke it A+ -- Eric Pouech

March 1, 2006

Re: Alexandre Julliard : configure: Use --rpath if supported when building binaries to point to

by Vitaly Lipatov

В сообщении от 1 марта 2006 21:25 Mike Hearn написал(a): > On Wed, 2006-03-01 at 20:50 +0300, Vitaly Lipatov wrote: > > Dear Mike, I asked Alexandre to add _option_ to configure for disable > > rpath but to remove rpath using. > > I understand the request, but the question remains - why are you asking > every single upstream author to add complexity to their build systems, > when you could just fix RPM? Did you mean fix rpm spec? You are about workaround explained by Alexandre? Build system in ALT Linux has strict requires to use rpath and last changes in wine conflicts with it. I guess I do not understand where is problem in RPM you told about. Now I think there is bug somewhere. I see in ps strange paths after ran any program: /usr/lib/../bin/wine-preloader /usr/lib/../bin/wine-kthread notepad.exe /usr/lib/../bin/wineserver -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

March 1, 2006

Re: Alexandre Julliard : configure: Use --rpath if supported when building binaries to point to

by Mike Hearn

On Wed, 2006-03-01 at 20:50 +0300, Vitaly Lipatov wrote: > Dear Mike, I asked Alexandre to add _option_ to configure for disable rpath > but to remove rpath using. I understand the request, but the question remains - why are you asking every single upstream author to add complexity to their build systems, when you could just fix RPM? thanks -mike

March 1, 2006

Re: wined3d: Implemented WINED3DRS_DEPTHBIAS

by H. Verbeet

On 01/03/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > + glPolygonOffset(*((float*)&This->stateBlock->renderState[WINED3DRS_SLOPESCALEDEPTHBIAS]), tmpvalue.f); Does this compile?

March 1, 2006

Re: wined3d: Add function pointers to glSupportOpSeparate and glSupportFuncSeparate

by H. Verbeet

On 01/03/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > wined3d: Add function pointers to glSupportOpSeparate and > glSupportFuncSeparate > That's not going to help much if you don't actually use them. Also, you probably want to be able to detect if the functions are actually available, instead of just dereferencing a NULL pointer if they aren't.

March 1, 2006

Re: Alexandre Julliard : configure: Use --rpath if supported when building binaries to point to

by Vitaly Lipatov

В сообщении от 1 марта 2006 17:23 Mike Hearn написал(a): > On Fri, 24 Feb 2006 21:11:39 +0300, Vitaly Lipatov wrote: > > Sorry for my English. It is useful when we run wine from the source tree. > > It's useful for people distributing Wine binaries as well. Not every > feature is there for the distros you know ... also asking developers to > disable rpath because RPM cannot cope with it is remarkably poor form IMO, > just fix RPM! Dear Mike, I asked Alexandre to add _option_ to configure for disable rpath but to remove rpath using. It is poor way to make comments about distros and RPMs as your one. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

March 1, 2006