June 2006 - Wine-Devel - list.winehq.org

Re: automatic winetest builds stopped

by Vijay Kiran Kamuju

Can someone take over this stuff? -- VJ On 6/28/06, Andrew Ziem <ahziem1(a)mailbolt.com> wrote: > Ivan Leo Puoti wrote: > > Does someone know why the tests at test.winehq.com/data aren't being > > built any more? > > Maybe a month ago there was a discussion on this list. IIRC, here's the > gist: The build system is broken. Then, someone sent in a patch, but > the maintainer is not at home. > > > > Andrew > > > >

June 29, 2006

Re: automatic winetest builds stopped

by Andrew Ziem

Ivan Leo Puoti wrote: > Does someone know why the tests at test.winehq.com/data aren't being > built any more? Maybe a month ago there was a discussion on this list. IIRC, here's the gist: The build system is broken. Then, someone sent in a patch, but the maintainer is not at home. Andrew

June 29, 2006

Re: Battlefront blending problem is fixed.

by Jason Green

On 6/28/06, Jesse Allen <the3dfxdude(a)gmail.com> wrote: > Hi Henri, > > You latest round of wined3d patches fixed the blending problem in SW > Battlefront including blocky text. Now I can properly aim at targets. > :) Yes, Henri, thanks again for this patchset. A *lot* more works now because of it. :-) Good work!

June 29, 2006

msdn calling everything .net now?

by Dan Kegel

Lately, when I search for win32 API functions like CoGetObject, the top few hits I get at microsoft.com are the .net ones. I guess it's not a problem, but it feels weird.

June 29, 2006

Re: [Tools/Wine.inf] Set Internet Explorer version

by Steven Edwards

Hi, On 6/28/06, Maarten Lankhorst <M.B.Lankhorst(a)gmail.com> wrote: > > --- tools/wine.inf.ori 2006-06-28 18:32:28.000000000 +0200 > +++ tools/wine.inf 2006-06-28 18:35:22.000000000 +0200 > @@ -2467,3 +2467,6 @@ > HKLM,%Control%\ProductOptions,"ProductType",2,"WinNT" > HKLM,%Control%\Windows,"CSDVersion",0x10003,0x400 > HKLM,%Control%\Session Manager\Environment,"OS",2,"Windows_NT" > +HKLM,"Software\Microsoft\Internet Explorer","Version",,"6.0.2900.2180" > +HKLM,"Software\Microsoft\Internet Explorer","W2kVersion",,"6.0.2900.2180" > +HKLM,"Software\Microsoft\Internet Exlporer","Build",,"62900" Does installing IE6 in win98 mode still work after this? I think its going to have problems. We really should report IE 5 so the IE 5.5 and 6 installers dont get confused. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

June 28, 2006

Battlefront blending problem is fixed.

by Jesse Allen

Hi Henri, You latest round of wined3d patches fixed the blending problem in SW Battlefront including blocky text. Now I can properly aim at targets. :) However, some screen items seem to be a little more transparent than they should be. It doesn't fix the blocky text in BF1942. BF1942 is a d3d8 game and Battlefront is a d3d9 game. Thanks, Jesse

June 28, 2006

Re: [Tools/Wine.inf] Set Internet Explorer version

by Maarten Lankhorst

Sven Paschukat schreef: > Maarten Lankhorst schrieb: >> Windows seems to set internet explorer only during a new installation >> or upgrade of internet explorer, so I put it in wine.inf, which >> seemed appropriate. >> >> Changelog: >> Set version strings for Internet Explorer so programs dependent on it >> can install. > > This breaks installation of real IE. Setting version to IE 5.5 would > give the users a chance to install at least version 6.0. > > BTW, you should fix the typo in the third line. > > Sven The program I put this in for was msn messenger 7.0, which requires ie 6.0 to work. With this msn works fine, but this brings up a bigger question. Should we require that people install Internet Explorer or should we put in patches that increase application compatibility with vanilla wine? Personally I favor to put this patch in, and let people that want to install native internet explorer to change these strings through registry modifying. I feel that we shouldn't need to rely on something that needs a windows license in order for programs to work under wine. Maarten

June 28, 2006

Re: [TOOLS] Re: Gecko installer

by Jeremy Newman

This is now live at: http://source.winehq.org/winegecko.php On Sun, 2006-06-25 at 11:40 +0200, Jonathan Ernst wrote: > Le samedi 24 juin 2006 à 20:06 +0200, Jacek Caban a écrit : > > Hi, > > > [...] > > - We need php script redirecting to SourceForge similar to one that > > forwards to Mozilla ActiveX control. > > Here you are. > >

June 28, 2006

Re: Freetype - Compile error when making a regression test

by Augusto Arcoverde da Rocha

I found a way to fix this compile error. I have deinstalled the package freetype2-dev (freetype 2.2.1) from my Debian system and I got a "build complete" with the package libttf-dev (freetype 1.5) already installed on my system. It seems to be a conflict between two installed header versions. After doing this I have got a segfault with gcc-4.1 when compiling Wine 0.9.4 with freetype 1.5, but works using CC variable when calling the configure script to change gcc version, like this: /src/wine-0.9.4$ CC=gcc-3.3 ./configure Thanks,

June 28, 2006

Wide Strings Query

by Andrew Talbot

I have written a patch to fix some of the write-strings warnings in regedit's listview.c file, in its OnGetDispInfo() fuction, but I need to know that my understanding is right, before I submit it. Am I correct in thinking that I can replace the _T() macros with TCHAR * variables, as exemplified with reg_szT, below? @@ -252,6 +252,19 @@ static void OnGetDispInfo(NMLVDISPINFO* plvdi) { static TCHAR buffer[200]; + static TCHAR reg_szT[] = {'R','E','G','_','S','Z',0}, plvdi->item.pszText = NULL; plvdi->item.cchTextMax = 0; @@ -263,43 +276,43 @@ case 1: switch (((LINE_INFO*)plvdi->item.lParam)->dwValType) { case REG_SZ: - plvdi->item.pszText = _T("REG_SZ"); + plvdi->item.pszText = reg_szT; break; Thanks, -- Andy.

June 28, 2006

Re: [AppDb] util_show_error_page

by Chris Morgan

This is a rename of one function to another, and a move from one file to another. Lets not make this into a project when it can be performed by a simple search and replace and verified with a grep of the source code after the change. I'm not trying to ignore you here btw. Give me a hand with our unit testing so we can turn hours of manual testing into seconds of automated testing. This ultimately is the only way we can really be sure any given patch doesn't break things. Chris On Wednesday 28 June 2006 3:01 pm, Tony Lambregts wrote: > Chris Morgan wrote: > > We'll want to perform this move of error_page() and the renaming of calls > > to it in a single patch. > > > > Chris > > Gah! you have not been listening. You know by now that I think that is a > bad idea. I'm preaty sure Jonathan would not be advers to sending a series > of patches (1 or x..) for this. > > Chris Please do not continue to ignore me. You obviously have a lot more > free time on your hands than I do at the moment. But that does not mean I > am not involved here. You cannot treat the AppDB like you own little > sandbox. > > > On Wednesday 28 June 2006 1:21 pm, Jonathan Ernst wrote: > >>Changelog: > >>- new util_show_error_page that will replace errorpage

June 28, 2006

Re: [Tools/Wine.inf] Set Internet Explorer version

by Sven Paschukat

Maarten Lankhorst schrieb: > Windows seems to set internet explorer only during a new installation or > upgrade of internet explorer, so I put it in wine.inf, which seemed > appropriate. > > Changelog: > Set version strings for Internet Explorer so programs dependent on it > can install. This breaks installation of real IE. Setting version to IE 5.5 would give the users a chance to install at least version 6.0. BTW, you should fix the typo in the third line. Sven

June 28, 2006

Re: [AppDb] util_show_error_page

by Tony Lambregts

Chris Morgan wrote: > We'll want to perform this move of error_page() and the renaming of calls to > it in a single patch. > > Chris > Gah! you have not been listening. You know by now that I think that is a bad idea. I'm preaty sure Jonathan would not be advers to sending a series of patches (1 or x..) for this. Chris Please do not continue to ignore me. You obviously have a lot more free time on your hands than I do at the moment. But that does not mean I am not involved here. You cannot treat the AppDB like you own little sandbox. > > > On Wednesday 28 June 2006 1:21 pm, Jonathan Ernst wrote: > >>Changelog: >>- new util_show_error_page that will replace errorpage > > > >

June 28, 2006

wine autorun utility

by Segin Noname

(FYI: I have no internet connection at the moment, so I say 'hi' to all Wine developers!) Wine is nortorious for NOT supporting Autorun. Sure, it's stupid to load the autorun program right after the disk is inserted, but who wants to have to parse the autorun.inf by hand? So I wrote this little program. You can scan a CD for viruses first, then run this to emulate the Windows autorun feature. All you tell it is the drive letter of the CD, and it parses autorun.inf, and runs the listed program. It also check to make sure the file is a valid autorun.inf. It is not complete, and it is pure standard C. No Win32-specific functions are used. It uses several functions that aren't in the msvcrt, so I have included the portable snprintf library (version 2.1) and some portablized code from glibc. The tarball includes a prebuilt binary for your convience, but i strongly suggest you recompile the program from source (emerge xmingw on gentoo, and you can use my Makefile unmodified!)

June 28, 2006

Freetype - Compile error when making a regression test

by Augusto Arcoverde da Rocha

Hi all, I'm here again with a little question about my dispersed efforts over Wine development. Now I'm trying to make some regression tests to identify when Lotus Notes started to show blank squares rather than icons for attachments. And by this way I get some errors compiling (see bellow) Wine versions 0.9.1 and 0.9.4, but with the version 0.9.9 this errors don't occurs. My guess is some version problem with freetype, but I didn't find any hints about this on the list history, though I have found some posts asking about the same problem. I tried to compile Wine on a Debian r3.1 with gcc versions 3.3 and 4.1, and with freetype 2.2.1, but didn't get any success. Any help is appreciated. Regards, --- 8< --- freetype.c:106: error: 'FT_Get_Module' undeclared here (not in a function) freetype.c:106: warning: type defaults to 'int' in declaration of 'pFT_Get_Module' freetype.c: In function 'WineEngGetFontData': freetype.c:3698: error: 'TT_Face' undeclared (first use in this function) freetype.c:3698: error: (Each undeclared identifier is reported only once freetype.c:3698: error: for each function it appears in.) freetype.c:3698: error: syntax error before 'tt_face' freetype.c:3699: error: 'SFNT_Interface' undeclared (first use in this function) freetype.c:3699: error: 'sfnt' undeclared (first use in this function) freetype.c:3703: error: syntax error before ')' token freetype.c:3703: error: 'tt_face' undeclared (first use in this function) freetype.c:3708: error: syntax error before ')' token freetype.c: In function 'is_hinting_enabled': freetype.c:3776: error: called object 'pFT_Get_Module' is not a function freetype.c:3777: warning: implicit declaration of function 'FT_DRIVER_HAS_HINTER' --- 8< ---

June 28, 2006

Re: [AppDb] util_show_error_page

by Chris Morgan

We'll want to perform this move of error_page() and the renaming of calls to it in a single patch. Chris On Wednesday 28 June 2006 1:21 pm, Jonathan Ernst wrote: > Changelog: > - new util_show_error_page that will replace errorpage

June 28, 2006

Re: msi: Download the MSI package if it is a remote URL

by Dan Kegel

On 6/28/06, James Hawkins <truiken(a)gmail.com> wrote: > > http://bugs.winehq.org/show_bug.cgi?id=5555 > > I'll check it out, but I don't think that's related to my patch. This > patch implements fetching remote packages that are given to > MsiInstallProduct. This looks like the ability office setup is > calling URLDownloadToCacheFileW itself to get the msi package before > installing. Right, it's only related in that it's downloading a .msi, and you're downloading a .msi. The code paths are different, but if we're going to fix installers that download .msi, may as well fix this one too sometime. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

June 28, 2006

Re: msi: Download the MSI package if it is a remote URL

by James Hawkins

On 6/28/06, Dan Kegel <dank(a)kegel.com> wrote: > Your patch ends in an empty sig, i.e. two dashes, > which makes patch complain "patch ends in middle of a line" > after finishing. > Hmm what version of patch are you using? All my patches have that at the end (git puts it in). > I tried your patch to see if it fixed a similar problem in Ability Office > (see http://ability.com/v4/download.php ) > but sadly that still fails with > > fixme:urlmon:URLDownloadToCacheFileW ((nil) > L"http://www.abilitydownload.com/download4/ability4_15/Ability.MSI" > 0x7fd49f40 520 0 0x7fb9fae8) > I'll check it out, but I don't think that's related to my patch. This patch implements fetching remote packages that are given to MsiInstallProduct. This looks like the ability office setup is calling URLDownloadToCacheFileW itself to get the msi package before installing. -- James Hawkins

June 28, 2006

Re: WineD3D: Add one extra line to the dib section

by Saulius Krasuckas

* On Fri, 23 Jun 2006, Stefan [iso-8859-1] D�singer wrote: > Some DirectDraw apps access the surface memory via DWORDS and do not > take the necessary care at the end of the surface. The old DDraw code > allocated 4 extra bytes for the surface and used the unofficial > DIB_CreateDibSection function to create the DIB section. The normal > CreateDIBSection function doesn't use the requested size. To increase > the surface size to catch bad accesses one extra line is added to the > dib section. It's nice to hear you are working on this... > This patch addresses the regression in Diablo 1 and some odd crashes in > the DX7 sdk demos ...but the patch doesn't fix the Diablo 1 game on my box. I even made distclean here to no avail.

June 28, 2006

re: msi: Download the MSI package if it is a remote URL

by Dan Kegel

Your patch ends in an empty sig, i.e. two dashes, which makes patch complain "patch ends in middle of a line" after finishing. I tried your patch to see if it fixed a similar problem in Ability Office (see http://ability.com/v4/download.php ) but sadly that still fails with fixme:urlmon:URLDownloadToCacheFileW ((nil) L"http://www.abilitydownload.com/download4/ability4_15/Ability.MSI" 0x7fd49f40 520 0 0x7fb9fae8) -- Wine for Windows ISVs: http://kegel.com/wine/isv

June 28, 2006

automatic winetest builds stopped

by Ivan Leo Puoti

Does someone know why the tests at test.winehq.com/data aren't being built any more? Ivan.

June 28, 2006

Re: Very large files

by Damjan Jovanovic

I tested it (code to copy a file below, file was > 4 GB) and it works. I'm using Gentoo 2006.0, Linux 2.6.15.1, ReiserFS 3 and wine 0.9.15. Can you find out whether the broken code is using KERNEL32, NTDLL, MSVCRT streams or MSVCRT POSIX-style open()/read() etc.? #include <windows.h> #include <stdio.h> int main(int argc, char **argv) { HANDLE inputFile = INVALID_HANDLE_VALUE, outputFile = INVALID_HANDLE_VALUE; const int bufferSize = 8*1024; char buffer[bufferSize]; DWORD bytesRead; BOOL ok; if (argc < 3) { fprintf(stderr, "Usage: %s source destination\n", argv[0]); return 1; } inputFile = CreateFile(argv[1], GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL); if (inputFile == INVALID_HANDLE_VALUE) { fprintf(stderr, "Error opening %s\n", argv[1]); goto done; } outputFile = CreateFile(argv[2], GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); if (outputFile == INVALID_HANDLE_VALUE) { fprintf(stderr, "Error opening %s\n", argv[2]); goto done; } ok = ReadFile(inputFile, buffer, bufferSize, &bytesRead, NULL); if (!ok) { fprintf(stderr, "Error reading file\n"); goto done; } while (bytesRead > 0) { DWORD bytesWritten = 0, bytesWrittenNow; do { ok = WriteFile(outputFile, buffer, bytesRead, &bytesWrittenNow, NULL); if (!ok) { fprintf(stderr, "Error writing file\n"); goto done; } bytesWritten += bytesWrittenNow; } while (bytesWritten < bytesRead); ok = ReadFile(inputFile, buffer, bufferSize, &bytesRead, NULL); if (!ok) { fprintf(stderr, "Error reading file\n"); goto done; } }; done: if (inputFile != INVALID_HANDLE_VALUE) CloseHandle(inputFile); if (outputFile != INVALID_HANDLE_VALUE) CloseHandle(outputFile); return 0; } --- John Willis <jswillis93105(a)verizon.net> wrote: > Damjan, > > Linux kernel: 2.4.21-20.ELsmp > Filesystem: ext3 > > Thanks for looking into this for me, > > John > > ----- Original Message ----- > From: "Damjan Jovanovic" <dj015(a)yahoo.com> > To: "John Willis" <jswillis93105(a)verizon.net>; > <wine-devel(a)winehq.org> > Sent: Sunday, June 25, 2006 11:31 PM > Subject: Re: Very large files > > > > > > > > --- John Willis <jswillis93105(a)verizon.net> wrote: > > > >> Howdy, > >> > >> I have a large VS 6.0 C++ program and I'm running > it > >> under WINE under Redhat Linux. > >> Everything works fine, but it doesn't handle file > >> sizes greater than 4gb like it can running > >> directly under Windows XP. > >> I've tweaked everything that I can find that > seems > >> to deal with file sizes. > > > > How do you access the file? With stdio streams > > (fopen(), fread(), ...), MSVCRT's open()/read(), > or > > with KERNEL32's CreateFile(), ReadFile(), ... ? > > > >> Is there a problem with WINE itself handling very > >> large file sizes? > > > > Which version of the Linux kernel and which > filesystem > > are you using? > > > > I'll run some tests at home and see whether it > works > > for me. > > > >> Thanks in advance, > >> John> > >> > > > > > > __________________________________________________ > > Do You Yahoo!? > > Tired of spam? Yahoo! Mail has the best spam > protection around > > http://mail.yahoo.com > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

June 28, 2006

Re: [AppDb] [Resend] errorpage -> show_error_page

by Jonathan Ernst

Le mardi 27 juin 2006 à 12:49 -0400, Chris Morgan a écrit : > Can we put a module prefix on this function so it is easier to locate in the > tree? I'm not sure what but it seems like we should try to prefix something > that matches the file the function is in. IMHO we should merge incl.php and util.php into functions.php for example then we'll know every functions that are not class related are in this file. If you think that's ok, please apply my patch yet and I'll make the required changes afterwards. Thanks.

June 28, 2006

Re: [AppDb] automatic variable cleanup

by Jonathan Ernst

Le mardi 27 juin 2006 à 12:07 -0400, Chris Morgan a écrit : > Wow, thats a pretty neat idea. > > A few comments. > > We should do something to the values in $_REQUEST so they can't be used after > this function is called. We can do that but only after we have made the required changes everywhere (i.e. remove makeClean AND remove every occurence or $_REQUEST[], $_POST and so on). > > We should error if there are variables that don't fit the format we expect. We > can't have anything getting past this filter by default or we'll be opening > holes in the filtering without any kind of notification. We'll also want to > know if we've missed anything during our changes. I made a show_error_page call when variables don't fit the format isn't it sufficient. > > Html keyword should probably be 'sh' instead of 'sH' so the lower case > characters prefixed on a variable are what represents the variables type. > This would be more consistent with what we have. Ok, could you please apply my patch and replace sH with sh in CODING_STANDARDS and in the new function in the diff ? My patch shouldn't cause any harm yet. > > Filtering all variables might let us support allowing magic quotes although > given the widespread rejection of the magic quotes feature it seems silly to > do so. I wouldn't be surprised if the switch was removed from php entirely > in the near future. That might be true, but for the moment being magic_quotes_gpc=on is still the default even in php5. Thanks.

June 28, 2006

Re: Debugging string comparison problem

by Dmitry Timoshkov

----- Original Message ----- From: "Juan Lang" <juan_lang(a)yahoo.com> To: <wine-devel(a)winehq.org> Sent: Wednesday, June 28, 2006 12:20 AM Subject: Debugging string comparison problem > I'm trying to figure out why CompareStringA returns CSTR_EQUAL for the strings "\1" and "\2". (See bug 5469, and the > todo_wine test case in dlls/kernel/tests/locale.c) > > CompareStringA does the usual thing, calls MultiByteToWideChar and calls CompareStringW. So CompareStringW is > comparing L"\0001" to L"\0002". > > CompareStringW calls wine_compare_string, in libs/unicode/sortkey.c That calls compare_unicode_weights. That has > this little bit of code: > ce1 = collation_table[collation_table[*str1 >> 8] + (*str1 & 0xff)]; > ce2 = collation_table[collation_table[*str2 >> 8] + (*str2 & 0xff)]; > > With the strings L"\0001" and L"\0002", *str1 is 0x0001, and *str2 is 0x0002. So *str1 >> 8 is 0, and *str2 >> 8 is > 0. *str1 & 0xff is 0x01, *str2 & 0xff is 0x02. So, ce1 == collation_table[1], which is 0x00000300 (in collation.c), > and ce2 == collation_table[2], which is 0x00000400. > > That gets us here: > if (ce1 != (unsigned int)-1 && ce2 != (unsigned int)-1) > ret = (ce1 >> 16) - (ce2 >> 16); > else > ret = *str1 - *str2; > > Well, 0x00000300 >> 16 is 0, and so is 0x00000400, so ce1 - ce2 is 0, so these strings are considered equal. But as > the test case shows, they're not supposed to be. > > I'm just not sure what to do about it. Changing collation.c isn't really > an option, since it's generated. So there's some flaw in the logic here, > but I don't understand the meaning of collation_table. Could someone explain > to me what it is? That's really a problem with collation.c, or rather with the it's been generated from www.unicode.org/reports/tr10/allkeys.txt. There are a lot of differences between that file and microsoft's implementation. We have some hacks in Crossover to compensate it, and to do so what I did is just fixed up the allkeys.txt from unicode.org and regenerated collation.c. -- Dmitry.

June 28, 2006

Re: [Dlls/Cryptnet] Implement a stub cryptnet dll (v2)

by Marcus Meissner

On Wed, Jun 28, 2006 at 09:11:21AM +0200, Maarten Lankhorst wrote: > Same as v1, but now even better! :D But without cryptnet_main.c ... Ciao, Marcus

June 28, 2006

Re: [Dlls/Cryptnet] Implement a stub cryptnet

by Maarten Lankhorst

2006/6/28, Dmitry Timoshkov <dmitry(a)baikal.ru>: > "Maarten Lankhorst" <M.B.Lankhorst(a)gmail.com> wrote: > > > +static HINSTANCE ghInst = NULL; > > + > > +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > > +{ > > + TRACE("(0x%p, %ld, %p)\n", hinstDLL, fdwReason, lpvReserved); > > + > > + switch (fdwReason) { > > + case DLL_WINE_PREATTACH: > > + return FALSE; /* prefer native version */ > > + case DLL_PROCESS_ATTACH: > > + ghInst = NULL; > > + break; > > You meant to make it 'ghInst = hinstDLL;', right? > I'd suggest to get rid of ghInst altogether until there is a real need for it. > > -- > Dmitry. > Thanks, I'll submit the improved version, never knew what DisableThreadLibraryCalls were for, so I looked it up, looks like it's useful. Maarten

June 28, 2006

wine and serial port - again

by Pavel Troller

Hi! From time to time, complaints can be heard about functionality of the serial port implementation in wine. Just now I have one of examples of the serial communication problem. There is a very simple program, called ft or softjump, intended to dump or modify some particular addresses of an EEPROM of an amateur radio. It uses a serial port in non-canonical mode, writing always 5 binary chars into it and reading (also binary) reply. I've run this program under wine but there were problems - the program never dumped any data. The source is included in the program archive; it was about 30 minutes of work to convert it for Linux. After successfull compilation, I've run the resulting Linux program (pure Linux, not winelib) and it worked as expected. For the testing purposes, I've then compiled the original windows version using winegcc. I was able to run the program, but the results were identical to those with original windows binary (no data). The windows binary output shows this: patrol(a)arcus:~/ft817$ wine ft.exe ft.exe by Peter May, VK2JCG, vk2jcg(a)yahoo.com.au This program uses undocumented CAT commands to read or update the EEPROM in the Yaesu FT817 and FT897 Radios. The soft jumper settings are stored in location 4 and 5 of the EEPROM. Power the radio off and on to activate the new settings. If you do a reset of the radio, you will have to run this program again to rewrite the values The program assumes that the radio is connected to COM1: and the CAT rate is set to 38400 baud *** USE AT YOUR OWN RISK *** Serial port COM1: successfully reconfigured. Read current data from EEPROM gives : patrol(a)arcus:~/ft817$ Its Linux version works well: patrol(a)arcus:~/ft817/Source$ ft ft by Peter May, VK2JCG, vk2jcg(a)yahoo.com.au This program uses undocumented CAT commands to read or update the EEPROM in the Yaesu FT817 and FT897 Radios. The soft jumper settings are stored in location 4 and 5 of the EEPROM. Power the radio off and on to activate the new settings. If you do a reset of the radio, you will have to run this program again to rewrite the values. *** USE AT YOUR OWN RISK *** Linux version by Pavel Troller - OK1XPT, <patrol(a)sinus.cz> Serial port /dev/tts/0 successfully reconfigured. Read current data from EEPROM gives : DD BF patrol(a)arcus:~/ft817/Source$ Do you see ? The windows version doesn't output the actual EEPROM data. +file,+comm trace from wine looks like this: trace:file:CreateFileW L"COM1:" GENERIC_READ GENERIC_WRITE creation 3 attributes 0x0 trace:file:RtlDosPathNameToNtPathName_U (L"COM1:",0x7fb3fdd0,(nil),(nil)) trace:file:RtlGetFullPathName_U (L"COM1:" 520 0x7fb3fb44 (nil)) trace:file:get_dos_device L"COM1" -> "/dev/ttyS0" trace:file:CreateFileW returning 0x2c trace:comm:GetCommState handle 0x2c, ptr 0x7fb3fe70 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_BAUD_RATE (nil) 0 0x7fb3fe18 4 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_LINE_CONTROL (nil) 0 0x7fb3fe1d 3 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_HANDFLOW (nil) 0 0x7fb3fe00 16 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_GET_CHARS (nil) 0 0x7fb3fe12 6 0x7fb3fdb0 trace:comm:GetCommState OK trace:comm:dump_dcb bytesize=8 baudrate=38400 fParity=0 Parity=0 stopbits=2 trace:comm:dump_dcb ~IXON ~IXOFF trace:comm:dump_dcb fOutxCtsFlow=0 fRtsControl=0 trace:comm:dump_dcb fOutxDsrFlow=0 fDtrControl=1 trace:comm:dump_dcb ~CRTSCTS trace:comm:dump_dcb bytesize=8 baudrate=38400 fParity=0 Parity=0 stopbits=2 trace:comm:dump_dcb ~IXON ~IXOFF trace:comm:dump_dcb fOutxCtsFlow=0 fRtsControl=0 trace:comm:dump_dcb fOutxDsrFlow=0 fDtrControl=0 trace:comm:dump_dcb ~CRTSCTS trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_BAUD_RATE 0x7fb3fe18 4 (nil) 0 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_LINE_CONTROL 0x7fb3fe1d 3 (nil) 0 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_HANDFLOW 0x7fb3fe00 16 (nil) 0 0x7fb3fdb0 trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_CHARS 0x7fb3fe12 6 (nil) 0 0x7fb3fdb0 trace:comm:SetCommTimeouts (0x2c, 0x7fb3fe5c) trace:comm:COMM_DeviceIoControl 0x2c IOCTL_SERIAL_SET_TIMEOUTS 0x7fb3fe0c 20 (nil) 0 0x7fb3fdb0 trace:file:WriteFile 0x8 0x7fb3f9cc 48 0x7fb3fdd4 (nil) Serial port COM1: successfully reconfigured. trace:file:WriteFile 0x2c 0x7fb3fe54 5 0x7fb3fe4c (nil) trace:file:ReadFile 0x2c 0x7fb3fe8c 4 0x7fb3fe4c (nil) trace:file:WriteFile 0x8 0x7fb3f9b4 38 0x7fb3fdbc (nil) Read current data from EEPROM gives : trace:file:WriteFile 0x8 0x7fb3f9b8 2 0x7fb3fdc0 (nil) You can see the port configuration phase, as well 5 bytes being written and a read being attempted. However, resulting "count" variable (see source) is probably 0, because there is no output of values read. I don't know, whether it is due to wrong command being written to the radio, or failure to read its response. Original package can be downloaded freely for example here: http://www.817-onair.de/download.php?id=6&sid=c66545090cd6b5cbc2e1c06321ff9… My Linux variant is attached to this mail. Sorry for the lengthy mail, but I hope that it can really help to improve the serial communication support in wine. With regards, Pavel Troller

June 28, 2006

Re: [Dlls/Cryptnet] Implement a stub cryptnet

by Dmitry Timoshkov

>> + case DLL_PROCESS_ATTACH: >> + ghInst = NULL; >> + break; > > You meant to make it 'ghInst = hinstDLL;', right? > I'd suggest to get rid of ghInst altogether until there is a real need for it. And please add a DisableThreadLibraryCalls( hinstDLL ); call. -- Dmitry.

June 28, 2006

Re: [Dlls/Cryptnet] Implement a stub cryptnet

by Dmitry Timoshkov

"Maarten Lankhorst" <M.B.Lankhorst(a)gmail.com> wrote: > +static HINSTANCE ghInst = NULL; > + > +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + TRACE("(0x%p, %ld, %p)\n", hinstDLL, fdwReason, lpvReserved); > + > + switch (fdwReason) { > + case DLL_WINE_PREATTACH: > + return FALSE; /* prefer native version */ > + case DLL_PROCESS_ATTACH: > + ghInst = NULL; > + break; You meant to make it 'ghInst = hinstDLL;', right? I'd suggest to get rid of ghInst altogether until there is a real need for it. -- Dmitry.

June 28, 2006

Re: mswsock.dll: TranmitFile - new way [1/2]

by Juan Lang

Hi Lukazs, I'm afraid this still isn't ready for inclusion: diff -u -r1.3 Makefile.in --- dlls/mswsock/Makefile.in 9 May 2005 14:42:33 -0000 1.3 +++ dlls/mswsock/Makefile.in 27 Jun 2006 23:13:09 -0000 @@ -4,13 +4,16 @@ VPATH = @srcdir@ MODULE = mswsock.dll IMPORTLIB = libmswsock.$(IMPLIBEXT) -IMPORTS = ws2_32 iphlpapi kernel32 +IMPORTS = ws2_32 kernel32 + This change looks fine, but it could, and therefore should, be sent as a separate patch. /*********************************************************************** - * TransmitFile (MSWSOCK.@) + * WSAAddressToStringW (MSWSOCK.@) * - * This function is used to transmit a file over socket. + * Transmit file via socket. Header / Footer data is also supported. * - * TODO - * This function is currently implemented as a stub. + * PARAMS + * hSocket [I] Socket for sending the data. Not handle. + * hFile [I] file to transmit. + * nNumberOfBytesToWrite [I] How much data to write. Optional + * nNumberOfBytesPerSend [I] Maximum length of single packet (usefull for communication protocols) + * lpOverlapped [I/O] used for overlapped operations + * lpTransmitBuffers [I] data to send as header/tail usefull for communication protocols) Same here. This looks good, but perhaps send this as a documentation patch. Lining up the text better would be nice too. + if(!nNumberOfBytesToWrite) + nNumberOfBytesToWrite = -1; /* should be OK */ Why wouldn't it be? The comment doesn't tell me anything, so make it say what it means, or omit it. + if(!dwRetVal) + { + WSASetLastError(WSAEACCES); + goto e_exit; Are you sure WSAEACCES should be set on any ReadFile error? I suspect ReadFile already sets the last error, so a goto e_exit should be sufficient. + } + if(dwFlags & TF_DISCONNECT) + +ok_exit: + if(lpOverlapped) + lpOverlapped->Internal = dwTotalBytesSent; /* FIXME */ The first if is missing a then block. Fix what? The comment needs to be clear about what needs to be fixed. In the tests patch, +/** #define RUN_BIG_FILE_TEST /**/ Eck. That's ugly. At least my editor complains about the nested comment. Just omit dead code from your patch. +#ifndef SAFE_RELEASE Why do you need the ifndef protection? It's not going to be defined anywhere else, so just define it. +#define SAFE_RELEASE(x) {if(x) {free(x); x=NULL;}} If you must use multi-statement macros, please use something like: do { ... } while 0 instead. Note the lack of closing semicolon. See e.g. http://c-faq.com/cpp/multistmt.html +#define SAFE_HRELEASE(x) {if(x!=INVALID_HANDLE_VALUE) {CloseHandle(x); x=INVALID_HANDLE_VALUE;}} What does that help? CloseHandle already handles invalid handles. Please just use that instead. + HANDLE hFOutput = INVALID_HANDLE_VALUE; + int i = 0; + int size = 0; + DWORD written = 0; + DWORD filesize = 0; + BOOL nBoolRetval = FALSE; What's the reason for aligning the variable declarations and initializations just so? It looks like you just used your editor to replace tabs with spaces, without paying attention to indentation. We accept all sorts of styles in wine code--but please pick one style. --Juan

June 28, 2006

Re: [PATCH 2/3] server: add calls to get/set menu info

by Thomas Kho

On 6/19/06, Robert Shearman <rob(a)codeweavers.com> wrote: > This needs to be cleaned up a lot more before it will be accepted. > > For a start, the members of this structure need to be cleaned up. Some > of the members of the POPUPMENU structure are for keeping track of the > menu while it's in use (bTimeToHide, bScrolling, nScrollPos, > FocusedItem), so these could be kept on the client side. Also, > everything needs to be converted to wineserver types. > > It should become clear what needs to change as menu item handling is > moved into the server, so I would urge you to work on that and then > rework these patches. Hi Rob, Thanks for your input. I've reworked the first set of patches with your suggestions and moved menu item data into the server. The patch series (11 of them) are at <http://silenceisdefeat.org/~tkho/seas/wine/patches/menu-0627-8/>. I tried to make as little changes as possible, and most of the code is still client-side. Apps seem just as responsive, and all conformance tests still pass. Should I try to integrate more functionality into the server, or get these 11 patches committed? Tommy

June 28, 2006

Re: Wine developers?

by Troy Rollo

On Wednesday 28 June 2006 02:11, Mike Hearn wrote: > On Mon, 26 Jun 2006 08:27:10 +1000, Troy Rollo wrote: > > On Friday 23 June 2006 22:50, Mike Hearn wrote: > >> careful, none of us are lawyers here. > > > > That's not entirely true. > > We have IP lawyers on wine-devel? Can you say who? I'm a non-practising lawyer, and my training does include IP law. There may be one or two others lurking - as I recall there were some others on the wine-legal list before it was shut down. -- Troy Rollo - wine(a)troy.rollo.name

June 27, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by Mike Hearn

On 6/27/06, Steven Edwards <winehacker(a)gmail.com> wrote: > I don't think they are wrong about feeling that the site just seems to > totally ignore OS X. I guess the FreeBSD and Solaris guys feel the > same way reading over recent discussions. Alexandre does not treat > patches from anyone as a second class citizen but the site does seem > to be very Linux centric rather than platform agnostic. Like read the > Myths page. Its all about Linux. I am happy to rewrite some bits of > the site to make it broader in scope. That's true, but then what the myths page says could really apply to any "alt" operating system. But writing "Linux/FreeBSD/OpenSolaris/MacOS/BeOS" every time is unwieldy, especially as most of our users are on Linux anyway. I guess you could rephrase it all in terms of non-Windows systems.

June 27, 2006

Re: [AppDB] Make screen shots safe from SQL injection

by Tony Lambregts

Chris Morgan wrote: >>>As we've discussed before I'd rather we did a single full pass of manual >>>testing than several full passes. It saves us time in that we don't have >>>to test the same things repeatedly like we would have to do when making >>>changes to things like classes that are used all over the code. >> >>Your logic is flawed and only applies if the patch has no bugs. By breaking >>up the patch into smaller pieces you save time in testing when there are >>problems. >> > > > When were you going to report the issue with query_parameters() that I found > the other day and sent in a unit test and patch for? Huh? Perhaps I would not have found it. It is Good you caught a bug in your own code. > Why do projects like > Wine have automated tests instead of manual ones? I think we want to mirror > successful projects like this by automating our testing. Manual testing may > catch some bugs but it is always going to be more time consuming and less > reproducable. > You still seem to be under the impression I am against automated testing. It is not a case of Manual vs Automated testing. Yes Wine has automated testing but it does not prevent regressions occurring. Wine has literaly hundreds of manual testers that use bugzilla and the AppDB to report how well wine is doing. With wine if a regression occurs at least the user has the option of using a previous version. Users of the AppDB do not have that option. There are lots of times that people have asked someone to break up a patch. In fact, it is in our documentation that it is considerd best practice to keep patches small. http://www.winehq.org/site?page=sending_patches. http://www.winehq.org/site/docs/winedev-guide/style-notes > As I've said before, manual testing is ok but isn't likely to be as good as > automated testing. That function is used in all sql calls. Modifying it > should mean that we have to check EVERY sql call in the appdb. > To me if you are making a change to a function that is used "everywhere" then that goes into a patch by itself because we should test everywhere it is called. Automated testing is only as good as the things it tests. If the test is flawed then it won't catch a bug and can give a false sense of security. Manual testing is only as good a the tests that the person does. Yes manual testing can be consuming but it is flexable. Neither are ideal. I see that you have committed that patch while we were still discusing it. That tells me that my opinion just does not matter to you and you do not respect me. I really hope that you tested it through and through. -- Tony Lambregts

June 27, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by Steven Edwards

Hi Mike, On 6/27/06, Mike Hearn <mike(a)plan99.net> wrote: > I think your email was OK, but wine-devel gets a constant stream of Mac > users/developers telling us how many Mac users want Wine, how they would > be a big benefit to the project, how Apple-land is a land of milk and > honey etc ... whereas not many people here are actually Mac users. Telling > people that's it's super important won't actually speed anything up. I don't think they are wrong about feeling that the site just seems to totally ignore OS X. I guess the FreeBSD and Solaris guys feel the same way reading over recent discussions. Alexandre does not treat patches from anyone as a second class citizen but the site does seem to be very Linux centric rather than platform agnostic. Like read the Myths page. Its all about Linux. I am happy to rewrite some bits of the site to make it broader in scope. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

June 27, 2006

Re: msvcrt/tests: Don't leave files on the disk

by Ivan Leo Puoti

Andreas Mohr wrote: > Hi, > > On Tue, Jun 27, 2006 at 04:05:14PM +0100, ivanleo(a)gmail.com wrote: > >>ChangeLog: Don't leave files on the user's hdd > > > Don't you think that a rm -rf / would be more efficient? ;) Unfortunately the tests are for windows, but I guess format c: would do too :-D Ivan.

June 27, 2006

Re: winbase.h: Add a few casts

by Andrew Talbot

Alexandre Julliard wrote: > Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > >> Changelog: >> winelib: Add a few casts. > > Why do you need them? > Sorry. I confess that I was looking around with Splint, saw that the difference between the returned types of some string functions differed from their declared type, and thought - as these are library functions that are used frequently - that it would be good to match them up with casts. -- Andy.

June 27, 2006

Re: [AppDb] [Resend] errorpage -> show_error_page

by Chris Morgan

Can we put a module prefix on this function so it is easier to locate in the tree? I'm not sure what but it seems like we should try to prefix something that matches the file the function is in. Chris On Monday 26 June 2006 6:18 pm, Jonathan Ernst wrote: > Changelog: > - rename errorpage function to better follow our coding standards > > Files changed: > - account.php > - addcomment.php > - appbrowse.php > - appimage.php > - appsubmit.php > - appview.php > - commentview.php > - deletecomment.php > - distributionView.php > - maintainerdelete.php > - maintainersubmit.php > - preferences.php > - testResults.php > - vendorview.php > - viewbugs.php > - admin/addAppNote.php > - admin/addCategory.php > - admin/adminAppDataQueue.php > - admin/adminAppQueue.php > - admin/adminBugs.php > - admin/adminMaintainerQueue.php > - admin/adminMaintainers.php > - admin/adminScreenshots.php > - admin/adminTestResults.php > - admin/adminUsers.php > - admin/deleteAny.php > - admin/editAppFamily.php > - admin/editAppNote.php > - admin/editAppVersion.php > - admin/editBundle.php > - admin/editDistribution.php > - admin/editVendor.php > - admin/moveAppVersion.php > - include/application.php > - include/incl.php > - include/version.php > - include/vote.php

June 27, 2006

Re: [AppDB] Make screen shots safe from SQL injection

by Chris Morgan

> > As we've discussed before I'd rather we did a single full pass of manual > > testing than several full passes. It saves us time in that we don't have > > to test the same things repeatedly like we would have to do when making > > changes to things like classes that are used all over the code. > > Your logic is flawed and only applies if the patch has no bugs. By breaking > up the patch into smaller pieces you save time in testing when there are > problems. > When were you going to report the issue with query_parameters() that I found the other day and sent in a unit test and patch for? Why do projects like Wine have automated tests instead of manual ones? I think we want to mirror successful projects like this by automating our testing. Manual testing may catch some bugs but it is always going to be more time consuming and less reproducable. As I've said before, manual testing is ok but isn't likely to be as good as automated testing. That function is used in all sql calls. Modifying it should mean that we have to check EVERY sql call in the appdb. > > In any case I'm implementing unit tests for nearly every bug I find. I > > haven't thought of a good way to unit test page actions yet though. > > I have no answer for that. > The trick is getting the parameters into $_REQUEST variables. I think we'll have to build up a <input> form in the test and then submit it as if the user clicked on 'submit'. That might require duplication of code how we currently have some of those pages designed but we may be able to refactor them into classes so we can reduce the duplication. Chris

June 27, 2006

Re: Wine developers?

by Mike Hearn

On Mon, 26 Jun 2006 08:27:10 +1000, Troy Rollo wrote: > On Friday 23 June 2006 22:50, Mike Hearn wrote: >> A very specific legal interpretation that would require the >> company behind Thinstall to want to hurt the Wine project .... be careful, >> none of us are lawyers here. > > That's not entirely true. We have IP lawyers on wine-devel? Can you say who? thanks -mike

June 27, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by Mike Hearn

On Mon, 26 Jun 2006 04:08:30 -0400, William Knop wrote: > Oh... Sorry about that. I suppose I did come off a bit critical. I think your email was OK, but wine-devel gets a constant stream of Mac users/developers telling us how many Mac users want Wine, how they would be a big benefit to the project, how Apple-land is a land of milk and honey etc ... whereas not many people here are actually Mac users. Telling people that's it's super important won't actually speed anything up. Not aimed specifically at you, this is just a general trend that's been on the increase lately. You know what they say about wishes and horses ... thanks -mike

June 27, 2006

Re: [AppDb] automatic variable cleanup

by Chris Morgan

Wow, thats a pretty neat idea. A few comments. We should do something to the values in $_REQUEST so they can't be used after this function is called. We should error if there are variables that don't fit the format we expect. We can't have anything getting past this filter by default or we'll be opening holes in the filtering without any kind of notification. We'll also want to know if we've missed anything during our changes. Html keyword should probably be 'sh' instead of 'sH' so the lower case characters prefixed on a variable are what represents the variables type. This would be more consistent with what we have. Filtering all variables might let us support allowing magic quotes although given the widespread rejection of the magic quotes feature it seems silly to do so. I wouldn't be surprised if the switch was removed from php entirely in the near future. Chris On Tuesday 27 June 2006 4:56 am, Jonathan Ernst wrote: > Please apply the (harmless) errorpage patch first. > > As my prevous approach was refused, I decided to improve the current > makeClean approach. > > This patch automatically fills the $aClean array when we'll start using > variable names like iVersionId, etc. This let's us check/clean up > everything in a single place and do the error handling there. > > You'll notice that I cleanly handle the magic_quote_gpc case as well. I > know that people with magic_quote_gpc will get an error message thanks > to Chris patch, but I still hope we can revert his patch in the future > because I don't like forcing people to change their php config. > > Changelog: > - automatic variable cleanup function > > Files changed: > - CODING_STANDARD > - include/incl.php > - include/util.php

June 27, 2006

Debugging string comparison problem

by Juan Lang

I'm trying to figure out why CompareStringA returns CSTR_EQUAL for the strings "\1" and "\2". (See bug 5469, and the todo_wine test case in dlls/kernel/tests/locale.c) CompareStringA does the usual thing, calls MultiByteToWideChar and calls CompareStringW. So CompareStringW is comparing L"\0001" to L"\0002". CompareStringW calls wine_compare_string, in libs/unicode/sortkey.c That calls compare_unicode_weights. That has this little bit of code: ce1 = collation_table[collation_table[*str1 >> 8] + (*str1 & 0xff)]; ce2 = collation_table[collation_table[*str2 >> 8] + (*str2 & 0xff)]; With the strings L"\0001" and L"\0002", *str1 is 0x0001, and *str2 is 0x0002. So *str1 >> 8 is 0, and *str2 >> 8 is 0. *str1 & 0xff is 0x01, *str2 & 0xff is 0x02. So, ce1 == collation_table[1], which is 0x00000300 (in collation.c), and ce2 == collation_table[2], which is 0x00000400. That gets us here: if (ce1 != (unsigned int)-1 && ce2 != (unsigned int)-1) ret = (ce1 >> 16) - (ce2 >> 16); else ret = *str1 - *str2; Well, 0x00000300 >> 16 is 0, and so is 0x00000400, so ce1 - ce2 is 0, so these strings are considered equal. But as the test case shows, they're not supposed to be. I'm just not sure what to do about it. Changing collation.c isn't really an option, since it's generated. So there's some flaw in the logic here, but I don't understand the meaning of collation_table. Could someone explain to me what it is? Thanks, --Juan

June 27, 2006

Re: msvcrt/tests: Don't leave files on the disk

by Andreas Mohr

Hi, On Tue, Jun 27, 2006 at 04:05:14PM +0100, ivanleo(a)gmail.com wrote: > ChangeLog: Don't leave files on the user's hdd Don't you think that a rm -rf / would be more efficient? ;) (one code line only) Andreas P.S.: Kids, don't try this at home!

June 27, 2006

Re: [AppDB] Make screen shots safe from SQL injection

by Tony Lambregts

Chris Morgan wrote: > On Monday 26 June 2006 11:38 pm, Tony Lambregts wrote: >> Chris Morgan wrote: >>> Yes, having quotes around limit values breaks sql queries. I'll >>> incorporate this into the injection change patch. >>> >>> I'm curious as to why the rest of the patch is the same though. It >>> will conflict when the other sql patch is applied. >> What other sql patch? How will it conflict? I have broken your large patch >> up in order to test it, since you refused to do it yourself. This is the >> portion of the patch that I tested. I had to modify it a bit like I said >> but the rest is yours and you get the credit. >> >> What do you plan on doing with this patch? Are you planning to wait until I >> have tested all various parts of your big patch and then apply it all at >> once? >> >> -- >> >> Tony Lambregts > > As we've discussed before I'd rather we did a single full pass of manual > testing than several full passes. It saves us time in that we don't have to > test the same things repeatedly like we would have to do when making changes > to things like classes that are used all over the code. Your logic is flawed and only applies if the patch has no bugs. By breaking up the patch into smaller pieces you save time in testing when there are problems. > > In any case I'm implementing unit tests for nearly every bug I find. I > haven't thought of a good way to unit test page actions yet though. > I have no answer for that. -- Tony Lambregts

June 27, 2006

Re: keyboard keypress codepath

by Dmitry Timoshkov

"Saulius Menkevicius" <saulius.menkevicius(a)gmail.com> wrote: > Now the problem is that I use Lithuanian keyboard layout on my gnome > desktop and it doesn't properly "translate" some of the non-latin > letters (like 'ąčęėįųū'). When I press one of those MS Word shows 'a/A' > instead of 'ą/Ą', 'c/C' instead of 'č/Č', etc. Letter 'š/Š', though is > mapped correctly. Same things happen for capital letters too. [This mail > is supposed to be unicode one, sorry for those incapable of seeing those > letters] Make sure that your locale and X11 keyboard layout are set correctly. Usually +x11drv,+key,+keyboard,+event log helps to debug the problems, feel free to send the log to me, I'll help to figure out what is going on. -- Dmitry.

June 27, 2006

Re: wined3d: Regression in DX8 SDK samples with VBO patch

by Stefan Dösinger

Am Dienstag 27 Juni 2006 04:08 schrieb Jason Green: > http://source.winehq.org/git/?p=wine.git;a=commit;h=2122026713baa3180931816 >07db79d7577f728e9 > > This patch breaks most of the DirectX 8 SDK Direct3D samples > (Billboard, ClipMirror, Cull, etc.). It seems like most of the > samples that use Shaders work fine, but those that don't are broken > (misplaced vertices, etc.). Apparently(and according to the msdn) vertex buffers can be locked multiple times( lock->lock->...->lock ->unlock->...->unlock->unlock). The some d3d helper lib does that and it fools the vbo loading code. I'll send a fix+test for that.

June 27, 2006

Re: WINED3D: Fix compilation (VBO constants)

by H. Verbeet

On 27/06/06, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Am Dienstag 27 Juni 2006 00:32 schrieb H. Verbeet: > > This makes wined3d use the VBO constants as defined in > > include/wine/wined3d_gl.h > Just asking, how do you check for those constant? As the code I sent compiled > fine here(with mesa) the way I used is to look at the diff if some changes > are missing the _ARB or GL_EXTCALL. Apparently that is prone to errors and I > miss some all the time. A lot of those you can spot just by looking at the diff, yes. However, I've also got a Debian stable machine on which I try compilation from time to time.

June 27, 2006

Re: wrc: allow quotes around resource ID

by Alexandre Julliard

Juan Lang <juan_lang(a)yahoo.com> writes: > Fixes bug 786. > > ChangeLog: allow quotes around resource ID I don't think that's the right fix, Windows doesn't handle this as a string, it simply passes the name through including quotes and all. -- Alexandre Julliard julliard(a)winehq.org

June 27, 2006

Re: riched20: hWnd validity test in window procedure

by Alexandre Julliard

Krzysztof Foltman <wdev(a)foltman.com> writes: > ChangeLog: > * Added hWnd validity check to work around buggy apps (bug# 4452) > > This patch is based on Phil Krylov's one, with two differences: it > checks the handle even before trying to call GetWindowLong, and it > checks for invalid window handle, not just NULL. The right way is to check for GetWindowLong failure, there's no reason to use IsWindow. -- Alexandre Julliard julliard(a)winehq.org

June 27, 2006

Re: winbase.h: Add a few casts

by Alexandre Julliard

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > Changelog: > winelib: Add a few casts. Why do you need them? -- Alexandre Julliard julliard(a)winehq.org

June 27, 2006

Re: WINED3D: Fix compilation (VBO constants)

by James Hawkins

On 6/27/06, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Am Dienstag 27 Juni 2006 00:32 schrieb H. Verbeet: > > This makes wined3d use the VBO constants as defined in > > include/wine/wined3d_gl.h > > Just asking, how do you check for those constant? As the code I sent compiled > fine here(with mesa) the way I used is to look at the diff if some changes > are missing the _ARB or GL_EXTCALL. Apparently that is prone to errors and I > miss some all the time. > He reads my complaints :) http://winehq.org/pipermail/wine-devel/2006-June/049004.html -- James Hawkins

June 27, 2006

Re: wined3d: Regression in DX8 SDK samples with VBO patch

by Stefan Dösinger

Am Dienstag 27 Juni 2006 04:08 schrieb Jason Green: > http://source.winehq.org/git/?p=wine.git;a=commit;h=2122026713baa3180931816 >07db79d7577f728e9 > > This patch breaks most of the DirectX 8 SDK Direct3D samples > (Billboard, ClipMirror, Cull, etc.). It seems like most of the > samples that use Shaders work fine, but those that don't are broken > (misplaced vertices, etc.). I have done a quick test with the Billboard demo, and I can confirm that it is broken :-( Apparently the terrain is broken, and the vertex buffer containing it is created by native d3dxof.dll. Looks like this dll is doing something I didn't expect :-\

June 27, 2006

Re: [AppDb] html cleanup

by Jonathan Ernst

Le mardi 27 juin 2006 à 01:51 -0400, Chris Morgan a écrit : > What is the justification for making this change? I can't find anything on > w3.org that suggests that these values should be lowercase and the > documentation seems to suggest that for the 'type' attribute the values > should all be upper case, http://www.w3.org/TR/html4/sgml/dtd.html#InputType$ http://www.w3.org/TR/html4/interact/forms.html#adef-type-INPUT Type attribute is lower case even in html4. http://www.w3.org/TR/xhtml1/#h-4.2 Furthermore in xhtml element and attribute names must be in lower case. And we try to be forward compatible with xhtml when it doesn't break html4 specification.

June 27, 2006

Re: WINED3D: Fix compilation (VBO constants)

by Stefan Dösinger

Am Dienstag 27 Juni 2006 00:32 schrieb H. Verbeet: > This makes wined3d use the VBO constants as defined in > include/wine/wined3d_gl.h Just asking, how do you check for those constant? As the code I sent compiled fine here(with mesa) the way I used is to look at the diff if some changes are missing the _ARB or GL_EXTCALL. Apparently that is prone to errors and I miss some all the time.

June 27, 2006

Re: Patch: winex11drv create_cursor Loading 32bit rgba cursor image

by Louis Lenders

Mike Hearn <mike <at> plan99.net> writes: > > Heya Pauli, > > A review is enclosed. To submit a patch please send it to > the wine-patches list, where it'll enter Alexandres queue for review. > > Firstly I'm kind of surprised this doesn't require the XCursor extension. > Handling the case of a solid alpha channel by converting it to a mask is > fine but you should note with a FIXME cases where it doesn't work properly. > Any updates on this one? I found quite a bit of applications that suffer from this bug, so i'd be really happy if some kind of fix went into cvs. Thanks

June 27, 2006

Re: [AppDb] html cleanup

by Chris Morgan

What is the justification for making this change? I can't find anything on w3.org that suggests that these values should be lowercase and the documentation seems to suggest that for the 'type' attribute the values should all be upper case, http://www.w3.org/TR/html4/sgml/dtd.html#InputType Chris On Monday 26 June 2006 6:18 pm, Jonathan Ernst wrote: > Changelog: > - html attributes and values are lowercase

June 27, 2006

Re: [AppDB] Make screen shots safe from SQL injection

by Chris Morgan

On Monday 26 June 2006 11:38 pm, Tony Lambregts wrote: > Chris Morgan wrote: > > Yes, having quotes around limit values breaks sql queries. I'll > > incorporate this into the injection change patch. > > > > I'm curious as to why the rest of the patch is the same though. It > > will conflict when the other sql patch is applied. > > What other sql patch? How will it conflict? I have broken your large patch > up in order to test it, since you refused to do it yourself. This is the > portion of the patch that I tested. I had to modify it a bit like I said > but the rest is yours and you get the credit. > > What do you plan on doing with this patch? Are you planning to wait until I > have tested all various parts of your big patch and then apply it all at > once? > > -- > > Tony Lambregts As we've discussed before I'd rather we did a single full pass of manual testing than several full passes. It saves us time in that we don't have to test the same things repeatedly like we would have to do when making changes to things like classes that are used all over the code. In any case I'm implementing unit tests for nearly every bug I find. I haven't thought of a good way to unit test page actions yet though. Chris

June 27, 2006

Re: [AppDB] Make screen shots safe from SQL injection

by Tony Lambregts

Chris Morgan wrote: > Yes, having quotes around limit values breaks sql queries. I'll > incorporate this into the injection change patch. > > I'm curious as to why the rest of the patch is the same though. It > will conflict when the other sql patch is applied. > What other sql patch? How will it conflict? I have broken your large patch up in order to test it, since you refused to do it yourself. This is the portion of the patch that I tested. I had to modify it a bit like I said but the rest is yours and you get the credit. What do you plan on doing with this patch? Are you planning to wait until I have tested all various parts of your big patch and then apply it all at once? -- Tony Lambregts

June 27, 2006

wineconsole not working (but wine worked for console app)

by Dee Ayy

Dear Wine Developers, I tried to post this anonymously, but it wanted me to create an account: In reply, some what confirmation of http://bugs.winehq.org/show_bug.cgi?id=5082 My comments: While reading the man page for wine, searching for how to run a Win32 exe which needs a native dll, I noticed the instruction to run wineconsole for my console executable. So I ran "wineconsole my.exe" in wine-0.9.16 on Mac OSX 10.4.6 on Intel Core Duo. I received so many errors that they scrolled across the shell too fast ad infinitum. I Quit the X11 xterm and figured I'd try "wine my.exe" even though the man pages said to use wineconsole. Regular "wine my.exe" actually worked. Ahh, I just did a screen capture: wineconsole scrolls by the infinite message, "fixme:curses:WCCURSES_GetEvents Ooch. somebody beat us". Regards.

June 27, 2006

Re: Opengl states in wined3d

by Jason Green

On 6/25/06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > The way opengl states are managed in wined3d at the moment is a bit messy and inefficient. Agreed. :-) > * Brute force applying opengl states is likely to re-set the old state > unnecessarily. Opengl does not assure that redundant calls are cheap. > * if an application sets and resets a state for some reason between 2 drawprim > calls that involves 2 not really necessary opengl state switches I have this problem with Fog settings in the case of shaders. If I set & restore the fog states on each drawPrimitive, it will drop the fps from 1250 to about 1000 in the Dolphin demo compared to just setting it once and leaving it. I've been holding off on a patch (pretty much taken from Roderick Colenbrander) for this reason. At the moment in current git, fog is broken when used with shaders (Dolphin demo and Tomb Raider Legend are affected). > I can think of a few ways to solve this: > * Do not do any opengl changes in SetRenderState, and apply all states in > drawprim. This way UnlockRect and Blt don't have to care for resetting the > things they changed and redundant changes can be catched nicely This style is probably the best, since we (hopefully) don't have to change much between drawPrim calls. Just have a function which compares the current GL state to the desired (cached) state, and change only what's necessary. However, some things (as you mentioned) can be changed safely during SetRenderState, and that's outside of the drawPrim loop, so hopefully it's just once per scene. Though, every game acts a bit differently, so it's tough to say how one method will work over another. But the caching method seems the cleanest to me. > To avoid re-setting an old setting again the current opengl state could be > stored in the d3ddevice. I think this should be done in any case, and > depending on the nature of some parameters the opengl state or the d3d state > should be kept in there(or both). Agreed. > I also think we should try to get rid of as much things as possible in > drawprim. I do not mean entirely removing it, but having a simple flag which > tells if a bigger number of states needs attention, like last_was_rhw does. I > think about adding a last_was_blit flag which is set in BltOverride and > UnlockRect. Yep. So, let's get a final game plan together and I can start the process with the fog patch, then we can start cleaning up everything else (which will be a fairly large undertaking but can be done in small chunks). Jason

June 27, 2006

wined3d: Regression in DX8 SDK samples with VBO patch

by Jason Green

http://source.winehq.org/git/?p=wine.git;a=commit;h=2122026713baa3180931816… This patch breaks most of the DirectX 8 SDK Direct3D samples (Billboard, ClipMirror, Cull, etc.). It seems like most of the samples that use Shaders work fine, but those that don't are broken (misplaced vertices, etc.).

June 27, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by William Knop

After looking at Darwine's quartzdrv, it looks like it uses CoreGraphics. On 6/26/06, William Knop <william.knop(a)gmail.com> wrote: > Yeah, a wiki page for the Quartz driver would be nice. There are a > couple implementations floating around, some using QuickDraw and some > using CoreGraphics. Most have endian bugs, since they were written > with Darwine/PPC in mind. As far as which is best, it seems to be that > QD is easiest, but it's a deprecated API. > > I think I'd use CG if I decided to sit down and write it, which I > might do. I've got some free time, and in a week or so I'll have > access to an intel mac for development. Thoughts on CG? Alexandre? > > Will > > On 6/26/06, Steven Edwards <winehacker(a)gmail.com> wrote: > > Hi William, > > > > On 6/26/06, William Knop <william.knop(a)gmail.com> wrote: > > > Quartz Driver: works > > > > Starting a wiki page just about this would be nice if one does not > > already exist. I am really interested in the Quartz driver but have > > not had the time to focus on it. It would be cool if someone could > > cleanup the diff and or poke at Julliard for his comments on it before > > too much time is invested in developing it futher. As far as I have > > seen simple win32 apps work with it which is a good start but it would > > be nice to have a patch that he could review and advise what more is > > needed before it can go in winehq. Being able to run Wine without > > needing the damn X server would be wonderful but its never going to > > get past the solitare stage unless we can get it in winehq. > > > > The last time I spoke with him about it, he said the Quartz driver did > > not have to be 100% just enough to prove a valid framework which I > > think the current one does. Namely running solitare without the X. The > > major infrastructure issue with it the last time I looked was the > > problem of conflicting functions in the C namespace. The quartzdrv > > imported and used Mac functions that had the same name as win32 > > functions and led to all sorts of problems requiring a hack to > > winebuild. Julliard suggested some linker magic could be done to not > > require needing to hack winebuild and or making some sort of wrapper > > library. I am sure there are other issues with design he will want > > resolved also.... > > > > -- > > Steven Edwards > > > > "There is one thing stronger than all the armies in the world, and > > that is an idea whose time has come." - Victor Hugo > > >

June 27, 2006

Re: [AppDB] - user class cleanup and implement user class unit test

by Chris Morgan

On Monday 26 June 2006 6:06 pm, Jonathan Ernst wrote: > Le lundi 26 juin 2006 à 15:33 -0400, Chris Morgan a écrit : > [...] > > > Comments? Questions? > > Index: index.php > =================================================================== > RCS file: /opt/cvs-commit/appdb/index.php,v > retrieving revision 1.33 > diff -u -r1.33 index.php > --- index.php 21 Jun 2006 01:04:12 -0000 1.33 > +++ index.php 26 Jun 2006 19:26:39 -0000 > @@ -7,7 +7,7 @@ > * application environment > */ > include("path.php"); > -require(BASE."include/incl.php"); > +require_once(BASE."include/incl.php"); > > Why use require_once ? It is slower and is bad unless you intend to > include index.php in another file where incl.php is also included... > I can't recall why anymore. I've reverted this change and everything still seems to work. > > Index: include/image.php > =================================================================== > RCS file: /opt/cvs-commit/appdb/include/image.php,v > retrieving revision 1.5 > diff -u -r1.5 image.php > --- include/image.php 21 Sep 2005 14:16:40 -0000 1.5 > +++ include/image.php 26 Jun 2006 19:26:40 -0000 > @@ -3,6 +3,8 @@ > /* image and image_resource classes */ > /*************************************/ > > +include_once(BASE."include/incl.php"); > + > > This time you use include once, we should use require everywhere if > incl.php is required (and including a file in another include is not so > pretty IMHO). > Reverted this change too since I can't recall why I made this change either. > > > + /* NOTE: we can't update the users password like we can update > other */ > + /* fields such as their email or username because the password is > hashed */ > + /* in the database so we can't keep the users password in a class > member variable */ > + /* and use update() because we can't check if the password changed > without hashing */ > + /* the newly supplied one */ > + function update_password($sPassword) > > > Should updatePassword according to our coding standards (method names). Updated. Chris

June 27, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by William Knop

Yeah, a wiki page for the Quartz driver would be nice. There are a couple implementations floating around, some using QuickDraw and some using CoreGraphics. Most have endian bugs, since they were written with Darwine/PPC in mind. As far as which is best, it seems to be that QD is easiest, but it's a deprecated API. I think I'd use CG if I decided to sit down and write it, which I might do. I've got some free time, and in a week or so I'll have access to an intel mac for development. Thoughts on CG? Alexandre? Will On 6/26/06, Steven Edwards <winehacker(a)gmail.com> wrote: > Hi William, > > On 6/26/06, William Knop <william.knop(a)gmail.com> wrote: > > Quartz Driver: works > > Starting a wiki page just about this would be nice if one does not > already exist. I am really interested in the Quartz driver but have > not had the time to focus on it. It would be cool if someone could > cleanup the diff and or poke at Julliard for his comments on it before > too much time is invested in developing it futher. As far as I have > seen simple win32 apps work with it which is a good start but it would > be nice to have a patch that he could review and advise what more is > needed before it can go in winehq. Being able to run Wine without > needing the damn X server would be wonderful but its never going to > get past the solitare stage unless we can get it in winehq. > > The last time I spoke with him about it, he said the Quartz driver did > not have to be 100% just enough to prove a valid framework which I > think the current one does. Namely running solitare without the X. The > major infrastructure issue with it the last time I looked was the > problem of conflicting functions in the C namespace. The quartzdrv > imported and used Mac functions that had the same name as win32 > functions and led to all sorts of problems requiring a hack to > winebuild. Julliard suggested some linker magic could be done to not > require needing to hack winebuild and or making some sort of wrapper > library. I am sure there are other issues with design he will want > resolved also.... > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo >

June 26, 2006

Re: WoW broken for wine 0.9.16 Nvidia cards

by nlaw＠nildram.co.uk

Nick wrote: > Hi, > > Just a quick question, WoW ( World of Warcraft ) was broken (for > Nvidia cards) with there latest software update. Is anybody working on > fixing Wow (with Nvidia Cards) ( working fine with ATI ). > > I just wondered if there was an opengl guru working on fixing this > broken application ?. Or whether I should invest some time in learning > more about the intricacies of wine and openg and NVidia !.. and fix it > myself ( my background is C and assembler (not Intel, but RT11 & > Perkin Elmer) ? > > One of the users was asking about progress on fixing this app. I would > like to respond back with some progress but suspect nobody is working > on it :-( > > Regards > > Nick Law > * > Now where's that "Learn opengl/wine/graphics in 21 days" book ..* > maybe I spoke too soon, a fix may have just become available ( we'll see after more tests ) :-)

June 26, 2006

Re: How are we doing?&In-Reply-To=44802036.6030100@codeweavers.com

by Vijay Kiran Kamuju

notNeeded=0; if (Ishack()) { /*(hacks are not accepted)*/ notNeeded=1; } else if(IsFeature()) { notNeeded=0; } PS ---- :P for the if - then constructs On 6/26/06, john(a)opensoftcorp.com <john(a)opensoftcorp.com> wrote: > On Friday, June 02, 2006 07:25, Mike McCormack wrote: > > >> lack of comments in the code > > > > > > +1, I think it's horrifying. > > > > void the_function_that_adds_one_to_i(int i) > > { > > /* this adds one to i */ > > i = i + 1; > > > > /* this returns i to the caller */ > > return i; > > } > > > > Horrifying, yes :) > > > > Mike > > I'm not opposed to having bug number in the comments ;) > > ---------------------------------------------------------------- > This message was sent using IMP, the Internet Messaging Program. > > > >

June 26, 2006

Re: [AppDB] - user class cleanup and implement user class unit test

by Jonathan Ernst

Le lundi 26 juin 2006 à 15:33 -0400, Chris Morgan a écrit : [...] > Comments? Questions? > Index: index.php =================================================================== RCS file: /opt/cvs-commit/appdb/index.php,v retrieving revision 1.33 diff -u -r1.33 index.php --- index.php 21 Jun 2006 01:04:12 -0000 1.33 +++ index.php 26 Jun 2006 19:26:39 -0000 @@ -7,7 +7,7 @@ * application environment */ include("path.php"); -require(BASE."include/incl.php"); +require_once(BASE."include/incl.php"); Why use require_once ? It is slower and is bad unless you intend to include index.php in another file where incl.php is also included... Index: include/image.php =================================================================== RCS file: /opt/cvs-commit/appdb/include/image.php,v retrieving revision 1.5 diff -u -r1.5 image.php --- include/image.php 21 Sep 2005 14:16:40 -0000 1.5 +++ include/image.php 26 Jun 2006 19:26:40 -0000 @@ -3,6 +3,8 @@ /* image and image_resource classes */ /*************************************/ +include_once(BASE."include/incl.php"); + This time you use include once, we should use require everywhere if incl.php is required (and including a file in another include is not so pretty IMHO). + /* NOTE: we can't update the users password like we can update other */ + /* fields such as their email or username because the password is hashed */ + /* in the database so we can't keep the users password in a class member variable */ + /* and use update() because we can't check if the password changed without hashing */ + /* the newly supplied one */ + function update_password($sPassword) Should updatePassword according to our coding standards (method names).

June 26, 2006

Build on kubuntu 6.06,amd_64 works

by Amaury

Hi, Sorry if I'm ask a stupid question, but I'm a newbie to Linux, trying to learn... I've been trying to install wine through the package manager but it said it was not possible (error message: "Depends: wine-dev but it is not installable"). I kind of knew it cos i'm running under Ubuntu 6.06-LTS for amd 64 and I had read somewhere that wine didn't run on such system. My investigations led me to your post on http://www.winehq.com/pipermail/wine-devel/2006-June/048637.html Could you please detail step by step how the installation works cos the command lines don't make much sense to me MT A.

June 26, 2006

Re: New dlls/ddraw/device.c warnings

by Stefan Dösinger

Am Montag 26 Juni 2006 19:13 schrieben Sie: > After the recent sets of changes, I found that GCC 3.4 issues the > following warnings (on FreeBSD 5.4. > > I checked and depending on how a compiler implements assert(), the > warnings are valid, insofar as the compiler doesn't have a way to > automatically determine that all code paths are covered: > > device.c: In function `Thunk_IDirect3DDeviceImpl_2_Begin': > device.c:1826: warning: 'FVF' might be used uninitialized in this > function device.c: In function `Thunk_IDirect3DDeviceImpl_2_BeginIndexed': > device.c:1886: warning: 'FVF' might be used uninitialized in this function > device.c: In function `Thunk_IDirect3DDeviceImpl_2_DrawPrimitive': > device.c:2752: warning: 'FVF' might be used uninitialized in this function > device.c: In function `Thunk_IDirect3DDeviceImpl_2_DrawIndexedPrimitive': > device.c:2891: warning: 'FVF' might be used uninitialized in this function > > Could you have a look into this, Stefan? If someone has a hint on > the preferred approach to address this, I can give it a try as well. This seems to be a clear case of 'stupid compiler'. The assert(0) in the default case of the switch statement will terminate the app, but it the compiler thinks that the call below will be called. I sent a fix which replaces the assertions by an ERR log and an error return to wine-patches Thanks for the hint Stefan

June 26, 2006

keyboard keypress codepath

by Saulius Menkevicius

Hi, Recently I've been trying to make MS Word work on my box, and just now I've finally managed to do that without resorting to winetools etc. (thanks to the work of msi.dll people). Now the problem is that I use Lithuanian keyboard layout on my gnome desktop and it doesn't properly "translate" some of the non-latin letters (like 'ąčęėįųū'). When I press one of those MS Word shows 'a/A' instead of 'ą/Ą', 'c/C' instead of 'č/Č', etc. Letter 'š/Š', though is mapped correctly. Same things happen for capital letters too. [This mail is supposed to be unicode one, sorry for those incapable of seeing those letters] It appears to be some mapping issue for letters that didn't have their canonical mappings previously (or something, I'm not an expert on codepages). Would anyone guide me with several sentences on where to look for those mapping tables (or code) in wine source tree? Thanks.

June 26, 2006

Re: cvs compile broken

by H. Verbeet

> > >> CVS compile is broken on my machine: I've got a patch for this, will send later.

June 26, 2006

WoW broken for wine 0.9.16 Nvidia cards

by nlaw＠nildram.co.uk

Hi, Just a quick question, WoW ( World of Warcraft ) was broken (for Nvidia cards) with there latest software update. Is anybody working on fixing Wow (with Nvidia Cards) ( working fine with ATI ). I just wondered if there was an opengl guru working on fixing this broken application ?. Or whether I should invest some time in learning more about the intricacies of wine and openg and NVidia !.. and fix it myself ( my background is C and assembler (not Intel, but RT11 & Perkin Elmer) ? One of the users was asking about progress on fixing this app. I would like to respond back with some progress but suspect nobody is working on it :-( Regards Nick Law * Now where's that "Learn opengl/wine/graphics in 21 days" book ..*

June 26, 2006

Re: cvs compile broken

by James Hawkins

On 6/26/06, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > James Hawkins wrote: > > > On 6/26/06, James Hawkins <truiken(a)gmail.com> wrote: > >> Hey, > >> > >> CVS compile is broken on my machine: > >> > > > It sounds like gcc is not finding your GL headers. I gained mine by > installing Mesa. On my SUSE 10.1 system, they got installed > under /usr/include/GL/. > hmm I don't think so. Even if that were the case, we should still handle it without user intervention. I'm pretty sure it's a versioning problem, because this has happened before (recently). I'm on a modified Red Hat 9 system. -- James Hawkins

June 26, 2006

Re: cvs compile broken

by Andrew Talbot

James Hawkins wrote: > On 6/26/06, James Hawkins <truiken(a)gmail.com> wrote: >> Hey, >> >> CVS compile is broken on my machine: >> > It sounds like gcc is not finding your GL headers. I gained mine by installing Mesa. On my SUSE 10.1 system, they got installed under /usr/include/GL/. -- Andy.

June 26, 2006

Re: cvs compile broken

by James Hawkins

On 6/26/06, James Hawkins <truiken(a)gmail.com> wrote: > Hey, > > CVS compile is broken on my machine: > Part two: vertexbuffer.c: In function `IWineD3DVertexBufferImpl_PreLoad': vertexbuffer.c:145: `GL_ARRAY_BUFFER' undeclared (first use in this function) vertexbuffer.c:145: (Each undeclared identifier is reported only once vertexbuffer.c:145: for each function it appears in.) vertexbuffer.c: In function `IWineD3DVertexBufferImpl_Lock': vertexbuffer.c:349: `GL_READ_WRITE' undeclared (first use in this function) vertexbuffer.c:355: `GL_WRITE_ONLY' undeclared (first use in this function) vertexbuffer.c:357: `GL_READ_ONLY' undeclared (first use in this function) vertexbuffer.c:361: `GL_ARRAY_BUFFER' undeclared (first use in this function) vertexbuffer.c: In function `IWineD3DVertexBufferImpl_Unlock': vertexbuffer.c:381: `GL_ARRAY_BUFFER' undeclared (first use in this function) make[2]: *** [vertexbuffer.o] Error 1 make[2]: Leaving directory `/home/jhawkins/wine/dlls/wined3d' -- James Hawkins

June 26, 2006

cvs compile broken

by James Hawkins

Hey, CVS compile is broken on my machine: make[2]: Entering directory `/home/jhawkins/wine/dlls/wined3d' gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o arb_program_shader.o arb_program_shader.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o baseshader.o baseshader.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o basetexture.o basetexture.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o cubetexture.o cubetexture.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o device.o device.c device.c: In function `process_vertices_strided': device.c:5015: `GL_READ_ONLY' undeclared (first use in this function) device.c:5015: (Each undeclared identifier is reported only once device.c:5015: for each function it appears in.) device.c:5033: `GL_WRITE_ONLY' undeclared (first use in this function) device.c: In function `IWineD3DDeviceImpl_ProcessVertices': device.c:5352: `GL_READ_ONLY' undeclared (first use in this function) make[2]: *** [device.o] Error 1 make[2]: Leaving directory `/home/jhawkins/wine/dlls/wined3d' make[1]: *** [wined3d] Error 2 make[1]: Leaving directory `/home/jhawkins/wine/dlls' make: *** [dlls] Error 2 -- James Hawkins

June 26, 2006

Re: [AppDb] [2/3] safe functions

by Chris Morgan

On Monday 26 June 2006 12:29 pm, Jonathan Ernst wrote: > Le lundi 26 juin 2006 à 11:54 -0400, Chris Morgan a écrit : > > [...] > > The most effective solution involves both filtering and sql protection. > > The first layer of protection is to filter each input variable down to > > the most restrictive data we can accept. > > > > The next step is to ensure that each query, independent of the data > > passed in, is safe because of the appropriate quoting. > > > > With both of these layers in place we can be pretty sure that injection > > and other attacks on the code will be much less effective. We could > > probably be secure with only the sql protection in place but the > > filtering raises the bar greatly for any potential exploits of sql or any > > other logic in the appdb. > > IMHO SQL protection (mysql_real_escape_string()) and correct database > design (ex. if we want integer make the field integer, an sql query with > something else will fail), along with data filtering when we display > user submitted data that doesn't come from database gives the same > protection (both SQL and HTML injection) without making the code > unreadable and having to copy strings everywhere and have is_integer(), > is_empty(), whatever checks everywhere. > People who write books about php security disagree: http://shiflett.org/articles/security-corner-apr2004 > > > > Also, I've submitted a patch for review to appdb(a)winehq.com and > > > > wine-patches(a)winehq.com that removes all of our > > > > get_magic_quotes_gpc() use and adds a check in include/incl.php that > > > > warns and prevents appdb from running if magic quotes is enabled. So > > > > you shouldn't need to have any get_magic_quotes_gpc() checks anymore. > > > > > > Isn't it better to support both configurations ? My solution works with > > > or without magic quotes. > > > > I don't believe so. If you read the patch that I submitted or look in > > include/incl.php you'll see the reasoning behind not bothering with magic > > quotes. > > > > echo "No! addslashes() isn't adequate. You should use > > mysql_real_escape_string() or some other function"; > > echo " that will handle multi-byte characters. See <a > > href=\"http://shiflett.org/archive/184\">this article</a>"; echo " for a > > way to exploit addslash()ed parameters. "; > > My function does just that. Ahh I see, you were addslash()ing the html stuff. > > > echo "A second reason is that with magic quotes enabled, due to the > > use of mysql_real_escape_string() to"; echo " protect from sql > > injection attacks we'll end up with variables that have been addslash()ed > > and"; echo " mysql_real_escape_string()ed. So you end up having > > to call stripslashes() on EVERY variable. "; > > No big deal, my function stripslashes only when magic quotes are enabled so > the only drawback of having magic_quotes enabled is that the AppDB is > theoretically a bit slower because we have to make a stripslashes > before applying mysql_real_escape_string if someone wishes to let > magic_quotes enabled. > > > > > I also noticed your quote_smart_sql() call. This call isn't used > > > > anywhere, we shouldn't add calls to functions that aren't called. We > > > > > > It is used in 3/3. > > > > > > > also already have a function that will make sql calls safe called > > > > query_paramters() in include/db.php. Also, do we want to strip tags > > > > from sql? Won't that remove all tags from things like app/version > > > > descriptions, comments and notes? > > > > > > No, there is a parameter in this function (quote_smart_sql). By default > > > we don't remove html, but for some fields we might want to filter out > > > html (comment titles, etc.) > > > > Ahh I see. > > Some questions : > > - Will you apply my coding_standards patch ? > - Will you apply my show_error_page patch ? > - Will you refuse my proposed way of securing the AppDB ? (I need to > know because I'm willing to cleanup the rest of the AppDB regarding this > issue (and others) but I don't want to send more patches if they will be > discarded) coding standard patch has been applied. It was in the queue to be but was busy with other appdb things. show_error_page patch is behind the sql injection patches that are higher priority. Securing the appdb is going to be done in two layers like current experts in the field such as Chris Shiflett and others recommend. The first layer is proper filtering of data, see php.net/filter. Filtering data should ensure that only appropriately typed and valued data can even get into use If we can't get this extension on the server, and I've emailed Jeremy Newman a few times about this without any response, then we should implement our own class that implements just what we need but uses the same syntax and parameter values. This way if we upgrade to php >= 5.2 we'll be able to switch over without much trouble. The second layer is the use of query_parameters() for all sql queries. This encapsulates the function we will use to protect each parameter and matches the formatting used in pear db. Making the user call sprintf() and quote_smart_sql() breaks encapsulation and is more complex than the query_parameters() way of doing things. sprintf() also lacks the functionality of the ?, ~ and & characters that query_parameters() supports. query_parameters() also matches the use of prepared statements that we may want to use in the future to speed up sql queries. Today the final piece of the second layer is nearly completed and in place so this part of your patches seems to overlap a cleaner and completed way of fixing sql injection issues. Fixing the filtering layer may or may not have been started yet by EA but we'll want to get something to replace makeSafe() with that lines up with php's filter extension. Chris

June 26, 2006

New dlls/ddraw/device.c warnings

by Gerald Pfeifer

After the recent sets of changes, I found that GCC 3.4 issues the following warnings (on FreeBSD 5.4. I checked and depending on how a compiler implements assert(), the warnings are valid, insofar as the compiler doesn't have a way to automatically determine that all code paths are covered: device.c: In function `Thunk_IDirect3DDeviceImpl_2_Begin': device.c:1826: warning: 'FVF' might be used uninitialized in this function device.c: In function `Thunk_IDirect3DDeviceImpl_2_BeginIndexed': device.c:1886: warning: 'FVF' might be used uninitialized in this function device.c: In function `Thunk_IDirect3DDeviceImpl_2_DrawPrimitive': device.c:2752: warning: 'FVF' might be used uninitialized in this function device.c: In function `Thunk_IDirect3DDeviceImpl_2_DrawIndexedPrimitive': device.c:2891: warning: 'FVF' might be used uninitialized in this function Could you have a look into this, Stefan? If someone has a hint on the preferred approach to address this, I can give it a try as well. Thanks, Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

June 26, 2006

Re: indented relay traces

by Duane Clark

James Hawkins wrote: > On 6/24/06, Eric Pouech <eric.pouech(a)wanadoo.fr> wrote: >> this won't work for a multithreaded program >> tools/examine_relay does what you want, plus some other goodies (calls >> that didn't return...) > > Ah, didn't know about that tool. You learn something new every day. > It is also not immediately obvious that it will indent in two slightly different formats. Add a flag to the end of the command line to get different formatting: tools/examine_relay wine.log -f

June 26, 2006

Re: [AppDb] [2/3] safe functions

by Jonathan Ernst

Le lundi 26 juin 2006 à 11:54 -0400, Chris Morgan a écrit : > [...] > The most effective solution involves both filtering and sql protection. The > first layer of protection is to filter each input variable down to the most > restrictive data we can accept. > > The next step is to ensure that each query, independent of the data passed in, > is safe because of the appropriate quoting. > > With both of these layers in place we can be pretty sure that injection and > other attacks on the code will be much less effective. We could probably be > secure with only the sql protection in place but the filtering raises the bar > greatly for any potential exploits of sql or any other logic in the appdb. IMHO SQL protection (mysql_real_escape_string()) and correct database design (ex. if we want integer make the field integer, an sql query with something else will fail), along with data filtering when we display user submitted data that doesn't come from database gives the same protection (both SQL and HTML injection) without making the code unreadable and having to copy strings everywhere and have is_integer(), is_empty(), whatever checks everywhere. > > > > > Also, I've submitted a patch for review to appdb(a)winehq.com and > > > wine-patches(a)winehq.com that removes all of our get_magic_quotes_gpc() > > > use and adds a check in include/incl.php that warns and prevents appdb > > > from running if magic quotes is enabled. So you shouldn't need to > > > have any get_magic_quotes_gpc() checks anymore. > > > > Isn't it better to support both configurations ? My solution works with > > or without magic quotes. > > > > I don't believe so. If you read the patch that I submitted or look in > include/incl.php you'll see the reasoning behind not bothering with magic > quotes. > echo "No! addslashes() isn't adequate. You should use > mysql_real_escape_string() or some other function"; > echo " that will handle multi-byte characters. See <a href=\"http://shiflett.org/archive/184\">this article</a>"; > echo " for a way to exploit addslash()ed parameters. "; My function does just that. > echo "A second reason is that with magic quotes enabled, due to the use of mysql_real_escape_string() to"; > echo " protect from sql injection attacks we'll end up with variables that have been addslash()ed and"; > echo " mysql_real_escape_string()ed. So you end up having to call stripslashes() on EVERY variable. "; No big deal, my function stripslashes only when magic quotes are enabled so the only drawback of having magic_quotes enabled is that the AppDB is theoretically a bit slower because we have to make a stripslashes before applying mysql_real_escape_string if someone wishes to let magic_quotes enabled. > > > > > I also noticed your quote_smart_sql() call. This call isn't used > > > anywhere, we shouldn't add calls to functions that aren't called. We > > > > It is used in 3/3. > > > > > also already have a function that will make sql calls safe called > > > query_paramters() in include/db.php. Also, do we want to strip tags > > > from sql? Won't that remove all tags from things like app/version > > > descriptions, comments and notes? > > > > No, there is a parameter in this function (quote_smart_sql). By default > > we don't remove html, but for some fields we might want to filter out > > html (comment titles, etc.) > > > > > > Ahh I see. Some questions : - Will you apply my coding_standards patch ? - Will you apply my show_error_page patch ? - Will you refuse my proposed way of securing the AppDB ? (I need to know because I'm willing to cleanup the rest of the AppDB regarding this issue (and others) but I don't want to send more patches if they will be discarded) Thanks

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by Steven Edwards

Hi William, On 6/26/06, William Knop <william.knop(a)gmail.com> wrote: > Quartz Driver: works Starting a wiki page just about this would be nice if one does not already exist. I am really interested in the Quartz driver but have not had the time to focus on it. It would be cool if someone could cleanup the diff and or poke at Julliard for his comments on it before too much time is invested in developing it futher. As far as I have seen simple win32 apps work with it which is a good start but it would be nice to have a patch that he could review and advise what more is needed before it can go in winehq. Being able to run Wine without needing the damn X server would be wonderful but its never going to get past the solitare stage unless we can get it in winehq. The last time I spoke with him about it, he said the Quartz driver did not have to be 100% just enough to prove a valid framework which I think the current one does. Namely running solitare without the X. The major infrastructure issue with it the last time I looked was the problem of conflicting functions in the C namespace. The quartzdrv imported and used Mac functions that had the same name as win32 functions and led to all sorts of problems requiring a hack to winebuild. Julliard suggested some linker magic could be done to not require needing to hack winebuild and or making some sort of wrapper library. I am sure there are other issues with design he will want resolved also.... -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

June 26, 2006

Re: [AppDb] [2/3] safe functions

by Chris Morgan

On Monday 26 June 2006 1:50 am, Jonathan Ernst wrote: > Le dimanche 25 juin 2006 à 20:00 -0400, Chris Morgan a écrit : > > Hi Jonathan. > > > > You'll want to talk to EA about the filtering changes. The plan is to > > filter using the same syntax and flags that the php filter extension > > is going to use so we can easily switch over to this extension in the > > future. > > I know we could use PEAR and we could also use a database abstraction > layer, I just thought my solution was better because it has proven to > work well on several projects I worked recently and is recommanded by > the php manual (and it makes queries more readable than using other > syntaxes). > The most effective solution involves both filtering and sql protection. The first layer of protection is to filter each input variable down to the most restrictive data we can accept. The next step is to ensure that each query, independent of the data passed in, is safe because of the appropriate quoting. With both of these layers in place we can be pretty sure that injection and other attacks on the code will be much less effective. We could probably be secure with only the sql protection in place but the filtering raises the bar greatly for any potential exploits of sql or any other logic in the appdb. > > Also, I've submitted a patch for review to appdb(a)winehq.com and > > wine-patches(a)winehq.com that removes all of our get_magic_quotes_gpc() > > use and adds a check in include/incl.php that warns and prevents appdb > > from running if magic quotes is enabled. So you shouldn't need to > > have any get_magic_quotes_gpc() checks anymore. > > Isn't it better to support both configurations ? My solution works with > or without magic quotes. > I don't believe so. If you read the patch that I submitted or look in include/incl.php you'll see the reasoning behind not bothering with magic quotes. > > I also noticed your quote_smart_sql() call. This call isn't used > > anywhere, we shouldn't add calls to functions that aren't called. We > > It is used in 3/3. > > > also already have a function that will make sql calls safe called > > query_paramters() in include/db.php. Also, do we want to strip tags > > from sql? Won't that remove all tags from things like app/version > > descriptions, comments and notes? > > No, there is a parameter in this function (quote_smart_sql). By default > we don't remove html, but for some fields we might want to filter out > html (comment titles, etc.) > > Ahh I see. Chris

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by David Bialac

I'm personally a relative Noop to Wine on Mac intel development. My goal has been to conquer the threading issues that keep it from running most modern-day apps, but I haven't really found the support (at least from the darwine email lists) necessary to write this component. About the only place there I've contributed was on the have a separate vs don't have a separate email list, which IMHO if they have one PPC should be mentioned as when I see the Darwine project I see it as one aimed at Intel macs, not PPC. That may be the reason that my responses have gone quiet over there -- intel isn't a goal. Dave --- James Hawkins <truiken(a)gmail.com> wrote: > On 6/26/06, William Knop <william.knop(a)gmail.com> > wrote: > > I think you missed my point. I know people are > working on it. The > > problem is "a few people, including Codeweavers, > are working on it," > > which is just about the sum-total of the > information out there, is not > > enough. There is very little information out there > for potential > > developers to know what's going on with wine and > intel macos x. For > > instance, a status page describing to-do items > would be a start (I'm > > going to add it to the wine wiki when I figure out > what the status > > is). It should be mentioned on winehq, so macos x > developers know to > > investigate further when they check wine out. > Expecting people to dig > > through the code or the mailing list is > unreasonable. Is this really > > only obvious to me? > > > > You could just ask, "Hey, what's the status of Wine > on Intel Max OS > X?". No one has really stepped up to work on that > aspect of Wine, > outside of Codeweavers, so there's not a whole lot > of incentive to put > this information up. So if you're wanting to work > on this, step up to > the plate, and I'm sure we'll be more than willing > to help. > > -- > James Hawkins > > > -- David Bialac dbialac(a)yahoo.com

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by William Knop

On 6/26/06, Alexandre Julliard <julliard(a)winehq.org> wrote: > There's no quartz driver in WineHQ. There are some patches floating > around but it's very far from working. Oops, I realized that just after I hit send. I'll make sure to state that it has rudimentary support.

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by William Knop

On 6/26/06, Alexandre Julliard <julliard(a)winehq.org> wrote: > At this point, many simple apps should probably work OK. The main > problems areas that need work are exception handling (mainly because > of kernel bugs) and the debugger support that essentially doesn't work > at all. You'll also need to disable optimizations when building > because of the gcc stack-realign bug (we need to come up with a > configure check for it), and you most likely have to use an x.org X > server because the Apple one has some serious bugs in rootless mode. Alright, so this is what I've got so far: Overall Status: Simple applications should work. Notes: Make sure to disable gcc optimizations when building since gcc has a stack realignment bug. Also, Apple's X11 has serious bugs in rootless mode, so x.org's X11 may be necessary. Tasks: Quartz Driver: works Core Audio Driver: works 16 Byte Stack Alignment: work in progress Mach Kernel Workarounds and Exception Handling: needs a lot of work Debugger: does not work Anything to add or correct? Thanks, Will

June 26, 2006

Re: How do I get the unix filename for a wine handle?

by Kuba Ober

> > just for sake of completeness: how about enhancing ClamAV so that it > > takes a fd (instead of a filename) as its input ? > > It looks like as if fd are already supported somehow. Need to have a closer > look at that ... > > But I found an even better alternative: ClamAV supports a STREAM command > which allows a client to send a string to the scanner. This allows to scan > a string even before it is written to disk. I think that this will totally kill performance. Many programs can create temporary files that later get deleted. There's no point in monitoring writes to those. The only way to tell is to wait until the handle gets closed by wine. Then I imagine you'd use fstat on a copy of the handle and see if there are any hard links (i.e. directory entries) pointing to that inode, and if there are (i.e. if the file is still acessible), only then you'd scan it. You'd also need to keep track of any handle copies that wine holds, if there are any -- I don't know offhand if wine itself duplicates "user" file handles, nor whether there's a windows API to do so. Similarly, programs such as databases may reorganize huge swaths of file(s), writing a lot of stuff that has no relevance to a virus scanner. I think that no-brainer approaches will result in exactly the same performance-robbing solution as McAffe and Symantec products evolved to. I think there needs to be some more serious thinking done before implementing your project. Cheers, Kuba

June 26, 2006

Re: How do I get the unix filename for a wine handle?

by Kuba Ober

On Saturday 24 June 2006 07:06, Christoph Probst wrote: > Hi. > > Alexandre Julliard wrote: > > You can't do that in general. In Unix a file can have multiple names, > > or even none at all, there's simply no way to get a filename from a > > handle. On Linux you can use /proc/self/fd but that's not very > > portable. > > So what do you think about the solution that the wineserver stores the > filename in the file object when the object is created? > > Just like wine_server_handle_to_fd() there would be a > wine_server_handle_to_filename() that returns the filename. A way to possibly do what you want to do is to duplicate the file handle, and to hack on ClamAV to scan a file given a handle to it. On unices you can open a file, hold a handle to it, and then remove the directory entry (rm file) -- the file will exist on the disk without a directory entry, for as long as the file handle is open. I don't think you could do that under e.g. Windows, so Unix is different here. In general the only way to get at a file knowing its handle is to use a duplicate handle. That'd be the only robust way AFAIK. Cheers, Kuba

June 26, 2006

Re: Autocad 2004 STATUS_INVALID_LDT_OFFSET

by Kuba Ober

> Thanks Ivan. > I did some IRC with Vitaliy, and he came to the conclusion that the > outport() code was probably the result of messed up code/stack, since > the program doesn't use any hardware or locks. I will look into it > tomorrow. As one other possibility, and I'm not trying to suggest that it's necessarily the case: could the driver want to check if it's indeed running in ring 0 by trying to poke some "safe" port? I know it'd be weird, but since copy protection is insane in itself, who knows . . . Cheers, Kuba

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by Alexandre Julliard

William Knop <william.knop(a)gmail.com> writes: > Just from keeping up with the mailing list, I've gleaned that Quartz > and Core Audio are being worked on, in addition to a stack alignment > patch. They seem to be pretty far along, but I don't really know. Are > there any other intel/darwin areas that require attention or are > being worked on? At this point, many simple apps should probably work OK. The main problems areas that need work are exception handling (mainly because of kernel bugs) and the debugger support that essentially doesn't work at all. You'll also need to disable optimizations when building because of the gcc stack-realign bug (we need to come up with a configure check for it), and you most likely have to use an x.org X server because the Apple one has some serious bugs in rootless mode. So it's not quite ready for prime time yet. We are hoping to have binary packages on WineHQ in the near future, that should make it somewhat easier to get things going. -- Alexandre Julliard julliard(a)winehq.org

June 26, 2006

Compilation error using winegcc

by Vikas Gera

Hello!! I am new user to Wine. I have downloaded Wine-0.9.15 sources on solaris box and tried to compile a simple "Hello World" program using WineLib. I am getting following error: winegcc: -Wl,-G,-B,symbolic failed. *** Error code 2 make: Fatal error: Command failed for target `helloworld.so' Can anybody guide me as to what went wrong? I have following environment setup Solaris 10, gcc, wine sources 0.9.15 built (compiled) using patch released on 2006/05/22 (http://www.blastwave.org/wine) regards, Vikas Gera

June 26, 2006

Re: mshtml 8: Added beginning IDM_BROWSEMODE implementation.

by Alexandre Julliard

This one breaks the tests: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmldoc.c && touch htmldoc.ok htmldoc.c:1703: Test failed: expected Invoke_AMBIENT_USERMODE htmldoc.c:1703: Test failed: expected Invoke_AMBIENT_USERMODE htmldoc.c:1703: Test failed: expected Invoke_AMBIENT_USERMODE htmldoc.c:1703: Test failed: expected Invoke_AMBIENT_USERMODE -- Alexandre Julliard julliard(a)winehq.org

June 26, 2006

Re: riched20: (updated) EM_GETLINE implementation and test

by Alexandre Julliard

Krzysztof Foltman <wdev(a)foltman.com> writes: > This is the EM_GETLINE patch from Thomas Kho, updated to current git > and with L"" replaced by proper WCHAR array. There are many more problems with that patch. For instance, it shouldn't call IsWindowUnicode all the time, once is enough. Also casting pointers to int is a bad idea (and not needed), it should use sizeof(WCHAR) instead of hardcoding 2, and preferably use proper data types instead of the nBPC hack. -- Alexandre Julliard julliard(a)winehq.org

June 26, 2006

How are we doing?&In-Reply-To=44802036.6030100@codeweavers.com

by john＠opensoftcorp.com

On Friday, June 02, 2006 07:25, Mike McCormack wrote: > >> lack of comments in the code > > > > +1, I think it's horrifying. > > void the_function_that_adds_one_to_i(int i) > { > /* this adds one to i */ > i = i + 1; > > /* this returns i to the caller */ > return i; > } > > Horrifying, yes :) > > Mike I'm not opposed to having bug number in the comments ;) ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by James Hawkins

On 6/26/06, William Knop <william.knop(a)gmail.com> wrote: > Er... I did ask that, and I have stepped up to the plate. :) > > Well, I said I'd update the wine wiki with the status, anyway. I also > think it'd be a good idea to add to the winehq main page, but I wasn't > sure who to talk to: > Good to hear, we can always use more active help. If you want to change the winehq main page, just make a patch and send it to wine-patches(a)winehq.org. I think the best that you can do about a status update is wait to see if anyone responds to this thread. Unfortunately, most of the work that is needed to get Wine running on Intel Macs can only be done by Alexandre Julliard, unless I'm mistaken. You can send him a line at julliard(a)winehq.org, or see if he replies to this thread. -- James Hawkins

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by William Knop

Oh... Sorry about that. I suppose I did come off a bit critical. Will On 6/26/06, James Hawkins <truiken(a)gmail.com> wrote: > Well, I was trying to be nice by not saying that his attitude in his > emails tends to put devels off, and emails like that usually get > ignored. That's why I said *just*, meaning, only ask that question. > > -- > James Hawkins >

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by William Knop

Er... I did ask that, and I have stepped up to the plate. :) Well, I said I'd update the wine wiki with the status, anyway. I also think it'd be a good idea to add to the winehq main page, but I wasn't sure who to talk to: "Wine provides both a development toolkit for porting Windows source code to Unix as well as a program loader, allowing many unmodified Windows programs to run on x86-based Unixes, including Linux, FreeBSD, Darwin (MacOS X), and Solaris." Will On 6/26/06, James Hawkins <truiken(a)gmail.com> wrote: > You could just ask, "Hey, what's the status of Wine on Intel Max OS > X?". No one has really stepped up to work on that aspect of Wine, > outside of Codeweavers, so there's not a whole lot of incentive to put > this information up. So if you're wanting to work on this, step up to > the plate, and I'm sure we'll be more than willing to help. > > -- > James Hawkins >

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by James Hawkins

On 6/26/06, Tim Schmidt <timschmidt(a)gmail.com> wrote: > On 6/26/06, James Hawkins <truiken(a)gmail.com> wrote: > > > > You could just ask, "Hey, what's the status of Wine on Intel Max OS > > X?". No one has really stepped up to work on that aspect of Wine, > > outside of Codeweavers, so there's not a whole lot of incentive to put > > this information up. So if you're wanting to work on this, step up to > > the plate, and I'm sure we'll be more than willing to help. > > > > You pretty much directly quoted the first line of his first email. > He's also offered to add the status to the wiki once it becomes public > knowledge (e.g. when someone from within codeweavers sends an email to > the list with a little information). > Well, I was trying to be nice by not saying that his attitude in his emails tends to put devels off, and emails like that usually get ignored. That's why I said *just*, meaning, only ask that question. -- James Hawkins

June 26, 2006

Re: Wine, Darwine, CodeWeavers-- Intel MacOS X

by Tim Schmidt

On 6/26/06, James Hawkins <truiken(a)gmail.com> wrote: > > You could just ask, "Hey, what's the status of Wine on Intel Max OS > X?". No one has really stepped up to work on that aspect of Wine, > outside of Codeweavers, so there's not a whole lot of incentive to put > this information up. So if you're wanting to work on this, step up to > the plate, and I'm sure we'll be more than willing to help. > You pretty much directly quoted the first line of his first email. He's also offered to add the status to the wiki once it becomes public knowledge (e.g. when someone from within codeweavers sends an email to the list with a little information). --tim

June 26, 2006