June 2006 - Wine-Devel - list.winehq.org

Re: Re: How are we doing?

by fenix＠club-internet.fr

----Message d'origine---- >De: Alexandre Julliard <julliard(a)winehq.org> >A: Detlef Riekenberg <wine.dev(a)web.de> >Date: Thu, 01 Jun 2006 11:45:10 +0200 >Copie à: wine-devel(a)winehq.com, Mike Hearn <mike(a)plan99.net> >Sujet: Re: How are we doing? > >Detlef Riekenberg <wine.dev(a)web.de> writes: > >> During the Time, things changed and I get confused more and more times >> about "special Developers" and "other Developers", as well as "special >> Patches" and "other Patches". >> (It's also Possible, that i did not see the big differences before). > >There's no such thing as special developer vs. other developer, it's >more like a linear scale based on trust: the more I trust a developer >the easiest it is for him to get his patches committed. The only way >to earn trust points is by submitting consistently good patches. > >That doesn't mean you can't get stuff in if you aren't trusted, but it >means it will require extra scrutiny, which is why it's very important >at the beginning to send small patches that are easy to review. Once >you have earned enough trust you can get away with being a bit more >sloppy (but not too much, or you'll lose trust points again ;-) It's possible to see on wiki the "trust points" positions ? :) And on each WWN, see the variations (seems the famous kde buzz) :) Anyway, adding an explaining page on wiki for "how to begin as wine developper" may help a lot Regards, Raphael

June 1, 2006

Re: comctl32: Fix loading string from resources

by Alexandre Julliard

Thomas Weidenmueller <wine-patches(a)reactsoft.com> writes: > LoadString() cannot be used to measure the length of a string resource. > It will not return the length of the string if no buffer is provided, > instead it will return 0! This patch fixes the broken property sheet code. Since you are going to the trouble of loading it all by hand, you should allocate and fill the buffer right away, instead of returning only the length and letting LoadString do the whole thing once again. Also a test case for LoadString demonstrating that the current behavior is wrong would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

June 1, 2006

Re: How are we doing?

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > During the Time, things changed and I get confused more and more times > about "special Developers" and "other Developers", as well as "special > Patches" and "other Patches". > (It's also Possible, that i did not see the big differences before). There's no such thing as special developer vs. other developer, it's more like a linear scale based on trust: the more I trust a developer the easiest it is for him to get his patches committed. The only way to earn trust points is by submitting consistently good patches. That doesn't mean you can't get stuff in if you aren't trusted, but it means it will require extra scrutiny, which is why it's very important at the beginning to send small patches that are easy to review. Once you have earned enough trust you can get away with being a bit more sloppy (but not too much, or you'll lose trust points again ;-) -- Alexandre Julliard julliard(a)winehq.org

June 1, 2006

Re: winspool/tests: [1/3] Tests for GetPrintProcessorDirectory

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > + SetLastError(0xdeadbeef); > + res = GetPrintProcessorDirectoryA(NULL, NULL, 1, NULL, 0, &cbBuf); > + if(!res && ( (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) || > + (GetLastError() == 0xdeadbeef) )) { > + trace("Not implemented yet\n"); > + return; > + } Unless there really is a Windows version that fails here, this test is wrong. Things that are not implemented yet in Wine should be marked with todo_wine, not ignored. -- Alexandre Julliard julliard(a)winehq.org

June 1, 2006

Re: wineprefix: Create a cdrom drive if it exists at /media/cdrom

by Francois Gouget

On Thu, 1 Jun 2006, Mike McCormack wrote: > + ln -s /media/cdrom "$WINEPREFIX/dosdevices/m:" Wouldn't it be better to create it as the d: drive? That's usually where CD-ROM drives end up on Windows... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ War doesn't determine who's right. War determines who's left.

June 1, 2006

Re: svrapi: add stub implementation

by Vitaly Lipatov

On Wednesday 31 May 2006 17:36, Robert Shearman wrote: > Vitaly Lipatov wrote: > >svrapi.dll is exist on Win9X OS and used in some programs. > > What programs? Is it still used even with the winver set to > win2k? Some accounting program called BEST in Russia. No it used only with winver set to win95/win98, but we may not use win2k winver now. P.S. I will review svrapi patch according to notes about getuname from Alexandre and you. -- Lav Vitaly Lipatov Saint-Petersburg, Etersoft www.etersoft.ru GNU! ALT Linux Team! WINE! LaTeX! LyX!

June 1, 2006

Re: Quartz driver

by Steven Edwards

Hi, On 5/31/06, Emmanuel Maillard <mahanuu(a)opendarwin.org> wrote: > Winemine is playable on both PPC and x86 but it look fine only on > PPC, x86 driver suffer strange rendering bugs. > > See wiki for building the driver : http://wiki.opendarwin.org/ > index.php/Darwine:quartzdrv > I will update wiki soon with issues and todo for Quartz driver. Very nice. This is much further along than I expected. Your work is really amazing. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

June 1, 2006