June 2006 - Wine-Devel - list.winehq.org

Re: winspool.drv: Write-strings warnings fix

by Detlef Riekenberg

Andrew Talbot wrote: > Changelog: > winspool.drv: Write-strings warnings fix. The touched parts should call the UNICODE-Functions instead of the ANSI-Functions. That's on my ToDo-List, but after the Port-Functions are fixed. Many tests for the affected Functions also needs to come before the touched Parts will be updated again. I'm ok with this Patch. -- By By ... ... Detlef

June 30, 2006

Re: mapi32: Replace CRITICAL_SECTION by RTL_CRITICAL_SECTION.

by Robert Shearman

Hervé Poussineau wrote: >Replace CRITICAL_SECTION by RTL_CRITICAL_SECTION, according to prototype of >RtlEnterCriticalSection and others. > It would be better to fix the file to use the kernel32 critical section functions instead of the ntdll ones. -- Rob Shearman

June 30, 2006

Re: [PATCH 10/11] server: add calls to get/set menu item info

by Robert Shearman

Thomas Kho wrote: > On 6/30/06, Robert Shearman <rob(a)codeweavers.com> wrote: > >> Thomas, can you regenerate this patch using "void *" for bmpitem (or >> perhaps add a new gdi_handle_t type)? > > > I'll add the gdi_handle_t type and resubmit two patches (I caught > another use in the menu struct). As others have said, GDI objects are not shared between processes. GDI objects are DCs, regions, bitmaps, palettes, fonts, and brushes. I assumed that they were shared, because icons are shared, but they are a user32 object. You'll have to write a test to see whether Windows allows you to retrieve and use the bitmap for a menu from another process. -- Rob Shearman

June 30, 2006

Re: [PATCH 10/11] server: add calls to get/set menu item info

by Thomas Kho

On 6/30/06, Robert Shearman <rob(a)codeweavers.com> wrote: > Thomas, can you regenerate this patch using "void *" for bmpitem (or > perhaps add a new gdi_handle_t type)? I'll add the gdi_handle_t type and resubmit two patches (I caught another use in the menu struct). Tommy

June 30, 2006

Re: [AppDb] [Resend] prefix all GPC variables

by Chris Morgan

There are several issues that I've found so far in this patch. It appears that you used a search and replace. You'll need to go through EVERY line of the patch and undo the changes to things like sql queries and others where the changes don't make sense. At some point we can discuss altering tables to match our internal variable scheme but we should wait until the php part of the patch is complete. Chris On Friday 30 June 2006 3:31 am, Jonathan Ernst wrote: > Before you ask, there was no possibility to split this one up because > everything is interdependant. > > Please commit it before other patches, it's a pain to rediff it agains head > and fix the conflicts everytime. > > Changelog: > - rename all Get/Post/Cookies variables using type prefixes so that we can > later use the autofiltering function

June 30, 2006

Re: [AppDb] appsubmit fix

by Chris Morgan

Yeah, lets pass the parameters into this function so we can move it around and reuse it without needing a global. Chris On Friday 30 June 2006 7:24 am, Jonathan Ernst wrote: > Le jeudi 29 juin 2006 à 12:19 -0400, Chris Morgan a écrit : > > Can we pass the parameters we need into the function instead of using a > > global? > > I don't think it is better. If we just pass it it'll make a copy of the > array. We could also use &$aClean but I don't see why it would be better > too.

June 30, 2006

Re: Wine 0.9.16 and ddraw issues

by Christoph Frick

On Fri, Jun 30, 2006 at 05:11:24PM +0200, Alexander Nicolaysen Sørnes wrote: > ... > fixme:d3d:IWineD3DStateBlockImpl_Release Releasing primary stateblock > ... > fixme:d3d:IWineD3DStateBlockImpl_Release Releasing primary stateblock this are also the last words of Planescape Torment when starting up (black screen, then end right before the menu would appear) -- cu

June 30, 2006

Wine 0.9.16 and ddraw issues

by Alexander Nicolaysen Sørnes

Greetings, I maintain several ddraw apps in the Application Database. While most of the problems introduced by Wine 0.9.16 have been fixed, some still remain. Command & Conquer and C&C: Red Alert When exiting the game, a messagebox displays: 'Unregonized Direct Draw result code: 1' A demo of Red Alert is available here: http://appdb.winehq.org/appview.php?versionId=4026 These two games, along with 'Warlords IIII: Darklords Rising' also have a strange SMP problem. In earlier Wine versions, these games would stop redrawing at some point. This also happens in Wine 0.9.16, but sometimes an error message is displayed instead, and then Wine receives a page fault. Emperor: Battle for Dune This game requires native d3drm.dll, which does not work anymore. Problems with this file was mentioned on this list a few days ago. Heroes of Might and Magic IV This game now displays a File menu when run in full-screen, which it is only supposed to do when run in a window. If I change the game's resolution, the menu disappears, but if I change it back to the resolution it had when it was started, the File menu is displayed again. Because of this menu, the game window is moved downwards, so the bottom part of the game is not displayed. Warcraft II Battle.net Edition The title screen is no longer displayed; it shows a black screen instead. This also happens with some of the campaign intro screens. The rest of the game seems to work as before. The new ddraw code fixes redrawing problems in at least a dozen games, and makes some of them faster, so it was a very good thing! :) Regards, Alexander N. Sørnes

June 30, 2006

Re: [PATCH 10/11] server: add calls to get/set menu item info

by Dmitry Timoshkov

"Robert Shearman" <rob(a)codeweavers.com> wrote: > You can pass HBITMAPs between processes on Windows, although you are > correct in saying that they aren't user handles. Of course, passing > bitmap handles between processes on Wine won't work yet. Feng Yuan's book claims that while GDI handles are kernel objects Windows kernel doesn't allow them to work across process boundaries. My tests confirm that. -- Dmitry.

June 30, 2006

Re: Debugging string comparison problem

by Juan Lang

> I think the bug is here. Using SysAllocString instead of > SysAllocStringLen I get: > > VarBstrCmp returns 1 > CompareStringW returns 2 Using SysAllocString, I get that the length of each string is 0. So yeah, they'd be equal. So, I'm back to where I started: in Windows, these are different characters, but in Wine they're not. How do I fix it? --Juan

June 30, 2006