August 2006 - Wine-Devel - list.winehq.org

Temporary Git tree available

by Mike McCormack

Hi All, As Alexandre has gone on holidays for a week, I've made available a temporary Git tree containing most patches sent to wine-patches. You can pull my branch into your existing Git checkout as follows: git fetch http://mandoo.dyndns.org/wine.git master:mmbranch git rebase mmbranch If you have an existing mmbranch, you probably want to delete it using: git branch -d mmbranch Mike $ git log origin.. commit 5d6e51717f24a594d793e8fde930a4a28df37ef0 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 17:19:21 2006 -0700 widl: Remove obsolete handling of typedefs commit f5fc2d59c121d13fe86d13d21c02ec6c6ba29eef Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:29:06 2006 -0700 widl: Generate an error for "int f(void a)" commit c0299c2b3e6c1fa4e14feeab1723ca7c545e9699 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:28:05 2006 -0700 widl: Print pointers using better style commit 41f540217f9bd03819be3f6154c03c06d98ec031 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:27:27 2006 -0700 widl: Add an is_ptr function commit e20f80716e8b352d72a1d86381d1f405e58ee19e Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:26:43 2006 -0700 widl: Factor the entry_t structure commit cd0ee17b195070962f97c5ac16b73dfd37e63620 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:26:03 2006 -0700 widl: Represent typedefs with easier to use structures commit 52ad5914edf8169610cb20ed20de6c2ec21869b4 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:25:19 2006 -0700 widl: Generate names for tagless structs, unions and enums commit e6bde7d70b930e37079faa46a340b206e1276933 Author: Paul Vriens <Paul.Vriens(a)xs4all.nl> Date: Tue Aug 29 17:57:35 2006 +0200 wintrust: Add some extra tests for WintrustRemoveActionID commit 13651132d7337f90d6d0b403261e5e30bc35a04d Author: James Hawkins <truiken(a)gmail.com> Date: Tue Aug 29 15:12:39 2006 -0700 advpack: Add the regsvr action to the SetupInstallFromInfSection call commit 6d26805474edc8bbdd201fdeb070e766e3102485 Author: James Hawkins <truiken(a)gmail.com> Date: Tue Aug 29 15:12:22 2006 -0700 advpack: Get the proper working directory in install_init commit e090dee9838d5dcfcc73464e7427f075e7d19bdc Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Tue Aug 29 16:58:49 2006 +0200 opengl32: import glx makecurrent/wglsharelists commit 8d410088146faa56701c440daa4ae350985feff9 Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Tue Aug 29 16:56:57 2006 +0200 opengl32: import glx context code commit e012ffe349a279b939a7b49f7439dd1cd1cd901e Author: Benjamin Arai <me(a)benjaminarai.com> Date: Tue Aug 29 17:51:27 2006 -0700 oleaut32: Test for correct error codes and return type for VarAnd commit 4dec3ee04b237a615bf0eb228c3b343ea537a6ca Author: Benjamin Arai <me(a)benjaminarai.com> Date: Tue Aug 29 17:50:05 2006 -0700 oleaut32: Updates variant:VarAnd to pass all failures exposed from conformance test commit 9e1fa3f6afb808eb0750404180ec7ff30c0a4db0 Author: Benjamin Arai <me(a)benjaminarai.com> Date: Tue Aug 29 17:49:29 2006 -0700 oleaut32: Conformance test for vartest:VarAnd checks for correct result values commit 75d7a735bc4447d099968b78b08de8cc7db8ebe2 Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Aug 29 21:46:49 2006 +0200 wined3d: Avoid wasting a uniform commit 4056ee5dae9ce52b94f518a850c13dfee478e56d Author: Robert Reif <reif(a)earthlink.net> Date: Tue Aug 29 19:34:31 2006 -0400 advapi32: fix lsa tests on windows98 commit b09802de14406bf2a358c256f2b186e15efde08d Author: mike <mike(a)codeweavers.com> Date: Wed Aug 30 12:55:27 2006 +0900 ddraw: Make tests pass when OpenGL libraries aren't present. commit 835596de7066b84a88f6182d4fab4dda1832456a Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Tue Aug 29 23:12:16 2006 +0100 comctl32: Cast-qual warnings fix commit b40c568d9215e906ca1521197fd3060c75fb6e5a Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:16:44 2006 +0100 rpcrt4: Make the reference counting in the standard proxy thread-safe. commit 5bf357288caf3b5eb5766d6bcade4f49fbd80084 Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:14:42 2006 +0100 rpcrt4: Fix NdrStubGetBuffer to use the IRpcChannelBuffer object since IRpcChannelBuffer_GetBuffer may put extra data onto the wire for ORPC calls. commit d63bda52650573e7ec62ca3fae707a231cfbbc6c Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:14:05 2006 +0100 rpcrt4: Remove some unused code. commit e888c667006107145f719537f3a169b797720cfd Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:12:42 2006 +0100 rpcrt4: Move NdrStub* functions to cstub.c and move NdrProxy* functions to cproxy.c since both sets of functions depend on the implementations of the standard stubs and proxies. commit 0879b1e305e4ad329f35c22d97a4765ea54be3c9 Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:12:16 2006 +0100 oleaut32: Delay the creation of the stub object for IDispatch until it is actually used. commit 337f886bab59f5fd7ab22d74ae3c712b593bd1e6 Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:11:12 2006 +0100 oleaut32: Fix a leak of the module reference count. commit d77bea6f8c896304a809e0b9834b1b52072a1901 Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Tue Aug 29 20:12:39 2006 +0100 advpack: Cast-qual warnings fix commit 206411e8032c25f82f738cf065cb2497aa63d96f Author: Paul Vriens <Paul.Vriens(a)xs4all.nl> Date: Tue Aug 29 19:33:00 2006 +0200 wintrust: Add some documentation commit 91a8502d1dcb65509128c602211b87d05aec8e6d Author: Renu Rajput <renu.rajput(a)gmail.com> Date: Tue Aug 29 13:50:16 2006 +0530 comdlg32: Send missing CDN_FOLDERCHANGE

Aug. 30, 2006

Re: wine's fullscreen code has no effect on metacity

by Dmitry Timoshkov

"Elijah Newren" <newren(a)gmail.com> wrote: > Ugh. Apparently, I busted our fullscreen handling in metacity>=2.14.x > in lots of cases in addition to problems we've being talking about in > this thread. See http://bugzilla.gnome.org/show_bug.cgi?id=343115#c6 > if you're curious. Anyway, I think I've fixed all those issues, and I > believe my fixes should cover this last issue of yours (making windows > return to the original size correctly). Is there any chance I could > get you test (with metacity 2.15.34) and verify? (You could also > backport the patch from bug 343115...) Since I'm on FC4 I can't test latest Metacity releases because it requires newer GTK, and backporting is not really possible since version 2.10 provided with FC4 is too different from 2.15.x series. -- Dmitry.

Aug. 30, 2006

Re: [wintrust] Add framework and initial tests (resend)

by Mike McCormack

Paul Vriens wrote: > configure | 3 - > configure.ac | 1 > dlls/Makefile.in | 1 > dlls/wintrust/tests/Makefile.in | 13 +++ > dlls/wintrust/tests/register.c | 176 +++++++++++++++++++++++++++++++++++++++ > programs/winetest/Makefile.in | 3 + You only need to send changes for dlls/wintrust/tests. Other files are updated automatically by scripts (eg. autoconf, dlls/make_dlls, programs/make_tests). Mike

Aug. 30, 2006

Re: [TRY 3] Add support for tooltips for system tray icons

by Mike McCormack

James Liggett wrote: > + if (!list_head(&tray.icons)) > + { > + INITCOMMONCONTROLSEX init_tooltip; > + > + init_tooltip.dwSize = sizeof(INITCOMMONCONTROLSEX); > + init_tooltip.dwICC = ICC_TAB_CLASSES; > + > + InitCommonControlsEx(&init_tooltip); Shouldn't you only initialize comctl32 once, rather than every time there's no icons and we add one? Mike

Aug. 30, 2006

Re: Does WIDL support include <xxx.idl>

by Vijay Kiran Kamuju

It would be gr8 if you could check with MIDL and WIDL the output of msxml.idl On 8/29/06, Dan Hipschman <dsh(a)linux.ucla.edu> wrote: > On Tue, Aug 29, 2006 at 08:45:17PM -0400, Vijay Kiran Kamuju wrote: > > But when i see the generated header file. I see that there is the > > expansion of interfaces defined in the foo.idl if we include it in > > foobar.idl > > eg: foobar.idl > > #include "foo.idl" > > > > For further reference see the msxml.idl in the PSDK headers. > > it includes xmldom.idl and xmldso.idl, but in the msxml.h we see all > > the declarations in xmldso.h and xmldom.h > > > > I dont know they(M$) generate msxml.h from msxml.idl > > I might not understand your question. If you don't want to #include > the idl file, you could use 'import "foo.idl";' which will process the > IDL file but just plop a #include "foo.h" in the generated header file. > If that's not what you're looking for, maybe consider cpp_quote to copy > code directly to the header. I don't have a windows machine with me > at the moment to look at the PSDK files. I can take a look at them > tomorrow and see how WIDL's output differs from MIDL's. >

Aug. 30, 2006

Re: Does WIDL support include <xxx.idl>

by Dan Hipschman

On Tue, Aug 29, 2006 at 08:45:17PM -0400, Vijay Kiran Kamuju wrote: > But when i see the generated header file. I see that there is the > expansion of interfaces defined in the foo.idl if we include it in > foobar.idl > eg: foobar.idl > #include "foo.idl" > > For further reference see the msxml.idl in the PSDK headers. > it includes xmldom.idl and xmldso.idl, but in the msxml.h we see all > the declarations in xmldso.h and xmldom.h > > I dont know they(M$) generate msxml.h from msxml.idl I might not understand your question. If you don't want to #include the idl file, you could use 'import "foo.idl";' which will process the IDL file but just plop a #include "foo.h" in the generated header file. If that's not what you're looking for, maybe consider cpp_quote to copy code directly to the header. I don't have a windows machine with me at the moment to look at the PSDK files. I can take a look at them tomorrow and see how WIDL's output differs from MIDL's.

Aug. 30, 2006

Re: Does WIDL support include <xxx.idl>

by Vijay Kiran Kamuju

But when i see the generated header file. I see that there is the expansion of interfaces defined in the foo.idl if we include it in foobar.idl eg: foobar.idl #include "foo.idl" For further reference see the msxml.idl in the PSDK headers. it includes xmldom.idl and xmldso.idl, but in the msxml.h we see all the declarations in xmldso.h and xmldom.h I dont know they(M$) generate msxml.h from msxml.idl On 8/29/06, Dan Hipschman <dsh(a)linux.ucla.edu> wrote: > On Tue, Aug 29, 2006 at 05:53:20PM -0400, Vijay Kiran Kamuju wrote: > > I am cleaning up msxml*.idl files. > > It seems that msxml.idl and msxml2.idl are incompatible. > > msxml.idl includes xmldso.idl and xmldom.idl (eg: include "xmldso.idl") > > where as msxml2.idl explicitly declares the interface defined by > > xmldso.idl and xmldom.idl. > > This is done so that we there would be no clashes beteen msxml2.0 and > > msxml3.0 implementation. > > As in msxml2.0 and msxml3.0 there were some GUID changes. > > Does MIDL put the expansion of the included idl file. > > ie, in a.idl we have a line include "b.idl" > > what i want ask is does a.h will contain all the contents of b.h(b.h > > is output when we run midl on b.idl) when we run midl on a.idl. > > > > I want to generalize the msxml implementation. > > Sure, it runs a C-style preprocessor on it, so #include should work. > Just note that #include <foo.idl> will look for foo.idl in predefined > locations, while #include "foo.idl" will look in those and the current > directory. You can add to the list of locations that #include <foo.idl> > will look with the usual "widl -I/dir1 -I/dir2 ..." syntax. >

Aug. 30, 2006

Re: Does WIDL support include <xxx.idl>

by Dan Hipschman

On Tue, Aug 29, 2006 at 05:53:20PM -0400, Vijay Kiran Kamuju wrote: > I am cleaning up msxml*.idl files. > It seems that msxml.idl and msxml2.idl are incompatible. > msxml.idl includes xmldso.idl and xmldom.idl (eg: include "xmldso.idl") > where as msxml2.idl explicitly declares the interface defined by > xmldso.idl and xmldom.idl. > This is done so that we there would be no clashes beteen msxml2.0 and > msxml3.0 implementation. > As in msxml2.0 and msxml3.0 there were some GUID changes. > Does MIDL put the expansion of the included idl file. > ie, in a.idl we have a line include "b.idl" > what i want ask is does a.h will contain all the contents of b.h(b.h > is output when we run midl on b.idl) when we run midl on a.idl. > > I want to generalize the msxml implementation. Sure, it runs a C-style preprocessor on it, so #include should work. Just note that #include <foo.idl> will look for foo.idl in predefined locations, while #include "foo.idl" will look in those and the current directory. You can add to the list of locations that #include <foo.idl> will look with the usual "widl -I/dir1 -I/dir2 ..." syntax.

Aug. 29, 2006

Does WIDL support include <xxx.idl>

by Vijay Kiran Kamuju

Hi, I am cleaning up msxml*.idl files. It seems that msxml.idl and msxml2.idl are incompatible. msxml.idl includes xmldso.idl and xmldom.idl (eg: include "xmldso.idl") where as msxml2.idl explicitly declares the interface defined by xmldso.idl and xmldom.idl. This is done so that we there would be no clashes beteen msxml2.0 and msxml3.0 implementation. As in msxml2.0 and msxml3.0 there were some GUID changes. Does MIDL put the expansion of the included idl file. ie, in a.idl we have a line include "b.idl" what i want ask is does a.h will contain all the contents of b.h(b.h is output when we run midl on b.idl) when we run midl on a.idl. I want to generalize the msxml implementation. Thanks, VJ

Aug. 29, 2006

Re: widl [2/6]: Handle more pointer types in write_type

by Dan Hipschman

On Tue, Aug 29, 2006 at 01:54:23PM +0100, Robert Shearman wrote: > I see from a couple of patches back that you intend to move the > representation of pointers out of the var_t type. How do you intend to > represent "char **" for example? > type: FC_RP, ref: { type: FC_RP, ref: { type: FC_CHAR } } > or: > type: FC_CHAR, ptr_level: 2 > > It seems to me you're going down the first route (and there's nothing > wrong with that as far as I can see). I'm just interested to know which > approach you are taking. I think the first approach leads to more natural recursion, so that's what I was shooting for. It may take up more memory, but that's likely to be insignificant. There are three things I'd like to change with widl, just so you know where I'm at: 1. Defining typedef'd types as those having the type field equal zero and ref field non-null. It leads to too much special case handling. That's what my last series of patches aims to solve. 2. Remove ptr_level from var_t and just have its type represent pointers. This would, again, eliminate the need for some special case code and allow types to be processed in a more natural, recursive (or iterative) way. 3. Remove tname from var_t. If a type has a name, why not just attach it to the type instead of the variable. I haven't looked into this in any depth, so I may be missing the need for it, now. I wanted to solve the first problem because it was hindering the work I was doing getting widl to generate a proxy file for oaidl. The other two I was going to hold off doing anything about until I had completed the work on the proxy code (unless they turned out to be necessary for that). I don't want to spend all my time making design changes. It's subjective and it's more important to fix actual bugs, which is what I'd like to be doing.

Aug. 29, 2006