September 2006 - Wine-Devel

Re: dlls/user/tests/win.c fix

by Juan Lang

> No it's not correct. Does the attached patch fix the failure? Not sure. I get a similar failure on an earlier line: win.c:2508: Test failed: message 0200 available This is the repeated failure after rerunning the tests several times to get past earlier intermittent failures. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

Sept. 30, 2006

Re: [PATCH] local fixes in ioctl for google video.

by Dmitry Timoshkov

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: > @@ -2125,6 +2125,13 @@ INT WINAPI WSAIoctl(SOCKET s, > > switch( dwIoControlCode ) > { > + case 0x8004667E: > + FIXME("8004667E: stub!\n"); > + break; > + case 0x4004667f: /* FIONREAD */ > + FIXME("4004667f/FIONREAD: stub, returning 1!\n"); > + *(DWORD*)lpbOutBuffer = 1; > + break; 0x8004667e is FIONBIO (set or clear non-blocking I/O). -- Dmitry.

Sept. 30, 2006

Re: str{n}casecmp(): unrecognized identifier

by Andrew Talbot

Dmitry Timoshkov wrote: > str[n]casecmp should be used only to compare strings received from an > underlying system, in all other cases win32 API lstrcmp[i]A should be > used instead, otherwise bad side effects could arise due to using wrong > locale. > I see. I would mention that, currently, there are about forty-two places in the dll files where one or other of these functions is used. (I don't know about the programs, tools or dll/tests directories.) Thanks, -- Andy.

Sept. 30, 2006

Re: todo_wine problems

by Dmitry Timoshkov

"Jeff L" <lats(a)yless4u.com.au> wrote: > I am having trouble with getting todo_wine working. It seems to be > ignored and the test is being executed on wine and failing as expected. > Is there a trick to setting todo up? > > According to all the examples and the text this should work: > todo_wine > { > ok(hr == S_OK, "ScriptStringOut Stub should return S_OK not > %08lx\n", hr); > } It depends how do you run the test. If you run the test directly using something like 'wine dlls/kernel32/tests/kernel32_test.exe.so', then the tests in the todo_wine blocks will fail because the platform (wine) is not specified. The switch '-P wine' specifies a Wine platform, and todo_wine will work properly. Hopefully I correctly understood the problem :-) -- Dmitry.

Sept. 30, 2006

Re: str{n}casecmp(): unrecognized identifier

by Dmitry Timoshkov

"Andrew Talbot" <Andrew.Talbot(a)talbotville.com> wrote: > It seems that, on my [x86_64] system, at least, string.h is not being > included in the files where strcasecmp() or strncasecmp() is used (for > example, in crypt32/oid.c), despite HAVE_STRCASECMP and HAVE_STRNCASECMP > being defined as 1. str[n]casecmp should be used only to compare strings received from an underlying system, in all other cases win32 API lstrcmp[i]A should be used instead, otherwise bad side effects could arise due to using wrong locale. -- Dmitry.

Sept. 30, 2006

Re: [PATCH] Use correct headers for strcasecmp

by Mike McCormack

Marcus Meissner wrote: > We need to include string.h and also wine/port.h > to get strcasecmp on platforms where it is missing. In Win32 code, shouldn't we be using lstrcmpi instead? Mike

Sept. 30, 2006

Re: str{n}casecmp(): unrecognized identifier

by Marcus Meissner

On Sat, Sep 30, 2006 at 10:50:27AM +0100, Andrew Talbot wrote: > Hi, > > It seems that, on my [x86_64] system, at least, string.h is not being > included in the files where strcasecmp() or strncasecmp() is used (for > example, in crypt32/oid.c), despite HAVE_STRCASECMP and HAVE_STRNCASECMP > being defined as 1. > > I presume, because of the above defines, that just adding > > #include <string.h> > > ... in the affected files would not be a proper fix. I imagine it requires > expert tweaking of the automake setup (or whatever) to ensure that this is > done automatically (if it's not just a fault on my system), in which case I > ask for suitable help, please. Actually we have to use wine/port.h. I sent in a patch (47545629d62da964293348a905f886162aae4f85). Ciao, Marcus

Sept. 30, 2006

str{n}casecmp(): unrecognized identifier

by Andrew Talbot

Hi, It seems that, on my [x86_64] system, at least, string.h is not being included in the files where strcasecmp() or strncasecmp() is used (for example, in crypt32/oid.c), despite HAVE_STRCASECMP and HAVE_STRNCASECMP being defined as 1. I presume, because of the above defines, that just adding #include <string.h> ... in the affected files would not be a proper fix. I imagine it requires expert tweaking of the automake setup (or whatever) to ensure that this is done automatically (if it's not just a fault on my system), in which case I ask for suitable help, please. Thanks, -- Andy.

Sept. 30, 2006

Re: [Bug 4995] Check for fontforge >= 20060406 as earlier versions fail to build our fonts with catastrophic results.

by Mike McCormack

Sam Dennis wrote: > +if PKG_CHECK_MINVER(fontforge, 20060406); then configure should check for features, not versions. This avoids problems with patched older versions or newer versions with features removed. To check for fontforge correctly, we need to check that it will generate a ttf file that works with Wine. The alternative is to fix up the sfd2ttf that somebody posted a month or two ago and use that so that we don't depend on fontforge. Mike

Sept. 30, 2006

Re: todo_wine problems

by James Hawkins

On 9/30/06, Jeff L <lats(a)yless4u.com.au> wrote: > I am having trouble with getting todo_wine working. It seems to be > ignored and the test is being executed on wine and failing as expected. > Is there a trick to setting todo up? > > According to all the examples and the text this should work: > todo_wine > { > ok(hr == S_OK, "ScriptStringOut Stub should return S_OK not > %08lx\n", hr); > } > todo_wine doesn't stop a test from running, it just makes 'make test' not error out. If you run 'make test' and a test fails and there is no todo_wine around the test, make will stop with an error. -- James Hawkins

Sept. 30, 2006