January 2007 - Wine-Devel - list.winehq.org

Re: Detect screen resolution change errors

by Stefan Dösinger

Am Mittwoch 31 Januar 2007 10:25 schrieb H. Verbeet: > On 30/01/07, Francois Gouget <fgouget(a)codeweavers.com> wrote: > > I have attached the relevant patches. Does this look ok to the DirectX > > gurus? > > At least the wined3d part looks ok to me, although we should probably > be cleaning up the GL context as well, there and in the other places > where we return. For some reason I didn't get the original patch, or I accidentally deleted it(more likely). Note that I have patches to rework the context creation and initialization routines(for easier cleanup). I do not know to what extend we want to catch screen res change failures. The resolution? I'd say yes. Color depth? Propably no because we can't change it anyway. Refresh rate? Don't think its important.

Jan. 31, 2007

Re: Detect screen resolution change errors

by H. Verbeet

On 30/01/07, Francois Gouget <fgouget(a)codeweavers.com> wrote: > I have attached the relevant patches. Does this look ok to the DirectX > gurus? > At least the wined3d part looks ok to me, although we should probably be cleaning up the GL context as well, there and in the other places where we return.

Jan. 31, 2007

Re: skipping incompatible libwine build problem.

by Robert Shearman

Matthew Watchinski wrote: > Linux ebx 2.6.17-10-generic #2 SMP Tue Dec 5 21:16:35 UTC 2006 x86_64 > GNU/Linux > > ... > wineg++ -mwindows -mno-cygwin -municode -mconsole -o simpleapp.exe.so > simpleapp.o simpleappList.o -lodbc32 -lole32 -loleaut32 -lwinspool > -luuid > /usr/bin/ld: skipping incompatible /usr/local/lib/libwine.so when > searching for -lwine > /usr/bin/ld: skipping incompatible /usr/local/lib/libwine.so when > searching for -lwine > /usr/bin/ld: skipping incompatible /usr/local/lib/libwine.so when > searching for -lwine > /usr/bin/ld: cannot find -lwine > collect2: ld returned 1 exit status > winegcc: g++ failed. > make: *** [simpleapp.exe.so] Error 2 > > ... > The only lines I've modified from the original winemaker Makefile are these: > > CXXFLAGS = -Wall -Wextra -Wwrite-strings -Wcast-align > -Wsign-compare -pedantic -m32 > #CXXFLAGS = > CEXTRA = -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w > CXXEXTRA = -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w > RCEXTRA = > INCLUDE_PATH = > > simpleapp_exe_LDFLAGS = -mwindows \ > -mno-cygwin \ > -municode \ > -mconsole > > I assume I'm missing some magic ld switch, but I'm not sure what. Can > anyone point me in the right direction? > The CXXFLAGS you specified aren't getting used. Can you send the entire makefile? -- Rob Shearman

Jan. 31, 2007

Re: Patch for Bugzilla Bug 6323

by Dean Kusler

On Tuesday 30 January 2007 11:28:23 pm Dmitry Timoshkov wrote: > "Dean Kusler" <deankus(a)gmail.com> wrote: > > In dlls/winex11.drv/keyboard.c, XmbLookupString was being called with > > KeyRelease events, which has undefined behavior (in this case, it fails > > to return a valid keysym for numpad key releases). By instead calling > > XLookupString in the case of a KeyRelease, we can obtain a valid keysym. > > While reviewing your patch in bugzilla I overlooked that you have added > a check for (e.type == KeyPress) X11DRV_ToUnicodeEx as well. There is no > need for that, we explicitly set e.type = KeyPress there. Fair enough - I just did a quick search for all instances of XmbLookupString, 'cause I was really getting tired of playing WoW without numpad key bindings. :-)

Jan. 31, 2007

Re: Patch for Bugzilla Bug 6323

by Dmitry Timoshkov

"Dean Kusler" <deankus(a)gmail.com> wrote: > In dlls/winex11.drv/keyboard.c, XmbLookupString was being called with > KeyRelease events, which has undefined behavior (in this case, it fails to > return a valid keysym for numpad key releases). By instead calling > XLookupString in the case of a KeyRelease, we can obtain a valid keysym. While reviewing your patch in bugzilla I overlooked that you have added a check for (e.type == KeyPress) X11DRV_ToUnicodeEx as well. There is no need for that, we explicitly set e.type = KeyPress there. -- Dmitry.

Jan. 31, 2007

Re: Test for LoadString

by Dmitry Timoshkov

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Add tests for LoadString, completed on Windows. > > As I see, > 1. LoadStringA with buf = NULL segfaults in Windows, we have to produce ERR > message instead > 2. LoadStringA with buf = NULL, buflen = 0 returns -1 > 3. LoadStringW with some buf, buflen = 0 returns length of the resource string > and puts some strange chars (F%O f.i.) in the buffer. > 4. LoadStringW with buf = NULL, buflen!=0 returns 0 > 5. LoadStringA/W segfaults on negative buflen Unfortunately the tests don't show whether last error value should be set in the case of a failure or not, please add that as well. -- Dmitry.

Jan. 31, 2007

skipping incompatible libwine build problem.

by Matthew Watchinski

Hopefully this is the right mailing list to ask this. If not please point me to the correct list. I have a simple application that use to build just fine using libwine/wine-0.9.30 on ubuntu edgy 32-bit. I just upgraded to a 64 bit system and got wine-0.9.30 installed and working, however, now my application doesn't build. uname -a: Linux ebx 2.6.17-10-generic #2 SMP Tue Dec 5 21:16:35 UTC 2006 x86_64 GNU/Linux When i run make everything builds correctly but it won't link and it exits as follows: wineg++ -c -Wall -Wextra -Wwrite-strings -Wcast-align -Wsign-compare -pedantic -m32 -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w -DCOMMAND_LINE -DWINDOWSNATIVE -DBUILD_CLI -o simpleapp.o simpleapp.cpp wineg++ -c -Wall -Wextra -Wwrite-strings -Wcast-align -Wsign-compare -pedantic -m32 -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w -DCOMMAND_LINE -DWINDOWSNATIVE -DBUILD_CLI -o simpleappList.o simpleappList.cpp wineg++ -mwindows -mno-cygwin -municode -mconsole -o simpleapp.exe.so simpleapp.o simpleappList.o -lodbc32 -lole32 -loleaut32 -lwinspool -luuid /usr/bin/ld: skipping incompatible /usr/local/lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/local/lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/local/lib/libwine.so when searching for -lwine /usr/bin/ld: cannot find -lwine collect2: ld returned 1 exit status winegcc: g++ failed. make: *** [simpleapp.exe.so] Error 2 Everything in /usr/local/lib looks right to me. ebx:~/Downloads/cvs/sfeng/research/tools/doccheck$ file /usr/local/lib/libwine.so* /usr/local/lib/libwine.so: symbolic link to `libwine.so.1.0' /usr/local/lib/libwine.so.1: symbolic link to `libwine.so.1.0' /usr/local/lib/libwine.so.1.0: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), not stripped And the makefile is pretty simple The only lines I've modified from the original winemaker Makefile are these: CXXFLAGS = -Wall -Wextra -Wwrite-strings -Wcast-align -Wsign-compare -pedantic -m32 #CXXFLAGS = CEXTRA = -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w CXXEXTRA = -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w RCEXTRA = INCLUDE_PATH = simpleapp_exe_LDFLAGS = -mwindows \ -mno-cygwin \ -municode \ -mconsole I assume I'm missing some magic ld switch, but I'm not sure what. Can anyone point me in the right direction? Thanks -matt

Jan. 30, 2007

Re: Do not use LoadStringW for get strlen of resource string

by James Hawkins

On 1/30/07, Vitaly Lipatov <lav(a)etersoft.ru> wrote: > As LoadStringW(...NULL,0) returns length of resource string only in Wine, > rewrote this part in independent manner. > > Changelog: > - do not use LoadStringW for get strlen of resource string > This is wrong: > @@ -75,15 +75,16 @@ static LPWSTR HH_ANSIToUnicode(LPCSTR an > /* Loads a string from the resource file */ > static LPWSTR HH_LoadString(DWORD dwID) > { > - LPWSTR string = NULL; > + WCHAR buf[1024]; > + LPWSTR string; > int iSize; > > - iSize = LoadStringW(hhctrl_hinstance, dwID, NULL, 0); > + iSize = LoadStringW(hhctrl_hinstance, dwID, buf, sizeof(buf)/sizeof(buf[0])); > iSize += 2; /* some strings (tab text) needs double-null termination */ > > string = HeapAlloc(GetProcessHeap(), 0, iSize * sizeof(WCHAR)); > LoadStringW(hhctrl_hinstance, dwID, string, iSize); > - > + string[iSize] = 0; /* add second null termination */ > return string; > } Why are you adding string[iSize] = 0...? This is an internal wrapper around LoadString that makes no promises about double-null termination, etc. Don't make assumptions. Also, you need to keep the style of the original code when making changes. There was an empty line where you added the aforementioned pieced of code, and that empty line separates logically different pieces of the function. 1024 is a magic number and it needs to go. You're putting a limitation of 1024 length on HH_LoadString that didn't exist before. -- James Hawkins

Jan. 30, 2007

re: Please help me debug wineserver

by Dan Kegel

Misha wrote: > I am new to wine programming but have a fair amount of > experience with C/C++ programming in general. I have > recently decided to make the Vector NTI application work > on Wine, and after overcoming quite a few installation > difficulties by making an install shell script, Cool. Can you file a bug about those problems, and attach the shell script as a workaround? > I have run in to a problem that I have traced down to > wineserver. This problem occurs after repeatedly changing > folders in the Vector NTI "Open Molecule File" dialog, > which does not use the standard open file Windows dialog > (e.g., the "Open Shortcut" dialog in the same program works > fine). Wineserver crashes with the following error message: > > wineserver: object.c:274: release_object: Assertion `obj->refcount' failed. You also have a bug opened for this, http://bugs.winehq.org/show_bug.cgi?id=7286 I see you also have a possible workaround there. > On looking at the output of WINEDEBUG=+server, it seems > that the "Vector NTI" thread is woken up, and then receives > a USER_APC, at which time this crash occurs. What version of Wine? There were recent changes in APC handling in wine-0.9.30 (and perhaps 0.9.29) that may have broken this. If you can verify that this worked ok in earlier versions like 0.9.27, that would help. Alexandre is the expert on this. He's on vacation but he'll want to take a look when he gets back. - Dan

Jan. 30, 2007

Re: [PATCH 7/7] server/kernel32: Marshal security descriptor to server for a new process.

by Vitaliy Margolen

Mirek wrote: > Hi, i cant compile wine with this patch, do you know why? > You need to run `tools/make_requests`. All patches to wineserver sent to wine-patches don't have auto-generated parts. Vitaliy.

Jan. 30, 2007