January 2007 - Wine-Devel - list.winehq.org

Re: DirectPlay should initialize The session guid when creating a session

by Kai Blin

On Sunday 28 January 2007 20:38, Tomas Carnecky wrote: > > From Microsoft DirectX SDK Documentation it seems that directplay should > > initialize the instance guid on session creation, this trivial patch does > > that. > > Two questions: > > 1. Does windows do this, too? You can't rely on the MS SDK > Documentation, always look what windows does and do it likewise. In many > cases, a wine test should be written to verify the behavior. > > 2. Does it solve anything? A bug, a problem with an application? Right now, it doesn't, as Wine doesn't _have_ a working DirectPlay implementation. However, Alessandro contacted me some time ago and was interested in starting to implement it. As I'm still busy working on figuring out the wire protocol used for dplay, I didn't get around to look at the programming side of things much. Alex, what are you currently trying to do? I figure it would make sense to kill the needed dll overrides for dplay dlls one by one, dplayx.dll might be a good start to do so. I'll be happy to help you with writing a test case for your current patch. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

Jan. 29, 2007

Wine study

by TRENY Simon

Hello guys :) We are a team of French students (at ENSEIRB, an engineering school in Bordeaux), and we are studying the Wine project as an example of open source project. We'd like to find out more about how things work from the inside, from any developer's point of view. So we have compiled here our main questions for those who are willing to help us.. Feel free to answer further than the actual question, we are looking for a real insight! :) Sorry in advance for those who are not interested, you can just skip this mail ;) -First, what is the nick under which u commit ? -What is your role in the Wine project? -Which country do u code from? -Who are the programmers you consider to be the "core" of the project? -Who are those you actually ask for help when you need some (e.g. about compatibility issues)? -Do you use means of communicating with the rest of the devs other than irc and the mailing lists? Do you find it (irc and MLs) entirely suited to your needs? -When there is a decision concerning the whole team you wish to see taken, how do u see to that? -Have you developed links with some devs that go beyond working on the same project? -How much time do you spend doing Wine developing (per week and per day, depending on the day)? -What do you do aside from Wine? -When, why and how did you join the Wine project? -Is there any recurrent problem you find to be responsible of unnecessary extra work/loss of time for you or the team? Well, thanks for reading, and greater thanks for answering us if you do.. :) Best regards

Jan. 29, 2007

Re: Test case for Bug 50 [Was: Bug 50]

by Pedro Araujo Chaves Jr.

I've just finished writing a test case for Bug 50, but I'm missing *a single thing* that prevents it from working under Windows: I still don't know how to get the width of the text output by ExtTextOutW(). MSDN isn't helping much, and I haven't found the optimal Google query yet... ;-) Would anybody out there have a clue? I'm ready to submit patch and test, but without that info, I can't... Thanks in advance! - Pedro.

Jan. 29, 2007

Another report of malware running on Wine

by Dan Kegel

A user reports that a trojan horse runs ok on wine, and indeed it had him fooled (right up to the point where it popped up a window offering to optimize his registry, anyway): http://www.postproductie.nl/?p=9

Jan. 29, 2007

kernel32: allow profile section and key names of zero length

by Claudio Fontana

Hello, following up on the profile changes started on this thread: http://www.winehq.org/pipermail/wine-devel/2006-December/053009.html I tried a patch in git format made against latest. First attempt at using git, that is. dlls/kernel32/profile.c: allow section and key names of zero length dlls/kernel32/tests/profile.c: add testcases where KEY or SECTION are "". Note: still requires testing on a real Windows 95, to determine if that version behaves differently. If you have access to a Windows 95 installation, please help by applying this patch and: [optional] * run the updated tests in wine (all should pass) * revert changes in dlls/kernel32/profile.c, and run the updated tests in wine (the two new tests should fail) [important] * run the updated test program under a real Windows 95. If tests pass, then Windows 95 behaves exactly the same as later versions. If tests do not pass, then Windows 95 is indeed different, and this patch should be modified accordingly. --- dlls/kernel32/profile.c | 10 ++-------- dlls/kernel32/tests/profile.c | 8 ++++++-- 2 files changed, 8 insertions(+), 10 deletions(-)

Jan. 29, 2007

Re: Vacations

by Francois Gouget

On Fri, 26 Jan 2007, Andreas Mohr wrote: [...] > On Fri, Jan 26, 2007 at 03:38:26PM +0100, Alexandre Julliard wrote: > > Now all I need is some snow... > > Nothing easier than that, just get back to Europe, we're drowning in it... ;) Heh, that's the problem with living in Switzerland. It's not in Europe so they don't have snow when we do. Though what I heard is that until very recently there was really not much snow in France either. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Demander si un ordinateur peut penser revient à demander si un sous-marin peut nager.

Jan. 28, 2007

Re: DirectPlay should initialize The session guid when creating a session

by Tomas Carnecky

Alessandro Pignotti wrote: > Hi, > this is my first patch i hope it's well formatted formating is good. > From Microsoft DirectX SDK Documentation it seems that directplay should > initialize the instance guid on session creation, this trivial patch does > that. Two questions: 1. Does windows do this, too? You can't rely on the MS SDK Documentation, always look what windows does and do it likewise. In many cases, a wine test should be written to verify the behavior. 2. Does it solve anything? A bug, a problem with an application? tom

Jan. 28, 2007

Re: USER32: resource.c: add LoadStringW description

by Dmitry Timoshkov

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Changelog: > Add description for LoadStringW > + * Can be called with buffer = NULL for get size of the requested string That LoadString behaviour in Wine has been questioned already, MSDN keeps silence about that, it needs at least a test case. -- Dmitry.

Jan. 27, 2007

Re: [cmd][buildins] Change output resource strings for correctlydisplayed

by Dmitry Timoshkov

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > --- programs/cmd/builtins.c 23 Jan 2007 12:20:55 -0000 1.5 > +++ programs/cmd/builtins.c 26 Jan 2007 09:23:05 -0000 > @@ -44,6 +44,13 @@ struct env_stack > WCHAR *strings; > }; > > +static inline unsigned int strlenW( const WCHAR *str ) > +{ > + const WCHAR *s = str; > + while (*s) s++; > + return s - str; > +} Please use normal lstrlenW instead of introducing a handmade version. -- Dmitry.

Jan. 27, 2007

Re: Vacations

by Andreas Mohr

Hi, On Fri, Jan 26, 2007 at 03:38:26PM +0100, Alexandre Julliard wrote: > Now all I need is some snow... Nothing easier than that, just get back to Europe, we're drowning in it... ;) (well, Germany at least, and I'm not even sure how long this rather sizeable amount of snow will actually last) Andreas

Jan. 26, 2007