January 2007 - Wine-Devel - list.winehq.org

Vacations

by Alexandre Julliard

Folks, I'm going skiing for a week, so don't be surprised if there aren't any new commits for a while. Now all I need is some snow... -- Alexandre Julliard julliard(a)winehq.org

Jan. 26, 2007

Re: scroll window fix

by Aric Stewart

Whoop, my bad. I almost always miss that on my first pass. I will correct that and resent. Thanks for pointing it out. -aric Peter Oberndorfer wrote: > On Thursday 25 January 2007 18:56, Aric Stewart wrote: >> finds the case where the scrolling amount exceeds the window but still falls >> within the clipping rect. This generates an additional update region >> that needs >> to be invalidated. >> includes a test > Hi, > I can't argue about the correctness of the patch itself but it adds tabs and a few > trailing spaces. > > Greetings Peter >> --- >> dlls/user32/painting.c | 21 +++++++++++++++++++++ >> dlls/user32/tests/win.c | 9 +++++++++ >> 2 files changed, 30 insertions(+), 0 deletions(-) >> > >

Jan. 26, 2007

Re: [PATCH 1/4] widl: Handle TKIND_DISPATCH when generating MSFT typelibs.

by Huw Davies

On Fri, Jan 26, 2007 at 09:13:52PM +0900, Mike McCormack wrote: > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index 6248c80..576601b 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -126,6 +126,8 @@ typedef struct _msft_typeinfo_t > } msft_typeinfo_t; > > > +static void add_dispinterface_typeinfo(msft_typelib_t *typelib, type_t *dispinterface); Could you move that so it's with all the other forward declarations of add_*_typeinfo funcs (or move all the others to be with this one)? Huw. -- Huw Davies huw(a)codeweavers.com

Jan. 26, 2007

Initial MIDI Out support on Mac OS X

by Emmanuel Maillard

Hi, anything wrong with this patch : http://www.winehq.org/pipermail/wine- patches/2007-January/035027.html thanks Emmanuel

Jan. 26, 2007

Re: Is anyone monitoring Transgaming's changes to the LGPL files?

by Scott Ritchie

On Thu, 2007-01-25 at 19:38 -0500, Gavriel State wrote: > Hi Scott, > > We mostly haven't made many significant changes to the LGPL DLLs that > we've been picking up, other than modifications to allow them to build > within our somewhat different build environment. > > One place where we have made changes recently was to the iphlpapi DLL, > and we recently submitted a patch for that. There have also been a > couple of places in some of the crypto code when we've come across a > bug, worked through it, and made a fix. But at least twice, a patch has > been checked into WineHQ CVS just before we posted our fix. > > We'll certainly be trying to submit patches to LGPLed DLLs that we make > changes to where we can, but if anyone is interested in helping, we're > happy to work with them too. > > Take care, > -Gav Thank you Gav, that was quite helpful. I guess we are in this together after all. On Fri, 2007-01-26 at 10:37 +0900, Mike McCormack wrote: > Scott Ritchie wrote: > > > The simplest thing to do is for someone to just track the code they > > release and diff it against our own stuff, and note if anything new and > > interesting (eg an implementation of a function) comes up. Then send in > > a patch if it seems like it could help us too. But, is anyone doing > > this? > It's really in their best interest to keep current with Wine. > > Continually resolving conflicts and fixing the same bugs we've fixed is > a waste of their time, and monitoring their patches is a waste of our time. That makes a lot of sense. Thanks, Scott Ritchie

Jan. 26, 2007

Re: Is anyone monitoring Transgaming's changes to the LGPL files?

by Mike McCormack

Scott Ritchie wrote: > The simplest thing to do is for someone to just track the code they > release and diff it against our own stuff, and note if anything new and > interesting (eg an implementation of a function) comes up. Then send in > a patch if it seems like it could help us too. But, is anyone doing > this? Why bother? It's really in their best interest to keep current with Wine. Continually resolving conflicts and fixing the same bugs we've fixed is a waste of their time, and monitoring their patches is a waste of our time. The easiest thing for everybody is for original patch authors to submit their patches to wine-patches. If they don't want to do that, it will be harder on them in the long run. Mike

Jan. 26, 2007

Re: Is anyone monitoring Transgaming's changes to the LGPL files?

by Gavriel State

Hi Scott, We mostly haven't made many significant changes to the LGPL DLLs that we've been picking up, other than modifications to allow them to build within our somewhat different build environment. One place where we have made changes recently was to the iphlpapi DLL, and we recently submitted a patch for that. There have also been a couple of places in some of the crypto code when we've come across a bug, worked through it, and made a fix. But at least twice, a patch has been checked into WineHQ CVS just before we posted our fix. We'll certainly be trying to submit patches to LGPLed DLLs that we've made changes to where we can, but if anyone is interested in helping, we're happy to work with them too. Take care, -Gav Scott Ritchie wrote: > I don't know when it started, but Transgaming has been using LGPL chunks > of Wine for quite some time. > > As they're required to, they've released the source for these files, > along with whatever changes they've made. However, they're not required > to tell us what they did, to send us patches, or to even let us know > they've made a change. > > What this means is that it's possible, even likely, that Transgaming has > improved the LGPL parts of Cedega in some important way that would be > useful to Wine as well, without us having even known about it. > > The simplest thing to do is for someone to just track the code they > release and diff it against our own stuff, and note if anything new and > interesting (eg an implementation of a function) comes up. Then send in > a patch if it seems like it could help us too. But, is anyone doing > this? > > Thanks, > Scott Ritchie > > > > -- Gavriel State Founder & CTO TransGaming Technologies Inc. gav(a)transgaming.com http://www.transgaming.com Broadening The Playing Field

Jan. 26, 2007

Re: Is anyone monitoring Transgaming's changes to the LGPL files?

by Gavriel State

Hi Scott, We mostly haven't made many significant changes to the LGPL DLLs that we've been picking up, other than modifications to allow them to build within our somewhat different build environment. One place where we have made changes recently was to the iphlpapi DLL, and we recently submitted a patch for that. There have also been a couple of places in some of the crypto code when we've come across a bug, worked through it, and made a fix. But at least twice, a patch has been checked into WineHQ CVS just before we posted our fix. We'll certainly be trying to submit patches to LGPLed DLLs that we make changes to where we can, but if anyone is interested in helping, we're happy to work with them too. Take care, -Gav Scott Ritchie wrote: > I don't know when it started, but Transgaming has been using LGPL chunks > of Wine for quite some time. > > As they're required to, they've released the source for these files, > along with whatever changes they've made. However, they're not required > to tell us what they did, to send us patches, or to even let us know > they've made a change. > > What this means is that it's possible, even likely, that Transgaming has > improved the LGPL parts of Cedega in some important way that would be > useful to Wine as well, without us having even known about it. > > The simplest thing to do is for someone to just track the code they > release and diff it against our own stuff, and note if anything new and > interesting (eg an implementation of a function) comes up. Then send in > a patch if it seems like it could help us too. But, is anyone doing > this? > > Thanks, > Scott Ritchie > > > > -- Gavriel State Founder & CTO TransGaming Technologies Inc. 55 Byward Market Square gav(a)transgaming.com http://www.transgaming.com Broadening The Playing Field

Jan. 26, 2007

Re: make crosstest broken (tmarshal)

by Alexandre Julliard

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > Checking the _unix_build_ i find the missing stdole2.tlb in ./dlls/stdole2.tlb > and ./include/stdole2.tlb. When doing the cross compile the one in the > include directory not generated. It is generated just fine for me. Make sure you don't have any object file anywhere in the source dir. > These problems are show stoppers for me because i have no idea how to fix it. Some parts of the tree, like the loader, cannot be cross-compiled, just do a make -k and ignore the failures. -- Alexandre Julliard julliard(a)winehq.org

Jan. 25, 2007

Re: make crosstest broken (tmarshal)

by Stefan Leichter

Am Thursday 25 January 2007 13:08 schrieb Alexandre Julliard: > Stefan Leichter <Stefan.Leichter(a)camLine.com> writes: > > What parameters do i need to pass to configure for this case. If i do > > it like Paul Millar descripted it > > > > ../wine-git/configure --host=i586-mingw32msvc \ > > -with-wine-tools=../wine-build > > That should work. Make sure you don't have a tmarshal.h in the source > tree. I'm sorry to tell you that it doesn't work but it looks different now. Just building the tests give me the error sle(a)sle3:/usr/src/wine/wine-mingw$ make -C dlls/oleaut32/tests/ make: Entering directory `/usr/src/wine/wine-mingw/dlls/oleaut32/tests' ../../../../wine-build/tools/widl/widl -I../../../../wine-git/dlls/oleaut32/tests -I. -I../../../../wine-git/include -I../../../include -h -H tmarshal.h ../../../../wine-git/dlls/oleaut32/tests/tmarshal.idl i586-mingw32msvc-gcc -c -I../../../../wine-git/dlls/oleaut32/tests -I. -I../../../../wine-git/include -I../../../include -D_REENTRANT -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o tmarshal.o ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c ../../../../wine-build/tools/widl/widl -I../../../../wine-git/dlls/oleaut32/tests -I. -I../../../../wine-git/include -I../../../include -t -T tmarshal.tlb ../../../../wine-git/dlls/oleaut32/tests/tmarshal.idl error: Could not open importlib stdole2.tlb. make: *** [tmarshal.tlb] Fehler 2 make: Leaving directory `/usr/src/wine/wine-mingw/dlls/oleaut32/tests' Checking the _unix_build_ i find the missing stdole2.tlb in ./dlls/stdole2.tlb and ./include/stdole2.tlb. When doing the cross compile the one in the include directory not generated. Just running make in the top level directory of the cross build gives me the error: make[1]: Entering directory `/usr/src/wine/wine-mingw/loader' (GIT_DIR=../../wine-git/.git git-describe HEAD 2>/dev/null || echo "wine-0.9.30") | sed -e 's/$.*$/const char wine_version[] = "\1";/' >version-stamp || (rm -f version-stamp && exit 1) i586-mingw32msvc-gcc -o wine-pthread pthread.o main.o version.o -L../libs/wine -lwine ../libs/port/libwine_port.a main.o: In function `main':/usr/src/wine/wine-mingw/loader/../../wine-git/loader/main.c:110: undefined reference to `_pthread_functions' collect2: ld returned 1 exit status make[1]: *** [wine-pthread] Fehler 1 make[1]: Leaving directory `/usr/src/wine/wine-mingw/loader' make: *** [loader] Fehler 2 And if i try make in the dll directory i get: make[1]: Entering directory `/usr/src/wine/wine-mingw/dlls/winspool.drv' ../../../wine-build/tools/winebuild/winebuild -w --def -o libwinspool.a --export ../../../wine-git/dlls/winspool.drv/winspool.drv.spec make[1]: Leaving directory `/usr/src/wine/wine-mingw/dlls/winspool.drv' rm -f libwinspool.a && ln -s winspool.drv/libwinspool.a libwinspool.a ... make[1]: Entering directory `/usr/src/wine/wine-mingw/dlls/comdlg32' i586-mingw32msvc-dllwrap -k --def libcomdlg32.def -o comdlg32.dll rsrc.res.o cdlg32.o colordlg.o filedlg.o filedlg31.o filedlgbrowser.o finddlg32.o fontdlg.o printdlg.o -L../../dlls -L../../dlls/ole32 -L../../dlls/shell32 -L../../dlls/shlwapi -L../../dlls/comctl32 -L../../dlls/winspool -L../../dlls/user32 -L../../dlls/gdi32 -L../../dlls/advapi32 -L../../dlls/kernel32 -L../../dlls/ntdll -lole32 -lshell32 -lshlwapi -lcomctl32 -lwinspool -luser32 -lgdi32 -ladvapi32 -lkernel32 -lntdll -L../../libs/wine -lwine -luuid ../../libs/port/libwine_port.a ../../dlls/libwinspool.a: file not recognized: File format not recognized collect2: ld returned 1 exit status i586-mingw32msvc-dllwrap: i586-mingw32msvc-gcc exited with status 1 make[1]: *** [comdlg32.dll] Fehler 1 make[1]: Leaving directory `/usr/src/wine/wine-mingw/dlls/comdlg32' make: *** [comdlg32] Fehler 2 These problems are show stoppers for me because i have no idea how to fix it. Bye Stefan PS: I wiill try again on Monday

Jan. 25, 2007