January 2007 - Wine-Devel - list.winehq.org

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols

by Anatoly Lyutin

Dmitry Timoshkov wrote: > "Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > >> --- dlls/kernel32/tests/locale.c 5 Jan 2007 19:37:02 -0000 1.8 >> +++ dlls/kernel32/tests/locale.c 24 Jan 2007 14:15:14 -0000 >> @@ -35,6 +35,9 @@ >> #include "winerror.h" >> #include "winnls.h" >> >> +#include "locale.h" >> +#include "tables_CP1251.h" > > I'd suggest to test specific strings instead of auto-generated tables. > Since microsoft apparently uses their own unicode tables that differ > from unicode.org ones that's almost impossible to get the exactly same > behaviour among Wine and Windows. > Unfortunately there are programs which are using this table of sorting and no other. >> +static int compare_string2_non_latin(const void *e1, const void *e2) >> +{ >> + const char *s1 = (char *)e1; >> + const char *s2 = (char *)e2; >> + >> + return CompareStringA(LOCALE_USER_DEFAULT,0,s1,1, s2,1) - 2; >> +} > > You need to directly specify the locale id, otherwise the test won't pass > on a system with different user default locale (like the Alexandre's > one). > In: + + while(Locales[j].pcTable) + { + if(setlocale(LC_ALL,Locales[j].pcLocalName)!=NULL) + { + for(i=0;i<cSize;i++) set another locale, isn't it?

Jan. 25, 2007

Re: make crosstest broken (tmarshal)

by Alexandre Julliard

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > The problem is related to the fact that i'm doing out of tree builds. > Therefore i have three directories: > 1. wine-git : the source tree > 2. wine-build : the normal build (unix) > 3. wine-mingw : the cross compile build If you are doing a cross-compile build then you don't need to use crosstest, a simple make will build the tests as PE binaries. "make crosstest" is meant for people who want to quickly build a PE test inside the normal tree, without the complexity of a separate build tree. -- Alexandre Julliard julliard(a)winehq.org

Jan. 25, 2007

Re: [try 4] slist support (2/2) slist declarations and functions

by Mike McCormack

Damjan Jovanovic wrote: > diff -ur a/include/winbase.h b/include/winbase.h > --- a/include/winbase.h 2007-01-12 20:59:52.000000000 +0200 > +++ b/include/winbase.h 2007-01-24 20:42:35.000000000 +0200 I would recommend you at least split the modifications to winbase into a separate patch, as they are not dependent on your implementation. Mike

Jan. 25, 2007

Re: Patch to make X11DRV_GetAsyncKeyState work for TacOps

by Mike McCormack

Martin Cracauer wrote: > The game "TacOps" (a standalone 2D wargame, not to be mixed up with > the Unreal mod "Tac Ops") uses home-grown scrollbars. They have > autorepeat, that means holding the mouse button on the "down" or "up" > icons will continue to scroll until you release the button. Without > the appended patch Wine will never notice when you release the mouse > button. That effectively means an application hang since you can > never do anything else anymore, as the game continue to execute "down" > autorepeat. You'll probably need Alexandre's comment on this, but it doesn't look correct to me. Querying the X server for the key state on each call to GetAsyncKeyState bypasses the input queue, and is likely to cause applications that poll GetAsyncKeyState to slow down... This is likely to be a tricky problem to solve, as you need to run Wine's X11 message loop, but Wine currently only does that when the application waits for input. Mike

Jan. 25, 2007

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols

by Mike McCormack

Anatoly Lyutin wrote: > Changelog: Add test for CompareStringA for non latin symbols. Hmm. > + if (0) test_sorting_non_latin(); Adding a test that won't run... > +/* If you want to get the source code of the program generating a file, > + * please write to me on vostok(a)etersoft.ru. > + * Automatically generated file; DO NOT EDIT!! > + */ without the source code to generate the test data... Seems like it's unlikely this patch will be accepted. What exactly are you trying to show? Mike

Jan. 25, 2007

Re: make crosstest broken (tmarshal)

by Michal Okresa

On Thursday 25 January 2007 07:51, Paul Vriens wrote: > as far as I can see it's not the fact that tmarshal.h is not there. It's > the fact it's not build, as the .idl files are there (on a clean Wine it's > not in the tests directory as well). On a 'normal' Wine-tree you will see > it being built: > > ../../../tools/widl/widl -I. -I. -I../../../include -I../../../include > -h -H tmarshal.h tmarshal.idl Hi, I pointed out that cross compilation doesn't work for tmarshal test here: http://www.winehq.org/pipermail/wine-patches/2007-January/035157.html . It's happen because build system doesn't generate appropriate files. You may build test by hand with following commands: make test (this generates tmarshal.h, tmarshal_i.c, tmarshal.tlb, tmarshal.res) i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o tmarshal_i.cross.o tmarshal_i.c i586-mingw32msvc-gcc olefont.cross.o olepicture.cross.o safearray.cross.o tmarshal.cross.o typelib.cross.o usrmarshal.cross.o varformat.cross.o vartest.cross.o vartype.cross.o tmarshal.res.cross.o testlist.cross.o tmarshal_i.cross.o -o oleaut32_crosstest.exe -loleaut32 -lole32 -lshlwapi -lrpcrt4 -luser32 -lgdi32 -ladvapi32 -lkernel32 -luuid -luser32 -- Michal Okresa

Jan. 25, 2007

Re: winex11.drv: Copy the GL extensions string because it may be freed.

by Roderick Colenbrander

> On Wednesday 24 January 2007 21:51, Ken Thomases wrote: > > + WineGLInfo.glExtensions = strdup((const char *) > pglGetString(GL_EXTENSIONS)); > > Shouldn't this be free'd somewhere? What about the other strings? > The problem with this string is that it depends on the presence of a GLX context which isn't the case for the other strings. This caused problems on OSX where the data got freed after releasing a context. Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

Jan. 25, 2007

Re: Tests for NtCreateMailslotFile

by Jeff L

Vitaliy Margolen wrote: > Jeff Latimer wrote: > >> This is the first of some tests for NtCreateMailslotFile. I have >> included them in kernel32/tests as I thought it better that the Mailslot >> tests be collocated. >> > Why do you need to test NtCreateMailslotFile directly? Why can't you use > CreateMailslot instead? > > Vitaliy. > > > > > > Dmitry Timoshkov wrote: > > NtCreateMailslotFile is a public API, so probably it should handle > the casewhen attr is NULL. I see the same problem at least in > NtCreateNamedPipeFile. > In general, handling of OBJECT_ATTRIBUTES in ntdll is not > consistent, but > fixing it properly most likely a test is needed to see what > Windows does > in that case. > I am following the suggestion from Dmitry. In my testing so far I have noticed that there are a number of edit conditions that are not yet implemented. These won't be tested as easily by CreateMailslot. Jeff

Jan. 25, 2007

Re: Tests for NtCreateMailslotFile

by Vitaliy Margolen

Jeff Latimer wrote: > This is the first of some tests for NtCreateMailslotFile. I have > included them in kernel32/tests as I thought it better that the Mailslot > tests be collocated. Why do you need to test NtCreateMailslotFile directly? Why can't you use CreateMailslot instead? Vitaliy.

Jan. 25, 2007

Re: make crosstest broken (tmarshal)

by Paul Vriens

Stefan Leichter wrote: > Hello, > > the tmarshal tests broke cross compiling. Compiling fails for me with > > i586-mingw32msvc-gcc -c -I../../../../wine-git/dlls/oleaut32/tests -I. -I../../../../wine-git/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o > tmarshal.cross.o ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c > ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:1: warning: -fPIC ignored > for target (all code is position independent) > ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:28:22: tmarshal.h: Datei > oder Verzeichnis nicht gefunden > ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:218: warning: type > defaults to `int' in declaration of `IWidgetVtbl' > ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:218: warning: no semicolon > at end of struct or union > ... > make[2]: *** [tmarshal.cross.o] Fehler 1 > make[2]: Leaving directory `/usr/src/wine/wine-mingw/dlls/oleaut32/tests' > make[1]: *** [oleaut32/tests/__crosstest__] Fehler 2 > make[1]: Leaving directory `/usr/src/wine/wine-mingw/dlls' > make: *** [dlls/__crosstest__] Fehler 2 > > The problem is related to the fact that i'm doing out of tree builds. > Therefore i have three directories: > 1. wine-git : the source tree > 2. wine-build : the normal build (unix) > 3. wine-mingw : the cross compile build > > The missing tmarshal.h file is in wine-build/dlls/oleauth32/tests > > Bye Stefan > > > Hi, as far as I can see it's not the fact that tmarshal.h is not there. It's the fact it's not build, as the .idl files are there (on a clean Wine it's not in the tests directory as well). On a 'normal' Wine-tree you will see it being built: ../../../tools/widl/widl -I. -I. -I../../../include -I../../../include -h -H tmarshal.h tmarshal.idl Cheers, Paul.

Jan. 25, 2007