October 2007 - Wine-Devel - list.winehq.org

Re: makefiles: add a notest target

by Maarten Lankhorst

Hi Lei, Lei Zhang schreef: > Hi, > > This patch adds a notest target to build everything but the dll unit > tests and winetest. This cuts down build time by 25%. > Julliard will never accept such patch. In the hacks.git tree there is a patch I did that has a configuration time option for it. It would be cleaner if you used something like 'make SKIPTESTS=1'. I doubt that alexandre would ever accept any patch that would disable building tests, though. Cheers, Maarten.

Oct. 26, 2007

Re: makefiles: add a notest target

by Michael Stefaniuc

Maarten Lankhorst wrote: > Lei Zhang schreef: >> This patch adds a notest target to build everything but the dll unit >> tests and winetest. This cuts down build time by 25%. >> > Julliard will never accept such patch. In the hacks.git tree there is a > patch I did that has a configuration time option for it. It would be > cleaner if you used something like 'make SKIPTESTS=1'. I doubt that > alexandre would ever accept any patch that would disable building tests, > though. And for a good reason. The tests started to rot and not even compile when building wasn't part of the default make target. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

Oct. 26, 2007

Re: What if heap errors caused 'make test' to fail?

by Dan Kegel

On 10/26/07, Alexandre Julliard <julliard(a)winehq.org> wrote: > > http://bugs.winehq.org/show_bug.cgi?id=10179 > > That's not heap corruption, it's the expected behavior of GlobalHandle > when called with a pointer to a moveable block. Good - then the bug is just that Wine is generating a spurious scary warning. How can we either suppress that warning, or make it more accurate?

Oct. 26, 2007

Re: What if heap errors caused 'make test' to fail?

by Alexandre Julliard

"Dan Kegel" <dank06(a)kegel.com> writes: > Have a look at > http://bugs.winehq.org/show_bug.cgi?id=10179 > and see if you still think so! That's not heap corruption, it's the expected behavior of GlobalHandle when called with a pointer to a moveable block. -- Alexandre Julliard julliard(a)winehq.org

Oct. 26, 2007

Re: What if heap errors caused 'make test' to fail?

by Dan Kegel

On 10/26/07, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Did you run them with a -j flag? Nope. Yeah, things happened kind of out of order, no idea why. > It would be less confusing to see it > without it. In either case I will take a look at the winmm/dsound tests > either tomorrow or when I get back from excursion in 9 days. I don't > think that the heap test failing would be a real failure though, it > probably tests such behavior. Have a look at http://bugs.winehq.org/show_bug.cgi?id=10179 and see if you still think so! - Dan

Oct. 26, 2007

Re: Misplaced Property Sheet buttons

by Frank Richter

On 26.10.2007 16:52, Peter Åstrand wrote: > This solves the position problem, but instead the Help button disappears. > See screenshot > http://www.cendio.com/~astrand/wine/62-tab-size/patched.png. Any ideas? Hint: check again what WM_WINDOWPOSCHANGED's 'lParam' contains ... -f.r.

Oct. 26, 2007

Re: user32: Fix a test that now passes in Windows

by Dan Hipschman

Some of what you're saying has validity, but all your criticisms are on very minor points, and I was surprised to see them. I think they're offset by the fact that James is a long-time developer who has a lot of work to do. I'm sure the Wine community appreciates every person who wants to help to make Wine better, but please get to know the culture of the Wine developers before criticizing them. Stop CCing wine-patches, it's for patches only. Thanks.

Oct. 26, 2007

Re: What if heap errors caused 'make test' to fail?

by Maarten Lankhorst

Hi Dan, Dan Kegel schreef: > 25! Here's the output of WINEDEBUG=warn+heap make -k test > piped through grep make.*Error: > > make[2]: *** [alloc.ok] Error 134 > make[2]: *** [pipe.ok] Error 1 > make[2]: *** [systray.ok] Error 6 > make[2]: *** [thread.ok] Error 9 > make[2]: *** [security.ok] Error 1 > make[1]: *** [advapi32/tests/__test__] Error 2 > make[2]: *** [info.ok] Error 134 > make[1]: *** [ntdll/tests/__test__] Error 2 > make[2]: *** [heap.ok] Error 134 > make[2]: *** [change.ok] Error 2 > make[2]: *** [heap.ok] Error 5 > make[2]: *** [util.ok] Error 134 > make[1]: *** [msvcrt/tests/__test__] Error 2 > make[1]: *** [snmpapi/tests/__test__] Error 2 > make[2]: *** [apibuf.ok] Error 134 > make[1]: *** [netapi32/tests/__test__] Error 2 > make[2]: *** [device.ok] Error 4 > make[1]: *** [d3d9/tests/__test__] Error 2 > make[2]: *** [moniker.ok] Error 134 > make[2]: *** [toolhelp.ok] Error 8 > make[2]: *** [webbrowser.ok] Error 134 > make[1]: *** [shdocvw/tests/__test__] Error 2 > make[2]: *** [input.ok] Error 64 > make[2]: *** [editor.ok] Error 5 > make[1]: *** [riched20/tests/__test__] Error 2 > make[2]: *** [mixer.ok] Error 10 > make[2]: *** [msg.ok] Error 18 > make[2]: *** [shellpath.ok] Error 3 > make[2]: *** [class.ok] Error 2 > make[2]: *** [comm.ok] Error 3 > make[2]: *** [vartype.ok] Error 134 > make[1]: *** [oleaut32/tests/__test__] Error 2 > make[2]: *** [parser.ok] Error 134 > make[1]: *** [setupapi/tests/__test__] Error 2 > make[2]: *** [win.ok] Error 8 > make[2]: *** [capture.ok] Error 134 > make[1]: *** [dsound/tests/__test__] Error 2 > make[2]: *** [htmldoc.ok] Error 134 > make[2]: *** [timer.ok] Error 1 > make[2]: *** [mci.ok] Error 134 > make[1]: *** [mshtml/tests/__test__] Error 2 > make[2]: *** [font.ok] Error 26 > make[1]: *** [gdi32/tests/__test__] Error 2 > make[1]: *** [kernel32/tests/__test__] Error 2 > make[2]: *** [wave.ok] Error 8 > make[1]: *** [winmm/tests/__test__] Error 2 > make[2]: *** [server.ok] Error 4 > make[1]: *** [rpcrt4/tests/__test__] Error 2 > make[2]: *** [dde.ok] Error 5 > make[1]: *** [user32/tests/__test__] Error 2 > make[2]: *** [shlexec.ok] Error 35 > make[1]: *** [shell32/tests/__test__] Error 2 > make[1]: *** [ole32/tests/__test__] Error 2 > > I wonder if some of these tests are themselves buggy such that > they pass on Wine by accident (without this patch) but fail on Windows Did you run them with a -j flag? It would be less confusing to see it without it. In either case I will take a look at the winmm/dsound tests either tomorrow or when I get back from excursion in 9 days. I don't think that the heap test failing would be a real failure though, it probably tests such behavior. Cheers, Maarten.

Oct. 26, 2007

Re: Lots of 'make test' failures on Windows

by Jakob Eriksson

Robert Shearman wrote: > > We do. I've got a machine that regularly runs the test on Windows 2003 > on real hardware: > http://test.winehq.org/data/200710241000/2003_rshearman/report That's excellent! > > However, the tests are run by a service rather than manually by me to > reduce the effort needed. This results in some tests failing when they > perhaps shouldn't. I have found that scripting a wget that runs periodically works good, with winetest in "Desktop mode". Maybe something for that server? > > This also doesn't help the Direct3D developers since D3D is disabled > by default on Windows 2003, so we also need a real Windows XP box to > run the tests regularly. True... regards, Jakob

Oct. 26, 2007

Re: my first patch

by Maarten Lankhorst

Hi Vincent, viny schreef: > Can someone tell me if this patch is correct for submitting to > wine-patches. > I have generated this patch with "git format-patch -o out origin" Anything created by git-diff or git-format patch will automatically be inthe proper format. Cheers, Maarten.

Oct. 26, 2007