October 2007 - Wine-Devel - list.winehq.org

Re: I am at the Ubuntu Developer Summit, do we need anything from other projects?

by Kai Blin

On Tuesday 30 October 2007 23:54:58 scott(a)tuzakey.com wrote: > > There are people from many free software projects here, including the > kernel and Samba. Should I voice anything else? As I added to the wiki page just now, a set of sockopts to allow sending/receiving UDP broadcasts even when bound to a specific IP address would be sweet, but I doubt that's ever going to fly. Say hello to Jerry Carter when you bump into him. Cheers. Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

Oct. 31, 2007

Tips needed for debugging Skype on Wine (Access violation)

by Paul Vriens

Hi, I'm trying to get Skype 3.5.0.39 running on Wine (latest Git). The app however throws an 'Access violation at address 00593AD1 in module "Skype.exe". Read of address FFFFFFFF'. I've set set the version to XP. I do find that when I apply this "patch": diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index a08235a..d4349d7 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -2819,7 +2819,7 @@ BOOL WINAPI IsWow64Process(HANDLE hProcess, PBOOL Wow64Process) { FIXME("(%p %p) stub!\n", hProcess, Wow64Process); *Wow64Process = FALSE; - return TRUE; + return FALSE; } the application has no issues starting up (several other issues remain). Is this an exception that Windows catches and we don't perhaps? The application runs fine on my Windows XP box. Tried to use several debugchannels but to no avail. -- Cheers, Paul.

Oct. 31, 2007

Re: Convincing Valgrind to give a stack dump?

by Dan Kegel

On 10/31/07, Robert Shearman <rob(a)codeweavers.com> wrote: > Dan Kegel wrote: > > But I couldn't coax Valgrind into giving stack dumps for those errors; > > it acted as if it had seen a few too many errors first, and only > > showed the one line. Grr. Anyone know how to coax valgrind > > into always giving a good stack dump? > > There are some patches on this page that will probably help, depending > on the version of valgrind you are using: > http://wiki.winehq.org/Wine_and_Valgrind Yes, thanks, I just updated that page with a version of that patch rediffed against valgrind-3.2.3, and have been submitting patches against Wine to fix buffer overflows and thinkos revealed by Valgrind. - Dan

Oct. 31, 2007

Re: Convincing Valgrind to give a stack dump?

by Robert Shearman

Dan Kegel wrote: > But I couldn't coax Valgrind into giving stack dumps for those errors; > it acted as if it had seen a few too many errors first, and only > showed the one line. Grr. Anyone know how to coax valgrind > into always giving a good stack dump? There are some patches on this page that will probably help, depending on the version of valgrind you are using: http://wiki.winehq.org/Wine_and_Valgrind -- Rob Shearman

Oct. 31, 2007

Re: cabinet: fully initialize structs in FCICreate() and FCIAddFile()

by Alexandre Julliard

"Dan Kegel" <dank(a)kegel.com> writes: > Rather than hunt it down precisely, I applied > the old "memset the struct to zero when allocating" > meme, which in some circles is considered the "right" > way to avoid this kind of problem. (I halfway expect > Alexandre to say "don't be so lazy", but it's worth a try.) Don't be so lazy. ;-) -- Alexandre Julliard julliard(a)winehq.org

Oct. 31, 2007

Re: Changes default socket behavior for WSASendTo function from overlapped to non-overlapped

by Alexandre Julliard

yurtk(a)mail15.com writes: > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 24a4a76..3697746 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -2662,7 +2662,8 @@ INT WINAPI WSASendTo( SOCKET s, LPWSABUF lpBuffers, DWORD dwBufferCount, > goto error; > } > > - if ((lpOverlapped || lpCompletionRoutine) && > + /* If no options specified, the socket assumed to be non-overlapped*/ > + if (options && (lpOverlapped || lpCompletionRoutine) && > !(options & (FILE_SYNCHRONOUS_IO_ALERT | FILE_SYNCHRONOUS_IO_NONALERT))) > { This is wrong, it will make all sockets non-overlapped. -- Alexandre Julliard julliard(a)winehq.org

Oct. 31, 2007

Re: winex11drv: Initialize real default mode in xrandr and xvidmodebackends

by Dmitry Timoshkov

"Chris Robinson" <chris.kcat(a)gmail.com> wrote: > This has been brought up on IRC before, and I believe the concensus was you > can't rely on the current mode when starting the app because there's no way > to tell if the current mode is the default or something another app set. Then x11drv should not try to restore a default mode at all. Since it does, my patch fixes a bug in it. > As far as XRandR is concerned, mode 0 is always the default, but the desktop > manager can set a different mode per user on login. The way to fix this would > be to get some way to query the desktop manager for the default mode, or to > extend XRandR to be able to change and report different defaults. Neither of > which is possible right now. I believe that my patch is better choice than current behaviour. -- Dmitry.

Oct. 31, 2007

Re: winex11drv: Initialize real default mode in xrandr and xvidmode backends

by Chris Robinson

On Tuesday 30 October 2007 10:47:34 pm Dmitry Timoshkov wrote: > - X11DRV_Settings_SetDefaultMode(0); > + > + default_mode = X11DRV_XRandR_GetCurrentMode(); > + TRACE("default mode: %d\n", default_mode); > + X11DRV_Settings_SetDefaultMode(default_mode); This has been brought up on IRC before, and I believe the concensus was you can't rely on the current mode when starting the app because there's no way to tell if the current mode is the default or something another app set. As far as XRandR is concerned, mode 0 is always the default, but the desktop manager can set a different mode per user on login. The way to fix this would be to get some way to query the desktop manager for the default mode, or to extend XRandR to be able to change and report different defaults. Neither of which is possible right now.

Oct. 31, 2007

Re: I am at the Ubuntu Developer Summit, do we need anything from other projects?

by Roderick Colenbrander

> The other day an X.org developer asked me if Wine needed anything from > X. Off the top of my head, all I could think to tell him was relative > mouse movements. Input isn't really my area but I believe we need relative mouse movements for the whole desktop and not for a single window. Ask vitaly for more info on what is needed. Input is the biggest issue in most recent games on Wine (Unreal Tournament III, Crysis and dozens of others) Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

Oct. 31, 2007

advapi32: fix buffer overrun in tests/registry.c:wine_debugstr_wn(), try 2

by Dan Kegel

OK, my last try was ugly and deserved to be dropped. This one is a one-bit change, and easier to understand. Fixes an off-by-one buffer overflow in wine_debugstr_wn() in which the wchar after the end of the buffer was read.

Oct. 31, 2007