October 2007 - Wine-Devel - list.winehq.org

Re: Anything wrong with my patch from 16.10. about w32x86 andwin40creation?

by Alexandre Julliard

Markus Gömmel <m.goemmel(a)compulab.de> writes: >> I suppose it was rejected by AJ based on the patch content. > > Hm, but the content of the patch is what Windows do, so rejecting cause of > the content sounds a bit unlikely to me... We of course have to create the directory, but I think it would be better if the dll that uses it did that. -- Alexandre Julliard julliard(a)winehq.org

Oct. 24, 2007

Re: PulseAudio as a sound output?

by TheBlunderbuss

L. Rahyen wrote: > Now 2.6.23 is stable so everyone can easily try and test it. All major > distribution should provide precompiled 2.6.23 kernels in near future. Thanks for your test!

Oct. 24, 2007

Re: Anything wrong with my patch from 16.10. about w32x86 and win40creation?

by Juan Lang

> So it's really ok to create a patch with only the patch as text without any > attachment? At one point that was the preferred way. I don't know whether it still is, but I'm sure it's still accepted. Its risky with some (bad) mailers, because they may wrap lines, but if you absolutely can't use a mailer that doesn't screw up attachments, you could try this instead. There are plenty of mail programs that don't screw up attachments, by the way. You might try one. --Juan

Oct. 24, 2007

Re: Anything wrong with my patch from 16.10. about w32x86 and win40creation?

by Markus Gömmel

So it's really ok to create a patch with only the patch as text without any attachment? Markus "Juan Lang" <juan.lang(a)gmail.com> wrote in message news:3a768c550710230713ub9d8911s282eac8759b7e801(a)mail.gmail.com... >> I usually use the archives for viewing patches, sometimes the patches >> are archived separately to the email. >> >> Markus' patch is here: >> http://www.winehq.org/pipermail/wine-patches/2007-October/045288.html > > Right, that one had formatting characters in it due to the encoding. > Patches need to be either inline as text or attached as plaintext to > get looked at. > --Juan > > >

Oct. 24, 2007

Re: Anything wrong with my patch from 16.10. about w32x86 andwin40creation?

by Markus Gömmel

> I suppose it was rejected by AJ based on the patch content. Hm, but the content of the patch is what Windows do, so rejecting cause of the content sounds a bit unlikely to me... bye bye Markus

Oct. 24, 2007

Re: iphlpapi: Intel Mac do not implement /proc filesystem so return Unimplemented for the functions trying to read from there.

by Aric Stewart

Yeah after I submitted the patch, I was thinking about that as well. I will look at doing that. -aric Juan Lang wrote: > Hi Aric, > > @@ -104,6 +104,9 @@ DWORD getInterfaceStatsByName(const char > { > FILE *fp; > > +#ifdef __APPLE__ > + return ERROR_NOT_SUPPORTED; > +#endif > > This is ugly. Why not just change the case when fp is NULL? You've > already got: > fp = fopen("/proc/net/dev", "r"); > if (fp) { > ... > } > else > ERR ("unimplemented!\n"); > > You could change this to set the return value, rather than using all > these #ifdefs. Same thing throughout the patch. > --Juan >

Oct. 24, 2007

Re: iphlpapi: Intel Mac do not implement /proc filesystem so return Unimplemented for the functions trying to read from there.

by Juan Lang

Hi Aric, @@ -104,6 +104,9 @@ DWORD getInterfaceStatsByName(const char { FILE *fp; +#ifdef __APPLE__ + return ERROR_NOT_SUPPORTED; +#endif This is ugly. Why not just change the case when fp is NULL? You've already got: fp = fopen("/proc/net/dev", "r"); if (fp) { ... } else ERR ("unimplemented!\n"); You could change this to set the return value, rather than using all these #ifdefs. Same thing throughout the patch. --Juan

Oct. 24, 2007

Re: "typos" on some include files

by Marcos Gutiérrez Batz

Oh God! Sorry about that! Dmitry Timoshkov wrote: > "Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote: > >> +HRESULT WINAPI HRESULT OleLoadPictureFile( >> + VARIANT varFileName, >> + LPDISPATCH *lplpdispPicture ) > > HRESULT is duplicated. > $ diff -up /usr/src/wine/dlls/oleaut32/stubs.c stubs.c --- /usr/src/wine/dlls/oleaut32/stubs.c 2007-07-27 17:11:43.000000000 +0200 +++ stubs.c 2007-10-24 16:05:53.000000000 +0200 @@ -54,3 +54,15 @@ HRESULT WINAPI OleCreatePropertyFrame( pPageClsID, (int)lcid,dwReserved,pvReserved); return S_OK; } + +/*********************************************************************** + * OleLoadPictureFile (OLEAUT32.422) + */ +HRESULT WINAPI OleLoadPictureFile( + VARIANT varFileName, + LPDISPATCH *lplpdispPicture ) +{ + FIXME("(%p,%p), not implemented (oleaut32.dll)\n", + varFileName, lplpdispPicture); + return S_OK; +} $ diff -up /usr/src/wine/dlls/oleaut32/oleaut32.spec oleaut32.spec --- /usr/src/wine/dlls/oleaut32/oleaut32.spec 2007-07-27 17:11:43.000000000 +0200 +++ oleaut32.spec 2007-10-24 15:39:54.000000000 +0200 @@ -390,7 +390,7 @@ 419 stdcall OleCreatePictureIndirect(ptr ptr long ptr) 420 stdcall OleCreateFontIndirect(ptr ptr ptr) 421 stdcall OleTranslateColor(long long long) -422 stub OleLoadPictureFile +422 stdcall OleLoadPictureFile(ptr ptr) 423 stub OleSavePictureFile 424 stdcall OleLoadPicturePath(wstr ptr long long ptr ptr) 425 stdcall VarUI4FromI8(double ptr)

Oct. 24, 2007

Re: "typos" on some include files

by Dmitry Timoshkov

"Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote: > +HRESULT WINAPI HRESULT OleLoadPictureFile( > + VARIANT varFileName, > + LPDISPATCH *lplpdispPicture ) HRESULT is duplicated. -- Dmitry.

Oct. 24, 2007

Re: "typos" on some include files

by Marcos Gutiérrez Batz

Added OleLoadPictureFile stub. Dmitry Timoshkov wrote: > "Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote: > >> $ diff -up liboleaut32.def /usr/lib/wine/liboleaut32.def >> --- liboleaut32.def 2007-08-23 16:15:48.000000000 +0200 >> +++ /usr/lib/wine/liboleaut32.def 2007-10-15 00:48:35.000000000 >> +0200 >> @@ -366,7 +366,6 @@ EXPORTS >> OleCreatePictureIndirect(a)16 @419 >> OleCreateFontIndirect(a)12 @420 >> OleTranslateColor(a)12 @421 >> - OleLoadPictureFile(a)12 @422 >> OleLoadPicturePath(a)24 @424 >> VarUI4FromI8(a)12 @425 >> VarUI4FromUI8(a)12 @426 > > Also you can't just add an entry to the .def file, it's auto generated. > You have to add a stub to the source file, and change the 'stub' entry > in the .spec file. > $ diff -up /usr/src/wine/dlls/oleaut32/stubs.c stubs.c --- /usr/src/wine/dlls/oleaut32/stubs.c 2007-07-27 17:11:43.000000000 +0200 +++ stubs.c 2007-10-24 15:39:58.000000000 +0200 @@ -54,3 +54,15 @@ HRESULT WINAPI OleCreatePropertyFrame( pPageClsID, (int)lcid,dwReserved,pvReserved); return S_OK; } + +/*********************************************************************** + * OleLoadPictureFile (OLEAUT32.422) + */ +HRESULT WINAPI HRESULT OleLoadPictureFile( + VARIANT varFileName, + LPDISPATCH *lplpdispPicture ) +{ + FIXME("(%p,%p), not implemented (oleaut32.dll)\n", + varFileName, lplpdispPicture); + return S_OK; +} $ diff -up /usr/src/wine/dlls/oleaut32/oleaut32.spec oleaut32.spec --- /usr/src/wine/dlls/oleaut32/oleaut32.spec 2007-07-27 17:11:43.000000000 +0200 +++ oleaut32.spec 2007-10-24 15:39:54.000000000 +0200 @@ -390,7 +390,7 @@ 419 stdcall OleCreatePictureIndirect(ptr ptr long ptr) 420 stdcall OleCreateFontIndirect(ptr ptr ptr) 421 stdcall OleTranslateColor(long long long) -422 stub OleLoadPictureFile +422 stdcall OleLoadPictureFile(ptr ptr) 423 stub OleSavePictureFile 424 stdcall OleLoadPicturePath(wstr ptr long long ptr ptr) 425 stdcall VarUI4FromI8(double ptr)

Oct. 24, 2007