October 2007 - Wine-Devel - list.winehq.org

Re: gdi32 (2/2): fix unchecked NULL ptr in BIDI_Reorder

by Alexandre Julliard

Alexander Dorofeyev <alexd14(a)hushmail.com> writes: > 3rd try. In this version I don't create a temp buffer, instead pass the original > string to subroutines; in BidiLines an additional parameter had to be added, to > indicate that the original string has been passed and in-place modifications it > normally does on the buffer must be skipped. You should pass separate in and out pointers, since the input pointer is const you can't use it in place of the output one. -- Alexandre Julliard julliard(a)winehq.org

Oct. 23, 2007

Re: Anything wrong with my patch from 16.10. about w32x86 andwin40creation?

by Stefan Dösinger

Am Dienstag, 23. Oktober 2007 15:07:16 schrieb Markus Gömmel: > Can you see if my 3rd try is valid now? Should be come through in the next > minutes... > > Thanks for all your help Looks good from the sending side. I can't comment on the printing stuff though

Oct. 23, 2007

Re: [PATCH] updated authors

by Michael Stefaniuc

Dmitry Timoshkov wrote: > "Marcus Meissner" <meissner(a)suse.de> wrote: > >> --- >> AUTHORS | 138 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- >> 1 files changed, 136 insertions(+), 2 deletions(-) > > I've found more duplicates, sorry for the trouble. > >> +Veksler Michael > > This is a duplicate due to the reversed last/first names. > >> Zoltan Nagy >> +Zoly Nagy Zoly is the short form of Zoltan. So this looks like a duplicate. > The two names above look similar enough, but changelog doesn't > provide enough information to distinguish them. > >> +Brouard Nicolas > > Again a duplicate due to the reversed last/first names. > >> +Tom Spear > > Not sure if have him already under an old name (can't remember which one). > bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111

Oct. 23, 2007

Re: [PATCH] updated authors

by Juan Lang

> > +Tom Spear > > Not sure if have him already under an old name (can't remember which one). Dustin Navea, I think. But it might be polite to retain both names in this case. --Juan

Oct. 23, 2007

Re: [PATCH] updated authors

by Dmitry Timoshkov

"Marcus Meissner" <meissner(a)suse.de> wrote: > --- > AUTHORS | 138 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 136 insertions(+), 2 deletions(-) I've found more duplicates, sorry for the trouble. > +Veksler Michael This is a duplicate due to the reversed last/first names. > Zoltan Nagy > +Zoly Nagy The two names above look similar enough, but changelog doesn't provide enough information to distinguish them. > +Brouard Nicolas Again a duplicate due to the reversed last/first names. > +Tom Spear Not sure if have him already under an old name (can't remember which one). -- Dmitry.

Oct. 23, 2007

Re: Anything wrong with my patch from 16.10. about w32x86 and win40 creation?

by Juan Lang

> I usually use the archives for viewing patches, sometimes the patches > are archived separately to the email. > > Markus' patch is here: > http://www.winehq.org/pipermail/wine-patches/2007-October/045288.html Right, that one had formatting characters in it due to the encoding. Patches need to be either inline as text or attached as plaintext to get looked at. --Juan

Oct. 23, 2007

Re: Anything wrong with my patch from 16.10. about w32x86 andwin40creation?

by Markus Gömmel

Can you see if my 3rd try is valid now? Should be come through in the next minutes... Thanks for all your help Markus

Oct. 23, 2007

Re: Anything wrong with my patch from 16.10. about w32x86 and win40creation?

by Stefan Dösinger

Am Dienstag, 23. Oktober 2007 11:53:52 schrieb Markus Gömmel: > Ups, I checked it here again and I can see an attachment which looks ok... > > It's not so easy to use Windows tools on a Linux newsgroup :-/ It is a mailing list actually, not a newsgroup. There are some mailing list<->newsgroup bridges though. > X-Newsreader: Microsoft Windows Mail 6.0.6000.16480 > X-MimeOLE: Produced By Microsoft MimeOLE V6.0.6000.16545 I don't know what sort of enchanted features Windows Mail uses, but make sure that the patch is attached as a normal text file without any fancy OLE fun and so on: This is how your mail arrived at the mailing list archive as far as I can see: http://www.winehq.org/pipermail/wine-patches/2007-October/045287.html A file is attached, but it is empty.

Oct. 23, 2007

Anything wrong with my patch from 16.10. about w32x86 and win40 creation?

by Pat

I usually use the archives for viewing patches, sometimes the patches are archived separately to the email. Markus' patch is here: http://www.winehq.org/pipermail/wine-patches/2007-October/045288.html

Oct. 23, 2007

Re: wininet: ftp test hangs behind firewall, so turn it off by default

by Hans Leidekker

On Tuesday 23 October 2007 12:37:46 Alexandre Julliard wrote: > > This gets rid of one more place I have to do 'wineserver -k' to > > make tests complete. > > I don't think it really hangs, it just takes a long time to complete. It may have really hung before for some people. I remember leaving the test running for more than half an hour and it was still stuck, whereas now it completes within minutes. I didn't verify this but the logical explanation seems to be that in the previous setting the incoming connection got blocked by a firewall, while the test sat there waiting for it in a blocking accept or analogous call. If so, there could be another bug lurking in our timeout handling. -Hans

Oct. 23, 2007