October 2007 - Wine-Devel - list.winehq.org

Re: wininet: ftp test hangs behind firewall, so turn it off by default

by Alexandre Julliard

"Dan Kegel" <dank(a)kegel.com> writes: > This gets rid of one more place I have to do 'wineserver -k' to > make tests complete. I don't think it really hangs, it just takes a long time to complete. > It would be better to embed a little ftp server into the test, > and connect to that instead of a public one, but that would > be a pain. No, we clearly want to run the test against a real ftp server. Running it against different types of servers would be even better. What we should probably do is try to connect to a server on localhost first, this way people can install the server of their choice to provide more test coverage. -- Alexandre Julliard julliard(a)winehq.org

Oct. 23, 2007

Re: pdh: Remove or fix tests that fail on Windows.

by Jeff Latimer

Hans Leidekker wrote: > On Monday 22 October 2007 14:43:59 Jeff Latimer wrote: > >> to test with and hence the delay. The current patch I submitted was >> cleaning up the Null reference issue before moving on to sorting out the >> > I don't see any crash on Wine or XP when running the test. When I run size = sizeof(buffer) / sizeof(WCHAR); ret = PdhLookupPerfNameByIndexW( NULL, 674, NULL, &size ); it crashes for me in wine and XP returns PDH_INVALID_ARGUMENT. > You are > trying to protect against a hypothetical case where an app specifies > a size > 0 but no buffer. XP won't accept that anyway and it's unlikely > any app will do that on non-XP systems. > I don't accept that it hypothetical because that is the exact behaviour the API spec encourages. The buffer can be NULL in all circumstances. > In fact your patch will break in another - also unlikely - > situation where an app relies on non-XP behaviour, which is to accept > a null buffer and size > 0 but less than the required size. > What is the result of that behaviour? It looks to me that the only response should be PDH_INVALID_ARGUMENT or ok with an updated size. As is stands pdh does neither. > So a crash is even desirable here, because it tells us immediately > that the app is doing something peculiar. > I don't understand this as there must be defined behaviour in this circumstance. Jeff

Oct. 23, 2007

Re: Anything wrong with my patch from 16.10. about w32x86 and win40creation?

by Markus Gömmel

Ups, I checked it here again and I can see an attachment which looks ok... It's not so easy to use Windows tools on a Linux newsgroup :-/ Can someone else please check what I'm doing wrong here? Thanks Markus

Oct. 23, 2007

Re: Anything wrong with my patch from 16.10. about w32x86 and win40 creation?

by Stefan Dösinger

Am Montag, 22. Oktober 2007 11:30:16 schrieb Markus Gömmel: > I think it's not a big deal but would help making on of our EmTec products > more compatible... I tried to look it up in the archives, but it contains only an empty file.

Oct. 23, 2007

Re: iexplore text input

by Robert Shearman

Luke Bratch wrote: > Hi all > > As you probably know, text input in iexplore isn't > working at the moment, and hasn't worked since this > commmit: > > http://source.winehq.org/git/wine.git/?a=commit;h=92b3cab7916445d79d2559e4b… > > (Found by Simon in this bug: > http://bugs.winehq.org/show_bug.cgi?id=9746) > > I've posted a patch in there: > > http://bugs.winehq.org/attachment.cgi?id=8647 > > That seems to make text input work be reversing part > of that commit. As far as I can see that doesn't > break anything else. > > Your thoughts? > Looks good to me. Send it to wine-patches whenever you're ready. -- Rob Shearman

Oct. 23, 2007

Re: [PATCH] updated AUTHORS according to "git log"

by Dmitry Timoshkov

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: I briefly looked over the diff and found some duplicates, perhaps there are more of them: > Guy Albertelli > +Guy L. Albertelli This one is probably a duplicate. > +Turchanov Sergei And this one already exists as 'Sergey Turchanov'. > +NF Stevens > Norman Stevens According to the e-mail addresses the two above is a single person. > +Josh Thielen > Joshua Thielen And these two as well. > +Sergei Turchanov > Sergey Turchanov Again a duplicate. -- Dmitry.

Oct. 23, 2007

urlmon: Fix the MIME type reported by the HTTP protocol when the Content-Type headers contains charset data too.

by Misha Koshelev

> Sorry to send this out after the patch has already been committed, but > this patch is wrong. If you just output the Content-Type in > test/protocol.c you'll see that the charset data is included in the > "MIME type" in both Windows XP and on wine with native urlmon (from > WinME or 98; I believe the XP one crashes wine or at least it used to). > That is why when I was fixing the original test I just changed it to a > memcmp from a strcmp. > Misha > Just checked on Win98, the behavior to keep the charset in the "MIME type" is correct on Win98 as well. Misha

Oct. 23, 2007

urlmon: Fix the MIME type reported by the HTTP protocol when the Content-Type headers contains charset data too.

by Misha Koshelev

Sorry to send this out after the patch has already been committed, but this patch is wrong. If you just output the Content-Type in test/protocol.c you'll see that the charset data is included in the "MIME type" in both Windows XP and on wine with native urlmon (from WinME or 98; I believe the XP one crashes wine or at least it used to). That is why when I was fixing the original test I just changed it to a memcmp from a strcmp. Misha

Oct. 23, 2007

Re: "winefix" - interesting wrapper for wine

by Scott Ritchie

Dan Kegel wrote: > Tom W. found and publicized a script called "winefix" by > an ubuntu forums user named "deadlydeathcone": > http://digg.com/linux_unix/Winefix_improved_desktop_integration_for_Wine > http://wine-review.blogspot.com/2007/10/winefix-improved-desktop-integratio… > http://ubuntuforums.org/showthread.php?s=6e904c1df87d3fd1698ab5d7bbdbf664&t… > > It's got a bunch of interesting stuff. > I wonder if we could get him to join wine-devel and start > contributing to wine itself... > - Dan > Yeah, it's very strange that he just came out of nowhere. I found out about his script through Digg. I'm gonna spend some time this week dissecting it and seeing what we can put right into the Wine package. Thanks, Scott Ritchie

Oct. 22, 2007

Re: Photoshop Elements 5 Tryout? (Maintainer requests)

by Alexander Nicolaysen Sørnes

On Monday 22 October 2007 20:28:01 Jan Zerebecki wrote: > On Mon, Oct 22, 2007 at 12:22:35AM +0200, Alexander Nicolaysen Sørnes wrote: > > On Sunday 21 October 2007 21:11:53 Vitaliy Margolen wrote: > > > Jan Zerebecki wrote: > > > > No. Let me rephrase what vitamin already said: I accepted a > > > > request he made but the only effect was that it was removed from > > > > the queue. (Although I didn't check that, I suspect that neither > > > > a reject nor accept mail was generated.) > > > > > > I have not received any e-mails. > > > > There wouldn't have been any; the maintainer entries would be silently > > deleted without any notification. > > But I _accepted_ his request. Do we agree that this is a bug? > It isn't a bug, because it has been fixed now. :) > And I would say that also rejection of a maintainer request > should generate a mail to the requester. > > > Jan A rejection does trigger a mail; the code thought it was a duplicate, in which case a mail would not be appropriate. Alexander

Oct. 22, 2007