October 2007 - Wine-Devel - list.winehq.org

re: ReplaceFileW (was: Phoronix: Ubuntu 7.10 + WINE vs. Windows XP)

by Dan Kegel

Reece Dunn wrote: > The patch was rejected by Alexandre because the patch was > implementing that command using Windows API calls, > when it should be implemented natively as POSIX/GNU calls. Really? Where did he say that? It'd be nice to link to that from http://bugs.winehq.org/show_bug.cgi?id=7544 - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

Oct. 20, 2007

Re: [PATCH 3/3] configure: Use 0 instead of NULL because NULL isn't defined.

by Juan Lang

> Both "0" and "(void *) 0" work here; which to use is a matter of style > and thus good for a flame war. But i don't care too much to start one ;) I'll point out that for the case at hand, a configure test, code readability is probably not a very important goal. As Ken points out, the configure check failed before, but for the wrong reason - NULL wasn't defined. Now it'll fail for the right reason - the function doesn't exist on MacOS X. The compiler warning during the configure check is only apparent in the configure log, which is probably why the reason for this failing was missed for so long. --Juan

Oct. 20, 2007

Re: Phoronix: Ubuntu 7.10 + WINE vs. Windows XP

by H. Verbeet

On 20/10/2007, Scott Ritchie <scott(a)open-vote.org> wrote: > Wait, they tested 3D Mark 2001 and 3D Mark 2003... > > Weren't those the exact same benchmarks NVidia was found to be cheating > with by including hacks into their drivers on Windows? No wonder they > found Windows to be faster in the graphics tests! > > Can anyone find a real (ie, not rigged on Windows) benchmark to use? > > Thanks, > Scott Ritchie > > Actually, the results look pretty consistent with my personal experience of getting about ~70% of Windows performance on average, although the results vary quite a bit between different applications. What I think is a bit of a shame is that they didn't test with GLSL or FBOs, although to be fair those are non-default registry settings.

Oct. 20, 2007

Re: Phoronix: Ubuntu 7.10 + WINE vs. Windows XP

by Reece Dunn

On 20/10/2007, Stephan Rose <kermos(a)somrek.net> wrote: > On that note, I noticed that ReplaceFileW still isn't implemented as > it's not possible to safe a profile under Supreme Commander. Wasn't > there a patch for this? I distinctly remember that because I was going > to implement that function until I saw someone else had already > submitted a patch with an implementation. What happened with that? The patch was rejected by Alexandre because the patch was implementing that command using Windows API calls, when it should be implemented natively as POSIX/GNU calls. Feel free to implement that function. The best way to get it accepted is to have another patch that provides a set of corresponding tests, so the behaviour can be checked against Windows. This then ensures that the API is doing the correct thing. Test cases worth covering are: * using NULL values in all permutations of source, target and backup file; * covering all premutations of file existing and not existing for the source, target and backup file; * how the replace flags affect the behaviour; * caller not having write access to the file being replaced; * different ACL combinations on the source file. Things worth testing for: * return value from the function; * GetLastError status; * file content of source, target and backup files (and presence thereof); * preservation of the attributes the API says are preserved (creation time, DACLs, etc). This is a lot to cover, but a simplified implementation with a basic set of tests that cover at least: * using NULL values in all permutations of source, target and backup file; * covering all premutations of file existing and not existing for the source, target and backup file; and checks at least: * return value from the function; * GetLastError status; * file content of source, target and backup files (and presence thereof); * a subset (or none) of the attributes being preserved. There should also be notes covering what functionality is missing. NOTE: I am not sure all of the above is possible without using Windows API calls, but that is where tests will help convince Alexandre. - Reece

Oct. 20, 2007

Re: [PATCH 3/3] configure: Use 0 instead of NULL because NULL isn't defined.

by Michael Stefaniuc

Alexandre Julliard wrote: > Michael Stefaniuc <mstefani(a)redhat.com> writes: > >> Actually it's not a cast. It's a heuristic that the compiler has to make >> to detect a NULL pointer. The best heuristic for this is (char *) 0. Duh ... that should have been (void *) 0. > There's no heuristic involved here, the assignment is clearly to a > pointer, and 0 is a perfectly valid null pointer, no cast is needed. I was talking more in general and not about this concrete case here. Both "0" and "(void *) 0" work here; which to use is a matter of style and thus good for a flame war. But i don't care too much to start one ;) bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111

Oct. 20, 2007

Re: Phoronix: Ubuntu 7.10 + WINE vs. Windows XP

by Stephan Rose

On Sat, 2007-10-20 at 09:51 +0000, L. Rahyen wrote: > On Saturday October 20 2007 09:28, Stephan Rose wrote: > > On Sat, 2007-10-20 at 09:21 +0000, L. Rahyen wrote: > > > But I think there is some people with dual boot configuration and modern > > > PC who has some games to test and enough free time to compare the results > > > between Windows and Linux. > > > > I can go ahead and try to install Supreme Commander and see if I can get > > it updated to the latest version. The auto-updater uses the .Net > > Framework so that makes it a little difficult. > > For .net support in WINE you can run "winetricks mono12" (you can get > winetricks at http://kegel.com/wine/winetricks ). Anyway, testing the latest > version of the game isn't very important, only important thing is to test > same version of the game on Windows and WINE. > > > But, it has a performance test / benchmark mode I could run to do some > > comparisons. > > > > Stephan > > It would be great. Don't forget to provide information about hardware > configuration used for testing, version of WINE and video drivers along with > FPS on Linux and Windows. Hardware: Intel Core 2 Duo 2.4 GHz 4gb 800MHz DDR2 4-4-4-12 Wine Version: 0.9.47 Video: nVidia 8800 GTX nVidia Driver Version Linux: 100.14.19 nVidia Driver Version XP: 162.18 Windows XP SP2 32-Bit Score: 16901 Ubuntu 7.10 64-Bit Score: 15996 Both performance tests were done with equal graphics settings at 1024x768. On that note, I noticed that ReplaceFileW still isn't implemented as it's not possible to safe a profile under Supreme Commander. Wasn't there a patch for this? I distinctly remember that because I was going to implement that function until I saw someone else had already submitted a patch with an implementation. What happened with that? Stephan

Oct. 20, 2007

Re: Phoronix: Ubuntu 7.10 + WINE vs. Windows XP

by Stefan Dösinger

Am Samstag, 20. Oktober 2007 10:40:33 schrieb Scott Ritchie: > speedator wrote: > > Hello everybody, > > new benchmark-test at phoronix.com: > > http://www.phoronix.com/scan.php?page=article&item=882&num=1 > > Wait, they tested 3D Mark 2001 and 3D Mark 2003... > > Weren't those the exact same benchmarks NVidia was found to be cheating > with by including hacks into their drivers on Windows? No wonder they > found Windows to be faster in the graphics tests! > > Can anyone find a real (ie, not rigged on Windows) benchmark to use? Yes, our own (nonexistant) benchmark. I'm afraid that is the only way. That's a bit much of an effort, but we can also tests where we have the source code available and can modify and recompile it, for example the sdk samples. Those aren't benchmarks, but they give us a rough understanding where our problems are. Just recompile them with gcc to break potential checksumming by the driver, change the filename and run them on windows and wine. SDK samples aren't suitable for general game benchmarking, and they don't make themselves as good for advertisement, but they are helpful for development.

Oct. 20, 2007

Re: [PATCH 3/3] configure: Use 0 instead of NULL because NULL isn't defined.

by Stefan Dösinger

Am Samstag, 20. Oktober 2007 00:36:13 schrieb Ken Thomases: > On Oct 19, 2007, at 5:24 PM, Stefan Dösinger wrote: > > Am Freitag, 19. Oktober 2007 23:18:51 schrieb Ken Thomases: > >> This makes the test test the proper thing on Mac OS X. It still > >> fails, but > >> for a good reason. > >> --- > >> configure.ac | 6 +++--- > >> 1 files changed, 3 insertions(+), 3 deletions(-) > >> > >> - char *name=NULL; > >> + char *name=0; > > > > Shouldn't that be (void *) 0 or (char *) 0? > > I don't think that's necessary. It compiled without warning here, > even with -Wall. Doesn't the C standard says that 0 casts to a > pointer naturally? Maybe that's C++. I think with -pedantic it warns about that. It could be gcc version dependent too.

Oct. 20, 2007

Re: Phoronix: Ubuntu 7.10 + WINE vs. Windows XP

by L. Rahyen

On Saturday October 20 2007 09:28, Stephan Rose wrote: > On Sat, 2007-10-20 at 09:21 +0000, L. Rahyen wrote: > > But I think there is some people with dual boot configuration and modern > > PC who has some games to test and enough free time to compare the results > > between Windows and Linux. > > I can go ahead and try to install Supreme Commander and see if I can get > it updated to the latest version. The auto-updater uses the .Net > Framework so that makes it a little difficult. For .net support in WINE you can run "winetricks mono12" (you can get winetricks at http://kegel.com/wine/winetricks ). Anyway, testing the latest version of the game isn't very important, only important thing is to test same version of the game on Windows and WINE. > But, it has a performance test / benchmark mode I could run to do some > comparisons. > > Stephan It would be great. Don't forget to provide information about hardware configuration used for testing, version of WINE and video drivers along with FPS on Linux and Windows.

Oct. 20, 2007

Solidworks 2007 Test with 0.9.47

by Stephan Rose

Major improvement with Solidworks 2007 on the latest version. Visually, everything actually looks perfect now. OpenGL windows are where they are supposed to be. Font is right. So from that end, everything appears to work very well. What's still broken: - Performance is extremely bad. Even on my Dual Core with 4 gigs of RAM. - Memory usage is extremely high still at around 2 gigs. - Extrude function, first thing I test as it's the most fundamental, still won't work. CPU will just go to full load on that core and just sit there forever. Infinite loop maybe? Definite improvement though, thanks everyone. =) Stephan

Oct. 20, 2007