October 2007 - Wine-Devel - list.winehq.org

Re: ntdll: Fix NtAccessCheck for NULL, but present SACLs and DACLs.

by Robert Shearman

Juan Lang wrote: > Hi Rob, > > - sd.sacl_len = (present ? sacl->AclSize : 0); > + sd.sacl_len = ((present && dacl) ? sacl->AclSize : 0); > > Shouldn't that be ((present && sacl) ? sacl->AclSize : 0); ? Good spot. It wouldn't be the first time I've mixed up dacls and sacls... Thanks, -- Rob Shearman

Oct. 15, 2007

Re: ntdll: Fix NtAccessCheck for NULL, but present SACLs and DACLs.

by Juan Lang

Hi Rob, - sd.sacl_len = (present ? sacl->AclSize : 0); + sd.sacl_len = ((present && dacl) ? sacl->AclSize : 0); Shouldn't that be ((present && sacl) ? sacl->AclSize : 0); ? --Juan

Oct. 15, 2007

Re: Make test drill, next steps, call for help with Winetest

by Detlef Riekenberg

On Mo, 2007-10-15 at 12:16 -0400, Dimi Paun wrote: > (And the rather > > non intuitive requirement to 'know' the unpublished > > url http://test.winehq.org/data/ is harsh). > > The plan was to have a home page at: > http://test.winehq.org > that would contain the explanation, plus an > index for the tests (hopefully organized nicely). Yes Please: http://bugs.winehq.org/show_bug.cgi?id=3187 -- By by ... Detlef

Oct. 15, 2007

re: Make test drill, next steps, call for help with Winetest

by Dan Kegel

>> There is a headless operation mode already, it detects >> if you run it as a service, and skips appropriate tests. > > Perhaps on Windows; I'm focused on Linux. How about wine net start winetest? <ducks> - Dan

Oct. 15, 2007

Re: Have `make distclean` also remove .i and .s files

by Alexandre Julliard

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > The GNU Coding Conventions (make distclean is a GNU invention as far > as I know) says the following: > > distclean: Delete all files in the current directory (or created by > this makefile) that are created by configuring or building the program. > If you have unpacked the source and built the program without creating > any other files, `make distclean` should leave only the files that were > in the distribution. > > Any chance of you reconsidering this? Well, following the GNU conventions would mean removing a lot of things from the existing make distclean, and I could be persuaded to do that. Adding *.i and *.s would be moving in the wrong direction, they are not generated by building Wine, except if you add special options; but if you allow this then there is no limit to the amount of things that we could potentially add. If you really want to remove everything except tracked files you can always use git-clean -x (of course you'd need to switch to git first ;-) -- Alexandre Julliard julliard(a)winehq.org

Oct. 15, 2007

Re: First batch of Swedish translation patches

by James Hawkins

On 10/15/07, Daniel Nylander <po(a)danielnylander.se> wrote: > > Here is the first batch of Swedish translation patches. > One patch per email. -- James Hawkins

Oct. 15, 2007

Re: Make test drill, next steps, call for help with Winetest

by Hans Leidekker

I have written attached script to facilitate automated winetest runs. It needs a VirtualBox virtual machine with either Windows or a Wine platform configured to run autorun.inf files. The script downloads the latest winetest binary and puts it in an iso image, along with an autorun file to trigger its execution when the image is 'inserted' into the virtual drive. A snapshot is used to revert the vm to its original state, so no need to worry about winetest screwing up your installation. -Hans #!/bin/bash if [ $# -lt 2 ]; then echo "Usage: $0 <vmname> <tag>" echo "" echo "vmname: Virtual machine to use (must be in suspended state). echo "tag: Tag built from [-.0-9a-zA-Z] to identify test report. exit 1 fi TMPDIR=/tmp/winetest$$ LOGFILE=$TMPDIR/log mkdir -p $TMPDIR/master echo "downloading winetest binary" wget -P $TMPDIR http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-latest.exe >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi mv $TMPDIR/winetest-latest.exe $TMPDIR/master/winetest.exe echo "creating autorun.inf" cat > $TMPDIR/master/autorun.inf <<_EOF_ [autorun] open=winetest.exe -q -t $2 _EOF_ echo "creating cd image" mkisofs -o $TMPDIR/winetest.iso $TMPDIR/master >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "checking vm $1 state" VBoxManage showvminfo $1 | grep "^State:" | grep "saved" >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "creating snapshot for vm $1" VBoxManage snapshot $1 take before-winetest >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "starting vm $1" VBoxManage startvm $1 >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "waiting until vm $1 is up and running" RUNNING="false" while [ $RUNNING != "true" ] do VBoxManage showvminfo $1 | grep "^State:" | grep "running" >> $LOGFILE 2>&1 if [ $? -eq 0 ]; then RUNNING="true" fi sleep 1 done echo "attaching cd image to vm $1" VBoxManage controlvm $1 dvdattach $TMPDIR/winetest.iso >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "sleeping while vm $1 runs winetest" sleep 1800 # 30 minutes should be enough for winetest to finish echo "suspending vm $1" VBoxManage controlvm $1 savestate >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "waiting until vm $1 is suspended" SAVED="false" while [ $SAVED != "true" ] do VBoxManage showvminfo $1 | grep "^State:" | grep "saved" >> $LOGFILE 2>&1 if [ $? -eq 0 ]; then SAVED="true" fi sleep 1 done echo "reverting vm $1 to previous state" VBoxManage snapshot $1 discardcurrent -all >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi rm -rf $TMPDIR exit 0

Oct. 15, 2007

Re: Have `make distclean` also remove .i and .s files

by Michael Stefaniuc

Alexandre Julliard wrote: > Gerald Pfeifer <gerald(a)pfeifer.com> writes: > >> After using GCC's -save-temps option to debug something, I noticed >> that `make distclean` fails to actually remove .i and .s files. >> >> This patch fixes it. I hope it's the right place to make this change? > > It would be, but I don't think we want make clean to remove all > possible output files from all possible tools. The current list is > probably too much already, it should really be limited to files that > are generated as part of the normal build process. That's why the right way to keep the source tree clean is to use a separate build dir. That way a "make reallyclean" is a simple "rm -r $wine_build_dir". bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

Oct. 15, 2007

Re: Have `make distclean` also remove .i and .s files

by Gerald Pfeifer

On Mon, 15 Oct 2007, Alexandre Julliard wrote: >> After using GCC's -save-temps option to debug something, I noticed >> that `make distclean` fails to actually remove .i and .s files. > It would be, but I don't think we want make clean to remove all > possible output files from all possible tools. I would argue that these aren't output files from some weirdo tool, but from GCC, at which point you could argue that these files are not generated with a default ./configure ; make. ;-) > The current list is probably too much already, it should really be > limited to files that are generated as part of the normal build process. Ugh, in fact that argument is already in your first mail. ;-) Well, I figured it's worth a try. The GNU Coding Conventions (make distclean is a GNU invention as far as I know) says the following: distclean: Delete all files in the current directory (or created by this makefile) that are created by configuring or building the program. If you have unpacked the source and built the program without creating any other files, `make distclean` should leave only the files that were in the distribution. Any chance of you reconsidering this? Gerald

Oct. 15, 2007

Re: Patch for adding Swedish localization

by Maarten Lankhorst

Daniel Nylander schreef: > How do I create a patch per file? There are 28 new files that needs to > be commited and one #include per dll/program to be added. Please help me > out, I'm not a developer If you created a git commit, you can undo it with git reset --mixed origin. Then do the following: git update-index --add dlls/somedll/newfile.rc dlls/somedll/existingfile.rc git commit -m 'somedll: Add swedish translations' Do this 28 times and then send it in. Good luck, Maarten.

Oct. 15, 2007