October 2007 - Wine-Devel - list.winehq.org

Re: Patch for adding Swedish localization

by Daniel Nylander

Maarten Lankhorst skrev: > Hi Daniel, > > You must add localizations for 1 dll/program at a time, that makes it a > lot easier to review. How do I create a patch per file? There are 28 new files that needs to be commited and one #include per dll/program to be added. Please help me out, I'm not a developer. -- Daniel Nylander (CISSP, GCUX, GCFA) Stockholm, Sweden http://www.DanielNylander.se info(a)danielnylander.se yeager(a)ubuntu.com dnylande(a)gnome.org

Oct. 15, 2007

Re: Have `make distclean` also remove .i and .s files

by Alexandre Julliard

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > After using GCC's -save-temps option to debug something, I noticed > that `make distclean` fails to actually remove .i and .s files. > > This patch fixes it. I hope it's the right place to make this change? It would be, but I don't think we want make clean to remove all possible output files from all possible tools. The current list is probably too much already, it should really be limited to files that are generated as part of the normal build process. -- Alexandre Julliard julliard(a)winehq.org

Oct. 15, 2007

Re: make crosstest - a catastrophic saga

by Hans Leidekker

On Monday 15 October 2007 19:24:27 Pedro Araújo wrote: > I've been consistently failing to 'make crosstest'... I've already tried my > distro's repositories, Hans Leidekker's patches, all to no avail. I wish I You need more patches ;) Wine tests are a fast moving target which means we're nearly always a couple of patches away from being able to cross compile current git. > undefined reference to `_CreateWellKnownSid(a)16' > undefined reference to `_GdiAlphaBlend(a)44' An easy way out for this type of error is to use Wine's import lib instead of MinGW's. E.g. run 'make libadvapi32.a' in dlls/advapi32 and copy the file over MinGW's version. -Hans

Oct. 15, 2007

Re: RICHED20: EM_SETTEXTEX must support RTF strings too

by Daniel Remenak

When you fix bugs that are documented in comments, please fix the comments also. At the top of the file: EM_SETTEXTEX 3.0 (no rich text insertion handling, proper style?) And in the case itself /* FIXME: this should support RTF strings too, according to MSDN */ Thanks, Daniel Remenak On 10/13/07, a_villacis(a)palosanto.com <a_villacis(a)palosanto.com> wrote: > Another fix for Zoiper (www.zoiper.com) This app can display an About dialog > with a richedit control that displays program credits. The text is a RTF > string pasted with EM_SETTEXTEX, which should result in formatted text being > displayed, but instead results in raw display of RTF codes. The attached > patch fixes this. > > Changelog: > * EM_SETTEXTEX should also support RTF strings, just like WM_SETTEXT > > > >

Oct. 15, 2007

make crosstest - a catastrophic saga

by Pedro Araújo

Hi all, I've been consistently failing to 'make crosstest'... I've already tried my distro's repositories, Hans Leidekker's patches, all to no avail. I wish I could use the test suite, but I need some custom local tests and therefore I need to be able to build win32 executables. However, I'm stuck getting this: > security.cross.o: In function `test_ConvertSecurityDescriptorToString':/home/foo/Wine/dlls/advapi32/tests/security.c:1996: undefined reference to `_CreateWellKnownSid(a)16' > :/home/foo/Wine/dlls/advapi32/tests/security.c:2006: undefined reference to `_CreateWellKnownSid(a)16' > collect2: ld returned 1 exit status > make[2]: *** [advapi32_crosstest.exe] Error 1 > make[2]: Leaving directory `/home/fooer/Wine/dlls/advapi32/tests' > make[1]: *** [advapi32/tests/__crosstest__] Error 2 > make[1]: Leaving directory `/home/fooer/Wine/dlls' > make: *** [dlls/__crosstest__] Error 2 or this, if I 'make crosstest -C dlls/gdi32/tests/': > bitmap.cross.o: In function `test_GdiAlphaBlend':/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1870: undefined reference to `_GdiAlphaBlend(a)44' > :/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1872: undefined reference to `_GdiAlphaBlend(a)44' > :/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1874: undefined reference to `_GdiAlphaBlend(a)44' > :/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1875: undefined reference to `_GdiAlphaBlend(a)44' > :/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1876: undefined reference to `_GdiAlphaBlend(a)44' > bitmap.cross.o:/home/foo/Wine/dlls/gdi32/tests/bitmap.c:1877: more undefined references to `_GdiAlphaBlend(a)44' follow > collect2: ld returned 1 exit status > make: *** [gdi32_crosstest.exe] Error 1 > make: Leaving directory `/home/fooer/Wine/dlls/gdi32/tests' What am I doing wrong? - Pedro. -- "Compatibility means deliberately repeating other people's mistakes." (David J. Wheeler)

Oct. 15, 2007

Bug in dlls/oleaut32/tests/vartype.c?

by Gerald Pfeifer

dlls/oleaut32/tests/vartype.c has the following snippet of code: + f = -1e-400; /* deliberately cause underflow */ + hres = pVarBstrFromR4(f, lcid, 0, &bstr); + ok(hres == S_OK, "got hres 0x%08lx\n", hres); + if (bstr) + { + todo_wine ok(memcmp(bstr, szZero, sizeof(szZero)) == 0, "negative zero (got %s)\n", wtoascii(bstr)); + } which was added in revision 1.27 Alex Villacís Lasso <a_villacis(a)palosanto.com> Test for behavior of negative underflow formatting. This doesn't seem to work as intended, because it is a floating point *constant* which current versions of GCC simply truncate to 0.0. Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

Oct. 15, 2007

Re: Make test drill, next steps, call for help with Winetest

by Dimi Paun

On Mon, 2007-10-15 at 11:18 -0500, Jeremy White wrote: > Perhaps on Windows; I'm focused on Linux. Is there > a way to trigger that when doing a 'wine winetest.exe.so'? Maybe "-c" (console mode, no GUI) -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

Oct. 15, 2007

Re: Make test drill, next steps, call for help with Winetest

by Jeremy White

> There is a headless operation mode already, it detects > if you run it as a service, and skips appropriate tests. Perhaps on Windows; I'm focused on Linux. Is there a way to trigger that when doing a 'wine winetest.exe.so'? Cheers, Jeremy

Oct. 15, 2007

Re: Make test drill, next steps, call for help with Winetest

by Dimi Paun

On Mon, 2007-10-15 at 10:48 -0500, Jeremy White wrote: > In my opinion, it needs the following: > > 1. A Wiki page! > > I could not find *any* documentation on this utility. > > For example, I'm still not entirely clear on how to > setup and/or register my build.id so that my results > are available on the web site. (And the rather > non intuitive requirement to 'know' the unpublished > url http://test.winehq.org/data/ is harsh). The plan was to have a home page at: http://test.winehq.org that would contain the explanation, plus an index for the tests (hopefully organized nicely). That didn't happen... > 2. Headless operation > > From my experiments, there were a number of dialogs > I had to dismiss, and some worrying complaints in > unpacking msvcrtd and msvcrt tests. > > This second point is probably a bit less important > than the first. There is a headless operation mode already, it detects if you run it as a service, and skips appropriate tests. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

Oct. 15, 2007

Make test drill, next steps, call for help with Winetest

by Jeremy White

Hi Folks, So I had plan to report on the status of make test, and sound a call to action. That is, one of the best and most fun things we did at Wineconf was to call bullshit on the failure of make test to work reliably. That is, it only runs cleanly on Alexandre's machine, and not even all the time then. So, we worked hard to make 'make test' work reliably on other folks systems at Wineconf. We made a lot of progress; cutting failures by half, I would say. The closest we got was with Michael; I think he was down to 3 at the end. However, we're still plagued with differences due to chipsets, locales, and other differences. But I think it is vital that we continue this work. The fact that 'make test' doesn't work anywhere, really, is bullshit. However, I'm enough of a weasel that I wanted to get out of collating all of this data myself. So I investigated (or tried to investigate) winetest to see if I could dump this work on a tool. And it looks like it would be great. Of course, with a few caveats :-/. In my opinion, it needs the following: 1. A Wiki page! I could not find *any* documentation on this utility. For example, I'm still not entirely clear on how to setup and/or register my build.id so that my results are available on the web site. (And the rather non intuitive requirement to 'know' the unpublished url http://test.winehq.org/data/ is harsh). 2. Headless operation From my experiments, there were a number of dialogs I had to dismiss, and some worrying complaints in unpacking msvcrtd and msvcrt tests. This second point is probably a bit less important than the first. However, it looked like if just a few little glitches could be ironed out, that it would be a fantastic tool for working on the make test problem. We'd be able to see the common failures, and work to resolve them and drive them to zero. Is there someone that could do the first part of this? Just document what is already there? Or point me to the page that exists that I just missed? Cheers, Jeremy

Oct. 15, 2007