October 2007 - Wine-Devel - list.winehq.org

Re: Fix casts in dlls/crypt32/decode.c

by Francois Gouget

On Mon, 15 Oct 2007, Robert Shearman wrote: > Gerald Pfeifer wrote: > > } > > if (!HIWORD(lpszStructType)) > > { > > - switch (LOWORD(lpszStructType)) > > + switch ((DWORD)lpszStructType) > > > > You're just passing the problem on to people doing 64-bit builds. You > should use DWORD_PTR or use LOWORD everywhere, like you suggested. The X509_* constants all look like small integers disguised as string pointers so the LOWORD() approach is probably the one that makes the most sense. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

Oct. 15, 2007

Re: Possible WIne regression with Warcraft

by Andrey Turkin

> > Let me take a wild guess. /etc/hosts resolves your hostname to a loopback > address, like 127.0.1.1 or somesuch. > > If that's the case, please change /etc/hosts to make your hostname resolve > to > your network card's IP address. > > If that's not the case, please attach a +winsock log to bug 9787. +winsock,+sync please. Another wild guess: maybe some out game update or something was recently rolled out?

Oct. 15, 2007

Re: Possible WIne regression with Warcraft

by Kai Blin

On Monday 15 October 2007 02:15:37 Michael Lothian wrote: > I've rolled all the way back to 0.9.43 but I still can't join a Local > Lan game (I don't use battlenet) > > So either the problem is in my setup (GCC 4.2.2 & Glibc 2.6.1) some > random change in the Kernel or perhaps using the git tree randomly > changed the registry which when rolled back still remains > > Any ideas folks? Let me take a wild guess. /etc/hosts resolves your hostname to a loopback address, like 127.0.1.1 or somesuch. If that's the case, please change /etc/hosts to make your hostname resolve to your network card's IP address. If that's not the case, please attach a +winsock log to bug 9787. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

Oct. 15, 2007

Re: Swedish translations

by Robert Shearman

Daniel Nylander wrote: > I have translated a lot of programs and dlls to Swedish. > Would be great if someone could commit this to git. > > http://home.danielnylander.se/translations/wine/wine-sv.tar.gz > > > Please also add the following to the ./tools/wine.desktop > > Name[sv]=Windows-emulatorn Wine > > You need to submit a patch to wine-patches yourself for numerous reasons. You can find out information for doing so at http://www.winehq.org/site/git and http://www.winehq.org/site/sending_patches. -- Rob Shearman

Oct. 15, 2007

Re: Fix casts in dlls/crypt32/decode.c

by Robert Shearman

Gerald Pfeifer wrote: > } > if (!HIWORD(lpszStructType)) > { > - switch (LOWORD(lpszStructType)) > + switch ((DWORD)lpszStructType) > You're just passing the problem on to people doing 64-bit builds. You should use DWORD_PTR or use LOWORD everywhere, like you suggested. -- Rob Shearman

Oct. 15, 2007

Re: Swedish translations

by James Hawkins

On 10/15/07, Daniel Nylander <po(a)danielnylander.se> wrote: > > I have translated a lot of programs and dlls to Swedish. > Would be great if someone could commit this to git. > It's your responsibility to get your own patches accepted. > http://home.danielnylander.se/translations/wine/wine-sv.tar.gz > Please read [1] to figure out how to send patches for inclusion in Wine. [1] http://winehq.org/site/sending_patches -- James Hawkins

Oct. 15, 2007

Re: Fix casts in dlls/crypt32/decode.c

by Dmitry Timoshkov

"Gerald Pfeifer" <gerald(a)pfeifer.com> wrote: > The patch below fixes the following diagnostics (rightfully) issued by > GCC 4.3 and later. If you prefer, we could use LOWORD everywhere, also > for the case labels, but my current patch seems to be more natural. > > decode.c:4365: warning: cast from pointer to integer of different size > --- decode.c 12 Oct 2007 10:24:15 -0000 1.87 > +++ decode.c 14 Oct 2007 14:17:58 -0000 > @@ -4360,103 +4360,103 @@ static CryptDecodeObjectExFunc CRYPT_Get > } > if (!HIWORD(lpszStructType)) > { > - switch (LOWORD(lpszStructType)) > + switch ((DWORD)lpszStructType) Your fix still won't work for a 64-bit target. You would need to use ULONG_PTR cast for that. 'if (!HIWORD(lpszStructType))' line also doesn't look right in the 64-bit case. dlls/crypt32/chain.c,CertVerifyCertificateChainPolicy() has the same problem. -- Dmitry.

Oct. 15, 2007

Re: Wiki looks much better

by Juan Lang

> OK, how about now? > http://wiki.winehq.org/FAQ +1, I like the paragraph breaks better. --Juan

Oct. 15, 2007

Re: Wiki looks much better

by Dimi Paun

On Sun, 2007-10-14 at 13:21 -0700, Scott Ritchie wrote: > If I may still whine for a bit, the FAQ page still looks a bit ugly > due to the lack of paragraph breaks. The "Wine/Cedega/Crossover" > question, for instance, needs some empty lines between the paragraphs. OK, how about now? http://wiki.winehq.org/FAQ -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

Oct. 15, 2007

Re: CSS changes to the Wiki

by Dimi Paun

On Sun, 2007-10-14 at 15:02 -0500, Mitchell Mebane wrote: > Anyway, you've got it almost right. It's still a bit cramped, but if > you add a > > .table-of-contents li { > line-height: 20px; > } > > to screen.css it will look the same as the preview. OK, it's in now, do people like it better? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

Oct. 15, 2007