November 2007 - Wine-Devel - list.winehq.org

re: ntdll: fix uninitialized buffers, found via valgrind

by Dan Kegel

James wrote: > Why did you move the variable declaration? Because the variable is only used inside the loop. Moving the declaration to the top of the loop is the right scoping. - Dan

Nov. 22, 2007

Re: Use GCC's -Wtype-limits

by Gerald Pfeifer

Hi Alexandre, On Wed, 21 Nov 2007, Alexandre Julliard wrote: >> If applied, I will commit to address, directly and by engaging others, >> the occurrences of such warnings in Wine. > I'm not opposed to applying it, but you have to fix the warnings first, > as far as possible the default build should not trigger any warnings. I have been submitting patches to address this, and got down the number quite a bit in my internal tree, but many of the patches I sent earlier this month haven't been applied or responded to yet except for those I resent. Should I continue resending the rest as well? GCC 4.3 hasn't been released yet and won't be released for a few months, so regular users/Wine contributors should not see these warnings, that's why I figured it would be good to get them in, for some of the more advanced hackers here to get exposure as well. Gerald 5B

Nov. 22, 2007

Re: d3dx8 [patch 7/7] Implement D3DXMatrixTransformation

by Ivan Gyurdiev

Any chance the formatting can be improved to include whitespace between blocks and proper indentation?

Nov. 22, 2007

Re: ntdll: fix uninitialized buffers, found via valgrind

by James Hawkins

On Nov 21, 2007 6:56 PM, Dan Hipschman <dsh(a)linux.ucla.edu> wrote: > > On Wed, Nov 21, 2007 at 06:53:27PM -0600, James Hawkins wrote: > > On Nov 21, 2007 6:08 PM, Zac Brown <zac(a)zacbrown.org> wrote: > > > Hi, > > > > > > Fixes valgrind error: > > > http://kegel.com/wine/valgrind/20071121/vg-ntdll_env.txt > > > > > > Changelog: > > > * Initialize buffers used in test using memset > > > > > > -- > > > Zac Brown <zac AT zacbrown DOT org> > > > > > > > > > dlls/ntdll/tests/env.c | 7 +++++-- > > > 1 files changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/dlls/ntdll/tests/env.c b/dlls/ntdll/tests/env.c > > > index d822946..90a3bf1 100644 > > > --- a/dlls/ntdll/tests/env.c > > > +++ b/dlls/ntdll/tests/env.c > > > @@ -80,8 +80,7 @@ static void testQuery(void) > > > {NULL, 0, 0, NULL} > > > }; > > > > > > - WCHAR bn[257]; > > > - WCHAR bv[257]; > > > + > > > UNICODE_STRING name; > > > UNICODE_STRING value; > > > const struct test* test; > > > @@ -89,6 +88,10 @@ static void testQuery(void) > > > > > > for (test = tests; test->var; test++) > > > { > > > + WCHAR bn[257]; > > > + WCHAR bv[257]; > > > + memset(bn, '\0', 257 * sizeof(WCHAR)); > > > + memset(bv, '\0', 257 * sizeof(WCHAR)); > > > name.Length = strlen(test->var) * 2; > > > name.MaximumLength = name.Length + 2; > > > name.Buffer = bn; > > > > > > > Why did you move the variable declaration? Also, please don't use > > magic constants; sizeof(bn) *sizeof(WCHAR) is what you want. > > Just sizeof bn. > oops, yes. -- James Hawkins

Nov. 22, 2007

Re: ntdll: fix uninitialized buffers, found via valgrind

by Dan Hipschman

On Wed, Nov 21, 2007 at 06:53:27PM -0600, James Hawkins wrote: > On Nov 21, 2007 6:08 PM, Zac Brown <zac(a)zacbrown.org> wrote: > > Hi, > > > > Fixes valgrind error: > > http://kegel.com/wine/valgrind/20071121/vg-ntdll_env.txt > > > > Changelog: > > * Initialize buffers used in test using memset > > > > -- > > Zac Brown <zac AT zacbrown DOT org> > > > > > > dlls/ntdll/tests/env.c | 7 +++++-- > > 1 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/dlls/ntdll/tests/env.c b/dlls/ntdll/tests/env.c > > index d822946..90a3bf1 100644 > > --- a/dlls/ntdll/tests/env.c > > +++ b/dlls/ntdll/tests/env.c > > @@ -80,8 +80,7 @@ static void testQuery(void) > > {NULL, 0, 0, NULL} > > }; > > > > - WCHAR bn[257]; > > - WCHAR bv[257]; > > + > > UNICODE_STRING name; > > UNICODE_STRING value; > > const struct test* test; > > @@ -89,6 +88,10 @@ static void testQuery(void) > > > > for (test = tests; test->var; test++) > > { > > + WCHAR bn[257]; > > + WCHAR bv[257]; > > + memset(bn, '\0', 257 * sizeof(WCHAR)); > > + memset(bv, '\0', 257 * sizeof(WCHAR)); > > name.Length = strlen(test->var) * 2; > > name.MaximumLength = name.Length + 2; > > name.Buffer = bn; > > > > Why did you move the variable declaration? Also, please don't use > magic constants; sizeof(bn) *sizeof(WCHAR) is what you want. Just sizeof bn.

Nov. 22, 2007

Re: ntdll: fix uninitialized buffers, found via valgrind

by James Hawkins

On Nov 21, 2007 6:08 PM, Zac Brown <zac(a)zacbrown.org> wrote: > Hi, > > Fixes valgrind error: > http://kegel.com/wine/valgrind/20071121/vg-ntdll_env.txt > > Changelog: > * Initialize buffers used in test using memset > > -- > Zac Brown <zac AT zacbrown DOT org> > > > dlls/ntdll/tests/env.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/dlls/ntdll/tests/env.c b/dlls/ntdll/tests/env.c > index d822946..90a3bf1 100644 > --- a/dlls/ntdll/tests/env.c > +++ b/dlls/ntdll/tests/env.c > @@ -80,8 +80,7 @@ static void testQuery(void) > {NULL, 0, 0, NULL} > }; > > - WCHAR bn[257]; > - WCHAR bv[257]; > + > UNICODE_STRING name; > UNICODE_STRING value; > const struct test* test; > @@ -89,6 +88,10 @@ static void testQuery(void) > > for (test = tests; test->var; test++) > { > + WCHAR bn[257]; > + WCHAR bv[257]; > + memset(bn, '\0', 257 * sizeof(WCHAR)); > + memset(bv, '\0', 257 * sizeof(WCHAR)); > name.Length = strlen(test->var) * 2; > name.MaximumLength = name.Length + 2; > name.Buffer = bn; > Why did you move the variable declaration? Also, please don't use magic constants; sizeof(bn) *sizeof(WCHAR) is what you want. -- James Hawkins

Nov. 22, 2007

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers [try 3]

by Stefan Dösinger

Hi, > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2007-11-22 Roman Mamedov <roman(a)rm.pp.ru> > + > + * dlls/wined3d/directx.c: > + wined3d: Implement detection of ATI cards with Mesa DRI drivers. > + Sorry, I missed this in the first patch: You don't have to update the changelog file in the patches. The ChangeLog is autogenerated from the git commit logs(ie, the subject in the patch file). I am not sure if Alexandre's scripts filter that out or if he asks to resend the patch.

Nov. 22, 2007

Re: wineprefixcreate: get xdg-user-dirs environment variables [1/2]

by Lei Zhang

On Nov 21, 2007 4:09 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > "Lei Zhang" <thestig(a)google.com> writes: > > > We need to get the "well known" XDG user directories so we can symlink to them. > > This should be done inside shell32, not in wineprefixcreate. > > -- > Alexandre Julliard > julliard(a)winehq.org > xdg-user-dirs provides xdg_user_dir_lookup() for doing this. [1] Is this something we can include in Wine? The code is under the MIT license. [1] http://webcvs.freedesktop.org/user-dirs/xdg-user-dirs/xdg-user-dir-lookup.c…

Nov. 21, 2007

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers

by Stefan Dösinger

Am Donnerstag, 22. November 2007 00:15:30 schrieb Roman Mamedov: > Hello. > > Presently, if an ATI card uses open-source DRI drivers from the Mesa > project ( http://dri.freedesktop.org/wiki/ATI ), Wine will report it to > Windows applications as being some generic nVIDIA model, based on D3D > capabilities of the card. The patch looks good to me content wise, but please attach it as an attachment to the mail instead of copypasting it into the mail. Also I am not sure if we should report R200 cards. They have pixel shader 1.x support on Windows, but Wine cannot implement this because the cards are too limited to support GL_ARB_fragment_program(~ ps 2.0), but there is no common extension that maps 1.x pixel shaders, only an ATI specific one. Any volunteers for a GL_ATI_fragment_shader shader backend :-) ? On the other hand, those cards support a few features that older cards did not have, like vertex shaders or volume textures. Also note that Alexandre is on holiday this week, so the patch won't be committed before next week.

Nov. 21, 2007

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers

by Roman Mamedov

James Hawkins wrote: >> If you send in a fixed patch, you need to add some variation of 'try >> X' in the subject, where X is the number of tries you're on. On top >> of this, you need to say in the body what you've changed between >> submissions. Thank you. I think I did mention the change in the body (just before the patch itself), maybe not very prominently, though. Sorry for the mistakes, it is the first time I submit a patch to Wine.

Nov. 21, 2007