November 2007 - Wine-Devel - list.winehq.org

Re: server: Change the get_dll_info server request to allow retrievingthe image file name of a process.

by Dmitry Timoshkov

"Robert Shearman" <rob(a)codeweavers.com> wrote: > + if (req->exe_module) > + dll = list_head( &process->dlls ) ? > + LIST_ENTRY(list_head( &process->dlls ), struct process_dll, entry) : NULL; > + else > + dll = find_process_dll( process, req->base_address ); Is it really necessary to introduce the exe_module request parameter? Main executable has its own base address which should work just fine in find_process_dll(). -- Dmitry.

Nov. 20, 2007

Re: wininet: InternetAttemptConnect() Stub

by Pavel Troller

> Hi Pavel, > > On Nov 19, 2007 6:30 AM, Pavel Troller <patrol(a)sinus.cz> wrote: > > I have a problem running an offline client for ordering photo prints from > > digital cameras. > > Even it is an "offline" client, it requires the computer to be online. > > It seems that in wine, it feels to be offline, thus refusing further > > operation with a dialog saying something like "Internet connection unavailable" > > and terminating. The machine is normally connected to the LAN with full net > > availability. > > The following is its full console log. > > > > patrol(a)gonio:~/.wine/drive_c/Program Files/droxi/OfflineClient$ wine PhotoOfflineClient.exe > > fixme:wininet:InternetGetConnectedState always returning LAN connection. > > fixme:win:SetLayeredWindowAttributes (0x10030,0x00000000,255,2): stub! > > fixme:win:LockWindowUpdate (0x10028), partial stub! > > fixme:win:LockWindowUpdate ((nil)), partial stub! > > fixme:shdocvw:OleObject_Close (0x199510)->(1) > > fixme:wininet:InternetAttemptConnect Stub > > I don't think either wininet fixme is telling you anything worthwhile. > As you already pointed out, the first one seems okay: a LAN > connection is what it most likely expects anyway. The second stub, if > you look at the source, returns ERROR_SUCCESS, which is what MSDN says > it should return if it succeeds. > > I think you're going to have to try a +relay log and scanning through > it ti figure out why it thinks it's offline. > --Juan > Just for your info, you're right, I was not carefull enough to verify what's happening and started writing too soon. The program is communicating happily with a lot of servers, downloads a plenty of files... and then it writes that the connection doesn't work. It seems that either it gets something wrong from one of the servers, or it crashes for another reason and the message is disinformative. I've captured its net activities by Wireshark and we are going to compare them with the log gathered when it runs on windows. With regards, Pavel Troller

Nov. 20, 2007

Re: bits: Description of patch set (resend 2) (0/26)

by Roy Shea

On Mon, Nov 19, 2007 at 08:31:31PM -0600, James Hawkins wrote: > On Nov 19, 2007 6:19 PM, Roy Shea <roy(a)cs.hmc.edu> wrote: > > Howdy, > > > > This is another resend of the BITS patch set. This resend changes > > svnhost to be ANSI based, merges patches 25 and 26 (old numbering), > > and removes extra headers and linked libraries. > > > > Any particular reason for using ansi? Generally we're moving > everything towards unicode and away from ansi. Also, the entire patch > set is relatively large, and you might want to consider breaking the > set up into chunks (svnhost, bits cleanup etc, bits interface impl) > and waiting till the first chunk is committed before moving on to the > next. That'll make it easier to get the patches committed (assuming > they don't get accepted this time) and it'll keep the mail count down > for list members. > I looked into switching svchost to ansi since there is no unicode version of GetProcAddress (used within svchost). I ended up asking on winehackers if there is a preference between unicode and ansi, but guessed that it didn't much matter since there was no strong response either way. Rather than juggle ansi and unicode strings, I bumped svchost over to ansi. Good to know that unicode is the way to go. I'll send a unicode version of the patch out in a few minutes. I'll also see what I can do about breaking up the patch set for future resubmissions. Peace, -Roy

Nov. 20, 2007

Re: mshtml #6: Change FIXME that is usually invalid to TRACE.

by James Hawkins

On Nov 19, 2007 6:51 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/mshtml/navigate.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > How about a warn instead of a trace? That is unless all the correct interfaces are already available, and any other requested interface shouldn't be available. -- James Hawkins

Nov. 20, 2007

Re: bits: Description of patch set (resend 2) (0/26)

by James Hawkins

On Nov 19, 2007 6:19 PM, Roy Shea <roy(a)cs.hmc.edu> wrote: > Howdy, > > This is another resend of the BITS patch set. This resend changes > svnhost to be ANSI based, merges patches 25 and 26 (old numbering), > and removes extra headers and linked libraries. > Any particular reason for using ansi? Generally we're moving everything towards unicode and away from ansi. Also, the entire patch set is relatively large, and you might want to consider breaking the set up into chunks (svnhost, bits cleanup etc, bits interface impl) and waiting till the first chunk is committed before moving on to the next. That'll make it easier to get the patches committed (assuming they don't get accepted this time) and it'll keep the mail count down for list members. -- James Hawkins

Nov. 20, 2007

Re: Missed Patches

by Alistair Leslie-Hughes

"Jacek Caban" <jacek(a)codeweavers.com> wrote in message news:47423F2E.5040005(a)codeweavers.com... > Alistair Leslie-Hughes wrote: >> Any other pointers? >> > This interface shouldn't be available in BSCallback. You probably added > it because of the FIXME message. I've sent a patch that silences it. In > the future you should check if interface is available in Windows before > adding them to Wine. > Yes, I did add it beacuse of the FIXME, but that is beacuse the application Im trying to get running uses it. (maybe Indirectly) Without the patch I just get a access Voliation. I see that it is wrong. How/where should I Implement it to stop the access Voliation. I can provide stacktrace if needed. Best Regards Alistair leslie-Hughes

Nov. 20, 2007

Re: Missed Patches

by Jacek Caban

Alistair Leslie-Hughes wrote: > Any other pointers? > This interface shouldn't be available in BSCallback. You probably added it because of the FIXME message. I've sent a patch that silences it. In the future you should check if interface is available in Windows before adding them to Wine. Jacek

Nov. 20, 2007

Re: Missed Patches

by Alistair Leslie-Hughes

"Jacek Caban" <jacek(a)codeweavers.com> wrote in message news:47423064.5060209(a)codeweavers.com... > Alistair Leslie-Hughes wrote: >> Hi, >> Is there any reason the following patches haven't been applied? >> > [...] > >> mshtml: Provide support for the IInternetProtocol Interface >> > > The patch is obviously wrong. Did you run tests with Gecko installed? It > probably won't fail, but you will see some tests skipped. > > Yes I did have Gecko installed when I ran the tests. Ok, I see the skipped tests. So I need to Run tests again without Gecko installed? (Correct test if needed) Any other pointers? Best Regards Alistair Leslie-Hughes

Nov. 20, 2007

Re: Missed Patches

by Jacek Caban

Alistair Leslie-Hughes wrote: > Hi, > Is there any reason the following patches haven't been applied? > [...] > mshtml: Provide support for the IInternetProtocol Interface > The patch is obviously wrong. Did you run tests with Gecko installed? It probably won't fail, but you will see some tests skipped. Jacek

Nov. 20, 2007

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

by devzero＠web.de

i`ve tracked this down to a watchdog issue. whenever i do "cat /dev/watchdog" - my system reboots after ~1 minute. i`ve contacted the maintainer of the watchdog subsystem. looks like a bug to me. thanks roland > -----Ursprüngliche Nachricht----- > Von: "Hans Leidekker" <hans(a)it.vu.nl> > Gesendet: 19.11.07 21:59:29 > An: wine-devel(a)winehq.org > Betreff: Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW > > On Monday 19 November 2007 21:39:16 devzero(a)web.de wrote: > > > i retried with ordinary account and the crash didn`t happen there. > > anyway - should i expect such problems with root ? > > Well, a reboot is not expected but it can certainly happen. If your > app is leaking file descriptors for example, given that there are no > limits for root, it will bring your system to a halt. > > -Hans > ______________________________________________________________________________ Jetzt neu! Im riesigen WEB.DE Club SmartDrive Dateien freigeben und mit Freunden teilen! http://www.freemail.web.de/club/smartdrive_ttc.htm/?mc=021134

Nov. 20, 2007