November 2007 - Wine-Devel - list.winehq.org

Re: Wrong comparison in ntdll/actctx.c

by nlataill

Hi, Yes, I can see that such 4-level comparisons are already in the actctx.c codebase (probably for a reason ?). Looking at MSDN earlier this evening, I could not find reference to 3rd and 4th entries in comparisons, but I probably skipped the right section in the doc. Do you believe it is worthwhile to check this comparison function from a windows test perspective ? Thanks, Norbert 2007/11/19, Robert Shearman <rob(a)codeweavers.com>: > > nlataill wrote: > > Adding verbosity to actctx.c, it seems that this game is requesting > > version 8.0.50608.0, which does match major.minor, > > but not the whole version number (/major.minor.build.revision)/. > > > ... > > According to MSDN, it seems only major.minor is considered for version > > matching: > > - http://msdn2.microsoft.com/en-us/library/aa374234.aspx : A version > > number that changes only in the /build/ or /revision/ parts indicates > > that the assembly is backward compatible with prior versions. > > - http://msdn2.microsoft.com/en-us/library/aa375365.aspx: [...] are > > manifests used to redirect the version of a side-by-side assembly to > > another compatible version. The version that the assembly is being > > redirected to should have the same major.minor values as the original > > version. > > > > I am proposing the following one-liner to ntdll/actctx.c: > > > > isa(a)isa:~/downloads/tmp$ diff -u wine-0.9.49/dlls/ntdll/actctx.c > > /home/isa/downloads/wine-0.9.49/dlls/ntdll/actctx.c > > --- wine-0.9.49/dlls/ntdll/actctx.c 2007-11-09 17:56: 12.000000000 > > +0100 > > +++ /home/isa/downloads/wine-0.9.49/dlls/ntdll/actctx.c 2007-11-19 > > 21:07:35.000000000 +0100 > > @@ -1390,8 +1390,8 @@ > > if (expected_ai) > > { > > /* FIXME: more tests */ > > - if (assembly->type == ASSEMBLY_MANIFEST && > > - memcmp(&assembly->id.version, &expected_ai->version, > > sizeof(assembly->id.version))) > > + if (assembly->type == ASSEMBLY_MANIFEST && > > + ((assembly->id.version.major != > > expected_ai->version.major) || (assembly->id.version.minor != > > expected_ai->version.minor)) ) > > { > > FIXME("wrong version\n"); > > return FALSE; > > > > With this patch, the manifest (and related DLL) is loading correctly. > > This does not prevent my game die shortly after, in D3D code this > > time. Still work to do ;-) > > I think the attached patch is more complete and implements what MSDN > states. > > -- > Rob Shearman > > >

Nov. 19, 2007

Re: Wrong comparison in ntdll/actctx.c

by Robert Shearman

nlataill wrote: > Adding verbosity to actctx.c, it seems that this game is requesting > version 8.0.50608.0, which does match major.minor, > but not the whole version number (/major.minor.build.revision)/. > ... > According to MSDN, it seems only major.minor is considered for version > matching: > - http://msdn2.microsoft.com/en-us/library/aa374234.aspx : A version > number that changes only in the /build/ or /revision/ parts indicates > that the assembly is backward compatible with prior versions. > - http://msdn2.microsoft.com/en-us/library/aa375365.aspx: [...] are > manifests used to redirect the version of a side-by-side assembly to > another compatible version. The version that the assembly is being > redirected to should have the same major.minor values as the original > version. > > I am proposing the following one-liner to ntdll/actctx.c: > > isa(a)isa:~/downloads/tmp$ diff -u wine-0.9.49/dlls/ntdll/actctx.c > /home/isa/downloads/wine-0.9.49/dlls/ntdll/actctx.c > --- wine-0.9.49/dlls/ntdll/actctx.c 2007-11-09 17:56: 12.000000000 > +0100 > +++ /home/isa/downloads/wine-0.9.49/dlls/ntdll/actctx.c 2007-11-19 > 21:07:35.000000000 +0100 > @@ -1390,8 +1390,8 @@ > if (expected_ai) > { > /* FIXME: more tests */ > - if (assembly->type == ASSEMBLY_MANIFEST && > - memcmp(&assembly->id.version, &expected_ai->version, > sizeof(assembly->id.version))) > + if (assembly->type == ASSEMBLY_MANIFEST && > + ((assembly->id.version.major != > expected_ai->version.major) || (assembly->id.version.minor != > expected_ai->version.minor)) ) > { > FIXME("wrong version\n"); > return FALSE; > > With this patch, the manifest (and related DLL) is loading correctly. > This does not prevent my game die shortly after, in D3D code this > time. Still work to do ;-) I think the attached patch is more complete and implements what MSDN states. -- Rob Shearman

Nov. 19, 2007

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

by devzero＠web.de

checked if app is leaking fd`s, but lsof didn`t tell anything special. after some investigation i came across the following entry in dmesg: iTCO_wdt: Unexpected close, not stopping watchdog seems that wine is triggering something with this - after unloading iTCO_wdt kernel module, the problem went away. looks that wine is (un-)triggering the watchdog timer and the reboot happens due to this. will further investigate (strace) - maybe i can provide some more input so, it`s probably not a wine issue.... regards roland > -----Ursprüngliche Nachricht----- > Von: "Hans Leidekker" <hans(a)it.vu.nl> > Gesendet: 19.11.07 21:59:29 > An: wine-devel(a)winehq.org > Betreff: Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW > > On Monday 19 November 2007 21:39:16 devzero(a)web.de wrote: > > > i retried with ordinary account and the crash didn`t happen there. > > anyway - should i expect such problems with root ? > > Well, a reboot is not expected but it can certainly happen. If your > app is leaking file descriptors for example, given that there are no > limits for root, it will bring your system to a halt. > > -Hans > __________________________________________________________________________ Erweitern Sie FreeMail zu einem noch leistungsstärkeren E-Mail-Postfach! Mehr Infos unter http://produkte.web.de/club/?mc=021131

Nov. 19, 2007

Missed Patches

by Alistair Leslie-Hughes

Hi, Is there any reason the following patches haven't been applied? [1/2] msxml: Implement createTextNode [2/2] msxml: Tests for createTextNode mshtml: Provide support for the IInternetProtocol Interface Best Regards Alistair Leslie-Hughes

Nov. 19, 2007

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

by Hans Leidekker

On Monday 19 November 2007 21:39:16 devzero(a)web.de wrote: > i retried with ordinary account and the crash didn`t happen there. > anyway - should i expect such problems with root ? Well, a reboot is not expected but it can certainly happen. If your app is leaking file descriptors for example, given that there are no limits for root, it will bring your system to a halt. -Hans

Nov. 19, 2007

Re: recent cedega contributions to wine

by Gavriel State

Stefan Dösinger wrote: >> "TransGaming's developers have been contributing some changes back to Wine >> as well, including in several networking and debugging libraries. " >> >> Just out of curiousity, which patches are these? >> > A wine-patches archive search finds these: > > http://article.gmane.org/gmane.comp.emulators.wine.patches/32979 > http://article.gmane.org/gmane.comp.emulators.wine.patches/32981 > http://article.gmane.org/gmane.comp.emulators.wine.patches/32982 > > http://article.gmane.org/gmane.comp.emulators.wine.patches/39016 > http://article.gmane.org/gmane.comp.emulators.wine.patches/39017 > http://article.gmane.org/gmane.comp.emulators.wine.patches/33632 > http://article.gmane.org/gmane.comp.emulators.wine.patches/3363 Hi All, There are some additional patches coming down the pipe shortly for dbghelp, which we've done extensive work with in the past few months. There was a communications mixup in that those changes have been merged into our external public CVS under the LGPL (http://cvs.transgaming.org/cgi-bin/viewcvs.cgi/winex/dlls/dbghelp) but haven't yet made it to wine-patches. The main thing holding up the patch submission there is the trace system changes that went into WineHQ to resolve some of the warning differences for printfs on different platforms. We are still using platform printf on our side, and our dbghelp changes include a bunch of changes to the traces that need to be backed out before a patch gets submitted to wine-patches. We certainly plan to continue contributing more code beyond this, which was why we made an explicit mention of it in the newsletter. Take care, -Gav -- Gavriel State Founder & CTO TransGaming Inc. gav(a)transgaming.com http://www.transgaming.com Broadening The Playing Field

Nov. 19, 2007

Re: Wrong comparison in ntdll/actctx.c

by Stefan Dösinger

Am Montag, 19. November 2007 21:25:25 schrieb nlataill: > Working on a D3D game, I have found that wine is refusing to load the > following > manifest file (when Windows does not fail). > > I am proposing the following one-liner to ntdll/actctx.c: You can send patches to wine-patches(a)winehq.org. Please use git-format-patch to create the diff file, and mail it as a regular attachment. You have to be subscribed to the list, otherwise your patch will end up in moderation, but you can turn off mail delivery so your inbox doesn't get spammed. > According to MSDN, it seems only major.minor is considered for version > matching: The msdn is sometimes wrong, it is a good idea to include a test in the patch(see dlls/ntdll/tests/). This shows your change is correct, and prevents others from changing it back because it happens to fix a different bug.

Nov. 19, 2007

Re: credui: Show a balloon tip in the credential dialog if CREDUI_FLAGS_INCORRECT_PASSWORD was specified.

by Robert Shearman

Juan Lang wrote: > Hi Rob, > > + IDS_INCORRECTPASSWORDTITLE "Logon unsucessful" > > The typo's your own work too, eh? Absolutely! -- Rob Shearman

Nov. 19, 2007

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

by devzero＠web.de

> Yes, Wine shouldn't be able to do that. You're not running Wine > as root are you? whoops - i did. shame on me :) i retried with ordinary account and the crash didn`t happen there. anyway - should i expect such problems with root ? >Does your system log reveal anything about the crash? no, unfortunately not regards roland > -----Ursprüngliche Nachricht----- > Von: "Hans Leidekker" <hans(a)it.vu.nl> > Gesendet: 19.11.07 21:22:20 > An: "http://freemail.web.de/" <devzero(a)web.de> > Betreff: Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW > > On Monday 19 November 2007 20:59:46 devzero(a)web.de wrote: > > > when scannnig trough drive z:\ , my notebook reboots ! > > wasn`t wine a userspace application with no kernel related stuff ? > > so it`s weird, that windirstat is crashing my notebook, isn`t it ? > > Yes, Wine shouldn't be able to do that. You're not running Wine > as root are you? Does your system log reveal anything about the crash? > > -Hans > ______________________________________________________________________ XXL-Speicher, PC-Virenschutz, Spartarife & mehr: Nur im WEB.DE Club! Jetzt testen! http://produkte.web.de/club/?mc=021130

Nov. 19, 2007

Re: d3dx8 [patch 1/10] Implement D3DXPlaneFromPointNormal

by Stefan Dösinger

Am Montag, 19. November 2007 21:19:08 schrieb Vijay Kiran Kamuju: > Why not having the functionality of d3dx in wined3d, instead of having > a separate d3dx library called wined3dx? > I like the having all the common functionality of d3drm,d3dx8, d3dx9_* > and d3dxof dlls at one place and for all the version dependent stuff, > we keep it the respective dlls. Because it is in a separate DLL in Windows. But it is an option to put it into wined3d. Also, wined3d is quite huge. The stripped binary has 926 kb of plain code - no graphics, nothing. Also, it is preferable that d3dx* can run on Windows without wined3d. Having a wined3d.dll around is not a big deal as long as it works without actually using the low level d3d parts of wined3d. I am not opposed to put d3dx things into wined3d, but I think it is nicer to have it separate.

Nov. 19, 2007