November 2007 - Wine-Devel - list.winehq.org

Re: imagelist test exception?

by Dan Kegel

On Nov 19, 2007 6:58 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > It's a DIB access exception, it's perfectly normal, it's used to trigger > a copy of the DIB bits from the X server. Oh, right, thanks! - Dan

Nov. 19, 2007

Re: imagelist test exception?

by Alexandre Julliard

"Dan Kegel" <dank(a)kegel.com> writes: > comctl32/tests/imagelist.c seems to throw an exception > during GetDIBits(), but for some reason, the test continues > and succeeds (except in Valgrind, which is why I noticed). > Do other folks also see a seh exception in the +seh log > on this test? > > I narrowed the test case down a bit (see patch). > Can anyone clue me in on what's going on here? It's a DIB access exception, it's perfectly normal, it's used to trigger a copy of the DIB bits from the X server. -- Alexandre Julliard julliard(a)winehq.org

Nov. 19, 2007

Re: imagelist test exception?

by Dan Kegel

On Nov 19, 2007 6:36 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Dan Kegel wrote: > > comctl32/tests/imagelist.c seems to throw an exception > > during GetDIBits(), but for some reason, the test continues > > and succeeds (except in Valgrind, which is why I noticed). > > FWIW I have several exceptions when running the imagelist test. Marcus pointed me to X11DRV_DIB_FaultHandler I think the exceptions are handled properly by wine, but it might be a benign accident that the test case is causing them.

Nov. 19, 2007

Re: imagelist test exception?

by Paul Vriens

Dan Kegel wrote: > comctl32/tests/imagelist.c seems to throw an exception > during GetDIBits(), but for some reason, the test continues > and succeeds (except in Valgrind, which is why I noticed). > Do other folks also see a seh exception in the +seh log > on this test? > > I narrowed the test case down a bit (see patch). > Can anyone clue me in on what's going on here? > > > ------------------------------------------------------------------------ > > Hi Dan, FWIW I have several exceptions when running the imagelist test. (I also see a lot of these exceptions while I was/am debugging Skype, they are all DIB related). -- Cheers, Paul.

Nov. 19, 2007

wininet: InternetAttemptConnect() Stub

by Pavel Troller

Hi! I have a problem running an offline client for ordering photo prints from digital cameras. Even it is an "offline" client, it requires the computer to be online. It seems that in wine, it feels to be offline, thus refusing further operation with a dialog saying something like "Internet connection unavailable" and terminating. The machine is normally connected to the LAN with full net availability. The following is its full console log. patrol(a)gonio:~/.wine/drive_c/Program Files/droxi/OfflineClient$ wine PhotoOfflineClient.exe fixme:wininet:InternetGetConnectedState always returning LAN connection. fixme:win:SetLayeredWindowAttributes (0x10030,0x00000000,255,2): stub! fixme:win:LockWindowUpdate (0x10028), partial stub! fixme:win:LockWindowUpdate ((nil)), partial stub! fixme:shdocvw:OleObject_Close (0x199510)->(1) fixme:wininet:InternetAttemptConnect Stub I see two network related fixmes - the first one is very frequent but it seems harmless, many programs are able to use the net even they issue such a message. However, the second fixme looks more interesting, it looks like that the program tries to activate the internet connection, which is of course just a stub. Why is it doing so, I don't know. Is this information enough to find a problem (and maybe its fix) or is more debugging needed ? What else to try ?

Nov. 19, 2007

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)

by Alexandre Julliard

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I had expected this comment for a different patch of mine. In > dlls/gdi32/enhmetafile.c we are just reading existing records, > so I'm not sure what you have in mind here? The records usually come from an external file, so they have to be validated (not that this is done correctly everywhere, but we should move towards more validation, not less). -- Alexandre Julliard julliard(a)winehq.org

Nov. 19, 2007

Re: recent cedega contributions to wine

by Tom Wickline

On Nov 19, 2007 8:36 AM, EA Durbin <ead1234(a)hotmail.com> wrote: > > > > > Date: Mon, 19 Nov 2007 08:14:11 -0500 > > From: twickline(a)gmail.com > > To: stefandoesinger(a)gmx.at > > Subject: Re: recent cedega contributions to wine > > CC: wine-devel(a)winehq.org > > > > > WhooHoo five patches made it into the Wine tree in three YEARS! > > > > Here is a list of patches over the past five years.. But five patches > > in three years is grounds for a announcement? > > > > :D > > > > The announcement on their dev report comes after 3 months of ignoring > user's support tickets, it makes it look like there's been a sudden surge of > collaboration with wine and "several" patches have been put back into the > wine tree. > Or in other words there typical "smoke and mirrors" dev reports....

Nov. 19, 2007

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)

by Gerald Pfeifer

On Mon, 19 Nov 2007, Alexandre Julliard wrote: >> The members of EMRCREATEDIBPATTERNBRUSHPT are of type DWORD, so >> comparing them for >= 0 is a noop which always evaluates to true. >> >> Gerald >> >> ChangeLog: >> Remove four unnecessary comparisions of DWORD variables for >= 0. > Validating the record is not unnecessary, it just needs to be done > correctly by checking for wraparounds etc. I had expected this comment for a different patch of mine. In dlls/gdi32/enhmetafile.c we are just reading existing records, so I'm not sure what you have in mind here? Gerald

Nov. 19, 2007

imagelist test exception?

by Dan Kegel

comctl32/tests/imagelist.c seems to throw an exception during GetDIBits(), but for some reason, the test continues and succeeds (except in Valgrind, which is why I noticed). Do other folks also see a seh exception in the +seh log on this test? I narrowed the test case down a bit (see patch). Can anyone clue me in on what's going on here?

Nov. 19, 2007

RE: recent cedega contributions to wine

by EA Durbin

> Date: Mon, 19 Nov 2007 08:14:11 -0500> From: twickline(a)gmail.com> To: stefandoesinger(a)gmx.at> Subject: Re: recent cedega contributions to wine> CC: wine-devel(a)winehq.org> > WhooHoo five patches made it into the Wine tree in three YEARS!> > Here is a list of patches over the past five years.. But five patches> in three years is grounds for a announcement?> > :D> The announcement on their dev report comes after 3 months of ignoring user's support tickets, it makes it look like there's been a sudden surge of collaboration with wine and "several" patches have been put back into the wine tree. _________________________________________________________________ Connect and share in new ways with Windows Live. http://www.windowslive.com/connect.html?ocid=TXT_TAGLM_Wave2_newways_112007

Nov. 19, 2007