November 2007 - Wine-Devel - list.winehq.org

re: advapi32/service.c -- remove untriggerable check

by Dan Kegel

Uwe wrote: >Gerald Pfeifer writes: > >> n is of type DWORD which is unsigned, so n < 0 always will >> evaluate to false. > > Is dropping the check the right answer? Shouldn't the check test for high > values like > 0xff00 and report a possible problem? Indeed. IMHO we don't need patches like this, and Gerald is not thinking hard enough. Simplistic just-remove-the-warning patches are a Bad Thing, and we Don't Want To Encourage Them. Please stop. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

Nov. 18, 2007

Re: advapi32/service.c -- remove untriggerable check

by Uwe Bonnes

>>>>> "Gerald" == Gerald Pfeifer <gerald(a)pfeifer.com> writes: Gerald> n is of type DWORD which is unsigned, so n < 0 always will Gerald> evaluate to false. Gerald> Gerald Gerald> ChangeLog: Remove untriggerable check. Gerald> Index: dlls/advapi32/service.c Gerald> =================================================================== Gerald> RCS file: /home/wine/wine/dlls/advapi32/service.c,v retrieving Gerald> revision 1.160 diff -u -3 -p -r1.160 service.c --- Gerald> dlls/advapi32/service.c 15 Oct 2007 16:29:59 -0000 1.160 +++ Gerald> dlls/advapi32/service.c 18 Nov 2007 06:01:28 -0000 @@ -2107,9 Gerald> +2107,6 @@ QueryServiceConfigW( SC_HANDLE hService, n -= Gerald> sizeof(WCHAR); } Gerald> - if( n < 0 ) - ERR("Buffer overflow!\n"); - TRACE("Image path = Gerald> %s\n", debugstr_w(lpServiceConfig->lpBinaryPathName) ); Gerald> TRACE("Group = %s\n", Gerald> debugstr_w(lpServiceConfig->lpLoadOrderGroup) ); Gerald> TRACE("Dependencies = %s\n", Gerald> debugstr_w(lpServiceConfig->lpDependencies) ); Is dropping the check the right answer? Shouldn't the check test for high values like > 0xff00 and report a possible problem? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

Nov. 18, 2007

Wine and LD_PRELOAD

by Lionel Tricon

Hi wine list, I am currently working for the next generation of the klik project (1 application = 1 file) and we actualy face some troubles with picasa which is running under linux thanks to wine. It seems that wine deal badly with the LD_PRELOAD feature which is one of the main composant we use to virtualize and execute the application (with fuse for the underlying filesystem). Is there a way to force wine to go through LD_PRELOAD (to overload some system calls) ? or this limitation is driven by the architecture ? Thanks in advance, Lionel Tricon

Nov. 18, 2007

Re: Valgrind results for Nov 12 & 13

by Shachar Shemesh

Dan Kegel wrote: > Oh, he'd undoubtedly prefer ignoring to memsetting. > I believe the "official" answer is to teach valgrind which fields are important for which server request. Granted, it a lot more work, but it's the only way we will actually catch errors :-) Shachar

Nov. 18, 2007

Re: bits: Added framework for testing the BackgroundCopyJob interface (25/27)

by Detlef Riekenberg

On Fr, 2007-11-16 at 16:21 -0800, Roy Shea wrote: > +/* Generic test setup */ > +static BOOL setup(void) unused code > +/* Generic test cleanup */ > +static void teardown(void) unused code +START_TEST(job) > +{ > + CoInitialize(NULL); > + CoUninitialize(); > +} Do you want to call "setup()" and "teardown()" here? -- By by ... Detlef

Nov. 18, 2007

Re: bits: INF and resource file for qmgr registration (8/27)

by Detlef Riekenberg

On Fr, 2007-11-16 at 16:16 -0800, Roy Shea wrote: > dlls/qmgr/qmgr.inf | 32 ++++++++++++++++++++++++++++++++ > dlls/qmgr/rsrc.rc | 21 +++++++++++++++++++++ > 2 files changed, 53 insertions(+), 0 deletions(-) The change for Makefile.in to add rsrc.rc is missing here. (found in the next patch) -- By by ... Detlef

Nov. 18, 2007

Re: gdi32: Add stub for RemoveFontMemResourceEx

by Dmitry Timoshkov

"Klaus Layer" <klaus.layer(a)gmx.de> wrote: > Nokia PC Suite installation crashes due to missing function > RemoveFontMemResourceEx. This patch adds function RemoveFontMemResourceEx > which just calls WineEngRemoveFontMemResourceEx as stub You forgot to create WineEngRemoveFontMemResourceEx implementation for a case when HAVE_FREETYPE is not defined. -- Dmitry.

Nov. 18, 2007

Re: Removing Windows and Solaris from the Downloads page

by Paul Millar

On Saturday 17 November 2007 12:04:36 Maarten Lankhorst wrote: > Roderick Colenbrander schreef: > > They should get updated. In case of Solaris there are some bugs which > > prevent it from running I think. In case of Windows someone needs to > > update the package. It is very useful to use some of the wine dlls > > (wined3d for instance) or tests on Windows. > > The question is what dlls should we include? Something like the d3d > dll's would be useful, and a lot of other dll's (mshtml, shdocvw, etc) > probably too. Unfortunately wine won't build on mingw properly,if you > try a 'make' in mingw, it will bomb out on building in dll's. If someone > wants to maintain windows dll's, the makefiles should be adjusted so > that it will build properly, and skip the dll's wine can't emulate in > windows. Such as ntdll, kernel32, advapi, to name a few, probably all > dll's with wineserver calls and perhaps a few more. That sounds promising. I should be able to tweak the winetest.exe build infrastructure so it also build DLLs and executables without too much trouble. Having a target that skips attempting to build DLLs that will never work would help. Cheers, Paul.

Nov. 18, 2007

Re: svchost: Added base implementation of svchost (1/27)

by Robert Shearman

Roy Shea wrote: > +TOPSRCDIR = @top_srcdir@ > +TOPOBJDIR = ../.. > +SRCDIR = @srcdir@ > +VPATH = @srcdir@ > +MODULE = svchost.exe > +APPMODE = -municode > +IMPORTS = advapi32 kernel32 ole32 > I can't see any reason why svchost needs to import ole32. -- Rob Shearman

Nov. 18, 2007

Hi, and a regression in bug 10486

by Paweł Różański

Hi I have found a regression in wine. a strange one. What is a policy about posting such regressions, here on malling list? (Or is regression is worth enough to post it here?) I don't play that particular game on wine and it's "minor" bug - but i have found (via bitsect) that "user32: Cache the window class name on the client side." produce strange effects on directx code. I have faith that regressions are supposed to post here as well. More info in bug #10486 Take care & Hope that helps -- Paweł Różański, a wine user witch occasionally post something on appdb/bugzilla

Nov. 18, 2007