November 2007 - Wine-Devel - list.winehq.org

Re: Regression testing and cc-ing the author

by Dmitry Timoshkov

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > I've opened a bug (which if fixed now btw) and the regression testing page at > http://wiki.winehq.org/RegressionTesting said "Also be sure to add the author of > the patch to the CC". > > So this is what I did. > > Should that line be removed from the wiki or do we generally want the author to > be CC-ed? IMHO that line should be left in the wiki, simply because not all patch submitters are subscribed to wine-bugs mailing list. But I find nothing wrong if somebody already subscribed asks to not add him to the cc: list. -- Dmitry.

Nov. 17, 2007

Regression testing and cc-ing the author

by Paul Vriens

Hi, I've opened a bug (which if fixed now btw) and the regression testing page at http://wiki.winehq.org/RegressionTesting said "Also be sure to add the author of the patch to the CC". So this is what I did. Should that line be removed from the wiki or do we generally want the author to be CC-ed? -- Cheers, Paul.

Nov. 17, 2007

Re: #winehackers invite only?

by Marcus Meissner

On Sat, Nov 17, 2007 at 01:58:31PM +0100, Stefan Dösinger wrote: > Hello, > Did anyone change #winehackers to require an invite? What was the reason for > this? Sorry, we had a kiddie problem. It is back to normal now. Ciao, Marcus

Nov. 17, 2007

Re: #winehackers invite only?

by Stefan Dösinger

Am Samstag, 17. November 2007 13:58:31 schrieb Stefan Dösinger: > Hello, > Did anyone change #winehackers to require an invite? What was the reason > for this? It's sorted out already

Nov. 17, 2007

#winehackers invite only?

by Stefan Dösinger

Hello, Did anyone change #winehackers to require an invite? What was the reason for this? Thanks, Stefan

Nov. 17, 2007

Re: Removing Windows and Solaris from the Downloads page

by Maarten Lankhorst

Hi, Roderick Colenbrander schreef: > They should get updated. In case of Solaris there are some bugs which prevent it from running I think. In case of Windows someone needs to update the package. It is very useful to use some of the wine dlls (wined3d for instance) or tests on Windows. > The question is what dlls should we include? Something like the d3d dll's would be useful, and a lot of other dll's (mshtml, shdocvw, etc) probably too. Unfortunately wine won't build on mingw properly,if you try a 'make' in mingw, it will bomb out on building in dll's. If someone wants to maintain windows dll's, the makefiles should be adjusted so that it will build properly, and skip the dll's wine can't emulate in windows. Such as ntdll, kernel32, advapi, to name a few, probably all dll's with wineserver calls and perhaps a few more. Regards, Maarten.

Nov. 17, 2007

Re: Removing Windows and Solaris from the Downloads page

by Roderick Colenbrander

> It appears that the links for the Windows and Solaris versions on the > winehq downloads page are very, very old. Since they're no longer > maintained, we should just remove them, yes? > > Thanks, > Scott Ritchie > They should get updated. In case of Solaris there are some bugs which prevent it from running I think. In case of Windows someone needs to update the package. It is very useful to use some of the wine dlls (wined3d for instance) or tests on Windows. Roderick -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

Nov. 17, 2007

Removing Windows and Solaris from the Downloads page

by Scott Ritchie

It appears that the links for the Windows and Solaris versions on the winehq downloads page are very, very old. Since they're no longer maintained, we should just remove them, yes? Thanks, Scott Ritchie

Nov. 17, 2007

Re: svchost: Added base implementation of svchost (1/27)

by Juan Lang

Hi Roy, +#define WIN32_LEAN_AND_MEAN That's not needed if you're not including windows.h (which you're not.) + if (unicode[i] > 129) You have an off-by-two error here. 7-bit clean means if (unicode[i] > 127). You can also use something like if (unicode[i] & 0x80). Stylistic note, use or ignore at your option: + HeapFree(GetProcessHeap(), 0, service_param_key); + return FALSE; (snip) + HeapFree(GetProcessHeap(), 0, service_param_key); + RegCloseKey(service_hkey); + return FALSE; (snip) + HeapFree(GetProcessHeap(), 0, service_param_key); + HeapFree(GetProcessHeap(), 0, dll_name_short); + RegCloseKey(service_hkey); + return FALSE; (snip) Some judicious use of goto could reduce code for all your error paths. Remember that HeapFree of a NULL pointer is allowed. + dll_service_main = GetRegValue(service_hkey, service_main); + RegCloseKey(service_hkey); + if (!dll_service_main) + { + service_main_a = UnicodeToAscii(service_main); + } + else + { + service_main_a = UnicodeToAscii(dll_service_main); + HeapFree(GetProcessHeap(), 0, dll_service_main); Why not just query dll_service_main and service_main from the registry as an ASCII value to begin with? --Juan

Nov. 17, 2007

Re: [Bug 10464] Regression when installing Skype

by James Hawkins

On 11/16/07, wine-bugs(a)winehq.org <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=10464 > > --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2007-11-16 18:33:31 --- > James, you can disable bugzilla from e-mailing you for CC's and/or disable all > e-mail. > > Austin, it's not about that. Disabling all emails is against the point. I'm subscribed to wine-bugs, so I don't need to be cc'ed. This is the position of several other developers, so I don't see where the confusion is coming from. If anything, ask the developer whose patch created a regression to assign the bug to himself. I'm going to stop now before I start ranting. -- James Hawkins

Nov. 17, 2007