November 2007 - Wine-Devel - list.winehq.org

Re: [3/4] msxml: Implement removeAttribute

by Mikołaj Zalewski

A problem with this patch is that the user may have an IXMLDOMNode * reference to the attribute node being removed. The xmlFreeProp will free the xmlnode so accessing the IXMLDOMNode could result in memory corruption. Under MSXML it's possible to access such node and even reconnect it e.g. to a different documents (at least I seem to remember such a thing for element nodes). I don't think supporting it is possible with our current reference counting only for the whole document. I was thinking about also keeping reference counts for each connected component and each node. The connected component count could be used to determine if the node can be freed in such a situation and the node count could be used to update the connected component counts if the tree gets split. But so far I haven't written any code (Another possibility is to keep in each node the refcount of the whole subtree starting in this node. This is more elegant but it would take a linear time with respect to the tree height to update the refcount). Mikołaj Zalewski

Nov. 14, 2007

Re: server: Make timer id allocation algorithm conform to the Windows one

by Uwe Bonnes

>>>>> "Dmitry" == Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: Dmitry> Hello, this patch should fix the problem reported in the bug Dmitry> 10343. My test which calls SetTimer in an infinite loop shows Dmitry> that XP starts to allocate timer ids at 0x7fff and goes Dmitry> backwards to 0x101, then restarts from 0x7fff. Isn't this worth a test suite case? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

Nov. 14, 2007

Re: AppDB down =(

by Jeremy Newman

I restarted it. I still have no idea how it gets into this state. The logs have not been much help. I think we have exposed a bug in mysql itself, as we did not have these issues until we upgraded to ver 5. On Wed, 2007-11-14 at 14:42 -0600, John Klehm wrote: > Erm yeah the appdb is down... too many connections...sad times. > > John > >

Nov. 14, 2007

Re: Asking Valve for Steam Survey Results

by Bryan Haskins

That is pretty fricking cool. It's not an astronomical figure and realistically could be contended from many directions but still some idea of the userbase, I call that significant. =] On Nov 14, 2007 11:52 AM, Brian Vincent <brian.vincent(a)gmail.com> wrote: > On Nov 13, 2007 4:45 PM, Scott Ritchie <scott(a)open-vote.org> wrote: > > Does anyone know whom we can contact at Valve for more specific results? > > Here's the answer from Valve to your question: > > ---- > > Hey Brian, we would be more than happy to help. I just did a quick query > for the audio device and found 12 out of 8566 results to contain "wine" > in the name of the driver. I did the same for video card and found zero, > if you can give me more details on specific strings or signatures for a > wine user I could have a look for. We just started this survey today so > I can run the queries again once we have a larger sample set. > > Our crash reporting system also collects information about the existence > of wine, about 0.4% of the reports are from Wine users (this is for a > couple months of data so a statistically significant sample). We have > around 3 million unique users in a month so that is around 12k wine > users. Given the large majority of crashes are game code related (and > not OS dependant) I suspect this is a fair measure for you. > > ---- > > -Brian > > > -- Cheers, Bryan

Nov. 14, 2007

AppDB down =(

by John Klehm

Erm yeah the appdb is down... too many connections...sad times. John

Nov. 14, 2007

Re: [4/4] msxml: Test for removeAttribute (try 2)

by James Hawkins

On 11/14/07, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Changelog: > msxml: Test for removeAttribute > You sent the patch to the wrong mailing list. Also, if you send a 'try X' patch, you should write a message saying what you changed from the last submission. -- James Hawkins

Nov. 14, 2007

Re: Asking Valve for Steam Survey Results

by Scott Ritchie

Brian Vincent wrote: > On Nov 13, 2007 4:45 PM, Scott Ritchie <scott(a)open-vote.org> wrote: >> Does anyone know whom we can contact at Valve for more specific results? > > Here's the answer from Valve to your question: > > ---- > > Hey Brian, we would be more than happy to help. I just did a quick query > for the audio device and found 12 out of 8566 results to contain "wine" > in the name of the driver. I did the same for video card and found zero, > if you can give me more details on specific strings or signatures for a > wine user I could have a look for. We just started this survey today so > I can run the queries again once we have a larger sample set. > > Our crash reporting system also collects information about the existence > of wine, about 0.4% of the reports are from Wine users (this is for a > couple months of data so a statistically significant sample). We have > around 3 million unique users in a month so that is around 12k wine > users. Given the large majority of crashes are game code related (and > not OS dependant) I suspect this is a fair measure for you. > > ---- > > -Brian How are these crash reports generated? I've never seen a method for reporting a crash to steam when using it with Wine. Thank you for taking the initiative on this Brian, and double thanks to Valve :) Thanks, Scott Ritchie

Nov. 14, 2007

Re: Asking Valve for Steam Survey Results

by Brian Vincent

On Nov 13, 2007 4:45 PM, Scott Ritchie <scott(a)open-vote.org> wrote: > Does anyone know whom we can contact at Valve for more specific results? Here's the answer from Valve to your question: ---- Hey Brian, we would be more than happy to help. I just did a quick query for the audio device and found 12 out of 8566 results to contain "wine" in the name of the driver. I did the same for video card and found zero, if you can give me more details on specific strings or signatures for a wine user I could have a look for. We just started this survey today so I can run the queries again once we have a larger sample set. Our crash reporting system also collects information about the existence of wine, about 0.4% of the reports are from Wine users (this is for a couple months of data so a statistically significant sample). We have around 3 million unique users in a month so that is around 12k wine users. Given the large majority of crashes are game code related (and not OS dependant) I suspect this is a fair measure for you. ---- -Brian

Nov. 14, 2007

Valgrind results for Nov 12 & 13

by Dan Kegel

It seems that valgrind doesn't like Ubuntu 7.10; I had to drop back to my Feisty system to generate good valgrind stack dumps. And the tests didn't hang once! Results for the last two days are at http://kegel.com/wine/valgrind/20071112/ http://kegel.com/wine/valgrind/20071113/ The logs are trimmed a bit more to make diffs less noisy. Diff now shows clearly that there were significant improvements in three tests between those two runs: ole32/compobj, ole32/marshal, and user32/dde Errors still remain in all three tests, though. - Dan

Nov. 14, 2007

Re: [4/8] WineD3D: Depth stencil fixes

by H. Verbeet

On 14/11/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Am Mittwoch, 14. November 2007 09:46:02 schrieb H. Verbeet: > > On 13/11/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > > static void depth_copy(IWineD3DDevice *iface) { > > > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > > > - IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl > > > *)This->depthStencilBuffer; + IWineD3DSurfaceImpl *depth_stencil = > > > (IWineD3DSurfaceImpl *)This->auto_depth_stencil_buffer; > > > > > > /* Only copy the depth buffer if there is one. */ > > > > I think this one should be changed to use stencilBufferTarget instead, > > although not in this patch. > I thought about that too, but does the depth copy ever apply to other stencil > buffers than the implicit one? > It applies to whatever depth stencil is active at the time you switch between rendering onscreen/offscreen.

Nov. 14, 2007