November 2007 - Wine-Devel - list.winehq.org

Re: USER32: Patch 3 of 6: DlgDirList converts path specification to uppercase.

by Alexandre Julliard

Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: > Observed while preparing conformance tests. The filepath (if valid) gets > converted to uppercase on return. > > Changelog: > * DlgDirList must convert path specification to uppercase. You should do that after the SetCurrentDirectory, uppercasing it first means we are much more likely to have to do a slow case-insensitive search on the whole path. -- Alexandre Julliard julliard(a)winehq.org

Nov. 14, 2007

Re: [4/4] msxml: Test for removeAttribute (try 2)

by Alistair Leslie-Hughes

Hi, Changelog: msxml: Test for removeAttribute Best Regards Alistair Leslie-Hughes

Nov. 14, 2007

Re: [4/4] msxml: Test for removeAttribute

by Robert Shearman

Alistair Leslie-Hughes wrote: > @@ -589,6 +589,10 @@ static void test_domnode( void ) > ok( !lstrcmpW(V_BSTR(&var), szstr1), "wrong attr value\n"); > VariantClear( &var ); > SysFreeString( str ); > + > + > + str = SysAllocString( szvr ); > + SysFreeString( str ); > > r = IXMLDOMElement_get_attributes( element, &map ); > ok( r == S_OK, "get_attributes returned wrong code\n"); > @@ -1077,7 +1081,7 @@ static void test_create(void) > ok( r == S_OK, "returns %08x\n", r ); > r = IXMLDOMNamedNodeMap_get_length( attr_map, &num ); > ok( r == S_OK, "returns %08x\n", r ); > - ok( num == 1, "num %ld\n", num ); > + ok( num == 1, "num %ld\n", num ); > IXMLDOMNamedNodeMap_Release( attr_map ); > VariantClear(&var); > r = IXMLDOMElement_getAttribute( element, name, &var ); > These two changes don't appear to be relevant to the test you're adding. -- Rob Shearman

Nov. 14, 2007

Re: [4/8] WineD3D: Depth stencil fixes

by Stefan Dösinger

Am Mittwoch, 14. November 2007 09:46:02 schrieb H. Verbeet: > On 13/11/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > static void depth_copy(IWineD3DDevice *iface) { > > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > > - IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl > > *)This->depthStencilBuffer; + IWineD3DSurfaceImpl *depth_stencil = > > (IWineD3DSurfaceImpl *)This->auto_depth_stencil_buffer; > > > > /* Only copy the depth buffer if there is one. */ > > I think this one should be changed to use stencilBufferTarget instead, > although not in this patch. I thought about that too, but does the depth copy ever apply to other stencil buffers than the implicit one?

Nov. 14, 2007

Re: Asking Valve for Steam Survey Results

by Stefan Dösinger

Am Mittwoch, 14. November 2007 00:45:29 schrieb Scott Ritchie: > Looking at the data we do have, we may be able to make a good guess from > examining the video card driver name field. Excluding NVidia, ATI, and > Intel leaves just over 4% of respondents using an "other" video driver > like the Wine one. If even only a quarter of these "others" are using > Wine, that still gives us 1% of the entire 10 million+ Steam user base, > translating into hundreds of thousands of users. It depends on how they find the vendor. If they go for the d3d string, then wine shows up as "Direct3D HAL", which would be identifyable. If they go for the PCI ID, then Wine installations show up as either ATI, NVIDIA, or Intel, unless the detection failed. More interesting is the "Video Card Driver Name": Video Card Driver Name nv4_disp.dll 10,269 53.43 %##################################################### ati2dvag.dll 5,060 26.33 %########################## nvd3dum.dll 2,698 14.04 %############## atiumdag.dll 571 2.97 %### ialmrnt5.dll 302 1.57 %## Other 319 1.66 %## This identifies the DLL, and wine has none of them. So we'd show up in the Other section here. Possible others in Windows space are matrox, sis and other chips, as well as the generic vesa driver. The best identification is the sound card name, or if Wine's display driver shows up as winex11.drv

Nov. 14, 2007

Re: [4/8] WineD3D: Depth stencil fixes

by H. Verbeet

On 13/11/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > static void depth_copy(IWineD3DDevice *iface) { > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > - IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl *)This->depthStencilBuffer; > + IWineD3DSurfaceImpl *depth_stencil = (IWineD3DSurfaceImpl *)This->auto_depth_stencil_buffer; > > /* Only copy the depth buffer if there is one. */ I think this one should be changed to use stencilBufferTarget instead, although not in this patch.

Nov. 14, 2007

Re: msxml: Implement cloneNode and correct insertBefore

by Maarten Lankhorst

Hi James, James Hawkins schreef: > mailing list etiquette: make sure to bottom-post on this ML and CC > wine-devel so others can share in the information exchange. > > To answer your question, you have to get into the git mindset. That > is, you make one fix, commit the fix, write the next fix, etc. It's > really a development change. You should know what to fix before you > go in to fix it, not hack around until an app works. > Strictly speaking not entirely true, a lot of the times I first hack around till my app works before cleaning it up and sending in a proper fix. You are right that missing the clean-up will mean that the code won't be accepted into wine, sometimes that is even more work then the stuff needed to make it work. A: Top posting > Q: What is the most annoying thing in the world? Cheers, Maarten

Nov. 14, 2007

Re: msxml: Implement cloneNode and correct insertBefore

by Alistair Leslie-Hughes

"James Hawkins" <truiken(a)gmail.com> wrote in message news:22821af30711131811g27868935uf3423253ddaf5bcd(a)mail.gmail.com... > On 11/13/07, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: >> >> Hi James, >> Thanks for the pointers. >> >> I resend the patches shortly. Is there an easy way to split a Diff up? >> via >> git? More to the point changes to a single file (without have to backup >> it >> up every change) >> >> I just get frustrated with try to keep lots of diffs around. >> > > mailing list etiquette: make sure to bottom-post on this ML and CC > wine-devel so others can share in the information exchange. > > To answer your question, you have to get into the git mindset. That > is, you make one fix, commit the fix, write the next fix, etc. It's > really a development change. You should know what to fix before you > go in to fix it, not hack around until an app works. > > -- > James Hawkins > Thanks again. I should of read http://wiki.winehq.org/GitWine first. Ill resend patches shortly. Best Regards Alistair Leslie-Hughes

Nov. 14, 2007

Re: msxml: Implement Element removeAttribute

by Steven Edwards

On Nov 12, 2007 3:57 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > > + > + TRACE("(%p)->%s\n", iface, debugstr_w(p)); > + // TODO Replace if Attribute has a Default value. Also another thing. No C++ style comments in Wine source code. Thanks Steven -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Nov. 14, 2007

Re: msxml: Implement cloneNode and correct insertBefore

by James Hawkins

On 11/13/07, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > > Hi James, > Thanks for the pointers. > > I resend the patches shortly. Is there an easy way to split a Diff up? via > git? More to the point changes to a single file (without have to backup it > up every change) > > I just get frustrated with try to keep lots of diffs around. > mailing list etiquette: make sure to bottom-post on this ML and CC wine-devel so others can share in the information exchange. To answer your question, you have to get into the git mindset. That is, you make one fix, commit the fix, write the next fix, etc. It's really a development change. You should know what to fix before you go in to fix it, not hack around until an app works. -- James Hawkins

Nov. 14, 2007