November 2007 - Wine-Devel - list.winehq.org

Re: msxml: Implement cloneNode and correct insertBefore

by James Hawkins

On 11/12/07, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > InsertBefore is allowed to have outNewChild as NULL > Implement cloneNode > One fix per patch please. Also, please add tests for these fixes. > Best Regards > Alistair Leslie-Hughes > > diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c > index 61d5ab2..86d7614 100644 > --- a/dlls/msxml3/node.c > +++ b/dlls/msxml3/node.c > @@ -373,7 +373,7 @@ static HRESULT WINAPI xmlnode_insertBefore( > > TRACE("(%p)->(%p,var,%p)\n",This,newChild,outNewChild); > > - if (!(newChild && outNewChild)) > + if (!newChild) > return E_INVALIDARG; > > switch(V_VT(&refChild)) > @@ -412,9 +412,13 @@ static HRESULT WINAPI xmlnode_insertBefore( > xmlAddChild(This->node, new_child_node); > } > > - IXMLDOMNode_Release(new); > IXMLDOMNode_AddRef(newChild); > - *outNewChild = newChild; > + IXMLDOMNode_Release(new); > + if(outNewChild) > + { > + *outNewChild = newChild; > + } > + > TRACE("ret S_OK\n"); > return S_OK; > } > @@ -517,8 +521,36 @@ static HRESULT WINAPI xmlnode_cloneNode( > VARIANT_BOOL deep, > IXMLDOMNode** cloneRoot) > { > - FIXME("\n"); > - return E_NOTIMPL; > + xmlnode *This = impl_from_IXMLDOMNode( iface ); > + xmlNodePtr pClone = NULL; > + IXMLDOMNode *pNode = NULL; > + > + TRACE("%p (%d)\n", This, deep); > + > + if(!cloneRoot) > + return E_INVALIDARG; > + > + pClone = xmlCopyNode(This->node, deep ? 1 : 0); > + if(pClone) > + { > + pClone->doc = This->node->doc; > + > + pNode = create_node(pClone); > + if(!pNode) > + { > + ERR("Copy failed\n"); > + return E_FAIL; > + } > + > + *cloneRoot = pNode; > + } > + else > + { > + ERR("Copy failed\n"); > + return E_FAIL; > + } > + > + return S_OK; > } > > static HRESULT WINAPI xmlnode_get_nodeTypeString( > @@ -832,7 +864,7 @@ static ULONG WINAPI Internal_Release( > if ( ref == 0 ) > { > if( This->node ) > - xmldoc_release( This->node->doc ); > + xmldoc_release( This->node->doc ); > Please don't make random whitespace changes. -- James Hawkins

Nov. 14, 2007

Asking Valve for Steam Survey Results

by Scott Ritchie

Valve regularly runs surveys of steam users, where they profile many different things about the hardware. They're nice enough to publish the results: http://www.steampowered.com/status/survey.html Some of these provide a way to detect Wine users. Everyone using the "Wine waveout" audio driver, for instance, must be a Wine user. Unfortunately, valve lumps all of these into "other" on the survey results page. Worries about sampling bias aside (maybe Wine users are less likely to do the steam survey), if we had the raw data from Valve we could determine the actual percentage of Steam users playing through Wine. Looking at the data we do have, we may be able to make a good guess from examining the video card driver name field. Excluding NVidia, ATI, and Intel leaves just over 4% of respondents using an "other" video driver like the Wine one. If even only a quarter of these "others" are using Wine, that still gives us 1% of the entire 10 million+ Steam user base, translating into hundreds of thousands of users. Does anyone know whom we can contact at Valve for more specific results? Thanks, Scott Ritchie

Nov. 13, 2007

Re: svchost Patch Question

by Stefan Dösinger

Am Dienstag, 13. November 2007 01:19:13 schrieb Roy Shea: > Howdy, > If the stopper for this patch is the lack of a DLL using it, I can > resend svchost later this week when I have a stub implementation of > BITS using svchost ready. I have zero idea what svchost is doing, but the general approach in this case is to write tests using the service directly. (However, I am not sure if our build and test system currently supports tests for a app in programs/)

Nov. 13, 2007

Re: xrun handling in winealsa.drv

by Timofei V. Bondarenko

Maarten Lankhorst wrote: > Hello Timofei, > > Timofei V. Bondarenko schreef: >> No matter how low the chance: sound is an real-time task while linux >> is not a real-time system. So underruns still possible. >> And in case of XRUN widRecorder() tries to read about 4G of data. >> >> Well, I'm a busy man too. So I've wrote a simple patch and sent it to >> wine-patches. Please look. May be it will be more clear in C than in >> my broken english. > I took a quick look, it's incorrect for dscapture and dsoutput, > underruns are already handled there in CheckXRUN, in case of _Stop it is > unneeded as well since it just stopped and restarted, no underruns > possible. The only thing needed in that part is that the < 0 checks need > to have a cast to sframes. Sure, you know better about it supposed to work ;-) when i can notice the obvious mistakes only. My main concern is the widRecorder() not the ds though. Regards, Tim.

Nov. 13, 2007

Re: Grumble. Lost the Valgrind magic.

by James Hawkins

On 11/13/07, Dan Kegel <dank(a)kegel.com> wrote: > I had to reinstall my main valgrind testing machine > (I foolishly ran the vmware server install script, and > it nuked my wireless), and since then, valgrind > isn't giving me stack traces. I guess something's > wrong in my recipe, but I'm not sure what, the > vg-3.2.3 patch is being applied. > > Sigh. Is anybody else having luck building a valgrind > that gives good stack traces for wine? > On Gutsy, I haven't been able to get stack traces either. -- James Hawkins

Nov. 13, 2007

Grumble. Lost the Valgrind magic.

by Dan Kegel

I had to reinstall my main valgrind testing machine (I foolishly ran the vmware server install script, and it nuked my wireless), and since then, valgrind isn't giving me stack traces. I guess something's wrong in my recipe, but I'm not sure what, the vg-3.2.3 patch is being applied. Sigh. Is anybody else having luck building a valgrind that gives good stack traces for wine?

Nov. 13, 2007

svchost Patch Question

by Roy Shea

Howdy, I'm looking for advice on how to clean up the implementation of svchost. The latest version is available at: http://www.winehq.org/pipermail/wine-patches/2007-November/046467.html If the stopper for this patch is the lack of a DLL using it, I can resend svchost later this week when I have a stub implementation of BITS using svchost ready. Thanks for any pointers! -Roy

Nov. 13, 2007

Re: rpcrt4: Implement RpcCancelThread for the ncacn_ip_tcp protocol sequence.

by Hans Leidekker

On Monday 12 November 2007 21:10:19 Robert Shearman wrote: > +static CRITICAL_SECTION_DEBUG threaddata_cs_debug = > +{ > + 0, 0, &uuid_cs, I smell a copy/paste artifact ;) -Hans

Nov. 12, 2007

Too many WM_MOUSEACTIVATE

by Peter Åstrand

I have lot's of problems with WM_MOUSEACTIVATE messages in "Magna Cura". The effekt is that certain popup dialog doesn't work: After selecting something, say a date, the whole "form" is cleared. After much debugging, I've found out that WM_MOUSEACTIVATE is the problem. If I explicitly stop WM_MOUSEACTIVATE from propagating from dialogs to parents, then things works OK. I do this by addding: case WM_MOUSEACTIVATE: return MA_ACTIVATE; in DefDlgProc{A,W}. I wonder how many things that will brake with a change like this.... Just a long shot, but has anyone else seen anything similiar to this? (It turns out that there are multiple differences compared to Windows; one with two many messages generated when the popup is created, another with too few messages when changing tab in a SysTabControl32 (but zero messages works fine as well.) Rgds, --- Peter Åstrand ThinLinc Chief Developer Cendio AB http://www.cendio.se Wallenbergs gata 4 583 30 Linköping Phone: +46-13-21 46 00 ThinLinc User Group 2007 Höstkonferens --- 15-16 november, Linköping. Program och anmälan: http://www.thinlincusergroup.se/aktiviteter

Nov. 12, 2007

Problem with wine + Dreamweaver + VNC

by Francisco José Gallego Durán

Hello, I am trying to run Dreamweaver.exe and Photoshop.exe in a remote gnome-session through vnc4server. When I try to run it I get the following message: Xlib: extension "XFree86-DRI" missing on display ": 3.0". X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 148 (GLX) Minor opcode of failed request: 3 (X_GLXCreateContext) Value in failed request: 0x24 Serial number of failed request: 11 Current serial number in output stream: 12 Might it be a kind of a bug? I am running wine 0.9.49, Debian etch with latest updates, and vnc4server. Thank you for your help. Francisco Gallego.

Nov. 12, 2007