November 2007 - Wine-Devel - list.winehq.org

Re: wininet: update test to pass on newer versions of windows

by Hans Leidekker

On Monday 12 November 2007 11:45:06 Alexandre Julliard wrote: > > + /* sz is 14 on XP SP1 and beyond, 30 on XP and before */ > > + todo_wine ok( sz == 14, "sz wrong\n"); > > The tests have to pass on all Windows versions. If some return 30 and > some return 14 the test must accept both. FWIW, my patch named "#2 wininet: Fix a number of problems with InternetGetCookie." corrects this. -Hans

Nov. 12, 2007

Re: widl [2/9]: Add an option to use Wine exception handlers.

by Alexandre Julliard

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > This patch adds a --wine-seh option to widl to use Wine's SEH instead of > the Windows one. This should not be a widl option. widl should generate a single version of the C code that works on all compilers, using appropriate macros and #ifdefs. Also you shouldn't use the wine/exception.h macros, since you are generating the code you can output the code directly, in a much more straightforward way than the convoluted __TRY macros. -- Alexandre Julliard julliard(a)winehq.org

Nov. 12, 2007

Re: wininet: update test to pass on newer versions of windows

by Alexandre Julliard

"Lei Zhang" <thestig(a)google.com> writes: > + > + /* sz is 14 on XP SP1 and beyond, 30 on XP and before */ > + todo_wine ok( sz == 14, "sz wrong\n"); The tests have to pass on all Windows versions. If some return 30 and some return 14 the test must accept both. -- Alexandre Julliard julliard(a)winehq.org

Nov. 12, 2007

Re: How can we handle undcomented shell functionsAW, that MS declared now (WSTR version only)

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > Examples: PathProcessCommend, PathResolve, PathQualify > > Question for include/shlobj.h: > What is the correct way to declare such functions? They should be declared exactly like they are on Windows. The AW function is internal to shell32. > Next question for shell32.spec: > Are we fixed to "ptr" for such functions? > ("str", "wstr" and "long" are all used and need to be fixed) They should be ptr. > Is it possible / useful to add support for "awstr" (or a similar name)? > What about support for UNICODE-Strings ("ustr")? I don't think it's worth the trouble. -- Alexandre Julliard julliard(a)winehq.org

Nov. 12, 2007

Re: cmdlgtst: Rename to dialogtest

by Alexander Nicolaysen Sørnes

On Monday 12 November 2007 04:09:31 Dmitry Timoshkov wrote: > "Detlef Riekenberg" <wine.dev(a)web.de> wrote: > > Windows has a lot more Dialogs in shell32, user32, kernel32 and various > > other dlls. > > > > This is only a rename, the only code that changed is the name of the > > debug-channel. > > IMHO it's better to remove programs/cmdlgtst altogether, it doesn't really > test anything, and this is not a place for tests anyway. I seem to recall they were very useful when translating the dialogues. Alexander N: Sørnes

Nov. 12, 2007

Re: Patch Follow up

by Alexandre Julliard

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> writes: > Hi, > Are there any reason they following patches where missed? They are not in a format that can be decoded automatically. They should either be plain text, or MIME attachments with proper MIME headers. Please fix your mail setup and resend. -- Alexandre Julliard julliard(a)winehq.org

Nov. 12, 2007

Re: Valgrind results for Oct 9: still lots of hangs

by Dan Kegel

Yes, senility. The next batch will have correct dates both numeric and alphabetic... On Nov 11, 2007 9:07 PM, Bang Jun-young <junyoung(a)mogua.com> wrote: > Just out of curiousity, is there a special reason for you to use "Oct" as the > abbreviation for November?

Nov. 12, 2007

Re: Valgrind results for Oct 9: still lots of hangs

by Bang Jun-young

Just out of curiousity, is there a special reason for you to use "Oct" as the abbreviation for November? On 11/10/07, Dan Kegel <dank(a)kegel.com> wrote: > Results for today's git (plus my dde patch) are online at > http://kegel.com/wine/valgrind/20071109/ > > ole32/tests/marshall.c has always been hanging > when run under valgrind. In the last two days, > the following additional tests hang under valgrind: > mshtml/tests/dom.c > mshtml/tests/htmldoc.c > ole32/tests/marshal.c > shdocvw/tests/webbrowser.c > > I can reproduce one hang with > cd dlls/mshtml/tests > make testclean > wineserver -k > RUNTEST_USE_VALGRIND=1 make test > (with the wine-vg-utils.patch I provide. > Make by itself does not behave well under valgrind, > so you can't just do "valgrind make test"). > > Sadly, I don't have time to do a regression test, but > it's pretty easy to repeat my results. See > http://wiki.winehq.org/Wine_and_Valgrind > It'd be nice if somebody else verified that > these hangs occur for them too, that they didn't > occur with wine-0.9.48, and maybe > did a regression test to find out when they started... > - Dan > > >

Nov. 12, 2007

Re: cmdlgtst: Rename to dialogtest

by Dmitry Timoshkov

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > Windows has a lot more Dialogs in shell32, user32, kernel32 and various > other dlls. > > This is only a rename, the only code that changed is the name of the > debug-channel. IMHO it's better to remove programs/cmdlgtst altogether, it doesn't really test anything, and this is not a place for tests anyway. -- Dmitry.

Nov. 12, 2007

Re: OLEDLG: use wide strings

by Dmitry Timoshkov

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Changelog: > - fix buffers size for registry functions > - use unicode registry functions > - do not requires ntdll anymore (remove RtlMultiByteToUnicodeN using) This patch is extremely buggy, it passes wrong buffer sizes to various APIs in many places. -- Dmitry.

Nov. 12, 2007