November 2007 - Wine-Devel - list.winehq.org

Re: Develop .h for Wine by looking Microsoft Platform SDK

by John Klehm

On 11/7/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Am Mittwoch, 7. November 2007 01:00:54 schrieb King InuYasha: > > It is not legal at all. Using Microsoft Platform SDK header code is not > > under the GNU General Public License version 2.0 or its listed compatible > > licenses, so you have to do it manually WITHOUT looking at the PSDK. I > > recommend removing the PSDK from your system as a way to remove temptation. > Headers contain facts, and facts cannot be copyrighted. Also the sdk headers > are the only source of information. Collecting them from the msdn is not > going to work. > > The typing of the header itself is copyrighted though, so you must not > copypaste from the MS Header. The wine header should be implemented as > differently as possible, but still be 100% compatible. Especially watch out > that the wine header includes the same files the other header does. > > > Hrmm smells like another good FAQ item. =)

Nov. 7, 2007

Re: advapi32: fix buffer overrun in tests/registry.c:wine_debugstr_wn(), try 3

by Alexandre Julliard

"Dan Kegel" <dank(a)kegel.com> writes: > Fixes an off-by-one buffer overflow in wine_debugstr_wn() > in which the wchar after the end of the buffer was read. > > This is same as try 2, but is slightly clearer and more correct. > > Found via Valgrind warning: > Conditional jump or move depends on uninitialised value(s) > at 0x45F3219: wine_debugstr_wn (registry.c:151) > by 0x45F34F5: test_hkey_main_Value_W (registry.c:284) > by 0x45F7644: func_registry (registry.c:327) > by 0x460A127: run_test (test.h:387) > > Alexandre, if you don't like this 'un, please tell me why. That function is really supposed to print n chars, not n-1. The terminating null probably needs to be included in the length. -- Alexandre Julliard julliard(a)winehq.org

Nov. 7, 2007

Re: ntdll: Architecture may be '*' in lookup_manifest_file so don't rely on the first '*' of the format indiacting where the version number is.

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > Instead use the underscores that separate the string fields. Of course the assembly name can contain underscores too... I think that the whole idea of checking the version number from the file name is flawed. -- Alexandre Julliard julliard(a)winehq.org

Nov. 7, 2007

[keyboard] GetAsyncKeyState: request for fixing #5623

by Rafał Miłecki

Hello, I have two favourite games (Diablo II & Ultima Online) and both of them works great under Wine. Unfortunately this is quite hard to play UO without additional tool called "EasyUO" which doesn't work under Wine. EasyUO generally works fine but it can not detect pressing any key-combination in focued UO window. Possibility of detecting is the main functionality for EUO. This problem is cuased by little bug in support for GetAsyncKeyState function. I am waiting about 8 months now for fixing this bug and I wonder if I can ask sb to look info this bug. Just to make fixing this little faster. Bug is quite well decribed in: http://bugs.winehq.org/show_bug.cgi?id=5623 but if you don't understand this, I can try to explain more detailed. So my request is someone try to fix this bug. Anyone have a free moment for this, please? -- Rafał Miłecki

Nov. 7, 2007

Re: [10/14] WineD3D: Implement the varying map

by Stefan Dösinger

Am Mittwoch, 7. November 2007 08:10:35 schrieb Stefan Dösinger: > Am Dienstag, 6. November 2007 23:41:40 schrieb Allan Tong: > > On 11/6/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > > + /* Don't do any register mapping magic if it is not needed, or > > > if we can't + * achive anything anyway > > > + */ > > > + if(highest_reg_used < (GL_LIMITS(glsl_varyings) / 4) || > > > + num_regs_used >= (GL_LIMITS(glsl_varyings) / 4) ) { > > > + if(num_regs_used >= (GL_LIMITS(glsl_varyings) / 4)) { > > > > Should it not be "num_regs_used > (GL_LIMITS(glsl_varyings) / 4)"? > > yes, I think you are right. Thanks for spotting this Here is a fixed patch

Nov. 7, 2007

Mistakes in my yesterday evening patches

by Laurent Vromman

I have send 4 patches yesterday. The 2 first of them are tagged resend. Please do not take those two first patches into account, they have already been merged in the git tree. My proxy played me a trick, i haven't see that before I sent them again. Only the 2 last ones (3/4 and 4/4) are to be merged by now. Sorry for my mistake, Laurent

Nov. 7, 2007

Re: What the hell is up with searching google for wine-devel and wine-patches posts?

by Steven Edwards

On Nov 7, 2007 2:23 AM, Scott Ritchie <scott(a)open-vote.org> wrote: > Try: > > site:http://www.winehq.org/pipermail/wine-patches/ Steven Edwards Thanks that works a little better, though normally I would do something like wine-devel AUTHOR Subject and depending on how much discussion a certain patch set had gotten its relivancy would be higher. Ditto for the patches list. Using site: seems to help a bit but the behavior of the search has still changed as is kind of annoying. Anyone have any idea why? -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

Nov. 7, 2007

Re: %fs, %gs on AROS hosted

by Marcus Meissner

On Tue, Nov 06, 2007 at 10:17:12PM +0100, Staf Verhaegen wrote: > Hello wine developers, > > I am an AROS developer (http://www.aros.org) that is an open source > implementation of the old AmigaOS. It has also the possiblity to run > hosted on other OSes and is thus very similar to wine. I know that this > group is for wine posts but I think I could reuse much of the knowledge > gained by the wine developers for AROS. > > Recently there has been discussion about the use of the %fs and %gs > segment for AROS purposes and thus also for the hosted version. > As wine also has to handle these registers, I am interested to know how > wine handles these registers. Or doesn't wine have to take these registers > into account ? > I did download the 0.9.48 source code of wine and I only did find some > places where a proper saving and restoring of these registers was done. Is > there something I am overlooking ? > Win32 (and so Wine) uses %fs as the thread selector. It needs to stay constant over process switches (as in "saved") and the base virtual address must be settable. Older Wines allocate a (LDT?) selector themselves for %fs, newer ones have it use a GDT (?) slot. %gs is not used in 32bit mode usually, but Win16 programs use it and so it should be allocatable and savable too. Ciao, Marcus

Nov. 7, 2007

Re: What the hell is up with searching google for wine-devel and wine-patches posts?

by Scott Ritchie

Steven Edwards wrote: > Hi, > I guess this issue is more directed at Dan and the rest of the google > guys we have lurking here but > has anyone else noticed how hard it is to do a google search for > discussions on wine-devel or > look for patches that have been submitted? I used to just be able to > search as follows > > wine-patches Steven Edwards > > and see every patch I ever submitted to wine. Ditto for most threads > on wine-devel. This is really > getting to be a pain for me because I need to be able to search for > patches that might not have > been merged in but still have merit for some of my customers. > > Thanks Try: site:http://www.winehq.org/pipermail/wine-patches/ Steven Edwards Thanks, Scott Ritchie

Nov. 7, 2007

Re: Develop .h for Wine by looking Microsoft Platform SDK

by Stefan Dösinger

Am Mittwoch, 7. November 2007 01:00:54 schrieb King InuYasha: > It is not legal at all. Using Microsoft Platform SDK header code is not > under the GNU General Public License version 2.0 or its listed compatible > licenses, so you have to do it manually WITHOUT looking at the PSDK. I > recommend removing the PSDK from your system as a way to remove temptation. Headers contain facts, and facts cannot be copyrighted. Also the sdk headers are the only source of information. Collecting them from the msdn is not going to work. The typing of the header itself is copyrighted though, so you must not copypaste from the MS Header. The wine header should be implemented as differently as possible, but still be 100% compatible. Especially watch out that the wine header includes the same files the other header does.

Nov. 7, 2007