November 2007 - Wine-Devel - list.winehq.org

Re: #winehq admin troubles

by Tom Wickline

On 11/5/07, Chris Morgan <chmorgan(a)gmail.com> wrote: > > I agree that this isn't something that should continue. Kicking should > be reserved for people being disruptive. There is no reason to be > anything other than polite to users asking for help. > > Allowing this kind of behavior to continue reflects poorly on us as a > community. I'd like to suggest that this be the last time we hear > about issues like this. If it happens again I'd like to propose a > graduated scale of irc channel bans, starting at one month, for > Vitamin. > > Chris I hope this is a joke! There is absolutely nothing wrong with they way Vitamin handles himself in #winehq. When these people come crying to wine-devel they leave out about 98% of the facts, 100% of the time. Tom > > >

Nov. 5, 2007

Re: #winehq admin troubles

by Vitaliy Margolen

feba thatl wrote: > > (09:32:56 PM) The topic for #winehq is:[long topic removed] > (09:33:09 PM) ***vitamin fucking tired all knowning noobs! > (09:33:15 PM) <Name removed, same person from #ubuntu>: wine: cannot > find '/media/cdrom0/intro.exe' > (09:33:15 PM) vitamin: usrl, you better leave > (09:33:25 PM) usrl: Why? > (09:33:32 PM) mode (+b *!*n=feba(a)*.hsd1.ks.comcast.net ) by vitamin > (09:33:32 PM) You have been kicked by vitamin: (vitamin) > You omitted the reason: Nov 04 20:30:56 <usrl> Gunn: that's an old version. Go to winehq.org and follow their instructions to add them to your repos. Nov 04 20:31:05 <vitamin> fester, how are you "loading" that program? Nov 04 20:31:09 <usrl> Gunn: it will be more up to date that way Nov 04 20:31:25 <vitamin> usrl, that's not a problem here Nov 04 20:31:37 <usrl> vitamin: I know, but it's helpful anyway. You got into middle of conversation, suggested something that user does not need (as 0.9.47 and 0.9.48 are still broken for most Source games). But since it seems that no one really gives a rip about what's going on on the channel, please whoever has higher access then me, remove me from the ops list. I don't want to explain myself every time some some one feels "wronged" and have to run to the mailing list to complain about it. Vitaliy.

Nov. 5, 2007

Re: #winehq admin troubles

by Chris Morgan

On 11/4/07, feba thatl <febaen(a)gmail.com> wrote: > Sorry if this mailing list is less than appropriate, but from what > I've seen this is where the conversation was last time, and there > doesn't seem to be much better. > > A while ago (Probably one-three months), I went to #winehq to ask > about something, and was treated rather rudely by vitamin. I got > annoyed by him, and made a somewhat rude comment myself (not as rude > as he was being, but still probably inappropriate), and he kicked me. > I rejoined the channel, and I don't really remember what happened > afterwards, but it can't have been too awful as I don't believe I was > banned. I do remember being left with a very sour taste with Wine, as > I googled vitamin, and found that this was nowhere near the first time > he had been needlessly rude to a user and had even given completely > unwarranted bans with seemingly no reprimand. > > I gradually started going back to winehq for help and questions, with > no problems. Last night, I went in to ask if anyone wanted to help me > get a program working, and vitamin replied. I groaned to myself, but > we had a perfectly civil conversation. At one point he stopped > replying, but it's not like I haven't had to walk off myself for > various reasons, so I just left quietly. > > Today, I joined #ubuntu to try to get something working, and found > someone else asking for help with Wine. I (amongst others) recommended > they go to #winehq. They joined, but commented in #ubuntu that, quote: > > (09:27:58 PM) <Name removed>: man these #winehq people are not friendly at all > > I joined #winehq and confirmed my fears that vitamin was being rude to > someone else. Vitamin asked what version they were running, they > answered with 9.46 (the version in the Ubuntu repos, last I checked), > and I recommended they go to winehq.org and follow the instructions on > how to add the Wine repos. Vitamin said something along the lines of > "that isn't the case here", I said that it's still helpful (to have an > up to date version of wine). I then asked if Vitamin had got the > program we talked about last night working, and seconds later was > kicked. No explanation, the kick line just had "(Vitamin)". Utterly > confused, I rejoined, for which I do have a chatlog: > > (09:32:56 PM) The topic for #winehq is:[long topic removed] > (09:33:09 PM) ***vitamin fucking tired all knowning noobs! > (09:33:15 PM) <Name removed, same person from #ubuntu>: wine: cannot > find '/media/cdrom0/intro.exe' > (09:33:15 PM) vitamin: usrl, you better leave > (09:33:25 PM) usrl: Why? > (09:33:32 PM) mode (+b *!*n=feba(a)*.hsd1.ks.comcast.net ) by vitamin > (09:33:32 PM) You have been kicked by vitamin: (vitamin) > > That's the entire chatlog of my second time joining (I didn't think to > save a copy of the first), with nothing removed but a bunch of topic > stuff nobody wants to read and the fellow from #ubuntu's nick. > > Now, I not only have been banned for apparently being a noob (Again, > it's a best guess, Vitamin did not give any clue at all in his kick > messages, let alone a warning in the channel) in a channel that is > supposed to support end users, but a few minutes later, I see this, > again in #ubuntu: > > (09:37:15 PM) <Name removed>: well I got banned from winehq for asking > a question > > > This person didn't seem rude at all when I was talking to them. > Thankfully, they were able to get their problems resolved in #ubuntu. > > Given that vitamin seems to have had user abuse problems in the past, > what is going on here? I can understand not getting professional > service in an IRC channel, but why is someone who is so needlessly > abusive (again, kicking people for little more than asking a question; > when the channel is for support.) entrusted with admin abilities? From > what I read on another complaint, he seems to be in this position > because he is a developer, not because he is truly a good fit for > being a moderator or even a helper. While he might be great at coding, > his people skills definitely suffer. I can understand getting angry > over people asking their questions right, but when you're trying to > support end users, you have to be able to deal with at least some > stupidity-- and even disregarding that, if you're going to not only > kick someone, but ban them, give them some idea of what they did > wrong. > > It almost seems to me as if he is banning people not because they did > something wrong, but because he had a bad day-- like I said, last > night he was fairly civil, even though I'm sure I made my share of > stupid questions and comments. I'm not sure if this is the only > moderator with these sorts of problems, but something needs to be > done. Wine is used by all sorts of people, heck, my mother uses it. > When all sorts of people are using a program, all sorts of people are > going to be having problems with it. I wouldn't expect my mother, or > anyone else's, to be able to phrase their question well and make a > support person happy, but I also wouldn't expect someone who is > supposed to be supporting users insulting them and banning them (not > only ignoring their need for help, but effectively making it > impossible for many other people to help them as well). > > Something needs to change, Wine is something a lot of people switching > to non-Windows OS are going to use, and many people could be easily > turned off when they find the first place they turn to for help, the > place that winehq.org leads them to, not only has very rude people in > power, but has no checks or guards to keep said people from ruining a > user's experience. > I agree that this isn't something that should continue. Kicking should be reserved for people being disruptive. There is no reason to be anything other than polite to users asking for help. Allowing this kind of behavior to continue reflects poorly on us as a community. I'd like to suggest that this be the last time we hear about issues like this. If it happens again I'd like to propose a graduated scale of irc channel bans, starting at one month, for Vitamin. Chris

Nov. 5, 2007

#winehq admin troubles

by feba thatl

Sorry if this mailing list is less than appropriate, but from what I've seen this is where the conversation was last time, and there doesn't seem to be much better. A while ago (Probably one-three months), I went to #winehq to ask about something, and was treated rather rudely by vitamin. I got annoyed by him, and made a somewhat rude comment myself (not as rude as he was being, but still probably inappropriate), and he kicked me. I rejoined the channel, and I don't really remember what happened afterwards, but it can't have been too awful as I don't believe I was banned. I do remember being left with a very sour taste with Wine, as I googled vitamin, and found that this was nowhere near the first time he had been needlessly rude to a user and had even given completely unwarranted bans with seemingly no reprimand. I gradually started going back to winehq for help and questions, with no problems. Last night, I went in to ask if anyone wanted to help me get a program working, and vitamin replied. I groaned to myself, but we had a perfectly civil conversation. At one point he stopped replying, but it's not like I haven't had to walk off myself for various reasons, so I just left quietly. Today, I joined #ubuntu to try to get something working, and found someone else asking for help with Wine. I (amongst others) recommended they go to #winehq. They joined, but commented in #ubuntu that, quote: (09:27:58 PM) <Name removed>: man these #winehq people are not friendly at all I joined #winehq and confirmed my fears that vitamin was being rude to someone else. Vitamin asked what version they were running, they answered with 9.46 (the version in the Ubuntu repos, last I checked), and I recommended they go to winehq.org and follow the instructions on how to add the Wine repos. Vitamin said something along the lines of "that isn't the case here", I said that it's still helpful (to have an up to date version of wine). I then asked if Vitamin had got the program we talked about last night working, and seconds later was kicked. No explanation, the kick line just had "(Vitamin)". Utterly confused, I rejoined, for which I do have a chatlog: (09:32:56 PM) The topic for #winehq is:[long topic removed] (09:33:09 PM) ***vitamin fucking tired all knowning noobs! (09:33:15 PM) <Name removed, same person from #ubuntu>: wine: cannot find '/media/cdrom0/intro.exe' (09:33:15 PM) vitamin: usrl, you better leave (09:33:25 PM) usrl: Why? (09:33:32 PM) mode (+b *!*n=feba(a)*.hsd1.ks.comcast.net ) by vitamin (09:33:32 PM) You have been kicked by vitamin: (vitamin) That's the entire chatlog of my second time joining (I didn't think to save a copy of the first), with nothing removed but a bunch of topic stuff nobody wants to read and the fellow from #ubuntu's nick. Now, I not only have been banned for apparently being a noob (Again, it's a best guess, Vitamin did not give any clue at all in his kick messages, let alone a warning in the channel) in a channel that is supposed to support end users, but a few minutes later, I see this, again in #ubuntu: (09:37:15 PM) <Name removed>: well I got banned from winehq for asking a question This person didn't seem rude at all when I was talking to them. Thankfully, they were able to get their problems resolved in #ubuntu. Given that vitamin seems to have had user abuse problems in the past, what is going on here? I can understand not getting professional service in an IRC channel, but why is someone who is so needlessly abusive (again, kicking people for little more than asking a question; when the channel is for support.) entrusted with admin abilities? From what I read on another complaint, he seems to be in this position because he is a developer, not because he is truly a good fit for being a moderator or even a helper. While he might be great at coding, his people skills definitely suffer. I can understand getting angry over people asking their questions right, but when you're trying to support end users, you have to be able to deal with at least some stupidity-- and even disregarding that, if you're going to not only kick someone, but ban them, give them some idea of what they did wrong. It almost seems to me as if he is banning people not because they did something wrong, but because he had a bad day-- like I said, last night he was fairly civil, even though I'm sure I made my share of stupid questions and comments. I'm not sure if this is the only moderator with these sorts of problems, but something needs to be done. Wine is used by all sorts of people, heck, my mother uses it. When all sorts of people are using a program, all sorts of people are going to be having problems with it. I wouldn't expect my mother, or anyone else's, to be able to phrase their question well and make a support person happy, but I also wouldn't expect someone who is supposed to be supporting users insulting them and banning them (not only ignoring their need for help, but effectively making it impossible for many other people to help them as well). Something needs to change, Wine is something a lot of people switching to non-Windows OS are going to use, and many people could be easily turned off when they find the first place they turn to for help, the place that winehq.org leads them to, not only has very rude people in power, but has no checks or guards to keep said people from ruining a user's experience.

Nov. 5, 2007

Re: libs/wine: Avoid compiler warnings about unused parameter(-W)

by Michael Stefaniuc

Detlef Riekenberg wrote: > Changelog: > libs/wine: Avoid compiler warnings about unused parameter(-W) > > > The code-sequence is optimized away. > Another option would be "__attribute__((unused__))" > or removing the function. > > ------------------------------------------------------------------------ > > From b865b71aff3b8b9c43dffe93f8f0de874cccab53 Mon Sep 17 00:00:00 2001 > From: Detlef Riekenberg <wine.dev(a)web.de> > Date: Sun, 4 Nov 2007 12:58:39 +0100 > Subject: [PATCH] libs/wine: Avoid compiler warnings about unused parameter(-W) > --- > libs/wine/debug.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/libs/wine/debug.c b/libs/wine/debug.c > index 67cc172..5fc56e7 100644 > --- a/libs/wine/debug.c > +++ b/libs/wine/debug.c > @@ -261,6 +261,8 @@ static char *get_temp_buffer( size_t siz > static void release_temp_buffer( char *buffer, size_t size ) > { > /* don't bother doing anything */ > + buffer = buffer; > + size = size; That's just ugly. If removing the function is not an option leaving the function as is is the best approach. -W is the old name for the gcc argument; the new name for it is -Wextra which describes the warnings better: extra warnings; might be legit but can be bogus. > } bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

Nov. 5, 2007

Linux/Windows app connection, how?

by Joshua Scholar

I really want to have some way to communicate between a Linux program and a Windows program running under WINE. The connection doesn't need to be high speed, a stream is fine - I'm just sending some unicode text. I'm writing both programs myself, so I can implement this in the easiest way, though if there was some way to create and call a Windows COM object from Linux, that would be the most direct solution... But reading what I can about WINE, I'm guessing that the only easy thing to do is to write a Windows server application with winegcc and either connect to it through a socket - or to have it spawn a Linux application that it has a stream to. But I need some sample code to know how to do this, since I don't have too much time to experiment. Just to make it clear why I'm doing this - I have some wonderful TTS voices (Neospeech's SAPI5 Japanese voices) installed in WINE and I need to be able to invoke them from a Linux program. Thanks in advance for any pointers, Joshua Scholar

Nov. 5, 2007

Re: libs/wpp: Avoid compiler warnings (-W)

by Dan Hipschman

On Sun, Nov 04, 2007 at 01:04:02PM +0100, Detlef Riekenberg wrote: > > Why is the code only used, when "WANT_NEAR_INDICATION" is defined? > Should we remove the code or enable it always? > > @@ -591,18 +592,17 @@ static void generic_msg(const char *s, c > fprintf(stderr, "%s:%d:%d: %s: ", pp_status.input ? pp_status.input : "stdin", > pp_status.line_number, pp_status.char_number, t); > vfprintf(stderr, s, ap); > -#ifdef WANT_NEAR_INDICATION > + if(n) > { > +#ifdef WANT_NEAR_INDICATION > char *cpy, *p; > - if(n) > - { > - cpy = pp_xstrdup(n); > - for (p = cpy; *p; p++) if(!isprint(*p)) *p = ' '; > - fprintf(stderr, " near '%s'", cpy); > - free(cpy); > - } > - } > + > + cpy = pp_xstrdup(n); > + for (p = cpy; *p; p++) if(!isprint(*p)) *p = ' '; > + fprintf(stderr, " near '%s'", cpy); > + free(cpy); > #endif > + } > fprintf(stderr, "\n"); > } > Related, although not really a great solution: http://www.winehq.org/pipermail/wine-cvs/2006-September/026094.html I forget, are the extra "near" messages actually helpful, or misleading? In any case, whatever ends up happening here should probably also happen in widl, since it uses wpp and consistent warning/error messages are nice.

Nov. 4, 2007

Re: Bugs in dlls/wsock32/socket.c

by Juan Lang

Hi Gerald, On Nov 3, 2007 9:58 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > dlls/wsock32/socket.c has the following code: > > DWORD routeTableSize, numRoutes, ndx, ret; > > numRoutes = min(routeTableSize - sizeof(MIB_IPFORWARDTABLE), > 0) / sizeof(MIB_IPFORWARDROW) + 1; > > The problem here is that both routeTableSize and sizeof(...) are of an > unsigned type, so their difference is also unsigned. Which means that > the minimum between that difference and 0 always will be 0, the result > of the division will thus always be zero, and the result of the entire > expressions is a constant 1. > > I have a hunch this is not the intendend purpose of this code, is it? Heh - no, that's not the intended purpose ;) I'll send a patch. Thanks, --Juan

Nov. 4, 2007

Re: dlls/comctl32/listview.c warning elimination

by Gerald Pfeifer

On Mon, 29 Oct 2007, Alexandre Julliard wrote: >> Not a patch I am particularily proud of, but the best way I found to get >> rid of >> >> listview.c:5043: warning: 'strW' might be used uninitialized in this function >> >> issued by GCC, and apart from the added cast it actually is simpler than >> the original. > It was done the way it is precisely to avoid the non-const cast, which > triggers a warning too. Hmm, I didn't see that other warning, but I can easily see that some versions of GCC or other compilers would do so. The only patch I can think of that avoid *both* warnings is the one below. Not perfect, but I fair compromise. What do you think? Or do you have any better idea that we might want to try? Gerald Index: dlls/comctl32/listview.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/listview.c,v retrieving revision 1.490 diff -u -3 -p -r1.490 listview.c --- dlls/comctl32/listview.c 23 Oct 2007 18:16:28 -0000 1.490 +++ dlls/comctl32/listview.c 4 Nov 2007 18:21:34 -0000 @@ -5040,12 +5040,18 @@ static INT LISTVIEW_FindItemA(const LIST BOOL hasText = lpFindInfo->flags & (LVFI_STRING | LVFI_PARTIAL); LVFINDINFOW fiw; INT res; - LPWSTR strW; memcpy(&fiw, lpFindInfo, sizeof(fiw)); - if (hasText) fiw.psz = strW = textdupTtoW((LPCWSTR)lpFindInfo->psz, FALSE); - res = LISTVIEW_FindItemW(infoPtr, nStart, &fiw); - if (hasText) textfreeT(strW, FALSE); + + if (hasText) + { + LPWSTR strW; + fiw.psz = strW = textdupTtoW((LPCWSTR)lpFindInfo->psz, FALSE); + res = LISTVIEW_FindItemW(infoPtr, nStart, &fiw); + textfreeT(strW, FALSE); + } else + res = LISTVIEW_FindItemW(infoPtr, nStart, &fiw); + return res; }

Nov. 4, 2007

'kernel32_test loader' causes BSOD on XP SP1

by Francois Gouget

So I'm running tests in an XP SP1 VM and yet, you can see no such results on http://test.winehq.org/data/. The reason for is that the 'kernel32_test loader' causes XP SP1 to crash, so that winetest.exe never has an opportunity to send the results. So I investigated this and the specific test that causes the crash is this one: { &dos_header, sizeof(dos_header), 1, sizeof(IMAGE_OPTIONAL_HEADER), 0x200, 0x200, sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER) + 0x1000, sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER), ERROR_SUCCESS }, I noticed the 0x1000. Shouldn't this be a 0x200? Or is that the whole point of this test? In any case, changing it to 0x200 avoids crashing SP1. Another weird way to avoid the crash is to introduce a Sleep(1000) just before the LoadLibrary(). I've summed up both ways to avoid the crash in the patch below. Hopefully someone more familiar with the loader than me can have a look into this and suggest a proper fix. diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c index 49af819..f9f9e0b 100644 --- a/dlls/kernel32/tests/loader.c +++ b/dlls/kernel32/tests/loader.c @@ -139,7 +139,7 @@ START_TEST(loader) }, { &dos_header, sizeof(dos_header), 1, sizeof(IMAGE_OPTIONAL_HEADER), 0x200, 0x200, - sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER) + 0x1000, + sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER) + 0xf00, sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER), ERROR_SUCCESS }, @@ -321,6 +322,11 @@ START_TEST(loader) file_size = GetFileSize(hfile, NULL); CloseHandle(hfile); + if (0 && i == 4) + { + /* Required to avoid a crash on Windows XP SP1 */ + Sleep(1000); + } SetLastError(0xdeadbeef); hlib = LoadLibrary(dll_name); if (td[i].error == ERROR_SUCCESS) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux, WinNT, MS-DOS - also known as the Good, the Bad and the Ugly.

Nov. 4, 2007