November 2007 - Wine-Devel - list.winehq.org

Re: [4/8] WineD3D: Do not try to disable unsupported texture units

by H. Verbeet

On 27/11/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > textures. In this case we build a texture map to read a texture from a > lower texture unit from a higher register combiner. This texture unit > always stays below GL_LIMITS(textures) though. Yes, but you're checking against the sampler, not the texture unit. Shouldn't you be checking against mapped_stage instead?

Nov. 28, 2007

d3dx8 [patch 1/10] Implement D3DXPlaneFromPointNormal

by tony.wasserka＠freenet.de

Anyways, where should we put the d3dx9 code? I mean, we have 13 folders to choose from.. Perhaps It'd be better if we create a new dll (or at least directory) called d3dx9 were we implement all d3dx9 stuff and let the other d3dx9_xx dlls just call these functions? This would improve the clarity of the code structure, so that people that don't follow this discussion can also understand what we're doing ;-)

Nov. 28, 2007

Re: TransGaming's dpnet (DirectPlay 8)

by Gavriel State

Hi Kai, Sorry about that - looks like I hadn't in fact updated my git tree quite properly. Also, I left out a header file I think. Try this patch instead. Take care, -Gav Kai Blin wrote: > On Wednesday 21 November 2007 05:42:18 Gavriel State wrote: > > >> Enclosed here is a patch to today's WineHQ git tree with our dpnet >> implementation in the hopes that someone finds it useful. Beyond >> ensuring that it compiles and links, it has not been tested at all with >> WineHQ. >> > > That's funny, it doesn't even apply for me against today's git, and the last > changes to dlls/dpnet are months old. Would you be so kind and supply the > plain source code of dlls/dpnet/address.c ? > > I've pulled the patch apart and the other changes apply or are trivial to fix > manually. > > Once the code compiles for me, I'll push it to a public git repo. I think the > next step would be adding some tests. > > Cheers, > Kai > > > ------------------------------------------------------------------------ > > > -- Gavriel State Founder & CTO TransGaming Inc. gav(a)transgaming.com http://www.transgaming.com Broadening The Playing Field

Nov. 27, 2007

Re: [PATCH] svchost: Implementation of svchost (revised submission)

by Roy Shea

On Tue, Nov 27, 2007 at 03:37:50PM -0600, James Hawkins wrote: > On Nov 27, 2007 3:21 PM, Roy Shea <roy(a)cs.hmc.edu> wrote: > > This is a revised and standalone version of svchost patch. Changes in > > this revision include: > > > > - Unicode based with a simple UNICODE to ASCII function used to > > convert the lpProcName passed into GetProcAddress > > > > I think you're misunderstanding Wine's policy about not using ansi > functions or constant strings. That only applies to external APIs > because we don't want to convert from unicode to ansi (lossy). > There's nothing wrong with just using: > > GetProcAddress(library, "ServiceMain"); > > There aren't many instances where W->A is valid. The name of the procedure passed into GetProcAddress is not always the constant string "ServiceMain". In these cases I'm getting the procedure name from RegQueryValueEx. RegQueryValueEx requires a little bit of error checking to ensure proper NULL termination of a REG_SZ. I'd already wrapped this into the helper function GetRegValue and thought a simple conversion from UnicodeToAscii would be cleaner than writing a second ANSI version of GetRegValue. I guess that inlining a native ANSI query doesn't look too bad: ---- /* Look for alternate to default ServiceMain entry point */ ret = RegQueryValueExA(service_hkey, service_main, NULL, NULL, NULL, &size); if (ret != ERROR_SUCCESS) { dll_service_main = NULL; } else { dll_service_main = HeapAlloc(GetProcessHeap(), 0, size); ret = RegQueryValueExA(service_hkey, service_main, NULL, NULL, (LPBYTE)dll_service_main, &size); if (ret != ERROR_SUCCESS) { HeapFree(GetProcessHeap(), 0, dll_service_main); RegCloseKey(service_hkey); goto cleanup; } if (dll_service_main[size-1] != '\0') { WINE_TRACE("NULL terminating registry entry: %s\n", service_main); tmp_value = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, dll_service_main, size+1); if (!tmp_value) { HeapFree(GetProcessHeap(), 0, dll_service_main); RegCloseKey(service_hkey); goto cleanup; } dll_service_main = tmp_value; } } RegCloseKey(service_hkey); /* Load the DLL and obtain a pointer to ServiceMain entry point */ library = LoadLibraryW(dll_name_long); if (!library) { WINE_ERR("failed to load library %s, err=%u\n", wine_dbgstr_w(dll_name_long), GetLastError()); goto cleanup; } if (dll_service_main) { service_main_func = (LPSERVICE_MAIN_FUNCTIONW) GetProcAddress(library, dll_service_main); } else { service_main_func = (LPSERVICE_MAIN_FUNCTIONW) GetProcAddress(library, service_main); } if (!service_main_func) { WINE_ERR("cannot locate ServiceMain procedure in DLL for %s\n", wine_dbgstr_w(service_name)); FreeLibrary(library); goto cleanup; } ---- I'll switch svchost over to a direct ANSI query when looking up the DLL's service main function. > > - Using HEAP_ZERO_MEMORY flag in calls to HeapAlloc and HeapReAlloc > > that are allocating space for a string and the NULL terminator to > > set the NULL terminator to zero. > > > > Why HEAP_ZERO_MEMORY when you can just set the last byte to NULL? > > str[LEN - 1] = '\0'; I was saving a line of code at the cost of performance. My bad. Thanks for catching this. And thank you for your continued help with this patch. Peace, -Roy

Nov. 27, 2007

Re: d3dx9_xx [patch 2/2] Implementation of the different d3dx9_xx lls

by Maciej Kowalczyk

Hi! > +@ stdcall D3DXVec2Normalize(ptr ptr) d3dx8.D3DXVec3Normalize Shouldn't it be "d3dx8.D3DXVec2Normalize"? This line is copy-pasted 13 times around the patch. -- Maciej Kowalczyk

Nov. 27, 2007

Re: [PATCH] svchost: Implementation of svchost (revised submission)

by James Hawkins

On Nov 27, 2007 3:21 PM, Roy Shea <roy(a)cs.hmc.edu> wrote: > This is a revised and standalone version of svchost patch. Changes in > this revision include: > > - Unicode based with a simple UNICODE to ASCII function used to > convert the lpProcName passed into GetProcAddress > I think you're misunderstanding Wine's policy about not using ansi functions or constant strings. That only applies to external APIs because we don't want to convert from unicode to ansi (lossy). There's nothing wrong with just using: GetProcAddress(library, "ServiceMain"); There aren't many instances where W->A is valid. > - Using HEAP_ZERO_MEMORY flag in calls to HeapAlloc and HeapReAlloc > that are allocating space for a string and the NULL terminator to > set the NULL terminator to zero. > Why HEAP_ZERO_MEMORY when you can just set the last byte to NULL? str[LEN - 1] = '\0'; -- James Hawkins

Nov. 27, 2007

Re: [keyboard] GetAsyncKeyState: request for fixing #5623

by Rafał Miłecki

2007/11/26, Stefan Dösinger <stefandoesinger(a)gmx.at>: > Am Montag, 26. November 2007 12:17:07 schrieb Rafał Miłecki: > > 2007/11/7, Rafał Miłecki <zajec5polish(a)gmail.com>: > > > Bug is quite well decribed in: > > > http://bugs.winehq.org/show_bug.cgi?id=5623 but if you don't > > > understand this, I can try to explain more detailed. > > > > > > So my request is someone try to fix this bug. Anyone have a free > > > moment for this, please? > > > > Really, not a chance for fixing this? I know you are busy, have own > > life, efc. but... maybe? Anyone, please? > The usual way for that is either to offer payment to someone to fix it, or fix > it yourself. > > Offering bug bounties was tried in the past, but I don't know how well they > worked. The issue is that usually affordable bounties are not comparable to > usual salaries and the issues involved with handling the bounty and reading > into the code. $100 for a bug bounty is quite a lot already, but at > codeweavers we have some estimation that fixing a minor bug costs about $1000 > to $1500 to fix(http://www.codeweavers.com/services/engagements/) . Sure, in a lot of cases the easiest way is to pay and get it done. Unfortunately not every person is able to offer hundreds of $ (as I am not). > So the most efficient way to get a bug fixed is to read into the code > yourself. I tried. I found function implementing GetAsyncKeyState but that's all I was able to do. Improveing this implementation was much over my little skills. > The bottom line is that while a free software project may be freely > downloadable, but it is not a place where one can expect service for free. I understand that and hope there wasn't anything wrong in my request. I tried be kind and ask for help, not demand it. -- Rafał Miłecki

Nov. 27, 2007

Re: urlmon: Callback can be NULL

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Changelog: > urlmon: The callback parameter can be null, check pointer before using. This breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so stream.c && touch stream.ok stream.c:210: Test failed: unexpected call OnDataAvailable stream.c:329: Test failed: IStream_Read failed with error 0x00000001 stream.c:330: Test failed: read data differs from file make: *** [stream.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

Nov. 27, 2007

Re: d3dx8: Implementation of WINAPI D3DXAssembleShaderFromFileA

by Michael Stefaniuc

Frank Richter wrote: > On 27.11.2007 09:28, Michael Stefaniuc wrote: >> Just go for >> if ( !pSrcFile ) >> return D3DXERR_INVALIDDATA; >> >> LPWSTR pSrcFileW = NULL; >> DWORD len; >> HRESULT ret; >> ... > > That's C++, not C, isn't it? No it is C as C99 allows to have the variable definitions in the middle of the code. But Wine itself doesn't allow that and i have missed that. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

Nov. 27, 2007

Re: d3dx8: Implementation of WINAPI D3DXAssembleShaderFromFileA

by Frank Richter

On 27.11.2007 09:28, Michael Stefaniuc wrote: > Just go for > if ( !pSrcFile ) > return D3DXERR_INVALIDDATA; > > LPWSTR pSrcFileW = NULL; > DWORD len; > HRESULT ret; > ... That's C++, not C, isn't it? -f.r.

Nov. 27, 2007