February 2007 - Wine-Devel - list.winehq.org

One school's list of must-have apps

by Dan Kegel

Here's a school that actually did transition to Linux: http://searchopensource.techtarget.com/originalContent/0,289142,sid39_gci12… They didn't use Wine. Here's what they said about legacy windows apps: "Using Wyse terminals, the district also planned to offer students and staff thin-client desktops running OpenOffice.org. Ericom software – a Citrix alternative -- enabled the terminals to run the district's existing and irreplaceable Microsoft Windows educational applications, including Type to Learn, Reading Counts and Kid Pix." - Dan

Feb. 28, 2007

Re: Wine's Wiki Defaced

by Felix Nawothnig

Francois Gouget wrote: > Someone has defaced Wine's Wiki frontpage. > Also I have either forgotten my password or the user accounts don't > work anymore. Could someone look into this? Reverted it (no idea about the accounts, I was still logged in).

Feb. 28, 2007

Re: Using ex-user32 controls from native comctl32 6

by Felix Nawothnig

Frank Richter wrote: >>So, any idea how Windows makes comctl32 register the user classes? > I think it just re-registered the classes, but I'm not sure. > A trace with class registrations (ie +class) might give some hint at > what native does. Okay, I was stupid. I removed registration of all the user32 classes, only some were copied over to comctl32. Anyway, it works "fine" know. Well. Actually it doesn't even initialize without some stubs but it runs. I have a native edit control in wine for the first time since 9x times eh? :) Felix

Feb. 28, 2007

Wine's Wiki Defaced

by Francois Gouget

Someone has defaced Wine's Wiki frontpage. Also I have either forgotten my password or the user accounts don't work anymore. Could someone look into this? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ War doesn't determine who's right. War determines who's left.

Feb. 28, 2007

Re: [6/6] d3d9: Add a mova rounding test

by H. Verbeet

On 28/02/07, Alexandre Julliard <julliard(a)winehq.org> wrote: > The test fails here: > > ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok > visual.c:405: Test failed: Expected color 00ffff00, got 00000000 (for input -2.400000) > visual.c:405: Test failed: Expected color 00ffff00, got 00000000 (for input -1.600000) > visual.c:405: Test failed: Expected color 0000ffff, got 00000000 (for input -0.400000) > visual.c:405: Test failed: Expected color 0000ffff, got 00000000 (for input 0.400000) > visual.c:405: Test failed: Expected color 00ff00ff, got 00000000 (for input 1.600000) > visual.c:405: Test failed: Expected color 00ff00ff, got 00000000 (for input 2.400000) > make: *** [visual.ok] Error 6 > Could you run that with +d3d_caps and possibly dump the value of caps.VertexShaderVersion? On a default Wine install that test should be getting skipped because our ARB shader backend doesn't support vs_2_0.

Feb. 28, 2007

Re: Unknown issue with test.winehq.org

by Alexandre Julliard

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > exception: 42 tests executed (0 marked as todo, 0 failures), 0 skipped. > exception: 279 tests executed (0 marked as todo, 5 failures), 0 skipped. > > The first one triggers the 'end of this test' in dissect. The second > one is thus not accepted as dissect expects a 'start' line (and a line > in between actually). > > The question now is: should dissect handle these cases or is this > particular test-case wrong? It's because some of the tests are run in a child process. dissect should probably handle it, ideally by reporting the sum of the test counts as the results for the whole test. -- Alexandre Julliard julliard(a)winehq.org

Feb. 28, 2007

Re: msiexec.exe service registration

by James Hawkins

On 2/27/07, Jeremy <jcgarbage(a)comcast.net> wrote: > In msiexec.c, the DoRegServer calls OpenSCManager, however, on a fresh > installation, ie no ~/.wine, the HKLM\CurrentControlSet\Services does > not yet exist, so that OpenSCManager fails. What is the correct way to > guarantee that this key exists? > See bug 7402. http://bugs.winehq.org/show_bug.cgi?id=7402 -- James Hawkins

Feb. 28, 2007

Re: Unknown issue with test.winehq.org

by Paul Vriens

Paul Vriens wrote: > Hi, > > So finally we have a working winetest executable and the test.winehq.org > scripts should be able to handle the new reports. > > Could someone have a look what the issue currently is on the webserver > as I've sent several reports (a few hours ago) and they are not handled > yet? > > Cheers, > > Paul. > Hi, I think I've found the issue. The error dissect outputs is something like: /wine/winetest/queue/errAfg8T: no start line:4789: ntdll:exception done (5) when looking at the report file I see that with a newer version of the ntdll exception tests we suddenly have 2 lines: exception: 42 tests executed (0 marked as todo, 0 failures), 0 skipped. exception: 279 tests executed (0 marked as todo, 5 failures), 0 skipped. The first one triggers the 'end of this test' in dissect. The second one is thus not accepted as dissect expects a 'start' line (and a line in between actually). The question now is: should dissect handle these cases or is this particular test-case wrong? Cheers, Paul.

Feb. 28, 2007

msi automation patches

by Misha Koshelev

Ok, so since my patches weren't commited to git yet, I've consolidated the new automation changes I've made in the attached patches. James and Rob, if they look good to you I will submit these version to wine-patches (so my total will once again be four patches, 1 is http://www.winehq.org/pipermail/wine-patches/2007-February/036359.html , 2 and 3 attached, and 4 is http://www.winehq.org/pipermail/wine-patches/2007-February/036362.html ) and wait to submit anything more for automation until all 4 patches are in. Please let me know Rob (I used DispGetParam, thanks a lot, so probably just need to look at my AutomationObject::Invoke and then the individual object Invoke handlers in the 0003 patch below) and James (I guess in regards to comments and formatting). Thanks a lot Misha

Feb. 28, 2007

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Felix Nawothnig

Erich Hoover wrote: >>>> The "right" way would probably to do the copying yourself by >>>> read/write.. but I dunno. >>> Except that it would ignore the permissions issues that have already >>> been coded into the copy routines (and any updates that may eventually >> No, CreateFile (and friends) does the permissions checks (which you >> would still have to call). > That was worded poorly, Copy/Move already handle copying file attributes > and I imagine would eventually implement copying the access control list > information. Implementing ReplaceFile as calls to either Copy or Move > takes these issues into account. I see your point. However, since the function you are implementing is in kernel32 anyway you could abstract it away and make both functions (CopyFile and ReplaceFile) call some internal function. That way you would get rid of the locking completly which is argueably somewhat ugly. Felix

Feb. 28, 2007

Re: [8/8] WineD3D: Use the source surface's texture for writing the backup

by H. Verbeet

On 28/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >The hwstretch blit code creates a new texture each time it is called to back up the back buffer and >releases it afterwards. It is more efficient to keep the texture and release it with the surface. This >patch uses the source surface's texture to do the job. Because the source surface is an active render >target its texture is either only needed for blitting(onscreen target) or will be completely overwritten >on the next render target change(offscreen target). Is this supposed to work with FBOs?

Feb. 28, 2007

Unknown issue with test.winehq.org

by Paul Vriens

Hi, So finally we have a working winetest executable and the test.winehq.org scripts should be able to handle the new reports. Could someone have a look what the issue currently is on the webserver as I've sent several reports (a few hours ago) and they are not handled yet? Cheers, Paul.

Feb. 28, 2007

Re: [4/8] WineD3D: Prepare only fixed function samplers for blit

by H. Verbeet

On 28/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >+ /* The blitting code uses (for now) the fixed function pipeline, so make sure to reset all fixed >+ * function texture unit. No need to care for higher samplers >+ */ >+ for(i = GL_LIMITS(texture_stages) - 1; i > 0 ; i--) { You should use GL_LIMITS(textures) here, since that's the number of fixed function texture units.

Feb. 28, 2007

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Erich Hoover

Oops, I must have hit the wrong reply button. >>> The "right" way would probably to do the copying yourself by >>> read/write.. but I dunno. >> Except that it would ignore the permissions issues that have already >> been coded into the copy routines (and any updates that may eventually > No, CreateFile (and friends) does the permissions checks (which you > would still have to call). That was worded poorly, Copy/Move already handle copying file attributes and I imagine would eventually implement copying the access control list information. Implementing ReplaceFile as calls to either Copy or Move takes these issues into account. >> be made to these routines). Also, it seems to me that MSDN is >> describing the list of function calls that ReplaceFile actually makes. > No it doesn't? >From my perspective the "remarks" section discusses the implementation of ReplaceFile as calls to existing API functions (as a sort of macro) as a convenience. Granted, it discusses moving files instead of copying but that conflicted with the file locking. Should I make a new patch file with the previously attached changes or would you prefer that the function be implemented in the read/write manner? Re-implementing the function in such a fashion would make it possible to do a more move-like operation while maintaining the file locking, but would lose out on any future improvements to CopyFile. Erich Hoover ehoover(a)mines.edu On 2/28/07, Felix Nawothnig <flexo(a)holycrap.org> wrote: > > (CC-ing wine-devel again) > > Erich Hoover wrote: > >> The "right" way would probably to do the copying yourself by > >> read/write.. but I dunno. > > Except that it would ignore the permissions issues that have already > > been coded into the copy routines (and any updates that may eventually > > No, CreateFile (and friends) does the permissions checks (which you > would still have to call). > > > be made to these routines). Also, it seems to me that MSDN is > > describing the list of function calls that ReplaceFile actually makes. > > No it doesn't? > > Your other objections were right. Your last version follows for > wine-devel. > > > ------------------------------------------------------------------------ > > > > > /************************************************************************** > > * ReplaceFileW (KERNEL32.@) > > * ReplaceFile (KERNEL32.@) > > */ > > BOOL WINAPI ReplaceFileW(LPCWSTR lpReplacedFileName,LPCWSTR > lpReplacementFileName, > > LPCWSTR lpBackupFileName, DWORD dwReplaceFlags, > > LPVOID lpExclude, LPVOID lpReserved) > > { > > HANDLE hReplaced, hReplacement; > > BOOL skipBackup = FALSE; > > > > if(dwReplaceFlags) > > FIXME("Ignoring flags %x\n", dwReplaceFlags); > > /* First two arguments are mandatory */ > > if(!lpReplacedFileName || !lpReplacementFileName) > > { > > SetLastError( ERROR_INVALID_PARAMETER ); > > return FALSE; > > } > > /* > > * Lock the "replacement" file, fail if it does not exist > > */ > > if((hReplacement = CreateFileW(lpReplacementFileName, GENERIC_READ, > > FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, > > NULL, OPEN_EXISTING, 0, 0)) == INVALID_HANDLE_VALUE) > > { > > return FALSE; > > } > > if(!LockFile( hReplacement, 0, 0, 0, 0 )) > > { > > CloseHandle( hReplacement ); > > return FALSE; > > } > > /* > > * Lock the "replaced" file while we're working. > > */ > > if((hReplaced = CreateFileW(lpReplacedFileName, GENERIC_READ, > > FILE_SHARE_READ | FILE_SHARE_WRITE, > > NULL, OPEN_EXISTING, 0, 0)) == INVALID_HANDLE_VALUE) > > { > > /* If "replaced" does not exist then create it for the lock, but > skip backup */ > > if((hReplaced = CreateFileW(lpReplacedFileName, GENERIC_READ, > > FILE_SHARE_READ | FILE_SHARE_WRITE, > > NULL, CREATE_ALWAYS, 0, 0)) == INVALID_HANDLE_VALUE) > > { > > UnlockFile( hReplacement, 0, 0, 0, 0 ); > > CloseHandle( hReplacement ); > > return FALSE; > > } > > skipBackup = TRUE; > > } > > if(!LockFile( hReplaced, 0, 0, 0, 0 )) > > { > > UnlockFile( hReplacement, 0, 0, 0, 0 ); > > CloseHandle( hReplacement ); > > CloseHandle( hReplaced ); > > return FALSE; > > } > > /* > > * If the user wants a backup then that needs to be performed first > > */ > > if( lpBackupFileName && !skipBackup ) > > { > > /* If an existing backup exists then copy over it */ > > if(!CopyFileW( lpReplacedFileName, lpBackupFileName, FALSE )) > > goto replace_fail; > > } > > /* > > * Now that the backup has been performed (if requested), copy the > replacement > > * into place > > */ > > if(!CopyFileW( lpReplacementFileName, lpReplacedFileName, FALSE )) > > { > > /* Assume that all access denied errors are a write problem. */ > > if(GetLastError() == ERROR_ACCESS_DENIED) > > SetLastError( ERROR_UNABLE_TO_REMOVE_REPLACED ); > > else > > SetLastError( ERROR_UNABLE_TO_MOVE_REPLACEMENT ); > > goto replace_fail; > > } > > /* Delete the replacement file */ > > if(!DeleteFileW( lpReplacementFileName )) > > return FALSE; > > /* Unlock the handles */ > > UnlockFile( hReplacement, 0, 0, 0, 0 ); > > CloseHandle( hReplacement ); > > UnlockFile( hReplaced, 0, 0, 0, 0 ); > > CloseHandle( hReplaced ); > > /* All done, file replacement successful */ > > return TRUE; > > > > replace_fail: > > UnlockFile( hReplacement, 0, 0, 0, 0 ); > > CloseHandle( hReplacement ); > > UnlockFile( hReplaced, 0, 0, 0, 0 ); > > CloseHandle( hReplaced ); > > return FALSE; > > } > >

Feb. 28, 2007

Using ex-user32 controls from native comctl32 6

by Felix Nawothnig

(CC-ing to Frank Richter because I hope he knows the answer :) Hi. I've been trying to make wine use the ex-user32 controls (listbox, scrollbox, etc.) in comctl32 where Microsoft copied them to in version 6 to get message traces of those controls (I know I could use msg spy tools on Windows but comparing two Wine spy logs is way more straight forward, especially since those tools don't get you stuff like +win). You need a manifest file on Windows to get application to use comctl6 but we don't use that since we've chosen to theme the user controls via subclassing. I've tried to just remove registration of the classes from our user32 and use native comctl32 6 (which otherwise works nice) but no success. So, any idea how Windows makes comctl32 register the user classes? Felix

Feb. 28, 2007

Re: Using ex-user32 controls from native comctl32 6

by Frank Richter

On 28.02.2007 18:26, Felix Nawothnig wrote: > So, any idea how Windows makes comctl32 register the user classes? I think it just re-registered the classes, but I'm not sure. A trace with class registrations (ie +class) might give some hint at what native does. -f.r.

Feb. 28, 2007

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Felix Nawothnig

(CC-ing wine-devel again) Erich Hoover wrote: >> The "right" way would probably to do the copying yourself by >> read/write.. but I dunno. > Except that it would ignore the permissions issues that have already > been coded into the copy routines (and any updates that may eventually No, CreateFile (and friends) does the permissions checks (which you would still have to call). > be made to these routines). Also, it seems to me that MSDN is > describing the list of function calls that ReplaceFile actually makes. No it doesn't? Your other objections were right. Your last version follows for wine-devel. > ------------------------------------------------------------------------ > > /************************************************************************** > * ReplaceFileW (KERNEL32.@) > * ReplaceFile (KERNEL32.@) > */ > BOOL WINAPI ReplaceFileW(LPCWSTR lpReplacedFileName,LPCWSTR lpReplacementFileName, > LPCWSTR lpBackupFileName, DWORD dwReplaceFlags, > LPVOID lpExclude, LPVOID lpReserved) > { > HANDLE hReplaced, hReplacement; > BOOL skipBackup = FALSE; > > if(dwReplaceFlags) > FIXME("Ignoring flags %x\n", dwReplaceFlags); > /* First two arguments are mandatory */ > if(!lpReplacedFileName || !lpReplacementFileName) > { > SetLastError( ERROR_INVALID_PARAMETER ); > return FALSE; > } > /* > * Lock the "replacement" file, fail if it does not exist > */ > if((hReplacement = CreateFileW(lpReplacementFileName, GENERIC_READ, > FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, > NULL, OPEN_EXISTING, 0, 0)) == INVALID_HANDLE_VALUE) > { > return FALSE; > } > if(!LockFile( hReplacement, 0, 0, 0, 0 )) > { > CloseHandle( hReplacement ); > return FALSE; > } > /* > * Lock the "replaced" file while we're working. > */ > if((hReplaced = CreateFileW(lpReplacedFileName, GENERIC_READ, > FILE_SHARE_READ | FILE_SHARE_WRITE, > NULL, OPEN_EXISTING, 0, 0)) == INVALID_HANDLE_VALUE) > { > /* If "replaced" does not exist then create it for the lock, but skip backup */ > if((hReplaced = CreateFileW(lpReplacedFileName, GENERIC_READ, > FILE_SHARE_READ | FILE_SHARE_WRITE, > NULL, CREATE_ALWAYS, 0, 0)) == INVALID_HANDLE_VALUE) > { > UnlockFile( hReplacement, 0, 0, 0, 0 ); > CloseHandle( hReplacement ); > return FALSE; > } > skipBackup = TRUE; > } > if(!LockFile( hReplaced, 0, 0, 0, 0 )) > { > UnlockFile( hReplacement, 0, 0, 0, 0 ); > CloseHandle( hReplacement ); > CloseHandle( hReplaced ); > return FALSE; > } > /* > * If the user wants a backup then that needs to be performed first > */ > if( lpBackupFileName && !skipBackup ) > { > /* If an existing backup exists then copy over it */ > if(!CopyFileW( lpReplacedFileName, lpBackupFileName, FALSE )) > goto replace_fail; > } > /* > * Now that the backup has been performed (if requested), copy the replacement > * into place > */ > if(!CopyFileW( lpReplacementFileName, lpReplacedFileName, FALSE )) > { > /* Assume that all access denied errors are a write problem. */ > if(GetLastError() == ERROR_ACCESS_DENIED) > SetLastError( ERROR_UNABLE_TO_REMOVE_REPLACED ); > else > SetLastError( ERROR_UNABLE_TO_MOVE_REPLACEMENT ); > goto replace_fail; > } > /* Delete the replacement file */ > if(!DeleteFileW( lpReplacementFileName )) > return FALSE; > /* Unlock the handles */ > UnlockFile( hReplacement, 0, 0, 0, 0 ); > CloseHandle( hReplacement ); > UnlockFile( hReplaced, 0, 0, 0, 0 ); > CloseHandle( hReplaced ); > /* All done, file replacement successful */ > return TRUE; > > replace_fail: > UnlockFile( hReplacement, 0, 0, 0, 0 ); > CloseHandle( hReplacement ); > UnlockFile( hReplaced, 0, 0, 0, 0 ); > CloseHandle( hReplaced ); > return FALSE; > }

Feb. 28, 2007

Error Invalid EXE Format when executing a exe.so built with winelib

by Roger Wimbert

Here is the Debug output: warn:module:load_builtin_dll failed to load .so lib for builtin L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so": /bb/home/.wine/dosdevices/z:/bb/s/bc/wine/dmsw.exe.so: cannot allocate memory in static TLS block warn:module:load_dll Failed to load module L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so"; status=c000007b warn:module:load_builtin_dll failed to load .so lib for builtin L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so": /bb/home/.wine/dosdevices/z:/bb/s/bc/wine/dmsw.exe.so: cannot allocate memory in static TLS block warn:module:load_dll Failed to load module L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so"; status=c000007b wine: could not load L"Z:\\bb\\s\\bc\\wine\\dmsw.exe.so": Fehlerhaftes EXE-Format f³r It has something to do with TLS memory or threads, but the /lib/tls/libc.so is linked in: (rw 8 amd64) /bb/s/bc/wine 105>ldd dmsw.exe.so linux-gate.so.1 => (0xffffe000) libwine.so.1 => /usr/local/lib/libwine.so.1 (0x557be000) libm.so.6 => /lib/tls/libm.so.6 (0x558e8000) libc.so.6 => /lib/tls/libc.so.6 (0x5590a000) libdl.so.2 => /lib/libdl.so.2 (0x55a1f000) /lib/ld-linux.so.2 => /lib/ld-linux.so.2 (0x56555000) Our system: (rw 8 amd64) /bb/s/bc/wine 106>uname -a Linux amd64 2.6.5-7.193-smp #1 SMP Wed Jul 20 14:39:18 UTC 2005 x86_64 x86_64 x86_64 GNU/Linux glibc has version 2.3.3 A simple program does work, but no program which uses threads. wine is created with the 32 bit libraries. If I use the original exe of my program with wine, it does work. Does anyone has an idea what is going wrong? The makefile is attached. Thanks a lot. ### Generated by Winemaker TOPSRCDIR = /bb/s TOPOBJDIR = /bb/s/bc/wine SRCDIR = . SUBDIRS = DLLS = EXES = dmsw.exe ### Common settings CEXTRA = -mno-cygwin -fno-pic -fno-PIC CXXEXTRA = -mno-cygwin CFLAGS = -D_DMSW RCEXTRA = RCFLAGS = -DBB_WINE INCLUDE_PATH = -I. -I/bb/nt/wine -I/bb/s/i -I/bb/fg/i -I/bb/ze/i -I/bb/fe/i -I/bb/pbm/i -I/bb/wb1/i DLL_PATH = LIBRARY_PATH = LIBRARIES = -lmsvcrt40 -lws2_32 -lversion -lnetapi32 -liphlpapi -lcomctl32 -lshlwapi -lwinmm ### dmsw.exe sources and settings dmsw_exe_MODULE = dmsw.exe dmsw_exe_C_SRCS = /bb/s/c/bbcrypt.c \ /bb/s/c/bbdes.c \ /bb/s/c/bbmalloc.c \ /bb/s/c/bbmd5.c \ /bb/s/c/bbo.c \ /bb/s/c/bbtwofish.c \ /bb/s/c/cmp.c \ /bb/s/c/costri.c \ /bb/s/c/cpy.c \ /bb/s/c/datec.c \ /bb/s/c/dfa.c \ /bb/fg/c/dgcode.c \ /bb/fg/c/dgvar.c \ /bb/s/c/dhinfo.c \ /bb/s/c/dholz.c \ /bb/fg/c/digcte.c \ /bb/fg/c/digecm.c \ /bb/fg/c/digranox.c \ /bb/fg/c/digvec.c \ /bb/s/c/dirview.c \ /bb/s/c/dirwalk.c \ /bb/s/c/dmsb.c \ /bb/s/c/dmsc.c \ /bb/s/c/dmsca.c \ /bb/s/c/dmse.c \ /bb/s/c/dmsf.c \ /bb/s/c/dmsfr.c \ /bb/s/c/dmsg.c \ /bb/s/c/dmsh.c \ /bb/s/c/dmshc.c \ /bb/s/c/dmsl.c \ /bb/s/c/dmsliz.c \ /bb/s/c/dmsm.c \ /bb/s/c/dmsmv.c \ /bb/s/c/dmsp.c \ /bb/s/c/dmsr.c \ /bb/s/c/dmss.c \ /bb/s/c/dmssb.c \ /bb/s/c/dmst.c \ /bb/s/c/dmstast.c \ /bb/s/c/dmsw.c \ /bb/s/c/dmswf.c \ /bb/s/c/dmswicon.c \ /bb/s/c/dmsy.c \ /bb/s/c/encode.c \ /bb/s/c/fileleng.c \ /bb/s/c/fordat.c \ /bb/s/c/gtypes.c \ /bb/fg/c/image.c \ /bb/fg/c/imgprint.c \ /bb/s/c/itoa.c \ /bb/fg/c/jpegconv.c \ /bb/s/c/lru.c \ /bb/s/c/ltoa.c \ /bb/s/c/map.c \ /bb/s/c/msleep.c \ /bb/s/c/packbits.c \ /bb/s/c/packdiff.c \ /bb/s/c/pfad.c \ /bb/fg/c/rgbtools.c \ /bb/s/c/rtt.c \ /bb/s/c/scrinfo.c \ /bb/s/c/set.c \ /bb/s/c/sockcom.c \ /bb/s/c/softdum.c \ /bb/s/c/swap.c \ /bb/s/c/syslog.c \ /bb/s/c/textino.c \ /bb/fg/c/tiffconv.c \ /bb/s/c/udpcom.c \ /bb/s/c/utoa.c \ /bb/s/c/vgl.c \ /bb/s/c/w32argv.c \ /bb/fg/c/w32bmp.c \ /bb/s/c/w32error.c \ /bb/s/c/w32font.c \ /bb/fg/c/w32ico.c \ /bb/s/c/w32macadr.c \ /bb/s/c/w32pfad.c \ /bb/s/c/w32pipe.c \ /bb/s/c/w32print.c \ /bb/s/c/w32puts.c \ /bb/s/c/w32reg.c \ /bb/fg/c/w32scalebmp.c \ /bb/s/c/w32screen.c \ /bb/s/c/w32scroll.c \ /bb/s/c/w32toolbar.c \ /bb/s/c/w32tools.c \ /bb/s/c/w32winms.c \ /bb/s/c/wsinit.c \ /bb/s/c/zeitc.c dmsw_exe_CXX_SRCS= dmsw_exe_RC_SRCS = /bb/nt/rc/dmsw/dmsw_wine.rc dmsw_exe_LDFLAGS = -mwindows \ -mno-cygwin dmsw_exe_DLL_PATH= dmsw_exe_DLLS = odbc32 \ ole32 \ oleaut32 \ winspool dmsw_exe_LIBRARY_PATH= dmsw_exe_LIBRARIES= uuid dmsw_exe_OBJS = $(dmsw_exe_C_SRCS:.c=.o) \ $(dmsw_exe_CXX_SRCS:.cpp=.o) \ $(dmsw_exe_RC_SRCS:.rc=.res) ### Global source lists C_SRCS = $(dmsw_exe_C_SRCS) CXX_SRCS = $(dmsw_exe_CXX_SRCS) RC_SRCS = $(dmsw_exe_RC_SRCS) ### Tools CC = winegcc CXX = wineg++ RC = wrc ### Generic targets all: $(SUBDIRS) $(DLLS:%=%.so) $(EXES:%=%.so) ### Build rules .PHONY: all clean dummy $(SUBDIRS): dummy @cd $@ && $(MAKE) # Implicit rules .SUFFIXES: .cpp .rc .res DEFINCL = $(INCLUDE_PATH) $(DEFINES) $(OPTIONS) .c.o: $(CC) -c $(CFLAGS) $(CEXTRA) $(DEFINCL) -o $@ $< .cpp.o: $(CXX) -c $(CXXFLAGS) $(CXXEXTRA) $(DEFINCL) -o $@ $< .cxx.o: $(CXX) -c $(CXXFLAGS) $(CXXEXTRA) $(DEFINCL) -o $@ $< .rc.res: $(RC) $(RCFLAGS) $(RCEXTRA) $(DEFINCL) -fo$@ $< # Rules for cleaning CLEAN_FILES = y.tab.c y.tab.h lex.yy.c core *.orig *.rej \ \\\#*\\\# *~ *% .\\\#* clean:: $(SUBDIRS:%=%/__clean__) $(EXTRASUBDIRS:%=%/__clean__) $(RM) $(CLEAN_FILES) $(RC_SRCS:.rc=.res) $(C_SRCS:.c=.o) $(CXX_SRCS:.cpp=.o) $(RM) $(DLLS:%=%.so) $(EXES:%=%.so) $(EXES:%.exe=%) $(SUBDIRS:%=%/__clean__): dummy cd `dirname $@` && $(MAKE) clean $(EXTRASUBDIRS:%=%/__clean__): dummy -cd `dirname $@` && $(RM) $(CLEAN_FILES) ### Target specific build rules DEFLIB = $(LIBRARY_PATH) $(LIBRARIES) $(DLL_PATH) $(dmsw_exe_MODULE).so: $(dmsw_exe_OBJS) $(CC) $(dmsw_exe_LDFLAGS) -o $@ $(dmsw_exe_OBJS) $(dmsw_exe_LIBRARY_PATH) $(DEFLIB) $(dmsw_exe_DLLS:%=-l%) $(dmsw_exe_LIBRARIES:%=-l%)

Feb. 28, 2007

Re: fc4 rpms

by Bill Medland

On Wed, 2007-28-02 at 09:43 +0100, Andreas Bierfert wrote: > On Tue, 27 Feb 2007 18:17:04 -0800 > Bill Medland <billmedland(a)shaw.ca> wrote: > > > Is there any chance that someone with the ability can create the fedora > > core 4 wine rpms for version 0.9.30? > > > > Bill Medland > > If you want to I can upgrade the spec in fedora cvs to the newest versions as > well. It is sad that I cannot push builds for fc 3 and fc 4 anymore I might put > builds on my webpage if the audience is big enough... > > - Andreas > Thanks but that's no help for me; I guess I'll just build for myself. Actually it's for Red Hat Enterprise Linux 4 Server and Desktop for redistribution. I was hoping that I wouldn't have to become totally au fait with the more advanced stuff in the spec files, but I guess I need to bite the bullet. Thanks, anyway Bill

Feb. 28, 2007

Re: [8/12] WineD3D: Create multithreading contexts for swapchains

by Stefan Dösinger

Hi, > I can even run Tom Clancy's Rainbow Six Vegas, but there are still > problems with offscreen rendering. Yeah, offscreen rendering is unsupported with my multithreading patches. I have another patch to fix that, but I haven't tested it. I have a bit of a mess in my wine tree at the moment(2 sets of patches), I will clean that up, send a few non-multithreaded patches to wine-patches and the newest multithreading thing to wine-devel for testing.

Feb. 28, 2007

Re: [7/7] cmd.exe: Support rd dir1 dir2 dir3 etc

by Alexandre Julliard

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes: > diff --git a/programs/cmd/wcmd.h b/programs/cmd/wcmd.h > index d6357f0..a7a73ae 100644 > --- a/programs/cmd/wcmd.h > +++ b/programs/cmd/wcmd.h > @@ -27,6 +27,9 @@ > #include <stdio.h> > #include <ctype.h> > > +#include "wine/debug.h" > +WINE_DEFAULT_DEBUG_CHANNEL(cmd); Adding tracing is OK, but this should go in the C files that need it, not in a header. -- Alexandre Julliard julliard(a)winehq.org

Feb. 28, 2007

Re: [6/6] d3d9: Add a mova rounding test

by Alexandre Julliard

"H. Verbeet" <hverbeet(a)gmail.com> writes: > It should be noted that native d3d rounds to nearest even while Wine > doesn't. Applications are not supposed to depend on that though. > > Changelog: > - Add a mova rounding test The test fails here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:405: Test failed: Expected color 00ffff00, got 00000000 (for input -2.400000) visual.c:405: Test failed: Expected color 00ffff00, got 00000000 (for input -1.600000) visual.c:405: Test failed: Expected color 0000ffff, got 00000000 (for input -0.400000) visual.c:405: Test failed: Expected color 0000ffff, got 00000000 (for input 0.400000) visual.c:405: Test failed: Expected color 00ff00ff, got 00000000 (for input 1.600000) visual.c:405: Test failed: Expected color 00ff00ff, got 00000000 (for input 2.400000) make: *** [visual.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

Feb. 28, 2007

Re: wine and msys rxvt.exe

by Jakob Eriksson

Phil Krylov wrote: > > AFAIR MSys's rxvt.exe uses libW11.dll, which implements Xlib API on > top of Win32 USER/GDI (no extra X server). However, it could be still > difficult (probably because of API name clashes?) > Not sure why the message is about libX11.dll - probably it sees > $DISPLAY and tries to use real X? AFAIR rxvt can be used both with and without X server, so that's probable. regards, Jakob

Feb. 28, 2007

Re: msi: Add proper parameter handling to OLE automation interfaces.

by Robert Shearman

Misha Koshelev wrote: > +/* Macros for variant conversions */ > +#define V_DECLARE \ > + VARIANTARG vararg[pDispParams->cArgs]; \ > + int iVarCount; \ > + HRESULT hr = S_OK; \ > + memset(vararg, 0, sizeof(vararg)); > +#define V_PREPARE(n, type) \ > + VariantInit(&vararg[n]); \ > + hr = VariantChangeTypeEx(&vararg[n], &pDispParams->rgvarg[n], lcid, 0, VT_##type); \ > + if (FAILED(hr)) \ > + { \ > + *puArgErr = n; \ > + goto v_finish; \ > + } > +#define V_PREPAREOPT(n, type) \ > + VariantInit(&vararg[n]); \ > + if (FAILED(VariantChangeTypeEx(&vararg[n], &pDispParams->rgvarg[n], lcid, 0, VT_##type))) \ > + VariantClear(&vararg[n]); > +#define V_PREPARED(n) (V_VT(&vararg[n]) != VT_EMPTY) > +#define V(n, type) V_##type(&vararg[n]) > +#define V_RETURN(value, type) \ > + V_VT(pVarResult) = VT_##type; \ > + V_##type(pVarResult) = value; > +#define V_FAIL hr = E_FAIL; > +#define V_DEFAULT \ > + default: \ > + hr = DISP_E_MEMBERNOTFOUND; > +#define V_FINISH \ > + goto v_finish; /* suppress warnings about unused label v_free */ \ > +v_finish: \ > + for (iVarCount = 0; iVarCount < pDispParams->cArgs; iVarCount++) \ > + if (V_PREPARED(iVarCount)) \ > + VariantClear(&vararg[iVarCount]); \ > + return hr; > This is quite ugly. You can at replace at least some of this with calls to DispGetParam. A lot of the methods only have one parameter so will end up simpler without using these macros. -- Rob Shearman

Feb. 28, 2007

Re: fc4 rpms

by Marcus Meissner

On Wed, Feb 28, 2007 at 09:43:02AM +0100, Andreas Bierfert wrote: > On Tue, 27 Feb 2007 18:17:04 -0800 > Bill Medland <billmedland(a)shaw.ca> wrote: > > > Is there any chance that someone with the ability can create the fedora > > core 4 wine rpms for version 0.9.30? > > > > Bill Medland > > If you want to I can upgrade the spec in fedora cvs to the newest versions as > well. It is sad that I cannot push builds for fc 3 and fc 4 anymore I might put > builds on my webpage if the audience is big enough... Fedora Core 4 RPMs are still available in the openSUSE buildservice. YUM base URL: http://software.opensuse.org/download/Emulators:/Wine/Fedora_Core_4/ Ciao, Marcus

Feb. 28, 2007

Re: fc4 rpms

by Andreas Bierfert

On Tue, 27 Feb 2007 18:17:04 -0800 Bill Medland <billmedland(a)shaw.ca> wrote: > Is there any chance that someone with the ability can create the fedora > core 4 wine rpms for version 0.9.30? > > Bill Medland If you want to I can upgrade the spec in fedora cvs to the newest versions as well. It is sad that I cannot push builds for fc 3 and fc 4 anymore I might put builds on my webpage if the audience is big enough... - Andreas -- Andreas Bierfert | http://awbsworld.de | GPG: C58CF1CB andreas.bierfert(a)lowlatency.de | http://lowlatency.de | signed/encrypted phone: +49 2402 102373 | cell: +49 173 5803043 | mail preferred

Feb. 28, 2007

Re: [8/12] WineD3D: Create multithreading contexts for swapchains

by Mirek

Stefan Dösinger napsal(a): > This patch finishes the opengl side of multithreaded direct3d, which was > started with the state management rewrite(well, almost, no offscreen rendering > yet) It does not make Direct3D thread safe, because there is no protection > against race conditions. > > This patch improves multithreaded games a bit. They do not crash any more in a > gl call, but running them is kinda like a lottery, especially on smp systems. > > Vitaly and Andras have reported success with Prince of Persia 3D: Sands of > Time and some other games, and on my laptop Empire Earth is running. Empire > Earth deadlocks regularly on my dual core system at ddraw creation. I can even run Tom Clancy's Rainbow Six Vegas, but there are still problems with offscreen rendering. Mirek > > > ------------------------------------------------------------------------ > > From 49cc9a0aa6e06f559540758d5b0ed2252208a0ad Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Sun, 25 Feb 2007 00:18:25 +0100 > Subject: [PATCH] WineD3D: Create multithreading contexts for swapchains > > This patch adds a routine to clone the main context of a swapchain to use it with a different thread on the > same drawable. This will enable multithreaded direct3d rendering, or better enable an attempt to do that. > From the opengl point of view it will work, but because concurrency control is not implemented yet(appart > of ENTER_GL() / LEAVE_GL() ) games may crash randomly, show strange behavior, ... > > The other problem is that this code was only tested with the open source radeon driver yet. While what > wined3d is doing here should be allowed by the spec, some drivers may have some bugs when using multiple > contexts on one drawable. > --- > dlls/wined3d/context.c | 4 ++-- > dlls/wined3d/swapchain.c | 30 ++++++++++++++++++++++++++++++ > dlls/wined3d/wined3d_private.h | 2 ++ > 3 files changed, 34 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c > index 3a815b3..8545568 100644 > --- a/dlls/wined3d/context.c > +++ b/dlls/wined3d/context.c > @@ -626,8 +626,8 @@ void ActivateContext(IWineD3DDeviceImpl *This, IWineD3DSurface *target, ContextU > } > > if(!context) { > - /* TODO: Create a new context for the thread */ > - FIXME("Context creation for a new thread not implemented yet\n"); > + /* Create a new context for the thread */ > + context = IWineD3DSwapChainImpl_CreateContextForThread(swapchain); > } > } else { > context = ((IWineD3DSwapChainImpl *) swapchain)->context[0]; > diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c > index 2977a05..3b8e3e8 100644 > --- a/dlls/wined3d/swapchain.c > +++ b/dlls/wined3d/swapchain.c > @@ -510,3 +510,33 @@ const IWineD3DSwapChainVtbl IWineD3DSwapChain_Vtbl = > IWineD3DSwapChainImpl_SetGammaRamp, > IWineD3DSwapChainImpl_GetGammaRamp > }; > + > +WineD3DContext *IWineD3DSwapChainImpl_CreateContextForThread(IWineD3DSwapChain *iface) { > + WineD3DContext *ctx; > + IWineD3DSwapChainImpl *This = (IWineD3DSwapChainImpl *) iface; > + WineD3DContext **newArray; > + > + TRACE("Creating a new context for swapchain %p, thread %d\n", This, GetCurrentThreadId()); > + > + ctx = CreateContext(This->wineD3DDevice, (IWineD3DSurfaceImpl *) This->frontBuffer, > + This->context[0]->display, This->win); > + if(!ctx) { > + ERR("Failed to create a new context for the swapchain\n"); > + return NULL; > + } > + > + newArray = HeapAlloc(GetProcessHeap(), 0, sizeof(*newArray) * This->num_contexts + 1); > + if(!newArray) { > + ERR("Out of memory when trying to allocate a new context array\n"); > + DestroyContext(This->wineD3DDevice, ctx); > + return NULL; > + } > + memcpy(newArray, This->context, sizeof(*newArray) * This->num_contexts); > + HeapFree(GetProcessHeap(), 0, This->context); > + newArray[This->num_contexts] = ctx; > + This->context = newArray; > + This->num_contexts++; > + > + TRACE("Returning context %p\n", ctx); > + return ctx; > +} > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 45e69bf..fa4232c 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -1341,6 +1341,8 @@ typedef struct IWineD3DSwapChainImpl > > extern const IWineD3DSwapChainVtbl IWineD3DSwapChain_Vtbl; > > +WineD3DContext *IWineD3DSwapChainImpl_CreateContextForThread(IWineD3DSwapChain *iface); > + > /***************************************************************************** > * Utility function prototypes > */ > > > ------------------------------------------------------------------------ > >

Feb. 28, 2007

Re: msi: automation: clean up comments.

by James Hawkins

On 2/27/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > Looking back at James comments, maybe I did have a little too much > commenting there :) > You're sending patches that change code that hasn't been committed yet. Instead, you need to go back and change the original patch and resend. -- James Hawkins

Feb. 28, 2007

Re: msi: Expand OLE automation interface parameter handling.

by James Hawkins

On 2/27/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > This applies on top of my other OLE automation patches. Added new > checks: > Why don't you wait until the other patches are committed before sending these new patches? It makes it hard to review, because I don't have your other patches applied. > - Parameter we are looking for is not passed? > - Only set puArgErr if it is passed > - Make sure pVarResult is valid before we write to it > - Don't return S_FAIL. MSDN doesn't mention it in the Invoke help, so we > won't use it. > You need to add tests for these items. -- James Hawkins

Feb. 28, 2007

Success story with Flash on Wine

by Dan Kegel

http://blog.brokenfunction.com/2007/02/27/debugging-flash-on-linux/ says "... How strange, the wine-powered standalone player is the most stable Flash player I've used yet. On Windows it would occasionally be unable to connect to the debugger until I restarted Eclipse, usually related to having to many players open at the same time. On Linux it will crash unexpectedly. Now I can have a dozen debuggers open at the same time with no crashes yet." Cool!

Feb. 28, 2007

msiexec.exe service registration

by Jeremy

In msiexec.c, the DoRegServer calls OpenSCManager, however, on a fresh installation, ie no ~/.wine, the HKLM\CurrentControlSet\Services does not yet exist, so that OpenSCManager fails. What is the correct way to guarantee that this key exists? Regards, Jeremy

Feb. 28, 2007

fc4 rpms

by Bill Medland

Is there any chance that someone with the ability can create the fedora core 4 wine rpms for version 0.9.30? Bill Medland

Feb. 28, 2007

Re: Make sure keyboard state is up to date before processing GetAsyncKeyState.

by Aric Stewart

That could be true. Since it was only used in this one place I was not sure the protocol for adding it to the header file or just as a prototype in this file. I will resubmit the patch -aric Detlef Riekenberg wrote: > On Di, 2007-02-27 at 20:28 +0900, Aric Stewart wrote: >> --- a/dlls/winex11.drv/keyboard.c >> +++ b/dlls/winex11.drv/keyboard.c >> @@ -94,6 +94,9 @@ static int kcControl, kcAlt, kcShift, kc >> >> static char KEYBOARD_MapDeadKeysym(KeySym keysym); >> >> +extern DWORD X11DRV_MsgWaitForMultipleObjectsEx( DWORD count, >> + const HANDLE *handles, DWORD timeout, DWORD mask, >> DWORD flags); > > I have no Idea about the code, but... > > IMHO, that declaration fit perfect into x11drv.h > >

Feb. 28, 2007

RE: xcopy try 3

by Joris Huizer

--- Ann & Jason Edmeades <us(a)edmeades.me.uk> wrote: > > For reference, in case anyone else hits it, the > problem here is I like my > windows editor so generally edit over a samba share. > (I've just found...) Makes me feel like why not use wine to run it...? Oh well, just babbling, you must have a valid reason for that regards, Joris ____________________________________________________________________________________ The fish are biting. Get more visitors on your site using Yahoo! Search Marketing. http://searchmarketing.yahoo.com/arp/sponsoredsearch_v2.php

Feb. 27, 2007

RE: xcopy try 3

by Ann & Jason Edmeades

>> diff --git a/programs/xcopy/Makefile.in b/programs/xcopy/Makefile.in >> new file mode 100755 >All the files you create or modify are marked executable, could you >please fix that? Thanks for the heads up - I should have fixed it now, any problems please let me know. For reference, in case anyone else hits it, the problem here is I like my windows editor so generally edit over a samba share. (I've just found...) Samba by default 'maps' the archive bit on windows to the execute bit on unix, hence any time I modified the file it was turning the execute bit on. To remove it, add 'map archive no' to the share in smb.conf The things you learn! Jason

Feb. 27, 2007

Re: Commit 37591409b28c2000e70bd0d3c654a3a7559a4a26 breaks accentuation

by Pedro Araujo Chaves Jr.

On 2/27/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > Please open a bug report regarding this problem, with all the appropriate > info: an aplication that shows the problem, the fonts used, etc. If you > could add a test to the existing tests in the above mentioned commit that > shows the problem that would be great. Been there, done that: http://bugs.winehq.org/show_bug.cgi?id=7571 In order to clarify things, please see the attachment: http://bugs.winehq.org/attachment.cgi?id=5133&action=view There I provided links for many of the fonts I used (all legal, AFAIK). Cheers, Pedro.

Feb. 27, 2007

Re: mingw linking problem

by Paul Millar

Hi Stefan, On Sunday 25 February 2007 18:13, Stefan Leichter wrote: > This fail for some dlls at the linking, eg. comdlg32.dll misses the imports > > _IID_IContextMenu, _IID_IShellFolder, _IID_IPersistFolder2, > _IID_IShellBrowser, _IID_ICommDlgBrowser, _IID_IShellView, These are part of the MinGW's W32api v3.8. I don't know how long they've been in W32api, so you may need to upgrade to this version. > _SID_STopLevelBrowser The set of patches I have includes a definition for this GUID (as well as many, many others). The complete set of patches (against w32api v3.8) is available from: http://www.astro.gla.ac.uk/users/paulm/Cross/mingw-w32api-patches-2007-02-2… Using a MinGW tool-chain (that has these patches) I was able to build comdlg32.dll N.B. The latest batch of patches (that fixed cross-compiling) are due to Stefan! Thanks! HTH, Paul.

Feb. 27, 2007

Re: wininet: Constify a formal parameter of CommitURLCacheEntry{A|W}() (Resend)

by Andrew Talbot

James Hawkins wrote: > #ifndef USE_FIXED_COMMIT_URL_CACHE_ENTRY > // Temporary state of affairs until we reconcile our apis. > Thanks, James. Maybe one day, then. :) -- Andy.

Feb. 27, 2007

Re: dplay: directplay should initialize session Guid patch + conformance tests

by Detlef Riekenberg

On Di, 2007-02-27 at 13:15 +0100, Alessandro Pignotti wrote: > +dlls/dplayx/tests/Makefile That is will not work since today, as the format changed. The correct entry is created by "tools/make_makefiles" I updated the wiki, that autogenerated code should not be included in a Patch -- By by ... Detlef

Feb. 27, 2007

Re: Make sure keyboard state is up to date before processing GetAsyncKeyState.

by Detlef Riekenberg

On Di, 2007-02-27 at 20:28 +0900, Aric Stewart wrote: > --- a/dlls/winex11.drv/keyboard.c > +++ b/dlls/winex11.drv/keyboard.c > @@ -94,6 +94,9 @@ static int kcControl, kcAlt, kcShift, kc > > static char KEYBOARD_MapDeadKeysym(KeySym keysym); > > +extern DWORD X11DRV_MsgWaitForMultipleObjectsEx( DWORD count, > + const HANDLE *handles, DWORD timeout, DWORD mask, > DWORD flags); I have no Idea about the code, but... IMHO, that declaration fit perfect into x11drv.h -- By by ... Detlef

Feb. 27, 2007

Re: Commit 37591409b28c2000e70bd0d3c654a3a7559a4a26 breaks accentuation

by Dmitry Timoshkov

"Pedro Araujo Chaves Jr." <inckie(a)gmail.com> wrote: > After some regression testing, I found out that commit > 37591409b28c2000e70bd0d3c654a3a7559a4a26 by Dmitry Timoshkov breaks > accentuation - at least for Brazilian Portuguese in Lotus Notes R5. > > I did some testing and found out that only TrueType fonts are affected > - that is, the fonts Notes lists as 'default foo' without the double-T > icon are all accented properly. To make matters worse, the affected > fonts don't behave the same way. > > For example, the string > > áéíóú ÁÉÍÓÚ àèìòù ÀÈÌÒÙ ãõ ÃÕ âêîôû ÂÊÎÔÛ äëïöü ÄËÏÖÜ > > renders as > > įéķóś ĮÉĶÓŚ ąčģņł ĄČĢŅŁ ćõ ĆÕ āźīōū ĀŹĪŌŪ äėļöü ÄĖĻÖÜ > > with Trebuchet MS. You can see they're pretty different - well, most > of you, at least. Please open a bug report regarding this problem, with all the appropriate info: an aplication that shows the problem, the fonts used, etc. If you could add a test to the existing tests in the above mentioned commit that shows the problem that would be great. -- Dmitry.

Feb. 27, 2007

Commit 37591409b28c2000e70bd0d3c654a3a7559a4a26 breaks accentuation

by Pedro Araujo Chaves Jr.

Hi all, After some regression testing, I found out that commit 37591409b28c2000e70bd0d3c654a3a7559a4a26 by Dmitry Timoshkov breaks accentuation - at least for Brazilian Portuguese in Lotus Notes R5. I did some testing and found out that only TrueType fonts are affected - that is, the fonts Notes lists as 'default foo' without the double-T icon are all accented properly. To make matters worse, the affected fonts don't behave the same way. For example, the string áéíóú ÁÉÍÓÚ àèìòù ÀÈÌÒÙ ãõ ÃÕ âêîôû ÂÊÎÔÛ äëïöü ÄËÏÖÜ renders as įéķóś ĮÉĶÓŚ ąčģņł ĄČĢŅŁ ćõ ĆÕ āźīōū ĀŹĪŌŪ äėļöü ÄĖĻÖÜ with Trebuchet MS. You can see they're pretty different - well, most of you, at least. However, that's only a display-and-print issue, as I can copy the text and paste it elsewhere, and the accents are in their right places (and in the right letters, for that matter) - as one would expect. Regarding Microsoft fonts, by the way, Calibri, Candara, Consolas, Constantia, Corbel, Segoe Print, and Segoe Script (couldn't test Cambria) all behave exactly like Trebuchet MS, whereas Segoe UI behaves just like Times New Roman, which shows problems only with graves and tildes. However the behavior is kinda random among the many other fonts (from many unrelated sources, of course) I tested, so I (still) didn't do an exhaustive check for a pattern. Would anybody have any word on this? Cheers, Pedro.

Feb. 27, 2007

Re: [3/12 WineD3D/DDraw: Forward DDSCL_MULTITHREADED to WineD3D

by Stefan Dösinger

> What exactly is this supposed to fix? We already pass the behaviour > flags through to IWineD3DImpl_CreateDevice(), so shouldn't wined3d > just handle it there? In DirectDraw the multithreading flag is set after creating the device, so I need a seperate method to set it in wined3d, because I don't know it at initialization time. This method has to initialize the thread safety things in wined3d. Now d3d8 and d3d9 call SetMultithreaded too because it is clearer to have SetMultithreaded called by ddraw, d3d8 and d3d9 instead of ddraw and wined3d. On the other hand, there are now 2 places where the multithreaded flag is passed to wined3d now, CreateDevice and SetMultithreaded. I could call SetMultithreaded from wined3d::CreateDevice, and not call it from d3d8/9, or I could remove the WINED3DCREATE_MULTITHREADED flag from the public wined3d_interface.h header, sinaling that CreateDevice ignores that flag? Or anything I missed?

Feb. 27, 2007

Re: dplay: directplay should initialize session Guid patch +conformance tests

by H. Verbeet

On 27/02/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > > +BOOL FAR PASCAL EnumConnectionsCallback(LPCGUID lpguidSP, LPVOID lpConnection, > > + DWORD dwConnectionSize, LPCDPNAME lpName, DWORD dwFlags, > > + LPVOID lpContext) > > +{ > > This doesn't look like a proper type of callb ack for IDirectPlayX_EnumConnections. > I wondered about that as well, but it does appear to be what the DXSDK headers specify.

Feb. 27, 2007

Re: dplay: directplay should initialize session Guid patch +conformance tests

by Dmitry Timoshkov

"Alessandro Pignotti" <alex.pigna(a)inventati.org> wrote: > +BOOL FAR PASCAL EnumConnectionsCallback(LPCGUID lpguidSP, LPVOID lpConnection, > + DWORD dwConnectionSize, LPCDPNAME lpName, DWORD dwFlags, > + LPVOID lpContext) > +{ This doesn't look like a proper type of callb ack for IDirectPlayX_EnumConnections. > + bzero(&sessionDesc,sizeof(DPSESSIONDESC2)); > + bzero(&zeroGuid,16); Use memset instead of non-portable bzero. > + LPDIRECTPLAY4 pDP = NULL; This initialization is redundant. If you also could use 4 spaces indents instead of tabs, and add an empty line after data declarations that would be nice as well. And a personal opinion: all that lines without a single space delimiting variables, functions, equal signs are absolutely not readable. -- Dmitry.

Feb. 27, 2007

Re: ntdll: resend 1/4 NtCreateMailslotFile tests

by Alexandre Julliard

Jeff Latimer <lats(a)yless4u.com.au> writes: > diff --git a/dlls/ntdll/tests/Makefile.in b/dlls/ntdll/tests/Makefile.in > index cccc4c5..4ceccfd 100644 > --- a/dlls/ntdll/tests/Makefile.in > +++ b/dlls/ntdll/tests/Makefile.in > @@ -14,6 +14,7 @@ CTESTS = \ > generated.c \ > info.c \ > large_int.c \ > + mailslot.c \ Naming it file.c would be better, since that's the name of the corresponding source file, and that makes it more general so it can later contain other tests too. -- Alexandre Julliard julliard(a)winehq.org

Feb. 27, 2007

Re: [4/6] cmd.exe : Prompt during rd /s command

by Alexandre Julliard

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes: > + /* Load the translated 'Are you sure' message */ > + LoadString (hinst, WCMD_YESORN, buffer, sizeof(buffer)); > + > + /* Loop waiting on a Y or N */ > + while (answer[0] != 'Y' && answer[0] != 'N') { Making the message translatable is good, but the Y/N answers need to be translatable too... -- Alexandre Julliard julliard(a)winehq.org

Feb. 27, 2007

Re: [1/12] - [12/12] WineD3D (multithreading)

by Stefan Dösinger

Am Dienstag 27 Februar 2007 09:54 schrieb Mirek: Looks like we have a rouge multithreaded game here - which is pretty strange since it worked before. > Here is output with only patches 1,2,3,4,5,6,7,10,11,12 (without patch 8 > and 9): > fixme:d3d:ActivateContext Context creation for a new thread not > implemented yet Can you send me a +d3d9,tid trace from that?

Feb. 27, 2007

Re: dplay: directplay should initialize session Guid patch + conformance tests

by Kai Blin

On Saturday 24 February 2007 22:10, Alessandro Pignotti wrote: > Thanks for the suggestions, this version of the patch uses IsEqualGUID and > eliminates C++ style comments and insert a proper copyright notice in the > added file You might want to use #include "wine/test.h" instead of #include <wine/test.h>, all the other tests do that. Also, you should split out the test from the START_TEST(dplayx) function into a function called e.g. test_session_guid and do all the testing there. Also, please use IsEqualGUID() in EnumConnectionsCallback, too. Sorry for not replying earlier, but last week was kind of a mess, and I'm slowly catching up. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

Feb. 27, 2007

Re: GDI surfaces, GDI heap and wined3d's VideoMemorySize

by H. Verbeet

On 27/02/07, Chris Robinson <chris.kcat(a)gmail.com> wrote: > I thought it was added to the registry because Wine can't figure out the video > memory amount itself from OpenGL or X, and that allows the user to make it > report the proper amount (or at least, more proper). Before it was hard-coded > to 64MB. > Pretty much.

Feb. 27, 2007

Re: [1/12] - [12/12] WineD3D (multithreading)

by Mirek

Mirek napsal(a): > Stefan Dösinger napsal(a): >> Am Montag 26 Februar 2007 22:52 schrieb Mirek: >>> Stefan Dösinger napsal(a): >>>> Am Montag 26 Februar 2007 19:58 schrieb Mirek: >>>>> Hi, this series of patches broke some textures in TES IV: Oblivion, >>>>> should I create bug in winebugs? I tried some other apps, they >>>>> looks ok. >>>>> (bug is here after patch 7/12 and 8/12). >>>> Which patch breaks oblivion? Can you describe the kind of breakage? >>>> >>>> *cough* That game seems to be really picky *cough* >>> Patch number 7 and 8 (after patch 7 game crashed, after patch 8 it works >>> normal but with graphical problems). I have Core 2 Duo CPU and SMP >>> enabled, Nvidia GF6800GS with latest stable drivers. >>> >>> Here are some screenshots: >>> http://headline.czela.net/Mirek/wine/TES%20IV:%20Oblivion/regression/ >>> >>> 2007-02-26-224223.jpg is for comparsion. >>> >>> This is realy strange, because after I do some spells (graphical efects) >>> in game it just recover to normal state (everything looks like before). >> Strange yes. Does it print any fixme right before it crashes if you >> only apply patch 7? > Output with all patches 1,2,3,4,5,6,7,8,9,10,11,12 (only interesting part): fixme:d3d:IWineD3DDeviceImpl_ResourceReleased Vertex buffer released while bound to a state block, stream 0 fixme:d3d:IWineD3DDeviceImpl_ResourceReleased Vertex buffer released while bound to a state block, stream 0 fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:ActivateContext Offscreen rendering is only supported from the creation thread yet fixme:d3d:ActivateContext Expect a crash now ... fixme:d3d:IWineD3DDeviceImpl_ResourceReleased Vertex buffer released while bound to a state block, stream 0 fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found And output without patch 7,8 an 9 (same part): fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=24400 < primary_done=24404) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=8016 < primary_done=8020) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=8016 < primary_done=8020) fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=19580 < primary_done=19584) fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:d3d:IWineD3DDeviceImpl_ResourceReleased Vertex buffer released while bound to a state block, stream 0 fixme:d3d:IWineD3DDeviceImpl_ResourceReleased Vertex buffer released while bound to a state block, stream 0 fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:d3d:CreateVBO Failed to create a vertex buffer object. Continuing, but performance issues can occur err:d3d:CreateIndexBufferVBO Creating a vbo failed, continueing without vbo for this buffer fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:d3d:IWineD3DDeviceImpl_ResourceReleased Vertex buffer released while bound to a state block, stream 0 fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found

Feb. 27, 2007

Re: [1/12] - [12/12] WineD3D (multithreading)

by Mirek

Stefan Dösinger napsal(a): > Am Montag 26 Februar 2007 22:52 schrieb Mirek: >> Stefan Dösinger napsal(a): >>> Am Montag 26 Februar 2007 19:58 schrieb Mirek: >>>> Hi, this series of patches broke some textures in TES IV: Oblivion, >>>> should I create bug in winebugs? I tried some other apps, they looks ok. >>>> (bug is here after patch 7/12 and 8/12). >>> Which patch breaks oblivion? Can you describe the kind of breakage? >>> >>> *cough* That game seems to be really picky *cough* >> Patch number 7 and 8 (after patch 7 game crashed, after patch 8 it works >> normal but with graphical problems). I have Core 2 Duo CPU and SMP >> enabled, Nvidia GF6800GS with latest stable drivers. >> >> Here are some screenshots: >> http://headline.czela.net/Mirek/wine/TES%20IV:%20Oblivion/regression/ >> >> 2007-02-26-224223.jpg is for comparsion. >> >> This is realy strange, because after I do some spells (graphical efects) >> in game it just recover to normal state (everything looks like before). > Strange yes. Does it print any fixme right before it crashes if you only apply > patch 7? Here is output with only patches 1,2,3,4,5,6,7,10,11,12 (without patch 8 and 9): fixme:d3d:ActivateContext Context creation for a new thread not implemented yet wine: Unhandled page fault on read access to 0x00001098 at address 0x7c544f6c (thread 0010), starting debugger... Unhandled exception: page fault on read access to 0x00001098 in 32-bit code (0x7c544f6c). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:7c544f6c ESP:7bdedd70 EBP:7bdeddd8 EFLAGS:00210246( - 00 -RIZP1) EAX:001b9268 EBX:7c5db078 ECX:00000000 EDX:00000000 ESI:00000000 EDI:0016be08 Stack dump: 0x7bdedd70: 0018ab38 7c5db9c4 7c5bc8dc 7c5bc694 0x7bdedd80: 16e9fa10 7efe5368 7bdedde8 7efa2396 0x7bdedd90: 00110020 175e21e0 7bdeddb8 7efa16f3 0x7bdedda0: 7efe5368 000e0000 00000000 00000000 0x7bdeddb0: 00000000 7efe5368 7bdede18 7e32d53c 0x7bdeddc0: 175069b8 001b9268 0018ab38 7c5db078 Backtrace: =>1 0x7c544f6c ActivateContext+0x2ac(This=0x1b9268, target=0x205618, usage=0x1) [/usr/src/wine/dlls/wined3d/context.c:761] in wined3d (0x7bdeddd8) 2 0x7c54f23d CreateVBO+0x6d(object=<register ESI not in topmost frame>) [/usr/src/wine/dlls/wined3d/device.c:330] in wined3d (0x7bdede18) 3 0x7c553e27 IWineD3DDeviceImpl_CreateVertexBuffer+0x1f7(iface=<register EDI not in topmost frame>, Size=0x120, Usage=0x8, FVF=0x0, Pool=0x1, ppVertexBuffer=0x16e9fa08, sharedHandle=0x0, parent=0x16e9fa00) [/usr/src/wine/dlls/wined3d/device.c:447] in wined3d (0x7bdede68) 4 0x7c781815 IDirect3DDevice9Impl_CreateVertexBuffer+0x95(iface=0x186870, Size=0x120, Usage=<register EDI not in topmost frame>, FVF=0x0, Pool=0x1, ppVertexBuffer=0x7bdedee0, pSharedHandle=0x0) [/root/.WineCVS/sources/cvswine/wine/dlls/d3d9/vertexbuffer.c:177] in d3d9 (0x7bdedea8) 5 0x006e2d7d in oblivion (+0x2e2d7d) (0x7bdedee0) 6 0x00000000 (0x26034550) 7 0x130003e4 (0x01c00000) 8 0x2a08eed8 (0x2a08ee10) 9 0xbffadd7c (0xbfd1fd64) 10 0x00000000 (0x00000000) 0x7c544f6c ActivateContext+0x2ac [/usr/src/wine/dlls/wined3d/context.c:761] in wined3d: movl 0x1098(%edx),%eax 761 ret = glXMakeCurrent(context->display, context->drawable, context->glCtx); Modules: Module Address Debug info Name (104 modules) PE 400000-b59000 Export oblivion PE b60000-daf000 Deferred d3dx9_27 PE 18000000-18068000 Deferred binkw32 ELF 7b1f1000-7b28a000 Deferred oleaut32<elf> \-PE 7b200000-7b28a000 \ oleaut32 ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7bf80000-7bfa7000 Deferred msvfw32<elf> \-PE 7bf90000-7bfa7000 \ msvfw32 ELF 7bfa7000-7c000000 Deferred quartz<elf> \-PE 7bfb0000-7c000000 \ quartz ELF 7c491000-7c521000 Deferred libglu.so.1 ELF 7c521000-7c5dc000 Dwarf wined3d<elf> \-PE 7c530000-7c5dc000 \ wined3d ELF 7c718000-7c737000 Deferred devenum<elf> \-PE 7c720000-7c737000 \ devenum ELF 7c737000-7c742000 Deferred libgcc_s.so.1 ELF 7c747000-7c75b000 Deferred avicap32<elf> \-PE 7c750000-7c75b000 \ avicap32 ELF 7c762000-7c78d000 Dwarf d3d9<elf> \-PE 7c770000-7c78d000 \ d3d9 ELF 7c9a8000-7ca69000 Deferred libasound.so.2 ELF 7ca69000-7ca94000 Deferred winealsa<elf> \-PE 7ca70000-7ca94000 \ winealsa ELF 7ca94000-7cac6000 Deferred uxtheme<elf> \-PE 7caa0000-7cac6000 \ uxtheme ELF 7cd55000-7cd6a000 Deferred midimap<elf> \-PE 7cd60000-7cd6a000 \ midimap ELF 7cd6a000-7cd6f000 Deferred libxfixes.so.3 ELF 7cd75000-7cd8d000 Deferred msacm32<elf> \-PE 7cd80000-7cd8d000 \ msacm32 ELF 7cd8f000-7cd92000 Deferred libxinerama.so.1 ELF 7cd95000-7cdb2000 Deferred imm32<elf> \-PE 7cda0000-7cdb2000 \ imm32 ELF 7d75c000-7e0cd000 Deferred libglcore.so.1 ELF 7e0cd000-7e161000 Deferred libgl.so.1 ELF 7e161000-7e166000 Deferred libxdmcp.so.6 ELF 7e166000-7e169000 Deferred libxau.so.6 ELF 7e169000-7e255000 Deferred libx11.so.6 ELF 7e255000-7e263000 Deferred libxext.so.6 ELF 7e263000-7e268000 Deferred libxxf86vm.so.1 ELF 7e268000-7e280000 Deferred libice.so.6 ELF 7e280000-7e289000 Deferred libsm.so.6 ELF 7e289000-7e292000 Deferred libxcursor.so.1 ELF 7e292000-7e295000 Deferred libxrandr.so.2 ELF 7e295000-7e29d000 Deferred libxrender.so.1 ELF 7e2a9000-7e336000 Deferred winex11<elf> \-PE 7e2c0000-7e336000 \ winex11 ELF 7e3ac000-7e3cc000 Deferred libexpat.so.1 ELF 7e3cc000-7e3f7000 Deferred libfontconfig.so.1 ELF 7e3f7000-7e40b000 Deferred libz.so.1 ELF 7e40b000-7e475000 Deferred libfreetype.so.6 ELF 7e495000-7e4c1000 Deferred ws2_32<elf> \-PE 7e4a0000-7e4c1000 \ ws2_32 ELF 7e4c1000-7e4db000 Deferred wsock32<elf> \-PE 7e4d0000-7e4db000 \ wsock32 ELF 7e4db000-7e53f000 Deferred msvcrt<elf> \-PE 7e4f0000-7e53f000 \ msvcrt ELF 7e53f000-7e553000 Deferred lz32<elf> \-PE 7e550000-7e553000 \ lz32 ELF 7e553000-7e5ab000 Deferred shlwapi<elf> \-PE 7e560000-7e5ab000 \ shlwapi ELF 7e5ab000-7e6a0000 Deferred shell32<elf> \-PE 7e5c0000-7e6a0000 \ shell32 ELF 7e6a0000-7e6e9000 Deferred dsound<elf> \-PE 7e6b0000-7e6e9000 \ dsound ELF 7e6e9000-7e777000 Deferred winmm<elf> \-PE 7e6f0000-7e777000 \ winmm ELF 7e777000-7e78a000 Deferred libresolv.so.2 ELF 7e78a000-7e78c000 Deferred libnvidia-tls.so.1 ELF 7e791000-7e7aa000 Deferred version<elf> \-PE 7e7a0000-7e7aa000 \ version ELF 7e7aa000-7e7c8000 Deferred iphlpapi<elf> \-PE 7e7b0000-7e7c8000 \ iphlpapi ELF 7e7c8000-7e81d000 Deferred rpcrt4<elf> \-PE 7e7d0000-7e81d000 \ rpcrt4 ELF 7e81d000-7e8b6000 Deferred ole32<elf> \-PE 7e830000-7e8b6000 \ ole32 ELF 7e8b6000-7e8ec000 Deferred dinput<elf> \-PE 7e8c0000-7e8ec000 \ dinput ELF 7e8ec000-7e905000 Deferred dinput8<elf> \-PE 7e8f0000-7e905000 \ dinput8 ELF 7e905000-7e94b000 Deferred advapi32<elf> \-PE 7e910000-7e94b000 \ advapi32 ELF 7e94b000-7e9de000 Deferred gdi32<elf> \-PE 7e960000-7e9de000 \ gdi32 ELF 7e9de000-7eb18000 Deferred user32<elf> \-PE 7ea00000-7eb18000 \ user32 ELF 7eb18000-7ebd5000 Deferred comctl32<elf> \-PE 7eb20000-7ebd5000 \ comctl32 ELF 7edd5000-7eefb000 Deferred kernel32<elf> \-PE 7edf0000-7eefb000 \ kernel32 ELF 7eefb000-7ef06000 Deferred libnss_files.so.2 ELF 7ef06000-7ef10000 Deferred libnss_nis.so.2 ELF 7ef10000-7ef26000 Deferred libnsl.so.1 ELF 7ef26000-7ef4b000 Deferred libm.so.6 ELF 7ef4b000-7ef4f000 Deferred iso8859-2.so ELF 7ef6b000-7f000000 Deferred ntdll<elf> \-PE 7ef80000-7f000000 \ ntdll ELF b7d2a000-b7d2e000 Deferred libdl.so.2 ELF b7d2e000-b7e60000 Deferred libc.so.6 ELF b7e60000-b7e72000 Deferred libpthread.so.0 ELF b7e77000-b7e80000 Deferred libnss_compat.so.2 ELF b7e93000-b7fa4000 Deferred libwine.so.1 ELF b7fa6000-b7fbd000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000a 0000000c 0 0000000b 0 00000008 (D) G:\usr\games\oblivion\Oblivion.exe 00000013 0 00000010 -1 <== 0000000f -1 0000000e 15 0000000d 0 00000009 0

Feb. 27, 2007

Re: [PATCH] seperate AC_CONFIG_FILES.

by Marcus Meissner

On Tue, Feb 27, 2007 at 01:03:09AM +0100, Detlef Riekenberg wrote: > On Mo, 2007-02-26 at 22:06 +0100, Marcus Meissner wrote: > > > -AC_CONFIG_FILES([ > > -Make.rules > > -dlls/Makedll.rules > > -dlls/Makeimplib.rules > > -dlls/Maketest.rules > > -programs/Makeprog.rules > > -Makefile > > -dlls/Makefile > > Does "tools/make_makefiles" still work after your Patch? > - for a new dll > - for a new test > - for a new program > > I'm unable to test that here (my autoconf is to old) Seems I need to actually change tools/make_makefiles instead of configure.ac :( Ciao, Marcus

Feb. 27, 2007

Re: configure: Break single-line ac_config_files list into multiple lines.

by Jan Zerebecki

On Sat, Feb 24, 2007 at 02:15:29PM +0200, Saulius Krasuckas wrote: > This long line breaks automated rebasing of one of testing branches on > (namely ntoskrnl) on my box every time a new dll or program is added. > That's because I need to merge conflict for this line by my hand. You might find http://wiki.winehq.org/There_are_always_conflicts_in_configure interesting. Jan

Feb. 27, 2007

Re: GDI surfaces, GDI heap and wined3d's VideoMemorySize

by Chris Robinson

On Sunday 25 February 2007 03:36:02 pm Vitaliy Margolen wrote: > The memory size setting is only in registry because you should not touch > it in the first place. I thought it was added to the registry because Wine can't figure out the video memory amount itself from OpenGL or X, and that allows the user to make it report the proper amount (or at least, more proper). Before it was hard-coded to 64MB.

Feb. 27, 2007

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Felix Nawothnig

Erich Hoover wrote: > Is the attached more like what you're looking for? I did some investigation and... actually I'm looking for an equivalent to the linux splice syscall. Win32 is the most braindead API ever. Duh. The "right" way would probably to do the copying yourself by read/write.. but I dunno. Your code looks solid at the first glance. Three things: - I'd remove the FILE_SHARE_DELETE and FILE_SHARE_WRITE. - Use MoveFile instead of CopyFile/DeleteFile at the end? - Are you sure you're supposed to set ERROR_INVALID_PARAMETER no matter what bad happens? If the function which failed already set LE you should probably keep it... Felix

Feb. 27, 2007

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Erich Hoover

Is the attached more like what you're looking for? Erich Hoover ehoover(a)mines.edu On 2/26/07, Felix Nawothnig <flexo(a)holycrap.org> wrote: > > Erich Hoover wrote: > > I assume you're referring to the file existence check and file delete, > > followed by the actual copy and move. I implemented these checks in > > this manner in order to provide error codes consistent with the > > documentation. I am not incredibly familiar with the Wine internals, > > but it looks to me like the functions called should handle a > > simultaneous call from another thread (without unnecessary code > > duplication). For example, if the "replaced" file goes missing between > > the check and the CopyFileW call then CopyFileW will return an error. > > If the "replaced" file appears between the DeleteFileW call and the > > MoveFileExW call (since the MOVEFILE_REPLACE_EXISTING flag is not set), > > then the MoveFileExW call will fail. The documentation's expected error > > codes for ReplaceFile seem to be consistent with these potential > > outcomes. > > Reading MSDN that doesn't seem to be the case. The way I see it all > those errors documented could be caused by file permisions. MSDN doesn't > say anything about race cons. > > Some notes about the patch: > > + /* Maker sure the "replacement" file exists before continuing */ > + if(!RtlDoesFileExists_U( lpReplacementFileName )) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > > This would probably the right place to lock the file... > > + /* > + * If the user wants a backup then that needs to be performed first > + * * Do not fail to backup if "replaced" does not exist > + */ > + if( lpBackupFileName && RtlDoesFileExists_U( lpReplacedFileName ) ) > > The call to RtlDoesFileExists_U() is redundant and introduces a race > con. CopyFileW() will check for existence, check GLE afterwards. > > + { > + /* If an existing backup exists then copy over it */ > + */ > + if(!CopyFileW( lpReplacedFileName, lpBackupFileName, FALSE )) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > + } > + /* > + * Now that the backup has been performed (if requested), copy the > replacement > + * into place (make sure we can delete the original file first) > + * * Do not fail if "replaced" does not exist > + */ > + if(RtlDoesFileExists_U( lpReplacedFileName ) && !DeleteFileW( > lpReplacedFileName )) > > Same here, DeleteFile() will check for existence. > > + { > + SetLastError(ERROR_UNABLE_TO_REMOVE_REPLACED); > + return FALSE; > + } > + if(!MoveFileExW( lpReplacementFileName, lpReplacedFileName, flags )) > > Couldn't you just get rid of the DeleteFile, check why MoveFileEx() > failed and get rid of the call to RtlDoesFileExists_U(lpReplacedFileName)? > > + { > + SetLastError(ERROR_UNABLE_TO_MOVE_REPLACEMENT); > + return FALSE; > + } > + /* All done, file replacement successful */ > + return TRUE; >

Feb. 27, 2007

Re: [7/12] WineD3D: Select an onscreen context based on the thread

by Stefan Dösinger

Am Montag 26 Februar 2007 13:49 schrieb Stefan Dösinger: Alexandre, do not patch 7, 8 and 9 yet, they are reported to cause regressions. Patch 10, 11 and 12 should apply without them too.

Feb. 27, 2007

Re: [PATCH] seperate AC_CONFIG_FILES.

by Detlef Riekenberg

On Mo, 2007-02-26 at 22:06 +0100, Marcus Meissner wrote: > -AC_CONFIG_FILES([ > -Make.rules > -dlls/Makedll.rules > -dlls/Makeimplib.rules > -dlls/Maketest.rules > -programs/Makeprog.rules > -Makefile > -dlls/Makefile Does "tools/make_makefiles" still work after your Patch? - for a new dll - for a new test - for a new program I'm unable to test that here (my autoconf is to old) -- By by ... Detlef

Feb. 27, 2007

Re: [1/12] - [12/12] WineD3D (multithreading)

by Stefan Dösinger

Am Montag 26 Februar 2007 22:52 schrieb Mirek: > Stefan Dösinger napsal(a): > > Am Montag 26 Februar 2007 19:58 schrieb Mirek: > >> Hi, this series of patches broke some textures in TES IV: Oblivion, > >> should I create bug in winebugs? I tried some other apps, they looks ok. > >> (bug is here after patch 7/12 and 8/12). > > > > Which patch breaks oblivion? Can you describe the kind of breakage? > > > > *cough* That game seems to be really picky *cough* > > Patch number 7 and 8 (after patch 7 game crashed, after patch 8 it works > normal but with graphical problems). I have Core 2 Duo CPU and SMP > enabled, Nvidia GF6800GS with latest stable drivers. > > Here are some screenshots: > http://headline.czela.net/Mirek/wine/TES%20IV:%20Oblivion/regression/ > > 2007-02-26-224223.jpg is for comparsion. > > This is realy strange, because after I do some spells (graphical efects) > in game it just recover to normal state (everything looks like before). Strange yes. Does it print any fixme right before it crashes if you only apply patch 7?

Feb. 26, 2007

Re: wininet: Constify a formal parameter of CommitURLCacheEntry{A|W}() (Resend)

by James Hawkins

On 2/26/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > James Hawkins wrote: > > > On 2/26/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > >> What is wrong with this patch, please? > >> > > > > This isn't how it's defined in the SDK headers. > > > > Am I right in thinking that for non-embedded-CE versions of Windows the > lpHeaderInfo variable of CommitURLCacheEntry() is now a LPCTSTR? In which > case, I presume that the comment about the ascii version requiring a LPBYTE > is now wrong: the "A" version should now have a LPCSTR and the "W" version, > a LPCWSTR. > #ifndef USE_FIXED_COMMIT_URL_CACHE_ENTRY // Temporary state of affairs until we reconcile our apis. // Why are we doing this? HeaderInfo _should_ be string data. // However, one group is passing binary data instead. For the // unicode api, we've decided to disallow this, but this // brings up an inconsistency between the u and a apis, which // is undesirable. // For Beta 1, we'll go with this behaviour, but in future releases // we want to make these apis consistent. BOOLAPI CommitUrlCacheEntryA( __in LPCSTR lpszUrlName, __in_opt LPCSTR lpszLocalFileName, __in FILETIME ExpireTime, __in FILETIME LastModifiedTime, __in DWORD CacheEntryType, __in_ecount_opt(dwHeaderSize) LPBYTE lpHeaderInfo, __in_opt DWORD dwHeaderSize, __reserved LPCSTR lpszFileExtension, __in_opt LPCSTR lpszOriginalUrl ); BOOLAPI CommitUrlCacheEntryW( __in LPCWSTR lpszUrlName, __in_opt LPCWSTR lpszLocalFileName, __in FILETIME ExpireTime, __in FILETIME LastModifiedTime, __in DWORD CacheEntryType, __in_ecount_opt(dwHeaders) LPWSTR lpszHeaderInfo, __in DWORD dwHeaders, __reserved LPCWSTR lpszFileExtension, __in_opt LPCWSTR lpszOriginalUrl ); #ifdef UNICODE #define CommitUrlCacheEntry CommitUrlCacheEntryW #else #define CommitUrlCacheEntry CommitUrlCacheEntryA #endif #else CommitUrlCacheEntryA( __in LPCSTR lpszUrlName, __in_opt LPCSTR lpszLocalFileName, __in FILETIME ExpireTime, __in FILETIME LastModifiedTime, __in DWORD CacheEntryType, __in_ecount_opt(dwHeaderSize) LPCSTR lpHeaderInfo, __in DWORD dwHeaderSize, __reserved LPCSTR lpszFileExtension, __in_opt LPCSTR lpszOriginalUrl ); CommitUrlCacheEntryW( __in LPCWSTR lpszUrlName, __in_opt LPCWSTR lpszLocalFileName, __in FILETIME ExpireTime, __in FILETIME LastModifiedTime, __in DWORD CacheEntryType, __in_ecount_opt(dwHeaderSize) LPCWSTR lpHeaderInfo, __in DWORD dwHeaderSize, __reserved LPCWSTR lpszFileExtension, __in_opt LPCWSTR lpszOriginalUrl ); #ifdef UNICODE #define CommitUrlCacheEntry CommitUrlCacheEntryW #else #define CommitUrlCacheEntry CommitUrlCacheEntryA #endif // !UNICODE #endif -- James Hawkins

Feb. 26, 2007

Re: wininet: Constify a formal parameter of CommitURLCacheEntry{A|W}() (Resend)

by Andrew Talbot

Andrew Talbot wrote: > ... but the corresponding parameter of > CommitURLCacheEntry() [...] ought to be a LPTSTR.... Or rather, a LPCTSTR. So, is there any scope to constify, here? -- A.

Feb. 26, 2007

Re: wininet: Constify a formal parameter of CommitURLCacheEntry{A|W}() (Resend)

by Andrew Talbot

The problem seems to be that the INTERNET_CACHE_ENTRY_INFO structure has a member lpHeaderInfo that is a LPBYTE, but the corresponding parameter of CommitURLCacheEntry() - sorry, I truncated its name in the original posting - ought to be a LPTSTR. It is not yet clear to me what is required. -- Andy.

Feb. 26, 2007

Re: wininet: Constify a formal parameter of CommitURLCacheEntry{A|W}() (Resend)

by Andrew Talbot

James Hawkins wrote: > On 2/26/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: >> What is wrong with this patch, please? >> > > This isn't how it's defined in the SDK headers. > Am I right in thinking that for non-embedded-CE versions of Windows the lpHeaderInfo variable of CommitURLCacheEntry() is now a LPCTSTR? In which case, I presume that the comment about the ascii version requiring a LPBYTE is now wrong: the "A" version should now have a LPCSTR and the "W" version, a LPCWSTR. -- Andy.

Feb. 26, 2007

Re: Add localizable strings support for popup menu in selection tree control.

by James Hawkins

On 2/26/07, Крылов Николай <krna(a)rambler.ru> wrote: > diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c > index 35a192c..3826326 100644 > --- a/dlls/msi/dialog.c > +++ b/dlls/msi/dialog.c > @@ -1755,17 +1755,41 @@ msi_seltree_popup_menu( HWND hwnd, INT x > HMENU hMenu; > INT r; > > + static const WCHAR szMenuLocal[] = > {'M','e','n','u','L','o','c','a','l',0}; > + static const WCHAR szMenuAllLocal[] = > {'M','e','n','u','A','l','l','L','o','c','a','l',0}; > + static const WCHAR szMenuAdvertise[] = > {'M','e','n','u','A','d','v','e','r','t','i','s','e',0}; > + static const WCHAR szMenuAbsent[] = > {'M','e','n','u','A','b','s','e','n','t',0}; > + /* If msi_dialog_get_uitext returns NULL - use default strings: */ > + static const WCHAR szMenuLocalDef[] = > {'I','n','s','t','a','l','l',' ','f','e','a','t','u','r','e',' ', > 'l','o','c','a','l','l','y',0}; > + static const WCHAR szMenuAllLocalDef[] = > {'I','n','s','t','a','l','l',' ','e','n','t','i','r','e',' > ','f','e','a','t','u','r','e',0}; > + static const WCHAR szMenuAdvertiseDef[] = > {'I','n','s','t','a','l','l',' ','o','n',' ','d','e','m','a','n','d',0}; > + static const WCHAR szMenuAbsentDef[] = {'D','o','n','\'','t',' > ','i','n','s','t','a','l','l',0}; > + > + LPWSTR szLocal,szAllLocal,szAdvertise,szAbsent; > + struct msi_selection_tree_info *info; > + > + info = GetPropW(hwnd, szButtonData); > + > + szLocal= msi_dialog_get_uitext( info->dialog, szMenuLocal ); > + szAllLocal= msi_dialog_get_uitext( info->dialog, szMenuAllLocal ); > + szAdvertise= msi_dialog_get_uitext( info->dialog, szMenuAdvertise > ); > + szAbsent= msi_dialog_get_uitext( info->dialog, szMenuAbsent ); > + > /* create a menu to display */ > hMenu = CreatePopupMenu(); > > - /* FIXME: load strings from resources */ > - AppendMenuA( hMenu, MF_ENABLED, INSTALLSTATE_LOCAL, "Install > feature locally"); > - AppendMenuA( hMenu, MF_GRAYED, 0x1000, "Install entire feature"); > - AppendMenuA( hMenu, MF_ENABLED, INSTALLSTATE_ADVERTISED, "Install > on demand"); > - AppendMenuA( hMenu, MF_ENABLED, INSTALLSTATE_ABSENT, "Don't > install"); > + /* Use strings from resources */ > + AppendMenuW( hMenu, MF_ENABLED, INSTALLSTATE_LOCAL, > (szLocal==NULL)?szMenuLocalDef:szLocal ); > + AppendMenuW( hMenu, MF_GRAYED, 0x1000, > (szAllLocal==NULL)?szMenuAllLocalDef:szAllLocal ); > + AppendMenuW( hMenu, MF_ENABLED, INSTALLSTATE_ADVERTISED, > (szAdvertise==NULL)?szMenuAdvertiseDef:szAdvertise ); > + AppendMenuW( hMenu, MF_ENABLED, INSTALLSTATE_ABSENT, > (szAbsent==NULL)?szMenuAbsentDef:szAbsent ); > r = TrackPopupMenu( hMenu, TPM_LEFTALIGN | TPM_TOPALIGN | > TPM_RETURNCMD, > x, y, 0, hwnd, NULL ); > DestroyMenu( hMenu ); > + if(szLocal) msi_free(szLocal); > + if(szAllLocal) msi_free(szAllLocal); > + if(szAdvertise) msi_free(szAdvertise); > + if(szAbsent) msi_free(szAbsent); > return r; > } > Don't check values for NULL before freeing them. The check is redundant, and we spent a long time removing such checks. -- James Hawkins

Feb. 26, 2007

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Felix Nawothnig

Erich Hoover wrote: > I assume you're referring to the file existence check and file delete, > followed by the actual copy and move. I implemented these checks in > this manner in order to provide error codes consistent with the > documentation. I am not incredibly familiar with the Wine internals, > but it looks to me like the functions called should handle a > simultaneous call from another thread (without unnecessary code > duplication). For example, if the "replaced" file goes missing between > the check and the CopyFileW call then CopyFileW will return an error. > If the "replaced" file appears between the DeleteFileW call and the > MoveFileExW call (since the MOVEFILE_REPLACE_EXISTING flag is not set), > then the MoveFileExW call will fail. The documentation's expected error > codes for ReplaceFile seem to be consistent with these potential > outcomes. Reading MSDN that doesn't seem to be the case. The way I see it all those errors documented could be caused by file permisions. MSDN doesn't say anything about race cons. Some notes about the patch: + /* Maker sure the "replacement" file exists before continuing */ + if(!RtlDoesFileExists_U( lpReplacementFileName )) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } This would probably the right place to lock the file... + /* + * If the user wants a backup then that needs to be performed first + * * Do not fail to backup if "replaced" does not exist + */ + if( lpBackupFileName && RtlDoesFileExists_U( lpReplacedFileName ) ) The call to RtlDoesFileExists_U() is redundant and introduces a race con. CopyFileW() will check for existence, check GLE afterwards. + { + /* If an existing backup exists then copy over it */ + */ + if(!CopyFileW( lpReplacedFileName, lpBackupFileName, FALSE )) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + } + /* + * Now that the backup has been performed (if requested), copy the replacement + * into place (make sure we can delete the original file first) + * * Do not fail if "replaced" does not exist + */ + if(RtlDoesFileExists_U( lpReplacedFileName ) && !DeleteFileW( lpReplacedFileName )) Same here, DeleteFile() will check for existence. + { + SetLastError(ERROR_UNABLE_TO_REMOVE_REPLACED); + return FALSE; + } + if(!MoveFileExW( lpReplacementFileName, lpReplacedFileName, flags )) Couldn't you just get rid of the DeleteFile, check why MoveFileEx() failed and get rid of the call to RtlDoesFileExists_U(lpReplacedFileName)? + { + SetLastError(ERROR_UNABLE_TO_MOVE_REPLACEMENT); + return FALSE; + } + /* All done, file replacement successful */ + return TRUE;

Feb. 26, 2007

Re: [1/12] - [12/12] WineD3D (multithreading)

by Mirek

Stefan Dösinger napsal(a): > Am Montag 26 Februar 2007 19:58 schrieb Mirek: >> Hi, this series of patches broke some textures in TES IV: Oblivion, >> should I create bug in winebugs? I tried some other apps, they looks ok. >> (bug is here after patch 7/12 and 8/12). > Which patch breaks oblivion? Can you describe the kind of breakage? > > *cough* That game seems to be really picky *cough* Patch number 7 and 8 (after patch 7 game crashed, after patch 8 it works normal but with graphical problems). I have Core 2 Duo CPU and SMP enabled, Nvidia GF6800GS with latest stable drivers. Here are some screenshots: http://headline.czela.net/Mirek/wine/TES%20IV:%20Oblivion/regression/ 2007-02-26-224223.jpg is for comparsion. This is realy strange, because after I do some spells (graphical efects) in game it just recover to normal state (everything looks like before).

Feb. 26, 2007

Re: wininet: Constify a formal parameter of CommitURLCache{A|W}() (Resend)

by James Hawkins

On 2/26/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > What is wrong with this patch, please? > This isn't how it's defined in the SDK headers. -- James Hawkins

Feb. 26, 2007

Re: [1/12] - [12/12] WineD3D (multithreading)

by Stefan Dösinger

Am Montag 26 Februar 2007 19:58 schrieb Mirek: > Hi, this series of patches broke some textures in TES IV: Oblivion, > should I create bug in winebugs? I tried some other apps, they looks ok. > (bug is here after patch 7/12 and 8/12). Which patch breaks oblivion? Can you describe the kind of breakage? *cough* That game seems to be really picky *cough*

Feb. 26, 2007

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Erich Hoover

I assume you're referring to the file existence check and file delete, followed by the actual copy and move. I implemented these checks in this manner in order to provide error codes consistent with the documentation. I am not incredibly familiar with the Wine internals, but it looks to me like the functions called should handle a simultaneous call from another thread (without unnecessary code duplication). For example, if the "replaced" file goes missing between the check and the CopyFileW call then CopyFileW will return an error. If the "replaced" file appears between the DeleteFileW call and the MoveFileExW call (since the MOVEFILE_REPLACE_EXISTING flag is not set), then the MoveFileExW call will fail. The documentation's expected error codes for ReplaceFile seem to be consistent with these potential outcomes. I apologize if there's something I'm missing here, please let me know. Erich Hoover ehoover(a)mines.edu On 2/26/07, Felix Nawothnig <flexo(a)holycrap.org> wrote: > > Erich Hoover wrote: > > Real Name: > > Erich Hoover > > Description: > > Implements the functions ReplaceFileA and ReplaceFileW in kernel32 > > (Bug #7544). Also provides conformance test code to ensure proper > > functionality. > > Changelog: > > kernel32: Implement ReplaceFileA/ReplaceFileW > > Your patch seems to introduce lots of race cons. It's possible these > exist on Win32 too but can't we avoid them? >

Feb. 26, 2007

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Felix Nawothnig

Erich Hoover wrote: > Real Name: > Erich Hoover > Description: > Implements the functions ReplaceFileA and ReplaceFileW in kernel32 > (Bug #7544). Also provides conformance test code to ensure proper > functionality. > Changelog: > kernel32: Implement ReplaceFileA/ReplaceFileW Your patch seems to introduce lots of race cons. It's possible these exist on Win32 too but can't we avoid them?

Feb. 26, 2007

Re: [1/12] - [12/12] WineD3D (multithreading)

by Mirek

Hi, this series of patches broke some textures in TES IV: Oblivion, should I create bug in winebugs? I tried some other apps, they looks ok. (bug is here after patch 7/12 and 8/12). Mirek

Feb. 26, 2007

Re: GDI surfaces, GDI heap and wined3d's VideoMemorySize

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > CreateCompatibleDC should be made to fail if the CreateRectRgn call fails. Yes, I committed a fix for that. -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2007

Re: xcopy try 3

by Alexandre Julliard

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes: > diff --git a/programs/xcopy/Makefile.in b/programs/xcopy/Makefile.in > new file mode 100755 All the files you create or modify are marked executable, could you please fix that? -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2007

Re: GDI surfaces, GDI heap and wined3d's VideoMemorySize

by Robert Shearman

Rok Mandeljc wrote: > Hey all, > > I've been experiencing an odd behavior in Baldur's Gate 2; when > "VideoMemorySize" registry key for wined3d is set to anything greater > than 64MB (69MB, actually), it stops before playing intro movie, > printing following line: > err:clipping:CLIPPING_UpdateGCRegion hVisRgn is zero. Please report this. > > Tracing the source of issue by inserting custom traces I got the following: > IDirectDrawImpl_CreateNewSurface -> IWineD3DDeviceImpl_CreateSurface > (decides to use GDI surface) -> IWineGDISurfaceImpl_PrivateSetup -> > IWineD3DSurfaceImpl_GetDC -> > CreateCompatibleDC -> CreateRectRgn -> REGION_CreateRegion -> > GDI_AllocObject -> alloc_large_heap > > alloc_large_heap fails because it can't find next large handle and > returns NULL, which is passed up the chain, where CreateCompatibleDC > puts it in dc->hVisRgn. Then DC_InitDC is called with that dc, which > calls CLIPPING_UpdateGCRegion, and that one finally chokes on it, > printing afore-mentioned line and calling exit(1). > > Now, when the game is run with 64MB of VideoMemorySize, upon reaching > the same point, IDirectDrawImpl_CreateNewSurface returns > WINED3DERR_OUTOFVIDEOMEMORY (because of > "IWineD3DDevice_GetAvailableTextureMem(iface) <= _size" check in > D3DCREATERESOURCEOBJECTINSTANCE macro) and intro movie starts playing. > So it seems Baldur's Gate 2 is trying to create as many surfaces as > possible before running out of memory. And the problem arises when > specified memory size is large enough to take up all GDI's heap... > > Sorry for the long-winded description of the problem, but I'm not sure > where and how this should be fixed (is it wined3d issue or should GDI > have its heap enlarged?), otherwise I'd do it myself... > CreateCompatibleDC should be made to fail if the CreateRectRgn call fails. -- Rob Shearman

Feb. 26, 2007

Re: Wine and XP Themes

by Felix Nawothnig

Frank Richter wrote: > WRT speed: themes usually use alpha-blending extensively; however, the > speed of Wine's AlphaBlend() can almost be measured in geological terms; Why is that? Looking at it it seems to be using XRender - since theming doesn't require Aero and stuff what way would there be to speed it up? (I admit I didn't really read the code. :) Felix

Feb. 26, 2007

Re: [9/12] WineD3D: When multithreading, call glFinish after drawing

by H. Verbeet

Would GL_NV_fence be usefull here?

Feb. 26, 2007

Re: Using InternalGetWindowText Instead of Sending WM_GETTEXT when Drawing Window Captions

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > Yes, the table windows in the query designer in Access 2003. Access > 2003 works on Windows 2000+. Maybe it's NT4 that doesn't send them then. Anyway, if the app needs them I don't have a problem with adding them back. -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2007

Re: [3/12 WineD3D/DDraw: Forward DDSCL_MULTITHREADED to WineD3D

by H. Verbeet

On 26/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Note: that this patch conflicts with the ddraw thread safety patch. After this > patch here is applied, I will send an updated thread safety patch for the > ddraw implementation > What exactly is this supposed to fix? We already pass the behaviour flags through to IWineD3DImpl_CreateDevice(), so shouldn't wined3d just handle it there?

Feb. 26, 2007

Re: GDI surfaces, GDI heap and wined3d's VideoMemorySize

by Stefan Dösinger

Am Sonntag 25 Februar 2007 21:57 schrieb Rok Mandeljc: > Hey all, > Now, when the game is run with 64MB of VideoMemorySize, upon reaching > the same point, IDirectDrawImpl_CreateNewSurface returns > WINED3DERR_OUTOFVIDEOMEMORY (because of > "IWineD3DDevice_GetAvailableTextureMem(iface) <= _size" check in > D3DCREATERESOURCEOBJECTINSTANCE macro) and intro movie starts playing. > So it seems Baldur's Gate 2 is trying to create as many surfaces as > possible before running out of memory. And the problem arises when > specified memory size is large enough to take up all GDI's heap... Now that seems interesting. Actually, I have never had a 2D application creating that much surfaces, and the old ddraw code only advertised 8 mb of mem. It might be an out of memory somewhere, but not sure how and why. You could try opengl surfaces. Those do not have a DIB section, unless the app calls GetDC on the surface

Feb. 26, 2007

Re: Using InternalGetWindowText Instead of Sending WM_GETTEXT when Drawing Window Captions

by Robert Shearman

Alexandre Julliard wrote: > Robert Shearman <rob(a)codeweavers.com> writes: > > >> Hi Alexandre, >> >> A patch of yours from 2.5 years ago >> (http://source.winehq.org/git/wine.git/?a=commitdiff;h=b72994b6d4a04352e1893…) >> changed the behaviour to not send WM_GETTEXT any more. My experiments >> on Windows show that WM_GETTEXT should be used. Can you remember what >> the reasoning behind the change in this patch was? >> > > Probably to avoid potential deadlocks; I'm not sure there's one > correct way, IIRC Win2k doesn't send them but XP does. Do you have > something that depends on receiving them? Yes, the table windows in the query designer in Access 2003. Access 2003 works on Windows 2000+. -- Rob Shearman

Feb. 26, 2007

Re: Using InternalGetWindowText Instead of Sending WM_GETTEXT when Drawing Window Captions

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > Hi Alexandre, > > A patch of yours from 2.5 years ago > (http://source.winehq.org/git/wine.git/?a=commitdiff;h=b72994b6d4a04352e1893…) > changed the behaviour to not send WM_GETTEXT any more. My experiments > on Windows show that WM_GETTEXT should be used. Can you remember what > the reasoning behind the change in this patch was? Probably to avoid potential deadlocks; I'm not sure there's one correct way, IIRC Win2k doesn't send them but XP does. Do you have something that depends on receiving them? -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2007

wine or wine-preloader exit with code 2 on x86_64

by Escuder Nicolas

Hello, I have build wine with the help of wiki WineOn64bit LDFLAGS="-L/lib32 -L/usr/lib32 -Wl,-rpath,/lib32 -Wl,-rpath,/usr/lib32" ./configure --prefix=/opt/wine --datadir=/usr/share But wine or wine-preloader always return 2 as you can see : [root(a)nico wine-0.9.31]# loader/wine-preloader [root(a)nico wine-0.9.31]# echo $? 2 [root(a)nico wine-0.9.31]# ./wine --version [root(a)nico wine-0.9.31]# echo $? 2 Anyone can help please ? See you, Escuder Nicolas

Feb. 26, 2007

Using InternalGetWindowText Instead of Sending WM_GETTEXT when Drawing Window Captions

by Robert Shearman

Hi Alexandre, A patch of yours from 2.5 years ago (http://source.winehq.org/git/wine.git/?a=commitdiff;h=b72994b6d4a04352e1893…) changed the behaviour to not send WM_GETTEXT any more. My experiments on Windows show that WM_GETTEXT should be used. Can you remember what the reasoning behind the change in this patch was? -- Rob Shearman

Feb. 26, 2007

Re: [2/4 revised] msi: Expand IDL file to contain all OLE automation interfaces.

by Misha Koshelev

On Sun, 2007-02-25 at 22:51 -0600, James Hawkins wrote: > On 2/25/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > > This patch expands the IDL to contain all OLE automation interfaces that > > the freely downloadable MS Windows Installer contains, and adds a > > msiserver_dispids.h file that has define statements for all the dispids. > > > > Changelog: > > > > * msi: Expand IDL file to contain all OLE automation interfaces. > > > > * Copyright (C) 2007 Mike McCormack > + * Misha Koshelev > > You have to repeat the Copyright (C) 2007 part for your name. It seems from doing a find . -name \*.idl -exec head {} \; -print that you are generally correct, but the formatting for copyright notices does vary. dlls/stdole32.tlb/std_ole_v1.idl and std_ole_v2.idl in that directory has: /* * Copyright (C) 2003 Robert Shearman * 2005 Huw Davies which is where I got the idea to do mine that way in the first place. > > + [id(DISPID_INSTALLER_OPENDATABASE)] > + Database* OpenDatabase( > + [in] BSTR > DatabasePath, > + [in] > VARIANT OpenMode); > + [id(DISPID_INSTALLER_SUMMARYINFORMATION), propget] > + SummaryInfo* SummaryInformation( > + > [in] BSTR PackagePath, > + > [in, optional, defaultvalue(0)] long UpdateCount); > + [id(DISPID_INSTALLER_ENABLELOG)] > + void EnableLog( > + [in] BSTR LogMode, > + [in] BSTR LogFile); > > Did you copy and paste this from OleView? This formatting is ridiculous. >

Feb. 26, 2007

Re: dlls: Move the 16-bit dll stubs to the appropriate subdirectories.

by Alexandre Julliard

Brian Gerst <bgerst(a)didntduck.org> writes: >>From 36873109949f308cc9d34f4df9bb0af4c219262b Mon Sep 17 00:00:00 2001 > From: Brian Gerst <bgerst(a)didntduck.org> > Date: Sat, 24 Feb 2007 08:59:48 -0500 > Subject: dlls: Move the 16-bit dll stubs to the appropriate subdirectories. This won't work, they won't be found when running inside the build tree. -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2007

Re: comctl32: rebar[2/3]: WM_SETFONT should send a RBN_HEIGHTCHANGED if necessary (with testcase)

by Alexandre Julliard

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > This allows as to eliminate the third parameter of REBAR_Layout. > From 2edae3656159e84a0366b65e1bd1d13e3089dc97 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Mon, 19 Feb 2007 20:42:08 +0100 > Subject: [PATCH] comctl32: rebar: WM_SETFONT should send a RBN_HEIGHTCHANGED if necessary (with testcase) The tests fail here: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so rebar.c && touch rebar.ok rebar.c:696: Test failed: (int)SendMessage(hRebar, RB_GETROWCOUNT, 0, 0) expected 2 got 1 rebar.c:696: Test failed: invalid rect (notify) (-1,-1) (-1,-1) - expected (0,0) (672,20) make: *** [rebar.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2007

Re: wine and msys rxvt.exe

by Wesley Parish

On Sunday 25 February 2007 22:30, L. Rahyen wrote: > Sunday February 25 2007 07:52、Wesley Parish さんは書きました: > > I installed msys a couple of years back, and decided to test rxvt.exe: > > > > bash-3.1$ wine .wine/drive_c/msys/1.0/bin/rxvt.exe > > libGL warning: 3D driver claims to not support visual 0x4b > > fixme:netapi32:NetWkstaUserGetInfo Level 1 processing is partially > > implemented fixme:advapi:LsaOpenPolicy > > ((null),0x68f478,0x00000001,0x68f494) stub fixme:advapi:LsaClose (0xcafe) > > stub > > fixme:advapi:LsaOpenPolicy ((null),0x68f488,0x000f0fff,0x68f484) stub > > fixme:netbios:NetServerEnum Stub ((null) 101 0x68ef04 -1 0x68ef08 > > 0x68ef0c 8 L"DOMAIN" (nil)) > > fixme:advapi:LsaClose (0xcafe) stub > > fixme:netapi32:NetUserGetInfo Level 3 is not implemented > > fixme:netapi32:NetUserGetInfo Level 3 is not implemented > > failed to load libX11.dllbash-3.1$ > > > > bash-3.1$ wine --version > > wine-0.9.29 > > > > Those are the error messages. > > > > My version of wine is a little old. Have the fixme's been fixed in the > > latest wine? > > Fixmes doesn't mean problems if there is no problems. This is rule of > thumb. If you want to get help please tell what problems you see when > trying to run the software. And if you can give a link to download demo > version of the software (or full version if it's free). Can do, will do. http://www.mingw.org/msys.shtml http://sourceforge.net/project/showfiles.php?group_id=2435 It's free. -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

Feb. 26, 2007

Re: wine and msys rxvt.exe

by Wesley Parish

That is the case. cygwin's just one of several POSIX environments on the Win32 platform, and msys is the other FOSS POSIX environment on Win32. I thought it would be a good test. I will have to upgrade my Wine version, admittedly ... Wesley Parish On Monday 26 February 2007 18:59, John Smith wrote: > If I recall correctly, MSYS is the mingw linux environment emulated on > windows. rxvt would be the terminal used in the msys environment. > > Hopefully this will be of some use, > John Klehm > > On 2/25/07, Robert Shearman <rob(a)codeweavers.com> wrote: > > Wesley Parish wrote: > > > I installed msys a couple of years back, and decided to test rxvt.exe: > > > > > > bash-3.1$ wine .wine/drive_c/msys/1.0/bin/rxvt.exe > > > libGL warning: 3D driver claims to not support visual 0x4b > > > fixme:netapi32:NetWkstaUserGetInfo Level 1 processing is partially > > > > implemented > > > > > fixme:advapi:LsaOpenPolicy ((null),0x68f478,0x00000001,0x68f494) stub > > > fixme:advapi:LsaClose (0xcafe) stub > > > fixme:advapi:LsaOpenPolicy ((null),0x68f488,0x000f0fff,0x68f484) stub > > > fixme:netbios:NetServerEnum Stub ((null) 101 0x68ef04 -1 0x68ef08 > > > > 0x68ef0c 8 > > > > > L"DOMAIN" (nil)) > > > fixme:advapi:LsaClose (0xcafe) stub > > > fixme:netapi32:NetUserGetInfo Level 3 is not implemented > > > fixme:netapi32:NetUserGetInfo Level 3 is not implemented > > > failed to load libX11.dllbash-3.1$ > > > > > > bash-3.1$ wine --version > > > wine-0.9.29 > > > > > > Those are the error messages. > > > > > > My version of wine is a little old. Have the fixme's been fixed in the > > > > latest > > > > > wine? > > > > What is the program supposed to do? > > > > -- > > Rob Shearman -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

Feb. 26, 2007

Re: wine and msys rxvt.exe

by Phil Krylov

On 26/02/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > "Wesley Parish" <wes.parish(a)paradise.net.nz> wrote: > > > failed to load libX11.dll > > Looks like rxvt.exe is linked to an MSys provided X11 libraries > that require a Windows X11 sever to be present and running. That's > a sort of layer on layer and I don't think that there is someone > who wants to make this configuration work. AFAIR MSys's rxvt.exe uses libW11.dll, which implements Xlib API on top of Win32 USER/GDI (no extra X server). However, it could be still difficult (probably because of API name clashes?) Not sure why the message is about libX11.dll - probably it sees $DISPLAY and tries to use real X? -- Ph.

Feb. 26, 2007

Re: wine and msys rxvt.exe

by Dmitry Timoshkov

"Wesley Parish" <wes.parish(a)paradise.net.nz> wrote: > failed to load libX11.dll Looks like rxvt.exe is linked to an MSys provided X11 libraries that require a Windows X11 sever to be present and running. That's a sort of layer on layer and I don't think that there is someone who wants to make this configuration work. -- Dmitry.

Feb. 26, 2007

Re: wine and msys rxvt.exe

by John Smith

If I recall correctly, MSYS is the mingw linux environment emulated on windows. rxvt would be the terminal used in the msys environment. Hopefully this will be of some use, John Klehm On 2/25/07, Robert Shearman <rob(a)codeweavers.com> wrote: > > Wesley Parish wrote: > > I installed msys a couple of years back, and decided to test rxvt.exe: > > > > bash-3.1$ wine .wine/drive_c/msys/1.0/bin/rxvt.exe > > libGL warning: 3D driver claims to not support visual 0x4b > > fixme:netapi32:NetWkstaUserGetInfo Level 1 processing is partially > implemented > > fixme:advapi:LsaOpenPolicy ((null),0x68f478,0x00000001,0x68f494) stub > > fixme:advapi:LsaClose (0xcafe) stub > > fixme:advapi:LsaOpenPolicy ((null),0x68f488,0x000f0fff,0x68f484) stub > > fixme:netbios:NetServerEnum Stub ((null) 101 0x68ef04 -1 0x68ef08 > 0x68ef0c 8 > > L"DOMAIN" (nil)) > > fixme:advapi:LsaClose (0xcafe) stub > > fixme:netapi32:NetUserGetInfo Level 3 is not implemented > > fixme:netapi32:NetUserGetInfo Level 3 is not implemented > > failed to load libX11.dllbash-3.1$ > > > > bash-3.1$ wine --version > > wine-0.9.29 > > > > Those are the error messages. > > > > My version of wine is a little old. Have the fixme's been fixed in the > latest > > wine? > > > > What is the program supposed to do? > > -- > Rob Shearman > > > >

Feb. 26, 2007

Re: We should have a .desktop file for the Uninstaller application

by Vitaliy Margolen

James Liggett wrote: > On Sun, 2007-02-25 at 20:29 -0800, Scott Ritchie wrote: >> As it is, most people don't even know this handy uninstaller applet >> exists. So let's fix that. > Good idea. And while we're at it, why not one for winecfg too? > > James > I was actually thinking about automatically creating those and other entries from wineshelllink whenever it creates Wine menu entry for the first time. However it would have to be aware of the WINEPREFIX and create separate entries for at least winecfg and uninstaller. So it's kind of defeats the propose of making it easy. Vitaliy.

Feb. 26, 2007

Re: We should have a .desktop file for the Uninstaller application

by James Liggett

On Sun, 2007-02-25 at 20:29 -0800, Scott Ritchie wrote: > As it is, most people don't even know this handy uninstaller applet > exists. So let's fix that. Good idea. And while we're at it, why not one for winecfg too? James

Feb. 26, 2007

Re: [3/4 revised] msi: Add partial, expandable OLE automation support.

by James Hawkins

On 2/25/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > This patch adds OLE automation support to MSI. It does this by creating > a wrapper class, which implements any of the OLE automation classes as > long as a function is given which is called from within the wrapper > classes invoke method after appropriate error checking. Basic > functionality is implemented, and it is fairly straightforward to add > the rest as the methods are all already implemented as functions in the > DLL. > +/* + * If you would like to implement a new automation function/object, look towards the bottom of this + * file for the "meat and potatoes" section. + */ + +/* FIXME: I don't know how big this should be */ +#define MAX_MSI_STRING 1000 + +/* + * AutomationObject - "base" class for all automation objects so we don't have to repeat functions. Just + * need to implement Invoke function for each dispinterface that is called from within + * the AutomationObject Invoke function which performs error checking, and pass the new + * function to create_automation_object. + */ + +typedef interface AutomationObject AutomationObject; + +interface AutomationObject { + /* + * VTables - We provide IDispatch, IProvideClassInfo, IProvideClassInfo2, IProvideMultipleClassInfo + */ + const IDispatchVtbl *lpVtbl; + const IProvideClassInfoVtbl *lpvtblIProvideClassInfo; + const IProvideClassInfo2Vtbl *lpvtblIProvideClassInfo2; + const IProvideMultipleClassInfoVtbl *lpvtblIProvideMultipleClassInfo; + + /* Object reference count */ + LONG ref; + + /* Clsid for this class and it's appropriate ITypeInfo object */ + LPCLSID clsid; + ITypeInfo *iTypeInfo; + + /* The MSI handle of the current object */ + MSIHANDLE msiHandle; + + /* A function that is called from IDispatch::Invoke, specific to this type of object. By the + * time this function is called, basic error checking has been done in the AutomationObject + * Invoke function */ + HRESULT (STDMETHODCALLTYPE *funcInvoke)( + AutomationObject* This, + DISPID dispIdMember, + REFIID riid, + LCID lcid, + WORD wFlags, + DISPPARAMS* pDispParams, + VARIANT* pVarResult, + EXCEPINFO* pExcepInfo, + UINT* puArgErr); +}; You went a little comment crazy here (and elsewhere). You should tone it down a bit. Good code explains itself and requires little or no commenting. + /* + * Perform a sanity check on the parameters. + */ + if ( (This==0) || (ppvObject==0) ) + return E_INVALIDARG; + + /* + * Initialize the return parameter. + */ + *ppvObject = 0; + + /* + * Compare the riid with the interface IDs implemented by this object. + */ + if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IDispatch) || IsEqualGUID(riid, This->clsid)) + *ppvObject = This; + else if (IsEqualGUID(riid, &IID_IProvideClassInfo)) + *ppvObject = (IProvideClassInfo*)&(This->lpvtblIProvideClassInfo); + else if (IsEqualGUID(riid, &IID_IProvideClassInfo2)) + *ppvObject = (IProvideClassInfo2*)&(This->lpvtblIProvideClassInfo2); + else if (IsEqualGUID(riid, &IID_IProvideMultipleClassInfo)) + *ppvObject = (IProvideMultipleClassInfo*)&(This->lpvtblIProvideMultipleClassInfo); + + /* + * Check that we obtained an interface. + */ + if ((*ppvObject)==0) + { + TRACE("() : asking for unsupported interface %s\n",debugstr_guid(riid)); + return E_NOINTERFACE; + } + + /* + * Query Interface always increases the reference count by one when it is + * successful + */ + IClassFactory_AddRef(iface); + + return S_OK; +} Way too many comments. It may seem like nitpicking, but the comments clutter up the code and don't provide any useful information. -- James Hawkins

Feb. 26, 2007

Re: [2/4 revised] msi: Expand IDL file to contain all OLE automation interfaces.

by James Hawkins

On 2/25/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > This patch expands the IDL to contain all OLE automation interfaces that > the freely downloadable MS Windows Installer contains, and adds a > msiserver_dispids.h file that has define statements for all the dispids. > > Changelog: > > * msi: Expand IDL file to contain all OLE automation interfaces. > * Copyright (C) 2007 Mike McCormack + * Misha Koshelev You have to repeat the Copyright (C) 2007 part for your name. + [id(DISPID_INSTALLER_OPENDATABASE)] + Database* OpenDatabase( + [in] BSTR DatabasePath, + [in] VARIANT OpenMode); + [id(DISPID_INSTALLER_SUMMARYINFORMATION), propget] + SummaryInfo* SummaryInformation( + [in] BSTR PackagePath, + [in, optional, defaultvalue(0)] long UpdateCount); + [id(DISPID_INSTALLER_ENABLELOG)] + void EnableLog( + [in] BSTR LogMode, + [in] BSTR LogFile); Did you copy and paste this from OleView? This formatting is ridiculous. -- James Hawkins

Feb. 26, 2007

Re: msi: Add full JScript/VBScript support and partial expandable OLE automation support. [PATCH 3/3]

by Misha Koshelev

On Sun, 2007-02-25 at 13:00 +0000, Robert Shearman wrote: > Misha Koshelev wrote: > > +/* Macros to get pointer to AutomationObject) from the other VTables. */ > > > > Typo with extra ")" here. > > > +HRESULT WINAPI SessionImpl_Invoke( > > + AutomationObject* This, > > + DISPID dispIdMember, > > + REFIID riid, > > + LCID lcid, > > + WORD wFlags, > > + DISPPARAMS* pDispParams, > > + VARIANT* pVarResult, > > + EXCEPINFO* pExcepInfo, > > + UINT* puArgErr) > > +{ > > + WCHAR szString[MAX_MSI_STRING]; > > + DWORD dwLen = MAX_MSI_STRING; > > + IDispatch *iDispatch = NULL; > > + MSIHANDLE msiHandle; > > + LANGID langId; > > + UINT ret; > > + INSTALLSTATE iInstalled, iAction; > > > > Some error checking here would be good, like you do in > AutomationObject_Invoke. > > > + > > + switch (dispIdMember) > > + { > > > ... > > +/* > > + * AutomationObject - "base" class for all automation objects so we don't have to repeat functions. Just > > + * need to implement Invoke function for each dispinterface and pass the new function > > + * to create_automation_object. > > + */ > > + > > +typedef struct { > > + /* > > + * VTables - We provide IDispatch, IProvideClassInfo, IProvideClassInfo2, IProvideMultipleClassInfo > > + */ > > + const IDispatchVtbl *lpVtbl; > > + const IProvideClassInfoVtbl *lpvtblIProvideClassInfo; > > + const IProvideClassInfo2Vtbl *lpvtblIProvideClassInfo2; > > + const IProvideMultipleClassInfoVtbl *lpvtblIProvideMultipleClassInfo; > > + > > + /* Object reference count */ > > + LONG ref; > > + > > + /* Clsid for this class and it's appropriate ITypeInfo object */ > > + LPCLSID clsid; > > + ITypeInfo *iTypeInfo; > > + > > + /* The MSI handle of the current object */ > > + MSIHANDLE msiHandle;; > > + > > + /* A function that is called from IDispatch::Invoke, specific to this type of object */ > > + LPVOID funcInvoke; > > +} AutomationObject; > > > > You shouldn't need to expose the implementation details of > AutomationObject outside of automation.c. > > > + > > +/* This is the function that one needs to call to create an automation object. */ > > +extern HRESULT create_automation_object(MSIHANDLE msiHandle, IUnknown *pUnkOuter, LPVOID *ppObj, REFIID clsid, LPVOID funcInvoke); > > > > It is dangerous to use LPVOID as the type to pass a function in. > > > + > > +/* We need to expose these functions because our IActiveScriptSite calls it */ > > +extern HRESULT WINAPI LoadTypeInfo(IDispatch *iface, ITypeInfo **pptinfo, REFIID clsid, LCID lcid); > > +extern HRESULT WINAPI SessionImpl_Invoke(AutomationObject*,DISPID,REFIID,LCID,WORD,DISPPARAMS*,VARIANT*,EXCEPINFO*,UINT*); > > + > > +/* Disp Ids > > + * (not complete, look in msiserver.idl to add more) */ > > +typedef enum { > > + RecordDispId_StringData=1, > > + RecordDispId_IntegerData, > > + RecordDispId_SetStream, > > + RecordDispId_ReadStream, > > + RecordDispId_FieldCount, > > + RecordDispId_IsNull, > > + RecordDispId_DataSize, > > + RecordDispId_ClearData, > > + RecordDispId_FormatText > > +} RecordDispId; > > + > > +typedef enum { > > + ViewDispId_Execute=1, > > + ViewDispId_Fetch, > > + ViewDispId_Modify, > > + ViewDispId_Close, > > + ViewDispId_ColumnInfo, > > + ViewDispId_GetError > > +} ViewDispId; > > + > > +typedef enum { > > + DatabaseDispId_DatabaseState=1, > > + DatabaseDispId_SummaryInformation, > > + DatabaseDispId_OpenView, > > + DatabaseDispId_Commit, > > + DatabaseDispId_PrimaryKeys, > > + DatabaseDispId_Import, > > + DatabaseDispId_Export, > > + DatabaseDispId_Merge, > > + DatabaseDispId_GenerateTransform, > > + DatabaseDispId_ApplyTransform, > > + DatabaseDispId_EnableUIPreview, > > + DatabaseDispId_TablePersistent, > > + DatabaseDispId_CreateTransformSummaryInfo > > +} DatabaseDispId; > > + > > +typedef enum { > > + SessionDispId_Installer=1, > > + SessionDispId_Property, > > + SessionDispId_Language, > > + SessionDispId_Mode, > > + SessionDispId_Database, > > + SessionDispId_SourcePath, > > + SessionDispId_TargetPath, > > + SessionDispId_DoAction, > > + SessionDispId_Sequence, > > + SessionDispId_EvaluateCondition, > > + SessionDispId_FormatRecord, > > + SessionDispId_Message, > > + SessionDispId_FeatureCurrentState, > > + SessionDispId_FeatureRequestState, > > + SessionDispId_FeatureValidStates, > > + SessionDispId_FeatureCost, > > + SessionDispId_ComponentCurrentState, > > + SessionDispId_ComponentRequestState, > > + SessionDispId_SetInstallLevel, > > + SessionDispId_VerifyDiskSpace, > > + SessionDispId_ProductProperty, > > + SessionDispId_FeatureInfo, > > + SessionDispId_ComponentCost > > +} SessionDispId; > > > > See dlls/oleaut32/tests/tmarshal_dispids.h and > dlls/oleaut32/tests/tmarshal.idl for how to use DISPIDs properly. > > > +typedef struct { > > + IActiveScriptSite lpVtbl; > > + AutomationObject *session; > > > > You don't actually access this as anything other than an IDispatch > object, so you might as well change to "IDispatch *session". > > > +LPCWSTR read_script_from_file(LPCWSTR szFile, INT type) > > > > Should be static. > > > +/* JScript or VBScript? */ > > +LPCWSTR progid_from_type(INT type) > > > > Should also be static. > > > + > > +/* > > + * Call a script. This is our meat and potatoes. > > + * - Currently, since the function is relatively new, it will always end up returning S_OK. > > + * Think of it like a bonus feature, we can run the script - great. If we have a problem, > > + * we are no worse off than if this function had not been called. > > + */ > > +DWORD call_script(MSIHANDLE hPackage, INT type, LPCWSTR filename, LPCWSTR function, LPCWSTR action) > > +{ > > + LPCWSTR script = NULL, progId = NULL; > > + HRESULT hr; > > + IActiveScript *iActiveScript = NULL; > > + IActiveScriptParse *iActiveScriptParse = NULL; > > > > I haven't seen this variable notation style before. In Hungarian > notation "p" is used instead of "i" to show a pointer to an object > exposing the interface declared. > I have implemented all the changes you outlined (thanks a lot) in this and your other email, with the exception of the extra error checking in each of the individual Invoke functions as they are called from within AutomationObject::Invoke after the error checking already occurs. What do you think? Thanks Misha p.s. The 5th patch is not a part of my submission, but is just a hack I used to make the IDL file with the dispids using oleview. This patch will make oleview use the DISPID_PARENT_MEMBER notation for ids and will output the include file to standard output. Thought maybe it would be useful for someone.

Feb. 26, 2007

We should have a .desktop file for the Uninstaller application

by Scott Ritchie

As it is, most people don't even know this handy uninstaller applet exists. So let's fix that. Thanks, Scott Ritchie

Feb. 26, 2007

Re: Wine and XP Themes

by Dmitry Timoshkov

"Frank Richter" <frank.richter(a)gmail.com> wrote: > The comctl32 controls all do theming "natively". The subclassing is done > only for control residing in user32 (the motivation was to avoid copying > and pasting all the control implementations from user32 to comctl32, as > Microsoft supposedly did). Sounds like a deja-vu: http://www.winehq.org/?issue=267#Theming%20Revisited -- Dmitry.

Feb. 26, 2007

Re: wined3d: Use application provided fog range when fog is enabled.

by Stefan Dösinger

Am Montag 26 Februar 2007 02:03 schrieb Vitaliy Margolen: > This should fix fog issues with PoP SoT. > --- > dlls/wined3d/state.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) Just wanted to add that this would fix the fixed function Z vs specular color alpha selection with table and vertex fog. Vertex shaders seem to be treated as transformed vertices. That said, the way the fixed function pipeline uses was developed by looking at what games need. The patch Vitaly sent looks good to me, but if there are any regressions I will have to try to write a unit test(though it will be tricky due to the pixel exactness thingy)

Feb. 26, 2007