February 2007 - Wine-Devel - list.winehq.org

Re: [msvcrt] properly align struct _stati64's st_size

by Dmitry Timoshkov

"Hans Leidekker" <hans(a)it.vu.nl> wrote: >> Does the approach used in winbase.h in declaration of WIN32_STREAM_ID to >> align the Size field help? > > That should fix this particular struct but __int64 is used elsewhere > inside and outside of Wine, so maybe the typedef for __int64 itself > should get the alignment attribute? To make sure that Wine headers are free of alignment bugs we have dlls/*/tests/generated.c auto generated by tools/winapi. We just need to add msvcrt types to tests.dat. It looks like a lot of the CRT headers in PSDK (including sys/stat.h) set alignment manually to 8, for example direct.h has the following comment: #ifdef _MSC_VER /* * Currently, all MS C compilers for Win32 platforms default to 8 byte * alignment. */ #pragma pack(push,8) #endif /* _MSC_VER */ -- Dmitry.

Feb. 4, 2007

Re: [msvcrt] properly align struct _stati64's st_size

by Francois Gouget

On Sat, 3 Feb 2007, Damjan Jovanovic wrote: [...] > * Added padding so that struct _stati64's st_size has an offset of 24 > bytes from the beginning of the struct like it should. Does the st_size field get the right offset when using Wine's header with the Windows compiler? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds

Feb. 3, 2007

Bug 4791 - Civ4 crashes because of recent explorer/systray changes

by Fabian Bieler

Hello! I tried to look into Bug 4791 (Civ4 crashes because of recent explorer/systray changes http://bugs.winehq.org/show_bug.cgi?id=4791 ). Pretty early during initialization (before the application creates any windows itsself) a WM_FONTCHANGE message is broadcasted. The only window to which the message gets actually send is the Wine Systray Listener window. The message is immediately pulled by peek_message as a MSG_NOTIFY message. A few seconds later the WM_FONTCHANGE message is pulled from the queue of the Wine Systray Listener window again, this time of the type MSG_CALLBACK. the callback function pointer is a nullpointer resulting in a pagefault. If the Wine Desktop window is set as its own parent (like described in the bugzilla thread), the WM_FONTCHANGE message does not get send to the window and the program starts up fine. Now, I do not really understand the wine messaging system (particularly the difference between notify and callback messages) so I thought maybe somebody here could help me with that or point me to some introduction other than http://winehq.org/site/docs/winedev-guide/c3762#AEN3825 and message.c. Should the fontchange-message really be send to the Wine Systray Listener window? All test were run using wine-0.9.30, civ4 v1.61 with nocd-patch and native msxml3. Fabian

Feb. 3, 2007

Re: [msvcrt] properly align struct _stati64's st_size

by Hans Leidekker

On Saturday 03 February 2007 18:25:05 Hans Leidekker wrote: > inside and outside of Wine, so maybe the typedef for __int64 itself > should get the alignment attribute? To answer my own question: __int64 is not a typedef when compiling with GCC, but a preprocessor define. This way it is possible to use signed/unsigned modifiers as you can on MSVC because it's a builtin type there. We can't add an alignment attribute to the preprocessor define because that will result in compiler errors when the type is used in function declarations. So it seems like we're stuck with fixing individual structs in Wine. Winelib apps will still be affected though. -Hans

Feb. 3, 2007

Re: [lostwages] Update download-deb page with better information, error fixes

by Detlef Riekenberg

On Sa, 2007-02-03 at 01:33 -0800, Scott Ritchie wrote: > I'll change the link to a page on our wiki with the same info and > resend. Please remove the tips for libxxf86dga from http://wiki.winehq.org/UbuntuAMD64 winex11.drv dropped DGA Support at the end of July 2006 Thanks -- By by ... Detlef

Feb. 3, 2007

Re: [lostwages] Update download-deb page with better information, error fixes

by Scott Ritchie

On Sat, 2007-02-03 at 21:52 +0100, Detlef Riekenberg wrote: > On Sa, 2007-02-03 at 01:33 -0800, Scott Ritchie wrote: > > > > > > > > And as a Note on https://wiki.ubuntu.com/I386WineInAmd64 and > > > > https://help.ubuntu.com/community/WineForAMD64 > > > > > > > > The provided automatic installation script includes the sidenet-script. > > > > Please include a BIG WARNING, that this is never supported by winehq > > > > and the users need a clean wine, before they ask for help on #winehq > > > > or wine-users(a)winehq.org > > > > I just fixed it to make it better. I have half a mind to delete all > > mention of sidenet from the page entirely. > > The Sidenet - Script is still there. > I removed all traces of it from the wine wiki page I set up here, which the download-deb page should link to now: http://wiki.winehq.org/UbuntuAMD64 I agree with you and Vitaly about this, by the way. > > Another Tip: > "Next get the libxxf86dga1 package" > > Why that? > DGA was dropped in July 2006: > http://source.winehq.org/git/wine.git/?a=commitdiff;h=98179f06565b7f681d3cd… > > The main problem is that I don't have a 64-bit machine and haven't tested the instructions myself, but as I understand it if Wine was compiled with DGA support (as the 32 bit package was) then it would go nuts if it expected to find the lib and didn't, which the DGA hack was a workaround for. But if it can be eliminated entirely that's really good news. Thanks, Scott Ritchie

Feb. 3, 2007

Re: [lostwages] Update download-deb page with better information, error fixes

by Detlef Riekenberg

On Sa, 2007-02-03 at 01:33 -0800, Scott Ritchie wrote: > > > > > > And as a Note on https://wiki.ubuntu.com/I386WineInAmd64 and > > > https://help.ubuntu.com/community/WineForAMD64 > > > > > > The provided automatic installation script includes the sidenet-script. > > > Please include a BIG WARNING, that this is never supported by winehq > > > and the users need a clean wine, before they ask for help on #winehq > > > or wine-users(a)winehq.org > I just fixed it to make it better. I have half a mind to delete all > mention of sidenet from the page entirely. The Sidenet - Script is still there. Another Tip: "Next get the libxxf86dga1 package" Why that? DGA was dropped in July 2006: http://source.winehq.org/git/wine.git/?a=commitdiff;h=98179f06565b7f681d3cd… IMHO, the only useful things, a wine download script can do is: - download and install wine - optional download and install the gecko-engine - add the "IE 6.0"-Version to the Registry - optional download and install mono - add the ".Net"-Version to the Registry (The above mono provides ".Net 1.1") - optional download and install the corefonts suggest a BUG-Report, when the buildin Fonts are not correct Enable download and installation for native DCOM / native MSI only as a test, when the buildin versions do not work and an active wine BUG-ID is provided. Thanks -- By by ... Detlef

Feb. 3, 2007

Re: Getting Fallout 2 to work well

by Stefan Dösinger

Am Samstag 03 Februar 2007 12:20 schrieb Mirek: > Sorry, my mistake :) How can I download wine from your tree? Yes, your > latest patches from 26.1.2007 fixed this regression, great work! "In my tree" == Those patches :-) > Mirek > > Stefan Dösinger napsal(a): > > Am Freitag 02 Februar 2007 17:15 schrieb Mirek: > >> Getting Fallout 2 to work well > >> Hi, for me Flatout 2 works perfect with latest CVS wine and some Stefan > >> patches from 26.1.2007 > > > > Not the same game. Fallout 2 is an old ddraw game, Flatout 2 is a > > Direct3D9 game afaik. > > > > Did you do a regression test to localize the Flatout 2 performance > > regression? I suspect my StretchRect patch, and I have a fix for it in my > > tree.

Feb. 3, 2007

Re: [msvcrt] properly align struct _stati64's st_size

by Hans Leidekker

On Saturday 03 February 2007 16:15:11 Dmitry Timoshkov wrote: > Does the approach used in winbase.h in declaration of WIN32_STREAM_ID to > align the Size field help? That should fix this particular struct but __int64 is used elsewhere inside and outside of Wine, so maybe the typedef for __int64 itself should get the alignment attribute? -Hans

Feb. 3, 2007

Re: [lostwages] Update download-deb page with better information, error fixes

by Vitaliy Margolen

Scott Ritchie wrote: > On Sat, 2007-02-03 at 00:06 -0700, Vitaliy Margolen wrote: >> Detlef Riekenberg wrote: >>> On Di, 2007-01-30 at 01:09 -0800, Scott Ritchie wrote: >>>> + >>>> +<p>While there is currently no Wine package explicitly designed for >>>> the 64-bit version >>>> +of Ubuntu, there are several hacks that can be used to install the >>>> 32-bit package >>>> +into the 64-bit distribution and have it function normally. See >>>> +<a href="https://wiki.ubuntu.com/I386WineInAmd64">this page on the >>>> Ubuntu wiki</a> >>>> +for more details.</p> >>> IMHO, a link to our own Wiki should be placed on the download-deb page >>> >>> http://wiki.winehq.org/WineOn64bit#head-56206e8bc74083807ffe06ccb471d3f964c… >>> >>> >>> And as a Note on https://wiki.ubuntu.com/I386WineInAmd64 and >>> https://help.ubuntu.com/community/WineForAMD64 >>> >>> The provided automatic installation script includes the sidenet-script. >>> Please include a BIG WARNING, that this is never supported by winehq >>> and the users need a clean wine, before they ask for help on #winehq >>> or wine-users(a)winehq.org >>> >>> >>> You mention sidenet on that page: >>> "If you followed the manual instructions you need to install the Sidenet >>> script" >>> This is wrong. Please remove that line! >>> >>> Even, when the sidenet-script might help some users to run an app, >>> "you need to install the Sidenet script" is wrong! >> I still see that information listed on the mentioned page. I was hopping >> we could get some useful information for Ubuntu-64 users. >> I guess not. I will discourage anyone from referring to the above >> mentioned page because it has sedenet script as a "requirement". It's >> the same stuff as winetools and _brakes_ default Wine configuration. >> >> >> Vitaliy > > I just fixed it to make it better. I have half a mind to delete all > mention of sidenet from the page entirely. Can you explain why is it needed? This is the same _exact_ stuff as winetools! I failed to find a single piece of it that is useful for every day user. However almost every single thing it does, will compromise Wine's integrity. Vitaliy.

Feb. 3, 2007