February 2007 - Wine-Devel - list.winehq.org

Re: Getting Fallout 2 to work well

by Mirek

Hi, for me Flatout 2 works perfect with latest CVS wine and some Stefan patches from 26.1.2007 I have GF6800GS, GLSL enabled, FBO enabled, thread patch (for better sound), ALSA, Pixel and vertex shaders enabled too. There was big performance regression in latest wine release (0.9.30). Mirek Joonas Koivunen napsal(a): > Hello everyone! > > Recently I tried fallout2 again, and for some reason it has again > started working with wine. I searched the archives and it seems there > have been lots of times when it has worked and then again hasn't.. Glad > to see I'm not the only one interested in it :) > > From what I gathered from old postings, there had mainly been issues > with mouse input, from which I at least don't suffer. Nor are there any > more reports (appdb at least) of it not working with the latest 0.9.30 . > > The problem I have is that fallout2.exe takes all the available CPU > power, optimizing that might make other old games work better too. I'm > interested in the task, though I haven't got much of an idea how GDI or > DirectDraw api's work and I'd need some pointers where to start solving > this problem. > > Game taking all of available CPU doesn't make it unplayable. It just > makes mouse movement jerky and overall feeling is that my computer (amd > athlon xp 1800+) is too slow :) AFAIK minimum requirements for this game > were something like P90 with 16MB ram :) > > Some "features" like fading to black and white (going to menu for > example) are simply missing (these were in use a while ago, with older > wine). The rendering of animations slows down (in the combat mode) if > the animation happens to be under the animated cursor. > > I have tried Thunderbirds (from #winehq @ freenode.net > <http://freenode.net>) patch, which when rendering with opengl uses > pixel shaders to do 8bit->32bit conversion. It resulted in a bit more > sluggish (compared to GDI) game play experience. > > Profiling with oprofile (GDI session) shows that most of the time is > used in the game (I suppose it's the "anon" from wine-preload), next > most time consuming is winex11 drivers X11DRV_DIB_SetImageBits which > seems to be doing the conversion. > > I have included a bit cleaned version of opreport -l, only the first 40 > lines. Any help would be appreciated. > > -- > -- Joonas Koivunen > > > ------------------------------------------------------------------------ > >

Feb. 2, 2007

Re: Getting Fallout 2 to work well

by Felix Nawothnig

Joonas Koivunen wrote: > The problem I have is that fallout2.exe takes all the available CPU > power, optimizing that might make other old games work better too. I'm > interested in the task, though I haven't got much of an idea how GDI or > DirectDraw api's work and I'd need some pointers where to start solving > this problem. See http://bugs.winehq.org/show_bug.cgi?id=5526 (at least that's what causing performance issues for Fallout 1 but IIRC they use the same engine) Felix

Feb. 2, 2007

Re: Getting Fallout 2 to work well

by Stefan Dösinger

Am Freitag 02 Februar 2007 08:34 schrieb Joonas Koivunen: > Profiling with oprofile (GDI session) shows that most of the time is used > in the game (I suppose it's the "anon" from wine-preload), next most time > consuming is winex11 drivers X11DRV_DIB_SetImageBits which seems to be > doing the conversion. It seems that you have a game that has problems with the gdi engine(or lack thereof): http://wiki.winehq.org/DIBEngine http://bugs.winehq.org/show_bug.cgi?id=421

Feb. 2, 2007

Re: Conformance test for bug #7286

by Dmitry Timoshkov

"Koshelev, Misha Vladislavo" <mk144210(a)bcm.tmc.edu> wrote: > I copied and pasted that code straight from the StartNotificationThread function in the same > file (well, minus the fact that I am waiting for two events, which is how the refcount problem > is brought about), that is dlls/kernel32/tests/change.c. I will change it in my patch, Thanks. > do I also > need to change it in the existing StartNotificationThread function? If you do please send that fix as a separate patch. -- Dmitry.

Feb. 2, 2007

Getting Fallout 2 to work well

by Joonas Koivunen

Hello everyone! Recently I tried fallout2 again, and for some reason it has again started working with wine. I searched the archives and it seems there have been lots of times when it has worked and then again hasn't.. Glad to see I'm not the only one interested in it :) >From what I gathered from old postings, there had mainly been issues with mouse input, from which I at least don't suffer. Nor are there any more reports (appdb at least) of it not working with the latest 0.9.30. The problem I have is that fallout2.exe takes all the available CPU power, optimizing that might make other old games work better too. I'm interested in the task, though I haven't got much of an idea how GDI or DirectDraw api's work and I'd need some pointers where to start solving this problem. Game taking all of available CPU doesn't make it unplayable. It just makes mouse movement jerky and overall feeling is that my computer (amd athlon xp 1800+) is too slow :) AFAIK minimum requirements for this game were something like P90 with 16MB ram :) Some "features" like fading to black and white (going to menu for example) are simply missing (these were in use a while ago, with older wine). The rendering of animations slows down (in the combat mode) if the animation happens to be under the animated cursor. I have tried Thunderbirds (from #winehq @ freenode.net) patch, which when rendering with opengl uses pixel shaders to do 8bit->32bit conversion. It resulted in a bit more sluggish (compared to GDI) game play experience. Profiling with oprofile (GDI session) shows that most of the time is used in the game (I suppose it's the "anon" from wine-preload), next most time consuming is winex11 drivers X11DRV_DIB_SetImageBits which seems to be doing the conversion. I have included a bit cleaned version of opreport -l, only the first 40 lines. Any help would be appreciated. -- -- Joonas Koivunen

Feb. 2, 2007

Re: Conformance test for bug #7286

by Misha Koshelev

Sending new patch to wine-patches now. Also, the important thing I think about this conformance test (although the checks of course are important too) is that on the current git version this conformance test will completely kill wineserver (which my other patch for this bug fixes). Misha On Fri, 2007-02-02 at 13:15 +0800, Dmitry Timoshkov wrote: > "Misha Koshelev" <mk144210(a)bcm.tmc.edu> wrote: > > > + /* Now create the notification thread */ > > + events[1] = CreateThread(NULL, 0, NotificationThread, (LPVOID)events[0], > > + 0, &threadId); > > + ok(events[1] != INVALID_HANDLE_VALUE, "CreateThread error: %d\n", GetLastError()); > > CreateThread returns NULL on error, not INVALID_HANDLE_VALUE. >

Feb. 2, 2007

RE: Conformance test for bug #7286

by Koshelev, Misha Vladislavo

I copied and pasted that code straight from the StartNotificationThread function in the same file (well, minus the fact that I am waiting for two events, which is how the refcount problem is brought about), that is dlls/kernel32/tests/change.c. I will change it in my patch, do I also need to change it in the existing StartNotificationThread function? Misha -----Original Message----- From: Dmitry Timoshkov [mailto:dmitry(a)codeweavers.com] Sent: Thu 2/1/2007 11:15 PM To: Koshelev, Misha Vladislavo Cc: wine-devel(a)winehq.org Subject: Re: Conformance test for bug #7286 "Misha Koshelev" <mk144210(a)bcm.tmc.edu> wrote: > + /* Now create the notification thread */ > + events[1] = CreateThread(NULL, 0, NotificationThread, (LPVOID)events[0], > + 0, &threadId); > + ok(events[1] != INVALID_HANDLE_VALUE, "CreateThread error: %d\n", GetLastError()); CreateThread returns NULL on error, not INVALID_HANDLE_VALUE. -- Dmitry.

Feb. 2, 2007

Re: Conformance test for bug #7286

by Dmitry Timoshkov

"Misha Koshelev" <mk144210(a)bcm.tmc.edu> wrote: > + /* Now create the notification thread */ > + events[1] = CreateThread(NULL, 0, NotificationThread, (LPVOID)events[0], > + 0, &threadId); > + ok(events[1] != INVALID_HANDLE_VALUE, "CreateThread error: %d\n", GetLastError()); CreateThread returns NULL on error, not INVALID_HANDLE_VALUE. -- Dmitry.

Feb. 2, 2007

Re: [PATCH 3/7] server: Implement object's security descriptor check against token.

by Vitaliy Margolen

Robert Shearman wrote: > Vitaliy Margolen wrote: >> + res = token_access_check( token, obj->sd, *access, &priv, >> &priv_count, >> + &mapping, access, &status ) == >> STATUS_SUCCESS && >> + status == STATUS_SUCCESS; >> + if (!res) >> + { >> + fprintf( stderr, "access check failed\n" ); >> + set_error( STATUS_ACCESS_DENIED ); >> + } > > We don't want anything in the wineserver that can possibly spam the > console, so this should be made conditional on debug_level being non-zero. In case we will have any problems related to security checks this will be really helpful troubleshooting them. > Also, is there any reason you return STATUS_ACCESS_DENIED instead of the > statuses returned by token_access_check? Could you try writing a test > that creates or opens an object with ACCESS_SYSTEM_SECURITY access and > see if it returns STATUS_PRIVILEGE_NOT_HELD or STATUS_ACCESS_DENIED? > The two programs I'm fixing does not require this. Nor do we handle it properly anyway. Vitaliy.

Feb. 1, 2007

Re: [PATCH 1/7] server: Get the primary group from the token.

by Vitaliy Margolen

Robert Shearman wrote: > Vitaliy Margolen wrote: >> list_add_tail( &token->groups, &group->entry ); >> + /* Use first owner capable group as an owner */ >> + if (!token->primary_group && group->owner) >> + token->primary_group = &group->sid; >> + } >> + /* we really need a primary group */ >> + if (!token->primary_group && group_count) >> + { >> + release_object( token ); >> + return NULL; >> } >> > > According to documentation from Microsoft, "the primary group only needs > to be set if POSIX compatibility is required." Also, the default > security descriptor does not require a group - a NULL group is fine. > However access check against token will fail without group being set. So I don't see why can't we require valid group in the security descriptor? Vitaliy.

Feb. 1, 2007