February 2007 - Wine-Devel - list.winehq.org

Re: [PATCH] rasapi32: RasEnumConnections now returns correct buffer size (zero) when there are zero connections available

by James Hawkins

On 2/1/07, John Smith <xixsimplicityxix(a)gmail.com> wrote: > When RasEnumConnections completes the expected behaviour is to have the > needed buffer size stored in *lpcb. Right now wine just leaves it at > whatever size was passed. The windows 2000 behaviour (tested) for when > they're are zero connections, *lpcb is 0. > > Changelog: > RasEnumConnections the buffersize needed reported is now 0 when the number > of connections is 0 > You need to add a test to the test suite for this. -- James Hawkins

Feb. 1, 2007

Office 2003 Installation

by Jan de Mooij

Hi, I have tried to run the office 2003 installation, and in doing that I came across the following issues: - I think we need to undo a patch for msiexec [1]. CommandLineToArgvW does not what we want with slashes in paths followed by an " (this also happens on Windows). Therefore we need to parse the commandline arguments ourselves, what's done by reverting the patch. I can give an example of when it goes wrong if you want. - Office 2003 installation fails with this (from the log): ------------------------ Successfully launched MsiExec.... 2/1/2007 8:30:55 PM Chained install return code: 1603 Exit code was an error. Shutting down chained setup processing. Set Verbose logging for subsequent setup. ------------------------ BUT, when I add WINEDEBUG=+relay,+seh,+tid,+msi,+msiexec, it runs well and installs alright, so I think it's a timing issue. Anyone has experienced this before? What would be the best way to debug this? (I only choose to install Word, I don't know what happens when I select the other Office-applications) Thanks in advance, Jan de Mooij [1] http://source.winehq.org/git/wine.git/?a=blobdiff;f=programs/msiexec/msiexe…

Feb. 1, 2007

Re: Donation for your work on Direct 3D

by H. Verbeet

On 31/01/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Hi, > Thanks for the offer :-) I am employed by CodeWeavers, so its cw where you > should donate to. I think the best way of doing so is to just buy a copy of > CrossOver :-) > > Stefan > > > Hi Stefan and Henry, i would like to send you 35 EUR or 45 USD for your > > work on Direct 3D in wine, how can i do that? Can you send me your > > account number and prefered currency? > Send it to the Wine Party Fund, I'd say. Henri

Feb. 1, 2007

Re: Synchronize code page 20127 table with Windows one

by Dmitry Timoshkov

"Robert Shearman" <rob(a)codeweavers.com> wrote: > If you change a codepage from a unicode.org mapping then you need to add > the changed .TXT file you generated it from to the build tree and update > cpmap.pl to use it. That's not really possible due to a confusing license accompanying the unicode.org mappings, and a policy (until at least now) to not patch unicode.org provided data. Otherwise we have to patch the unicode collation table (I had a patch for it somewhere) as well as some other code page tables (problem with cp1251 table comes to mind as was reported recently). The patch I sent mostly was provided for the reference, since I think that Alexandre won't accept it. Just for the reference I'm attaching both the patched US-ASCII-QUOTES.TXT and a diff against original version US-ASCII-QUOTES.TXT.diff. -- Dmitry.

Feb. 1, 2007

Re: [PATCH 3/7] server: Implement object's security descriptor check against token.

by Robert Shearman

Vitaliy Margolen wrote: > + res = token_access_check( token, obj->sd, *access, &priv, &priv_count, > + &mapping, access, &status ) == STATUS_SUCCESS && > + status == STATUS_SUCCESS; > + if (!res) > + { > + fprintf( stderr, "access check failed\n" ); > + set_error( STATUS_ACCESS_DENIED ); > + } We don't want anything in the wineserver that can possibly spam the console, so this should be made conditional on debug_level being non-zero. Also, is there any reason you return STATUS_ACCESS_DENIED instead of the statuses returned by token_access_check? Could you try writing a test that creates or opens an object with ACCESS_SYSTEM_SECURITY access and see if it returns STATUS_PRIVILEGE_NOT_HELD or STATUS_ACCESS_DENIED? -- Rob Shearman

Feb. 1, 2007

Re: [PATCH 1/7] server: Get the primary group from the token.

by Robert Shearman

Vitaliy Margolen wrote: > list_add_tail( &token->groups, &group->entry ); > + /* Use first owner capable group as an owner */ > + if (!token->primary_group && group->owner) > + token->primary_group = &group->sid; > + } > + /* we really need a primary group */ > + if (!token->primary_group && group_count) > + { > + release_object( token ); > + return NULL; > } > According to documentation from Microsoft, "the primary group only needs to be set if POSIX compatibility is required." Also, the default security descriptor does not require a group - a NULL group is fine. -- Rob Shearman

Feb. 1, 2007

Re: Synchronize code page 20127 table with Windows one

by Robert Shearman

Dmitry Timoshkov wrote: > The problem is that our translation table for code page 20127 is different from > what Windows has, and the ansi_buf get mangled. Attached patch synchronizes our > code page 20127 table with Windows one and fixes the bug. If you change a codepage from a unicode.org mapping then you need to add the changed .TXT file you generated it from to the build tree and update cpmap.pl to use it. -- Rob Shearman

Feb. 1, 2007

Re: Added CoWaitForMultipleHandles to ole32.spec so it will be visible to W indows apps.

by Michael Stefaniuc

Hello John, thanks for the patch. You do not need to add the entry to the ChangeLog file. That is done automaticly using the git changelog entries during the release of a new Wine version. Would you mind resubmitting the patch without that? bye michael John Morris wrote: > From 79b3a4ba86ec3ddbd4b8be7c04bb350d78c78bfa Mon Sep 17 00:00:00 2001 > From: John Morris <mailjohnmorris(a)gmail.com> > Date: Wed, 31 Jan 2007 17:38:04 -0600 > Subject: Added CoWaitForMultipleHandles to ole32.spec so it will be visible to Windows apps. > > --- > ChangeLog | 5 +++++ > dlls/ole32/ole32.spec | 1 + > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index 658036c..ce545d0 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2007-01-31 John Morris <mailjohnmorris(a)gmail.com> > + > + * dlls/ole32/ole32.spec: > + ole32: Add CoWaitForMultipleHandles to spec file so it will be visible to windows apps. > + > 2007-01-24 Vitaliy Margolen <wine-patches(a)kievinfo.com> > > * server/token.c: > diff --git a/dlls/ole32/ole32.spec b/dlls/ole32/ole32.spec > index d775556..3ae0240 100644 > --- a/dlls/ole32/ole32.spec > +++ b/dlls/ole32/ole32.spec > @@ -76,6 +76,7 @@ > @ stub CoUnloadingWOW > @ stdcall CoUnmarshalHresult(ptr ptr) > @ stdcall CoUnmarshalInterface(ptr ptr ptr) > +@ stdcall CoWaitForMultipleHandles(long long long ptr ptr) > @ stdcall CreateAntiMoniker(ptr) > @ stdcall CreateBindCtx(long ptr) > @ stdcall CreateClassMoniker(ptr ptr) > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

Feb. 1, 2007

Re: comdlg32-colordlg fix bgcolor

by Ivan Sinitsin

В сообщении от 1 февраля 2007 07:00 Dmitry Timoshkov написал(a): > "Ivan Sinitsin" <ivan(a)etersoft.ru> wrote: > > The patch corrects background color of a dialogue window " Choose color " > > at copying a triangular marker, the user colors and the predetermined > > colors. Earlier the background about these elements was more dark than > > the basic background of a window. > > > > + SetClassLongPtrW( hwnd, GCLP_HBRBACKGROUND, (LONG_PTR) > > GetSysColorBrush(COLOR_BTNFACE)); > > This fix is not correct, think for instance about different color themes. > Probably CC_PaintTriangle needs to specify the background color of a > triangle explicitly. This line obviously sets color (considering the current scheme), it transfers as a background current system color of the scheme for display of a background of elements of management. Has checked up, at change of color schemes - dialogue is displayed correctly.

Feb. 1, 2007

Re: comdlg32-colordlg fix bgcolor

by Dmitry Timoshkov

"Ivan Sinitsin" <ivan(a)etersoft.ru> wrote: > The patch corrects background color of a dialogue window " Choose color " at > copying a triangular marker, the user colors and the predetermined colors. > Earlier the background about these elements was more dark than the basic > background of a window. > + SetClassLongPtrW( hwnd, GCLP_HBRBACKGROUND, (LONG_PTR) GetSysColorBrush(COLOR_BTNFACE)); This fix is not correct, think for instance about different color themes. Probably CC_PaintTriangle needs to specify the background color of a triangle explicitly. -- Dmitry.

Feb. 1, 2007