February 2007 - Wine-Devel - list.winehq.org

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Felix Nawothnig

Erich Hoover wrote: > Real Name: > Erich Hoover > Description: > Implements the functions ReplaceFileA and ReplaceFileW in kernel32 > (Bug #7544). Also provides conformance test code to ensure proper > functionality. > Changelog: > kernel32: Implement ReplaceFileA/ReplaceFileW Your patch seems to introduce lots of race cons. It's possible these exist on Win32 too but can't we avoid them?

Feb. 26, 2007

Re: [1/12] - [12/12] WineD3D (multithreading)

by Mirek

Hi, this series of patches broke some textures in TES IV: Oblivion, should I create bug in winebugs? I tried some other apps, they looks ok. (bug is here after patch 7/12 and 8/12). Mirek

Feb. 26, 2007

Re: GDI surfaces, GDI heap and wined3d's VideoMemorySize

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > CreateCompatibleDC should be made to fail if the CreateRectRgn call fails. Yes, I committed a fix for that. -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2007

Re: xcopy try 3

by Alexandre Julliard

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes: > diff --git a/programs/xcopy/Makefile.in b/programs/xcopy/Makefile.in > new file mode 100755 All the files you create or modify are marked executable, could you please fix that? -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2007

Re: GDI surfaces, GDI heap and wined3d's VideoMemorySize

by Robert Shearman

Rok Mandeljc wrote: > Hey all, > > I've been experiencing an odd behavior in Baldur's Gate 2; when > "VideoMemorySize" registry key for wined3d is set to anything greater > than 64MB (69MB, actually), it stops before playing intro movie, > printing following line: > err:clipping:CLIPPING_UpdateGCRegion hVisRgn is zero. Please report this. > > Tracing the source of issue by inserting custom traces I got the following: > IDirectDrawImpl_CreateNewSurface -> IWineD3DDeviceImpl_CreateSurface > (decides to use GDI surface) -> IWineGDISurfaceImpl_PrivateSetup -> > IWineD3DSurfaceImpl_GetDC -> > CreateCompatibleDC -> CreateRectRgn -> REGION_CreateRegion -> > GDI_AllocObject -> alloc_large_heap > > alloc_large_heap fails because it can't find next large handle and > returns NULL, which is passed up the chain, where CreateCompatibleDC > puts it in dc->hVisRgn. Then DC_InitDC is called with that dc, which > calls CLIPPING_UpdateGCRegion, and that one finally chokes on it, > printing afore-mentioned line and calling exit(1). > > Now, when the game is run with 64MB of VideoMemorySize, upon reaching > the same point, IDirectDrawImpl_CreateNewSurface returns > WINED3DERR_OUTOFVIDEOMEMORY (because of > "IWineD3DDevice_GetAvailableTextureMem(iface) <= _size" check in > D3DCREATERESOURCEOBJECTINSTANCE macro) and intro movie starts playing. > So it seems Baldur's Gate 2 is trying to create as many surfaces as > possible before running out of memory. And the problem arises when > specified memory size is large enough to take up all GDI's heap... > > Sorry for the long-winded description of the problem, but I'm not sure > where and how this should be fixed (is it wined3d issue or should GDI > have its heap enlarged?), otherwise I'd do it myself... > CreateCompatibleDC should be made to fail if the CreateRectRgn call fails. -- Rob Shearman

Feb. 26, 2007

Re: Wine and XP Themes

by Felix Nawothnig

Frank Richter wrote: > WRT speed: themes usually use alpha-blending extensively; however, the > speed of Wine's AlphaBlend() can almost be measured in geological terms; Why is that? Looking at it it seems to be using XRender - since theming doesn't require Aero and stuff what way would there be to speed it up? (I admit I didn't really read the code. :) Felix

Feb. 26, 2007

Re: [9/12] WineD3D: When multithreading, call glFinish after drawing

by H. Verbeet

Would GL_NV_fence be usefull here?

Feb. 26, 2007

Re: Using InternalGetWindowText Instead of Sending WM_GETTEXT when Drawing Window Captions

by Alexandre Julliard

Robert Shearman <rob(a)codeweavers.com> writes: > Yes, the table windows in the query designer in Access 2003. Access > 2003 works on Windows 2000+. Maybe it's NT4 that doesn't send them then. Anyway, if the app needs them I don't have a problem with adding them back. -- Alexandre Julliard julliard(a)winehq.org

Feb. 26, 2007

Re: [3/12 WineD3D/DDraw: Forward DDSCL_MULTITHREADED to WineD3D

by H. Verbeet

On 26/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Note: that this patch conflicts with the ddraw thread safety patch. After this > patch here is applied, I will send an updated thread safety patch for the > ddraw implementation > What exactly is this supposed to fix? We already pass the behaviour flags through to IWineD3DImpl_CreateDevice(), so shouldn't wined3d just handle it there?

Feb. 26, 2007

Re: GDI surfaces, GDI heap and wined3d's VideoMemorySize

by Stefan Dösinger

Am Sonntag 25 Februar 2007 21:57 schrieb Rok Mandeljc: > Hey all, > Now, when the game is run with 64MB of VideoMemorySize, upon reaching > the same point, IDirectDrawImpl_CreateNewSurface returns > WINED3DERR_OUTOFVIDEOMEMORY (because of > "IWineD3DDevice_GetAvailableTextureMem(iface) <= _size" check in > D3DCREATERESOURCEOBJECTINSTANCE macro) and intro movie starts playing. > So it seems Baldur's Gate 2 is trying to create as many surfaces as > possible before running out of memory. And the problem arises when > specified memory size is large enough to take up all GDI's heap... Now that seems interesting. Actually, I have never had a 2D application creating that much surfaces, and the old ddraw code only advertised 8 mb of mem. It might be an out of memory somewhere, but not sure how and why. You could try opengl surfaces. Those do not have a DIB section, unless the app calls GetDC on the surface

Feb. 26, 2007