March 2007 - Wine-Devel - list.winehq.org

Re: Wine's Wiki Defaced

by Francois Gouget

On Thu, 1 Mar 2007, Felix Nawothnig wrote: > Francois Gouget wrote: > > Someone has defaced Wine's Wiki frontpage. > > Also I have either forgotten my password or the user accounts don't work > > anymore. Could someone look into this? > > Reverted it (no idea about the accounts, I was still logged in). Turns out I was using the wrong username and the wrong password. So this was just a loser who thinks editing a page in a Wiki makes him a hacker! Pretty sad really. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ La terre est une bêta...

March 1, 2007

Re: [6/6] d3d9: Add a mova rounding test

by H. Verbeet

On 01/03/07, Alexandre Julliard <julliard(a)winehq.org> wrote: > "H. Verbeet" <hverbeet(a)gmail.com> writes: > > > Could you run that with +d3d_caps and possibly dump the value of > > caps.VertexShaderVersion? On a default Wine install that test should > > be getting skipped because our ARB shader backend doesn't support > > vs_2_0. > > The version is 3.0, because it's using the software shader on this box: > Ah right. Software shaders don't work at all at the moment, and I don't expect them to start working anytime soon either, so we should probably just remove them completely.

March 1, 2007

Re: [6/6] d3d9: Add a mova rounding test

by Alexandre Julliard

"H. Verbeet" <hverbeet(a)gmail.com> writes: > Could you run that with +d3d_caps and possibly dump the value of > caps.VertexShaderVersion? On a default Wine install that test should > be getting skipped because our ARB shader backend doesn't support > vs_2_0. The version is 3.0, because it's using the software shader on this box: trace:d3d_caps:IWineD3DImpl_GetDeviceCaps (0x158de0)->(Adptr:0, DevType: 1, pCaps: 0x1aa6c0) trace:d3d_caps:IWineD3DImpl_GetAdapterCount (0x158de0): Mostly stub, only returns primary display trace:d3d_caps:WineD3D_CreateFakeGLContext getting context... trace:d3d_caps:WineD3D_CreateFakeGLContext incrementing ref from 0 trace:d3d_caps:IWineD3DImpl_FillGLCaps (0x158df4, 0x7c027110) trace:d3d_caps:IWineD3DImpl_FillGLCaps Filling vendor string Mesa project: www.mesa3d.org trace:d3d_caps:IWineD3DImpl_FillGLCaps found GL_VENDOR ("Mesa project: www.mesa3d.org")->(0x0001) trace:d3d_caps:IWineD3DImpl_FillGLCaps found GL_VERSION ("1.2 (1.5 Mesa 6.5.1)")->6.5->(0x00060005) trace:d3d_caps:IWineD3DImpl_FillGLCaps found GL_RENDERER ("Mesa GLX Indirect")->(0x0020) trace:d3d_caps:IWineD3DImpl_FillGLCaps ClipPlanes support - num Planes=6 trace:d3d_caps:IWineD3DImpl_FillGLCaps Lights support - max lights=8 trace:d3d_caps:IWineD3DImpl_FillGLCaps Maximum texture size support - max texture size=2048 trace:d3d_caps:IWineD3DImpl_FillGLCaps Maximum point size support - max point size=20.000000 trace:d3d_caps:IWineD3DImpl_FillGLCaps GL_Extensions reported: trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_depth_texture trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_imaging trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB imaging support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_multitexture trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB Multitexture support - GL_MAX_TEXTURE_UNITS_ARB=8 trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_point_parameters trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB Point parameters support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_point_sprite trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB point sprite support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_shadow trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_shadow_ambient trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_texture_border_clamp trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB Texture border clamp support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_texture_cube_map trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB Texture Cube Map support trace:d3d_caps:IWineD3DImpl_FillGLCaps IMPLIED: NVIDIA (NV) Texture Gen Reflection support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_texture_env_add trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB Texture Env Add support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_texture_env_combine trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB Texture Env combine support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_texture_env_crossbar trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_texture_env_dot3 trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB Dot3 support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_texture_mirrored_repeat trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB Texture mirrored repeat support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_texture_non_power_of_two trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ARB NPOT texture support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_texture_rectangle trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_transpose_matrix trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ARB_window_pos trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_abgr trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_bgra trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_blend_color trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_blend_func_separate trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_blend_logic_op trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_blend_minmax trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Blend minmax support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_blend_subtract trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_clip_volume_hint trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_copy_texture trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_draw_range_elements trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_fog_coord trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Fog coord support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_framebuffer_object trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Frame Buffer Object support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_multi_draw_arrays trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_packed_pixels trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_point_parameters trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Point parameters support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_polygon_offset trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_rescale_normal trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_secondary_color trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Secondary coord support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_separate_specular_color trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_shadow_funcs trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_stencil_wrap trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Stencil wrap support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_subtexture trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_texture trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_texture3D trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT_texture3D support trace:d3d_caps:IWineD3DImpl_FillGLCaps Max texture3D size: 8 trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_texture_edge_clamp trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_texture_env_add trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Texture Env Add support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_texture_env_combine trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Texture Env combine support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_texture_env_dot3 trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Dot3 support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_texture_lod_bias trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: EXT Texture LOD bias support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_texture_object trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_texture_rectangle trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_EXT_vertex_array trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_APPLE_packed_pixels trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ATI_texture_env_combine3 trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ATI Texture Env combine (3) support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ATI_texture_mirror_once trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: ATI Texture Mirror Once support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_ATIX_texture_env_combine3 trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_IBM_texture_mirrored_repeat trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_INGR_blend_func_separate trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_MESA_pack_invert trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_MESA_ycbcr_texture trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_NV_blend_square trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_NV_point_sprite trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_NV_texgen_reflection trace:d3d_caps:IWineD3DImpl_FillGLCaps FOUND: NVIDIA (NV) Texture Gen Reflection support trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_NV_texture_rectangle trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_SGIS_generate_mipmap trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_SGIS_texture_border_clamp trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_SGIS_texture_edge_clamp trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_SGIS_texture_lod trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_SGIX_depth_texture trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_SGIX_shadow trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_SGIX_shadow_ambient trace:d3d_caps:IWineD3DImpl_FillGLCaps - GL_SUN_multi_draw_arrays trace:d3d_caps:IWineD3DImpl_FillGLCaps GLX_Extensions reported: trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_ARB_get_proc_address trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_ARB_multisample trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_EXT_import_context trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_EXT_visual_info trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_EXT_visual_rating trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_MESA_copy_sub_buffer trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_OML_swap_method trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_SGI_make_current_read trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_SGIS_multisample trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_SGIX_fbconfig trace:d3d_caps:IWineD3DImpl_FillGLCaps - GLX_EXT_texture_from_pixmap trace:d3d_caps:WineD3D_ReleaseFakeGLContext decrementing ref from 1 trace:d3d_caps:IWineD3DImpl_GetDeviceCaps Software vertex shader version 3.0 enabled trace:d3d_caps:IWineD3DImpl_GetDeviceCaps Pixel shader functionality not available -- Alexandre Julliard julliard(a)winehq.org

March 1, 2007

DIB Engine & GSoC

by Benoit Pradelle

Hi, I would like participate to the Google Summer Of Code with Wine by implementing a DIB Engine. I've searched a lot of informations about the DIB Engine but i still got one question : for you, how important is a DIB Engine in Wine ? Ben.

March 1, 2007

Re: user32: add more tests for GetUpdateRect()

by Dmitry Timoshkov

"Clinton Stimpson" <cjstimpson(a)utwire.net> wrote: > Here's another test to add to test_GetUpdateRect(). > This case doesn't uses CS_PARENTDC as suggested in bug #7360. > +static LRESULT WINAPI test_GetUpdateRect_window_procA(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + return DefWindowProc(hwnd, msg, wparam, lparam); > +} You can just specify 'cls.lpfnWndProc = DefWindowProcA;' to avoid useless test_GetUpdateRect_window_procA body. > + cls.style = 0; > + cls.lpfnWndProc = test_GetUpdateRect_window_procA; > + cls.cbClsExtra = 0; > + cls.cbWndExtra = 0; > + cls.hInstance = GetModuleHandleA(0); > + cls.hIcon = 0; > + cls.hCursor = LoadCursorA(0, (LPSTR)IDC_ARROW); > + cls.hbrBackground = GetStockObject(WHITE_BRUSH); > + cls.lpszMenuName = NULL; > + cls.lpszClassName = "CSParentDCWindowClass"; Strange class name since it doesn't use CS_PARENTDC style at all. -- Dmitry.

March 1, 2007

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

by Erich Hoover

> I see your point. However, since the function you are implementing is in > kernel32 anyway you could abstract it away and make both functions > (CopyFile and ReplaceFile) call some internal function. That way you > would get rid of the locking completly which is argueably somewhat ugly. On closer inspection, CreateFile actually seems to take care of this with the "security attributes" and "template" parameters. It does not look like the security attributes are implemented yet (or the call to get the security attributes for a file) but since CreateFile already handles this it seems unnecessary to add a new break-out function. You will likely find the attached more to your liking. Erich Hoover ehoover(a)mines.edu On 2/28/07, Felix Nawothnig <flexo(a)holycrap.org> wrote: > > Erich Hoover wrote: > >>>> The "right" way would probably to do the copying yourself by > >>>> read/write.. but I dunno. > >>> Except that it would ignore the permissions issues that have already > >>> been coded into the copy routines (and any updates that may eventually > >> No, CreateFile (and friends) does the permissions checks (which you > >> would still have to call). > > That was worded poorly, Copy/Move already handle copying file attributes > > > and I imagine would eventually implement copying the access control list > > information. Implementing ReplaceFile as calls to either Copy or Move > > takes these issues into account. > > I see your point. However, since the function you are implementing is in > kernel32 anyway you could abstract it away and make both functions > (CopyFile and ReplaceFile) call some internal function. That way you > would get rid of the locking completly which is argueably somewhat ugly. > > Felix > >

March 1, 2007

Re: Unknown issue with test.winehq.org

by Paul Vriens

Alexandre Julliard wrote: > Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > >> exception: 42 tests executed (0 marked as todo, 0 failures), 0 skipped. >> exception: 279 tests executed (0 marked as todo, 5 failures), 0 skipped. >> >> The first one triggers the 'end of this test' in dissect. The second >> one is thus not accepted as dissect expects a 'start' line (and a line >> in between actually). >> >> The question now is: should dissect handle these cases or is this >> particular test-case wrong? > > It's because some of the tests are run in a child process. dissect > should probably handle it, ideally by reporting the sum of the test > counts as the results for the whole test. > So what's the difference between this one and for example the following ones running in child processes: kernel32:process start dlls/kernel32/tests/process.c 1.10 tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/process.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. process: 396 tests executed (0 marked as todo, 6 failures), 0 skipped. or: msvcrt:file start dlls/msvcrt/tests/file.c 1.45 tests/file.c: 3 tests executed (0 marked as todo, 0 failures), 0 skipped. tests/file.c: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 361 tests executed (0 marked as todo, 0 failures), 0 skipped. or better yet: shell32:shellpath start dlls/shell32/tests/shellpath.c 1.16 tests/shellpath.c: 10 tests executed (0 marked as todo, 4 failures), 0 skipped. tests/shellpath.c: 4 tests executed (0 marked as todo, 0 failures), 0 skipped. shellpath: 452 tests executed (0 marked as todo, 0 failures), 0 skipped. Obviously the start of line is a filename for these ones, whereas the start of the line for the exception one is the test itself. Should we consolidate the above ones as well? I think yes, cause the shell32 example is reflected as 0 errors on test.winehq.org. Cheers, Paul.

March 1, 2007

Re: [2/6] winex11.drv: Try to get an opengl visual with aux buffers

by Vitaliy Margolen

> I don't know if that patch wasn't applied because other patches of my patchset > weren't applied, or because something is wrong with this patch. If something > is wrong with this patch please tell me > @@ -3083,33 +3083,44 @@ BOOL X11DRV_SwapBuffers(X11DRV_PDEVICE *physDev) > XVisualInfo *X11DRV_setup_opengl_visual( Display *display ) > { > XVisualInfo *visual = NULL; > - /* In order to support OpenGL or D3D, we require a double-buffered visual and stencil buffer support, */ > - int dblBuf[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_DOUBLEBUFFER, None}; > + /* In order to support OpenGL or D3D, we require a double-buffered visual and stencil buffer support, > + * WineD3D and Some applications can make use of aux buffers > + */ > + int dblBuf[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_AUX_BUFFERS, 1, GLX_DOUBLEBUFFER, None}; [skip] > + int dblBuf2[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_DOUBLEBUFFER, None}; [skip] > + int dblBuf3[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_STENCIL_SIZE, 8, GLX_DOUBLEBUFFER, None}; [skip] > + int dblBuf4[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_DOUBLEBUFFER, None}; 3 levels was bad enough. Can we put this in an array and iterate through it instead of adding more levels? Specific comments can go there as well. Vitaliy.

March 1, 2007

Re: ntdll: Some code cleanup

by Vitaliy Margolen

Felix Nawothnig wrote: > - if (last) > - { > - LdrShutdownProcess(); > - exit( exit_code ); > - } > - else > - { > - LdrShutdownThread(); > - server_exit_thread( exit_code ); > - } > + NtTerminateThread( GetCurrentThread(), func( arg ) ); > + exit(0); /* To avoid a compiler warning, never reached. */ server_exit_thread() and NtTerminateThread() (which calls server_abort_thread()) are not the same things! Former gracefully exits the current thread freeing it's memory. Later rips it out from the process without freeing any resources. Needless to say you can't do that. Vitaliy.

March 1, 2007

Re: kernel32: Remove server-call from ExitThread()

by Dmitry Timoshkov

"Felix Nawothnig" <flexo(a)holycrap.org> wrote: > - if (last) > - { > - LdrShutdownProcess(); > - exit( code ); > - } > - else RtlExitUserThread( code ); > + TerminateThread( GetCurrentThread(), code ); > + exit(code); /* To avoid a compiler warning, never reached. */ > } New code now calls exit() unconditionally killing the whole process. If you follow the TerminateThread way you will notice that exit() is being already called on its time. -- Dmitry.

March 1, 2007