March 2007 - Wine-Devel - list.winehq.org

Re: Excluding a Windows version from the tests

by Carl-Daniel Hailfinger

On 30.03.2007 09:14, Alexandre Julliard wrote: > Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > >> Shouldn't then the wine code do a version check too and behave differently if >> the winver is set to win98? > > Only if there is an app that does the same version check and depends > on both behaviors. It's very unlikely that an app would want to crash > when the version is win98, so we don't need to replicate that behavior. Wasn't there some weird installshield behaviour where we had to crash like windows to make installshield happy? Regards, Carl-Daniel

March 30, 2007

Re: Stub for all raw input functions

by Dmitry Timoshkov

"Kovács András" <andras(a)csevego.net> wrote: > +LRESULT WINAPI DefRawInputProc( PRAWINPUT *paRawInput, INT nInput, UINT cbSizeHeader ) > +{ > + FIXME("(paRawInput=%p, nInput=%d, cbSizeHeader=%d) stub!\n", *paRawInput, nInput, cbSizeHeader); > + > + return S_OK; > +} Although MSDN documents that on success DefRawInputProc returns S_OK, that's most likely a misguided documenters error: S_OK is an HRESULT and an OLE error value, while it's user32 and return type is LRESULT. So IMO simply returning 0 should be OK here. > +BOOL WINAPI RegisterRawInputDevices( PRAWINPUTDEVICE pRawInputDevices, UINT uiNumDevices, UINT cbSize ) > +{ > + FIXME("(pRawInputDevices=%p, uiNumDevices=%d, cbSize=%d) stub!\n", pRawInputDevices, uiNumDevices, cbSize); > + > + return TRUE; > +} Probably this stub should return FALSE. > +UINT WINAPI GetRawInputBuffer( PRAWINPUT pData, PUINT pcbSize, UINT cbSizeHeader ) > +{ > + FIXME("(pData=%p, pcbSize=%p, cbSizeHeader=%d) stub!\n", pData, pcbSize, cbSizeHeader); > + > + return 0; > +} MSDN says that an error indicator is -1, not 0, same as for others raw input APIs. -- Dmitry.

March 30, 2007

RE: Jason Edmeades : xcopy: Add support for COPYCMD override and fix /-y.

by Alexander.Farber＠nokia.com

Hello, wouldn't it be nicer to use sizeof(copyCmd) here? if (GetEnvironmentVariable(COPYCMD, copyCmd, MAXSTRING)) { There are many spots like this in wcmdmain.c Regards Alex > -----Original Message----- > From: wine-cvs-bounces(a)winehq.org > [mailto:wine-cvs-bounces(a)winehq.org] On Behalf Of ext Alexandre Julliard .... > > + /* Preinitialize flags based on COPYCMD */ > + if (GetEnvironmentVariable(COPYCMD, copyCmd, MAXSTRING)) { > + if (wcsstr(copyCmd, PROMPTSTR1) != NULL || > + wcsstr(copyCmd, PROMPTSTR2) != NULL) { > + flags |= OPT_NOPROMPT; > + } > + } > + >

March 30, 2007

Re: extracting info from a minidump via winedbg

by Eric Pouech

2007/3/29, Dennis Schridde <devurandom(a)gmx.net>: > > Am Donnerstag, 29. März 2007 schrieb Eric Pouech: > > Dennis Schridde a écrit : > > > Hello Wine users! > > > > > > I've got a minidump from a ("real") Windows user of our game and would > > > like to extract information from it using winedbg. > > > > > > > > > The information winedbg gives me by default, is this: > > > > > > [...] > > > > > > Which is pretty rare. > > > Via addr2line I can translate the backtrace to possibly valid > locations > > > in our sourcefiles. > > > > > > > > > My questions are: > > > - Why doesn't winedbg extract the sourcecode locations itself? > > > > because it needs the original PE files (.exe, .dll) to get to the debug > > information > > those files must be seated in directories listed in the _NT_SYMBOL_PATH > > environment variable > Maybe I am just doing it wrong, but > _NT_SYMBOL_PATH=. winedbg warzone2100.mdmp > doesn't change anything... (Even supplying the full path doesn't.) > The exe (not all dlls, because I don't have a copy of the user's system) > is of > course in the working directory. But the debug info is not always in the .exe itself. the .exe can contain only a pointer to the debug info what does 'winedbg -x debug -g warzone2100.exe' give ? > > - Why doesn't winedbg show me the other information included in the > > > minidump, like the loaded modules, commandline options or version > > > information? > > > > 'info share' should do part of it... winedbg doesn't show the command > > line info nor options > That only shows me the memory ranges of some modules. The minidump > includes > more info, like the paths to dlls and similar. I am not sure whether it > includes version information, but it certainly contains the commandline > used > to start the app. > > > other thing you can do is to use winedump (man winedump) > How do I do this? And what will it provide? I tried > winedump -G warzone2100.exe > but I have no idea what I shall do with that tremedously long and cryptic > list. winedump warzone2100.mdmp > > - How can I get the parameters to the last called function(s)? > > > > see above for debug info > If the general debug info worked, that would also show me the function > parameters? yes -- Eric Pouech

March 30, 2007

Re: [1/2 RESEND] gdi32: Add failing metrics test for negative font widths

by Alexandre Julliard

Felix Nawothnig <flexo(a)holycrap.org> writes: > Please tell me if this still fails on your box (both versions pass on mine). Now it succeeds where it shouldn't... ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:541: Tests skipped: Symbol is not installed so skipping this test font.c:784: Tests skipped: Arial is not installed font.c:1094: Tests skipped: Arial is not installed font.c:1228: Tests skipped: Arial Black is not installed font.c:1228: Tests skipped: Symbol is not installed font.c:1688: Tests skipped: Arial Black or Symbol/Wingdings is not installed font.c:1514: Test succeeded inside todo block: gm1=62,57,0,60,61,0 gm2=62,57,0,60,61,0 make: *** [font.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

March 30, 2007

Re: winex11.drv: Remove an unnecessary XFlush().

by Alexandre Julliard

Huw Davies <huw(a)codeweavers.com> writes: > --- a/dlls/winex11.drv/xrender.c > +++ b/dlls/winex11.drv/xrender.c > @@ -596,7 +596,6 @@ void X11DRV_XRender_UpdateDrawable(X11DRV_PDEVICE *physDev) > if(physDev->xrender->pict) > { > TRACE("freeing pict = %lx dc = %p\n", physDev->xrender->pict, physDev->hdc); > - XFlush(gdi_display); > pXRenderFreePicture(gdi_display, physDev->xrender->pict); > physDev->xrender->pict = 0; > } This causes a test failure here: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so header.c && touch header.ok X Error of failed request: BadPixmap (invalid Pixmap parameter) Major opcode of failed request: 54 (X_FreePixmap) Resource id in failed request: 0x2400023 Serial number of failed request: 461 Current serial number in output stream: 472 make: *** [header.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

March 30, 2007

Re: [PATCH 13/18] XCOPY: Add support for /EXCLUDELIST:file1+file2 etc

by Alexandre Julliard

Jason Edmeades <us(a)edmeades.me.uk> writes: > + /* Loop through testing each exclude line */ > + while (pos) { > + if (wcsstr(copyFromUpper, pos->name) != NULL) { > + WINE_TRACE("Skipping file as matches exclude '%s'\n", > + wine_dbgstr_w(pos->name)); wcsstr() doesn't seem the right way to compare file names. You probably want to do a wcsicmp() of the end of the name or something like that. -- Alexandre Julliard julliard(a)winehq.org

March 30, 2007

Re: [PATCH 18/18] XCOPY: Add help

by Joerg Mayer

Umm, is there a specific reason why you created the mails by replying to the previous patch? This doesn't look that good with mailers that keep track of replies and e.g. indents them. ciao Joerg

March 30, 2007

Re: Excluding a Windows version from the tests

by Alexandre Julliard

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > Shouldn't then the wine code do a version check too and behave differently if > the winver is set to win98? Only if there is an app that does the same version check and depends on both behaviors. It's very unlikely that an app would want to crash when the version is win98, so we don't need to replicate that behavior. -- Alexandre Julliard julliard(a)winehq.org

March 30, 2007

Re: Declare another bunch of raw input structures and constants

by Dmitry Timoshkov

"Kovács András" <andras(a)csevego.net> wrote: > +typedef struct tagRAWMOUSE { > + USHORT usFlags; > + union { > + ULONG ulButtons; > + struct { > + USHORT usButtonFlags; > + USHORT usButtonData; > + } s; > + } u; You have to use DUMMYSTRUCTNAME and DUMMYUNIONNAME instead of s and u. Also please use 4 spaces indents instead of strange mix of 2 + 7 + 2. -- Dmitry.

March 30, 2007